Development issueshttps://lab.civicrm.org/groups/dev/-/issues2019-10-28T08:08:37Zhttps://lab.civicrm.org/dev/core/-/issues/1324Customfields attached to addresses break the profile page2019-10-28T08:08:37ZVangelisPCustomfields attached to addresses break the profile page## General
When we set an address customfield on an address and then we add that field into a profile, the profile page breaks on edit mode.
Returning error: `DB Error: no such field`
## How to reproduce
On https://dmaster.demo.civicrm...## General
When we set an address customfield on an address and then we add that field into a profile, the profile page breaks on edit mode.
Returning error: `DB Error: no such field`
## How to reproduce
On https://dmaster.demo.civicrm.org (CiviCRM 5.20.alpha1) :
* Create a new CustomGroup and assign it to the entity 'Address'
* Create a new customfield (for example of type textfield)
* Populate the field with some dummy information
* Create a new profile and add 2 fields:
* Street Address
* Your newly created customfield
* Click on 'More -> Use edit mode'
* The page should break with error `DB Error: no such field`
## Background
It seems that the issue starts here: https://lab.civicrm.org/dev/core/blob/master/CRM/Contact/BAO/Contact.php#L1784
and then goes here: https://lab.civicrm.org/dev/core/blob/master/CRM/Contact/BAO/Query.php#L1036
and the actual join should take place somewhere here: https://lab.civicrm.org/dev/core/blob/master/CRM/Contact/BAO/Query.php#L1307
In short: There is an additional field, the id of the customtable that is holding the customfield in the select query that is not being joined properly (join is actually missing) from the constructed query.5.20.0https://lab.civicrm.org/dev/core/-/issues/1319No Household Member Relationship Created when an Individual shares a relation...2020-02-19T20:48:07ZalicefruminNo Household Member Relationship Created when an Individual shares a relationship with a householdWhen editing a Contacts Address:
IF one clicks "Use another contact's address"
AND then selects a HOUSEHOLD contact to share an address with
THEN the address is shared BUT a **household member relationship is NOT created**.
The S...When editing a Contacts Address:
IF one clicks "Use another contact's address"
AND then selects a HOUSEHOLD contact to share an address with
THEN the address is shared BUT a **household member relationship is NOT created**.
The Shared Address help text says: "If you link an individual's address to an organization, an employee-employer relationship will be automatically created. **If you link an individual's address to a household, a household member relationship is created.**"
Which leads me to believe this is a regression. It seems the functionality for linking an individual's address to an organization has been enhanced specifically:
When one clicks "Use another contact's address"
AND then selects a ORGANIZATION contact to share an address with
THEN a "Set this organization as current employer" checkbox appears
IF checked then a relationship is created... if not no relationship is created
as discussed [here](https://github.com/civicrm/civicrm-core/pull/12574)
Perhaps a similar checkbox should appear when sharing a household address.
![sharedAddressHelpText](/uploads/9800c3df1b22b02f4342ccf05fb141cc/sharedAddressHelpText.png)5.23.0https://lab.civicrm.org/dev/user-interface/-/issues/11Remove CiviCRM install count from dashboard2023-12-02T18:42:58ZnicolRemove CiviCRM install count from dashboardIt was said at the 2019 Summit/Sprint that a requirement to get CiviCRM listed in the Wordpress plugins directory was to turn off statistics pingback on new installs by default - and this happened a few months ago (can anyone confirm? @c...It was said at the 2019 Summit/Sprint that a requirement to get CiviCRM listed in the Wordpress plugins directory was to turn off statistics pingback on new installs by default - and this happened a few months ago (can anyone confirm? @cividesk?). As a result all new installs of CiviCRM are not pinging stats collection so the total site count appears to have fallen in the same period from near 11,000 six months ago to around 10,000 today:
![image](/uploads/0630494d9e7df38a00001212afca3d9e/image.png)
Perhaps there is is another cause, but is it time to just remove this stat from the main CiviCRM dashboard? This was a post-it proposal put to the UX/UI group during the sprint as the notice seems to be giving a false impression of the project being in decline. Not sure what this would entail but it appears linked to this template: [templates/CRM/Dashlet/Page/GettingStarted.tpl](https://github.com/civicrm/civicrm-core/blob/8b9a8f4abb25cfa7a498eaaa3e459e4d313e350a/templates/CRM/Dashlet/Page/GettingStarted.tpl) & this file: [CRM/Dashlet/Page/GettingStarted.php](https://github.com/civicrm/civicrm-core/blob/bdeb5d154507df2dc913fc1ee9aaedfaa4721c04/CRM/Dashlet/Page/GettingStarted.php).bgmbgmhttps://lab.civicrm.org/dev/core/-/issues/1316Workflow templates - Update 'Thank You' & other text corrections2019-10-24T21:27:09Zmagnolia61Workflow templates - Update 'Thank You' & other text correctionsThere are a few texts in the workflow message templates that are too specific for use in different circumstances. Since we are making changes to the system workflow templates I would like to address these in this round
Specifically I wo...There are a few texts in the workflow message templates that are too specific for use in different circumstances. Since we are making changes to the system workflow templates I would like to address these in this round
Specifically I would like to adjust the templates dealing with contribution and membership
These templates have the text: "**Thank you for your support**". But this is too specific. The contribution offline-receipt could be sent because someone paid for a workshop they are attending. They are not supporting anything, they just paid for what the registered for. The same with the membership. Not all memberships are to support the cause of the organisation. It would be better to describe the object of the gratitude more general.
Some examples of proposed changes.
1. The contribution receipt template had:
`'Thank you for your support',`
But the status can be anything, also pending (which does make the thanks a bit confusing)
Better and more neutral would be:
`'Below you will find a receipt for this contribution.',`
(It would even be better if the table would include the contribution status here)
2. Another example. The event online receipt had:
`Thank you for your participation.`
But the status can also be pending, and anyway chances are high this is all still before the event.
Better and more neutral would be:
`Thank you for your registration.`
3. Thirdly, the membership receipts had:
`Thank you for your support.`
But the membership could also just be something people pay for on a regular basis, without the notion of supporting the 'cause' of the organisation. There are many variations of the membership function.
Better and more neutral here would be:
`Thank you for this contribution.`
4. Finally, the participant confirm template
I added {ts} to the 'click here to confirm text' in https://github.com/civicrm/civicrm-core/pull/15491
But the mail itself is lacking an introductory text. I would propose the following:
`Your registration was waitlisted but we can confirm you can now complete the registration process.`
I believe all these changes (and also some grammar corrections will benefit the readability of the standard texts and make these of more general use for more scenarios.
Cheers, Richard5.20.0magnolia61magnolia61https://lab.civicrm.org/dev/core/-/issues/1311Help bubble on directories/resource url pages has some hidden diagnostic powers2023-04-15T05:03:32ZDaveDHelp bubble on directories/resource url pages has some hidden diagnostic powersThere's a help icon in the intro section on both the administer - system settings - directories and resource urls pages. It pops up a box that tells you what civi thinks things like `[civicrm.root]` evaluate to. This can be very helpful ...There's a help icon in the intro section on both the administer - system settings - directories and resource urls pages. It pops up a box that tells you what civi thinks things like `[civicrm.root]` evaluate to. This can be very helpful for diagnostic use, but there's nothing suggesting that the help icon has those powers.
![screenshot](/uploads/f972af49f9cc6115f1c9ed0a00e1c194/screenshot.gif)
I'm thinking it might be more obvious as a button somewhere lower down in body of the page, called something like "Explain shortcodes". Quick mockup:
![mockup](/uploads/819eb9783b4722ba9372cca177a48544/mockup.gif)
Thoughts?https://lab.civicrm.org/dev/core/-/issues/1307Add tracking table for import jobs2022-06-10T09:06:03ZeileenAdd tracking table for import jobsA current blocker to refactoring the import jobs to use queue processes / non-timeout UI methods is persistence of output data.
We discussed this in Barcelona and came up with the following proposal
1) create a new table civicrm_user_j...A current blocker to refactoring the import jobs to use queue processes / non-timeout UI methods is persistence of output data.
We discussed this in Barcelona and came up with the following proposal
1) create a new table civicrm_user_job with the fields
- contact_id (or created_id?)
- job_identifier (or name?) - we probably would need this to be unique but the BAO could handle appending to it if it is not.
- start_timestamp
- end_timestamp
- job_hash - used for file naming
2) files created as a result of the job could have a standard naming convention - e.g
import_{job_hash}_validation_errors.csv
import_{job_hash}_duplicates.csv
3) We would need a cleanup job which would also remove the files - e.g more than one week old
4) The UserJob BAO would obviously run pre & post hooks - allowing tracking by extensions
5) Permissioning of file retrieval can be via Attachment api - Tim thinks we know how that works but he is wrong.
6) When viewing the results of the import this creates options for us to potentially present a user with their imports (plural) results & for them to choose which they want. (Perhaps exposing the job_idenfier field to them would help here?
@totten @pfigel @seamuslee5.51.0https://lab.civicrm.org/dev/user-interface/-/issues/10Ability to edit Contribution page "Confirm Contribution" button2023-11-23T07:35:02ZHeatherOliverAbility to edit Contribution page "Confirm Contribution" buttonIt would be useful to be able to control what the submission button says on a Contribution page in the same way that you can control the "Register now" button in events.
"Confirm Contribution" isn't very meaningful. For example:
Member...It would be useful to be able to control what the submission button says on a Contribution page in the same way that you can control the "Register now" button in events.
"Confirm Contribution" isn't very meaningful. For example:
Membership registration, Standard donation page and Campaign donation page you may wish to customise this button.https://lab.civicrm.org/dev/core/-/issues/1300Sorting Extensions list alphabetically breaks dropdown expansion2022-12-27T05:03:31ZJoe McLaughlinSorting Extensions list alphabetically breaks dropdown expansionAt ~/civicrm/admin/extensions?reset=1, sorting the Extension list by the Extension name (key) into alphabetical order breaks the expansion/window opening when clicking on the drop down arrow. Expansion via the dropdown only seems to work...At ~/civicrm/admin/extensions?reset=1, sorting the Extension list by the Extension name (key) into alphabetical order breaks the expansion/window opening when clicking on the drop down arrow. Expansion via the dropdown only seems to work with the default sort order (which seems totally random BTW :) ) .https://lab.civicrm.org/dev/translation/-/issues/31civicrm_mailing_component name is limited to 64 charaters, missing label2020-05-18T00:29:46Zbgmcivicrm_mailing_component name is limited to 64 charaters, missing labelThe `civicrm_mailing_component` has a `name` column limited to varchar(64). This name column is exposed to users, and extracted for translation.
However, in some languages the translation for some of the strings, such as "resubscribe me...The `civicrm_mailing_component` has a `name` column limited to varchar(64). This name column is exposed to users, and extracted for translation.
However, in some languages the translation for some of the strings, such as "resubscribe message" can be over 64 characters, causing the CiviCRM installer to fail.https://lab.civicrm.org/dev/core/-/issues/1271Event scheduled reminders not sending with fixed date2023-02-21T05:04:08ZjoewickertEvent scheduled reminders not sending with fixed dateI've been doing a bunch of testing on this on my site running Civicrm 5.13.5 and Drupal 7 after my event scheduled reminders were not working.
And after posting on stackexchange it was replicated on 5.17.4; Drupal 7.67 by ericg
https:/...I've been doing a bunch of testing on this on my site running Civicrm 5.13.5 and Drupal 7 after my event scheduled reminders were not working.
And after posting on stackexchange it was replicated on 5.17.4; Drupal 7.67 by ericg
https://civicrm.stackexchange.com/questions/33101/event-scheduled-reminders-not-sending-with-fixed-date
From what i can work out, if the original reminder has a fixed date (eg, 19th Sept 2019) the first email goes out but no subsequent repeats go out. No errors in the cron log.
But if the original reminder has a date like "1 hour after event start date", the repeats work.
The steps I used to reproduce were:
1. Make sure cron is working and schedule reminders set to hourly
2. create a test event
3. make a scheduled reminder with fixed date and repeat every hour till a year after event start.
4. only the first reminder is delivered
5. set a reminder with relative date (1 hour after start date) repeat every hour until a year after start date.
6. works as expected.https://lab.civicrm.org/dev/core/-/issues/1269Error during "Import Contribution" and not able to import2019-10-09T11:47:08ZtapashError during "Import Contribution" and not able to importReceiving following error in drupal when importing contribution from a csv. Is there a quick fix for this?
`Error: Class name must be a valid object or a string in CRM_Import_Parser->parsePseudoConstantField() (line 565 of /home/webadmi...Receiving following error in drupal when importing contribution from a csv. Is there a quick fix for this?
`Error: Class name must be a valid object or a string in CRM_Import_Parser->parsePseudoConstantField() (line 565 of /home/webadmin/public_html/cmm/sites/all/modules/civicrm/CRM/Import/Parser.php).`
`Notice: Undefined index: bao in CRM_Import_Parser->parsePseudoConstantField() (line 563 of /home/webadmin/public_html/cmm/sites/all/modules/civicrm/CRM/Import/Parser.php).
`5.19.0https://lab.civicrm.org/dev/core/-/issues/1261New Activity Preferences page2022-12-18T05:03:16Zm robimorgan@palantetech.coopNew Activity Preferences pageIn an effort to reorganize the administrative settings forms (see #1260) we propose moving some settings from the Administer > Display Preferences page and the Misc. settings page to a separate preferences page specifically for Activity ...In an effort to reorganize the administrative settings forms (see #1260) we propose moving some settings from the Administer > Display Preferences page and the Misc. settings page to a separate preferences page specifically for Activity settings.
Settings to appear on this page include:
* Notify Activity Assignees
* Do not notify assignees for
* Include Ical Invite to Activity Assignees
* Preserve activity filters as a user preference
* Record generated letters (note: use "Print/merge document" instead of "letter" for clarity)
@tommybobohttps://lab.civicrm.org/dev/core/-/issues/1260Reorganize Misc settings page2022-12-18T05:03:17Zm robimorgan@palantetech.coopReorganize Misc settings pageAs part of a larger effort to make the administrative settings forms more user-friendly, we're proposing some changes to what is currently the Administer > Misc settings page.
Propose changing the form name to: System Options (Undelete...As part of a larger effort to make the administrative settings forms more user-friendly, we're proposing some changes to what is currently the Administer > Misc settings page.
Propose changing the form name to: System Options (Undelete, PDFs, Limits, Logging, captcha, etc.)
Some settings that appear on this page are better classified as "Display Preferences" and should be moved to there:
* Display "empowered by CiviCRM"
* Size of "Recent Items" stack
* Recent Items Providers
* Allow alerts to auto-dismiss?
Some settings on the Display Preferences page are better classified as "System Options" and should be moved from there to here:
* Wysiwig Editor
* Enable popup forms?
Larger structural settings should be in a separate section at the bottom (they are heavier/higher-stakes and less likely to be altered) with a header such as "System Configuration" and maybe a red box. In general, the settings on the form could be ordered by most-to-least lightweight/reversible, with settings that only affect admins at the top.
* PrevNext Cache
* Accept profile submissions from external sites
* Logging (+ add some clarifying text)
* Contact Trash and Undelete
@tommybobohttps://lab.civicrm.org/dev/core/-/issues/1256Improve error handling to always throw exceptions and never abend2024-01-27T05:03:27ZAndrew WestImprove error handling to always throw exceptions and never abendWe're interested in funding a fix to ensure errors are always thrown as exceptions, as mentioned here: https://issues.civicrm.org/jira/browse/CRM-11193 and here: https://lab.civicrm.org/dev/core/issues/395 and here: https://lab.civicrm.o...We're interested in funding a fix to ensure errors are always thrown as exceptions, as mentioned here: https://issues.civicrm.org/jira/browse/CRM-11193 and here: https://lab.civicrm.org/dev/core/issues/395 and here: https://lab.civicrm.org/dev/core/issues/749
If someone could tag this with 'paid-issue-queue' I'd appreciate it.
Our particular interests are:
* catching errors when generating groups for mailings. Currently if these fail a mailing can cheerily sail on without the correct exclusion group
* catching smarty errors in mailings. These currently fail silently and can kill the scheduled jobs list
It seems like both of these are covered by CRM-11193.
I'm not promising we can fund the whole thing, but we can at least pay for time spent investigating what needs to be done.https://lab.civicrm.org/dev/core/-/issues/1252Contribution Summary report only shows first 50 entries2022-12-30T05:03:34ZVangelisPContribution Summary report only shows first 50 entriesHi!
I've noticed that the Contribution Summary report only shows the first 50 entries, without giving you the ability to move to the next set of records.
Bottom-page statistics also calculate those 50 displayed entries and not all ro...Hi!
I've noticed that the Contribution Summary report only shows the first 50 entries, without giving you the ability to move to the next set of records.
Bottom-page statistics also calculate those 50 displayed entries and not all rows.
Narrowing it down, I was able to make it work again by commenting 3 lines on the function `buildRows`. The offending lines:
```php
CRM_Core_DAO::disableFullGroupByMode();
CRM_Core_DAO::reenableFullGroupByMode();
$this->addToDeveloperTab($sql);
```
Source code reference [here](https://lab.civicrm.org/dev/core/blob/master/CRM/Report/Form/Contribute/Summary.php#L743-746)
Only when all these 3 lines are commented/removed, the report displays all records with a proper pager.
Anyone can shed any light why is this happening as I can't seem to be able to find out the reason?
Spotted on CiviCRM 5.16.2https://lab.civicrm.org/dev/core/-/issues/1251Missing Activity from case if source contact is deleted.2023-09-21T05:03:18ZjitendraMissing Activity from case if source contact is deleted.Looks like when a source contact attached to a case activity is deleted, the activity is not displayed under the case.
Scenario -
- Case has some set of activities with target = XYZ and source contact set to "ABC".
- ABC contact is per...Looks like when a source contact attached to a case activity is deleted, the activity is not displayed under the case.
Scenario -
- Case has some set of activities with target = XYZ and source contact set to "ABC".
- ABC contact is permanently deleted from civicrm.
- Activities with source set to ABC is not displayed on the case.
- Viewing the activity from the URL leads to a fatal error.
Approach to fix?
1. Add a validation error/warning before permanently deleting a contact so that user knows this contact is related to activity as "source" and can lead to some missing data on case management screen.
2. Load activity under case even if source contact is not present. https://github.com/civicrm/civicrm-core/commit/cbcb312b3e023d8205bb261067d54c79ac79d971 can provide a fix for this approach and a fatal error on view activity page.https://lab.civicrm.org/dev/financial/-/issues/69Recording one payment against a "Pending (Incomplete Transaction)" results in...2019-10-15T06:15:33ZJonGoldRecording one payment against a "Pending (Incomplete Transaction)" results in two paymentsTo replicate:
* Create a pending contribution (via API, more on this below).
* Record a payment against the contribution.
* Note that two payments are created - one for the full amount, one for the partial amount.
I investigated why thi...To replicate:
* Create a pending contribution (via API, more on this below).
* Record a payment against the contribution.
* Note that two payments are created - one for the full amount, one for the partial amount.
I investigated why this didn't happen via the UI, and it's because the UI creates "Pending (Pay Later)" records. If you pass `is_pay_later = 1` via API, this bug doesn't occur.
The "Pending (Incomplete Transaction)" generates a record in `civicrm_financial_trxn`, which seems odd if the payment didn't happen - but if that IS correct, it should be consistent about whether it appears when you view payments in the UI.5.18.3https://lab.civicrm.org/dev/drupal/-/issues/85Drupal8: Enabling language breaks a fresh CiviCRM install2020-01-26T17:07:09ZRar9Drupal8: Enabling language breaks a fresh CiviCRM installInstalled a fresh D8+civicrm via composer.
composer create-project roundearth/drupal-civicrm-project:8.x-dev MyDomain --no-interaction
setup d8
chmod +w web/sites/default
drush en -y civicrm
Change the "Resource URL" to `[cms.root]/lib...Installed a fresh D8+civicrm via composer.
composer create-project roundearth/drupal-civicrm-project:8.x-dev MyDomain --no-interaction
setup d8
chmod +w web/sites/default
drush en -y civicrm
Change the "Resource URL" to `[cms.root]/libraries/civicrm`
As icons still were not 100% I added to civicrm.settings.php the hard coded ResourceURLs
```php
if (!defined('CIVICRM_UF_BASEURL')) {
define( 'CIVICRM_UF_BASEURL' , 'https://MyDomain');
$civicrm_setting['URL Preferences']['userFrameworkResourceURL'] = '[cms.root]/libraries/civicrm';
$civicrm_paths['civicrm.root']['url'] = CIVICRM_UF_BASEURL . '/libraries/civicrm/';
$civicrm_setting['domain']['userFrameworkResourceURL'] = '[cms.root]/libraries/civicrm';
$civicrm_paths['cms.root']['path'] = '/var/www/vhosts/MyDomain/web';
}
```
Now cleared cache and CiviCRM runs :-)
But when I enable D8 language under extensions the CiviCRM site breaks! :-(
[Screenshot_1](/uploads/b0edfe413622185916d319889f178cd8/Screenshot_1.jpg)
Disabling Drupal language again, will bring back CiviCRM.5.23.0https://lab.civicrm.org/dev/core/-/issues/1246Fatal Error in "Search Builder" if "Household" Contact type is disabled.2019-09-13T03:49:45ZmarcusjwilsonFatal Error in "Search Builder" if "Household" Contact type is disabled.On upgrading to CiviCRM 5.17.0 we noticed that a Fatal Error was thrown when accessing "Search Builder", relating to Null values in arrays in CRM/Core/BAO/Map.php.
We tracked the issue down to the "Household" contact type, which we had ...On upgrading to CiviCRM 5.17.0 we noticed that a Fatal Error was thrown when accessing "Search Builder", relating to Null values in arrays in CRM/Core/BAO/Map.php.
We tracked the issue down to the "Household" contact type, which we had disabled for the two client sites throwing these errors (these two clients never use Household contact type, so we'd used CiviAPI to disable this contact type).
When we re-enabled Household contact type the Fatal error was resolved.
It feels like the Search Builder shouldn't break when Household contact type is disabled, so logging this for a fix.5.17.4colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/1241Custom field value for a new Event based on an Event Template are not checked...2020-03-17T23:06:46Zjustinfreeman (Agileware)Custom field value for a new Event based on an Event Template are not checked causing false validation message and Event not to saveCustom field value for a new Event based on an Event Template are not checked causing false validation message and Event not to save.
Steps to reproduce:
1. Create a custom field, assign to Events and set to be a required field
1. Creat...Custom field value for a new Event based on an Event Template are not checked causing false validation message and Event not to save.
Steps to reproduce:
1. Create a custom field, assign to Events and set to be a required field
1. Create a new Event
1. Select an Event Template for the Event
1. Set a value for the custom field
1. Save the Event
1. Validation message appears for custom field, even though a value has been set
1. Event does not save
1. If no Event Template is selected then field validation is correct and the Event will save
Tested on CiviCRM 5.16.3 and CiviCRM 5.19.alpha1
![screencapture-dmaster-demo-civicrm-org-civicrm-event-add-2019-09-09-10_45_33](/uploads/916cd2737c808f393b7a48a5fe86bb1f/screencapture-dmaster-demo-civicrm-org-civicrm-event-add-2019-09-09-10_45_33.png)
Agileware Ref: CIVICRM-13065.17.4Monish DebMonish Deb