Development issueshttps://lab.civicrm.org/groups/dev/-/issues2020-06-25T16:47:52Zhttps://lab.civicrm.org/dev/core/-/issues/1816[regression](for real this time) API doesn't allow passing option values by l...2020-06-25T16:47:52ZJonGold[regression](for real this time) API doesn't allow passing option values by labelThis is best replicated from the CLI.
In Civi 5.25 and below, when you use the API `create` action to modify a multiple-choice custom field (e.g. radio, checkboxes, etc.) you can pass either the OptionValue's `value` or `label`. Passin...This is best replicated from the CLI.
In Civi 5.25 and below, when you use the API `create` action to modify a multiple-choice custom field (e.g. radio, checkboxes, etc.) you can pass either the OptionValue's `value` or `label`. Passing a label no longer works. For example, on a site with the standard demo data, custom field 6 is a question, "How long have you been a donor?" Here are the potential options:
```
mysql> select label, value from civicrm_option_value WHERE option_group_id=99;
+-------------------+-------+
| label | value |
+-------------------+-------+
| Less than 1 year | 1 |
| 1-3 years | 2 |
| 4-6 years | 3 |
| 7-9 years | 4 |
| More than 9 years | 5 |
+-------------------+-------+
```
In Civi 5.25 and below, the following commands are equivalent:
```
cv api Contribution.create id=1 custom_6='1-3 years'
cv api Contribution.create id=1 custom_6=2
```
However, in Civi 5.26, if you run the first command, instead you get:
```json
{
"error_field": "custom_6",
"error_code": 2001,
"entity": "Contribution",
"action": "create",
"is_error": 1,
"error_message": "'1-3 years' is not a valid option for field custom_6"
}
```
`git bisect` tracks it down to [this commit](https://github.com/civicrm/civicrm-core/commit/1453c6db862950c135452bd36d20aa7f0e95c795) (attention @colemanw). Further testing tracks it down to the change in `CRM/Core/BAO/CustomField.php`; reverting that line fixes this.5.26.2https://lab.civicrm.org/dev/core/-/issues/1806Import Contribution of custom fields only accepts "Numeric Value" rather than...2020-06-16T10:20:04ZtapashImport Contribution of custom fields only accepts "Numeric Value" rather than "Label"It occurs after updating to CiviCRM v-5.26.x, on previous version it seems to have worked. And due to this issue I am not able to import hundreds of records.
When importing a contribution via csv with custom fields "Label", it comes wit...It occurs after updating to CiviCRM v-5.26.x, on previous version it seems to have worked. And due to this issue I am not able to import hundreds of records.
When importing a contribution via csv with custom fields "Label", it comes with an error **'Label' is not a valid option for field custom_xx.** Updating custom field set did not solve the issue.
If custom field is accessed this error message keep showing in drupal log
`"Warning: in_array() expects parameter 2 to be array, null given in CRM_Core_BAO_CustomField::setProfileDefaults() (line 1241 of /public_html//sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php)."`
If custom fields are updated : This error message shows in log
`Notice: Undefined index: ADD in CRM_Logging_Schema->fixSchemaDifferencesFor() (line 437 of /home/webadmin/public_html/cmm/sites/all/modules/civicrm/CRM/Logging/Schema.php).`
5.26.2https://lab.civicrm.org/dev/core/-/issues/1797jquery validation type error on the credit card field2020-06-06T01:16:36Zalicefruminjquery validation type error on the credit card fieldOverview
----------------------------------------
On front end contribution forms with Credit Card Processing enabled, the [jQuery Validation Plugin](https://jqueryvalidation.org/creditcard-method/) is choking on the credit card field an...Overview
----------------------------------------
On front end contribution forms with Credit Card Processing enabled, the [jQuery Validation Plugin](https://jqueryvalidation.org/creditcard-method/) is choking on the credit card field and throwing the following error in the console: `TypeError: a.validator.methods[d] is undefined. Exception occurred when checking element credit_card_number, check the 'creditcard' method. jquery.validate.min.js:4:11231`
I think this broke when the jQuery Validation Plugin was updated with this [commit](https://github.com/civicrm/civicrm-core/pull/16625) in CiviCRM 5.25.
Reproduction steps
----------------------------------------
1. go to a front end contribution form with credit card processing set up
1. Enter a 1 into the credit card number field
Current behaviour
----------------------------------------
an error is thrown in the console.
NO validation error is thrown
SCREENSHOT FROM CiviCRM v5.25
![typeerror](/uploads/92a9c0bba3c9fd0f036e2178740f34b2/typeerror.png)
Expected behaviour
----------------------------------------
no error should appear in the console
an "Invalid credit card number" message should appear next to the field
SCREENSHOT FROM CiviCRM v5.24
![error](/uploads/310bda7df2cc96594ee8e53628537d3a/error.png)
Environment information
----------------------------------------
I was able to recreate this on http://wpmaster.demo.civicrm.org/ (CiviCRM v5.27) and (CiviCRM v5.25)5.26.1https://lab.civicrm.org/dev/core/-/issues/1794Deselected checkbox settings are not saved2020-06-06T01:16:09Zaydunsaidan.saunders@squiffle.ukDeselected checkbox settings are not savedOverview
----------------------------------------
See https://civicrm.stackexchange.com/questions/35803/some-checkbox-settings-not-applying
Reproduction steps
----------------------------------------
1. Click on **Administer > Customize...Overview
----------------------------------------
See https://civicrm.stackexchange.com/questions/35803/some-checkbox-settings-not-applying
Reproduction steps
----------------------------------------
1. Click on **Administer > Customize Data and Screens > Custom Fields**.
1. Choose a custom field set, **more > Settings**
1. Choose one of the selected tickboxes and deselect.
1. Save
1. Re-open the settings page and observe that the checkbox is still selected
Current behaviour
----------------------------------------
Deselected value is not saved
Expected behaviour
----------------------------------------
Deselected value is saved
Environment information
----------------------------------------
* __CiviCRM:__ _Master_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
Confirmed on dmaster.demo.civicrm.org5.26.1https://lab.civicrm.org/dev/core/-/issues/1787Regression : File fields export results in DB error2021-03-22T20:15:23ZyashodhaRegression : File fields export results in DB errorIt was possible to export fields earlier
![export](/uploads/b55eb19f9b54375925777dcf3284a10d/export.png)
as the file field was exported as the link
But now it gives DB error as it looks like it is trying to put in content instead.
```
D...It was possible to export fields earlier
![export](/uploads/b55eb19f9b54375925777dcf3284a10d/export.png)
as the file field was exported as the link
But now it gives DB error as it looks like it is trying to put in content instead.
```
Database Error Code: Data too long for column 'custom_13' at row 1, 1406
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] =>
INSERT INTO civicrm_tmp_d_export_f8e0146418cb04e43d04334f268fd888 (`id`, `display_name`, `custom_13`, `participant_id`)
VALUES (1,'Mrs. Bernadette Ivanov',' <a href=\"/civicrm/file?reset=1&id=1&eid=42&fcs=66d344b164defb0da239223d1515c8a1b5e2305cd4be3c2527e18a2d6577acc4_1590738546_168\" class=\"crm-image-popup\" title=\"download.jpeg\">\n <i class=\"crm-i fa-file-image-o\" aria-hidden=\"true\"></i>\n </a>','42')
[nativecode=1406 ** Data too long for column 'custom_13' at row 1]
[type] => DB_Error
[user_info] =>
INSERT INTO civicrm_tmp_d_export_f8e0146418cb04e43d04334f268fd888 (`id`, `display_name`, `custom_13`, `participant_id`)
VALUES (1,'Mrs. Bernadette Ivanov',' <a href=\"/civicrm/file?reset=1&id=1&eid=42&fcs=66d344b164defb0da239223d1515c8a1b5e2305cd4be3c2527e18a2d6577acc4_1590738546_168\" class=\"crm-image-popup\" title=\"download.jpeg\">\n <i class=\"crm-i fa-file-image-o\" aria-hidden=\"true\"></i>\n </a>','42')
[nativecode=1406 ** Data too long for column 'custom_13' at row 1]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::handle prefix="" info="
INSERT INTO civicrm_tmp_d_export_f8e0146418cb04e43d04334f268fd888 (`id`, `display_name`, `custom_13`, `participant_id`)
VALUES (1,'Mrs. Bernadette Ivanov',' <a href=\"/civicrm/file?reset=1&id=1&eid=42&fcs=66d344b164defb0da239223d1515c8a1b5e2305cd4be3c2527e18a2d6577acc4_1590738546_168\" class=\"crm-image-popup\" title=\"download.jpeg\">\n <i class=\"crm-i fa-file-image-o\" aria-hidden=\"true\"></i>\n </a>','42')
[nativecode=1406 ** Data too long for column 'custom_13' at row 1]"]
)
```
I was able to replicate this on dmaster as well
![dmaster](/uploads/3c55e8ed9b1552c7bd0f79022d6bd930/dmaster.png)5.28.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/1784Contact restore from trash not working2020-06-01T00:07:09ZDaveDContact restore from trash not workingSee also https://civicrm.stackexchange.com/questions/35766/restore-from-trash-not-working-no-related-log-entries
Seems to be from here: https://github.com/civicrm/civicrm-core/commit/8e12bf072fe613c29da39614c8999a4041d7e1d2
In contactT...See also https://civicrm.stackexchange.com/questions/35766/restore-from-trash-not-working-no-related-log-entries
Seems to be from here: https://github.com/civicrm/civicrm-core/commit/8e12bf072fe613c29da39614c8999a4041d7e1d2
In contactTrashRestore() it used to fall through to the code below which does the save(). Then by just copying that block to deleteContact() and calling self::create() it doesn't work because it's expecting `contact_id` not `id`.
So would have started in 5.25.
The quick fix would be to use contact_id. But it sounds like there's a desire to deprecate this entire path of calling deleteContact in order to restore.5.26.0https://lab.civicrm.org/dev/core/-/issues/1780Export selected fields doesn't export related contacts if related info is pre...2020-06-04T04:12:51ZyashodhaExport selected fields doesn't export related contacts if related info is present in mappingSteps to replicate
* Search > *Find Contacts*
* Click the *Search* button > results in X contacts
* Select All contacts
* Actions > *Export Contacts*
* Use *Export PRIMARY fields*, all X contacts are exported
* Now try *Select Fields fo...Steps to replicate
* Search > *Find Contacts*
* Click the *Search* button > results in X contacts
* Select All contacts
* Actions > *Export Contacts*
* Use *Export PRIMARY fields*, all X contacts are exported
* Now try *Select Fields for Export* with some fields as related fields like employer, spouse of id etc
* *DO NOT MERGE*
* Export > only X-N contact records where N is the contacts that appeared in related contacts fields
I replicated this on dmaster and seems to be a regression when compared it with 4.7 site where no. of contacts exported was X regardless related fields are used in mapping or primary fields are used.5.26.0https://lab.civicrm.org/dev/core/-/issues/1747Regression: Fails to create smartgroup or refresh count of group2020-06-02T01:16:03ZPradeep Nayakpradpnayak@gmail.comRegression: Fails to create smartgroup or refresh count of groupOverview
----------------------------------------
Since upgrading to 5.24 creating smart group using 'Date Added to CiviCRM' fails with DB Error: no such table. Also when a smart group is based on 'Date Added to CiviCRM' and try to refre...Overview
----------------------------------------
Since upgrading to 5.24 creating smart group using 'Date Added to CiviCRM' fails with DB Error: no such table. Also when a smart group is based on 'Date Added to CiviCRM' and try to refresh the count it fails with same error message
Reproduction steps
----------------------------------------
1. Navigate to CiviCRM >> Search >> Custom Searches >> Date Added to CiviCRM
1. Do a search on date and include in group.
1. Select all contact and try adding to smart group.
1. Got an error "**Fatal error: DB error**".
![smartGroupError](/uploads/3ea50e38bccd47141831b4990f6f6b0a/smartGroupError.gif)
Current behaviour
----------------------------------------
Get DB error 'Database Error Code: Table 'dmastercivi_g5lis.civicrm_tmp_e_ig_6f1e2d3b300d50a856f5cb9140996451' doesn't exist, 1146' when trying to create smart group or refresh count
Expected behaviour
----------------------------------------
smart should be created with correct contacts in it and also when refreshing the group count, the group should show correct count
Environment information
----------------------------------------
https://dmaster.demo.civicrm.org/5.26.0https://lab.civicrm.org/dev/core/-/issues/1740Cumulative contributions not being calculated with the correct criteria2020-05-05T23:28:45ZyashodhaCumulative contributions not being calculated with the correct criteriaThis is a regression in CiviCRM. I have confirmed the same in dmaster.
Steps to replicate:
====================
* Go to Contributions > Online Contribution Pages > Contributions > Cumulative
* Check the criteria for Date Receipt, it do...This is a regression in CiviCRM. I have confirmed the same in dmaster.
Steps to replicate:
====================
* Go to Contributions > Online Contribution Pages > Contributions > Cumulative
* Check the criteria for Date Receipt, it doesn't account for **end of** today's date but the start of today and all the contributions done today will NOT be listed.
*Issue with master*
Criteria
Date Received - less than or equal to "May 1st, 2020 **12:00 AM** " ...AND.
![dmaster](/uploads/5441660b74e3a05abe19ae245324a88a/dmaster.png)
*Before*
Contribution Date - less than or equal to "May 1st, 2020 **11:59 PM** " .
![demo](/uploads/434f94696dbc3049c9425085abe1c3c0/demo.png)
The parameter receive_date_high=20200501 has to translate to <= date 11:59 PM and will throw off all the other parameter forced searches as well.
In cumulative search link, do we even need to pass parameters for the date?5.25.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/1738Incorrect loading of default tab on Contribution Page2020-04-30T22:58:29ZjitendraIncorrect loading of default tab on Contribution PageTo replicate - click https://dmaster.demo.civicrm.org/civicrm/admin/contribute?reset=1 -> select Configure > Membership Settings should navigate to the Membership tab directly but instead is navigated to the first tab of the page(Setting...To replicate - click https://dmaster.demo.civicrm.org/civicrm/admin/contribute?reset=1 -> select Configure > Membership Settings should navigate to the Membership tab directly but instead is navigated to the first tab of the page(Settings).
Caused by changes made in https://github.com/civicrm/civicrm-core/pull/17066.5.26.0https://lab.civicrm.org/dev/core/-/issues/1729CiviReport "Source Name" filter is broken / has no impact on report results2020-04-30T22:59:59ZmarshCiviReport "Source Name" filter is broken / has no impact on report resultsOverview
----------------------------------------
Setting the "Source Name" filter on a report has no effect on the results
Reproduction steps
----------------------------------------
1. open [Activity Details report](https://dmaster.de...Overview
----------------------------------------
Setting the "Source Name" filter on a report has no effect on the results
Reproduction steps
----------------------------------------
1. open [Activity Details report](https://dmaster.demo.civicrm.org/civicrm/report/instance/3?reset=1&output=criteria).
1. go to **filters** (tab)
1. **Source Name** : Contains : [any text]
1. Preview results
Current behaviour
----------------------------------------
- notice 80 results
- **results do not change** when changing the 'source name' filter
- no errors
Expected behaviour
----------------------------------------
- report results get filtered, so different filter values give different results
Environment information
----------------------------------------
testing and workflow was on https://dmaster.demo.civicrm.org/
Comments
----------------------------------------
This looks like a regression, and could be from:
- https://github.com/civicrm/civicrm-core/pull/16672
- https://lab.civicrm.org/dev/core/issues/1627
(thanks to Pradeep Nayak for investigations)5.24.6https://lab.civicrm.org/dev/core/-/issues/1724Changes to CiviContribute Component Settings not saved2020-05-15T23:43:31ZkcristianoChanges to CiviContribute Component Settings not savedAs reported in [Mattermost](https://chat.civicrm.org/civicrm/pl/iy3p1aqambfadymorr5ean7e3w)
```
Anyone have any idea why the CiviContribute Component Settings page would not be updating values on save? Everything up to the “Enabled Defe...As reported in [Mattermost](https://chat.civicrm.org/civicrm/pl/iy3p1aqambfadymorr5ean7e3w)
```
Anyone have any idea why the CiviContribute Component Settings page would not be updating values on save? Everything up to the “Enabled Deferred Revenue” field saves fine, but nothing below it (although Civi reports “Your changes have been saved”. Civi v5.24.3 running on WordPress).
```
Reproduced on 5.25 RC and master in WP and Drupal 7.5.24.6https://lab.civicrm.org/dev/core/-/issues/1723Reciprocal relationship search with custom fields leads to an error on Advanc...2020-04-23T02:52:05ZjitendraReciprocal relationship search with custom fields leads to an error on Advanced searchTo replicate -
- Create a custom field extending relationships. Searchable = yes.
- Open Advanced search
- Select any reciprocal relationship eg spouse of, sibling, partner, etc
- Enter value for the custom field.
- Hit Search.
![image...To replicate -
- Create a custom field extending relationships. Searchable = yes.
- Open Advanced search
- Select any reciprocal relationship eg spouse of, sibling, partner, etc
- Enter value for the custom field.
- Hit Search.
![image](/uploads/57290e079190ceb39e47eebe5a3331e6/image.png)
possibly due to https://github.com/civicrm/civicrm-core/pull/15793. As it was merged ~5 months ago(included in 5.21), I think it should be labeled as regression?5.24.5https://lab.civicrm.org/dev/core/-/issues/1717SMTP temp failure causes "Call to undefined method CRM_Utils_Mail_FilteredPea...2020-04-25T19:32:57Zaydunsaidan.saunders@squiffle.ukSMTP temp failure causes "Call to undefined method CRM_Utils_Mail_FilteredPearMailer::disconnect()"Overview
----------------------------------------
SMTP temp fails can result in "Call to undefined method CRM_Utils_Mail_FilteredPearMailer::disconnect()"
This involves SMTP temp fails so is not easy to reproduce reliably.
The error se...Overview
----------------------------------------
SMTP temp fails can result in "Call to undefined method CRM_Utils_Mail_FilteredPearMailer::disconnect()"
This involves SMTP temp fails so is not easy to reproduce reliably.
The error seen in the log is:
`SMTP Socket Error or failed to set sender error. Message: Failed to set sender: b-6928-162335-5d12be6b881f1e84@example.com [SMTP: Invalid response code received from SMTP server while sending email. This is often caused by a misconfiguration in Outbound Email settings. Please verify the settings at Administer CiviCRM >> Global Settings >> Outbound Email (SMTP). (code: 421, response: 4.7.0 Try again later, closing connection. (MAIL) f22sm5685077lja.39 - gsmtp)], Code: 10004`
The mailing was initiated with `cv api Job.execute` producing:
`Call to undefined method CRM_Utils_Mail_FilteredPearMailer::disconnect()`
The problem seems to be here: https://github.com/civicrm/org.civicrm.flexmailer/blob/master/src/Listener/DefaultSender.php#L77
Possible fixes:
1) Change flexmailer not to call `$mailer->disconnect()`
2) Implement `CRM_Utils_Mail_FilteredPearMailer::disconnect()`
Also, the error message is misleading: a 421 or 4.7.0 is not an invalid response and was not caused but settings misconfiguration.
This seems to be a fairly minor problem in that it only occurs for temp fails and those are retried later.
Environment information
----------------------------------------
* __CiviCRM:__ 5.24.4
* __Flexmailer:__ 1.1.1
* __PHP:__ 7.2
* Mail configuration: SMTP to gmail.com5.24.5https://lab.civicrm.org/dev/core/-/issues/1714Search Builder - Activity Type search not working.2020-05-02T04:46:10ZBari PollardSearch Builder - Activity Type search not working.After upgrading to 5.24.3 some smart groups stopped working that were created using Search Builder and activity types.
Investigated on DMaster 5.26.alpha1.
Using Search Builder -
Choose Activity - Activity Type - = - Tell a Friend. ...After upgrading to 5.24.3 some smart groups stopped working that were created using Search Builder and activity types.
Investigated on DMaster 5.26.alpha1.
Using Search Builder -
Choose Activity - Activity Type - = - Tell a Friend.
Actual results - 0
Choose Activity - Activity Type ID - = - Tell a Friend. (Not listed as a ID just the label)
Actual results - 925.25.0https://lab.civicrm.org/dev/core/-/issues/1712Can't edit Civicontribute component settings for tax and invoicing once set2022-10-04T13:21:48ZUpperholmeCan't edit Civicontribute component settings for tax and invoicing once setOverview
----------------------------------------
Having enabled the Tax and Invoicing feature and set the preferred options at /civicrm/admin/setting/preferences/contribute?reset=1, if you later want to alter one or more of these option...Overview
----------------------------------------
Having enabled the Tax and Invoicing feature and set the preferred options at /civicrm/admin/setting/preferences/contribute?reset=1, if you later want to alter one or more of these options, for example changing the number of days before the invoice falls due, or turning off the option to send a PDF invoice by default, edits to this page are not saved.
I've come across this on two installations, both running 5.24.x, and have replicated the issue on https://dmaster.demo.civicrm.org
Reproduction steps
----------------------------------------
1. Go to Administration > CiviContribute > CiviContribute Component Settings.
2. If Tax and Invoicing is already enabled, edit, for example, the number of days before an invoice falls due. Click 'Save'.
3. Return to Administration > CiviContribute > CiviContribute Component Settings
4. Note that your edit has not been saved and that the previous setting still stands.
Current behaviour
----------------------------------------
I've not tested every setting on this page, but for those that I have, edits are not saved and whatever the previous setting was remains in force.
Expected behaviour
----------------------------------------
The edit should be saved.
Environment information
----------------------------------------
* Browsers tested: Firefox 75/Safari 13.04
* CiviCRM: Master/5.24.1
* PHP: 7.3
* CMS: Drupal 7.69
* Database: MariaDB
* Web Server: Apache 2.45.25.0https://lab.civicrm.org/dev/core/-/issues/1695Upgrading to 5.24.1 custom field not saved for Case when submitted from webform2020-08-07T03:09:34ZPradeep Nayakpradpnayak@gmail.comUpgrading to 5.24.1 custom field not saved for Case when submitted from webformTo Replicate:
Create a webform and enable civicase with custom field. After submitting the webform a new case is created but the custom fields are blank.
This was working until 5.22.x and than update to DB/ packages in 5.23 broke this f...To Replicate:
Create a webform and enable civicase with custom field. After submitting the webform a new case is created but the custom fields are blank.
This was working until 5.22.x and than update to DB/ packages in 5.23 broke this functionality. This cannot be replicated when case is created from UI but can be replicated by writing code eg
```
$result = civicrm_api3('Case', 'create', [
'contact_id' => 202,
'case_type_id' => "housing_support",
'subject' => "test",
])['id'];
$cust = array(
'19' => array(
'-1' => array(
'id' => '',
'value' => '344',
'type' => 'Money',
'custom_field_id' => '19',
'custom_group_id' => '13',
'table_name' => 'civicrm_value_reportable_co_13',
'column_name' => 'reportable_cost_19',
'file_id' => '',
'is_multiple' => '0',
)
)
);
CRM_Core_BAO_CustomValueTable::store($cust, 'civicrm_case', $result);
```
Digging into the code found that the entry civicrm_value_reportable_co_13 table does get created but isn't shown. I guess this is because the transaction is started but not committed. Below patch fixes my problem (which removes Transaction code) but I guess its not ideal solution.
```
diff --git a/Civi/CCase/Events.php b/Civi/CCase/Events.php
index 114875f17e..f76c92c267 100644
--- a/Civi/CCase/Events.php
+++ b/Civi/CCase/Events.php
@@ -78,12 +78,10 @@ class Events {
public static function fireCaseChangeForRealz($caseIds) {
foreach ((array) $caseIds as $caseId) {
if (!isset(self::$isActive[$caseId])) {
- $tx = new \CRM_Core_Transaction();
self::$isActive[$caseId] = 1;
$analyzer = new \Civi\CCase\Analyzer($caseId);
\CRM_Utils_Hook::caseChange($analyzer);
unset(self::$isActive[$caseId]);
- unset($tx);
}
}
}
```5.24.2https://lab.civicrm.org/dev/core/-/issues/1677Domain specific entities on multisite are not respected after upgrade to 5.23.42020-04-02T17:36:40ZandyburnsDomain specific entities on multisite are not respected after upgrade to 5.23.4Overview
----------------------------------------
After upgrading to 5.23.4 on multisite the from email address and membership type that should respect the domain ID are not. After clearing cache with cv flush whichever domain ID I go to...Overview
----------------------------------------
After upgrading to 5.23.4 on multisite the from email address and membership type that should respect the domain ID are not. After clearing cache with cv flush whichever domain ID I go to first shows 'correctly' but then that would be the membership organization shown on any other domain I'd go to subsequently. Seeing another domain membership types other than the domain's org membership types. Seeing this with the default from address when going to actions > send email and membership when adding or renewing a membership.
Membership Error Reproduction steps
----------------------------------------
1. Run cv flush
2. Go to a contact
3. Click membership tab > add membership
4. AJAX modal pops up and the Membership Organization and Type is that of the domain.
5. Go to another domain and run steps 2-4 and it will be the same membership organization (incorrect) in step 4. Repeats on all other domains.
From Email Address Reproduction steps
----------------------------------------
1. Go to a contact
2. Click actions > send email
3. You'll see incorrect from email address for the domain
Current behaviour
----------------------------------------
Domain specific entities are not respected
Expected behaviour
----------------------------------------
You should only see your Membership Organization and Type and its membership types when adding a membership. You should only see from email address of the organization domain when sending an email.
Environment information
----------------------------------------
* __CiviCRM:__ 5.23.4
* __PHP:__ 7.2.28-3+ubuntu18.04.1+deb.sury.org+1
* __CMS:__ WordPress 5.3.2
* __Database:__ MySQL 5.7.29
* __Web Server:__ Apache/2.4.41 (Ubuntu)
Are others seeing this?
@kcristiano @seamuslee 5.24.0https://lab.civicrm.org/dev/core/-/issues/1676E_NOTICE when using the New Individual popup/profile2020-03-30T12:49:37ZDaveDE_NOTICE when using the New Individual popup/profileSeems to be new in master, not happening in 5.24. Adding regression label although with the default profile it doesn't cause any problems.
1. Turn on the setting at system settings - debugging to log to drupal watchdog.
1. Do something ...Seems to be new in master, not happening in 5.24. Adding regression label although with the default profile it doesn't cause any problems.
1. Turn on the setting at system settings - debugging to log to drupal watchdog.
1. Do something like create a contribution, where you have the option to create a new individual on the fly.
1. In the Contributor field, choose the option to create a New Individual.
1. In drupal watchdog there's `Notice: Undefined variable: primaryLocationType in CRM_Profile_Form->buildQuickForm() (line 844 of blah/CRM/Profile/Form.php).`
1. You can also see it on the screen as a red box if you instead:
1. Go to `/civicrm/profile/create?reset=1&context=dialog&gid=4&returnExtra=display_name,sort_name,email&snippet=json`
1. Visit the civicrm home page or any other actual page.5.25.0https://lab.civicrm.org/dev/core/-/issues/1674Regression: Api4 causes container being rebuild on every request2020-04-01T22:28:58ZjaapjansmaRegression: Api4 causes container being rebuild on every requestThe api4 is checking for the directories `Civi/Api4/Event/Subscriber` and `Civi/Api4/Service/Spec/Provider` in every enabled extension. And if that directory does not exists the container will be rebuild. This checking is done every requ...The api4 is checking for the directories `Civi/Api4/Event/Subscriber` and `Civi/Api4/Service/Spec/Provider` in every enabled extension. And if that directory does not exists the container will be rebuild. This checking is done every request and is part of the routine the check whether the container needs rebuilding.
This will slow down performance as the civi container is not cached anymore.
There is a work around, adding the directories: `Civi/Api4/Event/Subscriber` and `Civi/Api4/Service/Spec/Provider` to every extension.
I have given this the regression label as I do think it is a regression.
**Related PR**
https://github.com/civicrm/civicrm-core/pull/169195.25.0