Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-08-04T23:47:07Zhttps://lab.civicrm.org/dev/core/-/issues/2687Regression: Smart group rebuild in default config crashes cron2021-08-04T23:47:07ZJonGoldRegression: Smart group rebuild in default config crashes cronWhen you run cron (`job.execute`), it crashes because of a recent refactoring that enforces type checking.
### Steps to Replicate (can use dmaster.demo.c.o)
* Go to **Administer » System Settings » Scheduled Jobs**.
* Next to *Rebuild S...When you run cron (`job.execute`), it crashes because of a recent refactoring that enforces type checking.
### Steps to Replicate (can use dmaster.demo.c.o)
* Go to **Administer » System Settings » Scheduled Jobs**.
* Next to *Rebuild Smart Group Cache*, click **Execute Now**.
### Expected Result
Job completes successfully.
### Actual Result
```
TypeError: Argument 2 passed to CRM_Contact_BAO_GroupContactCache::getGroupsNeedingRefreshing() must be of the type int, string given, called in /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Contact/BAO/GroupContactCache.php on line 132 in CRM_Contact_BAO_GroupContactCache::getGroupsNeedingRefreshing() (line 715 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Contact/BAO/GroupContactCache.php).
```
In Scheduled Jobs, the default parameters for this job read:
```
limit=Number optional-Limit the number of smart groups rebuild
```
So `limit` is a string, but the new type checking enforces it being an integer.
This new function is only called in two places, and only one specifies a value, so I'm casting to `int` there.5.40.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2680Upgrade to Nightly (5.40.alpha1) from Stable (5.38.1) fails with DB Error: co...2021-07-08T23:07:11ZkcristianoUpgrade to Nightly (5.40.alpha1) from Stable (5.38.1) fails with DB Error: constraint violationLooking to test https://github.com/civicrm/civicrm-core/pull/20672 I ran into an upgrade issue.
- WP 5.7.2
- CiviCRM 5.38.1
- php 7.3
- MariaDB 10.3
Upgrade from Stable to Nightly at https://download.civicrm.org/latest/civicrm-NIGHTL...Looking to test https://github.com/civicrm/civicrm-core/pull/20672 I ran into an upgrade issue.
- WP 5.7.2
- CiviCRM 5.38.1
- php 7.3
- MariaDB 10.3
Upgrade from Stable to Nightly at https://download.civicrm.org/latest/civicrm-NIGHTLY-wordpress.zip as the first step before applying the patch.
Running either the Graphical Upgrader or `cv upgrade:db` produces `DB Error: constraint violation`
From the Logs:
```
Jul 05 13:34:23 [info] $CRM_Queue_Page_AJAX_runNext_error = PEAR_Exception: "DB Error: constraint violation"
* ERROR TYPE: DB_Error
* ERROR CODE: -3
* ERROR MESSAGE: DB Error: constraint violation
* ERROR MODE: 16
* ERROR USERINFO:
ALTER TABLE `civicrm_contribution_product`
ADD CONSTRAINT `FK_civicrm_contribution_product_product_id`
FOREIGN KEY (`product_id`) REFERENCES `civicrm_product` (`id`)
ON DELETE CASCADE;
[nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`wpcv_civicrm`.`#sql-696_454`, CONSTRAINT `FK_civicrm_contribution_product_p
roduct_id` FOREIGN KEY (`product_id`) REFERENCES `civicrm_product` (`id`) ON DELETE CASCADE)]
* ERROR DEBUGINFO:
ALTER TABLE `civicrm_contribution_product`
ADD CONSTRAINT `FK_civicrm_contribution_product_product_id`
FOREIGN KEY (`product_id`) REFERENCES `civicrm_product` (`id`)
ON DELETE CASCADE;
[nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`wpcv_civicrm`.`#sql-696_454`, CONSTRAINT `FK_civicrm_contribution_product_p
roduct_id` FOREIGN KEY (`product_id`) REFERENCES `civicrm_product` (`id`) ON DELETE CASCADE)]
#0 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(922): CRM_Core_Error::exceptionHandler(Object(DB_Error[5/91811]
#1 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/db/DB.php(997): PEAR_Error->__construct("DB Error: constraint violation", -3, 16, (Array:2), "
\n ALTER TABLE `civicrm_contribution_product`\n ADD CONSTRAIN...")
#2 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-3, 16, (Array:2), "\n ALTER
TABLE `civicrm_contribution_product`\n ADD CONSTRAIN...")
#3 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -3, 16, (Array:2), "\n ALTER TABLE `civicrm_contribution_product`\n ADD CONSTRAIN...", "DB_Error", TRUE)
#4 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/db/DB/common.php(1928): PEAR->__call("raiseError", (Array:7))
#5 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/db/DB/mysqli.php(936): DB_common->raiseError(-3, NULL, NULL, "\n ALTER TABLE `civicrm_contribution_product`\n ADD CONSTRAIN...", "1452 ** Cannot add or update a child row: a foreign key constraint fails (`ss...")
#6 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/db/DB/mysqli.php(406): DB_mysqli->mysqliRaiseError()
#7 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/vendor/pear/db/DB/common.php(1234): DB_mysqli->simpleQuery("\n ALTER TABLE `civicrm_contribution_product`\n ADD CONSTRAIN...")
#8 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/packages/DB/DataObject.php(2696): DB_common->query("\n ALTER TABLE `civicrm_contribution_product`\n
ADD CONSTRAIN...")
#9 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/packages/DB/DataObject.php(1829): DB_DataObject->_query("\n ALTER TABLE `civicrm_contribution_produ
ct`\n ADD CONSTRAIN...")
#10 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Core/DAO.php(468): DB_DataObject->query("\n ALTER TABLE `civicrm_contribution_product`\n
ADD CONSTRAIN...")
#11 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Core/DAO.php(1613): CRM_Core_DAO->query("\n ALTER TABLE `civicrm_contribution_product`\n
ADD CONSTRAIN...", FALSE)
#12 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Upgrade/Incremental/php/FiveForty.php(94): CRM_Core_DAO::executeQuery("\n ALTER TABLE `civicrm
_contribution_product`\n ADD CONSTRAIN...", (Array:0), TRUE, NULL, FALSE, FALSE)
#13 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Queue/Task.php(74): CRM_Upgrade_Incremental_php_FiveForty::addContributionProductFK(Object(CRM_Queue_
TaskContext))
#14 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Queue/Runner.php(201): CRM_Queue_Task->run(Object(CRM_Queue_TaskContext))
#15 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Queue/Page/AJAX.php(36): CRM_Queue_Runner->runNext(TRUE)
#16 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Queue/ErrorPolicy.php(89): CRM_Queue_Page_AJAX::{closure}()
#17 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Queue/Page/AJAX.php(38): CRM_Queue_ErrorPolicy->call(Object(Closure))
#18 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(279): CRM_Queue_Page_AJAX::runNext()
#19 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem((Array:13))
#20 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:5))
#21 /srv/www/wpcvlocal/public/wp-content/plugins/civicrm/civicrm.php(1178): CRM_Core_Invoke::invoke((Array:5))
#22 /srv/www/wpcvlocal/public/wp-includes/class-wp-hook.php(292): CiviCRM_For_WordPress->invoke("")
#23 /srv/www/wpcvlocal/public/wp-includes/class-wp-hook.php(316): WP_Hook->apply_filters("", (Array:1))
#24 /srv/www/wpcvlocal/public/wp-includes/plugin.php(484): WP_Hook->do_action((Array:1))
#25 /srv/www/wpcvlocal/public/wp-admin/admin.php(259): do_action("toplevel_page_CiviCRM")
#26 {main}
```https://lab.civicrm.org/dev/core/-/issues/2659failing update Smart Groups for installs with none2021-07-24T03:06:50ZStoobfailing update Smart Groups for installs with noneI got past an upgrade error by commenting out lines 96 through 118 in `CRM/Upgrade/Incremental/php/FiveTwenty.php`
The the update was repeatedly failing on this install which had no smart groups, had never had smart groups, and was prob...I got past an upgrade error by commenting out lines 96 through 118 in `CRM/Upgrade/Incremental/php/FiveTwenty.php`
The the update was repeatedly failing on this install which had no smart groups, had never had smart groups, and was probably five years old or more. I have no idea how to reproduce the issue reliably but if there isn't already a failsafe in the code for installs which have no smart groups to update, please add that failsafe.
Peace out!https://lab.civicrm.org/dev/core/-/issues/26495.39 upgrade is not re-runnable and forces utf8mb42021-06-13T04:43:12ZDaveD5.39 upgrade is not re-runnable and forces utf8mb4It includes a step to create a translation table that should check if the table exists first. Also it forces utf8mb4 but I don't think we've said that's required yet?It includes a step to create a translation table that should check if the table exists first. Also it forces utf8mb4 but I don't think we've said that's required yet?5.39.0https://lab.civicrm.org/dev/core/-/issues/2606My Cases dashlet no longer working (javascript network error - blank dashlet)2021-05-12T19:47:09ZDaveDMy Cases dashlet no longer working (javascript network error - blank dashlet)I'm pretty sure it's something from https://github.com/civicrm/civicrm-core/pull/18969 which was just committed yesterday. Looking into it.I'm pretty sure it's something from https://github.com/civicrm/civicrm-core/pull/18969 which was just committed yesterday. Looking into it.5.39.0https://lab.civicrm.org/dev/core/-/issues/2605CiviCRM 5.37.0 - Create User Record now hides the Password field and uses the...2021-05-19T21:33:33Zjustinfreeman (Agileware)CiviCRM 5.37.0 - Create User Record now hides the Password field and uses the check isUserRegistrationPermitted - which prevents Administrators from setting passwords for new UsersSince CiviCRM 5.37.0, it is no longer possible to use the **Create User Record** form to create a User and set the password. The Password field is now hidden and uses the check isUserRegistrationPermitted function. This check serves no u...Since CiviCRM 5.37.0, it is no longer possible to use the **Create User Record** form to create a User and set the password. The Password field is now hidden and uses the check isUserRegistrationPermitted function. This check serves no useful purpose in this context and hiding the password field is not desired behaviour as it now prevents Administrators from setting passwords for new Users on this form.
This problem was introduced with this change, https://github.com/civicrm/civicrm-core/commit/633d512254424bba7c2195da8c62a9d3ff43d1e4 and PR https://github.com/civicrm/civicrm-core/pull/18982
The comment was "Also removes the possibility to set a user-defined password for **WordPress users**." - this change affects **all** **CMS** not just _WordPress_.
Agileware Ref: CIVICRM-1737
**Before this change in CiviCRM 5.37.0**
![Screenshot_20210512_161416](/uploads/e6792827595e81cd8022ed27b07a5e48/Screenshot_20210512_161416.png)
**After this change in CiviCRM 5.37.0**
![Screenshot_20210512_161318](/uploads/f980d102839b6b2db5a50d07a2eec1ab/Screenshot_20210512_161318.png)5.38.0https://lab.civicrm.org/dev/core/-/issues/2601Cannot edit CiviCRM Joomla permissions (access control) in 5.37.02021-05-12T03:27:10ZAdam WoodCannot edit CiviCRM Joomla permissions (access control) in 5.37.0Have just updated for CiviCRM 5.37.0 for Joomla and found that editing global permissions (Administer > Users and Permissions > Permissions (Access Control) > Joomla Access Control) is broken.
Upon loading the page, I get the following ...Have just updated for CiviCRM 5.37.0 for Joomla and found that editing global permissions (Administer > Users and Permissions > Permissions (Access Control) > Joomla Access Control) is broken.
Upon loading the page, I get the following error:
"Too few arguments to function CRM_Core_Permission_Base::getAllModulePermissions(), 1 passed in /home/cses/public_html/administrator/components/com_civicrm/civicrm/joomla/libraries/joomla/form/fields/civiperms.php on line 282 and exactly 2 expected"
![screenshot_2021_05_09_16_25](/uploads/bd16ed12a9f414a6e7d0b540624486ce/screenshot_2021_05_09_16_25.png)
Issue seems to be that CRM_Core_Permission_Base::getAllModulePermissions() requires a permissions array to be passed (by reference) as the second argument, which is updated and also returned. (Not entirely sure why it does it like this but not really of primary concern).
The following two files are therefore incompatible:
https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Permission/Base.php
https://github.com/civicrm/civicrm-joomla/blob/master/libraries/joomla/form/fields/civiperms.php
Looking at the GitHub repositories, I cannot immediately see which has changed and why. As a quick fix I have simply created a temporary variable but this may not be a good long-term solution.
![Screenshot_2021-05-09_163456](/uploads/ddce48646cf2b128f693e9fcd55f85ed/Screenshot_2021-05-09_163456.png)5.37.1https://lab.civicrm.org/dev/core/-/issues/2588Unable to send transactional email to more than 2 recipients if there is an a...2021-05-07T03:42:47Zfreeform.stephUnable to send transactional email to more than 2 recipients if there is an attachmentOverview
----------------------------------------
If you attempt to send a transactional email with an attachment to 3 or more contacts, there is an error:
> Sorry, due to an error, we are unable to fulfill your request at the moment. Y...Overview
----------------------------------------
If you attempt to send a transactional email with an attachment to 3 or more contacts, there is an error:
> Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
>
> One of parameters (value: ) is not of the type Integer
The first 2 contacts receive the message, but no one else does.
There is no issue observed if there is no attachment, nor if there is an attachment but only 2 recipients.
I replicated the error on two different sites with two different SMTP providers, both running CiviCRM 5.36.1.
This may be related to an issue someone else reported here: https://civicrm.stackexchange.com/questions/39254/contacts-new-email-fails-when-sending-to-more-than-one-contact-after-upgrade-to/39463#39463
Reproduction steps
----------------------------------------
1. View the contacts of a group
1. Select 3 or more contacts
1. Select action "Email - send now (to 50 or less)"
1. Compose a message and include an attachment (I used a pdf that was only 13kb)
Current behaviour
----------------------------------------
> Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your
> administrator or service provider with more details about what action you were performing when this occurred.
> One of parameters (value: ) is not of the type Integer
Full message in error log:
```
May 04 19:06:02 [error]
$Fatal Error Details = array:3 [
"message" => "One of parameters (value: ) is not of the type Integer"
"code" => null
"exception" => CiviCRM_API3_Exception {#1944
-extraParams: array:4 [
"tip" => "add debug=1 to your API call to have more info about the error"
"is_error" => 1
"error_message" => "One of parameters (value: ) is not of the type Integer"
"error_code" => "undefined"
]
#message: "One of parameters (value: ) is not of the type Integer"
#code: 0
#file: "/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/api/api.php"
#line: 133
trace: {
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/api/api.php:133 {
› if (is_array($result) && !empty($result['is_error'])) {
› throw new CiviCRM_API3_Exception($result['error_message'], CRM_Utils_Array::value('error_code', $result, 'undefined'), $result);
› }
}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Activity/BAO/Activity.php:984 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Activity/BAO/Activity.php:1180 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Contact/Form/Task/EmailTrait.php:431 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Contact/Form/Task/EmailTrait.php:351 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/Form.php:526 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Upload.php:152 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Upload.php:119 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php:203 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php:103 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/Controller.php:347 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/Invoke.php:313 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/Invoke.php:69 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/Invoke.php:36 { …}
/var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/drupal/civicrm.module:458 { …}
/var/www/vhosts/example.org/httpdocs/includes/menu.inc:527 { …}
/var/www/vhosts/example.org/httpdocs/index.php:21 { …}
}
}
]
May 04 19:06:02 [debug] $backTrace = #0 /var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/Error.php(433): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/CRM/Core/Invoke.php(39): CRM_Core_Error::handleUnhandledException(Object(CiviCRM_API3_Exception))
#2 /var/www/vhosts/example.org/httpdocs/sites/all/modules/civicrm/drupal/civicrm.module(458): CRM_Core_Invoke::invoke((Array:3))
#3 /var/www/vhosts/example.org/httpdocs/includes/menu.inc(527): civicrm_invoke("group", "search")
#4 /var/www/vhosts/example.org/httpdocs/index.php(21): menu_execute_active_handler()
#5 {main}
```
Expected behaviour
----------------------------------------
All recipients should receive mail with attachments without error
Environment information
----------------------------------------
* __CiviCRM:__ _5.36.1_
* __PHP:__ _7.3.27_
* __CMS:__ _Drupal 7_
* __Database:__ _MariaDB 5.5.5-10.3.28-MariaDB-log_5.37.0https://lab.civicrm.org/dev/core/-/issues/2586CiviContribute: Cannot clear the Thank-you Date (does not set to null on save)2021-05-06T01:47:07ZpbarmakCiviContribute: Cannot clear the Thank-you Date (does not set to null on save)Overview
----------------------------------------
When editing a Contribution in version 5.36.1, we click on the x to clear the Thank-you Date field. It removes the date and time. But, when we click Save, the field remains with the last-...Overview
----------------------------------------
When editing a Contribution in version 5.36.1, we click on the x to clear the Thank-you Date field. It removes the date and time. But, when we click Save, the field remains with the last-used data/time. It does not saved the cleared/null value. This is true on the latest demo as well.
Reproduction steps
----------------------------------------
1. Find any contribution. Click View. Then click Edit.
2. Click the small x next to the time field to clear out the date and time (or simply erase/delete what is there)
3. Click Save.
4. View the contribution, and the Thank-you Date is still set to the old value.
Expected behaviour
----------------------------------------
It should clear out the value of that field.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Firefox 88
* __CiviCRM:__ 5.36.1
* __PHP:__ 7.3
* __CMS:__ Drupal 75.37.1https://lab.civicrm.org/dev/core/-/issues/2583Backend Membership Renewal returns a fatal error when min fee is empty2021-05-03T10:39:04ZjitendraBackend Membership Renewal returns a fatal error when min fee is emptyTo replicate -
- Create Membership Type with no amount value.
- Create a membership on a contact.
- Renew from the Membership tab.
![image](/uploads/50793b0035f0dd0df1bbddbf361fad5c/image.png)
- Error message when the link is opened...To replicate -
- Create Membership Type with no amount value.
- Create a membership on a contact.
- Renew from the Membership tab.
![image](/uploads/50793b0035f0dd0df1bbddbf361fad5c/image.png)
- Error message when the link is opened in a new window -
![image](/uploads/772d973198c86a4d9a7439625b7fda43/image.png)jitendrajitendrahttps://lab.civicrm.org/dev/core/-/issues/2577Changing Payment Method on a Transaction causes fatal error2021-05-02T21:47:08ZhaystackChanging Payment Method on a Transaction causes fatal errorOverview
----------------------------------------
Changing the Payment Method on a Transaction causes fatal error with the message: `"Mandatory key(s) missing from params array: contribution_id"`.
Reproduction steps
--------------------...Overview
----------------------------------------
Changing the Payment Method on a Transaction causes fatal error with the message: `"Mandatory key(s) missing from params array: contribution_id"`.
Reproduction steps
----------------------------------------
1. Go to Contribution Dashboard
1. Click the discovery triangle to reveal Transactions
1. Click the pencil icon to edit a Transaction
1. Change the Payment Method, e.g. from *Credit Card* to *Debit Card*
1. Click "Update"
1. Log shows "**Fatal error: Mandatory key(s) missing from params array: contribution_id"**".
Current behaviour
----------------------------------------
Changing the Payment Method on a Transaction cancels existing Payment but causes fatal error when trying to create a new replacement Payment.
Expected behaviour
----------------------------------------
Changing the Payment Method on a Transaction should replace (or update) the existing Payment.
Environment information
----------------------------------------
Replicated on Drupal Master.5.37.0https://lab.civicrm.org/dev/core/-/issues/2543Cannot edit a membership without a payment [fairly recent regression]2021-07-14T13:55:43ZbgmCannot edit a membership without a payment [fairly recent regression]To reproduce:
* https://dmaster.demo.civicrm.org/civicrm/contact/view?reset=1&cid=203
* Add a membership of type general
* Important: Do not recurd a payment
* save
* Then click "edit" on that new membership
* do not edit anything...To reproduce:
* https://dmaster.demo.civicrm.org/civicrm/contact/view?reset=1&cid=203
* Add a membership of type general
* Important: Do not recurd a payment
* save
* Then click "edit" on that new membership
* do not edit anything
* click save
Causes a PHP fatal error:
> TypeError: Argument 1 passed to CRM_Financial_BAO_Order::setOverrideTotalAmount() must be of the type float, string given
```
$this->order->setOverrideTotalAmount($formValues['total_amount']);
```
Casting to float seems to fix it, but presumably not a good idea.5.36.1https://lab.civicrm.org/dev/core/-/issues/2532Regression (5.36) - can't find soft-credit contact by contact id2021-04-14T04:10:13ZeileenRegression (5.36) - can't find soft-credit contact by contact idWe just pushed out 5.37 & a user has reported that contact id has gone missing from
![no_contact](https://phab.wmfusercontent.org/file/data/xq6tods7o3flmitss5s7/PHID-FILE-ggor3hyhsee7kairhdqk/preview-Screen_Shot_2021-04-13_at_2.38.43_PM...We just pushed out 5.37 & a user has reported that contact id has gone missing from
![no_contact](https://phab.wmfusercontent.org/file/data/xq6tods7o3flmitss5s7/PHID-FILE-ggor3hyhsee7kairhdqk/preview-Screen_Shot_2021-04-13_at_2.38.43_PM.png)
It was removed in
https://github.com/civicrm/civicrm-core/commit/9f61f456e9802f9734158ff74387bb8cd2886017
in order to improve the selectors elsewhere (angular I think). However, typing a contact id doesn't work without selecting that or if I just put that one line back either now
@colemanw I think it needs to go back in the list for congruousness with other items in the listhttps://lab.civicrm.org/dev/core/-/issues/2528upgrade error2021-04-15T19:41:20Zeileenupgrade error5.35 to 5.37
* ERROR USERINFO: ALTER TABLE civicrm_group ADD CONSTRAINT `FK_civicrm_group_saved_search_id` FOREIGN KEY (`saved_search_id`) REFERENCES `civicrm_saved_search`(`id`) ON DELETE CASCADE [nativecode=1005 ** Can't create table...5.35 to 5.37
* ERROR USERINFO: ALTER TABLE civicrm_group ADD CONSTRAINT `FK_civicrm_group_saved_search_id` FOREIGN KEY (`saved_search_id`) REFERENCES `civicrm_saved_search`(`id`) ON DELETE CASCADE [nativecode=1005 ** Can't create table `civicrm`.`civicrm_group` (errno: 121 "Duplicate key on write or update")]5.37.0https://lab.civicrm.org/dev/core/-/issues/2513Dashlet reports not scrollable2021-04-07T14:12:26ZAllenShawDashlet reports not scrollableOverview
----------------------------------------
Scrolling problems prevent full view of expanded dashlet content.
Current behaviour
----------------------------------------
On the CiviCRM home dashboard, a dashlet may be expanded usin...Overview
----------------------------------------
Scrolling problems prevent full view of expanded dashlet content.
Current behaviour
----------------------------------------
On the CiviCRM home dashboard, a dashlet may be expanded using the "View Fullscreen" icon (fa-expand). This does expand the dashlet, but that expanded dashlet is not scrollable. If the dashlet output is many rows, the dashlet simply extends its display below the bottom edge of the viewport.
At the same time, scrollbars are removed from the page itself. Therefore, there's no way to scroll down to see the bottom of the expanded dashlet output. (Mouse-wheel scrolling is also nonresponsive in this situation.)
See this animaged image:
![anim](/uploads/b0e83ea948708aabcdd5cc033d65e23d/anim.gif)
Expected behaviour
----------------------------------------
I should have some way of scrolling down to see the full dashlet content.
Environment information
----------------------------------------
* Browser: Chromium
Version 89.0.4389.90 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)
* Drupal/CiviCRM: dmaster.demo.civicrm.org, as of today ("Powered by CiviCRM 5.37.alpha1.")
Comments
----------------------------------------
A dev site with civicrm 5.28.3 shows me that the expanded dashlet had working vertical scrollbars in that version.https://lab.civicrm.org/dev/core/-/issues/2511[Unconfirmed Regression] CiviCRM 5.35.1, contact checksum URL is corrupted in...2021-04-27T01:47:46Zjustinfreeman (Agileware)[Unconfirmed Regression] CiviCRM 5.35.1, contact checksum URL is corrupted in Mailings when click thru tracking is enabledCiviCRM 5.35.1, when click thru tracking is enabled, the contact checksum URL is corrupted and will not work. Issue is most likely in the flexmailer extension, as that rewrites the tracker.
Agileware Ref: CIVICRM-1693CiviCRM 5.35.1, when click thru tracking is enabled, the contact checksum URL is corrupted and will not work. Issue is most likely in the flexmailer extension, as that rewrites the tracker.
Agileware Ref: CIVICRM-1693https://lab.civicrm.org/dev/core/-/issues/2498Regression dedupe threshold2021-04-19T01:19:26ZeileenRegression dedupe threshold![image](/uploads/f3b9df6dfa67374428ea472501166a73/image.png)
From https://github.com/civicrm/civicrm-core/commit/246500181dbfcdc72a528ad4893e51f295fc3124
Code looks right on first glance to am debugging![image](/uploads/f3b9df6dfa67374428ea472501166a73/image.png)
From https://github.com/civicrm/civicrm-core/commit/246500181dbfcdc72a528ad4893e51f295fc3124
Code looks right on first glance to am debugging5.36.1https://lab.civicrm.org/dev/core/-/issues/2478CiviCRM 5.35.1 - CiviCRM falls back to using domPDF despite having a valid pa...2021-03-30T10:07:20Zjustinfreeman (Agileware)CiviCRM 5.35.1 - CiviCRM falls back to using domPDF despite having a valid path and executable for wkhtmlpdfSince CiviCRM 5.35.1. CiviCRM falls back to using domPDF despite having a valid path and executable for wkhtmlpdf. Appears that this problem was introduced with this change, https://github.com/civicrm/civicrm-core/commit/6bbe0cf6c513c49f...Since CiviCRM 5.35.1. CiviCRM falls back to using domPDF despite having a valid path and executable for wkhtmlpdf. Appears that this problem was introduced with this change, https://github.com/civicrm/civicrm-core/commit/6bbe0cf6c513c49f89179aa153cabad3a2a059b7 / PR https://github.com/civicrm/civicrm-core/pull/19311
For CiviCRM sites hosted in an environment with an [open_basedir restriction](https://www.php.net/manual/en/ini.core.php#ini.open-basedir) enabled, CiviCRM will be incorrectly report that the wkhtmlpdf can't be found. Despite this Knp\Snappy\Pdf will execute wkhtmlpdf without any problems.
The recent change uses the false positive for the wkhtmlpdf path to then trigger the fallback to domPDF to be used.
Agileware Ref: CIVICRM-16905.36.0https://lab.civicrm.org/dev/core/-/issues/2473Create followup section at bottom of non-bulk email activities crashes2021-03-24T13:05:40ZDaveDCreate followup section at bottom of non-bulk email activities crashesThis must be somewhat recent. If you leave the assignee blank it's trying to insert "0" as the activity assignee, which causes a constraint violation. I'm not sure what changed yet.
Works in 5.30. Fails in 5.31+This must be somewhat recent. If you leave the assignee blank it's trying to insert "0" as the activity assignee, which causes a constraint violation. I'm not sure what changed yet.
Works in 5.30. Fails in 5.31+5.36.0https://lab.civicrm.org/dev/core/-/issues/2443Can't select field to update contribution2021-03-09T04:46:21ZeileenCan't select field to update contribution![image](/uploads/b676aeddc7fbd013ff7ddfe6aa304177/image.png)
@colemanw I'm pretty sure this is some sort of metadata regression. It's on 5.36 rc & master from my testing - see how I can't choose the field I want to update?
There is a ...![image](/uploads/b676aeddc7fbd013ff7ddfe6aa304177/image.png)
@colemanw I'm pretty sure this is some sort of metadata regression. It's on 5.36 rc & master from my testing - see how I can't choose the field I want to update?
There is a js error but I haven't managed to get to the crux of it5.36.0