Development issueshttps://lab.civicrm.org/groups/dev/-/issues2022-01-06T00:13:17Zhttps://lab.civicrm.org/dev/core/-/issues/3018Cannot configure repeat events in CiviCRM2022-01-06T00:13:17ZChabadrichmondCannot configure repeat events in CiviCRMWhen trying to create an event and add repeating it shows a critical wordpress error page.
If I go into an existing event and try to go the repeat tab it gives me the network error.
This seems somewhat recent (maybe since V 5.3x... but I...When trying to create an event and add repeating it shows a critical wordpress error page.
If I go into an existing event and try to go the repeat tab it gives me the network error.
This seems somewhat recent (maybe since V 5.3x... but I had the issue on 5.42 and 5.44)
I could not replicate on CiviCRM demo site but was able to replicate on both demos which show on the CiviCRM website [here](https://civicrm.org/demo?field_language_value=All&field_cms_demo_value=wordpress)
Attaching a VIDEO to show what's happening.
![Screen_Recording_2022-01-04_at_10.20.36_PM](/uploads/745accbe5266fd731c9799234585e6b6/Screen_Recording_2022-01-04_at_10.20.36_PM.mov)5.45.0https://lab.civicrm.org/dev/core/-/issues/3013Can't create > 25 thank-you letters from contributions2021-12-30T03:41:35ZJonGoldCan't create > 25 thank-you letters from contributionsThis is a regression in 5.44 from https://github.com/civicrm/civicrm-core/pull/21816. API3 25 record limit bug.
### Steps to replicate
* Do a contribution search that yields > 25 records.
* Create PDF thank-you letters from all records...This is a regression in 5.44 from https://github.com/civicrm/civicrm-core/pull/21816. API3 25 record limit bug.
### Steps to replicate
* Do a contribution search that yields > 25 records.
* Create PDF thank-you letters from all records.
Get this error:
```
TypeError: Argument 2 passed to CRM_Contribute_Form_Task_PDFLetter::resolveTokens() must be of the type int, null given, called in /home/jon/local/crcl/htdocs/sites/all/modules/civicrm/CRM/Contribute/Form/Task/PDFLetter.php on line 436 in CRM_Contribute_Form_Task_PDFLetter->resolveTokens() (line 553 of /home/jon/local/crcl/htdocs/sites/all/modules/civicrm/CRM/Contribute/Form/Task/PDFLetter.php).
```JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/3000Can't save a shared address twice when you have custom address fields2021-12-25T19:34:53ZJonGoldCan't save a shared address twice when you have custom address fieldsThis is a regression from https://github.com/civicrm/civicrm-core/pull/21313, which is in Civi 5.42+.
### Steps to replicate
* Create an address custom field (it may have to be a certain type; it happens with alphanumeric select-autocom...This is a regression from https://github.com/civicrm/civicrm-core/pull/21313, which is in Civi 5.42+.
### Steps to replicate
* Create an address custom field (it may have to be a certain type; it happens with alphanumeric select-autocomplete for sure).
* Create or re-save an address on a contact (to create its custom field record).
* On a second contact, share the address from the first contact and save.
* Edit the address on the second contact and save.
### Expected result
Saves successfully.
### Actual result
`"DB Error: already exists"`
### Comments
The `entity_id` on a custom value field must be unique, but the PR mentioned above forces an `INSERT` when copying the custom fields of the original address.5.45.0https://lab.civicrm.org/dev/core/-/issues/2974Membership status update breaks if override is removed2021-12-02T05:48:05ZJonGoldMembership status update breaks if override is removed### Steps to replicate
* Open a membership whose status should be "New" or "Current".
* Override the membership so the status is "Expired".
* Remove the override status and save.
### Expected Behavior
Membership returns to its normal st...### Steps to replicate
* Open a membership whose status should be "New" or "Current".
* Override the membership so the status is "Expired".
* Remove the override status and save.
### Expected Behavior
Membership returns to its normal status.
### Actual Behavior
Membership retains its override status, with no way to fix except with another override.
Additionally, the "Update Memberships" scheduled job doesn't work
This is a regression in 5.42, which I've tracked down to https://github.com/civicrm/civicrm-core/pull/20976.
I'm thinking the solution would be to clear the `status_id` when removing an override (likely with JS at the form level) but I'm not clear on the reason for the change so I'll let wiser heads prevail.5.44.0https://lab.civicrm.org/dev/core/-/issues/2973Custom fields all broken2021-12-01T03:19:28ZDaveDCustom fields all brokenMust be pretty recent. Noticed it locally and confirmed on dmaster.demo.
The fields are unusable on any entity edit form and all say NULL.
![Untitled](/uploads/3ec5d44c1d954956076f9e9a5f208892/Untitled.png)Must be pretty recent. Noticed it locally and confirmed on dmaster.demo.
The fields are unusable on any entity edit form and all say NULL.
![Untitled](/uploads/3ec5d44c1d954956076f9e9a5f208892/Untitled.png)5.45.0https://lab.civicrm.org/dev/core/-/issues/2952Multivalued custom field as "tab with table" no longer shows the tab2021-11-11T18:48:17ZDaveDMultivalued custom field as "tab with table" no longer shows the tab1. Create a custom field group and set it to be multivalued with style Tab with Table.
1. Add a field.
1. When you visit a contact record there's supposed to be a tab for it, but now it shows 2 Change Log tabs instead. On dmaster.demo I ...1. Create a custom field group and set it to be multivalued with style Tab with Table.
1. Add a field.
1. When you visit a contact record there's supposed to be a tab for it, but now it shows 2 Change Log tabs instead. On dmaster.demo I get a slightly different problem but still wrong - two tabs for the custom field group.
Maybe from https://github.com/civicrm/civicrm-core/pull/21991 ? Haven't confirmed.5.45.0https://lab.civicrm.org/dev/core/-/issues/2947event token values missing from pdf export from participant search2021-11-15T11:00:40ZJanecevent token values missing from pdf export from participant search5.43.1https://lab.civicrm.org/dev/core/-/issues/2942Displaying map for contact address causes WP error2021-11-15T07:59:28Ztreasurer@tricitiesprideDisplaying map for contact address causes WP errorOverview
----------------------------------------
Selecting "map" from the contact detail causes a Wordpress error.
![image](/uploads/6da1e74e2278d36dd879c7cf4a106605/image.png)
![image](/uploads/86c348df39b887caa6d56a9f92756bee/image....Overview
----------------------------------------
Selecting "map" from the contact detail causes a Wordpress error.
![image](/uploads/6da1e74e2278d36dd879c7cf4a106605/image.png)
![image](/uploads/86c348df39b887caa6d56a9f92756bee/image.png)
Reproduction steps
----------------------------------------
1. Click on **Contacts -> Map**.
Current behaviour
----------------------------------------
Selecting "map" from the contact detail causes a Wordpress error.
![image](/uploads/6da1e74e2278d36dd879c7cf4a106605/image.png)
![image](/uploads/86c348df39b887caa6d56a9f92756bee/image.png)
```
Error Details
=============
An error of type E_ERROR was caused in line 128 of the file /wp-content/plugins/civicrm/civicrm/CRM/Contact/Form/Task/Map.php. Error message: Uncaught Error: Using $this when not in object context in /wp-content/plugins/civicrm/civicrm/CRM/Contact/Form/Task/Map.php:128
Stack trace:
#0 /wp-content/plugins/civicrm/civicrm/CRM/Contact/Form/Task/Map.php(92): CRM_Contact_Form_Task_Map::createMapXML(Array, 1, Object(CRM_Contact_Form_Task_Map), true, 'Contact')
#1 /wp-content/plugins/civicrm/civicrm/CRM/Core/Form.php(629): CRM_Contact_Form_Task_Map->preProcess()
#2 /wp-content/plugins/civicrm/civicrm/CRM/Core/QuickForm/Action/Display.php(76): CRM_Core_Form->buildForm()
#3 /wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Contact_Form_Task_Map), 'display')
#4 /wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_C
```
Expected behaviour
----------------------------------------
Map should display
Environment information
----------------------------------------
* __Browser:__ _Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36_
* __CiviCRM:__ Version 5.43.0
* __PHP:__ _7.4.22__
* __CMS:__ _Wordpress Version 5.8.1_
* __Database:__ MariaDB 10.3.31-MariaDB-log-cll-lve - MariaDB Server..._
* __Web Server:__ Apache 2.4.48_5.43.1https://lab.civicrm.org/dev/core/-/issues/2923Upgrade to 5.43-RC causes Fatal `Class 'CRM_Contact_Form_Search_Custom_Base' ...2021-10-31T15:52:13ZkcristianoUpgrade to 5.43-RC causes Fatal `Class 'CRM_Contact_Form_Search_Custom_Base' not found`Upgrade to today's RC from 5.39.3 results in fatal errors and being unable to load the Admin UI or run `cv` commands.
`cv flush` results in
```
[Symfony\Component\Debug\Exception\FatalThrowableError]
Class 'CRM_Contact_Form_Search_C...Upgrade to today's RC from 5.39.3 results in fatal errors and being unable to load the Admin UI or run `cv` commands.
`cv flush` results in
```
[Symfony\Component\Debug\Exception\FatalThrowableError]
Class 'CRM_Contact_Form_Search_Custom_Base' not found
```
Removing all files (except .htaccess) under `templates_c` does not correct this error.
any other `cv` command results in the same error. `wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsetting%2FupdateConfigBackend&reset=1`cannot load trying to clear from `/wp-admin/admin.php?page=civi_options` also fails
log shows:
```
[22-Oct-2021 12:49:27 UTC] PHP Fatal error: Uncaught Error: Class 'CRM_Contact_Form_Search_Custom_Base' not found in /home/wpcv/public_html/wp-content/uploads/civicrm/ext/dataprocessor/CRM/DataprocessorSearch/Form/Search/Custom/DataprocessorSmartGroupIntegration.php:29
Stack trace:
#0 /home/wpcv/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/ClassLoader.php(220): require_once()
#1 [internal function]: CRM_Core_ClassLoader->loadClass('CRM_Dataprocess...')
#2 /home/wpcv/public_html/wp-content/plugins/civicrm/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php(214): spl_autoload_call('CRM_Dataprocess...')
#3 /home/wpcv/public_html/wp-content/plugins/civicrm/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php(44): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'civi.dao.postUp...', Object(Civi\Core\DAO\Event\PostUpdate))
#4 /home/wpcv/public_html/wp-content/plugins/civicrm/civicrm/Civi/Core/CiviEventDispatcher.php(198): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('civi.dao.postUp...', Object(Civi\Co in /home/wpcv/public_html/wp-content/uploads/civicrm/ext/dataprocessor/CRM/DataprocessorSearch/Form/Search/Custom/DataprocessorSmartGroupIntegration.php on line 29
```
I had updated this site last week to 5.43-RC but I rolled back to production (5.39.3) for other reasons and today's RC build fails.
I can update to 5.42.1, so the issue appears to be in the RC.
I have not tried disabling DataProcessor before upgrade. I'll try thta and report back.https://lab.civicrm.org/dev/core/-/issues/2914Count of sent messages can be wrong in status popup for email form2021-10-18T14:28:03ZDaveDCount of sent messages can be wrong in status popup for email formMaster and 5.43 are broken right at this moment and you can't send any email, but in 5.43+ if you do this:
1. Contacts - New Email.
1. Add one of more valid recipients.
1. Fill it out and send.
1. The status popup will say 0 messages se...Master and 5.43 are broken right at this moment and you can't send any email, but in 5.43+ if you do this:
1. Contacts - New Email.
1. Add one of more valid recipients.
1. Fill it out and send.
1. The status popup will say 0 messages sent, even though they were sent. The number it shows is however many were prepopulated on the form when it first opened, and doesn't account for any you added or subtracted.
(This isn't about emails that were for deceased or on-hold etc.)
It worked in 5.42.5.43.0https://lab.civicrm.org/dev/core/-/issues/2902Date fields are empty on memberships (created with pay later OR with an API c...2021-10-14T04:08:04ZjitendraDate fields are empty on memberships (created with pay later OR with an API call)To replicate -
- Create a contribution page with Membership + Pay later.
- Submit the page in live mode.
- Date fields (join, start & end) are empty for the membership.
Found while writing this test - https://github.com/colemanw/webfor...To replicate -
- Create a contribution page with Membership + Pay later.
- Submit the page in live mode.
- Date fields (join, start & end) are empty for the membership.
Found while writing this test - https://github.com/colemanw/webform_civicrm/pull/622
Probably related to https://github.com/civicrm/civicrm-core/pull/20759 merge where api/v3 code used to calculate the dates for all NEW memberships. https://github.com/civicrm/civicrm-core/pull/20759/files#diff-74f06c64d06b6b6c191ff86ab31113f7198e73c0a1f8c5487116e7b3faef26fcL95
Now, in BAO, the membership date calculation is avoided if `skipStatusCal` is set in the params. See https://github.com/civicrm/civicrm-core/blob/master/CRM/Member/BAO/Membership.php#L260
I think a test with below API should be able to replicate it in the test
```
$membership = civicrm_api3('Membership', 'create', [
'membership_type_id' => "General",
'contact_id' => 2,
'status_id' => "Current", (or Pending, New, etc)
'skipStatusCal' => 1,
]);
// Verify if membership dates are correctly set. Currently, they're not.
```
I've confirmed that CiviCRM v5.35 sets the date on the above API call, but >5.40 does NOT. Does that seem to be an unintentional change of behavior?
Not sure what should be the desired result - Does the API call need to set start_date separately when `skipStatusCal` is enabled?
OR
`skipStatusCal` should only skip the calculation of "status" on the membership and continue to set the dates as it used to do in previous versions?
fyi - @KarinG @eileen5.42.1https://lab.civicrm.org/dev/core/-/issues/2901Find Activities + Send Email task always says the contact is on hold or decea...2021-10-10T12:48:05ZDaveDFind Activities + Send Email task always says the contact is on hold or deceased etcEven if all the communication prefs are good and the email is valid it still gives the warning message and doesn't let you send.
1. Find Activities.
2. Select one that has a valid With Contact who isn't deceased and doesn't have email o...Even if all the communication prefs are good and the email is valid it still gives the warning message and doesn't let you send.
1. Find Activities.
2. Select one that has a valid With Contact who isn't deceased and doesn't have email on hold etc.
3. From the actions dropdown choose send email
4. Choose With Contact.
5. Warning comes up and redirects you back to search. `Selected contact(s) do not have a valid email address, or communication preferences specify DO NOT EMAIL, or they are deceased or Primary email address is On Hold.`
I'm putting regression but not 100% sure it is recent.5.43.0https://lab.civicrm.org/dev/core/-/issues/2897Send an email activity is weird -possible unreleased regression in 5.43/master2021-10-10T01:01:55ZeileenSend an email activity is weird -possible unreleased regression in 5.43/masterhttps://lab.civicrm.org/dev/core/-/issues/2895Emails can't resolve tokens for non-contact components for recipients added t...2021-10-13T20:23:45ZDaveDEmails can't resolve tokens for non-contact components for recipients added to the list after email form was openedhttps://github.com/civicrm/civicrm-core/pull/21745#discussion_r724286717
Affects 5.43 only.
e.g.
1. Create a case email, e.g. clicking on the mail icon in the roles section.
1. Add a recipient to the recipient field.
1. In the body pu...https://github.com/civicrm/civicrm-core/pull/21745#discussion_r724286717
Affects 5.43 only.
e.g.
1. Create a case email, e.g. clicking on the mail icon in the roles section.
1. Add a recipient to the recipient field.
1. In the body put something like `Dear {contact.display_name} Case {case.id}`
1. The email sent to the original recipient will resolve case.id. The added recipient will have it blank.
See below this also applies to other non-contact components, e.g. event tokens.5.43.0https://lab.civicrm.org/dev/core/-/issues/2861regression: Custom searches are completely broken when used as smart groups2021-09-25T08:04:08ZJonGoldregression: Custom searches are completely broken when used as smart groupsI'm attaching a video that demonstrates the replication steps, but:
* Create a new custom search.
* The results of the search are correct.
* Save the results as a smart group.
* View the smart group.
* The smart group contains all contac...I'm attaching a video that demonstrates the replication steps, but:
* Create a new custom search.
* The results of the search are correct.
* Save the results as a smart group.
* View the smart group.
* The smart group contains all contacts.
![broken_custom_searches](/uploads/7298e847393f8456bb907c80820c6d93/broken_custom_searches.mp4)
This led to someone emailing all contacts in their database on a CiviMail, which they're predictably taking seriously.
I traced the issue and found that at `CRM_Contact_BAO_GroupContactCache::insertGroupContactsIntoTempTable()`, there's an [if statement](https://github.com/civicrm/civicrm-core/blob/master/CRM/Contact/BAO/GroupContactCache.php#L832) that looks like it should evaluate to `TRUE` that evaluates to `FALSE` but forcing it to `TRUE` doesn't solve the problem.5.41.2https://lab.civicrm.org/dev/core/-/issues/2856Something something tokens something tokens2021-09-23T15:28:04ZDaveDSomething something tokens something tokensThe below line seems to now be a problem for contribution receipts when using Order api. Trying to track it down - a (non-core) unit test that was working before is failing.
https://github.com/civicrm/civicrm-core/blob/29d047d701c7223e7...The below line seems to now be a problem for contribution receipts when using Order api. Trying to track it down - a (non-core) unit test that was working before is failing.
https://github.com/civicrm/civicrm-core/blob/29d047d701c7223e7999fc1f66381022c3dee0e7/Civi/Token/TokenProcessor.php#L435
Based on the lines above it, filter is expected to possibly be null, so `$filter[0]` errors. That seems pretty clear regardless.
What's confusing me is there must be tests in core that would trigger this, basically anything that uses order api + payment to complete a contribution, so am looking closer.5.43.0https://lab.civicrm.org/dev/core/-/issues/2840Recent items list behaving weird2021-09-16T14:55:28ZDaveDRecent items list behaving weirdSeems ok in 5.41 but in master it seems to only show the most recent item, sometimes 2. Also affects the recentitems extension.Seems ok in 5.41 but in master it seems to only show the most recent item, sometimes 2. Also affects the recentitems extension.5.42.0https://lab.civicrm.org/dev/core/-/issues/2839Contribution Thank You letters always have "_preview" on the end of the filename2021-09-20T17:59:38ZDaveDContribution Thank You letters always have "_preview" on the end of the filenameThis seems to be in master (5.43). Works ok in 5.42.This seems to be in master (5.43). Works ok in 5.42.5.43.0https://lab.civicrm.org/dev/core/-/issues/2835Activity export broken - takes you to some other screen instead2021-09-14T05:00:39ZDaveDActivity export broken - takes you to some other screen instead1. Find Activities
1. Select a couple and from the dropdown choose export.
1. You're now on a different screen - which screen seems to depend where you were before.
1. Warning: Illegal offset type in CRM_Activity_StateMachine_Search->__c...1. Find Activities
1. Select a couple and from the dropdown choose export.
1. You're now on a different screen - which screen seems to depend where you were before.
1. Warning: Illegal offset type in CRM_Activity_StateMachine_Search->__construct() (line 41 of ...\CRM\Activity\StateMachine\Search.php).
Working in 5.40.3, not working in 5.41.5.42.0https://lab.civicrm.org/dev/core/-/issues/2829Dashboard error `Trying to access array offset on value of type null`2021-09-12T22:46:24ZDaveDDashboard error `Trying to access array offset on value of type null`Pretty sure this is coming from https://github.com/civicrm/civicrm-core/pull/21424 which was just merged today.
```
#0 ...\Civi\Api4\Query\Api4SelectQuery.php(1033): "Trying to access array offset on value of type null", "...\Civi\A..."...Pretty sure this is coming from https://github.com/civicrm/civicrm-core/pull/21424 which was just merged today.
```
#0 ...\Civi\Api4\Query\Api4SelectQuery.php(1033): "Trying to access array offset on value of type null", "...\Civi\A...", 1033, (Array:8))
#1 ...\Civi\Api4\Query\Api4SelectQuery.php(250): Civi\Api4\Query\Api4SelectQuery->autoJoinFK("dashboard_contact.id")
#2 ...\Civi\Api4\Query\Api4SelectQuery.php(148): Civi\Api4\Query\Api4SelectQuery->buildSelectClause()
#3 ...\Civi\Api4\Query\Api4SelectQuery.php(164): Civi\Api4\Query\Api4SelectQuery->getSql()
#4 ...\Civi\Api4\Generic\DAOGetAction.php(111): Civi\Api4\Query\Api4SelectQuery->run()
#5 ...\Civi\Api4\Generic\DAOGetAction.php(99): Civi\Api4\Generic\DAOGetAction->getObjects(Object(Civi\Api4\Generic\Result))
#6 ...\Civi\Api4\Provider\ActionObjectProvider.php(68): Civi\Api4\Generic\DAOGetAction->_run(Object(Civi\Api4\Generic\Result))
#7 ...\Civi\API\Kernel.php(149): Civi\Api4\Provider\ActionObjectProvider->invoke(Object(Civi\Api4\Generic\DAOGetAction))
#8 ...\Civi\Api4\Generic\AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAOGetAction))
#9 ...\api\api.php(85): Civi\Api4\Generic\AbstractAction->execute()
#10 ...\CRM\Core\BAO\Dashboard.php(69): civicrm_api4("Dashboard", "get", (Array:2))
#11 ...\CRM\Contact\Page\DashBoard.php(52): CRM_Core_BAO_Dashboard::getContactDashlets()
#12 ...\CRM\Core\Invoke.php(313): CRM_Contact_Page_DashBoard->run((Array:2), NULL)
#13 ...\CRM\Core\Invoke.php(69): CRM_Core_Invoke::runItem((Array:13))
#14 ...\CRM\Core\Invoke.php(36): CRM_Core_Invoke::_invoke((Array:2))
#15 ...\drupal\civicrm.module(458): CRM_Core_Invoke::invoke((Array:2))
#16 ...\includes\menu.inc(527): civicrm_invoke("dashboard")
#17 ...\index.php(21): menu_execute_active_handler()
#18 {main}
```5.43.0