Development issueshttps://lab.civicrm.org/groups/dev/-/issues2020-08-14T23:18:25Zhttps://lab.civicrm.org/dev/core/-/issues/1953Credit card fields still required when a $0 option is selected on event regis...2020-08-14T23:18:25Zmark-rodgers11markrodgers11@gmail.comCredit card fields still required when a $0 option is selected on event registration/contribution pageOverview
----------------------------------------
When submitting an event registration (or contribution page form) with a $0 price option selected the form fails validation, despite credit card fields being hidden. I noticed this on a C...Overview
----------------------------------------
When submitting an event registration (or contribution page form) with a $0 price option selected the form fails validation, despite credit card fields being hidden. I noticed this on a CiviCRM website I manage, reproduced on the circle interactive demo site, also @KarinG reproduced this on yet another site.
https://chat.civicrm.org/civicrm/pl/aer7pqut5b85t8ab83ax3iko3o
Reproduction steps
----------------------------------------
1. Go to an event registration page (or contribution page)
2. Select $0 price option
3. Submit form
Current behaviour
----------------------------------------
![image](/uploads/198a46411385f82538500f2a1d34e940/image.png)
Expected behaviour
----------------------------------------
Credit card fields should not be required when they're hidden.
Environment information
----------------------------------------
* __Browser:__ Chrome 84.0.4147.89
* __CiviCRM:__ 5.28.0
* __PHP:__ 7.2.31
* __CMS:__ Drupal 7.72
* __Database:__ MySQL 5.7.31
* __Web Server:__ _Apache 2.4.46
Comments
----------------------------------------
Works as intended on CiviCRM 5.26.2 but not 5.28.05.28.1https://lab.civicrm.org/dev/core/-/issues/1952Regression: Activities export results in DB error2020-08-15T02:36:42ZPradeep Nayakpradpnayak@gmail.comRegression: Activities export results in DB errorVersion: 5.28.0
Steps to replicate:
1. Find Activities
2. Select all activities (wont replicate if you select check box or limited activities)
3. Choose export activities action
Expected behaviour:
Should able to see export screen
Act...Version: 5.28.0
Steps to replicate:
1. Find Activities
2. Select all activities (wont replicate if you select check box or limited activities)
3. Choose export activities action
Expected behaviour:
Should able to see export screen
Actual Behaviour:
DB Error: no such field
Sql error detail:
```
Database Error Code: Unknown column 'activity_type.component_id' in 'where clause', 1054
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -19
[message] => DB Error: no such field
[mode] => 16
[debug_info] => SELECT ( civicrm_activity.id ), contact_a.id as contact_id, contact_a.contact_type as `contact_type`, contact_a.contact_sub_type as `contact_sub_type`, contact_a.sort_name as `sort_name`, contact_a.display_name as `display_name`, civicrm_activity.id as activity_id, civicrm_activity.activity_type_id, civicrm_activity.subject as activity_subject, civicrm_activity.activity_date_time as activity_date_time, 1, civicrm_activity.duration as activity_duration, civicrm_activity.location as activity_location, civicrm_activity.details as activity_details, civicrm_activity.source_record_id as source_record_id, civicrm_activity.is_test as activity_is_test, civicrm_activity.campaign_id as activity_campaign_id, civicrm_activity.engagement_level as activity_engagement_level, source_contact.sort_name as source_contact, activity_priority.label as activity_priority,
civicrm_activity.priority_id as priority_id, civicrm_activity.status_id as `status_id`, civicrm_activity.engagement_level as `engagement_level` FROM civicrm_contact contact_a LEFT JOIN civicrm_activity_contact
ON ( civicrm_activity_contact.contact_id = contact_a.id ) LEFT JOIN civicrm_activity
ON ( civicrm_activity.id = civicrm_activity_contact.activity_id
AND civicrm_activity.is_deleted = 0 AND civicrm_activity.is_current_revision = 1 ) INNER JOIN civicrm_contact
ON ( civicrm_activity_contact.contact_id = civicrm_contact.id and civicrm_contact.is_deleted != 1 ) LEFT JOIN civicrm_option_group option_group_activity_priority ON (option_group_activity_priority.name = 'priority') LEFT JOIN civicrm_option_value activity_priority ON (civicrm_activity.priority_id = activity_priority.value
AND option_group_activity_priority.id = activity_priority.option_group_id ) LEFT JOIN civicrm_activity AS parent_id ON civicrm_activity.id = parent_id.parent_id LEFT JOIN civicrm_activity_contact source_activity
ON (source_activity.activity_id = civicrm_activity_contact.activity_id
AND source_activity.record_type_id = 2)
LEFT JOIN civicrm_contact source_contact ON (source_activity.contact_id = source_contact.id) WHERE ( civicrm_activity.status_id IN ("1", "2") AND civicrm_activity.is_test = 0 ) AND (contact_a.is_deleted = 0) AND (civicrm_activity.activity_type_id IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 12, 17, 19, 22, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 54, 55)) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 5) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 6) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 9) GROUP BY civicrm_activity.id ORDER BY `contact_a`.`sort_name` ASC, `contact_a`.`id` [nativecode=1054 ** Unknown column 'activity_type.component_id' in 'where clause']
[type] => DB_Error
[user_info] => SELECT ( civicrm_activity.id ), contact_a.id as contact_id, contact_a.contact_type as `contact_type`, contact_a.contact_sub_type as `contact_sub_type`, contact_a.sort_name as `sort_name`, contact_a.display_name as `display_name`, civicrm_activity.id as activity_id, civicrm_activity.activity_type_id, civicrm_activity.subject as activity_subject, civicrm_activity.activity_date_time as activity_date_time, 1, civicrm_activity.duration as activity_duration, civicrm_activity.location as activity_location, civicrm_activity.details as activity_details, civicrm_activity.source_record_id as source_record_id, civicrm_activity.is_test as activity_is_test, civicrm_activity.campaign_id as activity_campaign_id, civicrm_activity.engagement_level as activity_engagement_level, source_contact.sort_name as source_contact, activity_priority.label as activity_priority,
civicrm_activity.priority_id as priority_id, civicrm_activity.status_id as `status_id`, civicrm_activity.engagement_level as `engagement_level` FROM civicrm_contact contact_a LEFT JOIN civicrm_activity_contact
ON ( civicrm_activity_contact.contact_id = contact_a.id ) LEFT JOIN civicrm_activity
ON ( civicrm_activity.id = civicrm_activity_contact.activity_id
AND civicrm_activity.is_deleted = 0 AND civicrm_activity.is_current_revision = 1 ) INNER JOIN civicrm_contact
ON ( civicrm_activity_contact.contact_id = civicrm_contact.id and civicrm_contact.is_deleted != 1 ) LEFT JOIN civicrm_option_group option_group_activity_priority ON (option_group_activity_priority.name = 'priority') LEFT JOIN civicrm_option_value activity_priority ON (civicrm_activity.priority_id = activity_priority.value
AND option_group_activity_priority.id = activity_priority.option_group_id ) LEFT JOIN civicrm_activity AS parent_id ON civicrm_activity.id = parent_id.parent_id LEFT JOIN civicrm_activity_contact source_activity
ON (source_activity.activity_id = civicrm_activity_contact.activity_id
AND source_activity.record_type_id = 2)
LEFT JOIN civicrm_contact source_contact ON (source_activity.contact_id = source_contact.id) WHERE ( civicrm_activity.status_id IN ("1", "2") AND civicrm_activity.is_test = 0 ) AND (contact_a.is_deleted = 0) AND (civicrm_activity.activity_type_id IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 12, 17, 19, 22, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 54, 55)) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 5) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 6) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 9) GROUP BY civicrm_activity.id ORDER BY `contact_a`.`sort_name` ASC, `contact_a`.`id` [nativecode=1054 ** Unknown column 'activity_type.component_id' in 'where clause']
[to_string] => [db_error: message="DB Error: no such field" code=-19 mode=callback callback=CRM_Core_Error::handle prefix="" info="SELECT ( civicrm_activity.id ), contact_a.id as contact_id, contact_a.contact_type as `contact_type`, contact_a.contact_sub_type as `contact_sub_type`, contact_a.sort_name as `sort_name`, contact_a.display_name as `display_name`, civicrm_activity.id as activity_id, civicrm_activity.activity_type_id, civicrm_activity.subject as activity_subject, civicrm_activity.activity_date_time as activity_date_time, 1, civicrm_activity.duration as activity_duration, civicrm_activity.location as activity_location, civicrm_activity.details as activity_details, civicrm_activity.source_record_id as source_record_id, civicrm_activity.is_test as activity_is_test, civicrm_activity.campaign_id as activity_campaign_id, civicrm_activity.engagement_level as activity_engagement_level, source_contact.sort_name as source_contact, activity_priority.label as activity_priority,
civicrm_activity.priority_id as priority_id, civicrm_activity.status_id as `status_id`, civicrm_activity.engagement_level as `engagement_level` FROM civicrm_contact contact_a LEFT JOIN civicrm_activity_contact
ON ( civicrm_activity_contact.contact_id = contact_a.id ) LEFT JOIN civicrm_activity
ON ( civicrm_activity.id = civicrm_activity_contact.activity_id
AND civicrm_activity.is_deleted = 0 AND civicrm_activity.is_current_revision = 1 ) INNER JOIN civicrm_contact
ON ( civicrm_activity_contact.contact_id = civicrm_contact.id and civicrm_contact.is_deleted != 1 ) LEFT JOIN civicrm_option_group option_group_activity_priority ON (option_group_activity_priority.name = 'priority') LEFT JOIN civicrm_option_value activity_priority ON (civicrm_activity.priority_id = activity_priority.value
AND option_group_activity_priority.id = activity_priority.option_group_id ) LEFT JOIN civicrm_activity AS parent_id ON civicrm_activity.id = parent_id.parent_id LEFT JOIN civicrm_activity_contact source_activity
ON (source_activity.activity_id = civicrm_activity_contact.activity_id
AND source_activity.record_type_id = 2)
LEFT JOIN civicrm_contact source_contact ON (source_activity.contact_id = source_contact.id) WHERE ( civicrm_activity.status_id IN ("1", "2") AND civicrm_activity.is_test = 0 ) AND (contact_a.is_deleted = 0) AND (civicrm_activity.activity_type_id IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 12, 17, 19, 22, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 54, 55)) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 5) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 6) AND (activity_type.component_id IS NULL OR activity_type.component_id <> 9) GROUP BY civicrm_activity.id ORDER BY `contact_a`.`sort_name` ASC, `contact_a`.`id` [nativecode=1054 ** Unknown column 'activity_type.component_id' in 'where clause']"]
)
```
Other information:
1. Can be replicated on https://dmaster.demo.civicrm.org/
2. Cannot replicate with user 15.28.1https://lab.civicrm.org/dev/core/-/issues/1945[Regression] Users without permission can edit recurring contributions2020-08-20T10:27:28Zjensschuppe[Regression] Users without permission can edit recurring contributionsOverview
----------------------------------------
Users _without_ the permission "edit contributions" can edit _recurring_ contributions of any contact (might be mitigated by specific scenarios, see below).
Reproduction steps
----------...Overview
----------------------------------------
Users _without_ the permission "edit contributions" can edit _recurring_ contributions of any contact (might be mitigated by specific scenarios, see below).
Reproduction steps
----------------------------------------
1. Create a user with a role that has only the following permissions:
* CiviCRM: access CiviCRM backend and API
* CiviContribute (Contributions): access CiviContribute
but explicitly _not_ the "CiviContribute (Contributions): Edit Contributions" permission
2. _Configure an ACL for them to view contacts in a specific group and their contributions._ - not sure this is necessary
3. With that user logged in, go to any visible contact's Contributions tab and the Recurring Contributions sub tab
Current behaviour
----------------------------------------
The user is presented links to edit recurring contributions and clicking it also shows the form. Saving the form is also allowed.
Expected behaviour
----------------------------------------
Editing should not be allowed, i.e. there should be no _Edit_ link at all and opening the forms should result in a 404.
Environment information
----------------------------------------
* __CiviCRM:__ 5.24.5
* __CMS:__ Drupal 7.30
Comments
----------------------------------------
This seems to have been introduced as a regression with https://github.com/civicrm/civicrm-core/pull/13237 which originated in #571.
The compared contact ID is retrieved using `$this->getContactID()` which calls `CRM_Core_Form::setContactID()` which states the following in its docblock:
```php
/**
* Get contact if for a form object. Prioritise
* - cid in URL if 0 (on behalf on someoneelse)
* (@todo consider setting a variable if onbehalf for clarity of downstream 'if's
* - logged in user id if it matches the one in the cid in the URL
* - contact id validated from a checksum from a checksum
* - cid from the url if the caller has ACL permission to view
* - fallback is logged in user (or ? NULL if no logged in user) (@todo wouldn't 0 be more intuitive?)
*
* @return NULL|int
*/
```
The relevant part seems to be: __`cid from the url if the caller has ACL permission to view`__, but I couldn't verify yet, since it's a production system this is appearing on.
Background: The scenario is a _regional department_ user (being restricted to viewing contacts of a specific regional group only - which is done using ACLs), who should be allowed to view contributions, but not edit them at all.
Since the aforementioned issue tried to bypass access checks for editing one's own recurring contributions, I'm not sure this is a correct assumption at all. There should be a separate permission for controlling whether editing own recurring contributions is allowed.5.28.1https://lab.civicrm.org/dev/core/-/issues/1937Upgrading a site that still has "mysql" in the dsn string breaks in latest ma...2020-08-28T01:22:17ZDaveDUpgrading a site that still has "mysql" in the dsn string breaks in latest masterI think it's partly because of https://github.com/civicrm/civicrm-packages/pull/302 but more because I remember once seeing something somewhere that civi silently converted mysql to mysqli for you, and maybe that has also been removed so...I think it's partly because of https://github.com/civicrm/civicrm-packages/pull/302 but more because I remember once seeing something somewhere that civi silently converted mysql to mysqli for you, and maybe that has also been removed somewhere. While reviewing it maybe I missed it.
The fix is easy, just update your DSN in civicrm.settings.php to explicitly say "mysqli".
The technical issue is that without that silent conversion, it ends up trying to load php-mysql. It's just confusing at first because the error is `extension not found`, which makes you think "Civi Extension", but it means php extension.
Going to label it regression, but it's not the usual type of regression and it just started yesterday.5.30.0https://lab.civicrm.org/dev/core/-/issues/1936When Contribution Page has no labels (just amounts) -> the Review and Thank y...2020-08-20T00:52:10ZKarinGWhen Contribution Page has no labels (just amounts) -> the Review and Thank you and Receipt all show string - null in ESR 5.27.4 AND dmaster [Regression]
Upgrading from 5.21.3 (previous ESR) to 5.27.4 (current ESR)
**To reproduce:**
Create a Contribution page -> Amounts section: fill in Amounts without Labels -> that produces:
![image](/uploads/e50c31e6542fe83feb249a8b321f4081/image.png...
Upgrading from 5.21.3 (previous ESR) to 5.27.4 (current ESR)
**To reproduce:**
Create a Contribution page -> Amounts section: fill in Amounts without Labels -> that produces:
![image](/uploads/e50c31e6542fe83feb249a8b321f4081/image.png)
Hit Review your Contribution button
**Before (5.21.3) -> all good**
![image](/uploads/45ca387ee6c46c0c14d2fea712ee657b/image.png)
**After (5.27.4) -> **
![image](/uploads/3300ecc0248bc39aff646a3d2916afb2/image.png)
the `null` is visible on Review, Thank you and Receipt.
**Quick solution:** hide label with CSS5.27.5https://lab.civicrm.org/dev/core/-/issues/1935Contribution Pages with On Behalf of Organization profile enabled stop workin...2020-08-08T16:09:03ZKarinGContribution Pages with On Behalf of Organization profile enabled stop working in ESR 5.27.4 [Regression]Upgrading from 5.21.3 (previous ESR) to 5.27.4 (current ESR).
**To reproduce:**
Enable the checkbox "Allow individuals to contribute and / or signup for membership on behalf of an organization" in the Contribution Page settings:
![image...Upgrading from 5.21.3 (previous ESR) to 5.27.4 (current ESR).
**To reproduce:**
Enable the checkbox "Allow individuals to contribute and / or signup for membership on behalf of an organization" in the Contribution Page settings:
![image](/uploads/6583b87856bc1ea6f1d22446686b7fb6/image.png)
**Problem:**
Visit Contribution Page + do NOT select to make an On Behalf of Contribution - pick your amounts, fill in card details and then click Review Contribution button at the bottom of the form:
Nothing happens; no error message. Just a non-responsive button.
**Digging in:** opening up the On Behalf of Contribution (after clicking Review Contribution button and nothng happening):
![image](/uploads/56551687401cae077e82ec64fdf837d6/image.png)
**Conclusion** -> Province/State is required even if this On Behalf of section is hidden.
**Quick Workaround:** in Localization -> set a default Province.
Solution @seamuslee -> see https://chat.civicrm.org/civicrm/pl/ehfq919d4jb6mk4yfmmy13mtgr
This fix was not backported to 5.27.x yethttps://lab.civicrm.org/dev/core/-/issues/1934Merging Contacts causes DB Error: Already Exists - conflict on setting table2020-09-03T20:15:33ZsadashivMerging Contacts causes DB Error: Already Exists - conflict on setting tableOverview
----------------------------------------
After upgrading my civicrm from 4.7.31 to 5.27.0 I found that merging contacts breaks. It no longer merges the contacts but shows DB Error: Already Exist as shown in the snapshot.
Repro...Overview
----------------------------------------
After upgrading my civicrm from 4.7.31 to 5.27.0 I found that merging contacts breaks. It no longer merges the contacts but shows DB Error: Already Exist as shown in the snapshot.
Reproduction steps
----------------------------------------
1. Click on **Contacts -> New Individual**.
2. Entered **First Name** and **Last Name** and clicked **Save**.
3. Follow same steps and create one more contact which is a duplicate.
4. Check if both contacts have a navigation entry in the civicrm_setting table
5. Click on **Search -> Find Contacts**.
6. Search by the name and locate the duplicates
7. Click on merge contact
8. Click merge
9. Got an error "**DB error**".
Current behaviour
----------------------------------------
![Screen_Shot_2020-08-04_at_2.57.24_PM](/uploads/0939bd069e2b722d1f0f5275692a4a9c/Screen_Shot_2020-08-04_at_2.57.24_PM.png)
Backtrace from ConfigLogs
```
Aug 06 04:12:23 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
) [code] => -5
[message] => DB Error: already exists
[mode] => 16
[debug_info] => UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714 [nativecode=1062 ** Duplicate entry '1-244336-navigation' for key 'index_domain_contact_name']
[type] => DB_Error
[user_info] => UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714 [nativecode=1062 ** Duplicate entry '1-244336-navigation' for key 'index_domain_contact_name']
[to_string] => [db_error: message="DB Error: already exists" code=-5 mode=callback callback=CRM_Core_Error::handle prefix="" info="UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714 [nativecode=1062 ** Duplicate entry '1-244336-navigation' for key 'index_domain_contact_name']"]
)
Aug 06 04:12:23 [debug] $backTrace = #0 /var/www/html/sites/all/modules/civicrm/CRM/Core/Error.php(205): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /var/www/html/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(922): CRM_Core_Error::handle(Object(DB_Error))
#2 /var/www/html/sites/all/modules/civicrm/packages/DB.php(998): PEAR_Error->__construct("DB Error: already exists", -5, 16, (Array:2), "UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714 [nat...")
#3 /var/www/html/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-5, 16, (Array:2), "UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714 [nat...")
#4 /var/www/html/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -5, 16, (Array:2), "UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714 [nat...", "DB_Error", TRUE)
#5 /var/www/html/sites/all/modules/civicrm/packages/DB/common.php(1925): PEAR->__call("raiseError", (Array:7))
#6 /var/www/html/sites/all/modules/civicrm/packages/DB/mysqli.php(935): DB_common->raiseError(-5, NULL, NULL, "UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714 [nat...", "1062 ** Duplicate entry '1-244336-navigation' for key 'index_domain_contact_n...")
#7 /var/www/html/sites/all/modules/civicrm/packages/DB/mysqli.php(405): DB_mysqli->mysqliRaiseError()
#8 /var/www/html/sites/all/modules/civicrm/packages/DB/common.php(1231): DB_mysqli->simpleQuery("UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714")
#9 /var/www/html/sites/all/modules/civicrm/packages/DB/DataObject.php(2696): DB_common->query("UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714")
#10 /var/www/html/sites/all/modules/civicrm/packages/DB/DataObject.php(1829): DB_DataObject->_query("UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714")
#11 /var/www/html/sites/all/modules/civicrm/CRM/Core/DAO.php(421): DB_DataObject->query("UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714")
#12 /var/www/html/sites/all/modules/civicrm/CRM/Core/DAO.php(1473): CRM_Core_DAO->query("UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714", TRUE)
#13 /var/www/html/sites/all/modules/civicrm/CRM/Dedupe/Merger.php(563): CRM_Core_DAO::executeQuery("UPDATE civicrm_setting SET contact_id = 244336 WHERE contact_id = 243714", (Array:0), TRUE, NULL, TRUE)
#14 /var/www/html/sites/all/modules/civicrm/CRM/Dedupe/Merger.php(1316): CRM_Dedupe_Merger::moveContactBelongings(Object(CRM_Dedupe_MergeHandler), (Array:12), (Array:0))
#15 /var/www/html/sites/all/modules/civicrm/CRM/Contact/Form/Merge.php(308): CRM_Dedupe_Merger::moveAllBelongings(244336, 243714, (Array:74))
#16 /var/www/html/sites/all/modules/civicrm/CRM/Core/Form.php(484): CRM_Contact_Form_Merge->postProcess()
#17 /var/www/html/sites/all/modules/civicrm/CRM/Core/StateMachine.php(144): CRM_Core_Form->mainProcess()
#18 /var/www/html/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Next.php(45): CRM_Core_StateMachine->perform(Object(CRM_Contact_Form_Merge), "next", "Next")
#19 /var/www/html/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Next->perform(Object(CRM_Contact_Form_Merge), "next")
#20 /var/www/html/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contact_Form_Merge), "next")
#21 /var/www/html/sites/all/modules/civicrm/CRM/Core/Controller.php(335): HTML_QuickForm_Page->handle("next")
#22 /var/www/html/sites/all/modules/civicrm/CRM/Utils/Wrapper.php(98): CRM_Core_Controller->run()
#23 /var/www/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(285): CRM_Utils_Wrapper->run("CRM_Contact_Form_Merge", "Merge Contact", (Array:0))
#24 /var/www/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(68): CRM_Core_Invoke::runItem((Array:13))
#25 /var/www/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
#26 /var/www/html/sites/all/modules/civicrm/drupal/civicrm.module(454): CRM_Core_Invoke::invoke((Array:3))
#27 /var/www/html/includes/menu.inc(527): civicrm_invoke("contact", "merge")
#28 /var/www/html/index.php(21): menu_execute_active_handler()
#29 {main}
```
Expected behaviour
----------------------------------------
Contact should be merged
Environment information
----------------------------------------
* __Browser:__ Tried on Firefox and chrome both
* __CiviCRM:__ Tried with 5.27.0
* __PHP:__ Tested with 7.2
* __CMS:__ Drupal 7.32
* __Database:__ MySQL 5.7.7
* __Web Server:__ Apache 2.4
Comments
----------------------------------------
Issue seems to be related to https://github.com/civicrm/civicrm-core/commit/bbc11d1920687d2e88c0fd24697032fd9a1b673f as reverting this change fixes this issue.5.28.1https://lab.civicrm.org/dev/core/-/issues/1930Contact merge form moves unchecked related entities2020-08-06T02:48:40ZPatrick Figelpfigel@greenpeace.orgContact merge form moves unchecked related entitiesWhile reviewing [this PR](https://github.com/civicrm/civicrm-core/pull/17981), I noticed that on latest master, the contact merge form moves related entities (e.g. contributions) even if the corresponding "Move related..." checkbox is un...While reviewing [this PR](https://github.com/civicrm/civicrm-core/pull/17981), I noticed that on latest master, the contact merge form moves related entities (e.g. contributions) even if the corresponding "Move related..." checkbox is unchecked.
I was able to reproduce this with all entities other than memberships (which has some special handling in the code, IIRC).
Not sure when exactly this regressed, but I was able to confirm it worked on 5.24.6.5.28.0https://lab.civicrm.org/dev/core/-/issues/1928Collapsed custom field set for activities with a required radio makes case ac...2020-09-18T15:11:46ZDaveDCollapsed custom field set for activities with a required radio makes case activity buttons seem disabledMight be from the recent jquery radio validation update. Haven't followed it through yet. Not even sure if it's specific to radio yet.
1. Create a custom fieldset for activities.
1. Make it apply to all activity types (not relevant just...Might be from the recent jquery radio validation update. Haven't followed it through yet. Not even sure if it's specific to radio yet.
1. Create a custom fieldset for activities.
1. Make it apply to all activity types (not relevant just makes this quicker).
1. Make it collapsed by default.
1. Add a radio field.
1. Make it required.
1. Administer - Customize - Display Prefs - Turn off popups (near the bottom). (Only relevant because then you can see the issue for all case activities - when it's on you only notice it for open case/creating a case.)
1. Create a case.
1. Fill out the client, subject, and case type but leave the collapsed custom field section collapsed.
1. Click Save. It appears as though nothing happened, but if you open the custom fieldset you can see why.5.29.0https://lab.civicrm.org/dev/core/-/issues/1927upgrade to 5.28.beta1 fails2020-08-05T01:07:06ZPradeep Nayakpradpnayak@gmail.comupgrade to 5.28.beta1 failsWith Contact types shown in below screenshot the upgrade fails with below error
![Screen_Shot_2020-08-04_at_23.55.00](/uploads/ff0affbc704cfabe4a4fea2b7f379161/Screen_Shot_2020-08-04_at_23.55.00.png)
```
Aug 04 23:51:52 [error] $Fat...With Contact types shown in below screenshot the upgrade fails with below error
![Screen_Shot_2020-08-04_at_23.55.00](/uploads/ff0affbc704cfabe4a4fea2b7f379161/Screen_Shot_2020-08-04_at_23.55.00.png)
```
Aug 04 23:51:52 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => exceptionHandler
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comment 'Internal name of Contact Type (or Subtype).' [nativecode=1138 ** Invalid use of NULL value]
[type] => DB_Error
[user_info] => ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comment 'Internal name of Contact Type (or Subtype).' [nativecode=1138 ** Invalid use of NULL value]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::exceptionHandler prefix="" info="ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comment 'Internal name of Contact Type (or Subtype).' [nativecode=1138 ** Invalid use of NULL value]"]
)
Aug 04 23:51:52 [debug] $backTrace = #0 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Core/Error.php(937): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(922): CRM_Core_Error::exceptionHandler(Object(DB_Error))
#2 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB.php(998): PEAR_Error->__construct("DB Error: unknown error", -1, 16, (Array:2), "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#3 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-1, 16, (Array:2), "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#4 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -1, 16, (Array:2), "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...", "DB_Error", TRUE)
#5 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/common.php(1925): PEAR->__call("raiseError", (Array:7))
#6 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/mysqli.php(936): DB_common->raiseError(-1, NULL, NULL, "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...", "1138 ** Invalid use of NULL value")
#7 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/mysqli.php(406): DB_mysqli->mysqliRaiseError()
#8 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/common.php(1231): DB_mysqli->simpleQuery("ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#9 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Utils/File.php(350): DB_common->query("ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#10 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Form.php(155): CRM_Utils_File::runSqlQuery("mysql://root:root@127.0.0.1:3306/civi_dru_crm?new_link=true", "-- https://github.com/civicrm/civicrm-core/pull/17579\nALTER TABLE `civicrm_n...", NULL)
#11 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Form.php(350): CRM_Upgrade_Form->source("-- https://github.com/civicrm/civicrm-core/pull/17579\nALTER TABLE `civicrm_n...", TRUE)
#12 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Form.php(384): CRM_Upgrade_Form->processLocales("/Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Increm...", "5.28.alpha1")
#13 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Incremental/Base.php(66): CRM_Upgrade_Form->processSQL("5.28.alpha1")
#14 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Task.php(74): CRM_Upgrade_Incremental_Base::runSql(Object(CRM_Queue_TaskContext), "5.28.alpha1")
#15 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Runner.php(202): CRM_Queue_Task->run(Object(CRM_Queue_TaskContext))
#16 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(36): CRM_Queue_Runner->runNext(TRUE)
#17 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/ErrorPolicy.php(90): CRM_Queue_Page_AJAX::{closure}()
#18 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(38): CRM_Queue_ErrorPolicy->call(Object(Closure))
#19 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php(278): CRM_Queue_Page_AJAX::runNext()
#20 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php(68): CRM_Core_Invoke::runItem((Array:13))
#21 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:5))
#22 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/drupal/civicrm.module(454): CRM_Core_Invoke::invoke((Array:5))
#23 /Users/pradeep/Sites/civi-drupal/includes/menu.inc(527): civicrm_invoke("upgrade", "queue", "ajax", "runNext")
#24 /Users/pradeep/Sites/civi-drupal/index.php(21): menu_execute_active_handler()
#25 {main}
Aug 04 23:51:52 [info] $CRM_Queue_Page_AJAX_runNext_error = PEAR_Exception: "DB Error: unknown error"
* ERROR TYPE: DB_Error
* ERROR CODE: -1
* ERROR MESSAGE: DB Error: unknown error
* ERROR MODE: 16
* ERROR USERINFO: ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comment 'Internal name of Contact Type (or Subtype).' [nativecode=1138 ** Invalid use of NULL value]
* ERROR DEBUGINFO: ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comment 'Internal name of Contact Type (or Subtype).' [nativecode=1138 ** Invalid use of NULL value]
#0 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(922): CRM_Core_Error::exceptionHandler(Object(DB_Error))
#1 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB.php(998): PEAR_Error->__construct("DB Error: unknown error", -1, 16, (Array:2), "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#2 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-1, 16, (Array:2), "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#3 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -1, 16, (Array:2), "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...", "DB_Error", TRUE)
#4 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/common.php(1925): PEAR->__call("raiseError", (Array:7))
#5 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/mysqli.php(936): DB_common->raiseError(-1, NULL, NULL, "ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...", "1138 ** Invalid use of NULL value")
#6 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/mysqli.php(406): DB_mysqli->mysqliRaiseError()
#7 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/packages/DB/common.php(1231): DB_mysqli->simpleQuery("ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#8 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Utils/File.php(350): DB_common->query("ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comme...")
#9 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Form.php(155): CRM_Utils_File::runSqlQuery("mysql://root:root@127.0.0.1:3306/civi_dru_crm?new_link=true", "-- https://github.com/civicrm/civicrm-core/pull/17579\nALTER TABLE `civicrm_n...", NULL)
#10 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Form.php(350): CRM_Upgrade_Form->source("-- https://github.com/civicrm/civicrm-core/pull/17579\nALTER TABLE `civicrm_n...", TRUE)
#11 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Form.php(384): CRM_Upgrade_Form->processLocales("/Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Increm...", "5.28.alpha1")
#12 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Upgrade/Incremental/Base.php(66): CRM_Upgrade_Form->processSQL("5.28.alpha1")
#13 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Task.php(74): CRM_Upgrade_Incremental_Base::runSql(Object(CRM_Queue_TaskContext), "5.28.alpha1")
#14 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Runner.php(202): CRM_Queue_Task->run(Object(CRM_Queue_TaskContext))
#15 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(36): CRM_Queue_Runner->runNext(TRUE)
#16 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/ErrorPolicy.php(90): CRM_Queue_Page_AJAX::{closure}()
#17 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(38): CRM_Queue_ErrorPolicy->call(Object(Closure))
#18 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php(278): CRM_Queue_Page_AJAX::runNext()
#19 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php(68): CRM_Core_Invoke::runItem((Array:13))
#20 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:5))
#21 /Users/pradeep/Sites/civi-drupal/sites/all/modules/civicrm/drupal/civicrm.module(454): CRM_Core_Invoke::invoke((Array:5))
#22 /Users/pradeep/Sites/civi-drupal/includes/menu.inc(527): civicrm_invoke("upgrade", "queue", "ajax", "runNext")
#23 /Users/pradeep/Sites/civi-drupal/index.php(21): menu_execute_active_handler()
#24 {main}
```
Caused problem from PR https://github.com/civicrm/civicrm-core/pull/17570
`ALTER TABLE civicrm_contact_type CHANGE name name varchar(64) not null comment 'Internal name of Contact Type (or Subtype).';` is executed from 5.28.alpha1.mysql.tpl just before populateMissingContactTypeName() is called in [upgrade_5_28_alpha1()](https://github.com/civicrm/civicrm-core/blob/master/CRM/Upgrade/Incremental/php/FiveTwentyEight.php#L89)5.28.0https://lab.civicrm.org/dev/core/-/issues/1920Help text bubble is empty and smarty errors when .hlp file is missing for set...2021-02-17T20:06:07ZDaveDHelp text bubble is empty and smarty errors when .hlp file is missing for settings formsFor example Administer - CiviMail - Mailer Settings.
I think this is related to the move towards generic settings in https://lab.civicrm.org/dev/core/-/issues/495, but at the moment looking at the related code it looks like help_text st...For example Administer - CiviMail - Mailer Settings.
I think this is related to the move towards generic settings in https://lab.civicrm.org/dev/core/-/issues/495, but at the moment looking at the related code it looks like help_text still depends on there being a corresponding .hlp file in the templates folder.
Even when there is help_text in the definition, it comes out like `<a class="helpicon" title=" Help" aria-label=" Help" href="#" onclick="CRM.help("", {"id":"civimail-sync-interval-id","file":"CRM\/Admin\/Form\/Setting\/Mail"}); return false;"> </a>`5.31.0https://lab.civicrm.org/dev/core/-/issues/1911Saving the contribution amounts tab removes the default-iness of the default ...2020-07-27T00:32:20ZDaveDSaving the contribution amounts tab removes the default-iness of the default amount when using fixed amount options. Or editing any price field that is not type text1. On a stock demo install, just save the amounts tab of the "Help Support CiviCRM" contribution page without making any changes.
2. The default of "Booster $10" is no longer checked.
3. Visiting the live contribution page has no default...1. On a stock demo install, just save the amounts tab of the "Help Support CiviCRM" contribution page without making any changes.
2. The default of "Booster $10" is no longer checked.
3. Visiting the live contribution page has no default amount checked, and clicking Review Your Contribution does nothing. There's no javascript errors in the browser console.
This seems to have started in 5.27. Note there is a slight difference between 5.27 and 5.28: In 5.27 clicking the Review button at least does something, whereas in 5.28/5.29 it doesn't.5.27.4https://lab.civicrm.org/dev/core/-/issues/1903E_WARNING when adding/editing a price set field2020-07-23T22:54:14ZDaveDE_WARNING when adding/editing a price set fieldIt appears to have started in 5.28, and I can reproduce on dmaster.demo.
To reproduce either add or edit a price set field, but either turn off popups or open in new tab otherwise the error is snippet'd out.
`Warning: Illegal string of...It appears to have started in 5.28, and I can reproduce on dmaster.demo.
To reproduce either add or edit a price set field, but either turn off popups or open in new tab otherwise the error is snippet'd out.
`Warning: Illegal string offset 'required' in CRM_Core_Form->addRequiredAttribute() (line 1188 of .../CRM/Core/Form.php).`
It's related to https://github.com/civicrm/civicrm-core/commit/77f68d88d633394c2ec17a5bbc77361620aa38bd but I'm not sure if it's just that. However it seems clear that `$attributes`, which is the same field as `$extra` earlier on, can be NULL, which is causing the error when it tries to do `$attributes['required']`, but then even ignoring that the code doesn't seem like it would ever work anyway. It's a local variable passed by value, so setting it to 1 in the function does nothing.
```
private function addRequiredAttribute($required, $attributes) {
$required ? $attributes['required'] = 1 : NULL;
}
```
I'm also confused by the fact that this warning should be coming up much more often based on my read of the add() function, but it doesn't seem to be. So I'm trying to assess the scope.5.28.0https://lab.civicrm.org/dev/core/-/issues/1899Text of activity action links has gone missing on manage case2020-07-26T21:53:18ZDaveDText of activity action links has gone missing on manage caseCan reproduce on dmaster.demo. It seems to have started in 5.27 (surprise!)
1. Create at least 2 cases. (The more dropdown doesn't appear if you only have one case.)
2. In the activities section, click the more dropdown at the far right...Can reproduce on dmaster.demo. It seems to have started in 5.27 (surprise!)
1. Create at least 2 cases. (The more dropdown doesn't appear if you only have one case.)
2. In the activities section, click the more dropdown at the far right of any activity.
3. There's no text for the action links.5.27.4https://lab.civicrm.org/dev/core/-/issues/1891"applyLocale()" does not apply desired locale when "inheritLocale" is set2023-09-05T13:38:59Zhaystack"applyLocale()" does not apply desired locale when "inheritLocale" is setFollowing up on #1890 it seems that the locale string in the `language` column in the `civicrm_uf_match` table is also redundant.
It is set [here](https://github.com/civicrm/civicrm-core/blob/fbb161e3a60900dd92f8dbf78b468b58233ee0be/CRM...Following up on #1890 it seems that the locale string in the `language` column in the `civicrm_uf_match` table is also redundant.
It is set [here](https://github.com/civicrm/civicrm-core/blob/fbb161e3a60900dd92f8dbf78b468b58233ee0be/CRM/Core/BAO/ConfigSetting.php#L173) when there is a locale requested in a URL that uses the `lcMessages` query param or when there's an existing locale set in the session.
The session locale is set from the `$ufm->language` locale [here](https://github.com/civicrm/civicrm-core/blob/fbb161e3a60900dd92f8dbf78b468b58233ee0be/CRM/Core/BAO/ConfigSetting.php#L187) when there's a logged-in user and the locale hasn't been determined by the `lcMessages` query param or there's no locale set in the session.
I cannot find anywhere else in the CiviCRM Core code where `$ufm->language` is read or set, so this appears to be circular logic that seems redundant to me.
Can we remove it since it's never actually used for anything practical?
**Correction:** both the `$ufm->language` and `lcMessages` session variable are set [here](https://github.com/civicrm/civicrm-core/blob/fbb161e3a60900dd92f8dbf78b468b58233ee0be/CRM/Admin/Form/Setting/Localization.php#L336-L338), but this only sets the locale for the Contact/User that saves that particular form. It doesn't alter the circularity of the logic in `applyLocale()`.5.29.0haystackhaystackhttps://lab.civicrm.org/dev/core/-/issues/1885E_WARNINGS on contact edit form related to groups2020-07-20T02:57:06ZDaveDE_WARNINGS on contact edit form related to groupsThis came up the other day while reviewing a PR but I couldn't reproduce it, but now today I'm seeing it on dmaster.demo (and elsewhere) so I assume it's from a recent change somewhere.
When saving a new contact that does not have a gro...This came up the other day while reviewing a PR but I couldn't reproduce it, but now today I'm seeing it on dmaster.demo (and elsewhere) so I assume it's from a recent change somewhere.
When saving a new contact that does not have a group:
`Warning: Invalid argument supplied for foreach() in CRM_Contact_BAO_Contact::create() (line 309 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Contact/BAO/Contact.php).`
When editing a contact that does have a group:
`Warning: htmlspecialchars() expects parameter 1 to be string, array given in HTML_Common->_getAttrString() (line 144 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/Common.php).`
And then it doesn't show the group on the form and then when saving that contact:
`Warning: array_key_exists() expects parameter 2 to be array, string given in CRM_Contact_Form_Contact->postProcess() (line 952 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Contact/Form/Contact.php).`5.29.0https://lab.civicrm.org/dev/core/-/issues/1882codeVersion not displayed in system status check error message about db versi...2020-07-16T01:28:18ZDaveDcodeVersion not displayed in system status check error message about db version vs codeversionIt's technically a regression (from here https://github.com/civicrm/civicrm-core/pull/17722/files#diff-50f6e167c4bfdcf605b5e0617d06b82d) but the check still comes up, it's just confusing since part of the message says `The v codebase may...It's technically a regression (from here https://github.com/civicrm/civicrm-core/pull/17722/files#diff-50f6e167c4bfdcf605b5e0617d06b82d) but the check still comes up, it's just confusing since part of the message says `The v codebase may not be compatible with your database state` - it's missing the number.
It's just because the variable got moved to another function, so it's blank at https://github.com/civicrm/civicrm-core/blob/e8270cb9e17d580b02605be9a8cf7217f0d5c0ad/CRM/Utils/Check/Component/Env.php#L7955.28.0https://lab.civicrm.org/dev/core/-/issues/1874Fatal error on new individual form, new contribution, new membership...2020-07-16T11:27:09ZDaveDFatal error on new individual form, new contribution, new membership...Something **very** recent is causing a fatal error on the new individual form. I think it's between commits 0f86b677f3 and 95266ab34b but I can't see what. It's not just my local - I can see it on this PR test site for example: http://co...Something **very** recent is causing a fatal error on the new individual form. I think it's between commits 0f86b677f3 and 95266ab34b but I can't see what. It's not just my local - I can see it on this PR test site for example: http://core-17766-50jo7.test-1.civicrm.org:8001 (admin pass TVCRm1QqkGcQ). But I don't think it's that PR, it's just an example of a recent test site where I see it.
It has to do with calling CRM_Core_SelectValues::date() with $type='mm/dd/yy', whereas normally it's a word, like 'birth'.5.27.2https://lab.civicrm.org/dev/core/-/issues/1868Slew of E_NOTICES on Profiles admin page and description field is always blank2020-07-11T11:30:17ZDaveDSlew of E_NOTICES on Profiles admin page and description field is always blankSeems to be from this https://github.com/civicrm/civicrm-core/commit/fdc2e63a7fb961c26bab02e9347ce44d2bdfde66#diff-9b81968d46b30094194b02c5dbf39b88L1668-L1671
PR: https://github.com/civicrm/civicrm-core/pull/17786Seems to be from this https://github.com/civicrm/civicrm-core/commit/fdc2e63a7fb961c26bab02e9347ce44d2bdfde66#diff-9b81968d46b30094194b02c5dbf39b88L1668-L1671
PR: https://github.com/civicrm/civicrm-core/pull/177865.29.0https://lab.civicrm.org/dev/core/-/issues/1865Mailing URLs using extern are adding query string in Joomla and WP2020-07-13T08:55:34ZkcristianoMailing URLs using extern are adding query string in Joomla and WPStarting in CiviCRM 5.27 mailing URLs using extern/url.php in both Joomla and WP are adding a query string to the destination URL. This issue is also in 5.28RC and latest master.
Steps to reproduce:
- Create a mailing
- Ensure Track C...Starting in CiviCRM 5.27 mailing URLs using extern/url.php in both Joomla and WP are adding a query string to the destination URL. This issue is also in 5.28RC and latest master.
Steps to reproduce:
- Create a mailing
- Ensure Track Click Throughs and Track Opens are selected
- Create a link to an external site such as startpage.com
- Send Mailing
- In Email Link is `http://joomla.test/index.php?option=com_civicrm&task=civicrm/mailing/url&u=11&qid=6` on Joomla and either `https://wplatest.test/civicrm/mailing/url/?u=4&qid=10` or `https://wplatest.test/civicrm?civiwp=CiviCRM&q=civicrm/mailing/url&u=129&qid=88` on WP (depending on Clean URLs being enabled or disabled
- Resultant URL you are taken to is:
- Joomla: `https://startpage.com/?option=com_civicrm`
- WP (With or without CleanURLs): `https://startpage.com/?civiwp=CiviCRM`
Drupal 7 is fine, as well as WP if you are bypassing the extern routing and using the WP REST API instead.
Internal links resolve fine as these are not tracked.
I have not found a case where `?option=com_civicrm` or `?civiwp=CiviCRM` has broken a link, but I imagine it could.
I have not tested Drupal 8 or backdrop.
I tested on CiviCRM 5.26.2 and the destination URLs were 'clean' with no query string so I am marking ths as a regression.5.27.2