Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-07-03T00:09:20Zhttps://lab.civicrm.org/dev/core/-/issues/2408Search kit - filter by groups2021-07-03T00:09:20ZeileenSearch kit - filter by groupsOn testing our first search-off-the-block with search kit I had some pretty bad performance issues (it didn't load). We used to have the same issue with CiviReport until I did some performance work which basically did the following
1) c...On testing our first search-off-the-block with search kit I had some pretty bad performance issues (it didn't load). We used to have the same issue with CiviReport until I did some performance work which basically did the following
1) created a temporary table of all the contact in the filtered group/s
2) used that table as the base table ie SELECT * FROM tempTABLE as hidden_table INNER JOIN civicrm_contact a ON a.id = hidden_table.id
3) told our users to always include a group filter in any reports
I worry that our thinking about how to 'properly' solve the groups issue might be blocking us from 'a solution that works as well as our existing searches/reports' - which could have some pretty big constraints on what is permitted (ie. you can filter by membership in specific group ids but that's it - which is pretty much all that works well currently) - as long as the api signature is OK-ish we can change what is under the hood later
Note the report in question was a Lybunt but the above does pretty much apply to all our reports
@totten @colemanw @seamuslee5.39.0https://lab.civicrm.org/dev/core/-/issues/2407Search kit uses a maria-db-reserved word2021-02-22T23:05:46ZeileenSearch kit uses a maria-db-reserved wordI found that when running the count query I was getting a db error - it turned out the word 'rows' in the below query is reserved in Maria DB from 10.2.4
```
SELECT count(*) AS `c` FROM ( SELECT `a`.`id` AS `id` FROM civicrm_contact a I...I found that when running the count query I was getting a db error - it turned out the word 'rows' in the below query is reserved in Maria DB from 10.2.4
```
SELECT count(*) AS `c` FROM ( SELECT `a`.`id` AS `id` FROM civicrm_contact a INNER JOIN `civicrm_contribution` `Contact_Contribution_contact_id_01` ON `Contact_Contribution_contact_id_01`.`contact_id` = `a`.`id` AND `a`.`id` = `Contact_Contribution_contact_id_01`.`contact_id` AND
blah blah
WHERE bla blah GROUP BY `a`.`id` ) AS rows;
```
https://mariadb.com/kb/en/reserved-words/5.35.0https://lab.civicrm.org/dev/core/-/issues/2198CiviMail "DB error": suspected core bug relating to attachment replace api2022-09-25T16:43:26ZedwardpetersCiviMail "DB error": suspected core bug relating to attachment replace apiOverview
----------------------------------------
In CiviMail, trying to send a Test mailing gives "Error - DB error - unknown error" on screen, see screenshot, and mail cannot be sent. Seems to be triggered by attachment replace api.
![...Overview
----------------------------------------
In CiviMail, trying to send a Test mailing gives "Error - DB error - unknown error" on screen, see screenshot, and mail cannot be sent. Seems to be triggered by attachment replace api.
![DBerror](/uploads/ae853f717ef1eecd051b826ff91b20de/DBerror.png)
Reproduction steps
----------------------------------------
1. Mailing -> New Mailing
2. Proceed to mailing template (I am using Mosaico) and try to send a Test.
Current behaviour
----------------------------------------
Error in the Civi Log is:
```
Nov 17 12:28:40 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => exceptionHandler
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not exist]
[type] => DB_Error
[user_info] => ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not exist]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::exceptionHandler prefix="" info="ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not exist]"]
)
Nov 17 12:28:40 [debug] $backTrace = #0 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Error.php(942): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /home/sclgulf/public_html/sclgulf/vendor/pear/pear-core-minimal/src/PEAR.php(944): CRM_Core_Error::exceptionHandler(Object(DB_Error))
#2 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB.php(977): PEAR_Error->__construct("DB Error: unknown error", -1, 16, (Array:2), "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...")
#3 /home/sclgulf/public_html/sclgulf/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-1, 16, (Array:2), "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...")
#4 /home/sclgulf/public_html/sclgulf/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -1, 16, (Array:2), "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...", "DB_Error", TRUE)
#5 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/common.php(1913): PEAR->__call("raiseError", (Array:7))
#6 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/mysqli.php(932): DB_common->raiseError(-1, NULL, NULL, "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...", "1305 ** SAVEPOINT civi_0 does not exist")
#7 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/mysqli.php(402): DB_mysqli->mysqliRaiseError()
#8 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/common.php(1219): DB_mysqli->simpleQuery("ROLLBACK TO SAVEPOINT civi_0")
#9 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/packages/DB/DataObject.php(2696): DB_common->query("ROLLBACK TO SAVEPOINT civi_0")
#10 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/packages/DB/DataObject.php(1829): DB_DataObject->_query("ROLLBACK TO SAVEPOINT civi_0")
#11 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/DAO.php(445): DB_DataObject->query("ROLLBACK TO SAVEPOINT civi_0")
#12 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/Core/Transaction/Frame.php(153): CRM_Core_DAO->query("ROLLBACK TO SAVEPOINT civi_0")
#13 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/Core/Transaction/Manager.php(103): Civi\Core\Transaction\Frame->finish()
#14 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Transaction.php(126): Civi\Core\Transaction\Manager->dec()
#15 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Transaction.php(175): CRM_Core_Transaction->commit()
#16 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Subscriber/DynamicFKAuthorization.php(240): CRM_Core_Transaction->run(Object(Closure))
#17 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Subscriber/DynamicFKAuthorization.php(181): Civi\API\Subscriber\DynamicFKAuthorization->authorizeDelegate("get", "civicrm_mailing", "130", (Array:8))
#18 /home/sclgulf/public_html/sclgulf/vendor/symfony/event-dispatcher/EventDispatcher.php(214): Civi\API\Subscriber\DynamicFKAuthorization->onApiAuthorize(Object(Civi\API\Event\AuthorizeEvent), "civi.api.authorize", Object(Civi\Core\CiviEventDispatcher))
#19 /home/sclgulf/public_html/sclgulf/vendor/symfony/event-dispatcher/EventDispatcher.php(44): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch((Array:5), "civi.api.authorize", Object(Civi\API\Event\AuthorizeEvent))
#20 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/Core/CiviEventDispatcher.php(129): Symfony\Component\EventDispatcher\EventDispatcher->dispatch("civi.api.authorize", Object(Civi\API\Event\AuthorizeEvent))
#21 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(219): Civi\Core\CiviEventDispatcher->dispatch("civi.api.authorize", Object(Civi\API\Event\AuthorizeEvent))
#22 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(148): Civi\API\Kernel->authorize(Object(Civi\API\Provider\MagicFunctionProvider), (Array:8))
#23 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest((Array:8))
#24 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/api.php(22): Civi\API\Kernel->runSafe("Attachment", "get", (Array:4))
#25 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/v3/utils.php(1800): civicrm_api("Attachment", "get", (Array:4), (Array:5))
#26 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/v3/Generic.php(398): _civicrm_api3_generic_replace("Attachment", (Array:5))
#27 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Provider/MagicFunctionProvider.php(85): civicrm_api3_generic_replace((Array:8))
#28 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(150): Civi\API\Provider\MagicFunctionProvider->invoke((Array:8))
#29 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest((Array:8))
#30 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/api.php(22): Civi\API\Kernel->runSafe("Attachment", "replace", (Array:5))
#31 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Utils/REST.php(300): civicrm_api("Attachment", "replace", (Array:5))
#32 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Utils/REST.php(550): CRM_Utils_REST::process((Array:3), (Array:5))
#33 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(278): CRM_Utils_REST::ajax()
#34 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(68): CRM_Core_Invoke::runItem((Array:12))
#35 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
#36 /home/sclgulf/public_html/sclgulf/web/modules/contrib/civicrm/src/Civicrm.php(88): CRM_Core_Invoke::invoke((Array:3))
#37 /home/sclgulf/public_html/sclgulf/web/modules/contrib/civicrm/src/Controller/CivicrmController.php(80): Drupal\civicrm\Civicrm->invoke((Array:3))
#38 [internal function](): Drupal\civicrm\Controller\CivicrmController->main((Array:3), "")
#39 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array((Array:2), (Array:2))
#40 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#41 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#42 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext((Array:2), (Array:2))
#43 /home/sclgulf/public_html/sclgulf/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#44 /home/sclgulf/public_html/sclgulf/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#45 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#46 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#47 /home/sclgulf/public_html/sclgulf/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#48 /home/sclgulf/public_html/sclgulf/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#49 /home/sclgulf/public_html/sclgulf/web/modules/contrib/shield/src/ShieldMiddleware.php(91): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#50 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\shield\ShieldMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#51 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#52 /home/sclgulf/public_html/sclgulf/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#53 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/DrupalKernel.php(708): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#54 /home/sclgulf/public_html/sclgulf/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#55 {main}
```
Expected behaviour
----------------------------------------
Test mailing gets sent
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Safari 14.0.1_
* __CiviCRM:__ 5.29.0
* __PHP:__ _7.3__
* __CMS:__ _Drupal 8.96_
* __Database:__ _5.5.5-10.3.27-MariaDB_
* __Web Server:__ _Apache_
Comments
----------------------------------------
My developer says he thinks it is a core bug. "the error seems to be around transaction and how it's being rollbacked".
He has done a temporary patch so that mailings can get sent:
```
[~/www/sclgulf/vendor/civicrm/civicrm-core/api/v3]# diff utils.php utils.php.orig
1800,1805c1800,1803
< if ($entity != 'Attachment') {
< $preexisting = civicrm_api($entity, 'get', $baseParams, $params);
< if (civicrm_error($preexisting)) {
< $transaction->rollback();
< return $preexisting;
< }
---
> $preexisting = civicrm_api($entity, 'get', $baseParams, $params);
> if (civicrm_error($preexisting)) {
> $transaction->rollback();
> return $preexisting;
```5.52.0https://lab.civicrm.org/dev/core/-/issues/2091Participant join not working in search2020-12-17T20:00:42ZeileenParticipant join not working in searchURL
https://dmaster.demo.civicrm.org/civicrm/search#/create/Contact/?join=%5B%5B%22Participant%20AS%20participants%22,true%5D%5D
![Screen_Shot_2020-10-05_at_3.16.38_PM](/uploads/aaa16d483d6acf36f733d2335c608a26/Screen_Shot_2020-10-05_a...URL
https://dmaster.demo.civicrm.org/civicrm/search#/create/Contact/?join=%5B%5B%22Participant%20AS%20participants%22,true%5D%5D
![Screen_Shot_2020-10-05_at_3.16.38_PM](/uploads/aaa16d483d6acf36f733d2335c608a26/Screen_Shot_2020-10-05_at_3.16.38_PM.png)
@colemanw - reported by @JonGold on chathttps://lab.civicrm.org/dev/core/-/issues/2067Add relative date searching on search creator2021-01-19T03:57:57ZeileenAdd relative date searching on search creator5.34.0https://lab.civicrm.org/dev/core/-/issues/2030Dropdown for country seems to have reverted to a regular select instead of se...2020-09-22T22:47:09ZDaveDDropdown for country seems to have reverted to a regular select instead of select2Meant to record this earlier and forgot. For example on a contribution page the country dropdown is a regular select. It all works though.
I think it reverted around 5.27-ish.Meant to record this earlier and forgot. For example on a contribution page the country dropdown is a regular select. It all works though.
I think it reverted around 5.27-ish.5.31.0https://lab.civicrm.org/dev/core/-/issues/2029Fix the Test Result (1 failure / -190) E2E.Core.PrevNextTest.testDeleteByCach...2020-10-27T02:46:48ZeileenFix the Test Result (1 failure / -190) E2E.Core.PrevNextTest.testDeleteByCacheKey recurring test issuehttps://lab.civicrm.org/dev/core/-/issues/2007Finalise shim script2022-05-19T21:53:26ZeileenFinalise shim scripthttps://github.com/civicrm/civicrm-core/pull/17832https://github.com/civicrm/civicrm-core/pull/17832https://lab.civicrm.org/dev/core/-/issues/1980Add Line Item v4 API2020-09-10T19:29:08ZeileenAdd Line Item v4 APIIn order to do this there is some preliminary work to do as the v3 api has handling that needs to be unpacked first. In general there are 2 parts
1) Get & Delete - the goal here is to use a more conventional hook to do this in financial...In order to do this there is some preliminary work to do as the v3 api has handling that needs to be unpacked first. In general there are 2 parts
1) Get & Delete - the goal here is to use a more conventional hook to do this in financialacls core extension
2) Create - not too sure what this stuff is doing yet....5.31.0https://lab.civicrm.org/dev/core/-/issues/1973Email & Phone storage issues in event location2020-09-18T01:07:09ZjitendraEmail & Phone storage issues in event location**Email** - Second field value cannot be saved on form submit.
To replicate -
- Navigate to Event -> Location tab - https://dmaster.demo.civicrm.org/civicrm/event/manage/location?reset=1&action=update&id=3
- Enter a value for the secon...**Email** - Second field value cannot be saved on form submit.
To replicate -
- Navigate to Event -> Location tab - https://dmaster.demo.civicrm.org/civicrm/event/manage/location?reset=1&action=update&id=3
- Enter a value for the second email field and save. The second field is empty after the form is submitted. And Email2 value is displayed on the first email field
**Phone**: Every time the Location form is submitted, a new row is inserted in phone table even if it already exist.
To replicate -
- Navigate to Event -> Location tab - https://dmaster.demo.civicrm.org/civicrm/event/manage/location?reset=1&action=update&id=3
- Fill both the phone numbers and save.
- Re-save the form without changing any value. 2 new duplicate rows have been inserted in `civicrm_phone` table.
- This happens on every submission of the Location form.
Reverting https://github.com/civicrm/civicrm-core/pull/13534/files fixes both the above issues.5.31.0https://lab.civicrm.org/dev/core/-/issues/1187csv import only import one phone number2019-09-06T12:41:15ZJankcsv import only import one phone numberIf i import trough UI some contacts with different phone number types, eg. with fax and/or cell and/or phone, only one number is imported. In this repro in all cases with more than one number only the cell number is imported.
See attache...If i import trough UI some contacts with different phone number types, eg. with fax and/or cell and/or phone, only one number is imported. In this repro in all cases with more than one number only the cell number is imported.
See attached Screenshots and example-csv.
![image](/uploads/16219ba0a56c27d64b1a573261abe65d/image.png)
![image](/uploads/51ae5e5dd8c0bf9cd7ea3754db3c8da0/image.png)
![image](/uploads/7355ce9514f4d636493bdb1d607a80d1/image.png)
![image](/uploads/5c26413032a4191aa627f3a21923f6c2/image.png)
This record should have all phone types.
![image](/uploads/2534f104657ada8f3e8f827cc1529caa/image.png)
This record should have fax and cell.
![image](/uploads/fb472d742f06b046e5ae94ad1f379192/image.png)
This record should only have phone and have it.
![image](/uploads/a264850e382880dd0356069a6869872c/image.png)
[export_organizations-test.csv](/uploads/e32981489eeaf7d0185b8b3577751b3b/export_organizations-test.csv)
Sorry, screenshots are german only5.18.0https://lab.civicrm.org/dev/core/-/issues/1061Bad popup on update recurring screen2019-08-21T16:48:10ZeileenBad popup on update recurring screenWe are seeing a popup when checksum users attempt to update a recurring contribution.
![Screenshot_2019-06-12_at_18.50.39](/uploads/85512b40438dcd0e198fddc51dd64c00/Screenshot_2019-06-12_at_18.50.39.png)
This appears to date back to M...We are seeing a popup when checksum users attempt to update a recurring contribution.
![Screenshot_2019-06-12_at_18.50.39](/uploads/85512b40438dcd0e198fddc51dd64c00/Screenshot_2019-06-12_at_18.50.39.png)
This appears to date back to March 2018 when custom data was added to this form (by @mattwire ) - which means we don't need to target the rc & I'm inclined to focus on 'the right fix' on master.
Fundamentally we have a backoffice form that is being exposed for front end users. I have personally proposed doing similar to the 'Add Payment' form recently so it probably bares a little thought. In this case the custom data is not accessible to checksum accessors of the page & superficially the problem is not that it is not available but that it is noisily not available.
I feel like at a conceptual level we probably want to either
1) say front end forms are front end forms and back end forms are back end forms and never the twain shall meet or
2) set the front end form flag whenever a both-use-form is accessed with a checksum
In terms of the custom data I feel the safest option is just to say 'don't expose custom data on both-use forms to users without Access CiviCRM'. If people want to this might not be the right form approach for them - they can actually probably intervene by hook but the risk of exposing inappropriate custom data fields seems real.
This probably also impacts on theming & provides an obvious way not to present un-themed versions of these pages (@seamuslee @totten )5.17.0https://lab.civicrm.org/dev/core/-/issues/1059Deprecation notice on Find Contributions when get there from Manage Contribut...2019-06-25T21:47:12ZDaveDDeprecation notice on Find Contributions when get there from Manage Contribution PagesReproduced on dmaster.demo.
`User deprecated function: Deprecated function CRM_Contribute_BAO_Query::whereClauseSingle, use search by receive_date. Array ( [civi.tag] => deprecated ) in CRM_Core_Error_Log->log() (line 69 of /srv/buildki...Reproduced on dmaster.demo.
`User deprecated function: Deprecated function CRM_Contribute_BAO_Query::whereClauseSingle, use search by receive_date. Array ( [civi.tag] => deprecated ) in CRM_Core_Error_Log->log() (line 69 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Core/Error/Log.php).`
1. Visit Manage contribution pages.
2. From the links on the right choose "Contributions".
3. Red warnings.
Looks like the deprecation was added last week:
https://github.com/civicrm/civicrm-core/pull/14533https://lab.civicrm.org/dev/core/-/issues/680"Date Received" for contributions no longer mandatory, also breaks financial ...2019-11-17T20:57:15Zfabian_SYSTOPIA"Date Received" for contributions no longer mandatory, also breaks financial transactionsThis issue affects at least versions >5.3 - I was able to reproduce it on the current master as well. I would consider it a rather critical bug but maybe there is more to it (new, not fully finished feature)?
**Description**
The contri...This issue affects at least versions >5.3 - I was able to reproduce it on the current master as well. I would consider it a rather critical bug but maybe there is more to it (new, not fully finished feature)?
**Description**
The contribution field "Date Received" used to be mandatory which imho had several good and important reasons. It is now possible to create a contribution without a date both via the UI and the Rest API.
Having a contribution without a date messes up views, reports and any function based on the contribution date such as receipts or invoices.
Also it creates a financial transaction without a date which cannot be good. In the UI, financial transactions still require a date.
**How to reproduce**
Create a new contribution via the UI and delete the date and time in the field "Date Received". Contribution date and financial transaction date will be empty.5.10https://lab.civicrm.org/dev/core/-/issues/584Using CiviDiscount gives a wrong amount with currency localization when recor...2019-12-13T14:14:08ZBetty DolfingUsing CiviDiscount gives a wrong amount with currency localization when recording a payment at an event1. Add Discount to an Event, e.g. 50 %
2. Add a paid event with online registration, event fee is 50 euro
3. Click on link to register
4. Add Discount code and click on 'apply'
5. The amount changes from the expected 25 euro to 25.000....1. Add Discount to an Event, e.g. 50 %
2. Add a paid event with online registration, event fee is 50 euro
3. Click on link to register
4. Add Discount code and click on 'apply'
5. The amount changes from the expected 25 euro to 25.000.000.000.000.
This is in an environment that was created in US English, and afterwards we changed the localisation/language into Dutch.
I tested this locally and on https://dmaster.demo.civicrm.org/civicrm/
Both same result.5.8https://lab.civicrm.org/dev/core/-/issues/529Editing smart group removes search criteria unless criteria tabs are opened f...2018-12-05T20:28:23ZsudomanEditing smart group removes search criteria unless criteria tabs are opened firstWhen editing the search terms in a smart group, If I click "Search" without first opening the drop down tabs that contain info about all of the search criteria, then those terms are removed from the search, returning a different number o...When editing the search terms in a smart group, If I click "Search" without first opening the drop down tabs that contain info about all of the search criteria, then those terms are removed from the search, returning a different number of contacts.
For instance, if my search terms are: `Country = United Kingdom ...AND... Contribution Date - greater than or equal to "January 2nd, 2017 12:00 AM"`, then I need to open the Address Fields and Contributions tabs before clicking "Search", otherwise, I get a much larger set of contacts.
I'm using CiviCRM version 5.3.1 on Drupal 7. Thanks! : )5.8Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/397Dedupe for Individual Birth Date Results in Error2019-02-13T20:28:31ZjasonobrownDedupe for Individual Birth Date Results in Error```
civicrm: $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_in...```
civicrm: $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => INSERT INTO dedupe (id1, id2, weight) SELECT t1.id id1, t2.id id2, 5 weight FROM civicrm_contact t1 JOIN civicrm_contact t2 USING (birth_date) JOIN dedupe_copy ON dedupe_copy.id1 = t1.id AND dedupe_copy.id2 = t2.id WHERE t1.contact_type = 'Individual' AND t2.contact_type = 'Individual' AND t1.id < t2.id AND t1.birth_date IS NOT NULL AND t1.birth_date <> '' GROUP BY id1, id2, weight ON DUPLICATE KEY UPDATE weight = weight + VALUES(weight) [nativecode=1292 ** Incorrect date value: '' for column 'birth_date' at row 1]
[type] => DB_Error
[user_info] => INSERT INTO dedupe (id1, id2, weight) SELECT t1.id id1, t2.id id2, 5 weight FROM civicrm_contact t1 JOIN civicrm_contact t2 USING (birth_date) JOIN dedupe_copy ON dedupe_copy.id1 = t1.id AND dedupe_copy.id2 = t2.id WHERE t1.contact_type = 'Individual' AND t2.contact_type = 'Individual' AND t1.id < t2.id AND t1.birth_date IS NOT NULL AND t1.birth_date <> '' GROUP BY id1, id2, weight ON DUPLICATE KEY UPDATE weight = weight + VALUES(weight) [nativecode=1292 ** Incorrect date value: '' for column 'birth_date' at row 1]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::handle prefix="" info="INSERT INTO dedupe (id1, id2, weight) SELECT t1.id id1, t2.id id2, 5 weight FROM civicrm_contact t1 JOIN civicrm_contact t2 USING (birth_date) JOIN dedupe_copy ON dedupe_copy.id1 = t1.id AND dedupe_copy.id2 = t2.id WHERE t1.contact_type = 'Individual' AND t2.contact_type = 'Individual' AND t1.id < t2.id AND t1.birth_date IS NOT NULL AND t1.birth_date <> '' GROUP BY id1, id2, weight ON DUPLICATE KEY UPDATE weight = weight + VALUES(weight) [nativecode=1292 ** Incorrect date value: '' for column 'birth_date' at row 1]"]
)
```5.12.0https://lab.civicrm.org/dev/core/-/issues/337QuickForm Error on Contact Search Form when using select custom field of type...2021-01-06T22:42:24ZPradeep Nayakpradpnayak@gmail.comQuickForm Error on Contact Search Form when using select custom field of type IntegerTo Replicate:
Create a 'Select' custom field of type Integer or Number with 'Is this Field Searchable?' checked.
The Advance search form throws fatal error
```
Aug 17 10:16:57 [info] $Fatal Error Details = Array
(
[callback] => Ar...To Replicate:
Create a 'Select' custom field of type Integer or Number with 'Is this Field Searchable?' checked.
The Advance search form throws fatal error
```
Aug 17 10:16:57 [info] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -3
[message] => QuickForm Error: nonexistent html element
[mode] => 16
[debug_info] => Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()
[type] => HTML_QuickForm_Error
[user_info] => Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()
[to_string] => [html_quickform_error: message="nonexistent html element" code=-3 mode=callback callback=CRM_Core_Error::handle prefix="QuickForm Error: " info="Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()"]
)
Aug 17 10:16:57 [info] $backTrace = #0 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Error.php(232): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 [internal function](): CRM_Core_Error::handle(Object(HTML_QuickForm_Error))
#2 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(921): call_user_func((Array:2), Object(HTML_QuickForm_Error))
#3 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(2084): PEAR_Error->__construct("nonexistent html element", -3, 16, (Array:2), "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()")
#4 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(575): HTML_QuickForm_Error->__construct(-3, 16, (Array:2), "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()")
#5 [internal function](): PEAR::_raiseError(NULL, NULL, -3, NULL, 512, "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()", "HTML_QuickForm_Error", TRUE)
#6 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(237): call_user_func_array((Array:2), (Array:8))
#7 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(1076): PEAR::__callStatic("raiseError", (Array:7))
#8 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(1076): PEAR::raiseError(NULL, -3, NULL, 512, "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()", "HTML_QuickForm_Error", TRUE)
#9 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php(1103): HTML_QuickForm->addRule("custom_8_from", "number-select From must be a number (with or without decimal point).", "numeric")
#10 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Contact/Form/Search/Criteria.php(567): CRM_Core_BAO_CustomField::addQuickFormElement(Object(CRM_Contact_Form_Search_Advanced), "custom_8", "8", FALSE, TRUE)
#11 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Contact/Form/Search/Advanced.php(150): CRM_Contact_Form_Search_Criteria::custom(Object(CRM_Contact_Form_Search_Advanced))
#12 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Form.php(606): CRM_Contact_Form_Search_Advanced->buildQuickForm()
#13 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php(92): CRM_Core_Form->buildForm()
#14 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Contact_Form_Search_Advanced), "display")
#15 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contact_Form_Search_Advanced), "display")
#16 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Controller.php(351): HTML_QuickForm_Page->handle("display")
#17 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(309): CRM_Core_Controller->run((Array:4), (Array:0))
#18 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:13))
#19 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:4))
#20 /var/www/html/civicrm-master/sites/all/modules/civicrm/drupal/civicrm.module(445): CRM_Core_Invoke::invoke((Array:4))
#21 [internal function](): civicrm_invoke("contact", "search", "advanced")
#22 /var/www/html/civicrm-master/includes/menu.inc(527): call_user_func_array("civicrm_invoke", (Array:3))
#23 /var/www/html/civicrm-master/index.php(21): menu_execute_active_handler()
#24 {main}
```
When i checked the field through database i found that this field has 'is_search_range' set to TRUE which should be only incase of text or date field i believe.5.9https://lab.civicrm.org/dev/core/-/issues/325Fatal error 'DB Error: no such field' on Contribution detail report2018-08-28T21:55:40ZPradeep Nayakpradpnayak@gmail.comFatal error 'DB Error: no such field' on Contribution detail report![before-patch](/uploads/a1f168c003724bf724eb8e4c0998e54c/before-patch.gif)
PR: https://github.com/civicrm/civicrm-core/pull/12660![before-patch](/uploads/a1f168c003724bf724eb8e4c0998e54c/before-patch.gif)
PR: https://github.com/civicrm/civicrm-core/pull/126605.6https://lab.civicrm.org/dev/core/-/issues/319Advanced search export: when location types' display names are different from...2018-08-27T01:41:01ZnoahAdvanced search export: when location types' display names are different from their machine names, empty columns are exportedEDITED to be more accurate following further investigation into the symptoms.
This is a regression in the last couple versions of Civi (I see it on 5.3.1 and 5.4.0, as well as 5.5-rc and master).
**Summary:** When exporting from advanc...EDITED to be more accurate following further investigation into the symptoms.
This is a regression in the last couple versions of Civi (I see it on 5.3.1 and 5.4.0, as well as 5.5-rc and master).
**Summary:** When exporting from advanced search, if you select email/phone/address fields to export _where the location type's display name is different from its machine name_, the headers for those columns will be included in the export, but the cells in those columns will be blank.
**To reproduce:**
1. Create a location type called "Field Office" with machine name "FieldOffice" or "FO"
1. Create a contact with a "Field Office" email.
1. Find that contact using advanced search and select the "export" task.
1. Select "Individual - Email - Field Office" as a field to export.
1. In the resulting CSV, there's a blank cell where the email address should be.
**Notes:** I also notice:
* the columns in the export are not in the same order as on the export column selection screen.
* exporting from Search Builder has a similar-but-different problem: if two location types are selected for export, only one of the columns will successfully be exported.
I see that quite a bit of work has gone into the Export code in recent releases and I suspect this regression happened as a result.
I'm interested in creating tests for this but I'd need someone to hold my hand through the process, as I have no recent experience doing that.5.5.0