Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-11-07T12:25:25Zhttps://lab.civicrm.org/dev/core/-/issues/4739Fatal Error "invalid locale" with scheduled jobs and tax receipts (and others...2023-11-07T12:25:25ZkcristianoFatal Error "invalid locale" with scheduled jobs and tax receipts (and others) and php 8.1.25 & civicrm 5.66.xAfter updating to php 8.1.25
```
PHP 8.1.25 (cli) (built: Oct 27 2023 13:02:10) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.25, Copyright (c) Zend Technologies
with Zend OPcache v8.1.25, Copyright (c), by Zend Technologies
``...After updating to php 8.1.25
```
PHP 8.1.25 (cli) (built: Oct 27 2023 13:02:10) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.25, Copyright (c) Zend Technologies
with Zend OPcache v8.1.25, Copyright (c), by Zend Technologies
```
Any attempt to call cron (cli with cv, or in the UI) fails with the following erro:
```
[28-Oct-2023 10:50:42 America/New_York] PHP Fatal error: Uncaught IntlException: datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR in /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php:105
Stack trace:
#0 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php(105): IntlDateFormatter->__construct()
#1 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php(204): PHP81_BC\{closure}()
#2 [internal function]: PHP81_BC\{closure}()
#3 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php(185): preg_replace_callback()
#4 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/Log.php(887): PHP81_BC\strftime()
#5 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/Log/file.php(294): Log->formatTime()
#6 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(590): Log_file->log()
#7 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(562): CRM_Core_Error::debug_log_message()
#8 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(442): CRM_Core_Error::debug_var()
#9 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(39): CRM_Core_Error::handleUnhandledException()
#10 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm.php(1199): CRM_Core_Invoke::invoke()
#11 /home/cvdemo/public_html/wp-includes/class-wp-hook.php(310): CiviCRM_For_WordPress->invoke()
#12 /home/cvdemo/public_html/wp-includes/class-wp-hook.php(334): WP_Hook->apply_filters()
#13 /home/cvdemo/public_html/wp-includes/plugin.php(517): WP_Hook->do_action()
#14 /home/cvdemo/public_html/wp-admin/admin.php(259): do_action()
#15 {main}
thrown in /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php on line 105
```
I am finding this on:
WP 6.3.2
CiviCRM 5.64.x and greater
The only workaround I could find was temporarily reverting to php 7.45.67.0https://lab.civicrm.org/dev/core/-/issues/4738Fields disappear when there is a number validation in Activity custom fields2023-11-02T15:22:36ZbgmFields disappear when there is a number validation in Activity custom fieldsSeen in #4154, but not a new issue:
- Create a new Custom Group, for Activities
- In that group, create a new custom field of type numeric
Then go to a contact, and create a new activity (ex: meeting), and in the numeric field, enter s...Seen in #4154, but not a new issue:
- Create a new Custom Group, for Activities
- In that group, create a new custom field of type numeric
Then go to a contact, and create a new activity (ex: meeting), and in the numeric field, enter something invalid (ex: 123abc).
Result: validation error causes a fatal error:
![image](/uploads/4507a214a62f15c31b74672d392041cb/image.png)
And the custom fields, which are loaded using ajax, are not displayed.https://lab.civicrm.org/dev/core/-/issues/4737Activity.getFields crashes2023-10-28T01:41:36ZDaveDActivity.getFields crashessyntax error: `SELECT * FROM civicrm_tag WHERE id IN ()`
Sorry the backtrace isn't formatted very well since it isn't available via CLI or log file just in the browser, but it's clearly something to do with tags at `Civi\Api4\Service\Sp...syntax error: `SELECT * FROM civicrm_tag WHERE id IN ()`
Sorry the backtrace isn't formatted very well since it isn't available via CLI or log file just in the browser, but it's clearly something to do with tags at `Civi\Api4\Service\Spec\SpecFormatter.php` line 245 where for some reason it's trying to do stuff with tags.
Doesn't happen in 5.67.
Can reproduce on cli with `cv ev "\Civi\Api4\Activity::getFields(FALSE)->setLoadOptions(['id','name','label','description','color','icon'])->execute();`
```
{
"debug": {
"info": "SELECT * FROM civicrm_tag WHERE `id` IN () [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1]",
"db_error": "syntax error",
"sql": [
"SELECT * FROM civicrm_tag WHERE `id` IN () [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1]"
],
"backtrace": "#0 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(945): CRM_Core_Error::exceptionHandler(Object(DB_Error))\n#1 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/db/DB.php(997): PEAR_Error->__construct('DB Error: synta...', -2, 16, Array, 'SELECT * FROM c...')\n#2 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-2, 16, Array, 'SELECT * FROM c...')\n#3 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR::_raiseError(Object(DB_mysqli), NULL, -2, 16, Array, 'SELECT * FROM c...', 'DB_Error', true)\n#4 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/db/DB/common.php(1928): PEAR->__call('raiseError', Array)\n#5 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/db/DB/mysqli.php(943): DB_common->raiseError(-2, NULL, NULL, 'SELECT * FROM c...', '1064 ** You hav...')\n#6 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/db/DB/mysqli.php(413): DB_mysqli->mysqliRaiseError()\n#7 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/vendor/pear/db/DB/common.php(1234): DB_mysqli->simpleQuery('SELECT * FROM c...')\n#8 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/packages/DB/DataObject.php(2696): DB_common->query('SELECT * FROM c...')\n#9 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/packages/DB/DataObject.php(1829): DB_DataObject->_query('SELECT * FROM c...')\n#10 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/CRM/Core/DAO.php(487): DB_DataObject->query('SELECT * FROM c...')\n#11 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/CRM/Core/DAO.php(1654): CRM_Core_DAO->query('SELECT * FROM c...', true)\n#12 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Service/Spec/SpecFormatter.php(245): CRM_Core_DAO::executeQuery('SELECT * FROM c...')\n#13 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Service/Spec/SpecFormatter.php(173): Civi\\Api4\\Service\\Spec\\SpecFormatter::addOptionProps(Array, Object(Civi\\Api4\\Service\\Spec\\FieldSpec), 'CRM_Core_BAO_En...', 'tag_id', Array, Array)\n#14 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Schema/Traits/OptionsSpecTrait.php(53): Civi\\Api4\\Service\\Spec\\SpecFormatter::getOptions(Object(Civi\\Api4\\Service\\Spec\\FieldSpec), Array, Array, true, Array)\n#15 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Generic/DAOGetFieldsAction.php(75): Civi\\Api4\\Service\\Spec\\FieldSpec->getOptions(Array, Array, true)\n#16 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Generic/DAOGetFieldsAction.php(52): Civi\\Api4\\Generic\\DAOGetFieldsAction->specToArray(Array)\n#17 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Generic/BasicGetFieldsAction.php(97): Civi\\Api4\\Generic\\DAOGetFieldsAction->getRecords()\n#18 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Service/Spec/Provider/EntityTagFilterSpecProvider.php(100): Civi\\Api4\\Generic\\BasicGetFieldsAction->_run(Object(Civi\\Api4\\Generic\\Result))\n#19 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Schema/Traits/OptionsSpecTrait.php(53): Civi\\Api4\\Service\\Spec\\Provider\\EntityTagFilterSpecProvider::getTagList(Object(Civi\\Api4\\Service\\Spec\\FieldSpec), Array, Array, true, Array)\n#20 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Generic/DAOGetFieldsAction.php(75): Civi\\Api4\\Service\\Spec\\FieldSpec->getOptions(Array, Array, true)\n#21 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Generic/DAOGetFieldsAction.php(52): Civi\\Api4\\Generic\\DAOGetFieldsAction->specToArray(Array)\n#22 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Generic/BasicGetFieldsAction.php(97): Civi\\Api4\\Generic\\DAOGetFieldsAction->getRecords()\n#23 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Provider/ActionObjectProvider.php(72): Civi\\Api4\\Generic\\BasicGetFieldsAction->_run(Object(Civi\\Api4\\Generic\\Result))\n#24 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/API/Kernel.php(156): Civi\\Api4\\Provider\\ActionObjectProvider->invoke(Object(Civi\\Api4\\Generic\\DAOGetFieldsAction))\n#25 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(256): Civi\\API\\Kernel->runRequest(Object(Civi\\Api4\\Generic\\DAOGetFieldsAction))\n#26 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/api/api.php(91): Civi\\Api4\\Generic\\AbstractAction->execute()\n#27 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/CRM/Api4/Page/AJAX.php(116): civicrm_api4('Activity', 'getFields', Array, '')\n#28 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/CRM/Api4/Page/AJAX.php(55): CRM_Api4_Page_AJAX->execute('Activity', 'getFields', Array, '')\n#29 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(322): CRM_Api4_Page_AJAX->run(Array, NULL)\n#30 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem(Array)\n#31 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke(Array)\n#32 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/sites/all/modules/civicrm/drupal/civicrm.module(472): CRM_Core_Invoke::invoke(Array)\n#33 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/includes/menu.inc(527): civicrm_invoke('ajax', 'api4', 'Activity', 'getFields')\n#34 /home/jenkins/bknix-dfl/build/core-27958-1xlfo/web/index.php(21): menu_execute_active_handler()\n#35 {main}"
}
}
```5.68.0https://lab.civicrm.org/dev/core/-/issues/4736New individual popup to create one on-the-fly is popping up the cms user acco...2023-10-27T21:24:50ZDaveDNew individual popup to create one on-the-fly is popping up the cms user account creation form not the usual profile popupe.g. create a contribution. In the contact field choose New Individual.e.g. create a contribution. In the contact field choose New Individual.5.68.0https://lab.civicrm.org/dev/core/-/issues/4735Event Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid...2023-12-06T16:06:38Zdarren.woodsEvent Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid value for id"Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/qu...Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/questions/45729/event-registration-error-on-wordpress-6-3-1-civi-5-63-4-could-not-find-valid-va
Reproduction steps
----------------------------------------
1. Configure an event with free online registration and a thankyou message.
2. Register for the event from the event info page.
Current behaviour
----------------------------------------
Users are shown an error: "Could not find valid value for id"
Expected behaviour
----------------------------------------
Thank you message configured in the event should be shown.
Environment information
----------------------------------------
* __Browser: Browser independent.
* __CiviCRM: 5.63.4
* __PHP: 8.1
* __CMS: WordPress 6.3.1
* __Database: MariaDB
* __Web Server: Nginx
Comments
----------------------------------------
This only happens with registering for events using the Civi event info page. If you embed a shortcode for the specific event in a WordPress page then the error is not shown.https://lab.civicrm.org/dev/core/-/issues/4734ADMIN_UI: default checkbox2023-11-03T15:31:20ZGuillaumeSorelADMIN_UI: default checkboxCould it be possible to have checkboxes per default for each new admin screen using SK, so it becomes possible to select multiple lines (for mailings, messages templates, custom fields...) and proceed bulk actions on them, especially del...Could it be possible to have checkboxes per default for each new admin screen using SK, so it becomes possible to select multiple lines (for mailings, messages templates, custom fields...) and proceed bulk actions on them, especially delete?
New SK screens are sweet but actions still need to be proceeded one-by-one.https://lab.civicrm.org/dev/core/-/issues/4733Where art thou APIv4: MailingEventSubscribe Create? Missing parity with civic...2023-11-02T15:16:06Zjustinfreeman (Agileware)Where art thou APIv4: MailingEventSubscribe Create? Missing parity with civicrm_api3('MailingEventSubscribe', 'Create')Where art thou APIv4: MailingEventSubscribe Create? Missing parity with civicrm_api3('MailingEventSubscribe', 'Create')
Agileware Ref: CVAP-50Where art thou APIv4: MailingEventSubscribe Create? Missing parity with civicrm_api3('MailingEventSubscribe', 'Create')
Agileware Ref: CVAP-50https://lab.civicrm.org/dev/core/-/issues/4732Scheduled Reminder select2 fields to save/view correctly2023-10-27T00:41:38Zmagnolia61Scheduled Reminder select2 fields to save/view correctlyI am testing 5.68 (master) and run into a problem with Event Type based scheduled reminders.
I think since the Event Type and Registration status have been changed to select2 values are saved but when I re-edit the reminder the field sh...I am testing 5.68 (master) and run into a problem with Event Type based scheduled reminders.
I think since the Event Type and Registration status have been changed to select2 values are saved but when I re-edit the reminder the field show empty.
![image](/uploads/1b0c39ee96ae06c36c0b8dcf2adc1552/image.png)
This is what is recorded in the database:
![image](/uploads/b9f77048338bd4347da0a6cc96cc94e1/image.png)
When I select a single value the behavior of the participant status is different than for the event types. A single value for the participant status gets saved and shown on re-edit.
![image](/uploads/d0659ed253a2ee37a07f21be2f0d70a8/image.png)
BTW. I confirmed this bug on https://dmaster.demo.civicrm.org/
![image](/uploads/b078da97fc6d141a3a5d7d54cc6c1ec0/image.png)
![image](/uploads/c256cd3bdef9f8980be7ab38fdaeb8ed/image.png)https://lab.civicrm.org/dev/core/-/issues/4731SearchKit/Form Builder: re-positioning menu links column in table display bre...2023-11-02T17:26:41ZtomrosenbloomSearchKit/Form Builder: re-positioning menu links column in table display breaks csv downloadTo reproduce:
1. add a Menu column to a SK table display - it will appear in the last column by default
2. move menu links column to a different position
3. create afform from this display
4. use action menu to download results to csv
5...To reproduce:
1. add a Menu column to a SK table display - it will appear in the last column by default
2. move menu links column to a different position
3. create afform from this display
4. use action menu to download results to csv
5. now check the download - the column data immediately to the right of the menu column is missing and the data in subsequent columns is shifted to the left
I guess this could be due to something not being closed off properly and corrupting the table, and in that case it could be relevant that one of my menu links is `civicrm/case-detail#/?id=[id]`
EDIT: no, don't think it's that: I removed this link and the problem persists5.68.0https://lab.civicrm.org/dev/core/-/issues/4730Case tagsets showing name not label2023-10-30T02:57:49ZDaveDCase tagsets showing name not labelThis isn't fixed by https://lab.civicrm.org/dev/core/-/issues/4727 so must be coming from somewhere else.
Create/edit are ok and bare case tags are ok, but for some reason case tagsets display name.This isn't fixed by https://lab.civicrm.org/dev/core/-/issues/4727 so must be coming from somewhere else.
Create/edit are ok and bare case tags are ok, but for some reason case tagsets display name.5.68.0https://lab.civicrm.org/dev/core/-/issues/4729Menu missing - error in console2023-10-24T22:06:48ZDaveDMenu missing - error in consoleSeems to be from https://github.com/civicrm/civicrm-core/pull/27569 - `undefined key "attribute"` error is mangling the ajax output.
`mixin\setting-admin@1\mixin.php(197)`Seems to be from https://github.com/civicrm/civicrm-core/pull/27569 - `undefined key "attribute"` error is mangling the ajax output.
`mixin\setting-admin@1\mixin.php(197)`5.68.0https://lab.civicrm.org/dev/core/-/issues/4728Form Builder Issue: Filter for "Contact (Near Side) / Contact (Far Side)" not...2023-10-26T11:44:33ZTobias Voigttobias.voigt@civiservice.deForm Builder Issue: Filter for "Contact (Near Side) / Contact (Far Side)" not workingI start with the "contacts" entity in Search Kit, then include "Contact Related Contacts" as an additonal entity and create a form in Form Builder for this composed search.
In Form Builder I then add a filter for both "Contact (Near Sid...I start with the "contacts" entity in Search Kit, then include "Contact Related Contacts" as an additonal entity and create a form in Form Builder for this composed search.
In Form Builder I then add a filter for both "Contact (Near Side)" and "Contact (Far Side)". When I then search for and choose a contact through one "Contact (Near Side)", the results table shows ALL possible results. When I search for and choose a contact through one "Contact (Far Side)", the results table is empty.
I was able to reproduce this behaviour in https://dmaster.demo.civicrm.org.
Side note: When I create a form directly for the composed search (rather than for a Search Kit table), I also get a warning: "Warning: Trying to access array offset on value of type null in Civi\Api4\Action\SearchDisplay\GetDefault->getColumnLabel() (line 418 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/Traits/SavedSearchInspectorTrait.php)."
Not sure if this is related to the issue or not.
If it would work, this filter would be extremely helpful and great to have.https://lab.civicrm.org/dev/core/-/issues/4727Basic/Advanced search and CiviReport filters showing `name` in tag dropdown i...2023-11-01T23:19:57ZDaveDBasic/Advanced search and CiviReport filters showing `name` in tag dropdown instead of `label`![untitled4](/uploads/ea919fe7f1f9257beb0f2c656f3efe2a/untitled4.png)
Also the QILL for the civireport (the QILL for the search is ok).
![untitled3](/uploads/ed24469c7b1110d79340b0f4b3555fb4/untitled3.png)![untitled4](/uploads/ea919fe7f1f9257beb0f2c656f3efe2a/untitled4.png)
Also the QILL for the civireport (the QILL for the search is ok).
![untitled3](/uploads/ed24469c7b1110d79340b0f4b3555fb4/untitled3.png)5.68.0https://lab.civicrm.org/dev/core/-/issues/4726On Import in Non English Mode do not import field in saved field mapping is n...2023-11-29T20:14:33ZseamusleeOn Import in Non English Mode do not import field in saved field mapping is not correctly set as default when re-using importOverview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set cor...Overview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set correctly when the MapField form is loaded as per the screenshot below showing the saving of the saved mapping field with the 2nd field as do not import but then when I go to re-use the saved mapping the mapped column does not match do not import
![save_import_map](/uploads/a652dc803fecadde0d5ec7fe0f202f58/save_import_map.jpg)
![use_import_map](/uploads/a2ae9251dbc67491276567473e4668c7/use_import_map.jpg)
Reproduction steps
----------------------------------------
1. Navigate to Administer -> localisation -> Languages ... and Set current language to be French (France)
1. Go to contacts -> Import contacts and proceed to the map field step. Create a mapping and save it making sure that one of the fields is marked as do not import
1. Repeat step 2 but this time re-use the saved mapping from before and find that the field is not mapped to the selection of do not import
ping @eileen @JoeMurray5.67.0https://lab.civicrm.org/dev/core/-/issues/4724Contribution fails mid-donation with geocoding, "on behalf of", and no state/...2023-10-30T02:57:00ZJonGoldContribution fails mid-donation with geocoding, "on behalf of", and no state/provinceOverview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
-------------------------------------...Overview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
----------------------------------------
1. Create a contribution page that allows giving "on behalf of an organization". The Organization profile should include state/province and at least one other address field. The state/province must not be required.
2. Submit the form with an organization. Provide at least one part of the address but leave the state blank.
Current behaviour
----------------------------------------
Crashes in geocoding.
Expected behaviour
----------------------------------------
Submits successfully.
Comments
----------------------------------------
This wouldn't be such a big deal but for https://lab.civicrm.org/dev/core/-/issues/2929.
A partial backtrace is below, though there are other ways to reach this code path (e.g. if confirm pages are present/absent).
```
#0 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/DAO.php(1419): strtolower()
#1 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Utils/Geocode/Google.php(76): CRM_Core_DAO::getFieldValue()
#2 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1287): CRM_Utils_Geocode_Google::format()
#3 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(276): CRM_Core_BAO_Address::addGeocoderData()
#4 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1365): CRM_Core_BAO_Address::fixAddress()
#5 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Location.php(52): CRM_Core_BAO_Address::legacyCreate()
#6 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(327): CRM_Core_BAO_Location::create()
#7 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(1921): CRM_Contact_BAO_Contact::create()
#8 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(1296): CRM_Contact_BAO_Contact::createProfileContact()
#9 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(2312): CRM_Contribute_Form_Contribution_Confirm::processOnBehalfOrganization()
#10 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(836): CRM_Contribute_Form_Contribution_Confirm->processFormSubmission()
#11 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/Form.php(617): CRM_Contribute_Form_Contribution_Confirm->postProcess()
#12 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1318): CRM_Core_Form->mainProcess()
#13 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1076): CRM_Contribute_Form_Contribution_Main->skipToThankYouPage()
```5.68.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/4723SearchKit joins to custom fields appear to be broken2023-11-02T20:48:31ZScottMasonSearchKit joins to custom fields appear to be brokenThe latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom fi...The latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom field for activities (for example Activities details > products)
2. Create a new SK search for activities and join to the custom field
![image](/uploads/ebbeb025d909e2df4b8c87d97d7a9ada/image.png)
3. Add info from the linked entity to the display
4. The info is not shown.
![image](/uploads/870046a2cf17c723bfff75917401beb0/image.png)
I have tested this on the lastest demo site and it appears to be an issue there.
fyi @kurundhttps://lab.civicrm.org/dev/core/-/issues/4722[PHP 8.1] fseek deprecation in PHPgettext2023-12-04T21:08:50Zjofranzfranz@systopia.de[PHP 8.1] fseek deprecation in PHPgettextOverview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Depre...Overview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Deprecation] fseek(): Passing null to parameter #2 ($offset) of type int is deprecated at .../drupal/vendor/civicrm/civicrm-packages/PHPgettext/streams.php:125```
Expected behaviour
----------------------------------------
There should be no deprecation warnings.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __CiviCRM:__ _5.66.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _8.1_
* __CMS:__ _Drupal 9.5.11_https://lab.civicrm.org/dev/core/-/issues/4720[PHP 8.1] New Organization: 4x Undefined array key2023-10-27T11:41:07Zjofranzfranz@systopia.de[PHP 8.1] New Organization: 4x Undefined array key## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/contact/add?reset=1&ct=Organization
## Seeing
```
Warning: Undefined array key "contact_sub_type" in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/4...## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/contact/add?reset=1&ct=Organization
## Seeing
```
Warning: Undefined array key "contact_sub_type" in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Undefined array key "contact_sub_type" in include() (line 34 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 34 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
```https://lab.civicrm.org/dev/core/-/issues/4719[PHP 8.1] New Contribution: 4x Undefined array key2023-12-12T20:43:31Zjofranzfranz@systopia.de[PHP 8.1] New Contribution: 4x Undefined array key## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicr...## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicrm/templates_c/en_US/%%60/60A/60A6E1C6%%Payment.tpl.php).
Warning: Undefined array key "buildRecurBlock" in include() (line 125 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
Warning: Undefined array key "urlPathVar" in include() (line 90 of sites/default/files/civicrm/templates_c/en_US/%%51/516/51624B60%%paymentBlock.tpl.php).
Warning: Undefined array key "dataUrl" in include() (line 477 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
```
---
_Internal ref: sci_https://lab.civicrm.org/dev/core/-/issues/4718[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in...2023-11-03T02:04:37Zjofranzfranz@systopia.de[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in CRM_Core_Action## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate...## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate/drupal/vendor/civicrm/civicrm-core/CRM/Core/Action.php).```5.67.0