Development issueshttps://lab.civicrm.org/groups/dev/-/issues2022-04-04T15:25:16Zhttps://lab.civicrm.org/dev/core/-/issues/3157Search Builder is gone2022-04-04T15:25:16ZjaapjansmaSearch Builder is goneThe menu item to Search Builder is gone from CiviCRM core.
When navigating in https://dmaster.demo.civicrm.or/civicrm/contact/search/builder?reset=1 it is displayed.
In CiviCRM 5.47.2 the menu item was still available.The menu item to Search Builder is gone from CiviCRM core.
When navigating in https://dmaster.demo.civicrm.or/civicrm/contact/search/builder?reset=1 it is displayed.
In CiviCRM 5.47.2 the menu item was still available.https://lab.civicrm.org/dev/core/-/issues/3153Filter summary no longer appearing on results for Reports2022-04-03T15:36:01ZStoobFilter summary no longer appearing on results for ReportsThere was summarized list of filters when you look at the results of a report. It looked something like the attached. Now in 5.46+ it is gone.
![filters](/uploads/5d2826f6c0661a375421f61cc73a1da2/filters.png)There was summarized list of filters when you look at the results of a report. It looked something like the attached. Now in 5.46+ it is gone.
![filters](/uploads/5d2826f6c0661a375421f61cc73a1da2/filters.png)5.48.0https://lab.civicrm.org/dev/core/-/issues/3151Database update from 5.47.2 to 5.47.3 fails with a non en_US database.2022-04-07T08:08:11ZspalmstromDatabase update from 5.47.2 to 5.47.3 fails with a non en_US database.Overview
----------------------------------------
The update from 5.47.2 to 5.47.3 fails in a non-US environment with
| Type | DB_Error ...Overview
----------------------------------------
The update from 5.47.2 to 5.47.3 fails in a non-US environment with
| Type | DB_Error |
|-----------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Code | -1 |
| Message | DB Error: unknown error |
| Mode | 16 |
| UserInfo | ALTER TABLE civicrm_event_en_GB CHANGE COLUMN event_tz event_tz_bak text NULL DEFAULT NULL COMMENT 'For troubleshooting upgrades post 5.47. Can drop this column if no issues.' [nativecode=1347 ** 'civicrm_test.civicrm_event_en_gb' is not BASE TABLE] |
| DebugInfo | ALTER TABLE civicrm_event_en_GB CHANGE COLUMN event_tz event_tz_bak text NULL DEFAULT NULL COMMENT 'For troubleshooting upgrades post 5.47. Can drop this column if no issues.' [nativecode=1347 ** 'civicrm_test.civicrm_event_en_gb' is not BASE TABLE] |
Reproduction steps
----------------------------------------
1. Use Composer to install the code.
2. Run the database update.
Current behaviour
----------------------------------------
```
| Type | DB_Error |
|-----------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Code | -1 |
| Message | DB Error: unknown error |
| Mode | 16 |
| UserInfo | ALTER TABLE civicrm_event_en_GB CHANGE COLUMN event_tz event_tz_bak text NULL DEFAULT NULL COMMENT 'For troubleshooting upgrades post 5.47. Can drop this column if no issues.' [nativecode=1347 ** 'civicrm_test.civicrm_event_en_gb' is not BASE TABLE] |
| DebugInfo | ALTER TABLE civicrm_event_en_GB CHANGE COLUMN event_tz event_tz_bak text NULL DEFAULT NULL COMMENT 'For troubleshooting upgrades post 5.47. Can drop this column if no issues.' [nativecode=1347 ** 'civicrm_test.civicrm_event_en_gb' is not BASE TABLE] |
```
Expected behaviour
----------------------------------------
Database update should run to completion.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is necessary. -->
* __Browser:__ _Edge_ but irrelevant.
* __CiviCRM:__ _5.47.2/5.47.3_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.4__ but probably irrelevant.
* __CMS:__ _Drupal 9.3.9/..._ but probably irrelvant
* __Database:__ _MySQL 8.0.28_ but may not be relevant.
* __Web Server:__ _IIS 10_ but probably irrelevant.
Comments
----------------------------------------
I had unzipped the localisation files to <drupal root>\vendor\civicrm\civicrm-core before running the update script.
I suspect a vanilla en_US installation won't show the issue.
[CiviCRM_5.47.2_to_5.47.3_upgrade_error.pdf](/uploads/b82ba443e7d87aa63edee4fb4abe72d3/CiviCRM_5.47.2_to_5.47.3_upgrade_error.pdf)https://lab.civicrm.org/dev/core/-/issues/3142Gender field no longer working2022-03-28T22:52:46ZDaveDGender field no longer workingThe field always displays as though it has no value, even when it has a value. Can reproduce locally and on dmaster.demo.
My guess would be it's from one of the smarty escaping PRs.The field always displays as though it has no value, even when it has a value. Can reproduce locally and on dmaster.demo.
My guess would be it's from one of the smarty escaping PRs.5.49.0https://lab.civicrm.org/dev/core/-/issues/3135Regression - dedupe redirects to wrong place in 5.48rc2022-06-12T00:47:07ZeileenRegression - dedupe redirects to wrong place in 5.48rcWith [this commit](https://github.com/civicrm/civicrm-core/pull/22768/commits/a6f2a80ffbddfc0788199ec824b8aff46ccd1542) the user is redirected to the wrong place after merging 2 contacts
The correct flow is that
1) user does a search f...With [this commit](https://github.com/civicrm/civicrm-core/pull/22768/commits/a6f2a80ffbddfc0788199ec824b8aff46ccd1542) the user is redirected to the wrong place after merging 2 contacts
The correct flow is that
1) user does a search from basic search, advanced search etc
2) user selects 2 contacts & chooses the action to merge them
3) user submits the screen to merge them
4) user redirected to the single resulting contact
The regression is that in 4 the user is redirected to the search results again. This has been reported as a regression/ problematic change by users
@colemanw this is the regression I commented in github5.48.0https://lab.civicrm.org/dev/core/-/issues/3134New Membership fails when price set present but not selected2022-03-30T16:37:26Zluke.stewartNew Membership fails when price set present but not selectedOverview
----------------------------------------
From -> https://chat.civicrm.org/civicrm/pl/raz1a9pnqpys7bff5bm6x45rwh
Reproduction steps
----------------------------------------
1. create Price Set for Memberships
1. add first field...Overview
----------------------------------------
From -> https://chat.civicrm.org/civicrm/pl/raz1a9pnqpys7bff5bm6x45rwh
Reproduction steps
----------------------------------------
1. create Price Set for Memberships
1. add first field for folk to choose their membership
1. add a second field (using a different FinType but may not be an important step) using options and give at least 2 options (though 1 may do too)
1. via backend, go to Contact, right click to Add Membership in new Tab. select above Price Set and do NOT chose an option in field.
1. The website encountered an unexpected error. Please try again later
Current behaviour
----------------------------------------
Badness!
"The website encountered an unexpected error. Please try again later"
```
TypeError: Argument 1 passed to CRM_Financial_BAO_Order::isOverrideLineItemFinancialType() must be of the type int, null given, called in
/sites/all/modules/civicrm/CRM/Financial/BAO/Order.php on line 817 in CRM_Financial_BAO_Order->isOverrideLineItemFinancialType() (line 390 of /sites/all/modules/civicrm/CRM/Financial/BAO/Order.php).
```
Expected behaviour
----------------------------------------
Membership should create
Environment information
----------------------------------------
Replicated on dmaster. Note error message I copied above is from a site which has a patched version of 5.46.3 so line numbers might vary but we do see this on dmaster as well.5.47.3https://lab.civicrm.org/dev/core/-/issues/3119Post-upgrade messages no longer being displayed2022-03-22T13:16:42ZDaveDPost-upgrade messages no longer being displayedIn 5.44 for example, the post-upgrade message looks like this:
```
Congratulations! Your upgrade was successful!
A token has been updated in the invoice template. Check the system checks page to see if any action is required.
```
Note...In 5.44 for example, the post-upgrade message looks like this:
```
Congratulations! Your upgrade was successful!
A token has been updated in the invoice template. Check the system checks page to see if any action is required.
```
Note that there is always at least the `Congratulations! Your upgrade was successful!` that comes from https://github.com/civicrm/civicrm-core/blob/2eab44850a420083bafef133278b34f43d28cc70/CRM/Upgrade/Page/Upgrade.php#L139
In 5.47 for example you get nothing. This line is no longer TRUE: https://github.com/civicrm/civicrm-core/blob/2eab44850a420083bafef133278b34f43d28cc70/CRM/Upgrade/Page/Upgrade.php#L172
Doesn't affect `cv` just the UI.5.47.3https://lab.civicrm.org/dev/core/-/issues/3118CiviGrant - Can't edit existing grants following move to Core Extension2022-03-16T12:49:25ZMatt TrimCiviGrant - Can't edit existing grants following move to Core ExtensionOverview
----------------------------------------
When trying to edit an existing grant in CiviCRM of Civi versions 5.47.0 onwards, I am greeted with an error message.
Reproduction steps
----------------------------------------
Editin...Overview
----------------------------------------
When trying to edit an existing grant in CiviCRM of Civi versions 5.47.0 onwards, I am greeted with an error message.
Reproduction steps
----------------------------------------
Editing a Grant from a Contact Record:
1. Find any existing contact record that has an existing Grant, and navigate to the Contact Record -> Grants tab.
1. Press the "Edit" button.
1. Receive "Network Error Unable to reach the server. Please refresh this page in your browser and try again." status bounce message
1. Look at Watchdog / Error logs:
```
TypeError: Argument 2 passed to CRM_Grant_BAO_Grant::retrieve() must be of the type array, null given, called in /buildkit/build/user-prompts/vendor/civicrm/civicrm-core/ext/civigrant/CRM/Grant/Form/Grant.php on line 106 in CRM_Grant_BAO_Grant::retrieve() (line 75 of /buildkit/build/test/vendor/civicrm/civicrm-core/ext/civigrant/CRM/Grant/BAO/Grant.php)
```
Editing a Grant from the "Find Grants" screen:
1. Navigate to the "Find Grants" screen
1. Press "Search"
1. Press "Edit" on any of the displayed Grants
1. Note the same behaviour presents as above.
Current behaviour
----------------------------------------
```
TypeError: Argument 2 passed to CRM_Grant_BAO_Grant::retrieve() must be of the type array, null given, called in /buildkit/build/user-prompts/vendor/civicrm/civicrm-core/ext/civigrant/CRM/Grant/Form/Grant.php on line 106 in CRM_Grant_BAO_Grant::retrieve() (line 75 of /buildkit/build/test/vendor/civicrm/civicrm-core/ext/civigrant/CRM/Grant/BAO/Grant.php)
```
Expected behaviour
----------------------------------------
I should be able to edit a grant.
Comments
----------------------------------------
Pradeep has raised a Pull Request that addresses this: https://github.com/civicrm/civicrm-core/pull/22947
OR
https://github.com/civicrm/civicrm-core/pull/22948https://lab.civicrm.org/dev/core/-/issues/3116Event API is not available after upgrading to 5.472022-03-17T18:12:40ZedvanleeuwenEvent API is not available after upgrading to 5.47After upgrading from 5.46.0 to 5.47.1, I get the following error:
`API Exception: Event API is not available because CiviEvent component is disabled while checking events for timezones.`
Is this a regression fault or should I change so...After upgrading from 5.46.0 to 5.47.1, I get the following error:
`API Exception: Event API is not available because CiviEvent component is disabled while checking events for timezones.`
Is this a regression fault or should I change some configuration setting?5.47.2https://lab.civicrm.org/dev/core/-/issues/3112Regression on 5.48 upgrade2022-03-17T18:15:55ZeileenRegression on 5.48 upgradeNew upgrade bug ... - I got past it doing https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/769796/1
- the item that it caught is further down
```
* ERROR USERINFO: SELECT `a`.`id` AS `id`, `a`.`option_group_...New upgrade bug ... - I got past it doing https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/769796/1
- the item that it caught is further down
```
* ERROR USERINFO: SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`label` AS `label`, `a`.`value` AS `value`, `a`.`name` AS `name`, `a`.`grouping` AS `grouping`, `a`.`filter` AS `filter`, `a`.`is_default` AS `is_default`, `a`.`weight` AS `weight`, `a`.`description` AS `description`, `a`.`is_optgroup` AS `is_optgroup`, `a`.`is_reserved` AS `is_reserved`, `a`.`is_active` AS `is_active`, `a`.`component_id` AS `component_id`, `a`.`domain_id` AS `domain_id`, `a`.`visibility_id` AS `visibility_id`, `a`.`icon` AS `icon`, `a`.`color` AS `color`
FROM a
WHERE (`a`.`option_group_id` = "19") AND (`a`.`name` = "CiviGrant")
[nativecode=1146 ** Table 'civicrm.a' doesn't exist]
* ERROR DEBUGINFO: SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`label` AS `label`, `a`.`value` AS `value`, `a`.`name` AS `name`, `a`.`grouping` AS `grouping`, `a`.`filter` AS `filter`, `a`.`is_default` AS `is_default`, `a`.`weight` AS `weight`, `a`.`description` AS `description`, `a`.`is_optgroup` AS `is_optgroup`, `a`.`is_reserved` AS `is_reserved`, `a`.`is_active` AS `is_active`, `a`.`component_id` AS `component_id`, `a`.`domain_id` AS `domain_id`, `a`.`visibility_id` AS `visibility_id`, `a`.`icon` AS `icon`, `a`.`color` AS `color`
FROM a
WHERE (`a`.`option_group_id` = "19") AND (`a`.`name` = "CiviGrant")
[nativecode=1146 ** Table 'civicrm.a' doesn't exist]
#0 /srv/civi-sites/wmff/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(922): CRM_Core_Error::exceptionHandler(Object(DB_Error))
#1 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB.php(997): PEAR_Error->__construct("DB Error: no such table", -18, 16, (Array:2), "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#2 /srv/civi-sites/wmff/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-18, 16, (Array:2), "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#3 /srv/civi-sites/wmff/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_civirpow), NULL, -18, 16, (Array:2), "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...", "DB_Error", TRUE)
#4 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/common.php(1928): PEAR->__call("raiseError", (Array:7))
#5 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/mysqli.php(936): DB_common->raiseError(-18, NULL, NULL, "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...", "1146 ** Table 'civicrm.a' doesn't exist")
#6 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/mysqli.php(406): DB_mysqli->mysqliRaiseError()
#7 /srv/civi-sites/wmff/drupal/sites/default/civicrm/extensions/rpow/DB/civirpow.php(66): DB_mysqli->simpleQuery("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#8 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/common.php(1234): DB_civirpow->simpleQuery("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#9 /srv/civi-sites/wmff/civicrm/packages/DB/DataObject.php(2696): DB_common->query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#10 /srv/civi-sites/wmff/civicrm/packages/DB/DataObject.php(1829): DB_DataObject->_query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#11 /srv/civi-sites/wmff/civicrm/CRM/Core/DAO.php(468): DB_DataObject->query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#12 /srv/civi-sites/wmff/civicrm/CRM/Core/DAO.php(1633): CRM_Core_DAO->query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...", TRUE)
#13 /srv/civi-sites/wmff/civicrm/Civi/Api4/Query/Api4SelectQuery.php(167): CRM_Core_DAO::executeQuery("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#14 /srv/civi-sites/wmff/civicrm/Civi/Api4/Generic/DAOGetAction.php(113): Civi\Api4\Query\Api4SelectQuery->run()
#15 /srv/civi-sites/wmff/civicrm/Civi/Api4/Generic/DAOGetAction.php(101): Civi\Api4\Generic\DAOGetAction->getObjects(Object(Civi\Api4\Generic\Result))
#16 /srv/civi-sites/wmff/civicrm/Civi/Api4/Provider/ActionObjectProvider.php(69): Civi\Api4\Generic\DAOGetAction->_run(Object(Civi\Api4\Generic\Result))
#17 /srv/civi-sites/wmff/civicrm/Civi/API/Kernel.php(149): Civi\Api4\Provider\ActionObjectProvider->invoke(Object(Civi\Api4\Generic\DAOGetAction))
#18 /srv/civi-sites/wmff/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAOGetAction))
#19 /srv/civi-sites/wmff/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute()
#20 /srv/civi-sites/wmff/civicrm/CRM/Upgrade/Incremental/php/FiveFortySeven.php(284): civicrm_api4("OptionValue", "get", (Array:2))
#21 /srv/civi-sites/wmff/civicrm/CRM/Queue/Task.php(73): CRM_Upgrade_Incremental_php_FiveFortySeven::migrateCiviGrant(Object(CRM_Queue_TaskContext))
#22 /srv/civi-sites/wmff/civicrm/CRM/Queue/Runner.php(215): CRM_Queue_Task->run(Object(CRM_Queue_TaskContext))
RAW Paste Data
* ERROR USERINFO: SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`label` AS `label`, `a`.`value` AS `value`, `a`.`name` AS `name`, `a`.`grouping` AS `grouping`, `a`.`filter` AS `filter`, `a`.`is_default` AS `is_default`, `a`.`weight` AS `weight`, `a`.`description` AS `description`, `a`.`is_optgroup` AS `is_optgroup`, `a`.`is_reserved` AS `is_reserved`, `a`.`is_active` AS `is_active`, `a`.`component_id` AS `component_id`, `a`.`domain_id` AS `domain_id`, `a`.`visibility_id` AS `visibility_id`, `a`.`icon` AS `icon`, `a`.`color` AS `color`
FROM a
WHERE (`a`.`option_group_id` = "19") AND (`a`.`name` = "CiviGrant")
[nativecode=1146 ** Table 'civicrm.a' doesn't exist]
* ERROR DEBUGINFO: SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`label` AS `label`, `a`.`value` AS `value`, `a`.`name` AS `name`, `a`.`grouping` AS `grouping`, `a`.`filter` AS `filter`, `a`.`is_default` AS `is_default`, `a`.`weight` AS `weight`, `a`.`description` AS `description`, `a`.`is_optgroup` AS `is_optgroup`, `a`.`is_reserved` AS `is_reserved`, `a`.`is_active` AS `is_active`, `a`.`component_id` AS `component_id`, `a`.`domain_id` AS `domain_id`, `a`.`visibility_id` AS `visibility_id`, `a`.`icon` AS `icon`, `a`.`color` AS `color`
FROM a
WHERE (`a`.`option_group_id` = "19") AND (`a`.`name` = "CiviGrant")
[nativecode=1146 ** Table 'civicrm.a' doesn't exist]
#0 /srv/civi-sites/wmff/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(922): CRM_Core_Error::exceptionHandler(Object(DB_Error))
#1 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB.php(997): PEAR_Error->__construct("DB Error: no such table", -18, 16, (Array:2), "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#2 /srv/civi-sites/wmff/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-18, 16, (Array:2), "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#3 /srv/civi-sites/wmff/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_civirpow), NULL, -18, 16, (Array:2), "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...", "DB_Error", TRUE)
#4 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/common.php(1928): PEAR->__call("raiseError", (Array:7))
#5 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/mysqli.php(936): DB_common->raiseError(-18, NULL, NULL, "SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...", "1146 ** Table 'civicrm.a' doesn't exist")
#6 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/mysqli.php(406): DB_mysqli->mysqliRaiseError()
#7 /srv/civi-sites/wmff/drupal/sites/default/civicrm/extensions/rpow/DB/civirpow.php(66): DB_mysqli->simpleQuery("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#8 /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/common.php(1234): DB_civirpow->simpleQuery("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#9 /srv/civi-sites/wmff/civicrm/packages/DB/DataObject.php(2696): DB_common->query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#10 /srv/civi-sites/wmff/civicrm/packages/DB/DataObject.php(1829): DB_DataObject->_query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#11 /srv/civi-sites/wmff/civicrm/CRM/Core/DAO.php(468): DB_DataObject->query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#12 /srv/civi-sites/wmff/civicrm/CRM/Core/DAO.php(1633): CRM_Core_DAO->query("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...", TRUE)
#13 /srv/civi-sites/wmff/civicrm/Civi/Api4/Query/Api4SelectQuery.php(167): CRM_Core_DAO::executeQuery("SELECT `a`.`id` AS `id`, `a`.`option_group_id` AS `option_group_id`, `a`.`lab...")
#14 /srv/civi-sites/wmff/civicrm/Civi/Api4/Generic/DAOGetAction.php(113): Civi\Api4\Query\Api4SelectQuery->run()
#15 /srv/civi-sites/wmff/civicrm/Civi/Api4/Generic/DAOGetAction.php(101): Civi\Api4\Generic\DAOGetAction->getObjects(Object(Civi\Api4\Generic\Result))
#16 /srv/civi-sites/wmff/civicrm/Civi/Api4/Provider/ActionObjectProvider.php(69): Civi\Api4\Generic\DAOGetAction->_run(Object(Civi\Api4\Generic\Result))
#17 /srv/civi-sites/wmff/civicrm/Civi/API/Kernel.php(149): Civi\Api4\Provider\ActionObjectProvider->invoke(Object(Civi\Api4\Generic\DAOGetAction))
#18 /srv/civi-sites/wmff/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAOGetAction))
#19 /srv/civi-sites/wmff/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute()
#20 /srv/civi-sites/wmff/civicrm/CRM/Upgrade/Incremental/php/FiveFortySeven.php(284): civicrm_api4("OptionValue", "get", (Array:2))
#21 /srv/civi-sites/wmff/civicrm/CRM/Queue/Task.php(73): CRM_Upgrade_Incremental_php_FiveFortySeven::migrateCiviGrant(Object(CRM_Queue_TaskContext))
#22 /srv/civi-sites/wmff/civicrm/CRM/Queue/Runner.php(215): CRM_Queue_Task->run(Object(CRM_Queue_TaskContext))
```
```
Mar 11 00:32:00 [warning] Array
(
[entity] => Navigation
[values] => Array
(
[name] => Grant Status
[domain_id] => current_domain
)
)
Array
(
[checkPermissions] =>
[where] => Array
(
[0] => Array
(
[0] => name
[1] => =
[2] => Grant Status
)
[1] => Array
(
[0] => domain_id
[1] => =
[2] => current_domain
)
)
)
```5.47.2https://lab.civicrm.org/dev/core/-/issues/3107Upgrading from pre-5.47 to 5.48+ isn't re-runnable in certain situations2022-06-29T02:33:30ZDaveDUpgrading from pre-5.47 to 5.48+ isn't re-runnable in certain situations
Since sketching out the below, I think I can see there is a quick solution, but now that I've written the description already I'll still post the whole thing. Short version: This line should have a check that `is_autorun` exists in the ...
Since sketching out the below, I think I can see there is a quick solution, but now that I've written the description already I'll still post the whole thing. Short version: This line should have a check that `is_autorun` exists in the table before running the query: https://github.com/civicrm/civicrm-core/blob/88e3bfdfc52aa1e117160b6592597510af446d1a/CRM/Upgrade/Incremental/php/FiveFortyEight.php#L60
Problem
-------
Typical sysadmin: "Goin' to upgrade now. Let me make a backup... ok, done. Upgrade, and ... oh that failed. Ok let me reload my sql file and apply this patch and try again... Oh that failed - something about queues. Repeat. Fail again. Hmm."
For a dev doing testing this might not come up, because they might "start from scratch" when repeating (or use trickery like devs do).
The difference is the reload db, and in particular when upgrading pre-5.47 to 5.48+. And given the history to-date, that reload-and-try-again cycle is likely to come up more with 5.47 than usual.
In 5.47, the `civicrm_queue` table is created, but [ONLY if it doesn't exist](https://github.com/civicrm/civicrm-core/blob/88e3bfdfc52aa1e117160b6592597510af446d1a/CRM/Upgrade/Incremental/sql/5.47.alpha1.mysql.tpl#L3). I.e. as opposed to `DROP TABLE IF EXISTS civicrm_queue`, followed by the creation. Since this table might have long-term data, you don't want to drop it if an upgrade is being re-run some time in the future.
(Aside: That create table statement probably shouldn't enforce utf8mb4 yet, but that's separate.)
So now let's think about the sequence for the sysadmin:
* Before first attempt, civicrm_queue didn't exist.
* After first attempt, it now exists.
* Reload db. Note something important: The backup sql file does NOT have anything about civicrm_queue. There is no DROP TABLE statement for it. So after reloading the sql file, civicrm_queue DOES exist, which is different from before the first run.
* If you're the type of sysadmin who drops the whole db before reloading the sql file, you won't run into this. I don't know what percentage that covers.
So now, there's [an upgrade step](https://github.com/civicrm/civicrm-core/blob/88e3bfdfc52aa1e117160b6592597510af446d1a/CRM/Upgrade/Incremental/php/FiveFortyEight.php#L60) in 5.48 that assumes that the field `is_autorun` is going to exist. But it doesn't because civicrm_queue at this point is the already upgraded table.
SECONDARY ISSUE
---------------
There's another issue here too for similar reasons, but I haven't confirmed the specific problem, but at the moment I think there is one.
Something new in 5.47 is that civi will auto-install search kit and afform. These both create database tables. So you have a similar situation where after reloading the db, you have an already upgraded table present when it shouldn't be, so you get a similar problem when something tries to act on it in a way that isn't re-runnable.https://lab.civicrm.org/dev/core/-/issues/3104RC Error: Call to undefined method CRM_Contact_Page_View_Summary::addExpected...2022-03-13T10:28:32Zmagnolia61RC Error: Call to undefined method CRM_Contact_Page_View_Summary::addExpectedSmartyVariables()With the current RC (5.48 beta 1) I get the following fatal error when I want to view a contact record
`Error: Call to undefined method CRM_Contact_Page_View_Summary::addExpectedSmartyVariables() in CRM_Core_BAO_CustomGroup::buildCustom...With the current RC (5.48 beta 1) I get the following fatal error when I want to view a contact record
`Error: Call to undefined method CRM_Contact_Page_View_Summary::addExpectedSmartyVariables() in CRM_Core_BAO_CustomGroup::buildCustomDataView() (line 1986 of /var/www/vhosts/xyz/webroot/sites/all/modules/civicrm/CRM/Core/BAO/CustomGroup.php).`
- CiviCRM: 5.48.beta1
- CMS: Drupal 7.89
- PHP: 7.4.28 (fpm-fcgi)
- Database: 10.6.5-MariaDB-1:10.6.5+maria~bullseye-log engine: InnoDB 10 row format: Dynamic
- Webserver: Apache
- OS: Linux5.48.0https://lab.civicrm.org/dev/core/-/issues/3100Grant CiviReport menu inconsistencies2022-03-09T13:47:08ZDaveDGrant CiviReport menu inconsistencies1. On a brand new install without civigrant, there's an empty Reports - CiviGrant menu.
1. If you install civigrant or upgrade from a site that had civigrant, the CiviGrant menu is still empty, and the reports get put under Reports - Con...1. On a brand new install without civigrant, there's an empty Reports - CiviGrant menu.
1. If you install civigrant or upgrade from a site that had civigrant, the CiviGrant menu is still empty, and the reports get put under Reports - Contact Reports.
There's two things I think:
1. Some leftovers in the xml files from before. Should be an easy fix.
1. Even if that's fixed, where _should_ the extension's reports live in the menu?5.47.1https://lab.civicrm.org/dev/core/-/issues/3095Formatting shows Currency for samey-locales2022-03-05T14:09:10ZeileenFormatting shows Currency for samey-localesThe switch to BrickMoney has the positive impact of adding a currency for the non-site-default locale - so for a US site NZ donations would be prefixed with NZ.
However, it turns out it is pretty common for NZ sites to leave the site la...The switch to BrickMoney has the positive impact of adding a currency for the non-site-default locale - so for a US site NZ donations would be prefixed with NZ.
However, it turns out it is pretty common for NZ sites to leave the site language as en_US as no other English variants are offered without the translation install...
![image](/uploads/7a814b43db89c9c100b4cbd7c9ccd528/image.png)
We discussed this & think that the remedy is to add a new setting
format_locale
If set this will be used for money formatting INSTEAD of thousand separator and decimal separator - ie those will be determinted from the format_locale and we will hide those settings in the UI and deprecate them. Over time we will encourage people to switch. This setting can also be used for dates5.47.0https://lab.civicrm.org/dev/core/-/issues/3094Contribution view page crashes if you don't have event permissions2022-03-08T00:10:22ZDaveDContribution view page crashes if you don't have event permissionshttps://github.com/civicrm/civicrm-core/pull/22732 adds info about participants to the page but the api call throws an exception if you don't have permissions. I think I'll just put up a PR to wrap in a try/catch and then not display the...https://github.com/civicrm/civicrm-core/pull/22732 adds info about participants to the page but the api call throws an exception if you don't have permissions. I think I'll just put up a PR to wrap in a try/catch and then not display the participant stuff if error.5.48.0https://lab.civicrm.org/dev/core/-/issues/3093Upgrade error with civigrant - order of dependencies matters2022-03-07T22:15:00ZDaveDUpgrade error with civigrant - order of dependencies matters1. Install an older version of civi. Let's say 5.39 but I don't think it matters too much.
1. Enable the CiviGrant component.
1. **Don't** install search kit.
1. Upgrade. You'll see a message about "extension error" that looks like this....1. Install an older version of civi. Let's say 5.39 but I don't think it matters too much.
1. Enable the CiviGrant component.
1. **Don't** install search kit.
1. Upgrade. You'll see a message about "extension error" that looks like this. So far not a problem, but note the order of dependencies listed. The average person will now attempt to install `Form Core` first.
![Untitled2](/uploads/84a1e72d59998ab8fc392187e72a5d29/Untitled2.png)
1. NO! You must install search kit first. Otherwise you get `API error: API (SearchDisplay, create) does not exist (join the API team and implement it!) on SearchDisplay.create`.
Note that this is slightly different from https://lab.civicrm.org/dev/core/-/issues/3036 (PR https://github.com/civicrm/civicrm-core/pull/22623) which dealt with interdependence between form builder and search kit, and the order there doesn't matter.5.47.0https://lab.civicrm.org/dev/core/-/issues/3088Notice error on dmaster2022-04-13T23:35:48ZJoeMurrayNotice error on dmasterOn dmaster 5.48.alpha1. Administer > CiviContribute Component Settings. Check Always post to Accounts Receivable? and submit, then one sees:
Notice: Trying to get property 'info' of non-object in CRM_Admin_Page_Admin->run() (line 43 of ...On dmaster 5.48.alpha1. Administer > CiviContribute Component Settings. Check Always post to Accounts Receivable? and submit, then one sees:
Notice: Trying to get property 'info' of non-object in CRM_Admin_Page_Admin->run() (line 43 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Admin/Page/Admin.php).
Notice: Trying to get property 'info' of non-object in CRM_Admin_Page_Admin->run() (line 43 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Admin/Page/Admin.php).
I marked as regression but don't know when this appeared. If I had to guess it is related to PHP version rather than a code change.Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/3087CiviGrant appears in admin menu twice2022-03-01T01:07:07ZDaveDCiviGrant appears in admin menu twiceI think it's maybe some leftovers in xml/templates/civicrm_navigation.tpl that need to be moved over/removed.I think it's maybe some leftovers in xml/templates/civicrm_navigation.tpl that need to be moved over/removed.5.47.0https://lab.civicrm.org/dev/core/-/issues/3084Backend membership with a price set will ignore the price field financial typ...2022-05-05T06:27:07ZherbdoolBackend membership with a price set will ignore the price field financial type, uses price set insteadOverview
----------------------------------------
Backend membership with a price set will ignore the price field financial type, uses price set instead. (This is a different problem from https://lab.civicrm.org/dev/core/-/issues/3083 t...Overview
----------------------------------------
Backend membership with a price set will ignore the price field financial type, uses price set instead. (This is a different problem from https://lab.civicrm.org/dev/core/-/issues/3083 though they should be consistent).
Related to https://lab.civicrm.org/dev/core/-/issues/3084, https://lab.civicrm.org/dev/core/-/issues/2414
Reproduction steps
----------------------------------------
1. Set up a price set to include memberships.
2. One price field should be membership of financial type Member Dues. The other Donation.
![2022-02-25_14.17.49_dev-cycleto.pantheonsite.io_edb775bf4afb](/uploads/baab97de74fc3910e4a016138db06c98/2022-02-25_14.17.49_dev-cycleto.pantheonsite.io_edb775bf4afb.png)
3. Make a backend membership purchase.
Current behaviour
----------------------------------------
The contribution will show that each line item gets the financial type from the price set and not from the price set field:
![2022-02-25_14.16.03_dev-cycleto.pantheonsite.io_372ee7ffbad1](/uploads/1f8a227ce02fb8c0d1b28a707ada8af0/2022-02-25_14.16.03_dev-cycleto.pantheonsite.io_372ee7ffbad1.png)
And it doesn't set the non-deductible amount properly. In fact, I don't think it's set either way. If I change the price set financial type to be Merchandise then it still doesn't set the non-deductible.
![2022-02-25_14.25.54_dev-cycleto.pantheonsite.io_ad7e30a61562](/uploads/4b22eafeeca74ee89f60918102bed234/2022-02-25_14.25.54_dev-cycleto.pantheonsite.io_ad7e30a61562.png)
Expected behaviour
----------------------------------------
Should use the financial type of the price set *field/option*. And it should set the non-deductible based on that. This is how it's working for a non-member price set: it will use the price field financial type and non-deductible amount regardless of what the price set is using.5.49.0https://lab.civicrm.org/dev/core/-/issues/3069Grant fields are included in exports in the Contact grouping2024-03-08T00:10:30ZDaveDGrant fields are included in exports in the Contact groupingGo to e.g. find contacts or find activities and from the results pick some or all and choose Export from the actions dropdown. Choose select fields for export. In the Contacts grouping, CiviGrant fields are being included there. I don't ...Go to e.g. find contacts or find activities and from the results pick some or all and choose Export from the actions dropdown. Choose select fields for export. In the Contacts grouping, CiviGrant fields are being included there. I don't remember seeing this before but will double-check if that's where they used to show up.5.47.0