Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-01-11T16:31:48Zhttps://lab.civicrm.org/dev/core/-/issues/2301Warning: count(): Parameter must be an array or an object that implements Cou...2023-01-11T16:31:48ZspalmstromWarning: count(): Parameter must be an array or an object that implements Countable when saving My Profile or Name and AddressOverview
----------------------------------------
_Please describe your problem or bug in detail._
_If you have already posted on https://civicrm.stackexchange.com or https://chat.civicrm.org, please include the link to that conversatio...Overview
----------------------------------------
_Please describe your problem or bug in detail._
_If you have already posted on https://civicrm.stackexchange.com or https://chat.civicrm.org, please include the link to that conversation._
Reproduction steps
----------------------------------------
1. Click on **My Account**.
1. Click on the **Edit** tab.
1. Click on **Name and Address** tab.
1. Get the warning message.
Current behaviour
----------------------------------------
_What happens currently. Please provide error messages, screenshots or gifs ([LICEcap](http://www.cockos.com/licecap/), [SilentCast](https://github.com/colinkeenan/silentcast)) where appropriate._
```
Warning: count(): Parameter must be an array or an object that implements Countable in include() (line 15 of sites\default\files\civicrm\templates_c\en_GB\%%4D\4DC\4DC76B26%%body.tpl.php).
```
Note that this appears to be instance dependent. I had one instance that showed it, and one that did not.
Expected behaviour
----------------------------------------
_What should happen._
No error message.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is necessary. -->
* __Browser:__ Edge_ but probably irrelevant.
* __CiviCRM:__ _5.33.1_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.4__ but probably irrelevant.
* __CMS:__ _Drupal 9.1.2_
* __Database:__ _MySQL 8.0_
* __Web Server:__ _IIS 10_
Comments
----------------------------------------
_Anything else you would like the reviewer to note._
This is not always reproducible. It can be cured by the following change to
```
<Drupal Root> web/custom-civicrm/templates/CRM/Form/body.tpl
```
```
+++ b/body
@@ -14,10 +14,7 @@
{if $form.hidden}
<div>{$form.hidden}</div>
{/if}
-{if (isset($form.errors))}
- {*
- If $form.errors isn't set, we get warning messages
- *}
+
{if ($snippet !== 'json') and !$suppressForm and count($form.errors) gt 0}
<div class="messages crm-error">
<i class="crm-i fa-exclamation-triangle crm-i-red" aria-hidden="true"></i>
@@ -33,7 +30,6 @@
</ul>
</div>
{/if}
-{/if}
{* Add all the form elements sent in by the hook *}
{if $beginHookFormElements}
```
If there has been an error, one would expect $form.errors to be set.5.59.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/2300Can not use Custom Fields defined on a contact_sub_type in dedupe rule2023-03-18T04:09:39ZKarinGCan not use Custom Fields defined on a contact_sub_type in dedupe ruleSteps to reproduce:
1. On dmaster demo -> Create Student Custom Data set -> add field: StudentID Alphanumeric Text
![image](/uploads/7ec9849e8ac5e9309cbdaece4019a5e9/image.png)
2. Contact -> Find and Merge Duplicate Contacts -> Add Ru...Steps to reproduce:
1. On dmaster demo -> Create Student Custom Data set -> add field: StudentID Alphanumeric Text
![image](/uploads/7ec9849e8ac5e9309cbdaece4019a5e9/image.png)
2. Contact -> Find and Merge Duplicate Contacts -> Add Rule for Individuals: and notice that the field is not available:
![image](/uploads/853786b65cee90d299d57ac2a42f34f1/image.png)
3. I remember finding this bug in 5.21 ESR - it had been fixed in later versions - the fix was backported and was still working fine in 5.27 ESR. I'm not sure when this re-regressed.https://lab.civicrm.org/dev/translation/-/issues/62Updated State list for Taiwan2021-01-15T15:42:56ZsudomanUpdated State list for TaiwanOne of our site users would like to recommend updating the "State list" of "Country: Taiwan". Below is the recommended list from the Office of the President (<https://english.president.gov.tw/Page/106>). Our user says that it's ok to put...One of our site users would like to recommend updating the "State list" of "Country: Taiwan". Below is the recommended list from the Office of the President (<https://english.president.gov.tw/Page/106>). Our user says that it's ok to put the list under "State", even though they actually only call them city or county.
```
Taipei City
New Taipei City
Keelung City
Taoyuan City
Hsinchu City
Hsinchu County
Miaoli County
Taichung City
Changhua County
Nantou County
Yunlin County
Chiayi City
Chiayi County
Tainan City
Kaohsiung City
Pingtung County
Yilan County
Hualien County
Taitung County
Penghu County
Kinmen County
Lienchiang County
```
Thanks : )https://lab.civicrm.org/dev/core/-/issues/2299Get contact id for the mailing along with display name and email2023-06-14T05:03:19ZyashodhaGet contact id for the mailing along with display name and emailGet contact id for the mailing along with display name and email in _getContactInfo_ method from CRM/Mailing/Event/BAO/Queue.phpGet contact id for the mailing along with display name and email in _getContactInfo_ method from CRM/Mailing/Event/BAO/Queue.phpyashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/2297Undefined index when putting in a contribution thank-you date without a time2021-01-15T05:31:02ZDaveDUndefined index when putting in a contribution thank-you date without a time`Notice: Undefined index: thankyou_date_time in CRM_Contribute_Form_AdditionalInfo::postProcessCommon() (line 275 of .../web/sites/all/modules/civicrm/CRM/Contribute/Form/AdditionalInfo.php).`
It's straightforward but there's also a isN...`Notice: Undefined index: thankyou_date_time in CRM_Contribute_Form_AdditionalInfo::postProcessCommon() (line 275 of .../web/sites/all/modules/civicrm/CRM/Contribute/Form/AdditionalInfo.php).`
It's straightforward but there's also a isNull() in there that seems odd so I'm wondering why it's there. It might be because sometimes it's the literal word 'null' and so you don't want to process that.
```
if (!empty($params['thankyou_date']) && !CRM_Utils_System::isNull($params['thankyou_date'])) {
$formatted['thankyou_date'] = CRM_Utils_Date::processDate($params['thankyou_date'], $params['thankyou_date_time']);
}
```5.35.0https://lab.civicrm.org/dev/core/-/issues/2296Only an admin user #1 (drupal) is able to edit an export mapping or edit one2021-01-29T11:01:43ZcalbasiOnly an admin user #1 (drupal) is able to edit an export mapping or edit oneDrupal 7, civicrm 5.33.1 (but also on 5.29)
My user#1 user can edit a mapping when exporting fields of a searched group of users, and it can also create a new mapping, just editing an existing one.
But when other manager user, with per...Drupal 7, civicrm 5.33.1 (but also on 5.29)
My user#1 user can edit a mapping when exporting fields of a searched group of users, and it can also create a new mapping, just editing an existing one.
But when other manager user, with permissions to export, is trying to do it, system freezes and nothing happens, and there is no a new or modified mapping on civicrm mappings section. So the process is stuck.
This user can export contact fields info without problem.https://lab.civicrm.org/dev/core/-/issues/2295List of exported fields are not shown with Chromium browser (but they do with...2021-01-29T11:00:15ZcalbasiList of exported fields are not shown with Chromium browser (but they do with Firerox)When exporting some custom information of some searched contacts, using any of the mappings available, an user can add/delete some fields (even update the mapping or create a new mapping "profile"). This happens at step 3 of 3 and I have...When exporting some custom information of some searched contacts, using any of the mappings available, an user can add/delete some fields (even update the mapping or create a new mapping "profile"). This happens at step 3 of 3 and I have no problem to do it using Firefox (Debian testing version), but I can not see the fields list using Crome, just submit buttons. Here you are the html output:
```
<div class="crm-block crm-form-block crm-export-map-form-block">
<div id="wizard-steps">
<ul class="wizard-bar">
<li class="past-step"><i class="crm-i fa-check" aria-hidden="true"></i> 1. Cerca</li>
<li class="past-step"><i class="crm-i fa-check" aria-hidden="true"></i> 2. Opcions d'exportació</li>
<li class="current-step"><i class="crm-i fa-chevron-right" aria-hidden="true"></i> 3. Selecciona els camps a exportar</li>
</ul>
</div>
<h2>Selecciona els camps a exportar (pas 3 de 3)</h2>
<div class="crm-submit-buttons">
<button class="crm-form-submit cancel crm-button crm-button-type-back crm-button_qf_Map_back" value="1" type="submit" name="_qf_Map_back" id="_qf_Map_back-top"><i aria-hidden="true" class="crm-i fa-chevron-left"></i> Anterior</button>
<button class="crm-form-submit validate crm-button crm-button-type-done crm-button_qf_Map_done" value="1" type="submit" name="_qf_Map_done" id="_qf_Map_done-top"><i aria-hidden="true" class="crm-i fa-times"></i> Torna a la cerca</button>
<button class="crm-form-submit validate crm-button crm-button-type-next crm-button_qf_Map_next" value="1" type="submit" name="_qf_Map_next" id="_qf_Map_next-top"><i aria-hidden="true" class="crm-i fa-download"></i> Descarrega el fitxer</button>
</div>
<div ng-app="exportui" class="ng-scope">
<!-- ngInclude: '~/exportui/export.html' -->
</div>
<div class="crm-submit-buttons">
```
I get 10 errors on inspector... i suppose one of them is the responsible for this.
> Access to font at 'https://www.enginyerscivils.cat/sites/all/modules/civicrm/bower_components/font-awesome/fonts/fontawesome-webfont.woff2?v=4.7.0' from origin 'https://enginyerscivils.cat' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
> fontawesome-webfont.woff2:1
>
> Failed to load resource: net::ERR_FAILED
>
> Access to font at 'https://www.enginyerscivils.cat/sites/all/modules/civicrm/bower_components/font-awesome/fonts/fontawesome-webfont.woff2?v=4.7.0' from origin 'https://enginyerscivils.cat' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
> fontawesome-webfont.woff2:1
>
> Failed to load resource: net::ERR_FAILED
> advanced?_qf_Map_display=true&qfKey=44f102135c72280af0998e66fda144374c69835124417548815e1d4eb76679a1_1095:1
>
> Access to font at 'https://www.enginyerscivils.cat/sites/all/modules/civicrm/bower_components/font-awesome/fonts/fontawesome-webfont.woff?v=4.7.0' from origin 'https://enginyerscivils.cat' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
> fontawesome-webfont.woff:1 Failed to load resource: net::ERR_FAILED
> advanced?_qf_Map_display=true&qfKey=44f102135c72280af0998e66fda144374c69835124417548815e1d4eb76679a1_1095:1
>
> Access to XMLHttpRequest at 'https://www.enginyerscivils.cat/sites/default/files/civicrm/persist/contribute/dyn/angular-modules.12d46c7002289d3a18abfc5c5b8ed6e9.json' from origin 'https://enginyerscivils.cat' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
> js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:897
>
> Possibly unhandled rejection: {"status":500}
> (anonymous) @ js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:897
> js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:897
>
> TypeError: a.headers is not a function
> at s (js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:876)
> at js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:910
> at m.$digest (js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:921)
> at m.$apply (js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:925)
> at k (js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:876)
> at v (js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:881)
> at XMLHttpRequest.y.onerror (js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:882) "Possibly unhandled rejection: {}"
> (anonymous) @ js_coCb3AVGGFHSRICP59lZ4DCHfK7RO_s1Whgo_Lhprfg.js:897
> www.enginyerscivils.cat/sites/default/files/civicrm/persist/contribute/dyn/angular-modules.12d46c7002289d3a18abfc5c5b8ed6e9.json:1 Failed to load resource: net::ERR_FAILED
> advanced?_qf_Map_display=true&qfKey=44f102135c72280af0998e66fda144374c69835124417548815e1d4eb76679a1_1095:1
>
> Access to font at 'https://www.enginyerscivils.cat/sites/all/modules/civicrm/bower_components/font-awesome/fonts/fontawesome-webfont.ttf?v=4.7.0' from origin 'https://enginyerscivils.cat' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
> fontawesome-webfont.ttf:1
>
> Failed to load resource: net::ERR_FAILED
>
> DevTools failed to load SourceMap: Could not load content for https://www.enginyerscivils.cat/sites/default/files/js/angular.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILUREhttps://lab.civicrm.org/dev/wordpress/-/issues/86List of groups in search form and create new contact screen not respecting ACLs2021-01-25T05:20:08ZseamusleeList of groups in search form and create new contact screen not respecting ACLsIf you have an ACL on your system and it limits access to one or a specific set of groups this is correctly reflected on the Manage Groups screen but not when you go to do an advanced search and click the list of groups nor when you go t...If you have an ACL on your system and it limits access to one or a specific set of groups this is correctly reflected on the Manage Groups screen but not when you go to do an advanced search and click the list of groups nor when you go to create a new Individual and expand the Tags and Groups Section.
To replicate
1. Grant the Subscriber role access to the CiviCRM backend
2. Create a new ACL group called test group
3. Create a new Individual Test Contact
4. Add Test Contact into ACL group created in item 2
5. Create new ACL role called Test ACL role
6. Assign the Test ACL role to the Test Group created In item 2
7. Create an ACL for the Test ACL role granting edit access to the contacts in the Newsletter Subscribers group
8. Create a new WordPress role for the Test Contact created in item 3 give them just the Subscriber role.
9. Now login at the new user account in a new private window
10. Navigate to the Contacts -> Manage Groups Screen and see that it only shows you Newsletter Subscriber
11. Navigate to Advanced Search and Click on groups and see you get more than just the Newsletter Subscriber group returned
ping @kcristiano @JoeMurray5.35.0Monish DebMonish Debhttps://lab.civicrm.org/dev/wordpress/-/issues/85WordPress releases being tagged 4.7 instead of 5.332021-01-17T19:31:58ZkcristianoWordPress releases being tagged 4.7 instead of 5.33I noticed that for versions 5.33.0 and 5.33.1 WordPress reports the version as 4.7.
Comparing to prior releases this is a change. 5.32.1 reported 5.32.1. WP reads from the main plugin file in `civicrm-wordpress` The Version is set i...I noticed that for versions 5.33.0 and 5.33.1 WordPress reports the version as 4.7.
Comparing to prior releases this is a change. 5.32.1 reported 5.32.1. WP reads from the main plugin file in `civicrm-wordpress` The Version is set in the [plugin header](https://github.com/civicrm/civicrm-wordpress/blob/master/civicrm.php#L5).
It's also [defined](https://github.com/civicrm/civicrm-wordpress/blob/master/civicrm.php#L57) to trigger css and js updates.
in Mattermost(https://chat.civicrm.org/civicrm/pl/kbj1dc913t8pfd7gwuwrmw4ndc) @totten mentioned the process for WP. Currently the automated process is not working.5.33.1https://lab.civicrm.org/dev/core/-/issues/2294When two contacts, Contact A and Contact B have the same email address, if Co...2021-01-11T21:27:11Zjustinfreeman (Agileware)When two contacts, Contact A and Contact B have the same email address, if Contact A is deleted then Contact B is incorrectly excluded from mailings, does not receive emailsWhen two contacts, Contact A and Contact B have the same email address, if Contact A is deleted then Contact B is incorrectly excluded from mailings, does not receive emails.
An error message is also displayed when previewing the receip...When two contacts, Contact A and Contact B have the same email address, if Contact A is deleted then Contact B is incorrectly excluded from mailings, does not receive emails.
An error message is also displayed when previewing the receipients on the mailing, if the contact is in the first 50 contacts listed. Error message:
{"count":0,"is_error":1,"error_message":"Expected one Contact but found 0"}
Reproduced on https://dmaster.demo.civicrm.org, CiviCRM 5.34-Alpha1
Related https://github.com/civicrm/civicrm-core/pull/18763
**Steps to reproduce**
1. Create Contact A with email address abc@abc.com.au
2. Create Contact B with email address abc@abc.com.au
3. Create Smart Group C and define criteria which matches both Contact A and Contact B
4. Verify that Contact A and Contact B are listed in Smart Group C
5. Manually add Contact A to Smart Group C
6. Delete Contact A
7. Create a Mailing D and select Smart Group C as recipients
8. The recipient count should be 1
9. Click on the Recipients Count to preview the listing of recipients
10. Note an error is shown in the pop-up: {"count":0,"is_error":1,"error_message":"Expected one Contact but found 0"}
11. When the mailing is sent, an email will not be sent to Contact B which is incorrect. Contact B should receive the email.
Agileware Ref: CIVICRM-1638
![Screenshot_20210111_164017](/uploads/4d0964cda096ca103595c5b7672e3f6b/Screenshot_20210111_164017.png)https://lab.civicrm.org/dev/core/-/issues/2293Sample data has no contributions since Oct 20202023-06-30T05:03:19ZDaveDSample data has no contributions since Oct 2020While it might be realistic that it's been tough to get donations lately, the sample data could use some recent contributions since otherwise the Top Donors dashlet which is a stock dashlet on the demo looks at first glance to be broken,...While it might be realistic that it's been tough to get donations lately, the sample data could use some recent contributions since otherwise the Top Donors dashlet which is a stock dashlet on the demo looks at first glance to be broken, but it's just empty. Or the dashlet could have some text displayed when there's no data.https://lab.civicrm.org/dev/core/-/issues/2291Some kind of duplicate glitch when editing navigation menu permissions2023-03-20T01:48:25ZDaveDSome kind of duplicate glitch when editing navigation menu permissionsI haven't found the source, but for example
1. Admin - customize - Navigation menu.
1. Go to add or edit one.
1. In the permissions field start typing "edit mess" to get the edit message templates permission. Behold:
![Untitled](/uploads...I haven't found the source, but for example
1. Admin - customize - Navigation menu.
1. Go to add or edit one.
1. In the permissions field start typing "edit mess" to get the edit message templates permission. Behold:
![Untitled](/uploads/642efdf544ae05d43d44a02b7fb6eec3/Untitled.png)
1. Note also the description on the second one is for a different permission.
This also happens if you start typing "system". My guess is it's related to the relatively recently added concept of "implied permissions", because note that those super permissions don't appear in the list, e.g. administer civicrm data isn't a possible choice for a navigation menu permission.https://lab.civicrm.org/dev/core/-/issues/2290Look at REMOVING id column from cache tables2022-12-13T11:58:44ZjitendraLook at REMOVING id column from cache tablesThis is a continuation of the "In Progress" JIRA https://issues.civicrm.org/jira/browse/CRM-19385
which aimed at removing the id from the cache tables but unfortunately was never completed since I see we still have id column in all the ...This is a continuation of the "In Progress" JIRA https://issues.civicrm.org/jira/browse/CRM-19385
which aimed at removing the id from the cache tables but unfortunately was never completed since I see we still have id column in all the cache tables.
```
civicrm_acl_cache
civicrm_acl_contact_cache
civicrm_cache
civicrm_group_contact_cache
civicrm_prevnext_cache
civicrm_relationship_cache
```
Related PRs -
- https://github.com/civicrm/civicrm-core/pull/9743 (Closed)
- https://github.com/civicrm/civicrm-core/pull/9801 (Closed)
- https://github.com/civicrm/civicrm-core/pull/10019 (Merged) - This removed the dependency in the code so think we can start by removing the column directly.
Thoughts @eileen @johnkhttps://lab.civicrm.org/dev/translation/-/issues/61docURL and ts, or how ConfigTaskList.tpl has odd translation strings2021-05-10T20:51:53ZbgmdocURL and ts, or how ConfigTaskList.tpl has odd translation stringsWhen running the string extraction, these strings end up in the .pot files:
```
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviContribute"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid ...When running the string extraction, these strings end up in the .pot files:
```
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviContribute"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviPledge"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviEvent"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviMember"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviMail"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviCampaign"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviCase"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviGrant"
msgstr ""
```
To test:
```
civistrings templates/CRM/Admin/Page/ConfigTaskList.tpl
```
Is it because of an incorrect use of `ts`, or is it because civistrings should ignore crmURL?
Code:
```
<tr class="even">
<td class="tasklist nowrap" style="width: 10%;">{docURL page="user/contributions/what-is-civicontribute" text=$componentTitles.CiviContribute}</td>
<td>{ts}Online fundraising and donor management, as well as offline contribution processing and tracking.{/ts}</td>
</tr>
```
Example of docURL strings that should be extracted:
```
templates/CRM/Contribute/Form/ContributionPage/Custom.hlp:{capture assign=docLinkCustom}{docURL page="user/organising-your-data/custom-fields" text="custom fields"}{/capture}
templates/CRM/Contribute/Form/ContributionPage/Custom.hlp:{capture assign=docLinkProfile}{docURL page="user/organising-your-data/profiles" text="profiles"}{/capture}
templates/CRM/Case/Page/ConfigureError.tpl:{capture assign=docLink}{docURL page="user/case-management/set-up" text="CiviCase Setup documentation"}{/capture}
templates/CRM/Contact/Form/OnBehalfOf.tpl: {ts}Latitude and longitude may be automatically populated by enabling a Mapping Provider.{/ts} {docURL page="user/initial-set-up/installation-and-basic-set-up" text="(Refer to the Mapping and Geocoding section in the Installation and Basic Setup Chapter)"}</span>
```
I feel like we should instead use 'ts' in the docURL call, instead of assuming it. There are 22 instances where it would need fixing.
```
grep -r docURL templates/ | grep text | grep -v componentTitle
```
@totten @seamuslee Any thoughts?https://lab.civicrm.org/dev/core/-/issues/2289PHP memory limit of '-1' not accepted.2021-01-08T02:53:23ZTony Maynard-SmithPHP memory limit of '-1' not accepted.I am running CiviCRM 5.32.2 and Drupal 8.9.11.
My hosting service defaults the PHP memory_limit parameter to '-1', meaning 'unlimited'. The Drupal System Status Report flags a warning that this is insufficient, as follows, which presuma...I am running CiviCRM 5.32.2 and Drupal 8.9.11.
My hosting service defaults the PHP memory_limit parameter to '-1', meaning 'unlimited'. The Drupal System Status Report flags a warning that this is insufficient, as follows, which presumably originates from CiviCRM.
```
CIVICRM: SYSTEM: YOU HAVE -1M ALLOCATED (MINIMUM 32MB, RECOMMENDED 64MB)
CiviCRM: System: You have -1M allocated (minimum 32Mb, recommended 64Mb)
```
Further down the Drupal report says: `PHP MEMORY LIMIT -1 (Unlimited)` without any error, indicating to me that Drupal is happy.
I suggest that a value of '-1' should be acceptable to CiviCRM.5.34.0https://lab.civicrm.org/dev/core/-/issues/2288Custom Field of type Integer that uses Radio Buttons as Input Type in combina...2021-01-19T03:23:54ZkainukCustom Field of type Integer that uses Radio Buttons as Input Type in combination with search range scrambles Case Report SearchOverview
----------------------------------------
https://civicrm.stackexchange.com/questions/38562/why-does-my-delete-case-action-in-the-case-search-report-not-work
Reproduction steps to create the testcase
----------------------------...Overview
----------------------------------------
https://civicrm.stackexchange.com/questions/38562/why-does-my-delete-case-action-in-the-case-search-report-not-work
Reproduction steps to create the testcase
----------------------------------------
1. Create a Custom Field on Cases of the type Integer
1. Start with display type 'Single Input Line'
1. Enable 'Is this Field Searchable?'
1. Now 'Search by Range' becomes visible.
1. Change the display type to Radio Buttons.
1. Add some Option Values and save the field.
Remark, some interface magic is required to create this situation. I think its more done by accident, than by intent.
Current behaviour
----------------------------------------
The behaviour is now as described in https://civicrm.stackexchange.com/questions/38562/why-does-my-delete-case-action-in-the-case-search-report-not-work .
Expected behaviour
----------------------------------------
The Case Search report should just work
Environment information
----------------------------------------
This issue can be reproduced on 5.34.alpha1 or on the https://dmaster.demo.civicrm.org
Comments
----------------------------------------
https://lab.civicrm.org/dev/core/-/issues/337 contains a discussion if the combination 'Radio Buttons' and 'Search by Range' should be allowed.5.35.0https://lab.civicrm.org/dev/wordpress/-/issues/84Fresh Install of 5.33 causes Fatal Error2021-01-07T09:47:05ZkcristianoFresh Install of 5.33 causes Fatal ErrorRan a new install of 5.33 today. On Plugin activation:
```
n error of type E_ERROR was caused in line 120 of the file /home/cv533/public_html/wp-content/plugins/civicrm/includes/civicrm.admin.php. Error message: Uncaught Error: Call t...Ran a new install of 5.33 today. On Plugin activation:
```
n error of type E_ERROR was caused in line 120 of the file /home/cv533/public_html/wp-content/plugins/civicrm/includes/civicrm.admin.php. Error message: Uncaught Error: Call to undefined method CiviCRM_For_WordPress_Admin::assert_php_pupport() in /home/cv533/public_html/wp-content/plugins/civicrm/includes/civicrm.admin.php:120
Stack trace:
#0 /home/cv533/public_html/wp-includes/class-wp-hook.php(287): CiviCRM_For_WordPress_Admin->run_installer('')
#1 /home/cv533/public_html/wp-includes/class-wp-hook.php(311): WP_Hook->apply_filters('', Array)
#2 /home/cv533/public_html/wp-includes/plugin.php(484): WP_Hook->do_action(Array)
#3 /home/cv533/public_html/wp-admin/admin.php(259): do_action('toplevel_page_c...')
#4 /home/cv533/public_html/wp-admin/options-general.php(10): require_once('/home/cv533/pub...')
#5 {main}
thrown
```
Plugin fatals on Activation, Install is just not possible.5.33.0https://lab.civicrm.org/dev/core/-/issues/2286civicrm-setup - Error during, uh, let's call them unit tests, if db port isn'...2021-02-02T00:50:16ZDaveDcivicrm-setup - Error during, uh, let's call them unit tests, if db port isn't specifiedCame up during stuff I probably shouldn't be spending time on, where this line errors if `port` doesn't even exist in the array:
https://github.com/civicrm/civicrm-core/blob/a1692bfae3a507ccac910bef28c2580fee850e61/setup/plugins/init/Dr...Came up during stuff I probably shouldn't be spending time on, where this line errors if `port` doesn't even exist in the array:
https://github.com/civicrm/civicrm-core/blob/a1692bfae3a507ccac910bef28c2580fee850e61/setup/plugins/init/Drupal8.civi-setup.php#L46
`... $connectionOptions['port'] ?: NULL ...`
It's more typing but this old-school version should achieve the same thing and prevent errors:
`empty($connectionOptions['port']) ? NULL : $connectionOptions['port']`
Also this line has the same error: https://github.com/civicrm/civicrm-drupal-8/blob/0b72da46ae00aa08152874d7faa40b66036c58a1/civicrm.install#L116
PR coming5.34.0https://lab.civicrm.org/dev/joomla/-/issues/31Joomla language strings not being used2021-08-27T11:24:06ZElin.WaringJoomla language strings not being usedI submitted https://github.com/civicrm/civicrm-joomla/pull/56
which changes the config.xml code to use Joomla language strings and adds the strings to the language folder. This makes them translatable or override-able.I submitted https://github.com/civicrm/civicrm-joomla/pull/56
which changes the config.xml code to use Joomla language strings and adds the strings to the language folder. This makes them translatable or override-able.https://lab.civicrm.org/dev/core/-/issues/2285The civicrm_alterReportVar hook is not working for contribute detail report2021-04-06T20:01:06Zahed_compucorpThe civicrm_alterReportVar hook is not working for contribute detail reportOverview
----------------------------------------
The `civicrm_alterReportVar` is not working for contribute detail report when the user select the new column or choose the new filter, and it will show an error message `DB Error: no such...Overview
----------------------------------------
The `civicrm_alterReportVar` is not working for contribute detail report when the user select the new column or choose the new filter, and it will show an error message `DB Error: no such field`
Here at [Detail.php#L956](https://github.com/civicrm/civicrm-core/blob/3662d5a75d79d6c259b632df748b1beb66db6faf/CRM/Report/Form/Contribute/Detail.php#L956) our changes to the `_form` attribute are lost and the error will be fired here [Detail.php#L576](https://github.com/civicrm/civicrm-core/blob/3662d5a75d79d6c259b632df748b1beb66db6faf/CRM/Report/Form/Contribute/Detail.php#L576)
Unknown column 'some_table.some_column' in 'where clause'
I believe this is a regression on soft credits.
Reproduction steps
----------------------------------------
Any suffecient use of this hook will face the error message.
[The code](https://gist.github.com/ahed-compucorp/672363f80c076a80c2804b78f61baaa9).
![Peek_2021-01-04_17-19](/uploads/4fef18053a65a947205d6540aa123552/Peek_2021-01-04_17-19.gif)
check the test case in the PR.
PR: https://github.com/civicrm/civicrm-core/pull/193175.37.0