Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-11-19T20:29:40Zhttps://lab.civicrm.org/dev/core/-/issues/2612CiviCRM 5.37.2 'CRM_Utils_ReCAPTCHA' not found2021-11-19T20:29:40ZbrianpCiviCRM 5.37.2 'CRM_Utils_ReCAPTCHA' not foundWe upgraded to 5.37.2 on Drupal 7 this morning and all the donation pages are now broken. I've cleared the cache and ensured the DB upgrade is complete. Per Issues #2596 I don't see a /ext/recaptcha in civicrm-core. Should that be there?...We upgraded to 5.37.2 on Drupal 7 this morning and all the donation pages are now broken. I've cleared the cache and ensured the DB upgrade is complete. Per Issues #2596 I don't see a /ext/recaptcha in civicrm-core. Should that be there?
Error: Class 'CRM_Utils_ReCAPTCHA' not found in CRM_Contribute_Form_ContributionBase->hasToAddForcefully() (line 845 of /code/sites/all/modules/civicrm/CRM/Contribute/Form/ContributionBase.php).https://lab.civicrm.org/dev/core/-/issues/3215On changing 'Limit Dashboard Results' count adds duplicate dashlet2023-12-25T05:03:30ZMonish DebOn changing 'Limit Dashboard Results' count adds duplicate dashletSteps to replicate:
1. Go to any existing report instance (say 'Activity Details') >> enable for 'Available for Dashboard' >> Save
2. Then change the 'Limit Dashboard Results' count and save again.
3. Go to homepage, and click on 'A...Steps to replicate:
1. Go to any existing report instance (say 'Activity Details') >> enable for 'Available for Dashboard' >> Save
2. Then change the 'Limit Dashboard Results' count and save again.
3. Go to homepage, and click on 'Available Dashlets'
Result:
You will find two duplicate dashlets has been created with same title. Here's a screencast in dmaster:
![after](/uploads/ff1256639e635a2887033f42b150d2d9/after.gif)Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/2613Useradd task gives a deprecation notice for the password confirmation field2021-05-19T21:47:08ZDaveDUseradd task gives a deprecation notice for the password confirmation field```
Deprecated function: Function create_function() is deprecated in HTML_QuickForm_Rule_Compare->validate() (line 87 of ...\vendor\civicrm\civicrm-packages\HTML\QuickForm\Rule\Compare.php).
HTML_QuickForm_Rule_Compare->validate(Array, ...```
Deprecated function: Function create_function() is deprecated in HTML_QuickForm_Rule_Compare->validate() (line 87 of ...\vendor\civicrm\civicrm-packages\HTML\QuickForm\Rule\Compare.php).
HTML_QuickForm_Rule_Compare->validate(Array, '===') (Line: 158)
HTML_QuickForm_RuleRegistry->validate('compare', Array, NULL, 1) (Line: 1580)
HTML_QuickForm->validate() (Line: 591)
CRM_Core_Form->validate() (Line: 126)
CRM_Core_StateMachine->perform(Object, 'next', 'Next') (Line: 43)
CRM_Core_QuickForm_Action_Next->perform(Object, 'next') (Line: 203)
HTML_QuickForm_Controller->handle(Object, 'next') (Line: 103)
HTML_QuickForm_Page->handle('next') (Line: 352)
CRM_Core_Controller->run() (Line: 35)
CRM_Contact_Page_View_Useradd->run(Array, NULL) (Line: 313)
```
To reproduce:
1. Use 5.36 or earlier, or you'll see it again after https://github.com/civicrm/civicrm-core/pull/20274.
2. View a contact.
3. From the actions menu choose Create User Record.
4. Fill it out and save.
It's deprecated in php 7.2 and will be removed in php 8.
There's two obvious ways to fix this:
1. Just doing a quickie search, this form is the only place the quickform "compare" rule is used. So just replace it with a local formRule that just does "is it equal".
2. Patch quickform to update this rule.
Either way is about the same amount of work I think, so leaning towards choice 1.5.39.0https://lab.civicrm.org/dev/core/-/issues/2614Sample payment processor types are misaligned in the sample data2021-05-15T21:47:26ZDaveDSample payment processor types are misaligned in the sample datae.g. on dmaster.demo.civicrm.org it says Elavon is configured when it's supposed to be the dummy processor, and then when you edit it it says it's authorize.net, presumably because the id doesn't match up and it's just picking the first ...e.g. on dmaster.demo.civicrm.org it says Elavon is configured when it's supposed to be the dummy processor, and then when you edit it it says it's authorize.net, presumably because the id doesn't match up and it's just picking the first in the list.
I'm thinking this is a regression from some payment processor type rearranging but I think it's only affecting the sample data.5.39.0https://lab.civicrm.org/dev/core/-/issues/2615Not inserting a ACL Role using ACL Role API2023-11-21T05:03:17Zmichaels23Not inserting a ACL Role using ACL Role APIOverview
----------------------------------------
I was trying to assigning a new Users to CiviCRM ACL role through ACL Role API, but it is not showing me in database.
Reproduced on https://demo.tadpole.cc/wp-admin/admin.php?page=CiviCR...Overview
----------------------------------------
I was trying to assigning a new Users to CiviCRM ACL role through ACL Role API, but it is not showing me in database.
Reproduced on https://demo.tadpole.cc/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fapi3#explorer
[link to that conversation](https://civicrm.stackexchange.com/questions/28088/not-inserting-a-acl-role-using-acl-role-api).
Reproduction steps
----------------------------------------
Input
` $result = civicrm_api3('AclRole', 'create', [
'debug' => 1,
'sequential' => 1,
'acl_role_id' => 14,
'entity_table' => "civicrm_group",
'entity_id' => 54,
'is_active' => 1,
]);`
Output
`"values": [
{
"id": "14",
"acl_role_id": "",
"entity_table": "civicrm_group",
"entity_id": "54",
"is_active": "1"
}
]`
I verified that "acl_role_id": 15 and civicrm_group 54 do exist.
Current behaviour
----------------------------------------
I don't see any new entries at https://demo.tadpole.cc/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Facl%2Fentityrole&reset=1
Expected behaviour
----------------------------------------
new entry at https://demo.tadpole.cc/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Facl%2Fentityrole&reset=1
Environment information
----------------------------------------
* __Browser:__ Google Chrome Version 90.0.4430.212 (Official Build) (64-bit)
* __CiviCRM:__ Powered by CiviCRM 5.37.2.
* __PHP:__ PHP version 7.3.27
* __CMS:__ _WordPress.Version 5.5.5
Comments
----------------------------------------https://lab.civicrm.org/dev/core/-/issues/3361View and Edit links for event participants are inconsistent and in some cases...2023-08-12T00:24:39ZlarsssandergreenView and Edit links for event participants are inconsistent and in some cases do not allow editingWhen using a price set, the View and Edit links for a participants lead to different forms depending on if the registration has an associated contribution. When there is a contribution record, the Edit link does not allow the user to edi...When using a price set, the View and Edit links for a participants lead to different forms depending on if the registration has an associated contribution. When there is a contribution record, the Edit link does not allow the user to edit the price set selections, while it is possible to edit those selection from the View link (with Change Selections). I believe this is a regression.
When there is no contribution record, you cannot edit the price set selections from the View link, but you can from the Edit link. That seems confusing for users and it would be best to make it consistent.
Here are some screenshots:
1) View with a contribution, this makes sense
![image](/uploads/52e7c3a5b96befe0a404f57850cc5bcf/image.png)
2) View without a contribution, seems like it there should be possible to change selections here as well for consistency (or else a user may think they can't edit the price set selections)
![image](/uploads/c93e10bbecf9ae053ea771becb07ac12/image.png)
3) Edit with a contribution, this should be the same as the View with a contribution, i.e. there should be a Change Selections link and the table of selections above it
![image](/uploads/95edcf86ca33d6bcdff302cee619acf8/image.png)
4) Edit without a contribution, this makes sense
![image](/uploads/12e211610125abb94b4f829bca465ebe/image.png)
I believe 3 - Edit with a contribution is a regression. I get his behaviour on dmaster, 5.37 and 5.35.2, but not on 5.24.5, where there is a Change Selections link and the table above.
Changing 2 - View without a contribution may be more complicated. What about adding an Edit Registration link, in the same place where the Change Selections link would otherwise be, that simply takes you to the edit form? As far as I can tell, trying to use Change Selections with a registration that doesn't have a contribution will result in errors. I'm not sure what would be involved in making it possible to use Change Selections in this case, but it seems like adding an edit link would be a simpler solution to keep some consistency between these two cases.https://lab.civicrm.org/dev/core/-/issues/2616Inherited Membership is updated by a non owner2023-08-08T05:03:21ZjitendraInherited Membership is updated by a non ownerOverview
----------------------------------------
Inherited Membership is updated by a non-owner.
Reproduction steps
----------------------------------------
1. Create an inherited General membership on a contact.
![image](/uploads/660...Overview
----------------------------------------
Inherited Membership is updated by a non-owner.
Reproduction steps
----------------------------------------
1. Create an inherited General membership on a contact.
![image](/uploads/6600a2906487dcda16baf87a443b656e/image.png)
2. Visit the Membership signup page and choose Student type (same org).
![image](/uploads/eea6f4019d33b888763485bd00915aaf/image.png)
3. Existing Inherited membership is updated to hold the Student Type. The primary membership is of type General.
![image](/uploads/831b8566d3aaa1346e09ce390d9ad799/image.png)
It's a different membership type and the user should not be allowed to 'renew' a membership given by a relationship?
Civi behaviour is like 'treat it as a renewal with a membership change' which is well and good for two 'same org' memberships for a person. But with an inherited one there needs to be a different set of rules? because inheritees should not be able to touch/change their inherited membership EXCEPT by adjusting the relationship. Only the membership owner should be able to update them?
If the above make sense, i think this if clause https://github.com/civicrm/civicrm-core/blob/master/CRM/Member/BAO/Membership.php#L1799 need to include an additional check for
```
$inheritedMemTypeChange = FALSE;
if (!empty($currentMembership['owner_membership_id'] && $membershipTypeID != $currentMembership['membership_type_id'])) {
$inheritedMemTypeChange = TRUE;
}
if ($currentMembership && !$inheritedMemTypeChange) {
```https://lab.civicrm.org/dev/core/-/issues/2617Automatic defaults for TIMESTAMP columns can differ between databases or data...2023-08-10T05:03:28ZFrancis (Agileware)Automatic defaults for TIMESTAMP columns can differ between databases or database configurations.This mostly applies to a difference between MariaDB and MySQL, but a difference may also be seen in certain configurations of MySQL.
Essentially, currently MySQL will normally not apply any defaults to `TIMESTAMP` columns, but MariaDB, ...This mostly applies to a difference between MariaDB and MySQL, but a difference may also be seen in certain configurations of MySQL.
Essentially, currently MySQL will normally not apply any defaults to `TIMESTAMP` columns, but MariaDB, earlier (possibly unsupported) versions of MySQL, and some (deprecated) configurations of MySQL will set `DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP`
See:
- https://mariadb.com/kb/en/timestamp/#automatic-values
- https://dev.mysql.com/doc/refman/8.0/en/timestamp-initialization.html , specifically:
> TIMESTAMP and DATETIME columns have no automatic properties unless they are specified explicitly, with this exception: If the explicit_defaults_for_timestamp system variable is disabled, the first TIMESTAMP column has both DEFAULT CURRENT_TIMESTAMP and ON UPDATE CURRENT_TIMESTAMP if neither is specified explicitly.
- https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_explicit_defaults_for_timestamp which details the variable which can make MySQL behave differently
This can result in some unexpected behaviour if someone creates an Entity definition with no default, and the resulting SQL is installed on a system with a different database e.g.:
- on the author's system with MySQL no default is set, and the value is not automatically updated when the entity is saved
- on an end-user's system with MariaDB, the default is set to CURRENT_TIMESTAMP, and the field is updated every time the entity is saved *without that field explicitly set*
No evidence of the changed default will be visible in the XML schema or the resulting SQL code.
A possible solution to this is to ensure a fallback default (probably NULL) is used during the GenCode phase to avoid inconsistency, as per @eileen's [suggestion on chat.civicrm.org](https://chat.civicrm.org/civicrm/pl/b1sokyxyqpdutbc88drrzyxmrc)https://lab.civicrm.org/dev/joomla/-/issues/33Data from custom fields is not stored in event but in event template2021-05-26T04:45:41ZoseidelData from custom fields is not stored in event but in event templateWhen creating a new event using an event template which includes custom fields, the data entered in the custom fields won't be stored in the event itself when clicking the 'Continue'-button, but are stored in the event template. After cl...When creating a new event using an event template which includes custom fields, the data entered in the custom fields won't be stored in the event itself when clicking the 'Continue'-button, but are stored in the event template. After clicking 'Continue' and then going back to the 'Info and Settings'-tab all data entered in the custom fields is gone. However, the data can be found in the used event template now. By going into edit mode the data is set in the template's custom fields and will be prefilled in the next event generated using this template.
This issue might be conneted to this one: [Core Issue 766](https://lab.civicrm.org/dev/core/-/issues/766)
See also a related post on [stackexchange](https://civicrm.stackexchange.com/questions/20709/new-event-from-template-does-not-copy-custom-fields)
Notice that custom field are 'only' lost in this cases, while it gets stored in the template in this one.
Steps to reproduce:
1. Set up fresh Joomla instance (V. 3.9.26 at the time of writing)
2. Install latest CiviCRM for Joomla (V. 5.37.2 at the time of writing)
3. Create a new set of custom fields (I've been using text, date and select inputs in my tests)
4. Create a new event template and fill out all necessary inputs (I've also entered something in the title, summary and description).
5. Create a new event using the newly created template. Enter something in all necessary fields as well as in the custom fields.
6. Click 'Continue'
7. Return to 'Info and Settings' - the data entered in the custom fields is gone :/
8. Open the template in edit mode. The custom data we previously entered in the event is here now
This issue can be reproduced in CiviCRM 5.37.0 and 5.37.2, but not in 5.36.1 used in the [Joomla Demo](https://cividemo.com/).
I've been using the following environments to test: AMPPS 3.9 and XAMPP (compile date 4-6-21) with PHP 7.3.
As I'm only using CiviCRM inside Joomla I haven't testet whether this issue also appears in other CMS- or the standalone-version.
A possible workaround for the problem is to skip entering something in the custom fields in Step 5 but doing so in Step 7. The contents of custom fields are saved correctly now. However, another strange behaviour occurs now: If there is any content of the custom fields already set in the template (e.g. if a field is set as required), this data is missing in the event using the template. Even in fields marked as required - the content set in the template is just gone.https://lab.civicrm.org/dev/core/-/issues/3382Data from custom fields is not stored in event but in event template2022-04-22T16:22:22ZoseidelData from custom fields is not stored in event but in event templateWhen creating a new event using an event template which includes custom fields, the data entered in the custom fields won't be stored in the event itself when clicking the 'Continue'-button, but are stored in the event template. After cl...When creating a new event using an event template which includes custom fields, the data entered in the custom fields won't be stored in the event itself when clicking the 'Continue'-button, but are stored in the event template. After clicking 'Continue' and then going back to the 'Info and Settings'-tab all data entered in the custom fields is gone. However, the data can be found in the used event template now. By going into edit mode the data is set in the template's custom fields and will be prefilled in the next event generated using this template.
This issue might be conneted to this one: [Core Issue 766](https://lab.civicrm.org/dev/core/-/issues/766)
See also a related post on [stackexchange](https://civicrm.stackexchange.com/questions/20709/new-event-from-template-does-not-copy-custom-fields)
Notice that custom field are 'only' lost in this cases, while it gets stored in the template in this one.
Steps to reproduce:
1. Set up fresh Joomla instance (V. 3.9.26 at the time of writing)
2. Install latest CiviCRM for Joomla (V. 5.37.2 at the time of writing)
3. Create a new set of custom fields (I've been using text, date and select inputs in my tests)
4. Create a new event template and fill out all necessary inputs (I've also entered something in the title, summary and description).
5. Create a new event using the newly created template. Enter something in all necessary fields as well as in the custom fields.
6. Click 'Continue'
7. Return to 'Info and Settings' - the data entered in the custom fields is gone :/
8. Open the template in edit mode. The custom data we previously entered in the event is here now
This issue can be reproduced in CiviCRM 5.37.0 and 5.37.2, but not in 5.36.1 used in the [Joomla Demo](https://cividemo.com/).
I've been using the following environments to test: AMPPS 3.9 and XAMPP (compile date 4-6-21) with PHP 7.3.
As I'm only using CiviCRM inside Joomla I haven't testet whether this issue also appears in other CMS- or the standalone-version.
A possible workaround for the problem is to skip entering something in the custom fields in Step 5 but doing so in Step 7. The contents of custom fields are saved correctly now. However, another strange behaviour occurs now: If there is any content of the custom fields already set in the template (e.g. if a field is set as required), this data is missing in the event using the template. Even in fields marked as required - the content set in the template is just gone.5.39.0https://lab.civicrm.org/dev/core/-/issues/2618Potential data loss on large forms2023-08-10T05:03:28Zaydunsaidan.saunders@squiffle.ukPotential data loss on large formsOverview
----------------------------------------
On large forms, fields may be dropped before form processing potentially resulting in data loss.
If the number of fields in the form submission exceeds the `max_input_vars` php setting (...Overview
----------------------------------------
On large forms, fields may be dropped before form processing potentially resulting in data loss.
If the number of fields in the form submission exceeds the `max_input_vars` php setting (1000 by default) then `$_POST` is truncated. The problem was noticed with the 'Update multiple contacts' action and a profile with 13 fields - see https://civicrm.stackexchange.com/questions/39588/update-multiple-contacts-failing
Reproduction steps
----------------------------------------
1. Check that `max_input_vars` has the default of 1000
1. Create a custom field set with 12 fields and a profile with them all.
1. Search for contacts, select 100, then the 'update multiple contacts' action and the profile just created
1. Add some data & save.
Current behaviour
----------------------------------------
Note that the last records are not updated correctly.
Depending on the field type, existing data may be removed by the update, not just that new data fails to save.
Then add `max_input_vars = 2000` to php.ini, restart php/apache (depending on your config) and repeat. Should be ok.
Expected behaviour
----------------------------------------
All data should be processed correctly.
Environment information
----------------------------------------
* __CiviCRM:__ _Master_
* __PHP:__ _7.3_
* __CMS:__ _Drupal 7.80._
Comments
----------------------------------------
When this occurs an **E_WARNING** is issued by php according to the [documentation](https://www.php.net/manual/en/info.configuration.php#ini.max-input-vars). It may be possible to capture that and respond appropriately.
Alternatively, forms (or those that might be big ones) could include a field with the expected number of fields and processing would check the actual number of fields against the expected number.
Somehow we should avoid processing forms where the incoming fields have been truncated.https://lab.civicrm.org/dev/core/-/issues/2620Uninstalling the oauth extension leaves the admin menu entry in the menus and...2023-08-16T05:03:17ZDaveDUninstalling the oauth extension leaves the admin menu entry in the menus and then reinstalling duplicates itIt doesn't break anything it's just obviously wrong.It doesn't break anything it's just obviously wrong.https://lab.civicrm.org/dev/core/-/issues/2621APIv4, setCheckPermissions FALSE is required to get listing of Events for Ano...2021-06-07T03:17:08Zjustinfreeman (Agileware)APIv4, setCheckPermissions FALSE is required to get listing of Events for Anonymous usersAPIv4, setCheckPermissions FALSE is required to get listing of Events for Anonymous users, despite Anonymous having access to Events. The same type of call using APIv3 works without error.
Tested using a standard CiviCRM 5.37.2 install ...APIv4, setCheckPermissions FALSE is required to get listing of Events for Anonymous users, despite Anonymous having access to Events. The same type of call using APIv3 works without error.
Tested using a standard CiviCRM 5.37.2 install on WordPress. The same site allows Anonymous access to the CiviCRM event listing page, /civicrm/event/list/?reset=1
Here's example code which will return a **403 unauthorised error** for anonymous users.
```
$results = \Civi\Api4\Event::get()
->addSelect('id', 'title', 'start_date', 'end_date', 'event_tz', 'event_type_id', 'is_online_registration')
->addWhere('start_date', '>=', 'today')
->addWhere('is_public', '=', TRUE)
->addWhere('is_active', '=', TRUE)
->addOrderBy('start_date', 'ASC');
```
However, this code will work for anonymous users.
```
$results = \Civi\Api4\Event::get()
->addSelect('id', 'title', 'start_date', 'end_date', 'event_tz', 'event_type_id', 'is_online_registration')
->addWhere('start_date', '>=', 'today')
->addWhere('is_public', '=', TRUE)
->addWhere('is_active', '=', TRUE)
->addOrderBy('start_date', 'ASC')
->setCheckPermissions(FALSE);
```
**It's not clear why setCheckPermissions would be required at all for this type of API call.**
Agileware Ref: CIVICRM-1764https://lab.civicrm.org/dev/core/-/issues/2623Upgrade 5.33.4 to 5.33.5, unable to view groups in Manage Groups or view mail...2021-05-24T11:39:10ZmattUpgrade 5.33.4 to 5.33.5, unable to view groups in Manage Groups or view mailings, activities or relationships in respective contact tabsOverview
----------------------------------------
After upgrading from 5.33.4 to 5.33.5, unable to view groups in Manage Groups or view mailings, activities or relationships in respective contact tabs.
Reproduction steps
---------------...Overview
----------------------------------------
After upgrading from 5.33.4 to 5.33.5, unable to view groups in Manage Groups or view mailings, activities or relationships in respective contact tabs.
Reproduction steps
----------------------------------------
1. Click on **Contacts -> Manage Groups** or
1. Open a contacts summary and click on **Mailings**, **Activities** or **Relationships**.
Current behaviour
----------------------------------------
All displays mentioned are empty of results. Contact Activities tab displays following error in browser console.
```
XHRGET.../civicrm/ajax/contactactivity?snippet=4&context=activity&cid=2&draw=1&columns%5B0%5D%5Bdata%5D=activity_type&columns%5B0%5D%5Bname%5D=&columns%5B0%5D%5Bsearchable%5D=true&columns%5B0%5D%5Borderable%5D=true&columns%5B0%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B0%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B1%5D%5Bdata%5D=subject&columns%5B1%5D%5Bname%5D=&columns%5B1%5D%5Bsearchable%5D=true&columns%5B1%5D%5Borderable%5D=true&columns%5B1%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B1%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B2%5D%5Bdata%5D=source_contact_name&columns%5B2%5D%5Bname%5D=&columns%5B2%5D%5Bsearchable%5D=true&columns%5B2%5D%5Borderable%5D=true&columns%5B2%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B2%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B3%5D%5Bdata%5D=target_contact_name&columns%5B3%5D%5Bname%5D=&columns%5B3%5D%5Bsearchable%5D=true&columns%5B3%5D%5Borderable%5D=false&columns%5B3%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B3%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B4%5D%5Bdata%5D=assignee_contact_name&columns%5B4%5D%5Bname%5D=&columns%5B4%5D%5Bsearchable%5D=true&columns%5B4%5D%5Borderable%5D=false&columns%5B4%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B4%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B5%5D%5Bdata%5D=activity_date_time&columns%5B5%5D%5Bname%5D=&columns%5B5%5D%5Bsearchable%5D=true&columns%5B5%5D%5Borderable%5D=true&columns%5B5%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B5%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B6%5D%5Bdata%5D=status_id&columns%5B6%5D%5Bname%5D=&columns%5B6%5D%5Bsearchable%5D=true&columns%5B6%5D%5Borderable%5D=true&columns%5B6%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B6%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B7%5D%5Bdata%5D=links&columns%5B7%5D%5Bname%5D=&columns%5B7%5D%5Bsearchable%5D=true&columns%5B7%5D%5Borderable%5D=false&columns%5B7%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B7%5D%5Bsearch%5D%5Bregex%5D=false&start=0&length=25&search%5Bvalue%5D=&search%5Bregex%5D=false&activity_type_id=&activity_type_exclude_id=&activity_date_time_relative=&activity_date_time_low=&activity_date_time_high=&activity_status_id=&_=1621483697855
Uncaught TypeError: json is null
<anonymous> .../sites/default/files/js/js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js line 14 > eval:20
dispatch .../sites/default/files/js/js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js:15
handle .../sites/default/files/js/js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js:15
trigger .../sites/default/files/js/js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js:15
trigger .../sites/default/files/js/js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js:15
each .../sites/default/files/js/js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js:14
each .../sites/default/files/js/js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js:14
js_VksT9VyUPqN12it0nB53nHNlLsFmhtLUGWGK2iQcxvM.js line 14 > eval:20:31
```
Environment information
----------------------------------------
* __Browser:__ Firefox 88.0.1 (64-bit)
* __CiviCRM:__ 5.33.4 to 5.33.5
* __PHP:__ 7.3.28
* __CMS:__ Drupal 7.80
* __Database:__ MySQL 5.6.51-91.0
* __Web Server:__ Nginx 1.20.0https://lab.civicrm.org/dev/core/-/issues/2624Line items not visible on recurring contribution2021-07-28T14:48:48ZjaapjansmaLine items not visible on recurring contributionWhen creating a new contribution recur with a contribution page and a price set with multiple line items. The line items are not stored within the contribution recur entity.
**Steps to reproduce**
1. Create a new price set (Financial t...When creating a new contribution recur with a contribution page and a price set with multiple line items. The line items are not stored within the contribution recur entity.
**Steps to reproduce**
1. Create a new price set (Financial type donation)
2. Create a price set field (Financial type Campaign donation)
3. Create a second price set field (Financial type Products)
4. Create a contribution page:
Financial type: donation
Amounts tab: Payment Processor: test processor
Amounts tab: Contributions amount section enabled: checked
Amounts tab: Price set: _select the created price set_
Amounts tab: Recurring contributions: check
5. Create a new contribution recur through the contribution page
6. Lookup the contribution recur on the Contact Summary
**Expected result**
Showing the line items. The total amount is correct.
**Actual result**
Line items are not visible at the contribution recur.
Below a screenshot of the contribution
![Screenshot_20210520_211830](/uploads/2447b95df431002e4405559a72fec4b5/Screenshot_20210520_211830.png)
And of the recurring contribution
![Screenshot_20210520_211918](/uploads/4036a932904649bbaa7c0d93b13879fb/Screenshot_20210520_211918.png)
**Possible solution**
I have looked up the line items in the database and there are no line items linked to the recurring contribution.
So the possible solution would exists of two steps:
1. Connect the line items to contribution recur
2. Make the line items visible in a similar way as on the contribution.
**Remarks**
Creating a new contribution with the `contribution.repeattransaction` api based on the first contribution and the recurring contribution correctly creates the line items at the contribution level.
**Funding**
I have some funding to work on this. So PR's might follow soon.
**PRs**
* ~~Fix for saving line items at the recurring contribution: https://github.com/civicrm/civicrm-core/pull/20398~~
* Fix for showing the line items from the template contribution: https://github.com/civicrm/civicrm-core/pull/20399
* Fix for excluding template contributions from reports: https://github.com/civicrm/civicrm-core/pull/20450
* Fix for searching template contributions: https://github.com/civicrm/civicrm-core/pull/20451
* Fix for excluding template contributions on the contact summary tab: https://github.com/civicrm/civicrm-core/pull/20452
* Fix for adding a button view template on the recurring contributions tab: https://github.com/civicrm/civicrm-core/pull/20685
* ~~Fix for creation of template contributions: https://github.com/civicrm/civicrm-core/pull/20453~~
**To do**
* Update user documentation
* Make sure an upgrade path exists
See also financial#65.41.0jaapjansmajaapjansmahttps://lab.civicrm.org/dev/core/-/issues/2625Adding recurring contributions in the backend of CiviCRM2021-09-22T14:32:30ZjaapjansmaAdding recurring contributions in the backend of CiviCRMCurrently there is a page to view a recurring contribution.
However a form is missing for adding new recurring contributions from the backend. Nor is it possible to edit existing recurring contributions.
See below a sketch of the chang...Currently there is a page to view a recurring contribution.
However a form is missing for adding new recurring contributions from the backend. Nor is it possible to edit existing recurring contributions.
See below a sketch of the changes on the tab Recurring Contributions on the contact summary.
![Screenshot_20210520_213037](/uploads/f04570f2d1896c00e70ad10718ed777d/Screenshot_20210520_213037.png)
Those buttons lead to a form where one can either enter a new recurring contribution, or edit an existing one.
**Solution**
1. Add a form for adding and editing the recurring contribution. I do think the form for add and edit could be the same.
2. Add the necessary buttons on the recurring contribution tab
**Funding**
I have funding to work on this so a PR might follow soon.jaapjansmajaapjansmahttps://lab.civicrm.org/dev/financial/-/issues/173"Pay Now" button on user dashboard is only for Pending, not Partially Paid co...2021-06-02T10:08:33ZJonGold"Pay Now" button on user dashboard is only for Pending, not Partially Paid contributions### Steps to replicate:
* Install Line Item Editor.
* Create a completed contribution.
* Use line item editor to increase the amount of the contribution, so the status changes to "Partially Paid".
* (Optional) For comparison, create a Pe...### Steps to replicate:
* Install Line Item Editor.
* Create a completed contribution.
* Use line item editor to increase the amount of the contribution, so the status changes to "Partially Paid".
* (Optional) For comparison, create a Pending contribution.
* Enable Tax and Invoicing in CiviContribute Settings.
* Visit the user dashboard.
### Expected Result
Both the "Pending" and "Partially Paid" contributions will have a "Pay Now" button next to them.
### Actual Result
Only the "Pending" contribution has a "Pay Now" button.
This was so quick to fix that I thought at first it might be intentional, but I really think it's just one of those places where partial payments are still a bit rough around the edges. Partially paid invoices are functional, so I think it's just adding a button that links to existing functionality.
I see that #14051 by @eileen covered this, and @magnolia61 requested it cover "Partially Paid" invoices as well, so I imagine that if anyone knows a reason why this PR should not be wed to core, it's them, and they'll speak up now.5.39.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2626The REST link produced by API v3 Explorer gives 'page not found' under Drupal 92023-08-26T05:03:22ZspalmstromThe REST link produced by API v3 Explorer gives 'page not found' under Drupal 9Overview
----------------------------------------
The REST link produced by API v3 Explorer gives 'page not found', i.e. it doesn't work.
Reproduction steps
----------------------------------------
1. Click on Support -> Developer -> AP...Overview
----------------------------------------
The REST link produced by API v3 Explorer gives 'page not found', i.e. it doesn't work.
Reproduction steps
----------------------------------------
1. Click on Support -> Developer -> API Explorer v3
1. Choose Contact and Get.
1. The Curl string returned is this:
```
curl '<drupal URL>/libraries/civicrm/core/extern/rest.php?entity=Contact&action=get&json=%7B%22sequential%22%3A1%7D&api_key=FIXME_USER_KEY&key=FIXME_SITE_KEY'
```
1. Fix the FIXME values and copy and paste the URL into a browser.
Current behaviour
----------------------------------------
_What happens currently. Please provide error messages, screenshots or gifs ([LICEcap](http://www.cockos.com/licecap/), [SilentCast](https://github.com/colinkeenan/silentcast)) where appropriate._
![image](/uploads/54b2aa119190710bf007b6a35e8ca91f/image.png)
Expected behaviour
----------------------------------------
_What should happen._
JSON list of contacts should appear.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _MS Edge_ but probably irrelevant.
* __CiviCRM:__ _5.37.2_
* __PHP:__ _7.4_ but probably irrelevant.
* __CMS:__ _Drupal 9.1.8_
* __Database:__ _MySQL 8.0.25_ but probably irrelevant.
* __Web Server:__ _IIS_ but probably irrelevant.
Comments
----------------------------------------
I know that REST is being deprecated, but there does not seem to be a replacement available.
The reason for the issue is that rest.php lives here:
```
<drupal root>/vendor/civicrm/civicrm-core/extern
```
not here:
<drupal root>/
```
<drupal root>/web/libraries/civicrm/core
```
A solution is to create a symbolic link to the extern folder in the latter folder. Copying the folder might also work, but then it would not be automatically updated when CiviCRM is updated.
There is an issue with rest.php itself, but I shall raise that as a separate issue.https://lab.civicrm.org/dev/core/-/issues/2627rest.php crashes with 'Failed to open' ... civicrm.config.php under Drupal 92023-08-21T05:03:19Zspalmstromrest.php crashes with 'Failed to open' ... civicrm.config.php under Drupal 9Overview
----------------------------------------
Having solved issue [The REST link produced by API v3 Explorer gives 'page not found' under Drupal 9](https://lab.civicrm.org/dev/core/-/issues/2626), running the link gives
**Warning:** ...Overview
----------------------------------------
Having solved issue [The REST link produced by API v3 Explorer gives 'page not found' under Drupal 9](https://lab.civicrm.org/dev/core/-/issues/2626), running the link gives
**Warning:** require_once(../civicrm.config.php): failed to open stream: No such file or directory in <drupal root>/vendor/civicrm/civicrm-core/extern/rest.php on line 12
**Fatal error:** require_once(): Failed opening required '../civicrm.config.php' (include_path='...) in ...
Reproduction steps
----------------------------------------
1. Run a REST query from a browser as generated by API Explorer v3 with the FIXMEs fixed.
Current behaviour
----------------------------------------
See the above.
Expected behaviour
----------------------------------------
A JSON list of contacts should appear.
Environment information
----------------------------------------
* __Browser:__ _MS Edge_ but probably irrelevant
* __CiviCRM:__ _5.38.1alpha/5.37.2_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.4_ but probably irrelevant
* __CMS:__ _Drupal 9.1.8_
* __Database:__ _MySQL 8.0.25._ but probably irrelevant.
* __Web Server:__ _IIS_ but probably irrelevant.
Comments
----------------------------------------
I know that the REST approach is being deprecated, but we do not seem to have replacement.
1. I could not find civicrm.config.php in the CiviCRM distribution; I suspect it may be obsolete.
1. Replacing line 12 with
```
require_once filter_input(INPUT_SERVER, 'APPL_PHYSICAL_PATH') . 'sites/default/civicrm.settings.php';
```
cured the problem. Someone with more CiviCRM expertise than I may be able to suggest a better solution.
```https://lab.civicrm.org/dev/core/-/issues/2628Contribution Detail Report Select County2023-08-15T05:03:14ZandyburnsContribution Detail Report Select CountyThis report `CRM_Report_Form_Contribute_Detail`, and any reports based on it, have the order of Country, State, County wrong. It allows you to select the County first, then State, then Country. e.g. There are 12 entries for Douglas Count...This report `CRM_Report_Form_Contribute_Detail`, and any reports based on it, have the order of Country, State, County wrong. It allows you to select the County first, then State, then Country. e.g. There are 12 entries for Douglas County in Colorado, USA, and choosing the wrong one returns no donations. The order of these fields needs to be reversed, so that only the counties in the selected state are shown and this would match how Advanced Search works.
![image](/uploads/c3a5ae49d598a698df9d6423298decba/image.png)
Revised order:
1. Country
1. State/Province
1. County