Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-07-02T03:13:28Zhttps://lab.civicrm.org/dev/core/-/issues/2412Allow Entities within Afform to reference each other for values2021-07-02T03:13:28ZseamusleeAllow Entities within Afform to reference each other for valuesProposal:
To allow Entities to reference each other to get the relevant values to be used by afform:
Example:
Create an Afform that has Individual Fields but also you want to create an Activity with it, Allow for the source_contact_id...Proposal:
To allow Entities to reference each other to get the relevant values to be used by afform:
Example:
Create an Afform that has Individual Fields but also you want to create an Activity with it, Allow for the source_contact_id field to be set to something like `Individual1.id` or similar which is then translated in the save process to the appropriate id
Perhaps initially this should just be limited to ID fields I'm not sure. I'm thinking that we would probably have to come up with a angular way of dynamically populating the list of known fields about the other entity and then in the Save pass through an array of created Entities but this may also need to do some work on working through the logic i.e. ensure that Individual is created before the Activity for instance
@colemanw @eileen @totten @JoeMurray5.39.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2411On New Campaign form, placeholder text for status is weird2021-03-10T01:23:11ZDaveDOn New Campaign form, placeholder text for status is weirdIt says "- select Campaign -".
It's a minor thing but in trying to see where it's coming from, I _think_ this is supposed to come from metadata somewhere, but it's falling back to the entity title, so is likely a generic issue, except t...It says "- select Campaign -".
It's a minor thing but in trying to see where it's coming from, I _think_ this is supposed to come from metadata somewhere, but it's falling back to the entity title, so is likely a generic issue, except that it's rare that an entity's status is an optional field so you don't see it anywhere else.
So then that brings up the question of whether the status field for campaigns should be optional. What does it mean for a campaign to be status-less?
Maybe ditto for Grants, except there it's both required AND shows you the placeholder, whereas normally for required you don't have the placeholder.5.37.0https://lab.civicrm.org/dev/financial/-/issues/167Document Support for CiviCRM from payment processors2024-03-07T16:39:04ZJoeMurrayDocument Support for CiviCRM from payment processorsDocument appropriately the support that CiviCRM receives from a variety of payment processors.
- [ ] Payment processing feature page that cites the sponsoring payment processors
- [ ] Individual payment processor pages similar to partn...Document appropriately the support that CiviCRM receives from a variety of payment processors.
- [ ] Payment processing feature page that cites the sponsoring payment processors
- [ ] Individual payment processor pages similar to partner detail pages
- [ ] Update the extension readme.md on extensions in gitlab
- [ ] Update extension pages on c.o (for as long as these will exist)
Josh has started on first two tasks as of Feb 22, 2021.
----
Original description
Document appropriately (after determining what that means ;) ) the support that CiviCRM receives from a variety of payment processors.
This might mean putting something into the info.xml or README.md of each extension, as well as adding something somewhere on c.o.
See https://github.com/agileware/cf-stripe/issues/1
@mattwire any sense of Stripe's compensation arrangements being different in Australia compared to other countries? I like the policy thrust of @justinfreeman 's comment but don't believe it is industry practice.joshjosh@civicrm.orgjoshjosh@civicrm.orghttps://lab.civicrm.org/dev/core/-/issues/2410Image custom field type2023-01-30T20:19:36ZMichael McAndrewImage custom field typeOverview
----------------------------------------
We want to add a custom field type of image that can be used to store images as part of a CiviCRM entity.
In terms of how this might be different to the file field type, I think the main...Overview
----------------------------------------
We want to add a custom field type of image that can be used to store images as part of a CiviCRM entity.
In terms of how this might be different to the file field type, I think the main consideration is how these fields would be displayed (resizing, thumbnails, etc.)
Example use-case
----------------------------------------
1. Store (one or more) images related to a contact as part of the contact record.
2. *** feel free to add more***
Current behaviour
----------------------------------------
At the moment, there is a single core field for a contact image (e.g. a headshot of an indiviual or a company logo). No other images can be added. Images can be added as files but are not displayed as one would expect an image to be displayed.
Proposed behaviour
----------------------------------------
People should be able to define image fields and upload images to them. The original should be retained and resized images should also be created (e.g. for thumbnails).
(Wireframes, mockups and more thinking required.)
Comments
----------------------------------------
Some relevant content (previous workarounds, etc.):
- https://drupal.stackexchange.com/questions/220599/how-to-add-image-field-in-civicrm
- https://civicrm.stackexchange.com/questions/15900/how-to-add-image-field-in-civicrmhttps://lab.civicrm.org/dev/core/-/issues/2409User with the permission 'access my cases and activities' cannot access there...2021-02-23T09:22:26ZkainukUser with the permission 'access my cases and activities' cannot access there case if they are closed.Overview
----------------------------------------
CiviCRM defines the permission `access my cases and activities`. It's for the user that do not need access to all the cases in the system, but only the cases of clients they have a relati...Overview
----------------------------------------
CiviCRM defines the permission `access my cases and activities`. It's for the user that do not need access to all the cases in the system, but only the cases of clients they have a relationship with. However, the moment a case is closed it is not accessible any more.
Reproduction steps
----------------------------------------
1. Login as a user with only `access my cases and activities` and no `access all cases and activities`. Below is a script to create such a user. In this example, she is called Casey Coördinator'.
1. Create a new case (for example for 'Housing Support').
![casey](/uploads/554f2ceaf44808b4d8e8d80c8e4e271c/casey.png)
1. Casy is allowed to see and change this case because she has the relationship `Homeless Services Coordinator is` (1).
1. Close the case at (2). This is done by changing the status from 'Ongoing' to 'Resolved'
Current behaviour
----------------------------------------
Immediately after closing a message pops up:
![Selection_016](/uploads/a5cb1359f6bcde2cc8d479c3d5cccb80/Selection_016.png)
The user cannot access this case anymore.
On the case dashboard, the case is still shown in the list of closed cases. The manage option gives the same error.
Expected behaviour
----------------------------------------
The case must be still available for the user.
Environment information
----------------------------------------
This is tested on the dmaster version in combination with drupal. The following bash script can be used to create a role with the privileges to test.
```
drush role:create casehandler
drush role:add:perm casehandler 'access CiviCRM'
drush role:add:perm casehandler 'access CiviReport'
drush role:add:perm casehandler 'access Contact Dashboard'
drush role:add:perm casehandler 'access my cases and activities'
drush role:add:perm casehandler 'add cases'
drush role:add:perm casehandler 'add contacts'
drush role:add:perm casehandler 'edit all contacts'
drush role:add:perm casehandler 'view all contacts'
drush ucrt casey --password='welcome' --mail='casey@example.org'
drush user:add:role casehandler casey
```
Functional Discussion
---------------------------------------
My customer says this is new behaviour, seen the first time after the upgrade. I can understand that there is a need to revoke access to a case. However, a more logical way to do this would be to remove or re-assign the relationship.
Some technical details
----------------------------------------
The lack of permission `access all cases and activities` on line 53 in `CRM_Case_Page_Tab` triggers a search for user_cases. And in this search `CRM_Case_BAO_Case::getCases` the closed statuses are excluded on line 527.https://lab.civicrm.org/dev/drupal/-/issues/157Drupal 9 installation errors2021-03-11T21:48:29ZsadashivDrupal 9 installation errorsAs per the documentation at https://docs.civicrm.org/installation/en/latest/drupal8/ we need a clean drupal 8 or 9 and we can do a composer install.
Steps to replicate:
1) Download composer.json and composer.lock from https://github.com...As per the documentation at https://docs.civicrm.org/installation/en/latest/drupal8/ we need a clean drupal 8 or 9 and we can do a composer install.
Steps to replicate:
1) Download composer.json and composer.lock from https://github.com/drupal/recommended-project/tree/9.1.x this gives latest drupal 9 dev and do a composer install or download and install drupal. Now we have a clean drupal 9.1 installed
2) cd /var/www/d8.example.org
3) composer config extra.enable-patching true
4) composer require civicrm/civicrm-asset-plugin:'~1.1'
5) composer require civicrm/civicrm-{core,packages,drupal-8}
Steps 2 to 5 are from the documentation.
Expected result: Civicrm packages are installed
Observed result:
````
Using version ^5.34 for civicrm/civicrm-core
Using version ^5.34 for civicrm/civicrm-packages
Using version ^5.34 for civicrm/civicrm-drupal-8
./composer.json has been updated
Running composer update civicrm/civicrm-core civicrm/civicrm-packages civicrm/civicrm-drupal-8
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires civicrm/civicrm-core ^5.34 -> satisfiable by civicrm/civicrm-core[5.34.0].
- civicrm/civicrm-core 5.34.0 requires pear/validate_finance_creditcard dev-master -> found pear/validate_finance_creditcard[dev-master] but it does not match your minimum-stability.
Problem 2
- civicrm/civicrm-core 5.34.0 requires pear/validate_finance_creditcard dev-master -> found pear/validate_finance_creditcard[dev-master] but it does not match your minimum-stability.
- civicrm/civicrm-drupal-8 5.34.0 requires civicrm/civicrm-core >=5.21.0 -> satisfiable by civicrm/civicrm-core[5.34.0].
- Root composer.json requires civicrm/civicrm-drupal-8 ^5.34 -> satisfiable by civicrm/civicrm-drupal-8[5.34.0].
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
`````
I think setting proper version for validate_finance_creditcard instead of dev-master in the composer.json file of civicrm should fix it, but as it is composer install I can't test this.
Environment details:
php: 7.4 (I know this is not completely supported but installation should go through)
mysql: 5.7
Operating system: Tried on Ubuntu and Centos.
composer version: 2.0.8
Am I missing something in the installation?
Thanks,
Sadashiv.https://lab.civicrm.org/dev/core/-/issues/2406Add link from afform edit screen to the form url2021-02-23T09:18:58ZeileenAdd link from afform edit screen to the form urlMinor thing - but helpful as it's confusing for people to have to copy & past the url fragmentMinor thing - but helpful as it's confusing for people to have to copy & past the url fragment5.36.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2405More operators for search kit2023-07-13T05:03:25ZeileenMore operators for search kitCurrently searchkit supports '=' or 'LIKE '%x' but in order to start to replace some of the dashlets created by CiviReport I think more flexibility is needed - for example if I want an afform to help me find donors with a total giving **...Currently searchkit supports '=' or 'LIKE '%x' but in order to start to replace some of the dashlets created by CiviReport I think more flexibility is needed - for example if I want an afform to help me find donors with a total giving **Greater Than** x. Another example is NOT IN - as currently on the activities dashlet
@colemanw has already added date search ranges ('this.week') etc to give some flexibility.https://lab.civicrm.org/dev/core/-/issues/2404Afform permissions - open access didn't seem to work (search kit)2021-02-24T09:17:31ZeileenAfform permissions - open access didn't seem to work (search kit)I tried configuring an afform search with open access but going to the url treats it as NO access
![image](/uploads/f61b78579e271bb0b088fd10c7dae203/image.png)
![image](/uploads/fc6a010613dee1e0e5da6854bc4f29d3/image.png)
I am logged...I tried configuring an afform search with open access but going to the url treats it as NO access
![image](/uploads/f61b78579e271bb0b088fd10c7dae203/image.png)
![image](/uploads/fc6a010613dee1e0e5da6854bc4f29d3/image.png)
I am logged in as an admin user & see this when I have 'administer civicrm required
![image](/uploads/8058409fff66b60e352ad98200e0d9a7/image.png)
@totten @colemanw5.36.0https://lab.civicrm.org/dev/core/-/issues/2403Link styling with default greenwich theme is not linklike on search kit screen2021-05-18T22:07:08ZeileenLink styling with default greenwich theme is not linklike on search kit screenOn testing search kit urls I initially thought they weren't working because I was expecting them to look like links - but they didn't. I suspect we could improve that in greenwich css
@colemanw ?
demo@example.com is a link in this scre...On testing search kit urls I initially thought they weren't working because I was expecting them to look like links - but they didn't. I suspect we could improve that in greenwich css
@colemanw ?
demo@example.com is a link in this screenshot
![image](/uploads/01c71434039d308202615d308995f011/image.png)https://lab.civicrm.org/dev/core/-/issues/2402Proposed Updated Phone Types2023-07-20T05:03:21ZcolemanwProposed Updated Phone TypesMotivation/Background
---------
The phone_type option list is somewhat dated and presents options that don't always make sense to modern users. The first two options are "Phone" and "Mobile". Twenty years ago there might have been a mor...Motivation/Background
---------
The phone_type option list is somewhat dated and presents options that don't always make sense to modern users. The first two options are "Phone" and "Mobile". Twenty years ago there might have been a more obvious distinction between the two, but today they are basically synonyms. We should re-label them so that it's clear that the first option means "Landline phone" and the second option means "Phone that can receive SMS". And while we're at it, let's also change their weights since mobile phones are now more common than landlines and should be presented as the first option.
Current Options
--------------
| weight | name | label (EN) |
| ------ | ---------- | ---------- |
| 1 | Phone | Phone |
| 2 | Mobile | Mobile |
| 3 | Fax | Fax |
| 4 | Pager | Pager |
| 5 | Voicemail | Voicemail |
Proposed Options (New Installs)
----------------
_This reverses the order and relabels the first two options, while deleting the last two, as "Pager" and "Voicemail" numbers are rarely used these days (it's an option list so specialized organizations can always add them in)._
| weight | name | label (EN) |
| ------ | ---------- | ----------- |
| 1 | Mobile | Voice & SMS |
| 2 | Phone | Voice Only |
| 3 | Fax | Fax |
Proposed Upgrade
-------------------
DB upgrade would update labels and weights of the first two options. Functionality will not be impacted as the machine names remain the same. The "Pager" and "Voicemail" options will be deleted _only if they are not in use._https://lab.civicrm.org/dev/core/-/issues/2401Unable to include seconds in date format for display2023-06-28T05:03:20Zfreeform.stephUnable to include seconds in date format for displayWe would like to include seconds when viewing date fields in reports, the option "%S" does not work (displays "%S" instead of the seconds value).
Reproduce: on Localization > Date format, change the value of "Date Format: Complete Date ...We would like to include seconds when viewing date fields in reports, the option "%S" does not work (displays "%S" instead of the seconds value).
Reproduce: on Localization > Date format, change the value of "Date Format: Complete Date and Time" from the default "%B %E%f, %Y %l:%M %P" to "%B %E%f, %Y %l:%M:%S %P" and load a report displaying a date column, you'll see something like "January 4th, 2021 3:28:%S PM".
First reported on stack exchange: https://civicrm.stackexchange.com/questions/38869/date-and-hour-format-with-secondshttps://lab.civicrm.org/dev/core/-/issues/2400APIv4 explorer, search kit - entity reference fields tricky if you know the id2021-02-24T21:53:21ZeileenAPIv4 explorer, search kit - entity reference fields tricky if you know the idOne of my annoyances with apiv4 explorer is now in search kit too. Quite often I know the id of the contact but not other details - in order to prevent leaking information we only pass around the id. While it makes sense in most use case...One of my annoyances with apiv4 explorer is now in search kit too. Quite often I know the id of the contact but not other details - in order to prevent leaking information we only pass around the id. While it makes sense in most use cases to use the entity reference look up that lookup is hard to use if you just know the id as you still need to enter 'something' to make it search.
![image](/uploads/8896341778d5e77cde2ea765964f7fe9/image.png)
With search kit this could impact when making the initial search and exposing in the dashlet (I would expect we will be quickly asked for some 'search by id afflets' as well as wanting entity references in other cases. I note the afflet currently renders contact id as an integer field - which is probably better than an entity reference for our current use cases but I think that we will want to be able to have more control (ie choose between an integer or entity reference field). I can see a case for making entity reference field better support entering the contact id - but I think we need to be mindful that when people are working with contact ids they are often doing data-entry type stuff that requires them to be able to enter the id & click go without many extra steps
![image](/uploads/d2f1e0c19237aea3b2622da2c7ceea68/image.png)5.36.0https://lab.civicrm.org/dev/core/-/issues/2399Add new property to Phone entity to mark a number as a mobile phone or the pr...2023-06-28T05:03:19ZhomotechsualAdd new property to Phone entity to mark a number as a mobile phone or the primary SMS number.Overview
----------------------------------------
_Currently we don't have a straightforward way to say "this is a mobile phone/cell phone number" we have the `phone_type` property but being an option group it's inherently unreliable and...Overview
----------------------------------------
_Currently we don't have a straightforward way to say "this is a mobile phone/cell phone number" we have the `phone_type` property but being an option group it's inherently unreliable and subject to change. If we were looking for a way to say "this phone number is a mobile phone - use it for sending SMS" we're kinda out of luck!_
Current behaviour
----------------------------------------
_We can try to infer whether a phone number is for a cell phone by checking for phone_type but it's unreliable and we can't reliably rely on a single ID designating a mobile phone number (or that any of them do!)_
Proposed behaviour
----------------------------------------
_An explicit property that denotes that a number is a cellphone/mobile number or alternatively a property that denotes that that number is the preferred for SMS e.g `is_smsprimary`._https://lab.civicrm.org/dev/financial/-/issues/166Account IIF Export Amount Format improper2021-03-01T02:27:36ZLoganBearAccount IIF Export Amount Format improperBatches created before 5.34 export simple value amounts:
```
12.00
-12.00
```
Batches after the upgrade to 5.34 adds a dollar sign to the amount:
```
$12.00
-$12.00
```
I can't get these files imported without loading them into Excel...Batches created before 5.34 export simple value amounts:
```
12.00
-12.00
```
Batches after the upgrade to 5.34 adds a dollar sign to the amount:
```
$12.00
-$12.00
```
I can't get these files imported without loading them into Excel and changing the formatting.5.35.0https://lab.civicrm.org/dev/core/-/issues/2397Add 'readonly' attribute to fields in schema2021-07-19T17:19:26ZcolemanwAdd 'readonly' attribute to fields in schemaThis is needed by Afform and SearchKit to know whether a field is appropriate to show to the user.
The goal here is to add 'readonly' to all fields that should *not* be presented as editable on user-facing forms.
Examples of fields tha...This is needed by Afform and SearchKit to know whether a field is appropriate to show to the user.
The goal here is to add 'readonly' to all fields that should *not* be presented as editable on user-facing forms.
Examples of fields that should be considered "readonly"
----
- [x] Contact type (theoretically could be changed, but only under special circumstances and there's an extension for that)
- [x] ID fields
- [x] Contact Hash
- [x] Custom fields marked `"is_view"`
- [ ] FK fields that are not meant to change, e.g. Email.contact_id or Participant.contact_id. (in rare circumstances this field gets updated e.g. during deduping, but it's still not something to present on a typical user-facing form, so I'd consider them `'readonly'`).
- [ ] Any auto-increment fields or autopopulated fields e.g. `'creation_date'`.
- [ ] Any other fields that are typically written to programatically and not shown on forms.seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2396Translation support for Afforms & Managed Search Displays2024-02-07T17:45:35ZseamusleeTranslation support for Afforms & Managed Search DisplaysAs per https://lab.civicrm.org/extensions/afform/-/issues/22 and https://lab.civicrm.org/extensions/afform/-/issues/8 looks like there needs to be some improvements to support multilingual sites in AfformAs per https://lab.civicrm.org/extensions/afform/-/issues/22 and https://lab.civicrm.org/extensions/afform/-/issues/8 looks like there needs to be some improvements to support multilingual sites in Afformhttps://lab.civicrm.org/dev/core/-/issues/2395Cannot use Afform to create a linked activity2023-07-19T05:03:21ZseamusleeCannot use Afform to create a linked activityAs per https://lab.civicrm.org/extensions/afform/-/issues/21 you cannot use Afform to create an activity when the form is submitted because the source_contact_id field is required by APIv4 when doing activity.create / activity.save and t...As per https://lab.civicrm.org/extensions/afform/-/issues/21 you cannot use Afform to create an activity when the form is submitted because the source_contact_id field is required by APIv4 when doing activity.create / activity.save and there is no way to pass through a param in the Afform form.seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2393Settings metadata help_text parameter doesn't work and causes errors if you s...2023-06-27T05:03:25ZDaveDSettings metadata help_text parameter doesn't work and causes errors if you specify it but there's no .hlp fileNot sure if I'm going to follow this thru but am recording some findings. There's at least 3 things to deal with:
1. There's no facility to specify the title of the help box. This is the easiest since it can compute it from the setting ...Not sure if I'm going to follow this thru but am recording some findings. There's at least 3 things to deal with:
1. There's no facility to specify the title of the help box. This is the easiest since it can compute it from the setting label.
2. CRM.help _does_ support passing a single string as the help content, but you get into quote-hell pretty quickly.
3. The `{help}` plugin which is what generates the `<a>` link that calls CRM.help doesn't have a way to accept a string as the help content, and `{help}` is what SettingForm.tpl uses. \
3.b Related note: the `{help}` plugin behaves differently whether you pass it a title parameter or not. If there's no parameter it expects to find it inside an associated .hlp file.
Earlier related issue: https://lab.civicrm.org/dev/core/-/issues/1920https://lab.civicrm.org/dev/core/-/issues/2392Deprecated force url for contribution dashboard links2021-02-17T23:06:15ZDaveDDeprecated force url for contribution dashboard links1. Contribution dashboard
2. Click the table layout "button" near the top.
3. Click on one of the "view details" links.
4. `User deprecated function: Deprecated function CRM_Contribute_Form_Search::setDeprecatedDefaults, use pass receive...1. Contribution dashboard
2. Click the table layout "button" near the top.
3. Click on one of the "view details" links.
4. `User deprecated function: Deprecated function CRM_Contribute_Form_Search::setDeprecatedDefaults, use pass receive_date_high not end`5.36.0