Development issueshttps://lab.civicrm.org/groups/dev/-/issues2020-09-29T20:07:08Zhttps://lab.civicrm.org/dev/core/-/issues/2063Eliminate "No extensions available for this version of CiviCRM"2020-09-29T20:07:08ZJonGoldEliminate "No extensions available for this version of CiviCRM"This error is a possible outcome of the "checkExtensions" system check. I propose we eliminate it:
* There's never going to be another version of CiviCRM that has no extensions available, so the message is wrong.
* The error pretty much...This error is a possible outcome of the "checkExtensions" system check. I propose we eliminate it:
* There's never going to be another version of CiviCRM that has no extensions available, so the message is wrong.
* The error pretty much exclusively happens when there's an error on the c.o side, like an outage.
* There are no actionable steps for someone receiving this message.
* My personal gripe: When c.o goes down, I get this message from a gazillion sites at once.
While I'm aware it's theoretically possible that someone could define an alternate extension directory source from c.o, to my knowledge that a) has never been done, b) if you do that, you shouldn't need a warning in the UI to tell you no extensions are available.
Happy to take this on if folks approve.5.31.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2062activity_contact.record_type_id should be required in the database?2023-05-08T05:03:25ZDaveDactivity_contact.record_type_id should be required in the database?Is there a use case where null in this field makes sense?
https://github.com/civicrm/civicrm-core/blob/6777cd9378333d3c4e38e7ce5ae7a396f6fb0a6e/xml/schema/Activity/ActivityContact.xml#L54Is there a use case where null in this field makes sense?
https://github.com/civicrm/civicrm-core/blob/6777cd9378333d3c4e38e7ce5ae7a396f6fb0a6e/xml/schema/Activity/ActivityContact.xml#L54https://lab.civicrm.org/dev/core/-/issues/2061PCP action links support for hook_civicrm_links2020-09-29T02:47:01ZbgmPCP action links support for hook_civicrm_linksAs a user who creates a Personal Campaign Page (PCP), CiviCRM displays a list of actions to manage the PCP page:
![pcp-links](/uploads/f28d64cd689c1d0d2705cdccc4c85984/pcp-links.jpg)
As site admins, we may want to customize the list of...As a user who creates a Personal Campaign Page (PCP), CiviCRM displays a list of actions to manage the PCP page:
![pcp-links](/uploads/f28d64cd689c1d0d2705cdccc4c85984/pcp-links.jpg)
As site admins, we may want to customize the list of links that are displayed. CiviCRM already has a [hook_civicrm_links](https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_links/) hook, but it is not being called from here.
(I will open a PR)5.31.0https://lab.civicrm.org/dev/core/-/issues/2060Relationship needs a pseudoconstant for relationship type2020-09-23T23:41:11ZeileenRelationship needs a pseudoconstant for relationship type@colemanw - I suggest we could have a function that concats some 2 way info?
![Screen_Shot_2020-09-24_at_7.54.18_AM](/uploads/b41459f06fbd78ab6706a89096c31e87/Screen_Shot_2020-09-24_at_7.54.18_AM.png)@colemanw - I suggest we could have a function that concats some 2 way info?
![Screen_Shot_2020-09-24_at_7.54.18_AM](/uploads/b41459f06fbd78ab6706a89096c31e87/Screen_Shot_2020-09-24_at_7.54.18_AM.png)https://lab.civicrm.org/dev/translation/-/issues/53Frequency units frequently fail to be translated properly2023-11-23T07:20:57ZStéphane Lussierstephane@symbiotic.coopFrequency units frequently fail to be translated properlyOn numerous occasions, the internal value of frequency units (eg: year, month) are sent for display to a template without being translated first.
One such issue may be found in [CRM/Contribute/Form/Contribution/Main.php](https://lab.ci...On numerous occasions, the internal value of frequency units (eg: year, month) are sent for display to a template without being translated first.
One such issue may be found in [CRM/Contribute/Form/Contribution/Main.php](https://lab.civicrm.org/dev/core/-/blob/master/CRM/Contribute/Form/Contribution/Main.php#L550). In this case, a simple fix would usually suffice:
```patch
--- a/civicrm/CRM/Contribute/Form/Contribution/Main.php
+++ b/civicrm/CRM/Contribute/Form/Contribution/Main.php
@@ -548,7 +548,7 @@ class CRM_Contribute_Form_Contribution_Main extends CRM_Contribute_Form_Contribu
if (!empty($form->_values['is_recur_interval']) || $className == 'CRM_Contribute_Form_Contribution') {
$unit .= "(s)";
}
- $form->assign('frequency_unit', $unit);
+ $form->assign('frequency_unit', ts($unit));
}
else {
$form->assign('one_frequency_unit', FALSE);
```
However, this patch in incomplete. There are multiple cases where a similar fix would need to be applied.
It's also not uncommon to find singular/plural tests in existing templates. The following example comes from [templates/CRM/Contribute/Form/Contribution/ThankYou.tpl](https://lab.civicrm.org/dev/core/-/blob/master/templates/CRM/Contribute/Form/Contribution/ThankYou.tpl#L123):
```smarty
{if $frequency_interval > 1}
<strong>{ts 1=$frequency_interval 2=$frequency_unit}This membership will be renewed automatically every %1 %2(s).{/ts}</strong>
{else}
<strong>{ts 1=$frequency_unit}This membership will be renewed automatically every %1.{/ts}</strong>
{/if}
```
This solution looks a bit strange to me... It assumes that adding an `(s)` to an internal keyword will make it plural. That may work in most situations, but it would prevent the already translated keyword to be altered upon the phrase translation.
Shouldn't the keyword be fully translated _and_ pluralized (if necessary) _before_ being sent to the translation string?
Could the `ts` function take care of translating and pluralizing substrings?
I don't mean to make a huge issue out of a small one, but I wonder: Is there a pattern that we can agree on for these sorts of situations?https://lab.civicrm.org/dev/core/-/issues/2059PayPal Standard redirect fails on Drupal 7 using Chrome2023-10-18T05:03:23ZmikantchapPayPal Standard redirect fails on Drupal 7 using ChromeThis is the Drupal version of https://lab.civicrm.org/dev/core/-/issues/1997 which is for WordPress
Reproduction steps
----------------------------------------
* Make a paid event using PayPal Standard
* Click continue
* Go To PayPal
* ...This is the Drupal version of https://lab.civicrm.org/dev/core/-/issues/1997 which is for WordPress
Reproduction steps
----------------------------------------
* Make a paid event using PayPal Standard
* Click continue
* Go To PayPal
* Make payment
* Return to merchant (either via auto return or clicking the return to merchant button)
Current behaviour
----------------------------------------
The return URL is
https://domain name/civicrm/event/register?_qf_ThankYou_display=1&qfKey=4d60370af572a747511fa134f1a1cf7abea39b279fd75ce95dae2f762be52dba_8277
You get an error page:
```
CRM_Core_Exception: We can't load the requested web page. This page requires cookies to be enabled in your browser settings. Please check this setting and enable cookies (if they are not enabled). Then try again. If this error persists, contact the site administrator for assistance.<br /><br />Site Administrators: This error may indicate that users are accessing this page using a domain or URL other than the configured Base URL. EXAMPLE: Base URL is http://example.org, but some users are accessing the page via http://www.example.org or a domain alias like http://myotherexample.org.<br /><br />Error type: Could not find a valid session key. in /home/<username>/public_html/sites/all/modules/civicrm/CRM/Core/Controller.php on line 849
Exception trace
# Function Location
0 CRM_Core_Controller->invalidKeyCommon() /home/<username>/public_html/sites/all/modules/civicrm/CRM/Core/Controller.php:849
1 CRM_Core_Controller->invalidKeyRedirect() /home/<username>/public_html/sites/all/modules/civicrm/CRM/Event/Controller/Registration.php:46
2 CRM_Event_Controller_Registration->invalidKey() /home/<username>/public_html/sites/all/modules/civicrm/CRM/Core/Controller.php:308
3 CRM_Core_Controller->key('CRM_Event_Contro…', true, false) /home/<username>/public_html/sites/all/modules/civicrm/CRM/Core/Controller.php:190
4 CRM_Core_Controller->__construct('Event Registrati…', 'null') /home/<username>/public_html/sites/all/modules/civicrm/CRM/Event/Controller/Registration.php:25
5 CRM_Event_Controller_Registration->__construct('Event Registrati…', true, 'null', null, 'false') /home/<username>/public_html/sites/all/modules/civicrm/CRM/Core/Invoke.php:307
6 CRM_Core_Invoke::runItem(Array) /home/<username>/public_html/sites/all/modules/civicrm/CRM/Core/Invoke.php:68
7 CRM_Core_Invoke::_invoke(Array) /home/<username>/public_html/sites/all/modules/civicrm/CRM/Core/Invoke.php:36
8 CRM_Core_Invoke::invoke(Array) /home/<username>/public_html/sites/all/modules/civicrm/drupal/civicrm.module:454
9 civicrm_invoke('event', 'register') /home/<username>/public_html/includes/menu.inc:527
10 menu_execute_active_handler() /home/<username>/public_html/index.php:21
11 {main}
Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
We can't load the requested web page. This page requires cookies to be enabled in your browser settings. Please check this setting and enable cookies (if they are not enabled). Then try again. If this error persists, contact the site administrator for assistance.<br /><br />Site Administrators: This error may indicate that users are accessing this page using a domain or URL other than the configured Base URL. EXAMPLE: Base URL is http://example.org, but some users are accessing the page via http://www.example.org or a domain alias like http://myotherexample.org.<br /><br />Error type: Could not find a valid session key.
```
Expected behaviour
----------------------------------------
Should return user to a working page in CiviCRM
Environment information
----------------------------------------
* Chrome Version 84.0.4147.105
* CiviCRM:5.28.3
* PHP: 7.3
Comments
----------------------------------------
Issue is OK in Edgehttps://lab.civicrm.org/dev/wordpress/-/issues/76REST delete Participant operation... get a WARNING message2023-12-06T16:39:30ZRTaglientoREST delete Participant operation... get a WARNING messageHi,
I am receiving a WANRNING message after an API-REST call via ajax.
The delete operation of a participant
.../wp-json/civicrm/v3/rest?entity=Participant&action=delete&api_key=...&key=..&json={"sequential":1,"id":711}
this is the ...Hi,
I am receiving a WANRNING message after an API-REST call via ajax.
The delete operation of a participant
.../wp-json/civicrm/v3/rest?entity=Participant&action=delete&api_key=...&key=..&json={"sequential":1,"id":711}
this is the response text:
> <br />
> <b>Warning</b>: array_reduce() expects parameter 1 to be array, int given in <b>C:\xampp\htdocs\civicenter\wp-content\plugins\civicrm\wp-rest\Controller\Rest.php</b> on line <b>147</b><br />
> {"is_error":0,"version":3,"count":1,"values":null}
it is only a WARNING and I catch only the final JSON object tail.
Regards Roberto.https://lab.civicrm.org/dev/core/-/issues/2058REST delete Participant operation... get a WARNING message2020-09-22T21:57:50ZRTaglientoREST delete Participant operation... get a WARNING messageHi,
I am receiving a WANRNING message after an API-REST call via ajax.
The delete operation of a participant
.../wp-json/civicrm/v3/rest?entity=Participant&action=delete&api_key=...&key=..&json={"sequential":1,"id":711}
this is the ...Hi,
I am receiving a WANRNING message after an API-REST call via ajax.
The delete operation of a participant
.../wp-json/civicrm/v3/rest?entity=Participant&action=delete&api_key=...&key=..&json={"sequential":1,"id":711}
this is the response text:
> <br />
> <b>Warning</b>: array_reduce() expects parameter 1 to be array, int given in <b>C:\xampp\htdocs\civicenter\wp-content\plugins\civicrm\wp-rest\Controller\Rest.php</b> on line <b>147</b><br />
> {"is_error":0,"version":3,"count":1,"values":null}
it is only a WARNING and I catch only the final JSON object tail.
Regards Roberto.https://lab.civicrm.org/dev/core/-/issues/2057Extraneous queries - activiies2023-05-09T05:03:25ZeileenExtraneous queries - activiiesPer #2033 when doing query analysis on creating 7 contacts with 7 contributions I found that around 10% of the queries were looking up activity contacts.
In other words 2 queries for each record type for each contribution. In fact these...Per #2033 when doing query analysis on creating 7 contacts with 7 contributions I found that around 10% of the queries were looking up activity contacts.
In other words 2 queries for each record type for each contribution. In fact these are new contributions so no existing records exist & that can hopefully be pre-determined
Examples
|timestamp|query|seconds|rows found|columns requested|
|----------|-------|-------|-------|-------|
| 15/09/20 2:54 | SELECT * FROM `civicrm_activity_contact` WHERE ( `civicrm_activity_contact`.`activity_id` = 112183025 ) AND ( `civicrm_activity_contact`.`contact_id` = 46011835 ) AND ( `civicrm_activity_contact`.`record_type_id` = 2 ) | 0.000549 | 0 | 0 |
| 15/09/20 2:54 | SELECT * FROM `civicrm_activity_contact` WHERE ( `civicrm_activity_contact`.`activity_id` = 112183025 ) AND ( `civicrm_activity_contact`.`record_type_id` = 1 ) | 0.000606 | 0 | 0 |
| 15/09/20 2:54 | SELECT * FROM `civicrm_activity_contact` WHERE ( `civicrm_activity_contact`.`activity_id` = 112183025 ) AND ( `civicrm_activity_contact`.`record_type_id` = 2 ) | 0.000725 | 0 | 0 |
| 15/09/20 2:54 | SELECT * FROM `civicrm_activity_contact` WHERE ( `civicrm_activity_contact`.`activity_id` = 112183025 ) AND ( `civicrm_activity_contact`.`record_type_id` = 2 ) | 0.000605 | 1 | 1 |
| 15/09/20 2:54 | SELECT * FROM `civicrm_activity_contact` WHERE ( `civicrm_activity_contact`.`activity_id` = 112183025 ) AND ( `civicrm_activity_contact`.`record_type_id` = 3 ) | 0.000636 | 0 | 0 |https://lab.civicrm.org/dev/core/-/issues/2056Performance - do not retrieve soft credits & pcps when not required2020-10-08T00:17:06ZeileenPerformance - do not retrieve soft credits & pcps when not requiredPer https://lab.civicrm.org/dev/core/-/issues/2033 3.5% (14 out of 393) of the queries I recorded when importing 7 contacts with 7 contributions were for retrieving pcp & soft credit information. However, this retrieved information is di...Per https://lab.civicrm.org/dev/core/-/issues/2033 3.5% (14 out of 393) of the queries I recorded when importing 7 contacts with 7 contributions were for retrieving pcp & soft credit information. However, this retrieved information is discarded unless the params hold the key 'pcp' or 'soft_credit' so we can simply bypass these queries almost all the time.
examples
|timestamp|query|seconds|rows found|columns requested|
|----------|-------|-------|-------|-------|
| 15/09/20 2:54 | SELECT id FROM civicrm_contribution_soft WHERE contribution_id = 49769031 AND pcp_id IS NOT NULL | 0.000624 | 0 | 0 |
| 15/09/20 2:54 | SELECT id FROM civicrm_contribution_soft WHERE contribution_id = 49769031 AND pcp_id IS NULL | 0.000616 | 0 | 0 |5.31.0https://lab.civicrm.org/dev/translation/-/issues/52POT Scan: Update for sequentialcreditnotes, eventcart, flexmailer, etc2023-11-09T18:52:41ZtottenPOT Scan: Update for sequentialcreditnotes, eventcart, flexmailer, etcOver the past half-year, there have been a few new folders within the `civicrm-core` file-hierarchy, e.g.
```
setup
ext/sequentialcreditnotes
ext/flexmailer
ext/eventcart
ext/ewaysingle
ext/financialacls
ext/greenwich
ext/afform
ext/sea...Over the past half-year, there have been a few new folders within the `civicrm-core` file-hierarchy, e.g.
```
setup
ext/sequentialcreditnotes
ext/flexmailer
ext/eventcart
ext/ewaysingle
ext/financialacls
ext/greenwich
ext/afform
ext/search
```
The POT scanner should check these folders. Eventually, we're going to notice missing strings. There are mitigating factors - e.g. the corpus of strings isn't huge, and a lot of the strings existed before (either in different core folders or in a standalone extension), so there may be a bit of lag-time between the file-reorg and the appearance of symptoms.
There are currently two distinct localization flows -- iirc:
* The core flow - which splits strings into multiple POT files (`contribute.pot`, `event.pot`, etc), sends those to transifex, gets the PO's back out, and recombines into one MO (`civicrm.mo`). To capture the updated folders in this flow, we'd need to update `create-pot-files.sh`.
* The ext flow - which scans multiple repos, creating one POT per repo, sends those to transifex, gets the PO's back out, and publishes multiple MOs. To capture the updated folders in this flow, we'd need to update `civiextensions-update-transifex.php` and/or `create-pot-files-extensions.sh` and/or the scheduled-job.https://lab.civicrm.org/dev/core/-/issues/2055Log error message instead of throwing exception while sending mailing2023-05-06T05:03:22ZyashodhaLog error message instead of throwing exception while sending mailingFor some reason if the mailing is stuck, we should log error message instead of throwing exception.
I recently encountered this
This is caused by because the details for contact id [x] are not returned for tokens for some reason
CiviMa...For some reason if the mailing is stuck, we should log error message instead of throwing exception.
I recently encountered this
This is caused by because the details for contact id [x] are not returned for tokens for some reason
CiviMail will not send an empty mail body, Skipping: email@email.com
All the required criteria are satisfied. It was strangely because of the limit of count passed to apiQuery which was 1 less than the contacts in the the query resulting in this unfortunate contact not getting any values and then causing the mailing job to fail. We should not have thrown the exception here.yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/2054Default value (on page load) for date value in Custom Field w/ multi-data on ...2023-05-12T05:03:31ZKarinGDefault value (on page load) for date value in Custom Field w/ multi-data on Contribution Page does not persist - and is reset to first date recorded insteadIssue Description:
1. Contribution page has a Profile contains Custom data -> Tab multi-data fields (Year, Education Hours and Hours Worked) so that every year Members can record this data ->
![image](/uploads/4bd15553c2e7000d0ad4e1731...Issue Description:
1. Contribution page has a Profile contains Custom data -> Tab multi-data fields (Year, Education Hours and Hours Worked) so that every year Members can record this data ->
![image](/uploads/4bd15553c2e7000d0ad4e1731764ea37/image.png)
2. What this does is place the current year onto the form: 0 years before and 0 years after and a default value -> all = 2020
![image](/uploads/0302ab545231e79f692ca7b8dae4695d/image.png)
3. This has been working since 2014. Not sure when it regressed as this is an annual registration process (Sep - Dec every year).
4. Issue: on Contribution page: on load -> all is well -> 2020
![image](/uploads/e55c0dbeeab968d3607c7fad72c577d1/image.png)
On both Confirmation and Thank you page -> 2014 (as opposed to 2020) and note the 2014 is also recorded in the CiviCRM database:
![image](/uploads/a1efa7a62927d961ba0af11d4c9921d0/image.png)
5. Here is what does work -> if I configure the Custom Field to allow -1 and +1 years - so 2019, 2020 and 2021 -> and if (on the contribution page) -> I first toggle the year to 2021 -> and then toggle it back to 2020. Then the 2020 value is persisting across Confirmation and Thank you pages!
6. So the default on load value for such a date field is no longer persisting.https://lab.civicrm.org/dev/core/-/issues/2053Can't send SMS to mailing group whose parent isn't a mailing group2023-05-17T05:03:26ZJonGoldCan't send SMS to mailing group whose parent isn't a mailing groupThis is a regression from [PR #18154](https://github.com/civicrm/civicrm-core/pull/18154), so tagging @noah - this bug is small, but is IMO a bigger bug than the one the PR is intended to solve.
To replicate:
* Create a group (Group A) ...This is a regression from [PR #18154](https://github.com/civicrm/civicrm-core/pull/18154), so tagging @noah - this bug is small, but is IMO a bigger bug than the one the PR is intended to solve.
To replicate:
* Create a group (Group A) that's not a mailing group.
* Create a second group (Group B) that IS a mailing group. Make it a child group of Group A.
* Send a new SMS. Attempt to send to Group B.
Expected Result:
Group B should be available to choose.
Actual Result:
Group B is not available as an option.
Digging into this - the bug is actually in `CRM_Core_PseudoConstant::nestedGroup` when called with a `$groupType` argument - which isn't done anywhere else in the (modern) code. Scheduled Reminders tries, but gets the argument order wrong :face_palm:.
I'm unsure how to proceed.
I thought, "let's display the parents of mailing groups also" - but this is a) inexact, b) could cause permissions issues.
The more I think about it, the more I think we should use the widget used in CiviMail to select groups - and deprecate the use of the `$groupType` argument here, since it's unused and broken. The CiviMail widget has had a lot of eyes on it, and was designed in part to deal with the same issues Noah's patch does.https://lab.civicrm.org/dev/core/-/issues/2052Some datepicker fields only allow choosing dates far in the future2020-09-20T21:21:36ZJonGoldSome datepicker fields only allow choosing dates far in the futureSteps to replicate:
* Send a mass SMS. If you're using a buildkit build, you'll need to install an SMS extension and define an SMS provider.
* On the "Schedule" screen, try to pick a schedule date.
Expected Behavior:
Years shown are 20...Steps to replicate:
* Send a mass SMS. If you're using a buildkit build, you'll need to install an SMS extension and define an SMS provider.
* On the "Schedule" screen, try to pick a schedule date.
Expected Behavior:
Years shown are 2020 and above.
Actual behavior:
Dates are several thousand years in the future.
I used `git bisect` to track it to [this PR](https://github.com/civicrm/civicrm-core/pull/16610). Tagging @mattwire.
I can see that `CRM_SMS_Form_Schedule` sets the `minDate` to `time()`, which is a Unix timestamp - and Matt's PR runs that through `strtotime`, which munges it into a different Unix timestamp. If Matt could give insight as to whether this should get fixed at the form level or in `CRM_Core_Form` I could potentially work on a fix.5.30.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2051jQuery validation not working2023-05-23T05:03:28ZAndie HuntjQuery validation not workingjQuery validation is currently not functioning in CiviCRM. The `validate`, `cancel`, and `required` classes on form elements are not triggering jQuery validation. The form still validates accurately, but this is server-side using Quick...jQuery validation is currently not functioning in CiviCRM. The `validate`, `cancel`, and `required` classes on form elements are not triggering jQuery validation. The form still validates accurately, but this is server-side using Quickform.
I first noticed this in [PR 17675](https://github.com/civicrm/civicrm-core/pull/17675), and I attempted to make a change there. However, that PR was delayed for unrelated reasons and there has been a lot of activity involving jQuery validate in the past few months.
- [PR 16488](https://github.com/civicrm/civicrm-core/pull/16488) attempted to apply the `required` attribute to required form elements.
- [PR 17929](https://github.com/civicrm/civicrm-core/pull/17929) rolled that back because it was invalid syntax.
- [PR 17937](https://github.com/civicrm/civicrm-core/pull/17937) adds the `required` attribute to individual radio options
- [PR 18080](https://github.com/civicrm/civicrm-core/pull/18080) dev/core#1928 switches the `required` on each radio option to a class name rather than an attribute
@colemanw @mattwire @seamuslee @DaveD I'm opening a PR that's mostly that one commit detached from [PR 17675](https://github.com/civicrm/civicrm-core/pull/17675).
There are two problems that remain even with the PR:
1. A required element inside a collapsed accordion won't be easily noticed. Server-side validation forces the accordion open, but the jQuery validation does not. However, I see no console errors from the result.
2. The behavior seems to vary from form to form. The New Contribution form is quite different from New Activity. The latter seems to never use jQuery Validator. Even besides looking for POST activity, you can see the different ways the validation appears:
With jQuery validator:
![image](/uploads/baac45affed515d1e7d2bcf67985da3a/image.png)
Server-side validation:
![image](/uploads/22e682d1fe77bf9344bae34a42841321/image.png)https://lab.civicrm.org/dev/financial/-/issues/150civicrm/payment/form url got empty currency argument in backoffice live CC form2021-07-07T08:47:08ZMonish Debcivicrm/payment/form url got empty currency argument in backoffice live CC formThis affects iATS Payments ACH/EFT payment processor which renders the payment block based on currency chosen. Here are the steps to replicate:
1. Install and enable [iATS paymentextension](https://github.com/iATSPayments/com.iatspayme...This affects iATS Payments ACH/EFT payment processor which renders the payment block based on currency chosen. Here are the steps to replicate:
1. Install and enable [iATS paymentextension](https://github.com/iATSPayments/com.iatspayments.civicrm)
2. Add and configure an iATS Payments ACH/EFT payment type payment processor.
3. Enable USD and CAD currencies
4. Go to 'Submit Credit Card Contribution' backoffice form
5. Choose payment processor created at step 2
Issue:
1. Payment block renders payment block with check template
2. Switching currency doesn't update the payment block.
For more detail discussion on MM - https://chat.civicrm.org/civicrm/pl/ixxrxhxs43r4mfyjpnf6tnwnnc
ping @KarinG @eileen @JoeMurray @seamuslee5.31.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/2050Can't search for deleted in new search2023-05-07T05:03:24ZeileenCan't search for deleted in new search@colemanw I just tried to do the following search (in the hope it's less slow than advanced search) - but is_deleted isn't searchable - I was looking for 'deleted contacts who have a contribution'
![Screen_Shot_2020-09-18_at_6.22.26_PM]...@colemanw I just tried to do the following search (in the hope it's less slow than advanced search) - but is_deleted isn't searchable - I was looking for 'deleted contacts who have a contribution'
![Screen_Shot_2020-09-18_at_6.22.26_PM](/uploads/7265737f0e5c16f01152bf4b8b1eb30d/Screen_Shot_2020-09-18_at_6.22.26_PM.png)https://lab.civicrm.org/dev/core/-/issues/2049use default membership status rule rather than hard-coded "New"2023-05-10T05:03:26Zlcdwebuse default membership status rule rather than hard-coded "New"In CRM_Contribute_BAO_Contribution::updateMembershipBasedOnCompletionOfContribution() we update the membership status when a linked contribution is completed (the method name says it all...). The code that determines the calculated statu...In CRM_Contribute_BAO_Contribution::updateMembershipBasedOnCompletionOfContribution() we update the membership status when a linked contribution is completed (the method name says it all...). The code that determines the calculated status defaults to a hard coded value of "New". I believe it should instead default to whatever status rule has been flagged as default... since that's kind of the point of having a default flag.
https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/BAO/Contribution.php#L5190
I'd like to add a method "getDefaultStatus()" to CRM_Member_BAO_MembershipStatus to retrieve whichever status rule has been flagged as default. Interestingly, there's a class static "$_defaultMembershipStatus" that as far as I can see is never used. I'll populate that and return the value for some caching love.
Looking for concept approval.lcdweblcdwebhttps://lab.civicrm.org/dev/core/-/issues/2048Rename crmStripAlternatives function and its friend CRM_Utils_String::stripAl...2023-05-05T14:13:30ZDaveDRename crmStripAlternatives function and its friend CRM_Utils_String::stripAlternativesIt's not used much at least in core, and it's not clear from the name what it does, and there's potential for it to be mistaken as a security function.
I'd suggest something like getFirstEmailMultipart or stripAlternativeEmailMultiparts.It's not used much at least in core, and it's not clear from the name what it does, and there's potential for it to be mistaken as a security function.
I'd suggest something like getFirstEmailMultipart or stripAlternativeEmailMultiparts.