Development issues
https://lab.civicrm.org/groups/dev/-/issues
2023-11-30T11:40:03Z
https://lab.civicrm.org/dev/core/-/issues/4815
Create Formbuilder page to view Queue status
2023-11-30T11:40:03Z
damilare
Create Formbuilder page to view Queue status
We need a page for CiviCRM administrators with Queue administration privilege to view the status of Civi Queues.
The page can be assigned this link: `https://{CIVI_DOMAIN}/civicrm/admin/queue`
We need a page for CiviCRM administrators with Queue administration privilege to view the status of Civi Queues.
The page can be assigned this link: `https://{CIVI_DOMAIN}/civicrm/admin/queue`
5.69.0
https://lab.civicrm.org/dev/core/-/issues/4814
5.69 change? regression? improvement - contribution & membership amounts are ...
2024-03-15T01:11:33Z
eileen
5.69 change? regression? improvement - contribution & membership amounts are separate line items
I've realised that when purchasing a quick config membership with an additional contribution as per
![image](/uploads/be6d34b67ddfdac42681f1895ab40bc4/image.png)
In 5.60 only one line item was created - in this case the total is $100 me...
I've realised that when purchasing a quick config membership with an additional contribution as per
![image](/uploads/be6d34b67ddfdac42681f1895ab40bc4/image.png)
In 5.60 only one line item was created - in this case the total is $100 membership + $15 tax + $10 contribution + $1.50 tax and only the tax_amount on the contribution record is wrong
![image](/uploads/c8a6a51b876b8f767b24db7810a217f1/image.png)
In 5.69 rc the current behaviour is to create 2 line items
![image](/uploads/f4319273e0c10e09cff4ed6b7a7c921f/image.png)
- this feels more correct to me and I am loath to change it back unless people want to push for that.
I should note the financial type of the current line item is currently the same as that configured for the contribution page - on the same page as the configuration of the contribution amount in question. Once again this feels more logical to me but it could pick up the financial type of the membership being purchased if that was the case people wanted to argue.
Lastly I should note that there is code in the form (which could do with testing) to ensure that if both are purchased then only the membership amount is put in the recurring contribution.
5.69.0
https://lab.civicrm.org/dev/core/-/issues/4813
CRM_Report_Form_Activity: Add Employer field, and "contact"-based custom fields
2023-12-18T23:06:40Z
AllenShaw
CRM_Report_Form_Activity: Add Employer field, and "contact"-based custom fields
This improvement is requested and sponsored by Stuart at Korlon.
We aim to implement the following changes to the CiviCRM core "Activity Detail" report (CRM_Report_Form_Activity):
- add "Current Employer" as an available column (not fi...
This improvement is requested and sponsored by Stuart at Korlon.
We aim to implement the following changes to the CiviCRM core "Activity Detail" report (CRM_Report_Form_Activity):
- add "Current Employer" as an available column (not filter), to display with its Display Name, as a link to the employer contact
- auto-include "contact"-based custom fields (currently only "individual"-based custom fields get this treatment)
A PR is forthcoming. If it seems this is not a desirable improvement, please let me know in comments!
(Joinery reference: F#1317)
https://lab.civicrm.org/dev/core/-/issues/4812
Drop php 7.3 in 5.70 after the 5.69 ESR release
2023-12-13T17:32:03Z
eileen
Drop php 7.3 in 5.70 after the 5.69 ESR release
It has been a year since we dropped php 7.2 so we are staying a similar amount behind the php support schedule
https://lab.civicrm.org/dev/core/-/issues/3991
It has been a year since we dropped php 7.2 so we are staying a similar amount behind the php support schedule
https://lab.civicrm.org/dev/core/-/issues/3991
https://lab.civicrm.org/dev/core/-/issues/4811
Angularjs.bootstrap behaves differently when opening in a popup on older CMSes
2023-12-04T04:39:25Z
seamuslee
Angularjs.bootstrap behaves differently when opening in a popup on older CMSes
Overview
----------------------------------------
When trying to have a form builder form integrated on a Smarty Page. On CMSes that ship by default older jQuery versions e.g. Drupal 7. The form builder form does not render correctly in ...
Overview
----------------------------------------
When trying to have a form builder form integrated on a Smarty Page. On CMSes that ship by default older jQuery versions e.g. Drupal 7. The form builder form does not render correctly in the popup.
Reproduction steps
----------------------------------------
1. Create a basic Drupal 7 + CiviCRM site with buildkit
1. Clone the searchkit branch of the [Line Item editor Extension](https://lab.civicrm.org/extensions/lineitemedit/-/tree/searchkit?ref_type=heads)
1. Enable Line Item extension
4. Do a find contribution search and try and edit any contribution and see that the angular js table does not load correctly to list the line items. But if you open it in a new tab find it renders correctly
Environment information
----------------------------------------
* __CiviCRM:__ Master
* __CMS:__ Drupal 7
5.69.0
colemanw
colemanw
https://lab.civicrm.org/dev/core/-/issues/4810
Class name must be a valid object or a string
2023-12-06T23:12:00Z
PaulButler
Class name must be a valid object or a string
I am seeing a strange issue that "seemed" to create itself. When trying to access a member record I get this error:
Class name must be a valid object or a string
in httpdocs/administrator/components/com_civicrm/civicrm/CRM/Utils/SQL.ph...
I am seeing a strange issue that "seemed" to create itself. When trying to access a member record I get this error:
Class name must be a valid object or a string
in httpdocs/administrator/components/com_civicrm/civicrm/CRM/Utils/SQL.php (line 61)
* @param string $joinColumn * @return array */ public static function mergeSubquery($entityName, $joinColumn = 'id') {
* $baoName = CRM_Core_DAO_AllCoreTables::getBAOClassName(CRM_Core_DAO_AllCoreTables::getFullName($entityName));
* $bao = new $baoName();
* $fields = $bao::getSupportedFields();
* $mergeClauses = $subClauses = [];
* foreach ((array) $bao->addSelectWhereClause($entityName) as $fieldName => $fieldClauses) { if ($fieldClauses) { foreach ((array) $fieldClauses as $fieldClause) {
The command that is failing is $bao = new $baoName
This error seemed to manifest itself (I know it won't have!). I restored a dump of the database from a previous day and can access the member record just fine , when I restore the database it then throws this error.
What more can I do to try and trace the source of it. My gut feel is that it's a DB corruption of sorts but I am unable to identify what. I set SQL trace on in CiviCRM but that doesn't display any errors that I can see.
Suggestions please?
My site is running Joomla 4.4 , PHP 8.0.30 and CiviCRM 5.67.1
https://lab.civicrm.org/dev/core/-/issues/4809
Backend register for event via credit card has problematic pre-help text and ...
2023-12-06T23:06:43Z
DaveD
Backend register for event via credit card has problematic pre-help text and should be completely removed and replaced with only a translation-friendly indicator of live vs test
Copied from https://github.com/civicrm/civicrm-core/pull/28309
I think the [tpl line](https://github.com/civicrm/civicrm-core/blob/6c6fdea6429f39d552d0cc6bae0254d27daa4919/templates/CRM/Event/Form/Participant.tpl#L31) needs to be comple...
Copied from https://github.com/civicrm/civicrm-core/pull/28309
I think the [tpl line](https://github.com/civicrm/civicrm-core/blob/6c6fdea6429f39d552d0cc6bae0254d27daa4919/templates/CRM/Event/Form/Participant.tpl#L31) needs to be completely replaced. I would remove the first sentence since it adds no value since right above it already says the name when it's present, and when it's not present is the cause of this notice, and then the second sentence is not correct in other languages (the "live"/"test" is always in english). Elsewhere the approach for that when there's a known list of values is to just hardcode the full sentences in an `{if}` block.
I do think it's important to identify if it's live or test, but since none of the above has been raised as an issue the help text itself seems very unimportant. Maybe it should just have some kind of icon indicating live or test and that's it.
https://lab.civicrm.org/dev/core/-/issues/4808
Proposal: Phase out public profile fields and profile listings
2023-12-06T22:08:58Z
bgm
Proposal: Phase out public profile fields and profile listings
Now that SearchKit provides this functionality, we should consider deprecating "public profile fields" and profile listings. They are a recurrent source of confusion and a bad configuration can lead to a data leak (I stumble on them regu...
Now that SearchKit provides this functionality, we should consider deprecating "public profile fields" and profile listings. They are a recurrent source of confusion and a bad configuration can lead to a data leak (I stumble on them regularly, with the help of the [symbiotic extension](https://civicrm.org/extensions/symbiotic).
I think we should:
- [ ] Add a feature flag (a hidden setting?) that hides
- ~~On Profiles, the option "Standalone Form or Directory"~~ (edit: I guess this might be needed for profile/edit of users with a checksum?)
- On Profile Fields: hide the visibility options, set them by default to "User and Admin only"
- [ ] Remove the feature from the Admin documentation
- [ ] Begin changing the interface to warn that we will be removing this feature, and that they can opt-in to that change right now
- [ ] Set a date for complete removal (or if someone really insists on keeping this feature, help them create an extension for it)
https://lab.civicrm.org/dev/core/-/issues/4807
[php8] CRM_Core_Form_Tag::_entityTagValues seems to be in the wrong place
2023-12-13T17:32:03Z
DaveD
[php8] CRM_Core_Form_Tag::_entityTagValues seems to be in the wrong place
This class doesn't ever seem to get instantiated as its own form, and the property is always accessed from "outside" as `$form->_entityTagValues`. There are two actual forms that declare the property - those declarations were added a yea...
This class doesn't ever seem to get instantiated as its own form, and the property is always accessed from "outside" as `$form->_entityTagValues`. There are two actual forms that declare the property - those declarations were added a year ago. The property has existed forever.
I'm thinking maybe it should live on CRM_Core_Form instead, or at least remove it from CRM_Core_Form_Tag and add it to the classes that call CRM_Core_Form_Tag functions. A larger refactor might instead make those classes contain an instance of CRM_Core_Form_Tag and then it could be protected inside there.
Also `_tagsetInfo`
5.70.0
https://lab.civicrm.org/dev/core/-/issues/4806
Tax amount on 'other amount field' - not being added
2023-12-06T23:04:26Z
eileen
Tax amount on 'other amount field' - not being added
When you Configure a Contribution Page with tax that applies to the 'Other Amount' field it is not applied.
Note that the way the page appears I feel like the amount entered should be treated as inclusive rather than exclusive - the alt...
When you Configure a Contribution Page with tax that applies to the 'Other Amount' field it is not applied.
Note that the way the page appears I feel like the amount entered should be treated as inclusive rather than exclusive - the alternative would be to improve the messaging to make it clearer on the page but it feels weird to ask people to enter a tax-exclusive amount
Screenshots from 5.60 with odd currency formatting configured
![image](/uploads/3ca803cb8846284f720063a253df407b/image.png)
Note tax is still $15
![image](/uploads/a54e7208521af056f0f958e152a4ff1b/image.png)
In the final screen the tax is ... interesting
![image](/uploads/074207531cc4cdb00fb56db499ca6421/image.png)
**Note**
1) there is code to say that if the membership recurs then the other amount should not be included
https://lab.civicrm.org/dev/core/-/issues/4805
[PHP 8.3] static fields syntax error
2024-01-31T22:30:17Z
jofranz
franz@systopia.de
[PHP 8.3] static fields syntax error
```bash
civicrm-core (f8a214edfd8c888dec0922e2622d3e8a9ff66eb2) parallel-lint --no-progress -p php8.3 .
PHP 8.3.0 | 10 parallel jobs
Checked 4242 files in 11.2 seconds
Syntax error found in...
```bash
civicrm-core (f8a214edfd8c888dec0922e2622d3e8a9ff66eb2) parallel-lint --no-progress -p php8.3 .
PHP 8.3.0 | 10 parallel jobs
Checked 4242 files in 11.2 seconds
Syntax error found in 2 files
------------------------------------------------------------
Parse error: ./CRM/Mailing/Event/BAO/MailingEventForward.php:236
> 236 | static $fields = NULL;
Duplicate declaration of static variable $fields in ./CRM/Mailing/Event/BAO/MailingEventForward.php
------------------------------------------------------------
Parse error: ./CRM/Import/Parser.php:1131
> 1131 | static $fields = NULL;
Duplicate declaration of static variable $fields in ./CRM/Import/Parser.php
```
Slightly related: #3958
https://lab.civicrm.org/dev/core/-/issues/4804
SearchKit: New toolbar in SearchKit doesn't show for contacts entity
2024-02-05T21:57:51Z
Tobias Voigt
tobias.voigt@civiservice.de
SearchKit: New toolbar in SearchKit doesn't show for contacts entity
The new option in CiviCRM 5.67.0 to add a toolbar with custom buttons to SearchKits is awesome!
Anyway - while it seems to work for other entities (e.g. participants), it doesn't show up for SearchKits that are based on the contacts ent...
The new option in CiviCRM 5.67.0 to add a toolbar with custom buttons to SearchKits is awesome!
Anyway - while it seems to work for other entities (e.g. participants), it doesn't show up for SearchKits that are based on the contacts entity.
colemanw
colemanw
https://lab.civicrm.org/dev/core/-/issues/4803
Custom Fields on Campaign are hidden on validation
2024-03-26T07:53:12Z
a.vallllovera
Custom Fields on Campaign are hidden on validation
## Overview
When trying to submit a new Campaign with a Type that have custom fields, if the valdator return some error/fields missing, the custom fields are hidden.
## Reproduction steps
1. Create some Custom Fields for a Campaign Ty...
## Overview
When trying to submit a new Campaign with a Type that have custom fields, if the valdator return some error/fields missing, the custom fields are hidden.
## Reproduction steps
1. Create some Custom Fields for a Campaign Type. **Administer -\> Customize Data and Screens -\> Custom Fields**
2. Create new Campaign. **Campaigns-\> New Campaign**
3. Select the Campaign Type that have the custom fields but **don't input the title** (for easier validation). The custom fields appers at bottom.
4. Click **Save**
5. The custom fields are hidden because validator tells you to fill the Title field.
## Current behaviour
![Error Campaign.gif](/uploads/41a8748520c6037df7d5a7d502762670/Error_Campaign.gif)
## Expected behaviour
Custom fields should still remain after validation fails.
## Environment information
* **CiviCRM:** _Master/5.69.alpha1_
https://lab.civicrm.org/dev/core/-/issues/4802
Main contribution page - amounts entered with money formatting that is non-En...
2023-11-27T20:32:14Z
eileen
Main contribution page - amounts entered with money formatting that is non-English are truncated
If a contribution page is configured with an other_amount field then the value from that field is not passed through `cleanMoney()` & is potentially truncated
- eg. 7,90 becomes 7
I verified this in 5.60 so not a new regression
If a contribution page is configured with an other_amount field then the value from that field is not passed through `cleanMoney()` & is potentially truncated
- eg. 7,90 becomes 7
I verified this in 5.60 so not a new regression
5.69.0
https://lab.civicrm.org/dev/core/-/issues/4801
[PHP 8.2] Access to an undefined property in CRM_Event_Badge_*
2023-12-11T23:28:11Z
jofranz
franz@systopia.de
[PHP 8.2] Access to an undefined property in CRM_Event_Badge_*
If I spot them correctly these are yet not covered by a unit test:
```
------ --------------------------------------------------------------------------------------
Line Logo.php ...
If I spot them correctly these are yet not covered by a unit test:
```
------ --------------------------------------------------------------------------------------
Line Logo.php
------ --------------------------------------------------------------------------------------
17 Access to an undefined property CRM_Event_Badge_Logo::$format.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
31 Access to an undefined property CRM_Event_Badge_Logo::$lMarginLogo.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
32 Access to an undefined property CRM_Event_Badge_Logo::$tMarginName.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
40 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
41 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
43 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
51 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo::$lMarginLogo.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo::$lMarginLogo.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
54 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
54 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
56 Access to an undefined property CRM_Event_Badge_Logo::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
56 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
56 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
58 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo::$tMarginName.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
60 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line Logo5395.php
------ --------------------------------------------------------------------------------------
17 Access to an undefined property CRM_Event_Badge_Logo5395::$format.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
31 Access to an undefined property CRM_Event_Badge_Logo5395::$lMarginLogo.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
32 Access to an undefined property CRM_Event_Badge_Logo5395::$tMarginName.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
40 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
41 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
43 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
51 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo5395::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo5395::$lMarginLogo.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo5395::$lMarginLogo.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
52 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
54 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
54 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
56 Access to an undefined property CRM_Event_Badge_Logo5395::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
56 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
56 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
58 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo5395::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
59 Access to an undefined property CRM_Event_Badge_Logo5395::$tMarginName.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
60 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo5395::$border.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
61 Access to an undefined property CRM_Event_Badge_Logo5395::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line NameTent.php
------ --------------------------------------------------------------------------------------
33 Access to an undefined property CRM_Event_Badge_NameTent::$lMargin.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
34 Access to an undefined property CRM_Event_Badge_NameTent::$tMargin.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
37 Access to an undefined property CRM_Event_Badge_NameTent::$format.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
55 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
62 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
62 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
65 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
65 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
66 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
67 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
68 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
68 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
69 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
70 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
78 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
79 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
79 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
79 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
79 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
81 Access to an undefined property CRM_Event_Badge_NameTent::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line Simple.php
------ --------------------------------------------------------------------------------------
31 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
32 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
33 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
34 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
34 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
34 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
35 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
36 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
36 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
36 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
37 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
38 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
38 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
39 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
39 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
39 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
40 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
41 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
41 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
42 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
42 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
42 Access to an undefined property CRM_Event_Badge_Simple::$pdf.
π‘ Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
```
Related: #4072
https://lab.civicrm.org/dev/core/-/issues/4800
Add Card Type and Last 4 to Contribution Import
2023-12-06T22:31:00Z
levi.k
Add Card Type and Last 4 to Contribution Import
Overview
----------------------------------------
When importing a contribution there are certain fields like Date, transaction ID from the contribution that get added to the Financial_Trx it would be nice to have the Card Type ID and PA...
Overview
----------------------------------------
When importing a contribution there are certain fields like Date, transaction ID from the contribution that get added to the Financial_Trx it would be nice to have the Card Type ID and PAN Truncation fields to be available in the contribution importer
Current behavior
----------------------------------------
currently Card Type ID (Card type like Visa Amex) and PAN Truncation (Last 4 of cc number) fields aren't available during contribution import
Proposed behavior
----------------------------------------
add those fields to contribution import
https://lab.civicrm.org/dev/core/-/issues/4799
Autocomplete-Select options not saving/displaying properly
2023-11-24T14:51:53Z
brienne
Autocomplete-Select options not saving/displaying properly
Overview
----------------------------------------
Autocomplete-Select custom fields are not properly displaying when that field is viewed, but does show the selected option in edit mode.
Reproduction steps
------------------------------...
Overview
----------------------------------------
Autocomplete-Select custom fields are not properly displaying when that field is viewed, but does show the selected option in edit mode.
Reproduction steps
----------------------------------------
1. Create a custom field of type βAutocomplete-Selectβ
1. Select an option for that field on a contact/contribution/ext. and **Save**
1. Note that the response does not display when viewing the field on that record
1. Click **Edit** and note that the selected option does display
![Selection_026](/uploads/a081103560d07c0726c43779471a35b9/Selection_026.png)
![Selection_027](/uploads/11ed0759d7e3c8d5103bdbeb049a2106/Selection_027.png)
Current behaviour
----------------------------------------
Custom fields of type βAutocomplete-Selectβ are not displaying when in View mode, but do display when editing that field on a record.
The id of the OptionValue is what is getting saved for the field, instead of its value:
Getting the custom field from the example contactβs record:
```json
[
{
"Auotcomplete_save_test.Favorite_genre_of_rock_music": "1001",
"Auotcomplete_save_test.Favorite_genre_of_rock_music:name": null,
"Auotcomplete_save_test.Favorite_genre_of_rock_music:label": null
}
]
```
Getting the OptionValues for the custom field:
```json
[
{
"id": 1001,
"value": "1",
"label": "Heavy metal",
"name": "Heavy_metal"
},
{
"id": 1002,
"value": "2",
"label": "Hard rock",
"name": "Hard_rock"
},
{
"id": 1003,
"value": "3",
"label": "Punk rock",
"name": "Punk_rock"
},
]
```
Expected behaviour
----------------------------------------
The option selected for the Autocomplete-Select custom field should be displayed both in View and Edit modes.
Environment information
----------------------------------------
* __CiviCRM: 5.67.1, 5.68.beta1
https://lab.civicrm.org/dev/core/-/issues/4798
Online contribution flow - fix for php8.x, notices, smarty3
2024-02-06T05:45:17Z
eileen
Online contribution flow - fix for php8.x, notices, smarty3
This is an oversight issue for fixing up the online contribution form in php8.x with a view to
1) resolving all the smarty & php layer notices, including in the message templateb
2) fixing the places where it doesn't work with Smarty3 (...
This is an oversight issue for fixing up the online contribution form in php8.x with a view to
1) resolving all the smarty & php layer notices, including in the message templateb
2) fixing the places where it doesn't work with Smarty3 (in the online membership receipt & I think I fixed one in Confirm.tpl maybe)
3) fixing it to work with php8.2 (no undeclared properties)
4) fixing the underlying line item handling mess (we have multiple different ways of setting & retrieving the line itesm + a whole lot of code that does stuff to the line items but ultimately alters variables that get discarded. The impact of that I found tax bugs as soon as I started looking at the code.
5) fixing the online membership receipt such that it is previewable in MessageAdmin Ui, and does not require complex code to call it & have it render correctly (ie. `composeMessageArray` & the form layer both do a lot of assigning that should be unnecessary)
Much of this work has been done in small steps with a few in 5.68 & the bulk in 5.69. The goal is to try to resolve all the most important parts in 5.69 & then not do any more & encourage lots of rc testing on 5.69.
Areas to think about when testing
- data input with different currency separators
- non deductible amount with tax
- checking tax in separate payment & non separate payment scenarios (this actually has modest test cover but should be extended)
- checking the receipts
- checking the contribution recur amount is correct - when there is an autorenew membership + a contribution & it is not separate payment the amount should be equal to the tax-inclusive amount for the membership part of the contribution
Issues
**Must fix regressions**
- [x] Form layer issue on other amount js - probably regression in rc or master https://lab.civicrm.org/dev/core/-/issues/4795
- [x] Disabled options showing up https://github.com/civicrm/civicrm-core/pull/28356
- [x] Membership type not selected as a default https://github.com/civicrm/civicrm-core/pull/28361
- [ ] Is something weird happening with pledge? I couldn't figure out how to enable & disable & see it there & not there - UPDATE - I think this is a demo site data issue - https://github.com/civicrm/civicrm-core/pull/28497
- [x] Is the other Amount js right when there is NOT a membership? Need to compare to an older version... This might also be a demo site data issue per ^^
**Regression?Improvement?**
- [x] Change in line items for membership + contribution https://lab.civicrm.org/dev/core/-/issues/4814
**Extension issues**
- [x] A couple of extensions are interacting with the no-longer-in-use `_lineItem` undeclared property. This undeclared property also causes php8 fails. Declaring it would give a false sense of security but an alternative is to add a magic `__GET` & `__SET`. In my digging so far taxcalculator would need some small changes to adapt to this as the undeclared property is passed-by-reference but other extensions are likely to be OK with it. PR to add magic methods https://github.com/civicrm/civicrm-core/pull/28276 PR on taxcalculator https://lab.civicrm.org/extensions/taxcalculator/-/merge_requests/9
**Pre-existing issues**
These are not necessarily going to be fixed but the process of verifying them provides a goodly amount of rc testing. In some cases they are suspected fully or partially fixed already
*Tax*
- [ ] Long term issue on tax not applying to separate membership payments, in my testing pre-cleanup the tax-not-applied seemed to go beyond separate payments. This needs re-testing & a list of issues confirmed https://lab.civicrm.org/dev/financial/-/issues/154
- [ ] Aha - here is the general tax issue I hit https://lab.civicrm.org/dev/core/-/issues/4524 - needs verification
- [x] How should tax apply to 'Other amount' - is the amount entered inclusive? https://lab.civicrm.org/dev/core/-/issues/4806
- [ ] possible bug - needs verification https://lab.civicrm.org/dev/financial/-/issues/182
- [ ] Now that we have standardised on publicly supported `getLineItems()` & `setLineItems()` how is our hook support https://lab.civicrm.org/dev/core/-/issues/2796
*Localisation*
- [x] Non-English currency formatting messes with other amount field https://lab.civicrm.org/dev/core/-/issues/4802
*Page flow*
- [ ] Membership amount + contribution issues (erm what did I mean when I wrote this?)
- [ ] Data issue when email fails https://lab.civicrm.org/dev/core/-/issues/4540
- [ ] Data issue on payment fail https://github.com/civicrm/civicrm-core/pull/26120
- [ ] ContributionRecurID not always passed to payment processor https://lab.civicrm.org/dev/core/-/issues/4019
- [ ] The stretch goal - create order before adding payment https://lab.civicrm.org/dev/financial/-/issues/76
- [ ] Also the stretch goal https://lab.civicrm.org/dev/financial/-/issues/53
- [ ] Another meta issue of unknown status https://lab.civicrm.org/dev/core/-/issues/928
*Validation*
- [ ] Contribution + membership + quick config https://lab.civicrm.org/dev/core/-/issues/3314
*On Behalf*
- [ ] Profile bug?? https://lab.civicrm.org/dev/financial/-/issues/124
- [ ] Onbehalf hide for orgs https://lab.civicrm.org/dev/core/-/issues/4725
*Presentation issues*
- [ ] Notices on form - undefined property https://lab.civicrm.org/dev/core/-/issues/4760
- [x] Currency incorrect on thank you / confirm pages https://lab.civicrm.org/dev/core/-/issues/3381
- [ ] Probably the same https://lab.civicrm.org/dev/core/-/issues/3917
- [ ] Probably the same https://lab.civicrm.org/dev/core/-/issues/411
- [ ] Problems at form layer with auto-renew handling https://lab.civicrm.org/dev/core/-/issues/3963
- [ ] Frequency units translation issues https://lab.civicrm.org/dev/translation/-/issues/53
- [ ] On behalf confusing https://lab.civicrm.org/dev/core/-/issues/2266
- [ ] PCP notices https://lab.civicrm.org/dev/drupal/-/issues/159
- [ ] Translation missin ghttps://lab.civicrm.org/dev/translation/-/issues/27
- [ ] Show hide billing doesn't work https://lab.civicrm.org/dev/financial/-/issues/129
- [ ] Email appears twice https://lab.civicrm.org/dev/core/-/issues/3858
- [ ] Translation issue https://lab.civicrm.org/dev/core/-/issues/4071
- [ ] Possible bug https://lab.civicrm.org/dev/core/-/issues/4293
- [ ] Bug? replicable https://lab.civicrm.org/dev/core/-/issues/4488
- [ ] Upload image does not show https://lab.civicrm.org/dev/core/-/issues/4817
- [x] Undefined array key "honoreeProfileFields" also "title" in ThankYou.tpl.php that appeared when payment incorrectly recorded as $0 https://lab.civicrm.org/dev/core/-/issues/4863
- [x] Edit contribution has about a dozen undefined array keys for defaultContribution, displayLineItemFinancialType, getTaxDetails, pricesetFieldsCount, hookDiscount https://lab.civicrm.org/dev/core/-/issues/4864
*Membership calculation*
- [ ] Membership term usage issue https://lab.civicrm.org/dev/core/-/issues/3344
- [ ] Probably the same thing https://lab.civicrm.org/dev/core/-/issues/3810
- [ ] Probably the same thing https://lab.civicrm.org/dev/core/-/issues/3339
- [ ] Autorenew deep dive https://lab.civicrm.org/dev/financial/-/issues/128
- [ ] My read of the code suggests that if 2 membership types are configured to offer auto-renew it will only work for one
*Premiums*
- [x] notices on manage premiums https://lab.civicrm.org/dev/core/-/issues/4793
- [x] need api support for premiums https://github.com/civicrm/civicrm-core/pull/28261
- [x] Smarty notices on premiums in Online form flow https://lab.civicrm.org/dev/core/-/issues/4794
- [ ] pre-existing brokenness on deductible amount https://lab.civicrm.org/dev/core/-/issues/1083
- [ ] More non-deductible amount issues https://lab.civicrm.org/dev/core/-/issues/2414
- [ ] non-deductible amount misconfiguration https://lab.civicrm.org/dev/core/-/issues/3083 (note we could add a system check as a low-risk step)
*Manage contribution pages*
- [x] issue saving renew options https://github.com/civicrm/civicrm-core/pull/24997
- [ ] Validation lacking https://lab.civicrm.org/dev/core/-/issues/2846
- [ ] Widget issue https://lab.civicrm.org/dev/core/-/issues/20
*Membership receipts*
- [x ] Remove text version of receipt - we are moving to relying on generated text version rather than maintaining both
- [ ] Membership data wrong https://lab.civicrm.org/dev/core/-/issues/2354
- [ ] Credit card info sometimes missing https://lab.civicrm.org/dev/core/-/issues/661
- [ ] Receipt text inconsistently handled https://lab.civicrm.org/dev/user-interface/-/issues/13
- [ ] Issue on upsell https://lab.civicrm.org/dev/core/-/issues/4332
- [ ] Proposal - remove trxn_id https://lab.civicrm.org/dev/financial/-/issues/217
- [ ] Missing recur links https://lab.civicrm.org/dev/financial/-/issues/127
*Contribution receipts*
- [ ] Somewhat obscure bug on on-behalf profiles (should be addressed if we get as far as moving the handling of that to the WorkflowMessage class) https://lab.civicrm.org/dev/core/-/issues/4779
- [x] Remove text version of receipt - we are moving to relying on generated text version rather than maintaining both
- [ ] Duplicate of donor name https://lab.civicrm.org/dev/core/-/issues/2021
- [ ] Not sent for paypal express https://lab.civicrm.org/dev/financial/-/issues/13
- [ ] PDF file name issue https://lab.civicrm.org/dev/core/-/issues/3068
- [ ] Broken links in contribution issue https://lab.civicrm.org/dev/core/-/issues/1195
- [ ] Likely fixed bug https://lab.civicrm.org/dev/core/-/issues/4185
- [ ] Checksum wiht on-behalf of https://lab.civicrm.org/dev/core/-/issues/4265
*Wordpress issue?*
- [ ] https://lab.civicrm.org/dev/wordpress/-/issues/120
Feature request
- [ ] Configurable confirm button - more than one request - like events - https://lab.civicrm.org/dev/user-interface/-/issues/10 https://lab.civicrm.org/dev/core/-/issues/4324
https://lab.civicrm.org/dev/core/-/issues/4797
A regression? Can't assign case role in CiviCase
2023-11-23T13:15:28Z
tomrosenbloom
A regression? Can't assign case role in CiviCase
I'm not able to assign (or re-assign) a case role to a case in CiviCase in the latest version - I can do this in our live Civi (5.64.4) but not in latest version 5.69.alpha1 either running locally or on the dmaster demo site.
Expected b...
I'm not able to assign (or re-assign) a case role to a case in CiviCase in the latest version - I can do this in our live Civi (5.64.4) but not in latest version 5.69.alpha1 either running locally or on the dmaster demo site.
Expected behaviour:
1. create case, or find existing case in dashboard
2. click Manage, then expand Roles pane
3. click pencil icon next to a role
4. in dialogue box 'Assign <role>', select a contact using autocomplete
Current behaviour:
as above until step 4, where the dialogue box is broken - seems to be a plain text input instead of autocomplete, and dialogue cannot be dismissed with Save or Cancel.
https://lab.civicrm.org/dev/core/-/issues/4796
Cancel button on the "unsubscribe mailing" form doesn't work as expected.
2024-01-05T03:42:40Z
CΓ©sar
Cancel button on the "unsubscribe mailing" form doesn't work as expected.
Overview
----------------------------------------
Hello,
The footer of a mailing (civicrm/admin/component?action=update&id=2) includes the token {action.optOutUrl}, but, if you create a new footer with the token {action.unsubscribeUrl...
Overview
----------------------------------------
Hello,
The footer of a mailing (civicrm/admin/component?action=update&id=2) includes the token {action.optOutUrl}, but, if you create a new footer with the token {action.unsubscribeUrl} and send a mailing, when you click to unsubscribe from the group, a mailing is resent allowing you to resubscribe. In this last form "civicrm/mailing/resubscribe" if you click on the cancel button, you resubscribe.
Both the "next" and "cancel" buttons work the same way.
![Screenshot_from_2023-11-22_16-10-01](/uploads/3b2c5eb787317542ea5b9e4542c97579/Screenshot_from_2023-11-22_16-10-01.png)
* https://github.com/civicrm/civicrm-core/blob/5.63.3/templates/CRM/Mailing/Page/Resubscribe.tpl#L23
Reproduction steps
----------------------------------------
1. Add contact to group
2. Create/edit footer on: "civicrm/admin/component", add {action.unsubscribeUrl}
3. Send mailing test with new footer
4. Unsubscribe with token email
5. Access to new mail Resubscribe and click cancel button (Now you are rejoined to group)
Current behaviour
----------------------------------------
* When I click on the βhereβ link in the re-subscribe confirmation and then on button βCancelβ, we still get re-subscribed.
* The "next" and "cancel" buttons work the same way.
Expected behaviour
----------------------------------------
* Do nothing with cancel button (Cancel action)
Environment information
----------------------------------------
* __CiviCRM: 5.63
* __PHP: 7.4 / 8.1
* __CMS: Drupal
5.69.0