Development issueshttps://lab.civicrm.org/groups/dev/-/issues2018-12-03T10:02:53Zhttps://lab.civicrm.org/dev/core/-/issues/466Broken encoding for german umlauts in search-builder2018-12-03T10:02:53Zthomas_SYSTOPIABroken encoding for german umlauts in search-builderThe select-field-options in the search-builder have broken umlauts if you use german as default-language.
To reproduce this issue just take a fresh CiviCRM-Installation, select "german" as default-language, open the search-builder and s...The select-field-options in the search-builder have broken umlauts if you use german as default-language.
To reproduce this issue just take a fresh CiviCRM-Installation, select "german" as default-language, open the search-builder and select "Kontakte" as record-type.
As you see the umlauts of the options of the field-selection are broken.
This was tested with version 5.5.3 and 5.6.05.7.2https://lab.civicrm.org/dev/core/-/issues/507Find Contacts: There is no possibility to add a tag to contacts from the sear...2018-12-03T22:40:58ZPradeep Nayakpradpnayak@gmail.comFind Contacts: There is no possibility to add a tag to contacts from the search results windowSteps:
* Click "View contact record"
* Click "Search" > "Find Contacts"
* Find some contact
* Click 3 dots for choosing an action near the contact
* Click 'Tag Contact'
* Try to choose some tag
**Actual result:** There is no possibili...Steps:
* Click "View contact record"
* Click "Search" > "Find Contacts"
* Find some contact
* Click 3 dots for choosing an action near the contact
* Click 'Tag Contact'
* Try to choose some tag
**Actual result:** There is no possibility to add a tag to contacts from the search results window.
![Screen_Shot_2018-11-06_at_17.11.21](/uploads/2e0f70bfc2ce2d5f29b044ac0208540b/Screen_Shot_2018-11-06_at_17.11.21.png)
**Expected result:** The user can add a tag to contacts from the search results window5.7.1https://lab.civicrm.org/dev/core/-/issues/573State field displays too small2018-12-04T18:41:12ZGhost UserState field displays too smallThe state field on contribution pages displays too small to display the full text of the field including defaults.
Screenshot: https://i.imgur.com/0yTqQas.png
Not sure if this is a WordPress specific bug or core as I do not have any Dr...The state field on contribution pages displays too small to display the full text of the field including defaults.
Screenshot: https://i.imgur.com/0yTqQas.png
Not sure if this is a WordPress specific bug or core as I do not have any Drupal installs to check it on.https://lab.civicrm.org/dev/core/-/issues/563Duplicate Case manager role2018-12-05T10:41:12ZMonish DebDuplicate Case manager roleSteps to replicate:
1. Create case
2. Go to 'Manage case' and change case manager to someone else
3. Change case manager back to original contact: error - duplicate relationship
4. From the contact's relationship tab, enable a relationsh...Steps to replicate:
1. Create case
2. Go to 'Manage case' and change case manager to someone else
3. Change case manager back to original contact: error - duplicate relationship
4. From the contact's relationship tab, enable a relationship
-- note that the end date is preserved, which may mean that the newly re-enabled relationship is still considered inactive
-- note that in the manage case roles panel the newly re-enabled relationship is not listed as the case manager
5. From the manage case roles panel, add a new role with the same case manager type, to one of the existing contacts: error, duplicate relationship
-- so if you change the case manager, there's currently no way to go back and set the original contact as case manager again5.9Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/552Contribution net amount not re-calculated when fee amount is changed2018-12-05T20:27:27Zaydunsaidan.saunders@squiffle.ukContribution net amount not re-calculated when fee amount is changedWhen a contribution is edited and the fee amount changed, the net amount is not being recalculated.
Scenario 1:
Go to a contact summary
Contributions > Record Contribution
Choose a financial type
Enter amount as 100
Expand Add...When a contribution is edited and the fee amount changed, the net amount is not being recalculated.
Scenario 1:
Go to a contact summary
Contributions > Record Contribution
Choose a financial type
Enter amount as 100
Expand Additional Details section
(Incidentally note stray help text "Net value of the contribution (Total Amount minus Fee)")
Enter Fee Amount as 1.23
Save
View the Contribution just created and note Total amount = $100, Fee amount $1.23, Net amount $98.77 -> Correct
Scenario 2:
Go to a contact summary
Contributions > Record Contribution
Choose a financial type
Enter amount as 100
Save
View the Contribution just created and note Total amount = $100, Fee amount $0, Net amount $100 -> Correct
Now edit the contribution
Expand Additional Details section
Enter Fee Amount as 1.23
Save
View the Contribution just created a note Total amount = $100, Fee amount $1.23, **Net amount $100** -> Total and Fee amounts are correct, but the **Net amount is not recalculated**.
May be related to https://github.com/civicrm/civicrm-core/pull/126625.8https://lab.civicrm.org/dev/core/-/issues/529Editing smart group removes search criteria unless criteria tabs are opened f...2018-12-05T20:28:23ZsudomanEditing smart group removes search criteria unless criteria tabs are opened firstWhen editing the search terms in a smart group, If I click "Search" without first opening the drop down tabs that contain info about all of the search criteria, then those terms are removed from the search, returning a different number o...When editing the search terms in a smart group, If I click "Search" without first opening the drop down tabs that contain info about all of the search criteria, then those terms are removed from the search, returning a different number of contacts.
For instance, if my search terms are: `Country = United Kingdom ...AND... Contribution Date - greater than or equal to "January 2nd, 2017 12:00 AM"`, then I need to open the Address Fields and Contributions tabs before clicking "Search", otherwise, I get a much larger set of contacts.
I'm using CiviCRM version 5.3.1 on Drupal 7. Thanks! : )5.8Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/576Fix issue where fields are dropped from XML files because version comparison ...2018-12-06T19:58:51ZseamusleeFix issue where fields are dropped from XML files because version comparison between the add key and the build version failsOn master we are seeing build failures in the matrix tests at the moment because doing `if (5.3 <= 5.10)` effectively is proving to be false so DAO files are being re-generated to exclude specific fields causing errors.On master we are seeing build failures in the matrix tests at the moment because doing `if (5.3 <= 5.10)` effectively is proving to be false so DAO files are being re-generated to exclude specific fields causing errors.5.10https://lab.civicrm.org/dev/core/-/issues/431notice errors on dmaster on create case2018-12-07T19:06:00ZJoeMurraynotice errors on dmaster on create caseCreated a Housing support case on dmaster just now and got:
Notice: Undefined variable: url in CRM_Activity_Selector_Activity::actionLinks() (line 225 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Activity/Selector/Activit...Created a Housing support case on dmaster just now and got:
Notice: Undefined variable: url in CRM_Activity_Selector_Activity::actionLinks() (line 225 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Activity/Selector/Activity.php).
Notice: Undefined variable: qsView in CRM_Activity_Selector_Activity::actionLinks() (line 226 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Activity/Selector/Activity.php).
Notice: Undefined variable: url in CRM_Activity_Selector_Activity::actionLinks() (line 225 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Activity/Selector/Activity.php).
Notice: Undefined variable: qsView in CRM_Activity_Selector_Activity::actionLinks() (line 226 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Activity/Selector/Activity.php).
Notice: Undefined variable: url in CRM_Activity_Selector_Activity::actionLinks() (line 225 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Activity/Selector/Activity.php).
Notice: Undefined variable: qsView in CRM_Activity_Selector_Activity::actionLinks() (line 226 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Activity/Selector/Activity.php).https://lab.civicrm.org/dev/core/-/issues/44admin price field options should be suppressed in event info page2018-12-08T09:38:52Zlcdwebadmin price field options should be suppressed in event info pageTo recreate:
1. create a price set with an option list price field (select/radio/checkbox)
2. set one of the options to visibility = admin
3. create an event and select this price set
4. view the event info page as a public (unauthe...To recreate:
1. create a price set with an option list price field (select/radio/checkbox)
2. set one of the options to visibility = admin
3. create an event and select this price set
4. view the event info page as a public (unauthenticated) user
The admin price field option should be suppressed but is incorrectly exposed.5.6lcdweblcdwebhttps://lab.civicrm.org/dev/core/-/issues/442Misc form issues2018-12-08T21:12:48ZAkA84Misc form issuesFound a handful of form-related issues that are pretty quick to fix, just wanted to have the green light on them before opening the PR. All screenshots are taken from https://dmaster.demo.civicrm.org (`v5.8.alpha1`)
## Wrong layout in "...Found a handful of form-related issues that are pretty quick to fix, just wanted to have the green light on them before opening the PR. All screenshots are taken from https://dmaster.demo.civicrm.org (`v5.8.alpha1`)
## Wrong layout in "Tags and Groups" accordion of "New Individual" form
The "Tag(s)" label+select group is missing a `<br>`
*Before*
![tags-before](/uploads/69da499d7792714de2dcf417981cfab7/tags-before.png)
*After*
![tags-after](/uploads/1fc640e4a276e0e0e6b7d70917d7337a/tags-after.png)
## Missing class on text fields in "Dedupe exceptions"
The input fields are missing the standard `crm-form-text class
*Before*
![dedupe-before](/uploads/0861f7c3c98f5b0a8a722b98a858fe92/dedupe-before.png)
*After*
![dedupe-after](/uploads/ca670378bf85ed8b3b8d8caba04764d4/dedupe-after.png)
## Wrong class on `<select>`s in "Submit Credit Card Contribution" modal
The <select> elements have the wrong class: `crm-form-date`
![contribute-select-before](/uploads/09ec405fac0bac56fe5c5cd10db1589f/contribute-select-before.png)
Applying the correct class, `crm-form-select` doesn't change much, but allows Shoreditch to style the selects correctly
![contribute-select-after](/uploads/3fd8125dcae0301d83381e329f543a3e/contribute-select-after.png)
## Textareas instead of text input in "Word Replacements" form
This one I'm not really sure is really a markup error, but it looks to me that instead of `<textarea>` elements, the form would benefit by using `input[type="text"]` fields instead (see how the checkboxes get a vertical alignment, for example)
*Before*
![replacement-before](/uploads/47d5a07307d2bb2d2a19850626ad8ee3/replacement-before.png)
*After*
![replacement-after](/uploads/362b5b8591a1171121562e31ca46dded/replacement-after.png)5.9https://lab.civicrm.org/dev/core/-/issues/194Search Builder greater than and lesser than operators for contribution total ...2018-12-09T21:15:34ZMatthias BärnthalerSearch Builder greater than and lesser than operators for contribution total amount omittedTo reproduce:
* Go to Search -> Search generator
* Choose Contribution -> Total Amount
* No greater than, lesser than, greater than equal, lesser than equal operators are present.
My guess is that the field gets treated as a String, th...To reproduce:
* Go to Search -> Search generator
* Choose Contribution -> Total Amount
* No greater than, lesser than, greater than equal, lesser than equal operators are present.
My guess is that the field gets treated as a String, therefore the operator is omitted in Builder.js
`// based on data type remove invalid operators e.g. IS EMPTY doesn't work with Boolean type column
if ((field in CRM.searchBuilder.fieldTypes) === true) {
if (CRM.searchBuilder.fieldTypes[field] == 'Boolean') {
CRM.searchBuilder.generalOperators = _.omit(CRM.searchBuilder.generalOperators, ['IS NOT EMPTY', 'IS EMPTY']);
}
else if (CRM.searchBuilder.fieldTypes[field] == 'String') {
CRM.searchBuilder.generalOperators = _.omit(CRM.searchBuilder.generalOperators, ['>', '<', '>=', '<=']);
}
}
buildOperator(operator, CRM.searchBuilder.generalOperators);`5.4.0https://lab.civicrm.org/dev/core/-/issues/104Get Tests to pass on PHP7.22018-12-10T03:36:53ZseamusleeGet Tests to pass on PHP7.2This is a meta issue for getting our tests to run against PHP7.2 ping @monish.deb @eileen @tottenThis is a meta issue for getting our tests to run against PHP7.2 ping @monish.deb @eileen @totten5.10seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/532Multi-select field not respected in batch search2018-12-10T17:15:43ZPradeep Nayakpradpnayak@gmail.comMulti-select field not respected in batch searchThe "Search by Financial Type" is a multi-select, but if you try to search by multiple values it fails validation (see screenshot 653 attached).
![Selection_653](/uploads/a61c238371a509c511a625d116d56413/Selection_653.png)
PR:https://...The "Search by Financial Type" is a multi-select, but if you try to search by multiple values it fails validation (see screenshot 653 attached).
![Selection_653](/uploads/a61c238371a509c511a625d116d56413/Selection_653.png)
PR:https://github.com/civicrm/civicrm-core/pull/131215.9https://lab.civicrm.org/dev/core/-/issues/462Export temporary tables cause Advanced Logging warning of missing log tables2018-12-12T22:29:36ZbgmExport temporary tables cause Advanced Logging warning of missing log tables`CRM/Utils/SQL/TempTable.php` was introduced around CiviCRM 5.3. It creates temp tables such as:
* `civicrm_tmp_d_{12}_{32}` (temporary tables, but created as ordinary tables)
* `civicrm_tmp_e_{12}_{32}` (ephemeral temp tables, automati...`CRM/Utils/SQL/TempTable.php` was introduced around CiviCRM 5.3. It creates temp tables such as:
* `civicrm_tmp_d_{12}_{32}` (temporary tables, but created as ordinary tables)
* `civicrm_tmp_e_{12}_{32}` (ephemeral temp tables, automatically deleted by mysql)
After a while, depending on cleanup, users of CiviCRM using Advanced Logging will see warnings that there are missing log tables.
cc @jackrabbithanna @totten5.7bgmbgmhttps://lab.civicrm.org/dev/core/-/issues/582Regression - datepicker icon not showing on search builder2018-12-12T23:43:41ZeileenRegression - datepicker icon not showing on search buildersee https://civicrm.stackexchange.com/questions/27628/search-builder-does-not-display-date-picker-for-contacts/27632#27632see https://civicrm.stackexchange.com/questions/27628/search-builder-does-not-display-date-picker-for-contacts/27632#276325.8.1https://lab.civicrm.org/dev/core/-/issues/588"CiviMail Draft" appears twice in non-Mosaico test emails2018-12-13T04:45:56ZJonGold"CiviMail Draft" appears twice in non-Mosaico test emailsCiviCRM 5.8.0 I believe this is a side effect of https://github.com/civicrm/civicrm-core/pull/12758.CiviCRM 5.8.0 I believe this is a side effect of https://github.com/civicrm/civicrm-core/pull/12758.5.8.1https://lab.civicrm.org/dev/core/-/issues/592ArgumentCountError: Too few arguments to function CiviCRM_API3_Exception...2018-12-13T06:41:13ZBjörn EndresArgumentCountError: Too few arguments to function CiviCRM_API3_Exception...Full message:
``ArgumentCountError: Too few arguments to function CiviCRM_API3_Exception::__construct(), 1 passed in [drupal root]/sites/all/modules/civicrm/Civi/API/Api3SelectQuery.php on line 130 and at least 2 expected in CiviCRM_API...Full message:
``ArgumentCountError: Too few arguments to function CiviCRM_API3_Exception::__construct(), 1 passed in [drupal root]/sites/all/modules/civicrm/Civi/API/Api3SelectQuery.php on line 130 and at least 2 expected in CiviCRM_API3_Exception->__construct()
``
I'm assuming the ``new \CiviCRM_API3_Exception(`` call has escaped the author when fixing all ``new CiviCRM_API3_Exception(`` occurrences after the signature change.
Seems to affect ``5.7.2`` and later.
I'll post a PR right away.5.10https://lab.civicrm.org/dev/core/-/issues/572Regression: Custom Note fields on Events do not work with CKEditor since 5.72018-12-13T08:48:47ZAgilewareRegression: Custom Note fields on Events do not work with CKEditor since 5.7Agileware ref: CIVICRM-1118
Overview
========
Custom Note fields on Events no longer work with CKEditor.
Was working in 5.6.2.
Verified this still an issue on `dmaster.demo.civicrm.org`:
![rich_text_field_event](/uploads/b636e035977...Agileware ref: CIVICRM-1118
Overview
========
Custom Note fields on Events no longer work with CKEditor.
Was working in 5.6.2.
Verified this still an issue on `dmaster.demo.civicrm.org`:
![rich_text_field_event](/uploads/b636e035977d0b5d100a6229c83e5200/rich_text_field_event.png)
Steps to Reproduce
==================
1. Create a custom data group for Events
2. Add a "Note" field using the "Rich Text Editor" Input Field Type
3. Create an event. Rich text editor is working here.
4. Edit the event Info and Configuration.
5. The custom field doesn't load CKEditor, complaining that `a.ui.spaces` is undefined or null.
6. Sometimes CKEditor doesn't load for the "Complete Description" field either, but it fails less reliably.5.8https://lab.civicrm.org/dev/core/-/issues/579Unable to make backend contributions with non-default payment processor (some...2018-12-14T14:40:16ZAlanDixonUnable to make backend contributions with non-default payment processor (sometimes) "no class provided" errorThis isn't a full error report, but we've been chasing it down long enough I wanted to get something in here.
As per the title, here's how it happens:
1. Create a payment processor instance (i.e. add payment processor here /civicrm/admi...This isn't a full error report, but we've been chasing it down long enough I wanted to get something in here.
As per the title, here's how it happens:
1. Create a payment processor instance (i.e. add payment processor here /civicrm/admin/paymentProcessor?reset=1)
2. Create a second one of the same type, different credentials. Leave the first one as default.
When trying to use the second payment processor on a 'backend/admin' contribution form (ie. /civicrm/contact/view/contribution?action=add&cid=etc.), we get an error at
/CRM/Contribute/Form/Contribution.php, line 1165
(this is using civicrm 5.6.1, we had the same issue on 5.3.1).
As far as we know this behaviour was introduced sometime shortly before 5.3.1 (that was the security update in the summer), and I suspect it might be related to this commit: https://github.com/civicrm/civicrm-core/commit/8461467c33a8e35f67b1d9938cdbc3d5ba5fd4b9
The commit in general is good, but the code it's touching is sufficiently scary that lots of hidden things might happen. Or maybe that's unrelated ...
I can see that the payment_processor_id value is getting to the server (I can see it in the submit values in the stacktrace).
To make matters a bit more confusing, we can't reproduce it reliably (but do have it reproduced on three separate sites, but not a fourth), so there is some additional aspect going on here. These tests are all using the iATS payment processor (of course ...), but I don't think that actually comes into play, since the code breaks before it can identify which payment processor is responsible for the payment.
Clues welcome ...https://lab.civicrm.org/dev/core/-/issues/498Undefined index in mailing report for mailing_modified_date; and room for ref...2018-12-14T23:17:06ZJKingsnorthUndefined index in mailing report for mailing_modified_date; and room for refactoringNotice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report() (line 1821 of /home/developer/buildkit/build/civicrmdev/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php).
Appears on ...Notice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report() (line 1821 of /home/developer/buildkit/build/civicrmdev/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php).
Appears on pages like: /civicrm/mailing/report?mid=7&reset=1
This is because the DAO key for the field is 'mailing_modified_date' - but the name is 'modified_date'.
And the way the field values are assigned to the object does not account for this difference.
This is a very minor issue as the modified date doesn't actually get used in the report!
We should probably refactor the query/code to only load the fields we're actually interested in; and get rid of the raw SQL in the file at the same time: https://github.com/civicrm/civicrm-core/blob/f87c35c7308fc6876e1a4fea8ac3ea908d3d9453/CRM/Mailing/BAO/Mailing.php#L18075.9