Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-01-04T18:01:36Zhttps://lab.civicrm.org/dev/core/-/issues/2481Discussion drop support for php 7.2 and mysql 5.62023-01-04T18:01:36ZeileenDiscussion drop support for php 7.2 and mysql 5.6We have been dropping support for EOL php & mysql on ESR releases because that gives sites the option of delaying for another 6 months for just $120. So far we are not aware of any sites opting for the ESR for that reason but we are crea...We have been dropping support for EOL php & mysql on ESR releases because that gives sites the option of delaying for another 6 months for just $120. So far we are not aware of any sites opting for the ESR for that reason but we are creating the option.
With 5.39 coming up we should consider whether we want to drop support for
php 7.2 (EOL Dec 2020)
mysql 5.6 (EOL Feb 2021)
Note that historically supporting older versions of mysql has been low effort although some features are not supported. However, it might be holding us back from using new features
Supporting older versions of php has historically been more problematic as it has been at the expense of supporting newer versions. In particular we often find packages don't support latest and EOL versions.
So dropping support for older php versions is more helpful than older mysql versions.
Last ESR we considered dropping support for php 7.1 and mysql 5.6. We did the former and not the latter. At the time the stats were:
mysql 5.6 : 805
php 7.1 : 658.
Maria DB 10.1 : 943
Currently they are
mysql 5.6 : 603
php 7.2 : 2846
Maria DB 10.1 : 526
Based on those numbers I think it's clearly too early for php 7.2 and I would be OK targetting both for the NEXT ESR (5.45)https://lab.civicrm.org/dev/core/-/issues/4047htmlspecialchars() issue on PHP8 and CiviReport2023-01-04T07:44:17ZJonGoldhtmlspecialchars() issue on PHP8 and CiviReport**Note** I've been seeing this `htmlspecialchars()` error on this line frequently on PHP 8. This is just the one instance I investigated thoroughly.
When attempting to use a particular CiviReport instance, we get a WSOD with this error...**Note** I've been seeing this `htmlspecialchars()` error on this line frequently on PHP 8. This is just the one instance I investigated thoroughly.
When attempting to use a particular CiviReport instance, we get a WSOD with this error in watchdog:
```
TypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, array given in htmlspecialchars() (line 144 of /var/www/mysite/vendor/civicrm/civicrm-packages/HTML/Common.php)
#0 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/Common.php(144): htmlspecialchars()
#1 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/input.php(154): HTML_Common->_getAttrString()
#2 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/Renderer/Array.php(307): HTML_QuickForm_input->toHtml()
#3 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/Renderer/ArraySmarty.php(189): HTML_QuickForm_Renderer_Array->_elementToArray()
#4 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Form/Renderer.php(87): HTML_QuickForm_Renderer_ArraySmarty->_elementToArray()
#5 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/Renderer/Array.php(221): CRM_Core_Form_Renderer->_elementToArray()
#6 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/element.php(415): HTML_QuickForm_Renderer_Array->renderElement()
#7 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm.php(1705): HTML_QuickForm_element->accept()
#8 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Form.php(1136): HTML_QuickForm->accept()
#9 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/QuickForm/Action/Display.php(95): CRM_Core_Form->toSmarty()
#10 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/QuickForm/Action/Display.php(83): CRM_Core_QuickForm_Action_Display->renderForm()
#11 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform()
#12 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle()
#13 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Controller.php(355): HTML_QuickForm_Page->handle()
#14 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Utils/Wrapper.php(98): CRM_Core_Controller->run()
#15 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Report/Page/Instance.php(74): CRM_Utils_Wrapper->run()
#16 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(319): CRM_Report_Page_Instance->run()
#17 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem()
#18 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke()
#19 /home/jon/local/mysite/web/modules/contrib/civicrm/src/Civicrm.php(88): CRM_Core_Invoke::invoke()
#20 /home/jon/local/mysite/web/modules/contrib/civicrm/src/Controller/CivicrmController.php(80): Drupal\civicrm\Civicrm->invoke()
#21 [internal function]: Drupal\civicrm\Controller\CivicrmController->main()
#22 /home/jon/local/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#23 /home/jon/local/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(580): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#24 /home/jon/local/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext()
#25 /home/jon/local/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#26 /home/jon/local/mysite/vendor/symfony/http-kernel/HttpKernel.php(169): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#27 /home/jon/local/mysite/vendor/symfony/http-kernel/HttpKernel.php(81): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#28 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
#29 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#30 /home/jon/local/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#31 /home/jon/local/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#32 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#33 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#34 /home/jon/local/mysite/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#35 /home/jon/local/mysite/web/core/lib/Drupal/Core/DrupalKernel.php(707): Stack\StackedHttpKernel->handle()
#36 /home/jon/local/mysite/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#37 {main}
```
I tracked it down to my `form_values` which is this:
```
a:27:{s:6:"fields";a:4:{s:9:"sort_name";s:1:"1";s:8:"event_id";s:1:"1";s:9:"status_id";s:1:"1";s:7:"role_id";s:1:"1";}s:12:"sort_name_op";s:3:"has";s:15:"sort_name_value";s:0:"";s:8:"email_op";s:3:"has";s:11:"email_value";s:0:"";s:11:"event_id_op";s:2:"in";s:14:"event_id_value";a:0:{}s:6:"sid_op";s:2:"in";s:9:"sid_value";a:0:{}s:6:"rid_op";s:2:"in";s:9:"rid_value";a:0:{}s:34:"participant_register_date_relative";s:1:"0";s:30:"participant_register_date_from";s:0:"";s:28:"participant_register_date_to";s:0:"";s:6:"eid_op";s:2:"in";s:9:"eid_value";a:0:{}s:11:"custom_4_op";s:2:"in";s:14:"custom_4_value";a:0:{}s:16:"blank_column_end";s:0:"";s:11:"description";s:44:"Provides lists of participants for an event.";s:13:"email_subject";s:0:"";s:8:"email_to";s:0:"";s:8:"email_cc";s:0:"";s:10:"permission";s:16:"access CiviEvent";s:6:"groups";s:0:"";s:7:"options";N;s:9:"domain_id";i:1;}
```
Unserialized:
```
array (
'fields' =>
array (
'sort_name' => '1',
'event_id' => '1',
'status_id' => '1',
'role_id' => '1',
),
'sort_name_op' => 'has',
'sort_name_value' => '',
'email_op' => 'has',
'email_value' => '',
'event_id_op' => 'in',
'event_id_value' => array (),
'sid_op' => 'in',
'sid_value' => array (),
'rid_op' => 'in',
'rid_value' => array (),
'participant_register_date_relative' => '0',
'participant_register_date_from' => '',
'participant_register_date_to' => '',
'eid_op' => 'in',
'eid_value' => array (),
'custom_4_op' => 'in',
'custom_4_value' => array (),
'blank_column_end' => '',
'description' => 'Provides lists of participants for an event.',
'email_subject' => '',
'email_to' => '',
'email_cc' => '',
'permission' => 'access CiviEvent',
'groups' => '',
'options' => NULL,
'domain_id' => 1,
)
```
The issue is `custom_4`, which is save as `in` `array()`. However, this is (and always has been) a free-entry text field, so "IN" should never have been an option. Pre-PHP8, this was ignored, now it's a fatal error.
I see @seamuslee made a [partial fix](https://github.com/civicrm/civicrm-packages/pull/346) but I'll submit a patch to handle the "empty array" case.JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/1372APIv4 Explorer should display more error details2023-01-04T05:03:24ZtottenAPIv4 Explorer should display more error details## Current Behavior
If you use the APIv4 Explorer to call something and hit an exception, then the output does not present any details. It only says "Internal Server Error"; this is true even if the response includes more details.
![Sc...## Current Behavior
If you use the APIv4 Explorer to call something and hit an exception, then the output does not present any details. It only says "Internal Server Error"; this is true even if the response includes more details.
![Screen_Shot_2019-11-06_at_8.15.04_PM](/uploads/cb0c7c2944f7c16451c893985f6c5171/Screen_Shot_2019-11-06_at_8.15.04_PM.png)
## Expected Behavior
Display the error message and backtrace.
## Environment
* CiviCRM: `master` circa Nov 6 -- early `5.21.alpha1`https://lab.civicrm.org/dev/core/-/issues/1093Add support for bulkcreates2023-01-04T05:03:23ZeileenAdd support for bulkcreatesAfter discussing with @colemanw on chat - there is a demand in some cases to create an entity in a way that performs well on multiple creates at one. GroupContact or MailingQueue are both examples. The current example is creating bulk cu...After discussing with @colemanw on chat - there is a demand in some cases to create an entity in a way that performs well on multiple creates at one. GroupContact or MailingQueue are both examples. The current example is creating bulk custom fields - the actual row saves are fine here but if adding more than one field to an-already-large custom table then multiple column adds is slow whereas one sql action adding multiple indexes & columns (& one for log tables) is much better.
We talked about laying the ground work for this being a supported apiv4 action with the goal being that apiv4 would expose an action for any entities that have a bulkCreate action.
At this stage my scope is limited to cleaning up the CustomField.create function and adding a bulkCreate function that is tested & suitable to be exposed via apiv4 (but I'm not taking that next step at this stage so the contract can still change). Currently 2 BAO have bulkCreate functions. They relate to mailings and are suitable for bulk create although require some tweaks (passing keyed params rather than 0, 1 etc)https://lab.civicrm.org/dev/core/-/issues/4049Tag tree broken for nested tags when the tags weren't created in the same ord...2023-01-03T21:07:11ZgellweilerTag tree broken for nested tags when the tags weren't created in the same order as they are nestedOverview
----------------------------------------
Commit https://lab.civicrm.org/dev/core/-/commit/a902f9f9268899c31ca21296d19d8c247a370a43 brakes the tag tree (in the add tag to contact dialog) for nested tags when the tags weren't crea...Overview
----------------------------------------
Commit https://lab.civicrm.org/dev/core/-/commit/a902f9f9268899c31ca21296d19d8c247a370a43 brakes the tag tree (in the add tag to contact dialog) for nested tags when the tags weren't created in the same order as they are nested.
This happens when a child tag that has itself children is moved under a newer parent tag.
Reproduction steps
----------------------------------------
1. Go to civicrm/tag
2. Add a new tag called "Isaac" to the tag tree
3. Add a new tag called "Abraham" to the tag tree
4. Add a new tag called "Jacob" to the tag tree
5. Move the tag "Jacob" below "Isaac"
6. Move the tag "Isaac" below "Abraham"
7. Try to add the Tag Jacob to a contact (it will not show up).
The order of tag creation is important.
![order_of_creation_and_tag_hierarchy](/uploads/f6d9e14d41fe988231fcea735ae73ebd/order_of_creation_and_tag_hierarchy.png)
Current behaviour
----------------------------------------
The tag Jacob is not shown when trying to add it to a contact.
![jacob_missing](/uploads/2f968f85eca49eb574d724df63300536/jacob_missing.png)
Expected behaviour
----------------------------------------
_What should happen._
This is how it used to be and how it is after applying the fix:
![expected_behavior](/uploads/1477bb98b6fee39836d81b152669e5d3/expected_behavior.png)
Fix and cause of issue
----------------------------------------
If you uncomment `$thisref['children'] = [];` in line 92 in file `CRM/Core/BAO/Tag.php` everything works again as expected.
This error was introduced by commit https://lab.civicrm.org/dev/core/-/commit/a902f9f9268899c31ca21296d19d8c247a370a43.https://lab.civicrm.org/dev/core/-/issues/4034CRM Builder - Profiles allow multiple Formatting Free HTML fields in forms2023-01-03T14:46:14ZJonny ToomeyCRM Builder - Profiles allow multiple Formatting Free HTML fields in formsOverview
----------------------------------------
When building a conribution form, or altering the profile for a form, the Javascript rightly detects duplciate fields and prevents saving. Would like to make an exception for Free HTML fi...Overview
----------------------------------------
When building a conribution form, or altering the profile for a form, the Javascript rightly detects duplciate fields and prevents saving. Would like to make an exception for Free HTML fields (could be expanded to anything from the Formatting section if that section should expand)
Current workaround
----------------------------------------
Saving after each change gets around this for now
Proposed behaviour
----------------------------------------
alter the markDuplicates() method so that is_duplicate class is only applied when the ufFieldModel does not have the label 'Free HTML'. This will allow multiple Free HTML fields for formatting forms
Proposed solution
----------------------------------------
civicrm/js/model/crm.uf.js
![markDuplicates](/uploads/fe6b7f9c7da464418d2bd6a27f75639a/markDuplicates.PNG)https://lab.civicrm.org/dev/core/-/issues/786Search Builder: Empty Operators create DB Errors; switching to NULL Operators...2023-01-03T05:03:33ZjoeglSearch Builder: Empty Operators create DB Errors; switching to NULL Operators fixesStackOverflow here: https://civicrm.stackexchange.com/questions/28802/search-builder-smart-group-with-latitute-street-address-criteria-1292-truncated
We have upgraded from 4.7.17 to 5.9.1. This was initially a Smart Group DB Error issue...StackOverflow here: https://civicrm.stackexchange.com/questions/28802/search-builder-smart-group-with-latitute-street-address-criteria-1292-truncated
We have upgraded from 4.7.17 to 5.9.1. This was initially a Smart Group DB Error issue, but I believe it has more to do with the Empty vs Null operators. The Smart Group/Contact Group in question is built on two simple search builder criteria:
Contacts Primary Street Address is NOT EMPTY
Contacts Primary Latitude IS EMPTY
The resulting error from trying to update this Smart Group is:
`[nativecode=1292 ** Truncated incorrect DOUBLE value: '']`
Additionally, when I attempt to create a new Search Builder with the same criteria, I wouldn't get a hard DB Error page fail, but I still saw this in the logs:
`Ignoring exception thrown by nullHandler: -1, DB Error: unknown error`
When I switched both the operators from EMPTY to NULL in the criteria, I had no problems with search and was able to successfully update the Smart Group.
One thing which I think is important/pertinent is when I initially loaded the "Edit Search Criteria" page for the existing Smart Group, the Search did not remember the operators and I had to re-select them -- this leads me to believe the field storage methodology for the operator lists changed at some point, and the options we had selected in this search were not carried over properly in an upgrade, but I am not certain.https://lab.civicrm.org/dev/core/-/issues/1368Renaming "Current Employer" Field on Employer Relationship Type2023-01-03T05:03:32ZJerry AyodeleRenaming "Current Employer" Field on Employer Relationship Type**How it is:**
Currently the (Employer of/Employer is) relationship type includes an optional data field called “Current Employer”. Use cases where contacts have multiple employers suggest that this field can be put to more accurate use ...**How it is:**
Currently the (Employer of/Employer is) relationship type includes an optional data field called “Current Employer”. Use cases where contacts have multiple employers suggest that this field can be put to more accurate use with a little renaming.
![Screenshot_2019-11-05_at_13.19.57](/uploads/f58ccb8c984b3aacce2bf03b83357bf0/Screenshot_2019-11-05_at_13.19.57.png)
**How it should be:**
* Suggestion to change the phrasing of the “Current Employer” field in the Relationship section of contact records in CiviCRM to “Primary Employer”. As the field’s name in the Database is “employer_id”, it is fair to assume this change to not be too disruptive. This would allow for users to have multiple employers and separation, if necessary, between employers.
* It would also not be amiss to have a help icon on the field that users can toggle to get a clearer understanding of the field and its intended use.
If the suggested changes are made, Tokens, Import and Export functionality will likely be affected by the syntax changes and will need to be visited accordingly.https://lab.civicrm.org/dev/core/-/issues/414Drupal views group filter is not working2023-01-02T23:26:16Zvakeesan26Drupal views group filter is not workingWhen i create the Group filter for contact sub-type there are no results coming.
The like query is being generated as "civicrm_contact.contact_sub_type LIKE '%��%'"
Please see the images below
![Group-Filter](/uploads/2a6a783ba85cf2be4d...When i create the Group filter for contact sub-type there are no results coming.
The like query is being generated as "civicrm_contact.contact_sub_type LIKE '%��%'"
Please see the images below
![Group-Filter](/uploads/2a6a783ba85cf2be4ded2df618e42eec/Group-Filter.JPG)![Group-Filter-Query](/uploads/36be0b16085264c2069156921e47b0df/Group-Filter-Query.JPG)5.54.0https://lab.civicrm.org/dev/core/-/issues/3782Don't prevent contact with Cancelled membership from signing up online2023-01-02T17:47:01Zmattwiremjw@mjwconsult.co.ukDon't prevent contact with Cancelled membership from signing up onlineContribution page prevents signing up for a membership if the matched contact has an existing cancelled membership of the same type.
I don't really understand why https://github.com/civicrm/civicrm-core/pull/3531 ever got merged given t...Contribution page prevents signing up for a membership if the matched contact has an existing cancelled membership of the same type.
I don't really understand why https://github.com/civicrm/civicrm-core/pull/3531 ever got merged given that it seems no-one was in favour of restricting memberships in this way: https://issues.civicrm.org/jira/browse/CRM-14645
A restriction such as this could easily be put in place via the `validateForm` hook for anyone who actually needs it and it seems a pretty obscure restriction to have hardcoded in core.5.56.0https://lab.civicrm.org/dev/core/-/issues/1362Create access role for importing memberships2023-01-02T05:03:55ZedvanleeuwenCreate access role for importing membershipsAt the moment, there is an access role to import contacts, but not for memberships. The latter shows up in the menu of users who are not allowed to import contacts.
It would be better to have a separate role for this or to attach this a...At the moment, there is an access role to import contacts, but not for memberships. The latter shows up in the menu of users who are not allowed to import contacts.
It would be better to have a separate role for this or to attach this access to the contact import role.https://lab.civicrm.org/dev/core/-/issues/858Weekly contribution summary displays incorrect results2023-01-02T05:03:54ZJKingsnorthWeekly contribution summary displays incorrect resultsThe weekly contribution summary does not group results correctly, resulting in inaccurate reporting.
Steps to recreate on dmaster:
- Use the Contribution Summary report, and change the 'Grouping' to Date Received - Week
- Add a contribu...The weekly contribution summary does not group results correctly, resulting in inaccurate reporting.
Steps to recreate on dmaster:
- Use the Contribution Summary report, and change the 'Grouping' to Date Received - Week
- Add a contribution for the date Sunday 7 April 2019
- Add a contribution for the date Monday 8 April 2019
Result - expected 2 rows, since two 'weeks' are covered, instead just one row is displayed:
![image](/uploads/f34a73f1142d4a2bd36150383db32477/image.png)
![image](/uploads/8a9ed219ce1fd55d7bc82c2afbf4c007/image.png)https://lab.civicrm.org/dev/core/-/issues/1354Proposal: Add customfield search in Campaign dashboard2023-01-01T05:03:25ZVangelisPProposal: Add customfield search in Campaign dashboardOn a regular basis I got some requests to have the customfields that are being assigned into Campaigns, exposed to the search of the campaign dashboard so that users can filter by those customfields.
I've already started working a littl...On a regular basis I got some requests to have the customfields that are being assigned into Campaigns, exposed to the search of the campaign dashboard so that users can filter by those customfields.
I've already started working a little bit on this issue myself, that is, to add all associated customfields on the campaign's dashboard filter search, is there any interest on this feature ?
Cheershttps://lab.civicrm.org/dev/core/-/issues/1282Customfields of type Multiselect attached to an Address do not render in prof...2023-01-01T05:03:25ZVangelisPCustomfields of type Multiselect attached to an Address do not render in profile page (appear empty)### Description
If we have a customfield that is being attached to an address and this customfield is of type Multi-Select, it does not render when `setDefaults` starts, thus appears empty.
### Steps to reproduce
1) Create a new custo...### Description
If we have a customfield that is being attached to an address and this customfield is of type Multi-Select, it does not render when `setDefaults` starts, thus appears empty.
### Steps to reproduce
1) Create a new customfield of type Multi-select and attach it to an address location. Add 2-3 option values.
2) Create a test profile and add this customfield as a field in that profile
3) View the profile and fill in the information, as you normally do.
4) On next reload/update, the stored values do not display
### The issue
It seems that there's no special process for non-text/integer fields here:
https://lab.civicrm.org/dev/core/blob/master/CRM/Core/BAO/UFGroup.php#L2479-2483
### Proposed solution
Enrich that function as we do a few lines before : https://lab.civicrm.org/dev/core/blob/master/CRM/Core/BAO/UFGroup.php#L2373-2400
PR Available [here](https://github.com/civicrm/civicrm-core/pull/15375)https://lab.civicrm.org/dev/core/-/issues/1357Add column for total duration for Activity report2022-12-31T05:03:25ZyashodhaAdd column for total duration for Activity reportAdd column for total duration for Activity report. This will be the sum of duration of all activities in report result and will be displayed in the statistics section.Add column for total duration for Activity report. This will be the sum of duration of all activities in report result and will be displayed in the statistics section.https://lab.civicrm.org/dev/core/-/issues/1349CiviCRM "Mobile" Menu on Drupal 8 is positioned weirdly.2022-12-31T05:03:25ZhomotechsualCiviCRM "Mobile" Menu on Drupal 8 is positioned weirdly.![image](/uploads/1c1129de0ced6919bb23cdb5c1a38be6/image.png)
This is the CiviCRM menu's styling on Drupal 8 with the Drupal Toolbar collapsed in "Mobile" mode. We're using absolute positioning to place the CiviCRM active menu in the mo...![image](/uploads/1c1129de0ced6919bb23cdb5c1a38be6/image.png)
This is the CiviCRM menu's styling on Drupal 8 with the Drupal Toolbar collapsed in "Mobile" mode. We're using absolute positioning to place the CiviCRM active menu in the mobile menu - this seems a little odd as a solution and I'm certain there's a better way to handle this.
If we decide not to take a different approach to this I feel changing the iconography to match Drupal 8's default styling would make this less "jarring".
Opened this issue for further discussion around possible solutions/thoughts.https://lab.civicrm.org/dev/core/-/issues/1338CiviCase end date not showing nor consistent2022-12-30T05:03:34ZStoobCiviCase end date not showing nor consistentIt is possible to search by End Date in CiviCase
![find](/uploads/545ddd404b11dbebb421e1c88131488c/find.png)
But neither Date shows up in the results of Find Cases. End Date is _only_ visible using Search Builder
![results](/uploads/e0...It is possible to search by End Date in CiviCase
![find](/uploads/545ddd404b11dbebb421e1c88131488c/find.png)
But neither Date shows up in the results of Find Cases. End Date is _only_ visible using Search Builder
![results](/uploads/e0fe3b35b3a2e71eb960f52d5bf3db45/results.png)
Nor does the End Date visible when managing the case itself
![case-view](/uploads/d4ec00d1267d0e4232405e8b045f3683/case-view.png)
Furthermore, the End Date of the Case is occasionally set mechanically by the software (not a human) to a Date *other than* the last Activity on the case. This is confusing how this Date determination is made and the treatment is inconsistent.
I'd find an explanation to this behavior from someone who knows, and possibly improve this Date process.https://lab.civicrm.org/dev/core/-/issues/1252Contribution Summary report only shows first 50 entries2022-12-30T05:03:34ZVangelisPContribution Summary report only shows first 50 entriesHi!
I've noticed that the Contribution Summary report only shows the first 50 entries, without giving you the ability to move to the next set of records.
Bottom-page statistics also calculate those 50 displayed entries and not all ro...Hi!
I've noticed that the Contribution Summary report only shows the first 50 entries, without giving you the ability to move to the next set of records.
Bottom-page statistics also calculate those 50 displayed entries and not all rows.
Narrowing it down, I was able to make it work again by commenting 3 lines on the function `buildRows`. The offending lines:
```php
CRM_Core_DAO::disableFullGroupByMode();
CRM_Core_DAO::reenableFullGroupByMode();
$this->addToDeveloperTab($sql);
```
Source code reference [here](https://lab.civicrm.org/dev/core/blob/master/CRM/Report/Form/Contribute/Summary.php#L743-746)
Only when all these 3 lines are commented/removed, the report displays all records with a proper pager.
Anyone can shed any light why is this happening as I can't seem to be able to find out the reason?
Spotted on CiviCRM 5.16.2https://lab.civicrm.org/dev/core/-/issues/4050Can't Disable Event Notification when Registering Participant Off-line2022-12-28T18:13:11ZsavionleeCan't Disable Event Notification when Registering Participant Off-lineOverview
----------------------------------------
When performing an offline Event Registration, you cannot disable "Send Confirmation and Receipt". The POST handler ```civicrm/contact/view/participant``` sends out emails irrespective of...Overview
----------------------------------------
When performing an offline Event Registration, you cannot disable "Send Confirmation and Receipt". The POST handler ```civicrm/contact/view/participant``` sends out emails irrespective of the disabled checkbox on the UI and the disabled default event page configuration.
https://chat.civicrm.org/civicrm/pl/4uy3mp5c3jbtjdx96fif6nk4ie
_If you have already posted on https://civicrm.stackexchange.com or https://chat.civicrm.org, please include the link to that conversation._
Reproduction steps
----------------------------------------
1. Open a Contact
1. Click on **Actions-> Register for Event**.
1. After any Event, Disable **☑️ Send Confirmation and Receipt** and **Save**.
1. Got a success of **"Event registration for Test Email has been added. A confirmation email has been sent to"**.
(No email should have been sent)
Current behaviour
----------------------------------------
_What happens currently. Please provide error messages, screenshots or gifs ([LICEcap](http://www.cockos.com/licecap/), [SilentCast](https://github.com/colinkeenan/silentcast)) where appropriate._
Currently Sends this payload with a disabled send notification and disabled Payment box
```
entryURL:
https://example.website/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fcontact%2Fview%2Fparticipant&page=CiviCRM&reset=1&action=add&cid=497&context=participant
_qf_default:
Participant:upload
MAX_FILE_SIZE: 83886080
_qf_Participant_upload: 1
contact_id: 497
event_id: 15
campaign_id: 8
role_id[]: 1
register_date: 2022-12-27 13:23:00
status_id: 1
source:
hidden_feeblock: 1
hidden_eventFullMsg:
priceSetId: 10
price_16:
price_13:
price_11:
financial_type_id: 4
total_amount: 0
receive_date: 2022-12-27 13:23:00
trxn_id:
contribution_status_id: 1
payment_instrument_id: 4
check_number:
from_email_address: 185
receipt_text:
note:
hidden_custom: 1
hidden_custom_group_count[]: 1
custom_21_-1:
custom_18_-1: 0
custom_19_-1: 0
custom_20_-1: 0
custom_22_-1:
hidden_custom: 1
hidden_custom_group_count[]: 1
hidden_custom: 1
hidden_custom_group_count[]: 1
hidden_custom: 1
hidden_custom_group_count[]: 1
```
I injected a null value into the options to select from the drop down which changed the parameter of ```from_email_address: 185``` to ```from_email_address: ``` Unfortunately, that is not how the post handler determines if to send a message because i got this error:
![image](/uploads/ddd977f63def220652a4e628a64e6702/image.png) So it still tried to send with the unset email address.
Expected behaviour
----------------------------------------
_What should happen._
No email is sent.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Edge 108.0.1462.54 _
* __CiviCRM:__ _5.56.0, 5.55.3_
* __PHP:__ _7.4?_
* __CMS:__ _Wordpress 6.1.1_
* __Database:__ _Maria DB_
* __Web Server:__ _Apache 2_
Comments
----------------------------------------
I'm not skilled in reading how php handles calls and everything, so i can't find the handler that this post query relates to. Any pointers would help!https://lab.civicrm.org/dev/core/-/issues/1314“Post Code Suffix” in Reports is the same as “Postal Code”2022-12-28T05:03:26Zdavepage“Post Code Suffix” in Reports is the same as “Postal Code”As per [this bug report](https://civicrm.stackexchange.com/questions/28778/post-code-suffix-in-reports-is-the-same-as-postal-code), which I can still reproduce on CiviCRM 5.16.2 on Drupal 7.67
>>>
My contacts have UK-style postcodes wit...As per [this bug report](https://civicrm.stackexchange.com/questions/28778/post-code-suffix-in-reports-is-the-same-as-postal-code), which I can still reproduce on CiviCRM 5.16.2 on Drupal 7.67
>>>
My contacts have UK-style postcodes with the first half (e.g. "M19") stored in "Postal Code" and the second (e.g. "3JD") in "Post Code Suffix".
I am trying to get a list of my members, with full postcode data, as a CSV. I generate the built-in "Membership Report (Detail)" which is at /civicrm/report/instance/20 for my instance. I then add the "Postal Code" and "Post Code Suffix" columns (among other address ones). The data displayed in "Post Code Suffix" is identical to that in "Postal Code", e.g. they are both "M19". This is also the case in an exported CSV of the report.
The correct data is in the database - clicking on any "Contact Name" from the report takes me to the individual "View Contact" screen, where the Post Code & Suffix are correct (e.g. "M19" "3JD").
Any idea what's going on here or how I can fix this?
>>>