Development issueshttps://lab.civicrm.org/groups/dev/-/issues2019-10-10T18:48:37Zhttps://lab.civicrm.org/dev/core/-/issues/933Flash-based charts missing in Chrome because the "click to enable" button is ...2019-10-10T18:48:37ZjohnkFlash-based charts missing in Chrome because the "click to enable" button is not visible on the pageJust go to Contributions Dashboard in Chrome. Charts do not show up. The issue is that in the default mode for Chrome, there should be a "click to enable" button coming up, but this chart or its javascript is in some way not compatible.
...Just go to Contributions Dashboard in Chrome. Charts do not show up. The issue is that in the default mode for Chrome, there should be a "click to enable" button coming up, but this chart or its javascript is in some way not compatible.
There is a well known workaround of manually enabling Flash for the site, which I've instructed our staff on. I still thought I'd open it as an issue. This Chrome-specific regression may be due to the use of SWFObject; see #270.
The Contributions chart is one of the best ways of showcasing all the hard work of setting up and importing data into ones fancy new CRM! So it's kind of a bummer to have the Chrome bug right there, is all.5.20.0https://lab.civicrm.org/dev/core/-/issues/1707Flemish missing from list of languages2020-04-15T17:13:30ZspalmstromFlemish missing from list of languagesOverview
----------------------------------------
It appears that the Flemish language (nl_BE), though in the localisation files, is missing from the list of languages in the database. This gives rise to this Notice:
[13-Apr-2020 10:44...Overview
----------------------------------------
It appears that the Flemish language (nl_BE), though in the localisation files, is missing from the list of languages in the database. This gives rise to this Notice:
[13-Apr-2020 10:44:40 Europe/Dublin] PHP Notice: Undefined index: nl_BE in .../CRM/Core/I18n.php on line 196
Reproduction steps
----------------------------------------
Run CiviCRM.
Current behaviour
----------------------------------------
```
[13-Apr-2020 10:44:40 Europe/Dublin] PHP Notice: Undefined index: nl_BE in .../CRM/Core/I18n.php on line 196
in the PHP log file
Expected behaviour
----------------------------------------
_What should happen._
Nothing
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is necessary. -->
Seen in both Joomla and Drupal.
Comments
----------------------------------------
_Anything else you would like the reviewer to note._
Cured by running this script against the database.
INSERT INTO `<database>`.`civicrm_option_value` (`option_group_id`, `value`, `name`, `is_default`, `weight`, `is_optgroup`, `is_reserved`, `is_active`, `label_en_GB`) VALUES ('69', 'nl', 'nl_BE', '0', '194', '0', '0', '1', 'Flemish');https://lab.civicrm.org/dev/core/-/issues/4070FlexMailer: Default Return Path not respected2023-02-27T13:47:09ZJonGoldFlexMailer: Default Return Path not respectedIn **Administer » CiviMail » Mail Accounts**, you can specify a default return path for your CiviMail mailings. This is important when, for instance, your bounce address's mailhost does not support VERP. This forces the `Return-Path` h...In **Administer » CiviMail » Mail Accounts**, you can specify a default return path for your CiviMail mailings. This is important when, for instance, your bounce address's mailhost does not support VERP. This forces the `Return-Path` header to a specific email address. The bounce processing code will find the `X-CiviMail-Bounce` header and process that instead of the bounce address.
However, this functionality was not ported to Flexmailer. You can see it at the very top of `CRM_Utils_Mail::send()` but not in `Civi\FlexMailer\Listener\BounceTracker::onCompose()`.
This causes the return-path to have the VERP address.JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/3473Follow-up on Regression #3464 impacting Schedule Reminders - Clear the Group ...2024-01-30T05:03:23Zjustinfreeman (Agileware)Follow-up on Regression #3464 impacting Schedule Reminders - Clear the Group field on Scheduled Reminders if it Limit To option is "Neither"Follow-up on Regression #3464 impacting Schedule Reminders - Clear the Group field on Scheduled Reminders if it Limit To option is "Neither".
Follow-up on this regression in CiviCRM https://lab.civicrm.org/dev/core/-/issues/3464#note_74...Follow-up on Regression #3464 impacting Schedule Reminders - Clear the Group field on Scheduled Reminders if it Limit To option is "Neither".
Follow-up on this regression in CiviCRM https://lab.civicrm.org/dev/core/-/issues/3464#note_74627
Change the logic on the Scheduled Reminder form to remove the value of the Group ID field on save if the limit_to value is "1".
If this had been implemented in the first place, the impact of this bug, https://lab.civicrm.org/dev/core/-/issues/3464 would have been mitigated. And would have very likely not required any remediation reverts:
https://github.com/civicrm/civicrm-core/pull/23490
https://github.com/civicrm/civicrm-core/pull/23497
WIP PR #23487 is available here, https://github.com/civicrm/civicrm-core/pull/23487
@eileen @monish.deb
Agileware Ref: CIVICRM-1986https://lab.civicrm.org/dev/core/-/issues/2941Follow-up task - Remove the CiviCRM Connections functionality from CiviCRM co...2024-03-21T05:03:26Zjustinfreeman (Agileware)Follow-up task - Remove the CiviCRM Connections functionality from CiviCRM core (Task 2 of 2) - Remove the codeThis is a follow-up task to https://lab.civicrm.org/dev/core/-/issues/2910 - which was changed to only remove the menu item from the menu as an intermediary step.
To complete this work, this task will remove the CiviCRM Connections func...This is a follow-up task to https://lab.civicrm.org/dev/core/-/issues/2910 - which was changed to only remove the menu item from the menu as an intermediary step.
To complete this work, this task will remove the CiviCRM Connections functionality from CiviCRM core. This concept was already approved on https://lab.civicrm.org/dev/core/-/issues/2910
Agileware Ref: CIVIBLD-286https://lab.civicrm.org/dev/core/-/issues/1070For CiviCRM v4 API, I would like to resurrect the discussion to remove the de...2019-06-25T13:05:13Zjustinfreeman (Agileware)For CiviCRM v4 API, I would like to resurrect the discussion to remove the default limit of 25 from the APIFor CiviCRM v4 API, I would like to resurrect the discussion to remove the default limit of 25 from the API.
The default limit of 25 is problematic because it is unexpected - not explicitly defined in the API call. So new developers are...For CiviCRM v4 API, I would like to resurrect the discussion to remove the default limit of 25 from the API.
The default limit of 25 is problematic because it is unexpected - not explicitly defined in the API call. So new developers are caught unaware of this limit when testing their code on small test data sets. When moving to a production environment, the default limit then appears and causes problems. We've seen this issue affect both new and seasoned CiviCRM developers.
I found this old discussion thread over here with familiar faces, https://forum.civicrm.org/index.php%3Ftopic=26854.0.html
This is a developer improvement similar to #1062
Agileware Ref: CIVICRM-1253https://lab.civicrm.org/dev/core/-/issues/2149For countries without a province N/A is not accepted as a state in a profile2020-11-01T21:07:07ZStoobFor countries without a province N/A is not accepted as a state in a profileTake for example Singapore or Monaco.
A form can be submitted for the Billing Block with these Countries without a State (N/A is selected) but the same is not true for a Profile.
The attachment will illustrate.
[singapore-profile.pdf]...Take for example Singapore or Monaco.
A form can be submitted for the Billing Block with these Countries without a State (N/A is selected) but the same is not true for a Profile.
The attachment will illustrate.
[singapore-profile.pdf](/uploads/5c0f195c42c2df4329ff9a05f9559728/singapore-profile.pdf)
![singapore](/uploads/5c06891671559b82319a663823794802/singapore.png)5.31.0https://lab.civicrm.org/dev/core/-/issues/724For many countries other than USA, state is displayed as a number instead of ...2023-11-17T05:03:23ZIan KellingFor many countries other than USA, state is displayed as a number instead of a stringRepro:
Go to https://civicrm.demo.civihosting.com which is running 5.10.0 when
I tested this. Create a new contact, add an address in japan, choose a
state from the drop down box and click save. Then view the contact. In the state field,...Repro:
Go to https://civicrm.demo.civihosting.com which is running 5.10.0 when
I tested this. Create a new contact, add an address in japan, choose a
state from the drop down box and click save. Then view the contact. In the state field,
you will see a number instead of a state name. This seems to happen with
many countries.
We printed mailing labels that had numbers instead of the state names
and we don't know how many were or were not delivered. Please consider
this a high priority bug.https://lab.civicrm.org/dev/core/-/issues/28For repeating Events, the absolute Registration Start / End date is transferr...2023-04-28T01:39:33Zjustinfreeman (Agileware)For repeating Events, the absolute Registration Start / End date is transferred to each of the repeated events which causes future events to be closed for sign-ups on creationFor repeating Events, the absolute Registration Start / End date is transferred to each of the repeated events which causes future events to be closed for sign-ups on creation.
The fields are:
Registration Start Date / Time
Registration...For repeating Events, the absolute Registration Start / End date is transferred to each of the repeated events which causes future events to be closed for sign-ups on creation.
The fields are:
Registration Start Date / Time
Registration End Date / Time
It makes more sense for repeating events, that these dates need to be set relative to the event date.
This could be an overall enhancement to make these date fields relative for all events, not just repeating. Which would make more sense. Especially since that applies also to copying an event as well as setting up a repeating event.
As it stands now, repeating events with Registration Start and Registration End need to be manually updated after creation. Otherwise, no one can register for those events.
Agileware Ref: CIVICRM-841https://lab.civicrm.org/dev/core/-/issues/3063Foreign constraint violation on APIv3 contribution create if financial_type_i...2022-02-16T21:27:08ZIan WilsonForeign constraint violation on APIv3 contribution create if financial_type_id is numericOverview
----------------------------------------
We have a lot of numeric financial types. On the new ESR (and also the dmaster site), attempts to create contributions via APIv3 are failing.
Reproduction steps
-------------------------...Overview
----------------------------------------
We have a lot of numeric financial types. On the new ESR (and also the dmaster site), attempts to create contributions via APIv3 are failing.
Reproduction steps
----------------------------------------
1. Go to /civicrm/api3/#explorer
1. Select "FinancialType" for entity and "create" for action.
1. Fill in a numeric value (e.g. 1234) for Financial Type Value and click Execute.
1. Reload the page.
1. Select "Contribution" for entity and "create" for action.
1. Select your newly created Financial Type ID from the list and fill in anything for other values.
1. Click Execute.
Current behaviour
----------------------------------------
The financial_type_id parameter accepts the financial type name (e.g. "Event Fee"). However, if the provided value is a number, it appears that the resulting SQL query attempts to use the number directly instead of looking up the associated key.
On the dmaster website the following query (via APIv3 explorer):
```php
$result = civicrm_api3('Contribution', 'create', [
'financial_type_id' => 1234,
'receive_date' => "2022-02-08",
'total_amount' => 50,
'contact_id' => "user_contact_id",
]);
```
produces the following result:
```json
{
"code": -3,
"error_message": "DB Error: constraint violation",
"mode": 16,
"debug_info": "INSERT INTO `civicrm_contribution` (`contact_id` , `financial_type_id` , `payment_instrument_id` , `receive_date` , `total_amount` , `fee_amount` , `net_amount` , `currency` , `contribution_status_id` , `tax_amount` ) VALUES ( 204 , 1234 , 4 , 20220208000000 , 50 , 0 , 50 , 'USD' , 1 , 0 ) [nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`dmastercivi_g5lis`.`civicrm_contribution`, CONSTRAINT `FK_civicrm_contribution_financial_type_id` FOREIGN KEY (`financial_type_id`) REFERENCES `civicrm_financial_type` (`id`))]",
"type": "DB_Error",
"user_info": "INSERT INTO `civicrm_contribution` (`contact_id` , `financial_type_id` , `payment_instrument_id` , `receive_date` , `total_amount` , `fee_amount` , `net_amount` , `currency` , `contribution_status_id` , `tax_amount` ) VALUES ( 204 , 1234 , 4 , 20220208000000 , 50 , 0 , 50 , 'USD' , 1 , 0 ) [nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`dmastercivi_g5lis`.`civicrm_contribution`, CONSTRAINT `FK_civicrm_contribution_financial_type_id` FOREIGN KEY (`financial_type_id`) REFERENCES `civicrm_financial_type` (`id`))]",
"to_string": "[db_error: message=\"DB Error: constraint violation\" code=-3 mode=callback callback=CRM_Utils_REST::fatal prefix=\"\" info=\"INSERT INTO `civicrm_contribution` (`contact_id` , `financial_type_id` , `payment_instrument_id` , `receive_date` , `total_amount` , `fee_amount` , `net_amount` , `currency` , `contribution_status_id` , `tax_amount` ) VALUES ( 204 , 1234 , 4 , 20220208000000 , 50 , 0 , 50 , 'USD' , 1 , 0 ) [nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`dmastercivi_g5lis`.`civicrm_contribution`, CONSTRAINT `FK_civicrm_contribution_financial_type_id` FOREIGN KEY (`financial_type_id`) REFERENCES `civicrm_financial_type` (`id`))]\"]",
"is_error": 1
}
```
Using a text value produces a similar example query:
```php
$result = civicrm_api3('Contribution', 'create', [
'financial_type_id' => "Event Fee",
'receive_date' => "2022-02-08",
'total_amount' => 50,
'contact_id' => "user_contact_id",
]);
```
and the result is successful:
```json
{
"is_error": 0,
"version": 3,
"count": 1,
"id": 116,
"values": {
"116": {
"id": "116",
"contact_id": "204",
"financial_type_id": "4",
"contribution_page_id": "",
"payment_instrument_id": "4",
"receive_date": "20220208000000",
"non_deductible_amount": "",
"total_amount": "50",
"fee_amount": "0",
"net_amount": "50",
"trxn_id": "",
"invoice_id": "",
"invoice_number": "",
"currency": "USD",
"cancel_date": "",
"cancel_reason": "",
"receipt_date": "",
"thankyou_date": "",
"source": "",
"amount_level": "",
"contribution_recur_id": "",
"is_test": "",
"is_pay_later": "",
"contribution_status_id": "1",
"address_id": "",
"check_number": "",
"campaign_id": "",
"creditnote_id": "",
"tax_amount": "0",
"revenue_recognition_date": "",
"is_template": "",
"contribution_type_id": "4"
}
}
}
```
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.45.35.46.2https://lab.civicrm.org/dev/core/-/issues/3036Form Builder (afform-admin) requires search_kit in 5.45 causing crash if you ...2022-03-01T00:32:23ZDaveDForm Builder (afform-admin) requires search_kit in 5.45 causing crash if you have Form Builder installed but not search kit before upgradingOne option is force install search kit during upgrade if form builder is installed. Pros and cons to that.
Another option is form builder disable itself during upgrade if search kit is not installed. Also pros and cons.
Another is a pr...One option is force install search kit during upgrade if form builder is installed. Pros and cons to that.
Another option is form builder disable itself during upgrade if search kit is not installed. Also pros and cons.
Another is a pre-upgrade message warning of the issue and what they can do (install search kit or disable afform-admin).
Another is make form builder more tolerant of missing search kit, but it seems like the extension system itself is also looking at the dependency and expecting it to be there.
https://civicrm.stackexchange.com/questions/41044/error-class-crm-search-upgrader-not-found-since-upgrading-to-5-45-1-joomla
and
https://civicrm.stackexchange.com/questions/41068/error-class-crm-search-upgrader-not-found-since-upgrading-civicrm-to-5-45-1-on/41084#410845.45.2https://lab.civicrm.org/dev/core/-/issues/4138Form Builder - autocomplete input does not use configured filtering2023-02-28T20:17:23ZFrancis (Agileware)Form Builder - autocomplete input does not use configured filteringOverview
----------------------------------------
In the Form Builder (afform/admin), there is an option to filter autocomplete inputs by an existing saved search / autocomplete display, where appears to do no actual filtering
Reproduct...Overview
----------------------------------------
In the Form Builder (afform/admin), there is an option to filter autocomplete inputs by an existing saved search / autocomplete display, where appears to do no actual filtering
Reproduction steps
----------------------------------------
Confirmed on wpmaster (5.60-alpha1)
1. Enable Form Builder extension
2. Go to SearchKit
3. Create a search for Events that filters by type (e.g. Fundraiser), add an Autocomplete display to it and save
4. Go back to SearchKit and create another search for Participants
5. Add a required "Participant Event" (this step may not be necessary)
6. Add a Table display and save.
7. using the form drop-down, create a new form for your results table
8. Add a filter for the results table, Participant / Event field
9. Configure the field to use the saved search and autocomplete display from step (3)
10. Save the form and go to its display page
11. start searching for events (using the sample data, just entering the letter S is sufficient)
Current behaviour
----------------------------------------
The Autocomplete field gives you to option of selecting any event on the system. Looking in the network requests, it appears that the search and display are not passed into the API4 endpoint at all.
Expected behaviour
----------------------------------------
The Autocomplete field should give you **only** options that match the filter specified in step 3.
Environment information
----------------------------------------
* __Browser:__ Firefox 109 (also happens on Chrome)
* __CiviCRM:__ 5.57.0, 5.58.1, 5.60-alpha / Master
Occurs on wpmaster.demo.civicrm.org
Comments
----------------------------------------
Example configurations:
Autocomplete (Events) search:
```json
[
[
"SavedSearch",
"save",
{
"records": [
{
"name": "Fundraiser_events",
"label": "Fundraiser events",
"form_values": null,
"mapping_id": null,
"search_custom_id": null,
"api_entity": "Event",
"api_params": {
"version": 4,
"select": [
"id",
"title",
"event_type_id:label"
],
"orderBy": [],
"where": [
[
"event_type_id:name",
"=",
"Fundraiser"
]
],
"groupBy": [],
"join": [],
"having": []
},
"expires_date": null,
"description": null
}
],
"match": [
"name"
]
}
],
[
"SearchDisplay",
"save",
{
"records": [
{
"name": "Fundraiser_events_Autocomplete_1",
"label": "Fundraiser events Autocomplete 1",
"saved_search_id.name": "Fundraiser_events",
"type": "autocomplete",
"settings": {
"sort": [],
"columns": [
{
"type": "field",
"key": "title",
"dataType": "String"
}
]
},
"acl_bypass": false
}
],
"match": [
"name",
"saved_search_id"
]
}
]
]
```
Participant search and form:
```json
[
[
"SavedSearch",
"save",
{
"records": [
{
"name": "Fundraiser_Participants",
"label": "Fundraiser Participants",
"form_values": null,
"mapping_id": null,
"search_custom_id": null,
"api_entity": "Participant",
"api_params": {
"version": 4,
"select": [
"id",
"contact_id.display_name",
"Participant_Event_event_id_01.title",
"Participant_Event_event_id_01.event_type_id:label"
],
"orderBy": [],
"where": [],
"groupBy": [],
"join": [
[
"Event AS Participant_Event_event_id_01",
"INNER",
[
"event_id",
"=",
"Participant_Event_event_id_01.id"
]
]
],
"having": []
},
"expires_date": null,
"description": null
}
],
"match": [
"name"
]
}
],
[
"SearchDisplay",
"save",
{
"records": [
{
"name": "Fundraiser_Participants_Table",
"label": "Fundraiser Participants Table",
"saved_search_id.name": "Fundraiser_Participants",
"type": "table",
"settings": {
"description": null,
"sort": [],
"limit": 50,
"pager": [],
"placeholder": 5,
"columns": [
{
"type": "field",
"key": "contact_id.display_name",
"dataType": "String",
"label": "Contact",
"sortable": true,
"link": {
"path": "",
"entity": "Contact",
"action": "view",
"join": "contact_id",
"target": "_blank"
},
"title": "View Contact"
},
{
"type": "field",
"key": "Participant_Event_event_id_01.title",
"dataType": "String",
"label": "Event",
"sortable": true,
"link": {
"path": "",
"entity": "Event",
"action": "view",
"join": "Participant_Event_event_id_01",
"target": "crm-popup"
},
"title": "View Participant Event"
},
{
"type": "field",
"key": "Participant_Event_event_id_01.event_type_id:label",
"dataType": "Integer",
"label": "Event Type",
"sortable": true
}
],
"actions": true,
"classes": [
"table",
"table-striped"
]
},
"acl_bypass": false
}
],
"match": [
"name",
"saved_search_id"
]
}
],
[
"Afform",
"save",
{
"records": [
{
"name": "afsearchFindFundraiserParticipants",
"requires": [],
"title": "Find Fundraiser Participants",
"description": "",
"is_dashlet": false,
"is_public": false,
"is_token": false,
"permission": "view event participants",
"type": "search",
"icon": "fa-list-alt",
"server_route": "civicrm/fundraiser-participants",
"entity_type": null,
"join_entity": null,
"contact_summary": null,
"summary_contact_type": null,
"redirect": null,
"create_submission": null,
"navigation": null,
"layout": "<div af-fieldset=\"\">\n <af-field name=\"event_id\" defn=\"{saved_search: 'Fundraiser_events', input_attrs: {multiple: true}, search_display: 'Fundraiser_events_Autocomplete_1'}\" />\n <crm-search-display-table search-name=\"Fundraiser_Participants\" display-name=\"Fundraiser_Participants_Table\"></crm-search-display-table>\n</div>\n"
}
]
}
]
]
```
Agileware ref CIVICRM-2101https://lab.civicrm.org/dev/core/-/issues/3729Form Builder doesn't use dedupe2023-02-16T22:18:18ZJonGoldForm Builder doesn't use dedupeIdeally Form Builder would allow you to select a dedupe rule on a per-contact basis, but on a basic level contacts should get deduped.Ideally Form Builder would allow you to select a dedupe rule on a per-contact basis, but on a basic level contacts should get deduped.https://lab.civicrm.org/dev/core/-/issues/3690Form Builder/Search Kit: Date filters do not work when picking dates2022-09-03T14:27:07ZJonGoldForm Builder/Search Kit: Date filters do not work when picking datesWhen creating a Form Builder form based on a Search Kit, the "Receive Date" filter doesn't work if you use "Pick Date".
### Steps to Replicate
* Create a SK that groups Contributions by Financial Type, and displays a count of IDs and a ...When creating a Form Builder form based on a Search Kit, the "Receive Date" filter doesn't work if you use "Pick Date".
### Steps to Replicate
* Create a SK that groups Contributions by Financial Type, and displays a count of IDs and a sum of Total Amount. Screenshot and exported SK are below.
* Embed the search in a Form Builder form, and add a "Date Received" filter. Screenshot and afform markup below.
* Use the form to filter by *Date Received* is **This calendar year**. Observe that it filters correctly.
* Change the *Date Received* to **Choose Date Range** and select 1/1/2022-12/31/2022 (or just 1/1/2022-today).
### Expected Result
Same as filtering by "This calendar year".
![Selection_1547](/uploads/55fa1017e814c8d80fb0071eb75eee49/Selection_1547.png)
### Actual Result
Date filter is ignored.
![Selection_1548](/uploads/bb092e9b7871e36fae3a385df6c68a72/Selection_1548.png)
#### Search Kit
![Selection_1545](/uploads/0aeaa229651b9a46e24c1aff105727e7/Selection_1545.png)
```
[
{
"name": "SavedSearch_date_test",
"entity": "SavedSearch",
"cleanup": "unused",
"update": "unmodified",
"params": {
"version": 4,
"values": {
"name": "date_test",
"label": "date test",
"form_values": null,
"mapping_id": null,
"search_custom_id": null,
"api_entity": "Contribution",
"api_params": {
"version": 4,
"select": [
"COUNT(id) AS COUNT_id",
"SUM(total_amount) AS SUM_total_amount"
],
"orderBy": [],
"where": [],
"groupBy": [
"financial_type_id"
],
"join": [],
"having": []
},
"expires_date": null,
"description": null
}
}
}
]
```
#### Form Builder
![Selection_1546](/uploads/333e237b15b1c16742d67c40cf453d7c/Selection_1546.png)
```
<div af-fieldset="">
<af-field name="receive_date" defn="{input_type: 'Select', search_range: true, input_attrs: {}}" />
<crm-search-display-table search-name="date_test" display-name=""></crm-search-display-table>
</div>
```colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/3897Form Builder: 'Show totals in footer' doesn't work with multiple displays on ...2023-12-30T21:10:37ZAndrew WestForm Builder: 'Show totals in footer' doesn't work with multiple displays on a formOverview
----------------------------------------
Total rows don't work when there are multiple displays on a single form, each containing a total row. It seems to calculate a single value and show it for all displays. No console errors....Overview
----------------------------------------
Total rows don't work when there are multiple displays on a single form, each containing a total row. It seems to calculate a single value and show it for all displays. No console errors.
Reproduction steps
----------------------------------------
1. Create 2 search displays with totals ([Example 1](https://wpmaster.demo.civicrm.org/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsearch#/create/Contact?params=%7B%22version%22:4,%22select%22:%5B%22id%22,%22display_name%22%5D,%22orderBy%22:%5B%5D,%22where%22:%5B%5B%22contact_type:name%22,%22%3D%22,%22Individual%22%5D,%5B%22age_years%22,%22IS%20EMPTY%22%5D%5D,%22groupBy%22:%5B%5D,%22join%22:%5B%5D,%22having%22:%5B%5D%7D), [Example 2](https://wpmaster.demo.civicrm.org/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsearch#/create/Contact?params=%7B%22version%22:4,%22select%22:%5B%22id%22,%22display_name%22%5D,%22orderBy%22:%5B%5D,%22where%22:%5B%5B%22age_years%22,%22%3E%22,5%5D%5D,%22groupBy%22:%5B%5D,%22join%22:%5B%5D,%22having%22:%5B%5D%7D)).
2. Create Table displays for them both, making sure to tick 'Show totals in footer'
3. Add them both to a form
[Here's an example](https://wpmaster.demo.civicrm.org/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Ftest%2Ftotals) - at least until the WP database resets.
Environment information
----------------------------------------
Tested on WP master.colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/3425form builder: contact reference field does not respect configuration2022-11-12T15:27:08Zlcdwebform builder: contact reference field does not respect configurationI ran into an issue with the following setup:
- created an activity type with a corresponding custom data set.
- created a custom data field of type contact reference, and used the advanced filter to limit it by contact type and sub typ...I ran into an issue with the following setup:
- created an activity type with a corresponding custom data set.
- created a custom data field of type contact reference, and used the advanced filter to limit it by contact type and sub type
- created a form to create an activity of this type. included the contact ref field in the form.
When the form is loaded, the contact reference field pulls all contacts -- ignoring the advanced filters.https://lab.civicrm.org/dev/core/-/issues/3122Form Builder: Deleting a form with a corresponding dashboard breaks the dashb...2022-03-22T17:07:09ZJonGoldForm Builder: Deleting a form with a corresponding dashboard breaks the dashboardOverview
----------------------------------------
Deleting a Form Builder form that has a corresponding `civicrm_dashboard` entry doesn't delete the `civicrm_dashboard` entry, resulting in a broken dashboard.
Reproduction steps
--------...Overview
----------------------------------------
Deleting a Form Builder form that has a corresponding `civicrm_dashboard` entry doesn't delete the `civicrm_dashboard` entry, resulting in a broken dashboard.
Reproduction steps
----------------------------------------
1. Create a search in Search Kit.
1. Create a corresponding Search Form.
1. Delete the search. Get the message `Form "%1" will also be deleted because it contains an embedded display from this search.`
1. Visit your dashboard.
Current behaviour
----------------------------------------
Drupal WSOD in one instance (D9), dashboard is completely missing in another (D7).
Expected behaviour
----------------------------------------
Deleting the Form should delete the dashboard entry just as deleting the search deletes the form.colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/3426form builder: edited labels result in visible markup on public display2024-01-19T05:03:24Zmegaphonetech-dennisform builder: edited labels result in visible markup on public displayWhen I created a form using Form Builder, edited a label, and then viewed the results as a standalone webpage, the edited labels unexpectedly displayed markup, which I believe to be a bug.
1. I created at Form Builder form at https://dm...When I created a form using Form Builder, edited a label, and then viewed the results as a standalone webpage, the edited labels unexpectedly displayed markup, which I believe to be a bug.
1. I created at Form Builder form at https://dmaster.demo.civicrm.org, titled *Form Title Here*, located at https://dmaster.demo.civicrm.org/civicrm/form-title-here
1. I exposed the form as a standalone webpage, by entering *civicrm/form-title-here* into the field, *Page*, located under **form settings > Placement**
1. I added a few fields associated with an organization contact to my form. These included a fieldset which contained an address block, as well as a *supplemental address 1* field.
1. I edited the labels for *Street Address* and *Supplemental Address 1* fields.
1. I viewed the form at https://dmaster.demo.civicrm.org/civicrm/form-title-here and found markup displayed along with the label. See screenshot.
![Screenshot_from_2022-04-26_17-22-28](/uploads/cadd27624aba5b9e23156fa3d2991178/Screenshot_from_2022-04-26_17-22-28.png)
Here is my form's markup
```
<af-form ctrl="afform">
<af-entity data="{contact_type: 'Organization', source: 'Form Title Here'}" type="Contact" name="Organization1" label="Organization 1" actions="{create: true, update: true}" security="RBAC" />
<fieldset af-fieldset="Organization1" class="af-container" af-title="Org 1">
<div af-join="Address" af-repeat="Add" min="1">
<div class="af-container af-layout-inline">
<af-field name="street_address" defn="{label: '<span class="ng-pristine ng-untouched ng-valid ng-binding ng-isolate-scope ng-not-empty" contenteditable="true">Street Address 1</span>', input_attrs: {}}" />
<af-field name="supplemental_address_1" defn="{label: 'Street Address 2', input_attrs: {}}" />
</div>
<div class="af-container af-layout-inline">
<af-field name="city" />
<af-field name="country_id" defn="{afform_default: '1228', input_attrs: {}}" />
<af-field name="state_province_id" />
<af-field name="postal_code" />
</div>
</div>
</fieldset>
<button class="af-button btn btn-primary" crm-icon="fa-check" ng-click="afform.submit()">Submit</button>
</af-form>
```https://lab.civicrm.org/dev/core/-/issues/3748Form Builder: Exceptions don't bubble up2024-03-16T05:03:27ZJonGoldForm Builder: Exceptions don't bubble upIf you submit a form that causes the underlying CRUD API to return an error, the error isn't recorded anywhere, displayed on screen, etc. You can replicate this by creating a FB form for an individual and submitting it without entering ...If you submit a form that causes the underlying CRUD API to return an error, the error isn't recorded anywhere, displayed on screen, etc. You can replicate this by creating a FB form for an individual and submitting it without entering any values.
The relevant code comment says:
> // What to do here? Sometimes we should silently ignore errors, e.g. an optional entity
intentionally left blank. Other times it's a real error the user should know about.
But a few lines above, we say:
```
if (empty($record['fields'])) {
continue;
}
```
So I'm guessing that comment predates the `if` statement, since blank entities shouldn't get saved. So I think we should always be notifying the user.
In addition to showing a message on screen, I think errors should be saved to the AfformSubmission record, that's a killer feature that would make troubleshooting form submission errors in production much easier than Webform.https://lab.civicrm.org/dev/core/-/issues/3743Form Builder: Load contact summary blocks on Print Summary page2024-03-16T05:03:26ZJonGoldForm Builder: Load contact summary blocks on Print Summary page### Replication Steps
* Create a Search Kit search and corresponding Form Builder form.
* Check the box indicating the FB form should appear as a block on the contact summary.
* Go to a contact and select **Actions menu » Print Summary**...### Replication Steps
* Create a Search Kit search and corresponding Form Builder form.
* Check the box indicating the FB form should appear as a block on the contact summary.
* Go to a contact and select **Actions menu » Print Summary**.
### Expected Result
Print Summary includes the FB block
### Actual Result
Nope.
I have a partial fix - I can load the block, but only if someone cancels the initial `window.print()`. I'm not sure how best to tackle the issue otherwise. I don't know that there's a way to delay the print until all the blocks load - if there is, that's ideal.JonGoldJonGold