Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-08-23T05:03:20Zhttps://lab.civicrm.org/dev/core/-/issues/1746Updating option value, doesn't update custom data for single select custom fi...2023-08-23T05:03:20ZMonish DebUpdating option value, doesn't update custom data for single select custom fields
Reproduction steps
----------------------------------------
1. Go to CiviCRM >> Administer >> Customize Data and Screens >> Go to any single select custom field (html type - Select/Radio). **.
1. Click on 'Edit Multiple Choice Options' ...
Reproduction steps
----------------------------------------
1. Go to CiviCRM >> Administer >> Customize Data and Screens >> Go to any single select custom field (html type - Select/Radio). **.
1. Click on 'Edit Multiple Choice Options' and change the value.
1. Go to view page of the CiviCRM component and check if the custom field value is changed or not
Current behavior
----------------------------------------
I have used 'How long have you been a donor?' custom field for Contribtuion to present this demo. At the end you will find that value doesn't get updated on the contribution.
![before](/uploads/83e58ff3636c6737f1ac1b9b0fc08edd/before.gif)
Expected behaviour
----------------------------------------
It should update the custom data too. This is not an issue for mult-select custom fields.
Environment information
----------------------------------------
* __CiviCRM:__ _Master5.25.0Monish DebMonish Debhttps://lab.civicrm.org/dev/drupal/-/issues/120Drupal 8 - TypeError: Argument 1 passed to civicrm_api() must be of the type ...2020-05-07T09:19:34ZRar9Drupal 8 - TypeError: Argument 1 passed to civicrm_api() must be of the type stringCurrently I'm getting this error not allowing me to add any new element to webforms
Drupal Version 8.8.5
PHP 7.3.17
civicrm 5.25.0
webform 5.11
webform_civicrm 5.x-dev
TypeError: Argument 1 passed to civicrm_api() must be of the type...Currently I'm getting this error not allowing me to add any new element to webforms
Drupal Version 8.8.5
PHP 7.3.17
civicrm 5.25.0
webform 5.11
webform_civicrm 5.x-dev
TypeError: Argument 1 passed to civicrm_api() must be of the type string, null given, called in /var/www/vhosts/xx/httpdocs/web/modules/contrib/webform_civicrm/includes/utils.inc on line 532 in civicrm_api() (line 21 of /var/www/vhosts/xx/httpdocs/vendor/civicrm/civicrm-core/api/api.php)
Drupal logs also shows
Notice: Undefined index: #form_key in Drupal\webform_civicrm\Plugin\WebformElement\CivicrmSelect->getFieldOptions() (line 85 of /var/www/vhosts/xx/httpdocs/web/modules/contrib/webform_civicrm/src/Plugin/WebformElement/CivicrmSelect.php).
Notice: Undefined offset: 1 in Drupal\webform_civicrm\Plugin\WebformElement\CivicrmContact->prepare() (line 107 of /var/www/vhosts/xx/httpdocs/web/modules/contrib/webform_civicrm/src/Plugin/WebformElement/CivicrmContact.php).https://lab.civicrm.org/dev/core/-/issues/1747Regression: Fails to create smartgroup or refresh count of group2020-06-02T01:16:03ZPradeep Nayakpradpnayak@gmail.comRegression: Fails to create smartgroup or refresh count of groupOverview
----------------------------------------
Since upgrading to 5.24 creating smart group using 'Date Added to CiviCRM' fails with DB Error: no such table. Also when a smart group is based on 'Date Added to CiviCRM' and try to refre...Overview
----------------------------------------
Since upgrading to 5.24 creating smart group using 'Date Added to CiviCRM' fails with DB Error: no such table. Also when a smart group is based on 'Date Added to CiviCRM' and try to refresh the count it fails with same error message
Reproduction steps
----------------------------------------
1. Navigate to CiviCRM >> Search >> Custom Searches >> Date Added to CiviCRM
1. Do a search on date and include in group.
1. Select all contact and try adding to smart group.
1. Got an error "**Fatal error: DB error**".
![smartGroupError](/uploads/3ea50e38bccd47141831b4990f6f6b0a/smartGroupError.gif)
Current behaviour
----------------------------------------
Get DB error 'Database Error Code: Table 'dmastercivi_g5lis.civicrm_tmp_e_ig_6f1e2d3b300d50a856f5cb9140996451' doesn't exist, 1146' when trying to create smart group or refresh count
Expected behaviour
----------------------------------------
smart should be created with correct contacts in it and also when refreshing the group count, the group should show correct count
Environment information
----------------------------------------
https://dmaster.demo.civicrm.org/5.26.0https://lab.civicrm.org/dev/wordpress/-/issues/50Upgrade to 5.25.0 failed with CiviCRM WP REST API plugin installed2020-05-14T23:21:36ZMWestergaardUpgrade to 5.25.0 failed with CiviCRM WP REST API plugin installedAttempted upgrade to 5.25.0 on Wordpress dev box. Failed with "Fatal error: Cannot declare class CiviCRM_WP_REST\Autoloader, because the name is already in use in /var/www/html/wp-content/plugins/civicrm-wp-rest-master/src/Autoloader.php...Attempted upgrade to 5.25.0 on Wordpress dev box. Failed with "Fatal error: Cannot declare class CiviCRM_WP_REST\Autoloader, because the name is already in use in /var/www/html/wp-content/plugins/civicrm-wp-rest-master/src/Autoloader.php on line 10". Removed "CiviCRM WP REST API" plugin and successfully restarted upgrade.kcristianokcristianohttps://lab.civicrm.org/dev/core/-/issues/1748Set a default ordering for `get` APIs2023-03-11T05:03:19ZtottenSet a default ordering for `get` APIsOverview
----------------------------------------
In SQL/MySQL, `SELECT` queries accept an option `ORDER BY`. If the option is not given, then the DBMS can choose an arbitrary ordering -- although, *most of the time*, it's a facsimile o...Overview
----------------------------------------
In SQL/MySQL, `SELECT` queries accept an option `ORDER BY`. If the option is not given, then the DBMS can choose an arbitrary ordering -- although, *most of the time*, it's a facsimile of `ORDER BY id`. This creates a false expectation of ordering. This behavior has a knock-on effect - it also applies to API requests.
Example use-case
----------------------------------------
```php
civicrm_api3('Contact', 'get', []);
civicrm_api3('Dedupe', 'get', []);
civicrm_api4('Group', 'get', []);
civicrm_api4('Activity', 'get', []);
```
Current behaviour
----------------------------------------
In absence of an explicit `orderBy` / `sort` option, the `get` API relies on the DBMS's default ordering... which *usually* returns records in order of ID/creation, but it *sometimes* returns records with an arbitrary ordering.
Proposed behaviour
----------------------------------------
In the absence of an explicit `orderBy` / `sort` option, the `get` API should set `ORDER BY id` (*provided that `id` is a sensible column for the given query*).
This makes the actual behavior align reliably with the typical/expected behavior.
Comments
----------------------------------------
A person looking at a typical result-set (esp on a developmental system, with its synthetic data) can incorrectly infer that records are being returned in a sensible order. But they're not - and the misunderstanding can lead to subtle bugs that are difficult to reproduce. (Ex: `SyntaxConformanceTest::testSqlOperators()` has been flaky for a long time and ultimately needed a [patch to use explicit ordering](https://github.com/civicrm/civicrm-core/pull/17251). We only diagnosed the bug by luck -- it was easy to reproduce with one particular entity on one particular version of MySQL.)
Setting the default is a systemic way to prevent this class of bug.https://lab.civicrm.org/dev/core/-/issues/1749whom_url missing contact ID parameter in detailed logging report2020-07-06T17:39:05Zdomwhom_url missing contact ID parameter in detailed logging reportIn the Logging Details view (linked as "Update" in the "Contact Logging Report") the `cid` parameter in the link to the contact that's been modified is unset. Reproduced on 5.25.0 and 5.27.alpha1 (dmaster.demo.civicrm.org). To reproduce:...In the Logging Details view (linked as "Update" in the "Contact Logging Report") the `cid` parameter in the link to the contact that's been modified is unset. Reproduced on 5.25.0 and 5.27.alpha1 (dmaster.demo.civicrm.org). To reproduce:
* Enable detailed logging (Administer -> System Settings -> Misc -> Logging -> Yes)
* Create a test contact and fill in at least a name and email address
* Visit the Contact Logging Report (Reports -> All Reports -> Contact Logging Report (Summary))
* Refresh results
* Click on the Update button of any entry
* Click on the name ("Change to <name>")
* Observe the error: "We could not find a contact id"
I'm not sure if this is a regression as I've only just started using this functionality.
In [ReportDetail.php](CRM/Logging/ReportDetail.php#L241) `$whom_url` is set using `$this->cid`; perhaps this is not correct?5.28.0https://lab.civicrm.org/dev/core/-/issues/1750View sent emails in activities2021-03-27T15:11:01ZshitijgView sent emails in activitiesOverview
----------------------------------------
As it stands currently, a CiviCRM user can send an email to a contact via a few methods. The user can also use tokens which personalise the content per contact they are sending an email t...Overview
----------------------------------------
As it stands currently, a CiviCRM user can send an email to a contact via a few methods. The user can also use tokens which personalise the content per contact they are sending an email too.
On submission, an activity is created for this. However, the activity only stores the tokens and not the actual content sent to a contact.
The behaviour for how the content of the email when we use the “send email” activity functionality is different to that from mass mailings with respect to tokens, and any used tokens aren’t replaced in the resultant stored body of the content in the activity with the actual content.
To see the content of the sent email (rather than just “token” itself) is important to users as
- They should be able to see what was sent to a contact at any given time and not just the tokens
- information might change with time i.e. the data in the field may change so the user will not know what was actually sent to the contact
Current behaviour
----------------------------------------
A mailing can be sent to the user in multiple ways in CiviCRM eg. bulk mailings, through send email activity on the contact record, inside a case, scheduled reminders, and through extensions like CiviRules.
However, when we use the send email activity form, any used tokens aren’t replaced in the resultant stored body of the content in the activity eg
![image1](/uploads/7419b37d976e1603ae2ad05d1c8619f2/image1.png)
This is happening due to an issue in the following create email activity functionality:
https://github.com/civicrm/civicrm-core/blob/master/CRM/Contact/Form/Task/EmailCommon.php#L467-L483
This is used:
1. When creating an activity from the contact record: This can be done by clicking on the ‘Send email’ action which triggers the form above
2. From within a case: The same form is used when creating a ‘Send email’ activity from within a case
Proposed behaviour
----------------------------------------
The created activity should store (in the content) the "resultant value" of any "tokens" with the content they were actually sent as to the recipient rather than just the {token} field name itself.
Technical implementation suggestions:
- The email activity is created before the token replacements is done here: https://github.com/civicrm/civicrm-core/blob/master/CRM/Activity/BAO/Activity.php#L1122.
- Token replacements are done here: https://github.com/civicrm/civicrm-core/blob/master/CRM/Activity/BAO/Activity.php#L1193-L1216
- Change will be to move the activity creation to just before the email is sent, after token replacements are done to somewhere like here: https://github.com/civicrm/civicrm-core/blob/master/CRM/Activity/BAO/Activity.php#L1227
with the following code:
$activityID = self::createEmailActivity($userID, $tokenSubject, $tokenHtml, $tokenText, $additionalDetails, $campaignId, $attachments);
We have tested this on our local and are happy to submit a core PR if the concept is approved.5.36.0https://lab.civicrm.org/dev/drupal/-/issues/121OG Sync Problem on ACL Groups2020-05-26T17:12:27ZTony Maynard-SmithOG Sync Problem on ACL GroupsThis is in CiviCRM 5.24.4
When I look at the ACL setup created by OG Sync, I see the following in the ACL Assign Users to Roles page. For each OG ACL Group there is one entry with the appropriate ACL Role assigned, and a variable numbe...This is in CiviCRM 5.24.4
When I look at the ACL setup created by OG Sync, I see the following in the ACL Assign Users to Roles page. For each OG ACL Group there is one entry with the appropriate ACL Role assigned, and a variable number of entries with the ACL Role column blank.
This page corresponds to the acl_entity_role table in the database, which joins the civicrm_group id to the acl_role_id (which is a key to the option_value table). The rows which have the ACL Role column blank on the Assign Users to Roles page contain acl_role_id values which do not appear in the option_value table, while the valid entry has a valid option_value.
It would appear that this situation has been caused by the following bug. When an OG Group Page on the website is edited (with a simple text edit), the system deletes the previous value in the option_value table and creates a new one in its place. It also creates a new entry in the acl_entity_role table, linked to the new option_value, and leaves the old entry in the acl_entity_role table behind. (There may be other actions which cause the same result, I haven't checked.)
I don't think this is causing functional misbehaviour, but it is administratively annoying (and steadily getting worse) and is clearly bad coding.https://lab.civicrm.org/dev/user-interface/-/issues/20Activity type search - sort alphabetically2020-05-11T13:49:30ZrebeccatregennaActivity type search - sort alphabeticallyFor end user friendliness, it would be nice to sort 'activity type' alphabetically in the dropdown options for search functions
![activitysearch](/uploads/aca6f87b7781f8890fa71268903d425b/activitysearch.png)
(from 5.27.alpha1 on Drupa...For end user friendliness, it would be nice to sort 'activity type' alphabetically in the dropdown options for search functions
![activitysearch](/uploads/aca6f87b7781f8890fa71268903d425b/activitysearch.png)
(from 5.27.alpha1 on Drupal demo)https://lab.civicrm.org/dev/core/-/issues/1751Email template permissions2020-07-18T03:07:08Zfran@compucorp.co.ukEmail template permissionsOverview
----------------------------------------
In the email modal, CiviCRM users can write an email from scratch or use an existing message template. They are given the options to update existing templates or save a new template.
Th...Overview
----------------------------------------
In the email modal, CiviCRM users can write an email from scratch or use an existing message template. They are given the options to update existing templates or save a new template.
These options are currently available and can be completed by users with basic access to CiviCRM*, even when they do not have the permission CiviCRM: edit message templates.
Organisations want to create standard message templates that cannot be altered by the hundreds of staff using the templates. They need to be able to set this up as a user permission.
Current behaviour
----------------------------------------
When writing an email in the email modal, CiviCRM users can write an email from scratch or use an existing template. If they write an email from scratch they have the option to save their email as a new message template. If they use an existing template, they have an option to ‘update’ the template or save it as a new message template.
When a CiviCRM user writes an email, selects ‘Save as new template’ and sends the email, a new message template is created. These steps are the same when a user edits an already existing email template.
When a CiviCRM user selects an existing email template, makes changes to the content, selects ‘Update template’ and sends the email, the existing template is updated to whatever content the user has changed.
![permissions_template](/uploads/67b28e3e11d4cf353e1845b22c3fac31/permissions_template.png)
Email templates can be accessed where the email modal is triggered (e.g. contact record, cases extension etc.).
Expected behaviour
----------------------------------------
Acceptance criteria:
Any user that does not have the permission to update email templates [CiviCRM: edit message templates] should not see the check box ‘Update Template’
Any user that does not have the permission to create email templates [CiviCRM: edit message templates] should not be able to edit the content of email templates
![permissions_update_template](/uploads/719e1502f187a21a52027b946cd51e92/permissions_update_template.png)5.29.0https://lab.civicrm.org/dev/civicrm-asset-plugin/-/issues/4kcfinder libraries is missing files2023-07-05T05:41:48Zkarunadevkcfinder libraries is missing filesI notice there are far more files and directories for kcfinder ./vendor/civicrm/civicrm-packages/kcfinder/ compared to ./web/libraries/civicrm/packages/kcfinder. For example the browse.php file is not present in libraries path, which exp...I notice there are far more files and directories for kcfinder ./vendor/civicrm/civicrm-packages/kcfinder/ compared to ./web/libraries/civicrm/packages/kcfinder. For example the browse.php file is not present in libraries path, which explains why the functionality to find and upload images in CiviMail or CiviEvent does not work and produces a 'page not found' error in the logs
`/libraries/civicrm/packages/kcfinder/browse.php?cms=civicrm&type=images&CKEditor=crmUiId_1&CKEditorFuncNum=0&langCode=en-ca. `
Copying the kcfinder contents from /vendor path to the /libraries path does not help, so there is more to this.
BTW, test case summary is:
#installed with
`
composer create-project drupal/recommended-project <path>
composer require civicrm/civicrm-asset-plugin civicrm/civicrm-drupal-8 civicrm/civicrm-packages
`
Also occurs with
`
composer create-project roundearth/drupal-civicrm-project:8.x-dev www-cmnty-drupal --no-interaction
`
#set permissions (Cpanel machine) run with root
`
cd ./web
chown -R user:nobody .
find . -type d -exec chmod u=rwx,g=rx,o= '{}' \;
find . -type f -exec chmod u=rw,g=r,o= '{}' \;
cd /sites
find . -type d -name files -exec chmod ug=rwx,o= '{}' \;
for d in ./*/files
do
find $d -type d -exec chmod ug=rwx,o= '{}' \;
find $d -type f -exec chmod ug=rw,o= '{}' \;
done
`
#enable
`chmod +w web/sites/default
vendor/drush/drush/drush pm-enable -y civicrm`https://lab.civicrm.org/dev/core/-/issues/1752Allow existing lifetime memberships to be displayed and selected on contribut...2023-03-21T05:03:20ZAllenShawAllow existing lifetime memberships to be displayed and selected on contribution pagesCurrently, if a lifetime membership type is configured to be available on a contribution page, AND if the user has an existing current membership of that type, that membership type is hidden when viewing the live contribution page, and a...Currently, if a lifetime membership type is configured to be available on a contribution page, AND if the user has an existing current membership of that type, that membership type is hidden when viewing the live contribution page, and a help message reads, "You have a current Lifetime Membership which does not need to be renewed.", like so:
--------------
![hidden-explain](/uploads/aaf99afc0b35739844a73203a12b80d9/hidden-explain.png)
--------------
I've encountered a use case in which it's preferable to make this membership type available and selectable, rather than hiding it and explaining why. With small changes to CiviCRM core code (this is not possible with hooks) we're allowing users to complete the contribution form while retaining their lifetime membership, without having to explain to them, "Yes, we know you have a lifetime membership, we're just hiding it from you." Like so:
------------------------------
![displayed](/uploads/b474c63d700e2a0f479e1d9daf5f1251/displayed.png)
------------------------------
I wonder what it might take to get this kind of behavior into CiviCRM core.
This site is maintained by Stuart Gaston, so maybe he'll chime in here with more on the use case and the general rationale for this proposal.https://lab.civicrm.org/dev/core/-/issues/1753Deleting an activity with attachments doesn't delete the file or entries in c...2020-06-02T06:07:11ZDaveDDeleting an activity with attachments doesn't delete the file or entries in civicrm_file/civicrm_entity_fileThis might be an old issue but I did a quick look and didn't see anything. If a file is shared between two entities, then I could understand if it leaves civicrm_file and the file itself and just removes civicrm_entity_file, but it doesn...This might be an old issue but I did a quick look and didn't see anything. If a file is shared between two entities, then I could understand if it leaves civicrm_file and the file itself and just removes civicrm_entity_file, but it doesn't seem to remove anything, and even when there's no sharing (i.e. zero reference count).
1. Create e.g. an email activity. Add an attachment.
2. Delete the activity, e.g. from your contact's activity tab.
3. Look in sites/default/files/civicrm/custom. The attachment file is still there.
4. Also the entries are still there in civicrm_file and civicrm_entity_file even though the entry in civicrm_activity isn't there anymore.5.27.0https://lab.civicrm.org/dev/core/-/issues/1754Create user record screen unsupported on WordPress2021-10-10T15:19:11ZBradley TaylorCreate user record screen unsupported on WordPressOn Drupal and Joomla it is possible to create a new CMS user from a contact record, by selecting "Create User Record" from the Actions dropdown. This is not available on WordPress.
It looks like this is the result of `CRM_Utils_System_W...On Drupal and Joomla it is possible to create a new CMS user from a contact record, by selecting "Create User Record" from the Actions dropdown. This is not available on WordPress.
It looks like this is the result of `CRM_Utils_System_WordPress` not implementing `checkPermissionAddUser`.
I would expect this function could be very simple - something like this would probably work:
```
public function checkPermissionAddUser() {
return current_user_can('create_users');
}
```
Note, it is possible to directly access the useradd page in WordPress, even though `checkPermissionAddUser` is not implemented (and returns false in the base class). It appears checkPermissionAddUser is not checked before this page is rendered or proccessed. Even though this page is accessible, I would not be comfortable relying on it in a WordPress context, as the lack of `checkPermissionAddUser` method makes me assume this functionality would have been minimally tested.https://lab.civicrm.org/dev/core/-/issues/1755Mailing Subscription form does not validate reCaptcha2020-07-28T23:07:08ZbgmMailing Subscription form does not validate reCaptchaTo reproduce:
* Go to: https://civicrm.org/civicrm/mailing/subscribe?reset=1 (or setup any site with a reCaptcha key, it automatically enables on this form).
* Enter an email, select a newsletter
* Hit Submit, without answering the Capt...To reproduce:
* Go to: https://civicrm.org/civicrm/mailing/subscribe?reset=1 (or setup any site with a reCaptcha key, it automatically enables on this form).
* Enter an email, select a newsletter
* Hit Submit, without answering the Captcha.
Result: captcha is not validated.
I tried debugging to the point where in `CRM_Core_Utils_ReCAPTCHA::add()`, the call to `isSubmitted` returns false, but that may have been a misleading, since removing this bit seems to fix it:
https://lab.civicrm.org/dev/core/-/blob/master/CRM/Mailing/Form/Subscribe.php#L123
```
// If this is POST request and came from a block,
// lets add recaptcha only if already present.
// Gross hack for now.
if (!empty($_POST) &&
!array_key_exists('recaptcha_challenge_field', $_POST)
) {
$addCaptcha = FALSE;
}
```
I don't know what "came from a block" means in this context. Mayeb an old Drupal block?
It was added in 2009: https://github.com/civicrm/civicrm-svn/commit/e745abc5114e644ef58712a42e73af9be100588c#diff-7e49ca39c25024fb4dbba97bee79be03
Related: infra/ops#9465.29.0https://lab.civicrm.org/dev/core/-/issues/1756Bad link in profile form confirmation page2020-05-14T19:30:08ZyosefromanoBad link in profile form confirmation pageThis issue happens when using a profile in create mode.
Even when the profile listing option is not setup, the confirmation page still includes a "Back to Listing" link which leads to an error page (since listings are not setup).
The "...This issue happens when using a profile in create mode.
Even when the profile listing option is not setup, the confirmation page still includes a "Back to Listing" link which leads to an error page (since listings are not setup).
The "Back to Listing" link should only be displayed when the listing feature is enabled for the profilehttps://lab.civicrm.org/dev/core/-/issues/1757CiviCRM menu toggle "adjust menu position" customisable2023-03-24T05:03:20Zfran@compucorp.co.ukCiviCRM menu toggle "adjust menu position" customisableOverview
----------------------------------------
There are 2 ways for CiviCRM users to show the drupal menu
1. Using ‘hide menu’ dropdown under the CiviCRM main menu, which hides the CiviCRM menu showing only the drupal menu
2. With t...Overview
----------------------------------------
There are 2 ways for CiviCRM users to show the drupal menu
1. Using ‘hide menu’ dropdown under the CiviCRM main menu, which hides the CiviCRM menu showing only the drupal menu
2. With the ‘adjust menu position’ toggle, which moves CiviCRM menu down and shows drupal menu above CiviCRM menu
![menu_toggle](/uploads/b4df0eb1e4164fb43e7e6aac2e570b24/menu_toggle.png)
Most CiviCRM users only use the CiviCRM menu. ‘Adjust menu position’ is most useful for site administrators and ideally would be hidden for all other users.
Current behaviour
----------------------------------------
The menu item ‘adjust menu position’ is available for all CiviCRM users. There is no configuration as with other menu items in the Navigation Menu to define permissions or enable/disable it completely.
Some CiviCRM users who do not use the drupal menu find it confusing seeing both CiviCRM menu and drupal menu together. The ‘hide menu’ already allows access to the drupal menu for these users who need it, and it’s located under the CiviCRM main menu, where the ‘adjust menu position’ is prominent on the CiviCRM menu panel.
Proposed behaviour
----------------------------------------
As there is another way of hiding the civicrm menu ie ‘hide menu’ option and as such most of the sites have been configured in a way that the user is directly taken to the CiviCRM dashboard on login, we suggest the following:
The menu item ‘adjust menu position’ can be configurable so that it can be hidden from basic CiviCRM users.
Acceptance criteria:
1. ‘Adjust menu position’ would be part of the Navigation Menu and be configurable like other menu items
2. Users who could access the Administer menu would have the permission to customise this menu item
3. It would be customisable like other menu items, with the key functionality of being able to set permissions.
![screenshot-compuclient-case-rules-lmi.compubox.co.uk-2020.05.13-11_46_47](/uploads/d16f65a34061aabba1bcec21871d8139/screenshot-compuclient-case-rules-lmi.compubox.co.uk-2020.05.13-11_46_47.png)https://lab.civicrm.org/dev/core/-/issues/1758Record Payment does not update check_number & trxn id on main contribution.2020-09-09T05:47:08ZjitendraRecord Payment does not update check_number & trxn id on main contribution.To reproduce -
- Create a pending contribution.
- Record payment and enter C111 in the check number field.
- Main contribution row in civicrm_contribution table is not updated with the check number field. This leads to empty values in c...To reproduce -
- Create a pending contribution.
- Record payment and enter C111 in the check number field.
- Main contribution row in civicrm_contribution table is not updated with the check number field. This leads to empty values in contribution export.
Similar issues with trxn_id input field.
Note that the main contribution values are updated if we use the payment edit form.
Related issue was raised at https://lab.civicrm.org/dev/core/-/issues/1483 but it deals specifically with the incorrect updates made via the edit form. Also that tickets needs concept approval as one of the unit test asserts this wrong behaviour(more info on [gitlab](https://lab.civicrm.org/dev/core/-/issues/1483))5.27.0https://lab.civicrm.org/dev/core/-/issues/1759Contribution aggregate is not working for contribution templates2023-03-12T05:03:21ZyashodhaContribution aggregate is not working for contribution templatesThe {$contribution_aggregate} is not working for contribution template
Steps to replicate:
--------------------
* Contributions > Find Contributions > Actions > Thank You Letters for Contributions
* Select options as displayed in the f...The {$contribution_aggregate} is not working for contribution template
Steps to replicate:
--------------------
* Contributions > Find Contributions > Actions > Thank You Letters for Contributions
* Select options as displayed in the following screenshot:
![thank](/uploads/d1941864b5068bf9ec6af51d03490ab1/thank.png)
Before
![aggregate_before](/uploads/3a28dba2083273674a6d4221248b4973/aggregate_before.png)
After
![dmaster_aggregate](/uploads/4e3648fe29ea2a5c40c6f56e718897b4/dmaster_aggregate.png)yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/1760SMTP page appears broken when language is French (JS issue)2020-05-20T12:34:55ZVangelisPSMTP page appears broken when language is French (JS issue)On the SMTP settings admin page, there's a warning when you switch from Redirect to database to a live mode. In French language, the translation has double-quotes, but js-escaping does single quotes and expects the terminator to be singl...On the SMTP settings admin page, there's a warning when you switch from Redirect to database to a live mode. In French language, the translation has double-quotes, but js-escaping does single quotes and expects the terminator to be single quotes.
To reproduce, switch language to french and visit the admin smtp settings page. Look in the browser javascript console and you'll see the error.
The issue is located [here](https://github.com/civicrm/civicrm-core/blob/5.25.0/templates/CRM/Admin/Form/Setting/Smtp.tpl#L96)
@DaveD was kind enough and quick enough to produce a PR for this: https://github.com/civicrm/civicrm-core/pull/17315 so all credit goes to him.5.27.0