Development issues
https://lab.civicrm.org/groups/dev/-/issues
2023-11-01T23:19:57Z
https://lab.civicrm.org/dev/core/-/issues/4727
Basic/Advanced search and CiviReport filters showing `name` in tag dropdown i...
2023-11-01T23:19:57Z
DaveD
Basic/Advanced search and CiviReport filters showing `name` in tag dropdown instead of `label`
![untitled4](/uploads/ea919fe7f1f9257beb0f2c656f3efe2a/untitled4.png)
Also the QILL for the civireport (the QILL for the search is ok).
![untitled3](/uploads/ed24469c7b1110d79340b0f4b3555fb4/untitled3.png)
![untitled4](/uploads/ea919fe7f1f9257beb0f2c656f3efe2a/untitled4.png)
Also the QILL for the civireport (the QILL for the search is ok).
![untitled3](/uploads/ed24469c7b1110d79340b0f4b3555fb4/untitled3.png)
5.68.0
https://lab.civicrm.org/dev/core/-/issues/4726
On Import in Non English Mode do not import field in saved field mapping is n...
2023-11-29T20:14:33Z
seamuslee
On Import in Non English Mode do not import field in saved field mapping is not correctly set as default when re-using import
Overview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set cor...
Overview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set correctly when the MapField form is loaded as per the screenshot below showing the saving of the saved mapping field with the 2nd field as do not import but then when I go to re-use the saved mapping the mapped column does not match do not import
![save_import_map](/uploads/a652dc803fecadde0d5ec7fe0f202f58/save_import_map.jpg)
![use_import_map](/uploads/a2ae9251dbc67491276567473e4668c7/use_import_map.jpg)
Reproduction steps
----------------------------------------
1. Navigate to Administer -> localisation -> Languages ... and Set current language to be French (France)
1. Go to contacts -> Import contacts and proceed to the map field step. Create a mapping and save it making sure that one of the fields is marked as do not import
1. Repeat step 2 but this time re-use the saved mapping from before and find that the field is not mapped to the selection of do not import
ping @eileen @JoeMurray
5.67.0
https://lab.civicrm.org/dev/core/-/issues/4724
Contribution fails mid-donation with geocoding, "on behalf of", and no state/...
2023-10-30T02:57:00Z
JonGold
Contribution fails mid-donation with geocoding, "on behalf of", and no state/province
Overview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
-------------------------------------...
Overview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
----------------------------------------
1. Create a contribution page that allows giving "on behalf of an organization". The Organization profile should include state/province and at least one other address field. The state/province must not be required.
2. Submit the form with an organization. Provide at least one part of the address but leave the state blank.
Current behaviour
----------------------------------------
Crashes in geocoding.
Expected behaviour
----------------------------------------
Submits successfully.
Comments
----------------------------------------
This wouldn't be such a big deal but for https://lab.civicrm.org/dev/core/-/issues/2929.
A partial backtrace is below, though there are other ways to reach this code path (e.g. if confirm pages are present/absent).
```
#0 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/DAO.php(1419): strtolower()
#1 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Utils/Geocode/Google.php(76): CRM_Core_DAO::getFieldValue()
#2 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1287): CRM_Utils_Geocode_Google::format()
#3 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(276): CRM_Core_BAO_Address::addGeocoderData()
#4 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1365): CRM_Core_BAO_Address::fixAddress()
#5 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Location.php(52): CRM_Core_BAO_Address::legacyCreate()
#6 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(327): CRM_Core_BAO_Location::create()
#7 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(1921): CRM_Contact_BAO_Contact::create()
#8 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(1296): CRM_Contact_BAO_Contact::createProfileContact()
#9 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(2312): CRM_Contribute_Form_Contribution_Confirm::processOnBehalfOrganization()
#10 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(836): CRM_Contribute_Form_Contribution_Confirm->processFormSubmission()
#11 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/Form.php(617): CRM_Contribute_Form_Contribution_Confirm->postProcess()
#12 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1318): CRM_Core_Form->mainProcess()
#13 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1076): CRM_Contribute_Form_Contribution_Main->skipToThankYouPage()
```
5.68.0
JonGold
JonGold
https://lab.civicrm.org/dev/core/-/issues/4723
SearchKit joins to custom fields appear to be broken
2023-11-02T20:48:31Z
ScottMason
SearchKit joins to custom fields appear to be broken
The latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom fi...
The latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom field for activities (for example Activities details > products)
2. Create a new SK search for activities and join to the custom field
![image](/uploads/ebbeb025d909e2df4b8c87d97d7a9ada/image.png)
3. Add info from the linked entity to the display
4. The info is not shown.
![image](/uploads/870046a2cf17c723bfff75917401beb0/image.png)
I have tested this on the lastest demo site and it appears to be an issue there.
fyi @kurund
https://lab.civicrm.org/dev/core/-/issues/4722
[PHP 8.1] fseek deprecation in PHPgettext
2023-12-04T21:08:50Z
jofranz
franz@systopia.de
[PHP 8.1] fseek deprecation in PHPgettext
Overview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Depre...
Overview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Deprecation] fseek(): Passing null to parameter #2 ($offset) of type int is deprecated at .../drupal/vendor/civicrm/civicrm-packages/PHPgettext/streams.php:125```
Expected behaviour
----------------------------------------
There should be no deprecation warnings.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __CiviCRM:__ _5.66.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _8.1_
* __CMS:__ _Drupal 9.5.11_
https://lab.civicrm.org/dev/core/-/issues/4720
[PHP 8.1] New Organization: 4x Undefined array key
2023-10-27T11:41:07Z
jofranz
franz@systopia.de
[PHP 8.1] New Organization: 4x Undefined array key
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/contact/add?reset=1&ct=Organization
## Seeing
```
Warning: Undefined array key "contact_sub_type" in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/4...
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/contact/add?reset=1&ct=Organization
## Seeing
```
Warning: Undefined array key "contact_sub_type" in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Undefined array key "contact_sub_type" in include() (line 34 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 34 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
```
https://lab.civicrm.org/dev/core/-/issues/4719
[PHP 8.1] New Contribution: 4x Undefined array key
2023-12-12T20:43:31Z
jofranz
franz@systopia.de
[PHP 8.1] New Contribution: 4x Undefined array key
## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicr...
## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicrm/templates_c/en_US/%%60/60A/60A6E1C6%%Payment.tpl.php).
Warning: Undefined array key "buildRecurBlock" in include() (line 125 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
Warning: Undefined array key "urlPathVar" in include() (line 90 of sites/default/files/civicrm/templates_c/en_US/%%51/516/51624B60%%paymentBlock.tpl.php).
Warning: Undefined array key "dataUrl" in include() (line 477 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
```
---
_Internal ref: sci_
https://lab.civicrm.org/dev/core/-/issues/4718
[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in...
2023-11-03T02:04:37Z
jofranz
franz@systopia.de
[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in CRM_Core_Action
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate...
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate/drupal/vendor/civicrm/civicrm-core/CRM/Core/Action.php).```
5.67.0
https://lab.civicrm.org/dev/core/-/issues/4717
[PHP 8.1] Organization Address and Contact Info: foreach() argument must be ...
2023-12-11T23:15:39Z
jofranz
franz@systopia.de
[PHP 8.1] Organization Address and Contact Info: foreach() argument must be of type array|object, string given
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/admin/domain?action=update&reset=1
## Seeing
2x:
```Warning: Undefined array key "defaultCurrencySymbol" in include() (line 155 of sites/default/files/civicrm/templates_c/en...
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/admin/domain?action=update&reset=1
## Seeing
2x:
```Warning: Undefined array key "defaultCurrencySymbol" in include() (line 155 of sites/default/files/civicrm/templates_c/en_US/%%24/24E/24E27851%%jsortable.tpl.php).```
https://lab.civicrm.org/dev/core/-/issues/4716
[PHP 8.1] Registered Templates: Undefined array key "weight"
2023-11-01T20:31:11Z
jofranz
franz@systopia.de
[PHP 8.1] Registered Templates: Undefined array key "weight"
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/admin/report/options/report_template?reset=1
## Seeing
288x:
`Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autoph...
## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/admin/report/options/report_template?reset=1
## Seeing
288x:
`Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate/drupal/vendor/civicrm/civicrm-core/CRM/Core/Action.php).`
5.67.0
https://lab.civicrm.org/dev/core/-/issues/4714
Civi-Import change the description
2023-10-26T07:16:29Z
jaapjansma
Civi-Import change the description
I just installed a CiviCRM version 5.66 fresh for a client and saw a core extension Civi-Import.
The description line reads:
`Core extension for us to start moving import logic into, has more functionalit`
My question is what is this ...
I just installed a CiviCRM version 5.66 fresh for a client and saw a core extension Civi-Import.
The description line reads:
`Core extension for us to start moving import logic into, has more functionalit`
My question is what is this extension? And who is the us?
I am bit afraid that the wording us also creates a not me and thus a we vs them mentality. I am not sure whether that is intededed.
So my proposal would be: `This is an extension in development to move core import functionality into an extension. This extension helps people who do development work on CiviCRM core. Feel free to contribute.`
5.68.0
https://lab.civicrm.org/dev/core/-/issues/4710
demo data needs updating for tag changes
2023-10-19T23:10:37Z
DaveD
demo data needs updating for tag changes
Just visit the tags admin page on dmaster.demo. Looks pretty blank, which is one way to solve translation issues, but probably not as intended.
Just visit the tags admin page on dmaster.demo. Looks pretty blank, which is one way to solve translation issues, but probably not as intended.
https://lab.civicrm.org/dev/core/-/issues/4709
Custom Field display code assumes option values are numeric
2023-10-22T22:13:14Z
JonGold
Custom Field display code assumes option values are numeric
Overview
----------------------------------------
Custom Field display code assumes option values are numeric. This leads to crashing when searching using regex/`LIKE` in Search Builder, and possibly less obsolete parts of Civi as well....
Overview
----------------------------------------
Custom Field display code assumes option values are numeric. This leads to crashing when searching using regex/`LIKE` in Search Builder, and possibly less obsolete parts of Civi as well.
Reproduction steps
----------------------------------------
1. Create a new custom field of data type Alphanumeric, HTML type of Select.
1. Go to Search Builder.
1. Search on that field using regex or `LIKE`, with a period in the search term. See attached screenshot.
Current behaviour
----------------------------------------
```
TypeError: round(): Argument #1 ($num) must be of type int|float, string given in round() (line 1332 of /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php).
```
Expected behaviour
----------------------------------------
Search should complete as normal.
Comments
----------------------------------------
This happens because we assume that a select value either has a corresponding label, or it's a number. Which is true when you're searching for a specific value, but fails when the value is a regex or LIKE statement.
This doesn't happen in SearchKit, but it *does* happen when you use a smart group based on the search.
This is a regression in the technical sense, but it's been broken since at least 5.53.
Backtrace is below:
```
#0 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomField.php(1278): round()
#1 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomField.php(1194): CRM_Core_BAO_CustomField::formatDisplayValue()
#2 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomQuery.php(197): CRM_Core_BAO_CustomField::displayValue()
#3 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomQuery.php(369): CRM_Core_BAO_CustomQuery->where()
#4 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/Query.php(569): CRM_Core_BAO_CustomQuery->query()
#5 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/Query.php(524): CRM_Contact_BAO_Query->initialize()
#6 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(585): CRM_Contact_BAO_Query->__construct()
#7 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(777): CRM_Contact_BAO_GroupContactCache::getQueryObjectSQL()
#8 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(616): CRM_Contact_BAO_GroupContactCache::insertGroupContactsIntoTempTable()
#9 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(359): CRM_Contact_BAO_GroupContactCache::buildGroupContactTempTable()
#10 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Mailing/BAO/Mailing.php(477): CRM_Contact_BAO_GroupContactCache::load()
#11 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Mailing/BAO/Mailing.php(1647): CRM_Mailing_BAO_Mailing::doSubmitActions()
#12 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/v3/utils.php(1294): CRM_Mailing_BAO_Mailing::create()
#13 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/v3/Mailing.php(55): _civicrm_api3_basic_create()
#14 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_mailing_create()
#15 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(156): Civi\API\Provider\MagicFunctionProvider->invoke()
#16 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(79): Civi\API\Kernel->runRequest()
#17 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/api.php(136): Civi\API\Kernel->runSafe()
#18 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/v3/Mailing.php(307): civicrm_api3()
#19 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_mailing_submit()
#20 /home/members/mysite/sites/crm.mysite.org/web/wp-content/civicrm-custom/extensions/uk.co.vedaconsulting.mosaico/CRM/Mosaico/AbDemux.php(128): Civi\API\Provider\MagicFunctionProvider->invoke()
#21 [internal function]: CRM_Mosaico_AbDemux->onSubmitMailing()
#22 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Provider/WrappingProvider.php(48): call_user_func()
#23 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(156): Civi\API\Provider\WrappingProvider->invoke()
#24 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(79): Civi\API\Kernel->runRequest()
#25 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/api.php(28): Civi\API\Kernel->runSafe()
#26 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/REST.php(288): civicrm_api()
#27 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/REST.php(533): CRM_Utils_REST::process()
#28 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(288): CRM_Utils_REST::ajax()
#29 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem()
#30 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke()
#31 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm.php(1199): CRM_Core_Invoke::invoke()
#32 /home/members/mysite/sites/crm.mysite.org/web/wp-includes/class-wp-hook.php(310): CiviCRM_For_WordPress->invoke()
#33 /home/members/mysite/sites/crm.mysite.org/web/wp-includes/class-wp-hook.php(334): WP_Hook->apply_filters()
#34 /home/members/mysite/sites/crm.mysite.org/web/wp-includes/plugin.php(517): WP_Hook->do_action()
#35 /home/members/mysite/sites/crm.mysite.org/web/wp-admin/admin.php(259): do_action()
#36 {main}
```
5.68.0
JonGold
JonGold
https://lab.civicrm.org/dev/core/-/issues/4708
Memberships by relationship are not created on contact merge
2023-10-23T20:45:46Z
brienne
Memberships by relationship are not created on contact merge
Overview
----------------------------------------
If two contacts are merged and one has an active membership and the other has active relationships, memberships by relationship are not created for the related contacts.
Reproduction st...
Overview
----------------------------------------
If two contacts are merged and one has an active membership and the other has active relationships, memberships by relationship are not created for the related contacts.
Reproduction steps
----------------------------------------
1. Create (or find) two Organization Contacts
* one should have a membership
* one should have at least one relationship of Type 'Employer of'
1. Merge the two Organizations
1. Note that the merged contact has the membership and the relationship, but that the related contact does not have a membership by relationship
Current behaviour
----------------------------------------
Memberships by relationship are not being created for related contacts after a contact merge.
Expected behaviour
----------------------------------------
When contacts with memberships and relationships- such as of Type 'Employer of' - are merged, memberships by relationship should be created for the relevant contacts- i.e. whatever function gets called to create a membership by relationship should be called after contacts are merged, if that contact has a membership.
Environment information
----------------------------------------
* __CiviCRM:__ 5.66
https://lab.civicrm.org/dev/core/-/issues/4707
[PHP 8.0+?] Empty requires tag in info.xml crashes extension list
2023-10-23T20:45:38Z
jofranz
franz@systopia.de
[PHP 8.0+?] Empty requires tag in info.xml crashes extension list
Overview
----------------------------------------
This seems to be working fine on PHP 7.4 tho.
Reproduction steps
----------------------------------------
1. Having an [empty requires tag](https://github.com/Project60/org.project60.mem...
Overview
----------------------------------------
This seems to be working fine on PHP 7.4 tho.
Reproduction steps
----------------------------------------
1. Having an [empty requires tag](https://github.com/Project60/org.project60.membership/pull/68/files)
1. Go to: `.../civicrm/admin/extensions?reset=1`
1. See an empty page? Not sure as I have [whoops](https://filp.github.io/whoops/) enabled
Current behaviour
----------------------------------------
```
array_intersect(): Argument #1 ($array) must be of type array, string given
```
Expected behaviour
----------------------------------------
Empty tags should be ignored
Environment information
----------------------------------------
* __Browser:__ _Firefox_
* __CiviCRM:__ _5.65.2_
* __PHP:__ _8.1 (works on 7.4)_
* __CMS:__ _Drupal 9.5.11_
* __Database:__ _Yes :)_
* __Web Server:__ _Apache 2_
5.67.0
https://lab.civicrm.org/dev/core/-/issues/4706
Event Custom Field Overwrite
2023-10-19T23:02:35Z
guyiac
Event Custom Field Overwrite
## Overview
_Please describe your problem or bug in detail._
On custom fields for Events, if you save the record, then leave, then come back in, the custom data doesn't show up in the UI but actually is in the database. Even worse, if ...
## Overview
_Please describe your problem or bug in detail._
On custom fields for Events, if you save the record, then leave, then come back in, the custom data doesn't show up in the UI but actually is in the database. Even worse, if you save that record again, the blank fields in the UI overwrite the data in the database. So if you go in to edit the event, and don't notice the blank custom fields, when you save, you will overwrite the custom data and not even know it.
I first noticed this on a client site in WP on 5.66.0, and have confirmed it on wpmaster and d7master on 5.68.alpha1. It doesn't appear to happen on contacts, but I didn't test any other entities.
https://chat.civicrm.org/civicrm/pl/q6jpjss4x7byiqkejar1nbhxkw
## Reproduction steps
## Current behaviour
_What happens currently. Please provide error messages, screenshots or gifs (_[_LICEcap_](http://www.cockos.com/licecap/)_, _[_SilentCast_](https://github.com/colinkeenan/silentcast)_) where appropriate._
```plaintext
```
## Expected behaviour
## Environment information
* **Browser:** _recent chrome and firefox_
* **CiviCRM:** _d7 and wp master 5.68.alpha1, wp 5.66.0_
* **PHP:** 8.1
* **CMS:** _wp and d7_
* **Database:** _MySQL 5_
* **Web Server:** _not sure_
## Comments
_Anything else you would like the reviewer to note._
https://lab.civicrm.org/dev/core/-/issues/4705
Regression - breakage on quicksearch in conjunction with contact id
2023-10-19T21:21:25Z
eileen
Regression - breakage on quicksearch in conjunction with contact id
This is currently replicable on https://dmaster.demo.civicrm.org/ & intermittently replicable on Civi sites from 5.66 upwards & earlier but with the proviso that I only replicated on earlier (5.65, 5.64) with a db already 'infected' from...
This is currently replicable on https://dmaster.demo.civicrm.org/ & intermittently replicable on Civi sites from 5.66 upwards & earlier but with the proviso that I only replicated on earlier (5.65, 5.64) with a db already 'infected' from master
On the demo site
![image](/uploads/9f8ad640c1b5baad4918ff533eb426f4/image.png)
![image](/uploads/ac16e638316e25939d8712fc8032afba/image.png)
![image](/uploads/9e15dd298562998fad9de8f3d65903e2/image.png)
The error occurs when 'id' is in the $_POST
![image](/uploads/4b3506df674d9d5c8ea7d6da183dcc68/image.png)
- with some combo of cache clearing / setting re-setting it switches to contact_id - which does work - I haven't figured out what combo yet
![image](/uploads/f4387184cb6ce03146d6c8728d7cf454/image.png)
https://lab.civicrm.org/dev/core/-/issues/4703
Saving a group definition lose the current parent groups
2023-10-25T20:49:32Z
samuelsov
Saving a group definition lose the current parent groups
To reproduce:
1. edit a group, add a parent, save -> all good
1. edit a group, don't touch the parent, save -> the parent is lost
Was working in 5.60, doesn't work anymore since at least 5.65 and reproduced in https://dmaster.demo.civic...
To reproduce:
1. edit a group, add a parent, save -> all good
1. edit a group, don't touch the parent, save -> the parent is lost
Was working in 5.60, doesn't work anymore since at least 5.65 and reproduced in https://dmaster.demo.civicrm.org
5.66.1
https://lab.civicrm.org/dev/core/-/issues/4700
Email attachments with unicode filename get munged
2023-10-13T13:46:38Z
JonGold
Email attachments with unicode filename get munged
Overview
----------------------------------------
If you send an email with an attachment, and the filename has Unicode, the Unicode will be converted to underscores.
Reproduction steps
----------------------------------------
1. Create...
Overview
----------------------------------------
If you send an email with an attachment, and the filename has Unicode, the Unicode will be converted to underscores.
Reproduction steps
----------------------------------------
1. Create a new file `Montréal.txt`.
2. Send an email to yourself, attaching the file.
Current behaviour
----------------------------------------
Email attachment is named `Montr_al.txt`.
Expected behaviour
----------------------------------------
Email attachment is named `Montréal.txt`.
5.68.0
JonGold
JonGold
https://lab.civicrm.org/dev/core/-/issues/4697
Standalone: civicrm/user path conflicts with existing path to user dashboard
2023-11-29T02:10:00Z
colemanw
Standalone: civicrm/user path conflicts with existing path to user dashboard
The path `civicrm/user` is declared by the Standalone extension, but it was already in use by core.
See https://lab.civicrm.org/dev/core/-/blob/f04bfacb5ed5131c9d29e8a9c0725c3059caeef0/CRM/Core/xml/Menu/Contact.xml#L213-218
The path `civicrm/user` is declared by the Standalone extension, but it was already in use by core.
See https://lab.civicrm.org/dev/core/-/blob/f04bfacb5ed5131c9d29e8a9c0725c3059caeef0/CRM/Core/xml/Menu/Contact.xml#L213-218