Development issueshttps://lab.civicrm.org/groups/dev/-/issues2020-08-20T02:05:05Zhttps://lab.civicrm.org/dev/core/-/issues/1960WordPress Uncaught TypeError: Argument 1 throws an exception during search in...2020-08-20T02:05:05ZshaneonabikeWordPress Uncaught TypeError: Argument 1 throws an exception during search indexingOverview
----------------------------------------
We are using ElasticSearch (ElasticPress) to index our site. I know that in the latest CiviCRM it creates a page (ID: 5) which should not be deleted. For some weird reason this page (I be...Overview
----------------------------------------
We are using ElasticSearch (ElasticPress) to index our site. I know that in the latest CiviCRM it creates a page (ID: 5) which should not be deleted. For some weird reason this page (I believe) is causing exceptions although I could be wrong. If there is a way that I can output a bigger stacktrace let me know and I'll provide that. I honestly can't determine where this is originating from which is frustrating.
Regardless, each time that I index it hangs because an exception is thrown during the index process.
Reproduction steps
----------------------------------------
1. Install ElasticPress
1. Connect to your ElasticSearch
1. Index the website and receive an error
`Uncaught TypeError: Argument 1 passed to civicrm_api3() must be of the type string, null given, called in /var/www/example.org/wp-content/plugins/content-views-civicrm-data-processor/includes/class-cvc-api.php on line 27 and defined in /var/www/example.org/wp-content/plugins/civicrm/civicrm/api/api.php:129
Stack trace:
#0 /var/www/example.org/wp-content/plugins/content-views-civicrm-data-processor/includes/class-cvc-api.php(27): civicrm_api3(NULL, 'getfields', Array)
#1 /var/www/example.org/wp-content/plugins/content-views-civicrm-data-processor/includes/class-cvc-api.php(49): Content_Views_CiviCRM_Api->call(NULL, 'getfields', Array)
#2 /var/www/example.org/wp-content/plugins/content-views-civicrm-data-processor/includes/class-cvc-display.php(256): Content_Views_CiviCRM_Api->call_values(NULL, 'getfields', Array)
#3 /var/www/example.org/wp-content/plugins/content-views-civicrm-data-processor/includes/class-cvc-display.php(180): Content_Views_CiviCRM_Display->get_fields in /var/www/example.org/wp-content/plugins/civicrm/civicrm/api/api.php on line 129`
Current behaviour
----------------------------------------
Expected behaviour
----------------------------------------
I was expecting that if bad values are sent to CiviCRM it could just gracefully fail instead of throwing an exception.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Firefox 59.0.1/Chrome 78.0.3904/Safari 13_
* __CiviCRM:__ Latest
* __PHP:__ 7.2
* __CMS:__ Wordpress
* __Web Server:__ Nginx Latesthttps://lab.civicrm.org/dev/core/-/issues/1959Brick\Math\Exception\RoundingNecessaryException2020-08-21T07:54:12ZDon WijesooriyaBrick\Math\Exception\RoundingNecessaryExceptionOverview
----------------------------------------
When viewing/editing a contribution, throws [- Brick\Math\Exception\RoundingNecessaryException: "Rounding is necessary to represent the result of the operation at this scale." -]
Happen...Overview
----------------------------------------
When viewing/editing a contribution, throws [- Brick\Math\Exception\RoundingNecessaryException: "Rounding is necessary to represent the result of the operation at this scale." -]
Happens in 5.28.0 as a regression of dev/translation#48
Reproduction steps
----------------------------------------
1. Install Civi with sample data
2. Go to any contact
3. Create a new General membership with default values (Completed status etc) **Amount should be $100.00**
4. Go to contributions tab and view the new contribution
5. Throws the following error
![error](/uploads/2f2754546ac7aed5437f2088897bd149/error.PNG)
Environment information
----------------------------------------
* __CiviCRM:__ _5.28.0_
* __PHP:__ _7.2.10_
* __CMS:__ _Drupal 7.69/WordPress 5.5_
This issue only happens with servers not having gmp php extension installed or not getting picked up due to following code in `vendor/brick/math/src/Internal/Calculator.php` from line 76
```php
/**
* Returns the fastest available Calculator implementation.
*
* @codeCoverageIgnore
*
* @return Calculator
*/
private static function detect() : Calculator
{
if (\extension_loaded('gmp')) {
return new Calculator\GmpCalculator();
}
if (\extension_loaded('bcmath')) {
return new Calculator\BcMathCalculator();
}
return new Calculator\NativeCalculator();
}
```
Comments
----------------------------------------
Issue only applies to BCMath5.28.3https://lab.civicrm.org/dev/core/-/issues/1958Add copy action to activity2023-04-27T05:03:20ZyashodhaAdd copy action to activityProvide handy link for duplicating activity.Provide handy link for duplicating activity.yashodhayashodhahttps://lab.civicrm.org/dev/drupal/-/issues/135Use Exception handling for drush (d7) commands - specifically civicrm-upgrade-db2021-02-15T02:50:40ZeileenUse Exception handling for drush (d7) commands - specifically civicrm-upgrade-dbWhen there is a problem upgrading via drush this is how it looks
![Screen_Shot_2020-08-19_at_2.33.52_PM](/uploads/7f3a15ac5a07104926c78d77c9ff168d/Screen_Shot_2020-08-19_at_2.33.52_PM.png)
I think we should set exception handling 'some...When there is a problem upgrading via drush this is how it looks
![Screen_Shot_2020-08-19_at_2.33.52_PM](/uploads/7f3a15ac5a07104926c78d77c9ff168d/Screen_Shot_2020-08-19_at_2.33.52_PM.png)
I think we should set exception handling 'somewhere' & my current best guess as to where is
--- a/CRM/Upgrade/Headless.php
+++ b/CRM/Upgrade/Headless.php
@@ -30,6 +30,8 @@ class CRM_Upgrade_Headless {
set_time_limit(0);
}
+ // As long as the error scope is not deconstructed exceptions will be thrown.
+ $errorScope = CRM_Core_TemporaryErrorScope::useException();
$upgrade = new CRM_Upgrade_Form();https://lab.civicrm.org/dev/user-interface/-/issues/27Bootstrap3 CSS2022-12-14T16:05:01ZtottenBootstrap3 CSS## Definitions
* __Look and Feel__: A visual appearance that can be recognized by a user of a page.
* __CSS Vocabulary__: A list of CSS classes that are agreed upon as a contract between a theme and an app-page. Example: "Bootstrap CSS ...## Definitions
* __Look and Feel__: A visual appearance that can be recognized by a user of a page.
* __CSS Vocabulary__: A list of CSS classes that are agreed upon as a contract between a theme and an app-page. Example: "Bootstrap CSS v3", "Bootstrap CSS v4", "crm-*"
* __Application Page__: A business application which provides functionality/behavior. It is positioned as *consumer* of CSS vocabulary(ies). Example: CiviContribute's "Contribution Page", CiviMail's "New Mailing" page, or CiviVolunteer's "Assign Volunteers" page.
* __Civi Theme__: A CiviCRM package which defines a look-and-feel. It is positioned as a *provider* of CSS vocabulary(ies). Example: Shoreditch
* __CMS Theme__: A package for a CMS which defines a look-and-feel. It is positioned as a *provider* of CSS vocabulary(ies). Example: Drupal Garland, WP Twenty Seventeen
* __Civi-Optimized Theme__: A package which defines a look-and-feel that is specifically intended to work with CiviCRM. Some CMS themes may be "Civi-optimized" (even if they are not specificallly packaged as a "CiviCRM extension").
* __Resource__: A resource is some artifact-- CSS file, CSS snippet, JS file, JS snippet, JS setting, et al -- that can be added to a page.
* __Resource Bundle__: A bundle is a list of related resources that are loaded together.
## Expectations
1. I am a novice site-builder who relies on some default/widespread theme. I expect that CiviCRM will look coherent out-of-the-box. If this expectation is unmet, I will assume that CiviCRM is broken.
2. I am a mid-level (or higher) site-builder who researches and configures various addons. I may be using a theme that is neither default/widespread nor specific/optimized to CiviCRM. I also expect that CiviCRM will look coherent. However, I have greater tolerance for challenges: if my expectation cannot be met out-of-the-box, then I may spend some effort to make it work... *provided that the configuration game is communicated clearly*.
3. I am an application developer with a specialization in CiviCRM. I expect there to be a well-defined CSS vocublary that I can rely upon when writing application pages. I expect the CSS vocabulary to be equally supported in all environs.
4. I am a theme designer/developer with a specialization in CiviCRM. I expect there to be a well-defined CSS vocabulary that I can target when writing CSS rules. I anticipate some interaction between CMS theming and Civi theming, and I expect a clear relation between them.
## General Thoughts
* It is possible to implement any "CSS Vocabulary" in any "CMS Theme" or "Civi Theme". Just create another `.css` file.
* The CSS vocabulary for "Bootstrap3" is well-defined, well-documented, stable. The CSS vocabulary for "crm-*" is (in relative terms) more fluid and not as well-documented.
* Within any given page-request, there are 0-1 active CMS themes and 0-1 active Civi themes. (Internally, some themes may be built on top of one another. For our purposes, such details are encapsulated witin the theme such that we may set aside those details while considering the protocol.)
* The upshot of a "Civi Theme" is that it can provide additional CSS vocabularies that are not universally available within CMS ecosystems. The flip-side is that the look-and-feel may be mismatched.
* If the concurrent "CMS Theme" and "Civi Theme" both implement support for the same CSS vocabulary, then (logically) this is a conflict. The "CMS Theme" is generally required for other purposes (outside our purview), so it must be left active. The conflict may have a few outcomes:
* ~~(Mixed) If we proceed with loading both CMS+Civi theme CSS, and if both use broad selectors, then the look-and-feel will be the arbibtrary combination of both (spread across the page).~~
* (Split) If we proceed with loading both CMS+Civi theme CSS, and if Civi's selectors are carefully tuned, then the look-and-feel have single, distinct split in the look-and-feel (different L&F on "Civi pages" and "CMS pages").
* (Yield) If we omit the the Civi theme CSS for that vocabulary, and if the vocabulary providers really are interchangeable, then we get one L&F across all "Civi pages" and "CMS pages". (At least, for pages based on the duplicate vocabulary. Other Civi pages may use other vocabularies which are not supported by the CMS theme.)
* Note: None of these outcomes is necessarily best or optimal... the "best" will be in a state of flux as support for different vocabularies and different L&Fs change. The choice is subjective.
* In discussing themes, we often distinguish between a frontend and backend policy. If there's a manual on/off switch for "bootstrap3", should it discern between frontend/backend?
* At first, I thought "yes", because that's usually articulate decision-making wrt frontend vs backend.
* On second thought, aren't we using "frontend/backend" as a proxy for identifying the *particular theme* that is active on the frontend/backend? ie The provisioning of `bootstrap3` is a chacateristic of that theme.
## Current behavior
In `shoreditch`, one activates the extension and chooses "Shoreditch" as the activ etheme- and then its bundle of `bootstrap3` resources is loaded on every page.
## New behavior
* __Application Page__: An application-page signals the need for Bootstrap3 vocabulary by calling
```php
Civi::resources()->addBundle('bootstrap3');
```
* __Civi Theme (Basic)__: A theme may define the content of `bootstrap3` bundle by file-convention, ie
* Implement `hook_civicrm_themes` to declare the theme
* Create the files `css/bootstrap3.css` and `js/bootstrap3.js`
* __Civi Theme (Advanced)__: A theme may define the contenf of `bootstrap3` bundle by hook, ie
* Implement `hook_civicrm_themes` to declare the theme
* Implement `hook_civicrm_alterBundle` and filter/revise/override/supplement the list of resources inside of `bootstrap3`.
```php
Civi::dispatcher()->addListener('hook_civicrm_alterBundle', function($e){
if ($e->bundle->name === 'bootstrap3') {
$e->bundle->update('civicrm:css/bootstrap.css', [
'type' => 'scriptUrl',
'scriptUrl' => Civi::service('asset_builder')->getUrl('...');
]);
}
});
```
* __Conflict Resolution__: The default policy is to "(Split)" L&F between CMS+Civi, but there are counterplays.
* To wit: if Shoreditch is active on a page, and if the page needs Bootstrap3, then (by deafult) it loads Shoreditch's `bootstrap3` - regardless of whether the CMS provides `bootstrap3` by other means. This provides more internal consistency (e.g. `bootstra.css`/`civicrm.css`) and more cross-site consistency (e.g. different sites with different CMS themes chosen by different people => but shoreditch always behaves the same).
* For a Civi-optimized CMS theme, the developer may implement `hook_civicrm_alterBundle` and toggle `$bundle->isActive`.
```php
Civi::dispatcher()->addListener('hook_civicrm_alterBundle', function($e){
// mycmstheme has built-in, global support for bootstrap3.
if ($e->bundle->getName() === 'bootstrap3' && $e->bundle->getActive() === 'auto' && cms_active_theme() === 'mycmstheme') {
$bundle->setActive(FALSE);
}
}, 1000);
```
* For a local override, the site-builder may configure the setting `array theme_bundles` - ie `$themeBundles[$cmsThemeName][$bundleName] === TRUE|FALSE|auto'`.https://lab.civicrm.org/dev/core/-/issues/1957Profile post-help text not shown on contribution pages2023-04-16T05:03:21ZrebeccatregennaProfile post-help text not shown on contribution pagesOverview
----------------------------------------
Where a profile has Post-form Help text entered it is not shown on contribution pages where the profile is in use (the Pre-form Help however displays as expected)
This applies to new pro...Overview
----------------------------------------
Where a profile has Post-form Help text entered it is not shown on contribution pages where the profile is in use (the Pre-form Help however displays as expected)
This applies to new profiles as well as some existing profiles (e.g. '[Profile Settings - Supporter Profile](https://dmaster.demo.civicrm.org/civicrm/admin/uf/group/update?action=update&id=2&context=group)' on dmaster)
Reproduction steps
----------------------------------------
1. Add/update/check for Post-form Help on a profile and **Save** (e.g. Supporter Profile)
1. Add the profile to a contribution page and **Save** (e.g. '[Member Signup and Renewal])(https://dmaster.demo.civicrm.org/civicrm/admin/contribute/custom?action=update&reset=1&id=2)'
![formhelptext](/uploads/98af82a6eaf61fafec00c5bea509cc16/formhelptext.png)
Current behaviour
----------------------------------------
The contribution page shows the the pre-form help but not the post-form help text
![contributionpage](/uploads/6504a02386372d08aa015331238e89f9/contributionpage.png)
Expected behaviour
----------------------------------------
The contribution page shows both the pre-form help and the post-form help text
Environment information
----------------------------------------
Tested on [dmaster.demo.civicrm.org](https://dmaster.demo.civicrm.org/) 5.30.alpha1
Tested on Chrome, Firefox and Safari (on mobile)https://lab.civicrm.org/dev/core/-/issues/1956Typo in groups dropdown on scheduled reminders admin form2020-09-03T00:38:33ZDaveDTypo in groups dropdown on scheduled reminders admin formThis is similar to https://github.com/civicrm/civicrm-core/pull/18154 but it's not as clear that the original intent was correct.
In [the form](https://github.com/civicrm/civicrm-core/blob/5.28.0/CRM/Admin/Form/ScheduleReminders.php#L25...This is similar to https://github.com/civicrm/civicrm-core/pull/18154 but it's not as clear that the original intent was correct.
In [the form](https://github.com/civicrm/civicrm-core/blob/5.28.0/CRM/Admin/Form/ScheduleReminders.php#L253) you have the option to limit to groups, and it seems like it was intended to limit to mailing groups but is missing the first parameter so it shows all.
But for these you might want to send to internal groups or admins, and given that it has showed all groups for a while I'd argue to just remove the parameter completely to explicitly show all.5.30.0https://lab.civicrm.org/dev/core/-/issues/1955Incorrect Resource URL2023-04-20T05:03:27ZresgaIncorrect Resource URLUsing Drupal 7.72 and CiviCRM 5.28.0, I get this alert on the front page:
> <h1>Incorrect Resource URL</h1>
> The Resource URL is not set correctly. Please set the <a href="/civicrm/admin/setting/url?reset=1">CiviCRM Resource URL</a>
> ...Using Drupal 7.72 and CiviCRM 5.28.0, I get this alert on the front page:
> <h1>Incorrect Resource URL</h1>
> The Resource URL is not set correctly. Please set the <a href="/civicrm/admin/setting/url?reset=1">CiviCRM Resource URL</a>
> <p><a href="/civicrm/a/#/status">View details and manage alerts</a></p>
Settings on the "Settings - Resource URLs" page (`/civicrm/a/#/status`):
`CiviCRM Resource URL:
[cms.root]/sites/all/modules/civicrm/`
`Image Upload URL:
[cms.root]/sites/default/files/civicrm/persist/contribute/`
```
Disable CiviCRM css:
Yes
x No
```
`Extension Resource URL:
[civicrm.root]/ext/`
Do the settings look correct? Are the recommended settings documented somewhere? Also, is there way I can get more details about how they fail, to better debug this issue?https://lab.civicrm.org/dev/core/-/issues/1954Country field is validated within the billing block by jquery even when not s...2020-08-16T22:35:00ZseamusleeCountry field is validated within the billing block by jquery even when not showing e.g user has selected a $0 optionOverview
----------------------------------------
When you have a contribution page and there is a free option ($0) if you do not have a default country set then on a stick CiviCRM you will not be able to move to the next step when submi...Overview
----------------------------------------
When you have a contribution page and there is a free option ($0) if you do not have a default country set then on a stick CiviCRM you will not be able to move to the next step when submitting a public contribution as jQuery tries to validate the country field
Reproduction steps
----------------------------------------
1. Ensure that under the languages / currency settings there is no default country set.
1. Create a new contribution page ensuring that in the amounts tab you include a free option
1. Try and submit a new contribution as an anon user
Current behaviour
----------------------------------------
Cannot submit contribution as jQuery tries to validate the off screen country field
Expected behaviour
----------------------------------------
Form should be submitted
Environment information
----------------------------------------
* __CiviCRM:__ _5.28.0_https://lab.civicrm.org/dev/core/-/issues/1953Credit card fields still required when a $0 option is selected on event regis...2020-08-14T23:18:25Zmark-rodgers11markrodgers11@gmail.comCredit card fields still required when a $0 option is selected on event registration/contribution pageOverview
----------------------------------------
When submitting an event registration (or contribution page form) with a $0 price option selected the form fails validation, despite credit card fields being hidden. I noticed this on a C...Overview
----------------------------------------
When submitting an event registration (or contribution page form) with a $0 price option selected the form fails validation, despite credit card fields being hidden. I noticed this on a CiviCRM website I manage, reproduced on the circle interactive demo site, also @KarinG reproduced this on yet another site.
https://chat.civicrm.org/civicrm/pl/aer7pqut5b85t8ab83ax3iko3o
Reproduction steps
----------------------------------------
1. Go to an event registration page (or contribution page)
2. Select $0 price option
3. Submit form
Current behaviour
----------------------------------------
![image](/uploads/198a46411385f82538500f2a1d34e940/image.png)
Expected behaviour
----------------------------------------
Credit card fields should not be required when they're hidden.
Environment information
----------------------------------------
* __Browser:__ Chrome 84.0.4147.89
* __CiviCRM:__ 5.28.0
* __PHP:__ 7.2.31
* __CMS:__ Drupal 7.72
* __Database:__ MySQL 5.7.31
* __Web Server:__ _Apache 2.4.46
Comments
----------------------------------------
Works as intended on CiviCRM 5.26.2 but not 5.28.05.28.1https://lab.civicrm.org/dev/core/-/issues/1951Dates in event (and likely other) pages show in site locale rather than curre...2023-04-19T20:37:52ZKeith NunnDates in event (and likely other) pages show in site locale rather than current user localeOverview
----------------------------------------
_Please describe your problem or bug in detail._
When Mutlilang is enabled on Civi, translation works well for everything except date display. This is mostly only an issue for event inf...Overview
----------------------------------------
_Please describe your problem or bug in detail._
When Mutlilang is enabled on Civi, translation works well for everything except date display. This is mostly only an issue for event info pages, but will happen anywhere that a date is displayed as part of the page content. I just made a sample event (with nearly nothing in it) on the demo site to show what happens. This link goes to the french version and the whole page is translated, but the date is still in English.
`https://dmaster.demo.civicrm.org/civicrm/event/info?reset=1&id=7&lcMessages=fr_CA`
I have done a little exploring in civicrm/CRM/Core/I18n.php and /civicrm/CRM/Utils/Date.php and found that the methods seem to be locale aware, but appear to use a more global locale (CiviCRM default, Wordpress default, or maybe System
[Stackexchange question](https://civicrm.stackexchange.com/questions/35468/date-in-english-even-when-page-is-set-to-french?noredirect=1#comment42248_35468)
Reproduction steps
----------------------------------------
1. make site multilingual and ensure there is more than one language. In my case english (default) and french (additional)
1. create an event and set basic information including a future date. save
1. view the info page in french by adding &lcMessages=fr_CA to the URL
1. the page will show in french, but the date format and language of month and day names will be in english.
Current behaviour
----------------------------------------
Date is rendered in default languange
![image](/uploads/85480ee9051c152c45a5c220d84be150/image.png)
Expected behaviour
----------------------------------------
Date should be rendered in the language that the browser requested
Environment information
----------------------------------------
Happens in every environment and version I have tested including the test site at dmaster.demo.civicrm.org
Comments
----------------------------------------https://lab.civicrm.org/dev/drupal/-/issues/133Breadcrumb error on CiviCRM admin pages (Drupal 8)2023-12-13T17:46:26ZW01FBreadcrumb error on CiviCRM admin pages (Drupal 8)Getting the following error on several CiviCRM admin pages, including /civicrm/admin
```
Warning: Invalid argument supplied for foreach() in CRM_Utils_System_Drupal8->appendBreadCrumb() (line 190 of /home/customer/www/youpickfarms.org/v...Getting the following error on several CiviCRM admin pages, including /civicrm/admin
```
Warning: Invalid argument supplied for foreach() in CRM_Utils_System_Drupal8->appendBreadCrumb() (line 190 of /home/customer/www/youpickfarms.org/vendor/civicrm/civicrm-core/CRM/Utils/System/Drupal8.php).
CRM_Utils_System_Drupal8->appendBreadCrumb('Administer CiviCRM', '/civicrm/admin?reset=1') (Line: 60)
CRM_Utils_System::__callStatic('appendBreadCrumb', Array) (Line: 76)
CRM_Contact_Form_Domain->preProcess() (Line: 599)
CRM_Core_Form->buildForm() (Line: 120)
CRM_Core_StateMachine->perform(Object, 'next', 'Next') (Line: 45)
CRM_Core_QuickForm_Action_Next->perform(Object, 'next') (Line: 203)
HTML_QuickForm_Controller->handle(Object, 'next') (Line: 103)
HTML_QuickForm_Page->handle('next') (Line: 347)
CRM_Core_Controller->run() (Line: 98)
CRM_Utils_Wrapper->run('CRM_Contact_Form_Domain', 'Organization Address and Contact Info', Array) (Line: 285)
CRM_Core_Invoke::runItem(Array) (Line: 68)
CRM_Core_Invoke::_invoke(Array) (Line: 36)
CRM_Core_Invoke::invoke(Array) (Line: 88)
Drupal\civicrm\Civicrm->invoke(Array) (Line: 80)
Drupal\civicrm\Controller\CivicrmController->main(Array, '')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
```5.70.0https://lab.civicrm.org/dev/core/-/issues/1949Payment method should reflect the last transaction on the contribution2020-09-09T05:18:38ZyashodhaPayment method should reflect the last transaction on the contributionPayment method should reflect the last transaction on the contribution.
When the payment method is updated on the contribution, the system creates a new payment record with the new payment method attached to the contribution.
When the ...Payment method should reflect the last transaction on the contribution.
When the payment method is updated on the contribution, the system creates a new payment record with the new payment method attached to the contribution.
When the contribution is saved, we must update the payment method field on the contribution with the payment method on the most recent payment record attached to that contribution.
I know we are planning on dropping the payment method on contribution and just have it for individual transaction but till the time it does exist it should have the correct value.
Create a contribution which is pay later by check
![pay_later](/uploads/73fda0162672541c39db8f212f945f59/pay_later.png)
Record payment complete with method Cash
![new_payment](/uploads/5c721d3cf7f0d40daf02373a7ce28916/new_payment.png)
It doesn't reflect
![payment_view](/uploads/72697eeae2a99dee75dcc519ece65b97/payment_view.png)5.31.0https://lab.civicrm.org/dev/core/-/issues/1946Batch Update via Profile does not supply data for editing when custom fields ...2023-04-19T05:03:26ZmarshBatch Update via Profile does not supply data for editing when custom fields created after participant added to eventOverview
----------------------------------------
When trying to "update via Profile" on event participants, some of the custom fields for specific roles do not pull through to the form for editing.
Reproduction steps
------------------...Overview
----------------------------------------
When trying to "update via Profile" on event participants, some of the custom fields for specific roles do not pull through to the form for editing.
Reproduction steps
----------------------------------------
2. add a participant to an event
1. create custom fields for participants
- [add fields page](https://dmaster.demo.civicrm.org/civicrm/admin/custom/group?reset=1)
- name: test participant
- used for: Participants (Event Name) > Select three (not sure if 'All' will reproduce)
- Add field
- simple radio field will do
2. Administer profiles > reserved profile > "Participant Status" profile > fields
- add fields
- add the 'test participant' radio button fields created above
1. do participant search for participant created at step 1.
1. select the created participant
1. actions > update via profile
1. select profile Participant Status
Current behaviour
----------------------------------------
notice the radio field created column is there, but does not contain any data or data structure for the participant
Expected behaviour
----------------------------------------
All participants have the custom fields pull through
Environment information
----------------------------------------
* CiviCRM 5.24.4
* __PHP:__ 7.3
* __CMS: Drupal-7.72
* __Database:__ _MySQL 5.7.7
* __Web Server: Nginxhttps://lab.civicrm.org/dev/core/-/issues/1945[Regression] Users without permission can edit recurring contributions2020-08-20T10:27:28Zjensschuppe[Regression] Users without permission can edit recurring contributionsOverview
----------------------------------------
Users _without_ the permission "edit contributions" can edit _recurring_ contributions of any contact (might be mitigated by specific scenarios, see below).
Reproduction steps
----------...Overview
----------------------------------------
Users _without_ the permission "edit contributions" can edit _recurring_ contributions of any contact (might be mitigated by specific scenarios, see below).
Reproduction steps
----------------------------------------
1. Create a user with a role that has only the following permissions:
* CiviCRM: access CiviCRM backend and API
* CiviContribute (Contributions): access CiviContribute
but explicitly _not_ the "CiviContribute (Contributions): Edit Contributions" permission
2. _Configure an ACL for them to view contacts in a specific group and their contributions._ - not sure this is necessary
3. With that user logged in, go to any visible contact's Contributions tab and the Recurring Contributions sub tab
Current behaviour
----------------------------------------
The user is presented links to edit recurring contributions and clicking it also shows the form. Saving the form is also allowed.
Expected behaviour
----------------------------------------
Editing should not be allowed, i.e. there should be no _Edit_ link at all and opening the forms should result in a 404.
Environment information
----------------------------------------
* __CiviCRM:__ 5.24.5
* __CMS:__ Drupal 7.30
Comments
----------------------------------------
This seems to have been introduced as a regression with https://github.com/civicrm/civicrm-core/pull/13237 which originated in #571.
The compared contact ID is retrieved using `$this->getContactID()` which calls `CRM_Core_Form::setContactID()` which states the following in its docblock:
```php
/**
* Get contact if for a form object. Prioritise
* - cid in URL if 0 (on behalf on someoneelse)
* (@todo consider setting a variable if onbehalf for clarity of downstream 'if's
* - logged in user id if it matches the one in the cid in the URL
* - contact id validated from a checksum from a checksum
* - cid from the url if the caller has ACL permission to view
* - fallback is logged in user (or ? NULL if no logged in user) (@todo wouldn't 0 be more intuitive?)
*
* @return NULL|int
*/
```
The relevant part seems to be: __`cid from the url if the caller has ACL permission to view`__, but I couldn't verify yet, since it's a production system this is appearing on.
Background: The scenario is a _regional department_ user (being restricted to viewing contacts of a specific regional group only - which is done using ACLs), who should be allowed to view contributions, but not edit them at all.
Since the aforementioned issue tried to bypass access checks for editing one's own recurring contributions, I'm not sure this is a correct assumption at all. There should be a separate permission for controlling whether editing own recurring contributions is allowed.5.28.1https://lab.civicrm.org/dev/core/-/issues/1944Add new columns to mailing summary report2020-08-12T18:22:51ZyashodhaAdd new columns to mailing summary reportAdd new columns to mailing summary report
- Sender name
- Sender emailAdd new columns to mailing summary report
- Sender name
- Sender email5.30.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/1943Fix : Enable Drupal Watchdog Logging for Drupal 82020-08-10T21:07:07ZsunilFix : Enable Drupal Watchdog Logging for Drupal 8Overview
----------------------------------------
Currently We have Setting to log CiviCRM Error Log to Drupal Access Log, but functionality in code is not present.
Current behaviour
----------------------------------------
Code not pre...Overview
----------------------------------------
Currently We have Setting to log CiviCRM Error Log to Drupal Access Log, but functionality in code is not present.
Current behaviour
----------------------------------------
Code not present of Functionality present at /civicrm/admin/setting/debug?reset=1, `Enable Drupal Watchdog Logging`
Proposed behaviour
----------------------------------------
After changes, it will start logging into Drupal log if `Enable Drupal Watchdog Logging` is enabled.
https://github.com/civicrm/civicrm-core/pull/181155.30.0https://lab.civicrm.org/dev/core/-/issues/1942Multiple Memberships Status Not updated when payment status changed from pend...2020-10-09T21:08:23ZsunilMultiple Memberships Status Not updated when payment status changed from pending to CompletedOverview
----------------------------------------
Pending Membership (multiple) created through Webform not updated in CiviCRM when Payment Status changed from Pending (paylater) to Completed.
Reproduction steps
------------------------...Overview
----------------------------------------
Pending Membership (multiple) created through Webform not updated in CiviCRM when Payment Status changed from Pending (paylater) to Completed.
Reproduction steps
----------------------------------------
1. Create Webform in Drupal 7/8, Enable multiple contacts for Membership Signup/renew.
2. Each contact can choose different/same membership type (-- User Select -- option for Membership Type)
3. When form is submitted. Contribution Record created and Multiple membership created and these memberships linked to same contribution record in **civicrm_membership_payment** table
4. In this scenario, All contact have chosen Same Membership Types
Current behaviour
----------------------------------------
at backend, when Contribution/payment record status changed from Pending (Pay_later) to Completed, only last membership record from `civicrm_membership_payment` against contribution record get updated to New/Current, other membership status remain Pending.
Note : This is no Inherited Membership, Each contact get Direct Membership for Same Contribution Record.
e.g. IF 3 person signup for General Membership. then in `civicrm_membership_payment` table we have 3 entries of membership record with common contribution id.
Expected behaviour
----------------------------------------
All Pending Membership Status should change to New/Current.
https://github.com/civicrm/civicrm-core/pull/181135.31.1https://lab.civicrm.org/dev/core/-/issues/1941Required Fields in Onbehalf of an Organization look not Required after donor ...2023-04-16T05:03:21ZKarinGRequired Fields in Onbehalf of an Organization look not Required after donor uses the Go Back button on Confirm page [Regression]When reviewing/testing https://github.com/civicrm/civicrm-core/pull/18102 - I noticed a small ad-hoc regression. Seamus asked me to log a new lab ticket.
-> none of the I'm contributing on behalf of an organization look required if a d...When reviewing/testing https://github.com/civicrm/civicrm-core/pull/18102 - I noticed a small ad-hoc regression. Seamus asked me to log a new lab ticket.
-> none of the I'm contributing on behalf of an organization look required if a donor changes their mind and hits the go back button on the confirm page. This was definitively not the case before the jquery PRs on Contribution pages:
**Reproducing this on dmaster:**
https://dmaster.demo.civicrm.org/civicrm/contribute/transact?reset=1&id=4
![image](https://user-images.githubusercontent.com/5340555/89713968-9ba73f00-d958-11ea-9d8f-f1e6017da783.png)
Hitting Review Contribution -> CiviCRM does remember that these were required after all - except for State/Province ?!
![image](https://user-images.githubusercontent.com/5340555/89714007-d01afb00-d958-11ea-8af2-cd36658e4723.png)https://lab.civicrm.org/dev/core/-/issues/1940Remove language column from civicrm_ufmatch table2023-04-13T05:03:16Zmattwiremjw@mjwconsult.co.ukRemove language column from civicrm_ufmatch tableFollow up to #1891 we should actually remove the column after a few versions (change was merged in 5.29 so 5.32?).Follow up to #1891 we should actually remove the column after a few versions (change was merged in 5.29 so 5.32?).