Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-07-28T01:08:46Zhttps://lab.civicrm.org/dev/core/-/issues/2705CiviCRM not wrapping long lines in emails2021-07-28T01:08:46ZSandor SemseyCiviCRM not wrapping long lines in emailsOverview
----------------------------------------
CiviMail (and FlexMailer) does not break lines in emails. The SMTP protocol only allows 1000 chars per line. So on a mailserver this wrapping is enforced and it can cause DKIM signatures ...Overview
----------------------------------------
CiviMail (and FlexMailer) does not break lines in emails. The SMTP protocol only allows 1000 chars per line. So on a mailserver this wrapping is enforced and it can cause DKIM signatures to get invalid.
Further [details](https://civicrm.stackexchange.com/questions/39172/line-wrapping-breaking-lines-longer-than-998-characters-in-civicrm-civimail).
Reproduction steps
----------------------------------------
1. Go to **Mailings >> New Mailing**
1. Create Email with a line with more than 1000 chars.
1. Send Email (you can redirect to DataBase)
1. Inspect sent email
Current behaviour
----------------------------------------
Lines are not wrapped.
Expected behaviour
----------------------------------------
Lines should be hard-wrapped (inserting a line break) after a specified number of characters (I would suggest a default for 990).
Comments
----------------------------------------
If this gets confirmed, we are to happy to jump in and implement this functionality.5.29.0Sandor SemseySandor Semseyhttps://lab.civicrm.org/dev/wordpress/-/issues/108Issue with Gmail Adresses2021-07-20T12:57:07ZGahrtIssue with Gmail AdressesIf I want to send an email via CiviCRM to a contact who uses googlemail, the system turns e.g. max.muster@googlemail.com into maxmuster@gmail.com and
max.muster@gmail.com into at maxmuster@gmail.com.
For other addresses the dot is not ...If I want to send an email via CiviCRM to a contact who uses googlemail, the system turns e.g. max.muster@googlemail.com into maxmuster@gmail.com and
max.muster@gmail.com into at maxmuster@gmail.com.
For other addresses the dot is not removedhttps://lab.civicrm.org/dev/core/-/issues/2704Search kit request - calculated field in display2023-07-31T14:53:02ZeileenSearch kit request - calculated field in displayFeature request for the option to have calculated fields in search displays e.g a field that displays SUM('custom_money_field' + 'total_amount') - or COALLESCE('nick_name', 'first_name')Feature request for the option to have calculated fields in search displays e.g a field that displays SUM('custom_money_field' + 'total_amount') - or COALLESCE('nick_name', 'first_name')https://lab.civicrm.org/dev/core/-/issues/2703Not possible to set the location type (address, mail, telephone) to a specifi...2021-08-31T08:28:06ZNadaillacNot possible to set the location type (address, mail, telephone) to a specific valueWhen I create a form, I would prefer to set the mail type to a specific value and not present this field to the user. Like in a CiviCRM profile.
I cannot find the field in the list of fields for the values to be set.
![Address_type](/u...When I create a form, I would prefer to set the mail type to a specific value and not present this field to the user. Like in a CiviCRM profile.
I cannot find the field in the list of fields for the values to be set.
![Address_type](/uploads/b7b7db251b7aa404cc0a0d94a6fbe8fc/Address_type.png)colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/2702Cannot set contact subtype value for individual if organisation tab is created2021-08-04T06:13:04ZNadaillacCannot set contact subtype value for individual if organisation tab is createdIn Formbuilder, I create a tab individual, set a subtype contact to "Contact of NGO", I create an activity tab, and as soon as I create a organisation tab "NGO", the value in the individual subtype is not set anymore and the options that...In Formbuilder, I create a tab individual, set a subtype contact to "Contact of NGO", I create an activity tab, and as soon as I create a organisation tab "NGO", the value in the individual subtype is not set anymore and the options that are presented are organisation subtype (instead of individual)
![Bug_1](/uploads/2aaa7b2052c1d37a85d75d01e1ff8fae/Bug_1.png)
![Bug_2](/uploads/dd976e00f53dad6567d1d60e3ea6469b/Bug_2.png)
![Bug_3](/uploads/b180c4d3f436d4bfdcd97715cb50364a/Bug_3.png)5.41.0colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/2701(Smart Group) is being constantly added while editing the smart group title f...2021-08-25T01:48:12ZMonish Deb(Smart Group) is being constantly added while editing the smart group title from 'Manage Group' page Steps to replicate:
1. Go to 'Manage Group'
2. Inline edit any smart group title by clicking on the title.
Error
-----
On the input text field "(Smart Group)" is added which is not a part of group title. And one need to constantly rem... Steps to replicate:
1. Go to 'Manage Group'
2. Inline edit any smart group title by clicking on the title.
Error
-----
On the input text field "(Smart Group)" is added which is not a part of group title. And one need to constantly remove the "(Smart Group)" text in order to retain the original or modified group title.
![before](/uploads/0f5b230f41b006760128c864c2b3ffa2/before.gif)5.42.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/2700Enhance test-drive bevhaviour and associated wording2023-09-08T05:03:14ZrebeccatregennaEnhance test-drive bevhaviour and associated wordingOverview
----------------------------------------
At the moment test-drive transactions are not recorded consistently for memberships and events nor does the current intro text for test-drive mode reflects what is actually happening.
Ex...Overview
----------------------------------------
At the moment test-drive transactions are not recorded consistently for memberships and events nor does the current intro text for test-drive mode reflects what is actually happening.
Example use-case
----------------------------------------
1. Join as a member with [&action=preview](https://dmaster.demo.civicrm.org/civicrm/contribute/transact?reset=1&id=2&action=preview)
1. Register for an event with [&action=preview](https://dmaster.demo.civicrm.org/civicrm/event/register?reset=1&action=preview&id=1)
Current behaviour
----------------------------------------
**Memberships**
The info text on the join pages states:
> This page is currently running in test-drive mode. Transactions will be sent to your payment processor's test server. No live financial transactions will be submitted. However, a contact record will be created or updated and a test contribution record will be saved to the database. Use obvious test contact names so you can review and delete these records as needed. **Test contributions are not visible on the Contributions tab, but can be viewed by searching for 'Test Contributions' in the CiviContribute search form.** Refer to your payment processor's documentation for information on values to use for test credit card number, security code, postal code, etc.
However both the contribution and membership entries are displayed on the contact's record on the necessary tab:
![active_membership](/uploads/f190e74461e0cd6f407ebdc9bc9dde5c/active_membership.png)
![active_contributions](/uploads/bdf686fecbeb65a82445a9a50fde492f/active_contributions.png)
**Events**
The info text on the event pages states:
> Test-drive Your Event Registration Page This page is currently running in test-drive mode. If this is a paid event, transactions will be sent to your payment processor's test server. No live financial transactions will be submitted. However, a contact record will be created or updated and test event registration and contribution records will be saved to the database. Use obvious test contact names so you can review and delete these records as needed. Refer to your payment processor's documentation for information on values to use for test credit card number, security code, postal code, etc.
As mentioned above, again also visible on the Contributions tab but unfortunately not displayed as a test registrations on the Events tab.
![active_events](/uploads/869dd4b91a008358ff7d8c7e8e9e9c21/active_events.png)
Proposed behaviour
----------------------------------------
Agree consistent behaviour, i.e.:
- Show the test event registration on the contact Event tab (as it does for membership)
- Update the info text to ensure it aligns with what is actually being shown / recorded where
Comments
----------------------------------------
Tested on dmaster.demo.civicrm.org 5.41.alpha1https://lab.civicrm.org/dev/wordpress/-/issues/107WordPress basepage_render shouldn't remove the 'the_content' filter2023-07-26T15:45:51ZchriscantWordPress basepage_render shouldn't remove the 'the_content' filterOn a WordPress CiviCRM site using the Avada theme, removing the 'the_content' filter in basepage_render() in here causes a problem:
https://github.com/civicrm/civicrm-wordpress/blob/master/includes/civicrm.basepage.php
basepage_render()...On a WordPress CiviCRM site using the Avada theme, removing the 'the_content' filter in basepage_render() in here causes a problem:
https://github.com/civicrm/civicrm-wordpress/blob/master/includes/civicrm.basepage.php
basepage_render() is called from wp_trim_excerpt() first and then is called again somewhere to get the content to display the page. If the filter removes itself then the page content isn't replaced with the CiviCRM output.
When displaying /civicrm pages the holding page content is erroneously shown: "Do not delete this page. Page content is generated by CiviCRM."
So this commit needs reversing, which looks like it has only recently been included in 5.39.0:
https://github.com/civicrm/civicrm-wordpress/commit/16137ebf4038e901fb4981d7de2c328d96411fe9https://lab.civicrm.org/dev/core/-/issues/2699Failing api4 test api.v4.Action.CreateWithOptionGroupTest.testWithCustomDataF...2021-07-21T20:07:07ZDaveDFailing api4 test api.v4.Action.CreateWithOptionGroupTest.testWithCustomDataForMultipleContactsSo the BAO CustomField looks maybe buggy to me. At [this line](https://github.com/civicrm/civicrm-core/blob/d5cb55868ef0f1f173f678780e4cba7b53552891/CRM/Core/BAO/CustomField.php#L2016-L2017), it says for almost any type except text, let'...So the BAO CustomField looks maybe buggy to me. At [this line](https://github.com/civicrm/civicrm-core/blob/d5cb55868ef0f1f173f678780e4cba7b53552891/CRM/Core/BAO/CustomField.php#L2016-L2017), it says for almost any type except text, let's see about creating an option group. And then it says, partly, if it's a new field and there's no option_group_id specified, let's create a dummy one for it with `name` based on timestamp. Unless you've passed in the magic number 2.
Since in unit tests the timestamp is almost constant, you get a duplicate sometimes if the second hasn't rolled over yet.
Or, the tests should clean up the dummy option groups too.
FYI @colemanw @eileen @seamuslee5.40.0https://lab.civicrm.org/dev/core/-/issues/2698add animation or redirect to extension installation screen during installation?2023-09-03T05:03:32Zananelsonadd animation or redirect to extension installation screen during installation?This is very much a would-be-nice-to-have
When you click "Download and Install" or "Uninstall" on the confirmation page for an extension installation or uninstallation, the only visual feedback that something is happening is the "loadin...This is very much a would-be-nice-to-have
When you click "Download and Install" or "Uninstall" on the confirmation page for an extension installation or uninstallation, the only visual feedback that something is happening is the "loading" animation provided by the browser. If you go do something else while the installation takes place (since it can often take a while) it can be easy to forget whether you've pushed the button already or not, and easy to miss the "loading" animation if you are distracted. Might it be possible to either (a) add some sort of javascript spinny widget while the process is running or (b) redirect to a different page while the process is running - to make it more obvious that there is a process running so you don't accidentally try to run it againhttps://lab.civicrm.org/dev/wordpress/-/issues/106Add shortcode support for profile map view2021-07-29T18:09:38ZKurund JalmiAdd shortcode support for profile map viewCurrently, map view for profile is not supported using shortcode.
I can't remember if it was there initially and was removed or was never implemented hence, wanted to check here.
I can add this feature and submit PR if everyone agrees :)Currently, map view for profile is not supported using shortcode.
I can't remember if it was there initially and was removed or was never implemented hence, wanted to check here.
I can add this feature and submit PR if everyone agrees :)5.41.0https://lab.civicrm.org/dev/core/-/issues/2697Contact acl caching - could it be even worse than we thought????2023-09-05T05:03:23ZeileenContact acl caching - could it be even worse than we thought????https://lab.civicrm.org/dev/core/-/issues/2696check admin menu from admin menu module is present before hiding CiviCRM menu...2023-09-03T05:03:31Zeileencheck admin menu from admin menu module is present before hiding CiviCRM menu toggle buttonI've opened this to track https://github.com/civicrm/civicrm-core/pull/19379
"Drupal 7 provide Toolbar module to show the admin menus, but does not provide drop down option of sub menus on mouse over. There is another module which is co...I've opened this to track https://github.com/civicrm/civicrm-core/pull/19379
"Drupal 7 provide Toolbar module to show the admin menus, but does not provide drop down option of sub menus on mouse over. There is another module which is commonly used is 'Admin Menu' which provide sub menu selection on mouse hover.
In CiviCRM, We have feature to toggle CiviCRM Menu if Drupal Admin menus are present. To check Drupal menu exist or not we refer toolbar module id #toolbar, In case site admin not using toolbar module and instead using 'Admin Menu' module.
The Admin menu generate different id #admin-menu, But civicrm only checking for #toolbar."https://lab.civicrm.org/dev/core/-/issues/2695Contact Logging Detail report can crash if it tries to query change records f...2023-09-02T05:03:23ZDaveDContact Logging Detail report can crash if it tries to query change records from log tables that don't have a contact_id fieldThere might be a couple issues so trying to collect some info.
Related PR https://github.com/civicrm/civicrm-core/pull/18937
CRM_Logging_Differ has both diffsInTable and diffsInTableForId. When CRM_Report_Form_Contact_LoggingDetail sta...There might be a couple issues so trying to collect some info.
Related PR https://github.com/civicrm/civicrm-core/pull/18937
CRM_Logging_Differ has both diffsInTable and diffsInTableForId. When CRM_Report_Form_Contact_LoggingDetail starts up it calls the second one. If that succeeds in getting some rows, which is usually the case, it **never calls diffsInTable**, but if it returns 0 rows then in CRM_Logging_ReportDetail::buildRows it tries again using diffsInTable. That's when the crash can occur. However, the only way at the moment I can reproduce this situation is when the first run of diffsInTableForId hits [this line regarding updates](https://github.com/civicrm/civicrm-core/blob/bdd0a3f9c7d44c499ff8c1c73890e079a56dd3b5/CRM/Logging/Differ.php#L207) which is never supposed to happen. But I do seem to have some such data, I just don't know how.
1. So one issue might be how is this data happening.
1. A second issue is why are there two functions that do things differently for this report depending on when they get called.
1. A third issue is if diffsInTable is necessary, the `switch` might be replaceable with data collected via DAO::referenceColumns() which happens early on in [CRM_Report_Form_Contact_LoggingDetail](https://github.com/civicrm/civicrm-core/blob/bdd0a3f9c7d44c499ff8c1c73890e079a56dd3b5/CRM/Report/Form/Contact/LoggingDetail.php#L24) but then that part of the info is discarded at [this point](https://github.com/civicrm/civicrm-core/blob/bdd0a3f9c7d44c499ff8c1c73890e079a56dd3b5/CRM/Logging/Schema.php#L1046) so would need to be kept or looked up again.https://lab.civicrm.org/dev/core/-/issues/2694What is the correct way to cancel an Event Registration that is marked Pendin...2023-09-06T05:03:19ZclementWhat is the correct way to cancel an Event Registration that is marked Pending Pay Later?Overview
----------------------------------------
we have been registering participants online for our paid events and marking them by default to "Pending Pay Later" status. However, when some of the participants cancels their registrati...Overview
----------------------------------------
we have been registering participants online for our paid events and marking them by default to "Pending Pay Later" status. However, when some of the participants cancels their registration and we go into their Contribution record to cancel those contribution, the Payment field will register a deficit amount equal to the event fee. Since payment was still pending when the cancellation of registration was made, we were expecting the payment amount to still be at zero.
i attach a screenshot of the contribution record of such a cancelled contribution to illustrate:
[screenshot]
![WHeZv](/uploads/cc9de4f94d2e4d0dbfeb466ee2a71bc2/WHeZv.png)
The Payment details (at the bottom of the screenshot) had Amount as $0 since this was "Pending Payment Later". But when we change the Contribution Status to "Cancelled" to indicate a cancellation of this registration, the Amount changed to "-$30" which was the fee for the event. this then affects the accounting as CIVICRM will think we are $30 short due to this cancellation.
Is it the case that "Cancelled" shouldn't be used in this case? We tried others and it seems "Failed" will cancel the event registration and not register any deficit in the payment. However, I would like to get the view of the community on whether this is the right way to cancel a event registration that is marked "Pending Pay Later"?
Also, if the behaviour of recording a deficit in Payment is correct when the event registration is changed to "Cancelled", what situation should this be used for ? Is it when a refund is due?
Thanks.
This problem was posted to StackExchange
https://civicrm.stackexchange.com/questions/39677/what-is-the-correct-way-to-cancel-an-event-registration-that-is-marked-pending-p
Reproduction steps
----------------------------------------
Online register at a CIVICRM event that allow Pay Later in cash
Cancel the registration in the backend
Check the payment record
Current behaviour
----------------------------------------
we have been registering participants online for our paid events and marking them by default to "Pending Pay Later" status. However, when some of the participants cancels their registration and we go into their Contribution record to cancel those contribution, the Payment field will register a deficit amount equal to the event fee. Since payment was still pending when the cancellation of registration was made, we were expecting the payment amount to still be at zero.
Expected behaviour
----------------------------------------
Since the event is "Pending Pay Later", cancellation should not incur any deficit amount in Payment but should be 0.
Environment information
----------------------------------------
[civicrm 5.10.4 - WP 5.3.2]
Comments
----------------------------------------https://lab.civicrm.org/dev/core/-/issues/2693Remove all calls to BAO_Contribution::completeOrder other than from Payment.c...2023-09-10T15:41:47ZeileenRemove all calls to BAO_Contribution::completeOrder other than from Payment.createThe goal is that we should either
1) call Payment.create to add a payment - which would itself call completeOrder
2) OR call repeatTransaction via the repeattransaction api to create a pending order - which we would then update to cance...The goal is that we should either
1) call Payment.create to add a payment - which would itself call completeOrder
2) OR call repeatTransaction via the repeattransaction api to create a pending order - which we would then update to cancelled or failed if need be or - if completed call payment.create
Note that currently Payment.create calls Contribution.completetransaction - the goal is to reverse this
I'm currently working on removing calls to completeOrder other than from the 2 api calls - at which point we can change the api calls to no longer call completeOrder directlyhttps://lab.civicrm.org/dev/core/-/issues/2692All the PR test sites are missing the civicrm_strip_non_numeric function2021-07-30T12:33:35ZDaveDAll the PR test sites are missing the civicrm_strip_non_numeric functionSo for example just edit a contact with a phone and save it -> crash.
But it doesn't seem to be a problem on dmaster.demo and I can't reproduce this doing a "normal" install, so I think it's something about how the PR test sites get bui...So for example just edit a contact with a phone and save it -> crash.
But it doesn't seem to be a problem on dmaster.demo and I can't reproduce this doing a "normal" install, so I think it's something about how the PR test sites get built. Maybe they just need to do a cache rebuild at the end.
It's from the below PR so marking a regression but it's not the usual type of regression, but if some people do installs the same way the PR test sites do then they might see it.
https://github.com/civicrm/civicrm-core/pull/20757https://lab.civicrm.org/dev/core/-/issues/2691On logging detail report show the words not the numbers2021-08-14T16:44:11ZDaveDOn logging detail report show the words not the numbersTurn on trigger-based logging and do something like edit an activity. When you look at the Contact Logging Summary report and then drill down to that change detail, it looks something like this:
![Untitled](/uploads/2d5bfb5460818c98ba44...Turn on trigger-based logging and do something like edit an activity. When you look at the Contact Logging Summary report and then drill down to that change detail, it looks something like this:
![Untitled](/uploads/2d5bfb5460818c98ba4452d046606570/Untitled.gif)
Showing the words for the record type (Source,Assignee, etc) looks easy. Showing the contact name maybe less easy.
Is there an api4 thing available to do something like take a table/field as input and then get its "_labelField" value?5.42.0https://lab.civicrm.org/dev/core/-/issues/2690Print mailing label doesn't work with the same address2023-08-31T05:03:27ZMonish DebPrint mailing label doesn't work with the same addressSteps to replicate:
1. Choose one or more contacts on Advance Search which has same address
2. Then select action: 'Print - Mailing Label'
3. Select all the three options and then click on 'Make Mailing Labels':
Demo:
![before](/upl...Steps to replicate:
1. Choose one or more contacts on Advance Search which has same address
2. Then select action: 'Print - Mailing Label'
3. Select all the three options and then click on 'Make Mailing Labels':
Demo:
![before](/uploads/ae7a772e2f85d5d23c8d8bf62cd26ed8/before.gif)
Here I have chosen two contact with same address. And mailing labels show the contact twice, one with name and other without name - [MailingLabels_CiviCRM__28_.pdf](/uploads/13d3f95541eb7ce9f34d71f8cf01f4d9/MailingLabels_CiviCRM__28_.pdf)5.41.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/2689Deprecated join alias 'contact' used in APIv4 get. Should be changed to 'cont...2022-01-23T16:20:01ZDaveDDeprecated join alias 'contact' used in APIv4 get. Should be changed to 'contact_id'When saving an activity. More details TBD. Might have something to do with custom fields, maybe.
Deprecated join alias 'contact' used in APIv4 get. Should be changed to 'contact_id' Caller: Civi\Api4\Query\Api4SelectQuery::autoJoinFKWhen saving an activity. More details TBD. Might have something to do with custom fields, maybe.
Deprecated join alias 'contact' used in APIv4 get. Should be changed to 'contact_id' Caller: Civi\Api4\Query\Api4SelectQuery::autoJoinFK5.41.0