Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-11-17T13:46:29Zhttps://lab.civicrm.org/dev/wordpress/-/issues/115WP API REST cURL error 282021-11-17T13:46:29ZjbonlineaWP API REST cURL error 28Hi Guys,
I hope I'm in the right spot to bring this.
To be short, Wordpress "site health" tool reports me an `Erreur : cURL error 28: Operation timed out after 10001 milliseconds with 0 bytes received (http_request_failed)` as soon as...Hi Guys,
I hope I'm in the right spot to bring this.
To be short, Wordpress "site health" tool reports me an `Erreur : cURL error 28: Operation timed out after 10001 milliseconds with 0 bytes received (http_request_failed)` as soon as CiviCRM is running.
I've used wordpress site health and troubleshoot plug-in to do some testings, disabling all plug-in and using twentyXX theme, and as soon as CiviCRM is activated the error pops-in :(
At time of testing I do have
Php 7.4
wp 5.8.2
Civi 5.43.2
Regards
---
More info
In wordpress realm, this error, or at least a similar `cURL error 28`, is quite known and mentioned on the web. Recently it also has apeared in `Super Simple SSL plugin` however the wp was still on 5.8.1. Since 5.8.2 this issue got fixed for me and I've read this latest update addressed recent ssl certifcate protocol/version that was dismissed
here you can fin the full error message I get, it's en french (sorry), but I don't think the french par matter as much as the error detail itself
> L’API REST est l’une des façon pour WordPress ou d’autres applications de communiquer avec le serveur. Un exemple est l’écran de l’éditeur, qui s’appuie dessus pour afficher et enregistrer vos publications.
>
> La requête API REST a échoué à la suite d’une erreur.
> Erreur : cURL error 28: Operation timed out after 10001 milliseconds with 0 bytes received (http_request_failed)
>https://lab.civicrm.org/dev/core/-/issues/2919Hidden submit buttons are confussing for keyboard users2021-11-17T19:56:33ZBradley TaylorHidden submit buttons are confussing for keyboard usersModals are used in various parts of the CiviCRM. For example:
![Screenshot_2021-10-17_at_16.39.33](/uploads/a0f38e37e9ecf5423826d1e8dd06973c/Screenshot_2021-10-17_at_16.39.33.png)
The two buttons in the bottom-right are actually genera...Modals are used in various parts of the CiviCRM. For example:
![Screenshot_2021-10-17_at_16.39.33](/uploads/a0f38e37e9ecf5423826d1e8dd06973c/Screenshot_2021-10-17_at_16.39.33.png)
The two buttons in the bottom-right are actually generated based on buttons within the modal content, which are hidden with CSS. With this CSS removed, the modal actually looks like this:
![Screenshot_2021-10-17_at_16.41.51](/uploads/365c9c0577f3e89a12451f36c059e828/Screenshot_2021-10-17_at_16.41.51.png)
The problem is that these buttons are still keyboard focussable when tabbing. If a user hits their enter key whilst one of these keys are focused, then the modal may be saved or cancelled without any visual indication of what they triggered.
The code contains this comment, which is fair enough if a field is actually focussed but not when a non-visible field is focussed:
`// display:none causes the form to not submit when pressing "enter"`
I'd like to propose that the hidden buttons are made non-focussable with `tabindex="-1"`. I think this should be a safe change, but it would be good to hear if anyone sees any potential issues with this change.
For accessibility, ideally the focussable submit button should be within the form. However, as there is consistency across how modals work within CiviCRM I think the proposed change should be ok from an accessibility point of view.5.45.0https://lab.civicrm.org/dev/core/-/issues/2959some PDFs hard-code format to "a3 landscape", overriding default PDF format2021-11-18T21:48:05ZAllenShawsome PDFs hard-code format to "a3 landscape", overriding default PDF format**Disclaimer:** this is something of an edge case, as I'm only encountering this by calling `civicrm/event/participant?reset=1&id=N&snippet=3` to print Event Participant Listings to PDF.
**Problem:** It appears that PDFs generated by so...**Disclaimer:** this is something of an edge case, as I'm only encountering this by calling `civicrm/event/participant?reset=1&id=N&snippet=3` to print Event Participant Listings to PDF.
**Problem:** It appears that PDFs generated by some code execution pathways will always be size=A3 and orientation=landscape, no matter what is specified for PDF formats anywhere in the UI settings. This seems undesirable, unless you live in a place where everybody normally keeps A3 paper in the printer.
Consider this line of code from https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Page.php#L214:
```
if ($this->_print == CRM_Core_Smarty::PRINT_PDF) {
CRM_Utils_PDF_Utils::html2pdf($content, "{$this->_name}.pdf", FALSE,
['paper_size' => 'a3', 'orientation' => 'landscape']
);
}
```
**Proposed solution:** Would it be acceptable to simply remove this `['paper_size' => 'a3', 'orientation' => 'landscape']` array from this call? It appears (per [`CRM_Utils_PDF_Utils::html2pdf()`](https://github.com/civicrm/civicrm-core/blob/master/CRM/Utils/PDF/Utils.php#L44)) that doing so would simply cause such PDFs to use whatever is returned by `CRM_Core_BAO_PdfFormat::getDefaultValues()`.https://lab.civicrm.org/dev/core/-/issues/2612CiviCRM 5.37.2 'CRM_Utils_ReCAPTCHA' not found2021-11-19T20:29:40ZbrianpCiviCRM 5.37.2 'CRM_Utils_ReCAPTCHA' not foundWe upgraded to 5.37.2 on Drupal 7 this morning and all the donation pages are now broken. I've cleared the cache and ensured the DB upgrade is complete. Per Issues #2596 I don't see a /ext/recaptcha in civicrm-core. Should that be there?...We upgraded to 5.37.2 on Drupal 7 this morning and all the donation pages are now broken. I've cleared the cache and ensured the DB upgrade is complete. Per Issues #2596 I don't see a /ext/recaptcha in civicrm-core. Should that be there?
Error: Class 'CRM_Utils_ReCAPTCHA' not found in CRM_Contribute_Form_ContributionBase->hasToAddForcefully() (line 845 of /code/sites/all/modules/civicrm/CRM/Contribute/Form/ContributionBase.php).https://lab.civicrm.org/dev/core/-/issues/2950SearchKit+Afform issue with Cases2021-11-22T00:10:18ZjhungerfordSearchKit+Afform issue with CasesOverview
----------------------------------------
Search Kit searches for Contacts with Cases will fail if the user does not have "Administer CiviCRM" permission.
The detailed description below is incorrect. In fact the Case Permission ...Overview
----------------------------------------
Search Kit searches for Contacts with Cases will fail if the user does not have "Administer CiviCRM" permission.
The detailed description below is incorrect. In fact the Case Permission extension does not cause the issue, and it affects a vanilla Civi install in the same manner.
Reproduction steps (updated)
----------------------------------------
This has been tested on Civi 5.43.1:
1. Create a clean install of Civi on Drupal 7
2. Create a Permission User contact and a Test Client contact
3. Enable the CiviCase component, plus Search Kit and Afform extensions
4. Add a Case for Test Client
5. Create a Search Kit search showing Contacts with optional Contact Cases (if Case is in the Trash = No), WHERE Case Subject is not empty
6. Add a Display for the search and create a Search Afform to display it
7. Create a Drupal user login for Permission User
8. Add CiviCase permissions and other Civi permissions for Permission User
9. Confirm that when the admin visits the Search Afform, they see Test Client and their Case subject, but Permission User does not see any results
Original (outdated) issue description
----------------------------------------
We use hook_civicrm_selectWhereClause to apply granular Case permissions by Case Type. When we create a SearchKit search and an Afform to display it, users who do not have "Administer CiviCRM" permission do not see any results.
I mentioned the issue briefly here: https://chat.civicrm.org/civicrm/pl/cjjf8e6p8bnbfyh83inm5abtay
Reproduction steps (outdated)
----------------------------------------
1. Install this extension on a clean Civi system with test data: https://github.com/AsylumSeekersCentre/au.org.asylumseekerscentre.casepermission
2. Check that some Contacts and Cases have been created, and if not, create some
3. Create a CMS user with permission to see all Cases, including all granular Case Type permissions (added by the extension), but without "Administer CiviCRM"
4. Create a SearchKit search showing Contacts with optional Contact Cases (if Case is in the Trash = No), WHERE Case Subject is not empty -- (or is empty, choose something which shows results for the admin)
5. Create an Afform to display the search to users and view the page as an admin, confirming that you see results
6. View the page as the user affected by permissions
Current behaviour
----------------------------------------
The user affected by permissions does not see any results. There are no error messages in the Drupal log.
Stepping through the sequence in xdebug, it lands in this AJAX exception handler:
https://lab.civicrm.org/dev/core/-/blob/master/CRM/Api4/Page/AJAX.php#L83
At that point, $e->message contains this string:
```
Invalid field 'Contact_CaseContact_Case_01.subject'
```
Going back through the sequence of calls before that:
When it gets to this point with $item="Contact_CaseContact_Case_01.subject", the variable "$valid" is FALSE:
https://lab.civicrm.org/dev/core/-/blob/master/Civi/Api4/Query/Api4SelectQuery.php#L268
If I try to step over buildWhereClause in xdebug, it jumps to the AJAX exception handler linked above, so it's failing somewhere in this function call:
https://lab.civicrm.org/dev/core/-/blob/master/Civi/Api4/Query/Api4SelectQuery.php#L150
I haven't gone any further yet to diagnose what is going wrong.
Expected behaviour
----------------------------------------
Users should see results consistent with their permissions.
Environment information
----------------------------------------
* __Browser:__ Chromium 95.0.4638.69
* __CiviCRM:__ 5.43.0
* __PHP:__ 7.3
* __CMS:__ Drupal 7.82
* __Database:__ 10.3.31-MariaDB, for debian-linux-gnu (x86_64)
* __Web Server:__ Apache 2.4
Comments
----------------------------------------
The situation matches the title of this issue:
https://lab.civicrm.org/dev/core/-/issues/2921
However, this one relates to a different hook and will probably require a separate solution.https://lab.civicrm.org/dev/financial/-/issues/190Proposal: Add `created_id` to `civicrm_contribution`2021-11-23T17:28:24ZJonGoldProposal: Add `created_id` to `civicrm_contribution`This is fairly straightforward as a proposal. I think it's a good idea generally (for those who lack advanced logging) but could also solve financial#49 - it's impossible to know what individual gave on behalf of an organization based o...This is fairly straightforward as a proposal. I think it's a good idea generally (for those who lack advanced logging) but could also solve financial#49 - it's impossible to know what individual gave on behalf of an organization based on the existing data.JonGoldJonGoldhttps://lab.civicrm.org/dev/financial/-/issues/49No way to customize contribution receipt based on individual entering data wh...2021-11-23T17:28:26ZJonGoldNo way to customize contribution receipt based on individual entering data when giving "On behalf of" an organizationWhen giving on behalf of an organization, we don't store the contact ID of the person who actually entered the contribution, nor do we pass it to the receipt in `$tplParams`. My PR will resolve the latter issue, since it's a safe fix th...When giving on behalf of an organization, we don't store the contact ID of the person who actually entered the contribution, nor do we pass it to the receipt in `$tplParams`. My PR will resolve the latter issue, since it's a safe fix that doesn't affect folks who don't choose to use its functionality.JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2953Afform - Angular error `Controller 'afFieldset', required by directive 'afFie...2021-11-24T03:44:08ZjensschuppeAfform - Angular error `Controller 'afFieldset', required by directive 'afField', can't be found!`Overview
----------------------------------------
Afform field blocks with a path or in a dashboard panel do not load fields.
Previously reported on [mattermost](https://chat.civicrm.org/civicrm/pl/gr5xtw6i3jdy9c9i86k3qwunyh).
Reproduc...Overview
----------------------------------------
Afform field blocks with a path or in a dashboard panel do not load fields.
Previously reported on [mattermost](https://chat.civicrm.org/civicrm/pl/gr5xtw6i3jdy9c9i86k3qwunyh).
Reproduction steps
----------------------------------------
1. Create an Afform field block, e.g. for Contact entities
2. Add at least one field (e.g. `first_name` and `last_name`)
3. Add a path for a standalone form
4. Save and Load the standalone form.
Current behaviour
----------------------------------------
The fields don't show. The JS console throws [`Controller 'afFieldset', required by directive 'afField', can't be found!`](https://code.angularjs.org/1.8.2/docs/error/$compile/ctreq?p0=afFieldset&p1=afField)
Expected behaviour
----------------------------------------
The form should show the fields and let the user enter values and save the entity.
Environment information
----------------------------------------
This is reproducible on dmaster and was tested with a Chromium browser.
Comments
----------------------------------------
We'd be able to provide some funding for resolving this issue if adding/editing entities will then work with those forms, as we're planning to use Afform for providing forms for entities that don't have their own forms yet. @colemanw that's for the virtual entity thing.https://lab.civicrm.org/dev/core/-/issues/2893Searchkit UI thoughts2021-11-24T17:11:38ZeileenSearchkit UI thoughts@colemanw Logging this after seeing how search kit is being used in practice - I'm seeing a lot of people create & keep using searches without ever creating a display. That means every time they access it they access it via 'edit' which ...@colemanw Logging this after seeing how search kit is being used in practice - I'm seeing a lot of people create & keep using searches without ever creating a display. That means every time they access it they access it via 'edit' which seems a bit counter intuitive - I wondered about a separate 'view' or 'view results' link which is the same page but the criteria would by in something more like a closed accordian & possibly it would be as if search had been clicked.
Being able to hide & expand the criteria section would be useful in general I thinkhttps://lab.civicrm.org/dev/core/-/issues/2967Multiple elements with same id are generate when honoree section is enabled o...2021-11-24T17:47:49ZKurund JalmiMultiple elements with same id are generate when honoree section is enabled on the contribution pageSteps to replicate
* Enable honoree section for the contribution page
* Add a pre profile to include first name and last name
Visit contribution page and we get 2 div elements with same id. For eg: 'editrow-first_name' and 'editrow-las...Steps to replicate
* Enable honoree section for the contribution page
* Add a pre profile to include first name and last name
Visit contribution page and we get 2 div elements with same id. For eg: 'editrow-first_name' and 'editrow-last_name'
We already have prefix for honoree and can be used to differentiate.5.45.0https://lab.civicrm.org/dev/core/-/issues/2954Searchkit: can't use HAVING2021-11-24T21:28:04ZalainbSearchkit: can't use HAVINGI'm testing the Searchkit in CiviCRM version 5.43.0 in Wordpress 5.8.2.
I noticed I can't specify an operator in a HAVING clause.
![image](/uploads/f118ec00b047ddb4e201f1d3e7996105/image.png)
These are the errors in the dev tools of F...I'm testing the Searchkit in CiviCRM version 5.43.0 in Wordpress 5.8.2.
I noticed I can't specify an operator in a HAVING clause.
![image](/uploads/f118ec00b047ddb4e201f1d3e7996105/image.png)
These are the errors in the dev tools of Firefox:
![image](/uploads/1387808acd4dc763e5191b84f4ed734d/image.png)5.44.0https://lab.civicrm.org/dev/core/-/issues/2973Custom fields all broken2021-12-01T03:19:28ZDaveDCustom fields all brokenMust be pretty recent. Noticed it locally and confirmed on dmaster.demo.
The fields are unusable on any entity edit form and all say NULL.
![Untitled](/uploads/3ec5d44c1d954956076f9e9a5f208892/Untitled.png)Must be pretty recent. Noticed it locally and confirmed on dmaster.demo.
The fields are unusable on any entity edit form and all say NULL.
![Untitled](/uploads/3ec5d44c1d954956076f9e9a5f208892/Untitled.png)5.45.0https://lab.civicrm.org/dev/core/-/issues/2446Custom field of type money and drop down does not hold the selected option (C...2021-12-01T09:37:57ZjaapjansmaCustom field of type money and drop down does not hold the selected option (CiviCase & CiviContact)**Steps to reproduce**
1. Create custom field of type money and input type Drop Down Select List.
2. Add a couple of options
3. Go to a case and select a value for the custom field press save.
4. Check the custom field value it is saved...**Steps to reproduce**
1. Create custom field of type money and input type Drop Down Select List.
2. Add a couple of options
3. Go to a case and select a value for the custom field press save.
4. Check the custom field value it is saved and displayed
5. Press edit again - the drop down is now empty
Here is a screen recording of the problem:
![Dropdown_on_case](/uploads/4bef0bd4b99af9d3b0cfab36334c4a43/Dropdown_on_case.gif)
**Remarks**
This problem also occurs when you add a money drop down for contacts (probably also on other screens).
**Environment**
Drupal 7
CiviCRM 5.37.alpha1https://lab.civicrm.org/dev/core/-/issues/2238Improvement: custom search and a custom action list2021-12-01T10:00:13ZjaapjansmaImprovement: custom search and a custom action listAs a developer I sometimes write a custom search and sometimes I also need to ability to have a customized list of actions after the search and not the default list of actions possible with a contact.
So my proposal is that the custom ...As a developer I sometimes write a custom search and sometimes I also need to ability to have a customized list of actions after the search and not the default list of actions possible with a contact.
So my proposal is that the custom search class could set the `$objectType` for the `hook_civicrm_searchTasks`.
PR: https://github.com/civicrm/civicrm-core/pull/19143https://lab.civicrm.org/dev/core/-/issues/2974Membership status update breaks if override is removed2021-12-02T05:48:05ZJonGoldMembership status update breaks if override is removed### Steps to replicate
* Open a membership whose status should be "New" or "Current".
* Override the membership so the status is "Expired".
* Remove the override status and save.
### Expected Behavior
Membership returns to its normal st...### Steps to replicate
* Open a membership whose status should be "New" or "Current".
* Override the membership so the status is "Expired".
* Remove the override status and save.
### Expected Behavior
Membership returns to its normal status.
### Actual Behavior
Membership retains its override status, with no way to fix except with another override.
Additionally, the "Update Memberships" scheduled job doesn't work
This is a regression in 5.42, which I've tracked down to https://github.com/civicrm/civicrm-core/pull/20976.
I'm thinking the solution would be to clear the `status_id` when removing an override (likely with JS at the form level) but I'm not clear on the reason for the change so I'll let wiser heads prevail.5.44.0https://lab.civicrm.org/dev/core/-/issues/2822Unsubscribe from a smart group behaves wrongly2021-12-02T13:24:14ZKurund JalmiUnsubscribe from a smart group behaves wrongly### Steps to replicate
* create a smart group
* send mailing to the group and include unsubscribe url
* you will get following screen on clicking unsubscribe url
![screenshot-wp.localhost_7979-2021.09.07-16_31_12](/uploads/6711392bdc47b...### Steps to replicate
* create a smart group
* send mailing to the group and include unsubscribe url
* you will get following screen on clicking unsubscribe url
![screenshot-wp.localhost_7979-2021.09.07-16_31_12](/uploads/6711392bdc47bcdbb2053775ffaac00c/screenshot-wp.localhost_7979-2021.09.07-16_31_12.png)
* click unsubscribe and following page will be displayed
![screenshot-wp.localhost_7979-2021.09.07-16_31_45](/uploads/8220253062d06539a9d60f68c8371b57/screenshot-wp.localhost_7979-2021.09.07-16_31_45.png)
### Expected behavior
* After user unsubscribe it should not give option to unsubscribe. The user is correctly unsubscribed however, this behavior is bit confusing.
* Ideally it should only show.
![screenshot-wp.localhost_7979-2021.09.07-16_35_50](/uploads/354d3fd152fa594a09d54d79f6cab415/screenshot-wp.localhost_7979-2021.09.07-16_35_50.png)
Note that it is working fine for normal group and the issue is only with smart group.https://lab.civicrm.org/dev/civicrm-asset-plugin/-/issues/14Command "composer civicrm: publish" is not executed automatically?2021-12-03T14:43:54ZwouterhCommand "composer civicrm: publish" is not executed automatically?I was upgrading our drupal 8 and CiviCRM installation, as our vendor directory is outside the webroot, as a solution we ran a bash script via composer.json scripts to put all assets in the right place in the webroot.
I recently saw that...I was upgrading our drupal 8 and CiviCRM installation, as our vendor directory is outside the webroot, as a solution we ran a bash script via composer.json scripts to put all assets in the right place in the webroot.
I recently saw that "civicrm-asset-plugin" is available, while implementing this I saw that the command `composer civicrm: publish` was not executed, so I have to run this manually after a composer install/update.
I solved this by adding this in our composer.json:
```
"scripts": {
"post-install-cmd": [
"@composer civicrm:publish"
],
"post-update-cmd": [
"@composer civicrm:publish"
]
}https://lab.civicrm.org/dev/core/-/issues/2385Investigate replacing civicase views with something that is not views2021-12-08T09:00:21ZDaveDInvestigate replacing civicase views with something that is not viewsRelated to https://lab.civicrm.org/dev/core/-/issues/2262.
CiviCase uses mysql views (as opposed to drupal views) and is the only component that does so. I'm not sure if they're still truly needed the way they originally were. In additi...Related to https://lab.civicrm.org/dev/core/-/issues/2262.
CiviCase uses mysql views (as opposed to drupal views) and is the only component that does so. I'm not sure if they're still truly needed the way they originally were. In addition to the issue above, they hardcode activity status id and the number 14 (nothing against the number 14, but hey) making it difficult to override those.
I haven't looked at the full query lately but at one time it had a self-join on the view which was where it was convenient to have the view since at the time you couldn't self-join to temporary tables, which might still be true.5.37.0https://lab.civicrm.org/dev/core/-/issues/2982Repeat Contributions CiviReport warnings: Formatting non-numeric values is no...2021-12-09T00:48:06ZDaveDRepeat Contributions CiviReport warnings: Formatting non-numeric values is no longer supportedWhole screen fills with ones like this:
`User deprecated function: Formatting non-numeric values is no longer supported: 100.00 (2) Caller: CRM_Utils_Money::format in CRM_Core_Error::deprecatedWarning() (line 1060 of /srv/buildkit/build...Whole screen fills with ones like this:
`User deprecated function: Formatting non-numeric values is no longer supported: 100.00 (2) Caller: CRM_Utils_Money::format in CRM_Core_Error::deprecatedWarning() (line 1060 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Error.php).`
It must be the `(2)` part it doesn't like. Perhaps that repeat count should be its own column.
It's also showing `<br/>` in the column heading, which I assume is from the recent smarty escaping PRs.5.46.0https://lab.civicrm.org/dev/wordpress/-/issues/116Issue related to Civi and WP Scss compiler causing fatal error2021-12-09T15:17:29ZjbonlineaIssue related to Civi and WP Scss compiler causing fatal errorHi there,
It seems there is a issue / conflict between CiviCRM Scss compiler and my wordpress theme (gantry 5) Scss compiler.
We've discussed it [here](https://chat.civicrm.org/civicrm/pl/mfsmpmhewjyd7p7srbe1h9cyfa) where I've linked w...Hi there,
It seems there is a issue / conflict between CiviCRM Scss compiler and my wordpress theme (gantry 5) Scss compiler.
We've discussed it [here](https://chat.civicrm.org/civicrm/pl/mfsmpmhewjyd7p7srbe1h9cyfa) where I've linked what put me on track to think is was due to Civi Scss compiler.
A workaround is to rename the folder `civicrm/civicrm/vendor/scssphp`
Let me know if you want more detail
Cheers
PHP 7.4
WP 5.8.2
Civi 5.40.2
Gantry 5.5.6 (theme I use that also bundle an scss compiler, but there are many others)