Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-08-27T11:24:06Zhttps://lab.civicrm.org/dev/joomla/-/issues/31Joomla language strings not being used2021-08-27T11:24:06ZElin.WaringJoomla language strings not being usedI submitted https://github.com/civicrm/civicrm-joomla/pull/56
which changes the config.xml code to use Joomla language strings and adds the strings to the language folder. This makes them translatable or override-able.I submitted https://github.com/civicrm/civicrm-joomla/pull/56
which changes the config.xml code to use Joomla language strings and adds the strings to the language folder. This makes them translatable or override-able.https://lab.civicrm.org/dev/core/-/issues/2285The civicrm_alterReportVar hook is not working for contribute detail report2021-04-06T20:01:06Zahed_compucorpThe civicrm_alterReportVar hook is not working for contribute detail reportOverview
----------------------------------------
The `civicrm_alterReportVar` is not working for contribute detail report when the user select the new column or choose the new filter, and it will show an error message `DB Error: no such...Overview
----------------------------------------
The `civicrm_alterReportVar` is not working for contribute detail report when the user select the new column or choose the new filter, and it will show an error message `DB Error: no such field`
Here at [Detail.php#L956](https://github.com/civicrm/civicrm-core/blob/3662d5a75d79d6c259b632df748b1beb66db6faf/CRM/Report/Form/Contribute/Detail.php#L956) our changes to the `_form` attribute are lost and the error will be fired here [Detail.php#L576](https://github.com/civicrm/civicrm-core/blob/3662d5a75d79d6c259b632df748b1beb66db6faf/CRM/Report/Form/Contribute/Detail.php#L576)
Unknown column 'some_table.some_column' in 'where clause'
I believe this is a regression on soft credits.
Reproduction steps
----------------------------------------
Any suffecient use of this hook will face the error message.
[The code](https://gist.github.com/ahed-compucorp/672363f80c076a80c2804b78f61baaa9).
![Peek_2021-01-04_17-19](/uploads/4fef18053a65a947205d6540aa123552/Peek_2021-01-04_17-19.gif)
check the test case in the PR.
PR: https://github.com/civicrm/civicrm-core/pull/193175.37.0https://lab.civicrm.org/dev/core/-/issues/2284CRM_Member_Form_MembershipRenewalTest - Started failing circa Jan 1, 20212021-01-08T07:07:09ZtottenCRM_Member_Form_MembershipRenewalTest - Started failing circa Jan 1, 2021Overview
----------------------------------------
The unit-test was passing. When the new year started, it began failing. The test does have some calculations about current-year and next-year.
Reproduction steps
------------------------...Overview
----------------------------------------
The unit-test was passing. When the new year started, it began failing. The test does have some calculations about current-year and next-year.
Reproduction steps
----------------------------------------
1. Look at the test output on https://test.civicrm.org/ (For example, here's a test for a PR that has nothing to do with memberships https://test.civicrm.org/job/CiviCRM-Core-PR/38621/)5.34.0https://lab.civicrm.org/dev/core/-/issues/2283Use nicer report layout on install2023-06-10T05:03:21ZeileenUse nicer report layout on installwhen civicrm is installed there is a very flat menu layout for reports like this
![defaultmenu](/uploads/05d41b8b50a4bca6f06a68477f0cde39/defaultmenu.png)
There is an api call (Navigation.reset) exposed on civicrm/admin/menu?reset=1 th...when civicrm is installed there is a very flat menu layout for reports like this
![defaultmenu](/uploads/05d41b8b50a4bca6f06a68477f0cde39/defaultmenu.png)
There is an api call (Navigation.reset) exposed on civicrm/admin/menu?reset=1 that fixes it to live in submenus like
![organisedmenu](/uploads/cc3baf0280b46dc945d8046ef6200e63/organisedmenu.png)
At the time the function was added it was hoped it would be run on install - but we never figured out how. Due to the interaction between the ids of the reports and the navigation menu it did not seem feasible to hard code the menu structure into the sql. @totten - I wonder if adding an api call on install would be more do-able now?https://lab.civicrm.org/dev/core/-/issues/2282Use the proper content type for ICalendar link2021-01-04T19:47:08Zahed_compucorpUse the proper content type for ICalendar linkOverview
----------------------------------------
There is two ways to add an event to my calendar :
- Download `ICS` file and import it.
- Copy the `ICalendar` link directly but when you click it shows the contents and some users th...Overview
----------------------------------------
There is two ways to add an event to my calendar :
- Download `ICS` file and import it.
- Copy the `ICalendar` link directly but when you click it shows the contents and some users think it is a bug.
![2020-12-30_13-08](/uploads/0a267756da641d70ee44bf1b479ce4ff/2020-12-30_13-08.png)
Reproduction steps
----------------------------------------
Clicking on the second icon (ICalendar feed for this event.)
Current behaviour
----------------------------------------
When you click the `ICalendar` link it shows the `ICalendar` contents and some users think it is a bug.
![Screenshot_from_2020-12-30_13-16-28](/uploads/6eeaffd9998eb234505e8d264eee0a2b/Screenshot_from_2020-12-30_13-16-28.png)
![RPReplay_Final1609580895_2r](/uploads/5358f62f1b4e330c086def8362ebe477/RPReplay_Final1609580895_2r.gif)
Expected behaviour
----------------------------------------
When you click the `ICalendar` link the browser will start downloading the file.
![Screenshot_from_2020-12-30_09-45-20](/uploads/60a20ccf404754288dd6d940d2e050d7/Screenshot_from_2020-12-30_09-45-20.png)
![RPReplay_Final1609580895_1r](/uploads/74be3271114878f3ad1aecb7f9753433/RPReplay_Final1609580895_1r.gif)
Comments
----------------------------------------
Using the proper content type for ICalendar link is a good practice and the browsers will handle it properly by downloading it - UX improvement.
Changing the content type here to `text/calendar` will fix it
https://github.com/civicrm/civicrm-core/blob/3662d5a75d79d6c259b632df748b1beb66db6faf/CRM/Event/ICalendar.php#L73
So what do you think about this?
PR: https://github.com/civicrm/civicrm-core/pull/193165.34.0https://lab.civicrm.org/dev/core/-/issues/2281Tabbed custom fields indented.2023-06-09T05:03:32ZspalmstromTabbed custom fields indented.Overview
----------------------------------------
We have a custom field set that contains several fields. When configured as tabbed as opposed to in-line, they appear indented rather than one below the other.
Reproduction steps
------...Overview
----------------------------------------
We have a custom field set that contains several fields. When configured as tabbed as opposed to in-line, they appear indented rather than one below the other.
Reproduction steps
----------------------------------------
1. View a contact.
1. Click on the **Tabbed custom field set**.
Current behaviour
----------------------------------------
![image](/uploads/71a15e5903ac906283a9525a8388d49c/image.png)
Expected behaviour
----------------------------------------
![image](/uploads/891cbd8270bbf41bdcd4a5e2dbcb4a38/image.png)
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is necessary. -->
* __Browser:__ _Edge_ but probably not relevant
* __CiviCRM:__ _5.32.2_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.4__ but probably not relevant
* __CMS:__ _Drupal 9.1_. _Joomla 3.9.6_ does not show the issue.
* __Database:__ _MySQL 8.0.22_ but probably not relevant.
* __Web Server:__ _IIS 10_ but probably not relevant.
Comments
----------------------------------------
_Anything else you would like the reviewer to note._https://lab.civicrm.org/dev/core/-/issues/2280Price set options show nine decimal places.2023-06-10T05:03:21ZspalmstromPrice set options show nine decimal places.Overview
----------------------------------------
The price in a price set option shows nine decimal places and not two.
Reproduction steps
----------------------------------------
1. Click on **Events -> Manage Price Sets**.
1. Click o...Overview
----------------------------------------
The price in a price set option shows nine decimal places and not two.
Reproduction steps
----------------------------------------
1. Click on **Events -> Manage Price Sets**.
1. Click on **View and Edit Price Fields** for a given event.
Current behaviour
----------------------------------------
The price shows to nine decimal places.
![image](/uploads/1080ecb928c6f2601d014afa2128bb19/image.png)
Expected behaviour
----------------------------------------
The price should show two decimal places.
![image](/uploads/40d5279f5c7ef20c0d6ff830184ebc88/image.png)
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is necessary. -->
* __Browser:__ _Edge_ but probably not relevant
* __CiviCRM:__ _5.32.2_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.4__ but probably not relevant
* __CMS:__ _Drupal 9.1/Joomla 3.9.6_ but may not be relevant
* __Database:__ _MySQL 8.0.22_ but may not relevant
* __Web Server:__ _IIS 10_ but probably not relevant.
Comments
----------------------------------------
_Anything else you would like the reviewer to note._
The expected behaviour comes from a 5.30.1 system under Joomla and MySQL 5.6,https://lab.civicrm.org/dev/core/-/issues/2279Proposal - add hook alterIndices2023-08-04T05:03:24ZeileenProposal - add hook alterIndicesProposal - add hook alterIndices to ```CRM_Core_DAO_AllCoreTables::indices()``
The above function returns the indices that should exist according to our schema and we have the apiv3 function System.updateindexes to reconcile the
indic...Proposal - add hook alterIndices to ```CRM_Core_DAO_AllCoreTables::indices()``
The above function returns the indices that should exist according to our schema and we have the apiv3 function System.updateindexes to reconcile the
indices that do exist against those that should.
However, the stock indices are not perhaps better viewed as a guideline. At WMF we have removed some (e.g contribution_status_id) that are not good for performance and added others (eg. nick_name, preferred_language) that are helpful to us but perhaps not universally applicable.
Since we try to keep our development installs in line with production it's useful for us to be able to reconcile against our tweaked set of indices - and possibly to share or at least document them.
Adding a hook would be helpful here - although it would be more helpful if there were a UI to view & individually add missing indices. I somewhat contemplate doing this UI - but I'm not 100% sure where it would sit - probably a core extension that promotes itself after upgradeshttps://lab.civicrm.org/dev/core/-/issues/2278PCP transact action fails when there are more PCP's then contribution pages2020-12-30T13:27:10ZandyburnsPCP transact action fails when there are more PCP's then contribution pagesIf you have site with more PCP's then contribution pages, the action=transact shortcode fails.
The test sites have more contribution pages than PCP pages, so this was not caught before merging. https://github.com/civicrm/civicrm-wordpre...If you have site with more PCP's then contribution pages, the action=transact shortcode fails.
The test sites have more contribution pages than PCP pages, so this was not caught before merging. https://github.com/civicrm/civicrm-wordpress/pull/226/commits/cffd5f54b6bb56138956c287afc2442879fa23bf
```
case 'transact':
$args['q'] = 'civicrm/contribute/transact';
$args['pcpId'] = $args['id'];
break;
```
Example for a contribution page ID 87 and PCP ID of 228.
ID must = 87 and then add pcpID as 228
We have no contribution page ID 228, but we do have 228 as a PCP ID.
Verified that this is the problem. @kcristiano @mattwire @haystack
It is quite normal to have more PCP's than contribution pages.
https://lab.civicrm.org/dev/wordpress/-/issues/63https://lab.civicrm.org/dev/core/-/issues/2277Expose option value ccreate metadata to the api2023-06-09T05:03:30ZeileenExpose option value ccreate metadata to the apiOverview
----------------------------------------
I'm proposing we move metadata about option values from the form to somewhere accessible.
Example use-case
----------------------------------------
Via the api, or via any new form laye...Overview
----------------------------------------
I'm proposing we move metadata about option values from the form to somewhere accessible.
Example use-case
----------------------------------------
Via the api, or via any new form layer we switch to, we should be able to access the metadata to build the form or interface without interacting with quickform
Current behaviour
----------------------------------------
The form 'knows' things like
- if the option group is participant status or participant role then 'filter' should be exposed and called 'Counted'
- visibility should be exposed for participant status
- for some option groups is_default should be exposed
- if the name is participant listing then description should be text not a wysiwig
- for greetings there is an array of options for filter
- for payment instruments financial_account_id is required, for existing ones the default can be loaded
Proposed behaviour
----------------------------------------
I'll flesh this out a bit more if I get buy in but I'm thinking we add metadata for option groups in a similar way to settings, but more optional.
Comments
----------------------------------------
I have a specific interest in payment_instrument_id - it seems it can't currently be created as an 'mgd entity and I feel that should be possible and financial_account_id should be accepted for it by the api and preferably have a defaulthttps://lab.civicrm.org/dev/core/-/issues/2276membership edit and renew links do not show with proper permissions set2021-01-08T19:44:21Zandyburnsmembership edit and renew links do not show with proper permissions setAccording to the [docs](https://docs.civicrm.org/user/en/latest/membership/manual-entry-of-memberships/#civimember-access-control), you need
> For users who need to create and/or edit membership records - assign the **edit memberships*...According to the [docs](https://docs.civicrm.org/user/en/latest/membership/manual-entry-of-memberships/#civimember-access-control), you need
> For users who need to create and/or edit membership records - assign the **edit memberships** permission, the **edit contributions** permission if payments are involved and make sure the user has edit contact permission for the associated contact record.
I have both set. See related SE issue: https://civicrm.stackexchange.com/questions/38001/what-permissions-are-needed-to-renew-memberships-in-back-end
I have de-activated CiviCRM Admin Utilities, ACL for Activity Types without effect.
It is important to note this behavior as a workaround for editng the membership:
This is the view membership url when you go to the member tab.
https://example.org/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fcontact%2Fview%2Fmembership&action=view&reset=1&cid=499750&id=28258&context=membership&selectedChild=member
Switch the 'view' to 'update' like so. Now you can edit the membership status.
https://example.org/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fcontact%2Fview%2Fmembership&action=update&reset=1&cid=499750&id=28258&context=membership&selectedChild=member
So what this says is is a permission issue with the edit and renew buttons.
On Civi 5.31.0 and WP 5.5.3.https://lab.civicrm.org/dev/core/-/issues/2275Feature Request: Add action to bulk de-activate or re-activate a relationship2021-01-19T03:29:33Znc3man - karlFeature Request: Add action to bulk de-activate or re-activate a relationshipOverview
----------------------------------------
When performing a search and selecting a number of contacts on return, there is an action to "Add relationship to - ..." That works great, but annually we need to set a number of relation...Overview
----------------------------------------
When performing a search and selecting a number of contacts on return, there is an action to "Add relationship to - ..." That works great, but annually we need to set a number of relationships inactive (is_active=0) to not only disable the relation but so the history shows up in the contacts Relationships view as Inactive relationships. Additionally, we annually need to re-activate some of these relationships (is_active=1). Our staff would prefer to simply disable/enable via the Actions pull-down after selecting a group of contacts to either de-activate or re-activate a relationship. The request is to add a few actions in the pull-down post-search to (i) disable a relationship; (ii) re-enable a relationship.
Example use-case
----------------------------------------
The context for our organization, a bike coalition, is that we have a number of bike clubs as organizational contacts. Within each bike club, we have their members as individual contacts and we tie members to their club(s) via a relation. Since bike club members come and go annually, we go through a process of adding, disabling, or re-enabling individuals to the various bike clubs to which they belong. This annual process must be done for up to thousands of contacts and it is either completely tedious for non-technical staff or requires SQL expertise at the risk of damaging our database. This use case would apply to any CiviCRM organization that has a number of sub-organizations, each of which has multiple individual members which change at some frequency.
Current behavior
----------------------------------------
Our non-technical staff can only **Add** a **new** relationship from the Actions pull-down to do any bulk relationship operations. To do what we want, they can click on a single individual, click on the relationship and disable any active relationship. Alternatively, they can Enable an inactive relationship from the list under Relationships. This can be done one at a time by non-technical staff - hours of tedious, error-prone mouse clicks.
Staff who have access to the database and are familiar with SQL can set is_active=0 (or 1) as in this example:
> UPDATE civicrm_relationship
SET is_active=0
WHERE contact_id_b=384 AND relationship_type_id=17
AND (contact_id_a=386
OR contact_id_a=389
OR contact_id_a=390);
In that case, contact_id_a are 3 individuals, contact_id_b=384 is a bike club and relationship_type_id=17 indicates "Club Member of"
There may be unintended consequences with such a query, although it has been our go-to action for the past couple years.
Proposed behavior
----------------------------------------
1. Perform any search and select contacts from the result.
2. Under Actions, we would like these additional actions
- Disable relationship to - Individual
- Disable relationship to - Household
- Disable relationship to - Organization
- Enable relationship to - Individual
- Enable relationship to - Household
- Enable relationship to - Organization
Alternatively, to avoid the pull-down being too long, you could just have one item "Relationship operation" and that could pop up a dialogue to select Individual, Household, Organization, as well as Add, Disable, Enable, and I suppose Delete might be a 4th thing to add.
Comments
----------------------------------------
It would be nice if there were an API function to do this as well. A less attractive, but still possibly useful way to perform what we need to do on thousands of contacts annually would be to provide an API function with args (contact_id_a, contact_id_b, relationship_type_id) and the ability to add|disable|enable|delete through the API csv import function which is now available directly under Civi > Administer. The API function with entities included in API csv import would seem to be useful as a first step, anyway, to the Actions pull-down interface.https://lab.civicrm.org/dev/core/-/issues/2274Feature request: Include a "Aggregate Amount Filter" for "Top donor" report2023-06-08T05:03:23ZtapashFeature request: Include a "Aggregate Amount Filter" for "Top donor" reportI think the report does what it should but I was think would be a great addition to include a "Aggregate Amount Filter" for "Top donor" report.I think the report does what it should but I was think would be a great addition to include a "Aggregate Amount Filter" for "Top donor" report.https://lab.civicrm.org/dev/core/-/issues/2273Contact type incorrectly set to Contribution due to 'Honoree Profile'2021-02-04T03:19:33ZyashodhaContact type incorrectly set to Contribution due to 'Honoree Profile'Steps to replicate:
- Create a contribution page with _Honoree Section Enabled_.
- Choose a profile that includes a contribution field.
- Make a contribution with this page with soft credit contact.
![Screenshot_from_2020-12-23_19_01_...Steps to replicate:
- Create a contribution page with _Honoree Section Enabled_.
- Choose a profile that includes a contribution field.
- Make a contribution with this page with soft credit contact.
![Screenshot_from_2020-12-23_19_01_36](/uploads/eb4c8c6a1efde56de24f54e82d7b6e8d/Screenshot_from_2020-12-23_19_01_36.png)
- Check contact type of the newly created soft credit contact in DB. It will be _Contribution_ which is why it will not show up in some places and throws errors on various screens.
![Screenshot_from_2020-12-23_19_01_14](/uploads/3757f53442f4c41e204e62fa222fac88/Screenshot_from_2020-12-23_19_01_14.png)
![Screenshot_from_2020-12-23_19_01_05](/uploads/be5efccbb45d14a6bb0c7c7306cb87eb/Screenshot_from_2020-12-23_19_01_05.png)
I was able to replicate the scenario on dmaster. We should restrict the profile type to Contact types when calculating for honoree profile.5.34.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/2272Merge all members into the same household when using select fields fails with...2020-12-23T23:06:34ZseamusleeMerge all members into the same household when using select fields fails with a db errorOverview
----------------------------------------
When you select the merge option when exporting contacts to Merge Household members into their households and you select fields and the only field you select is addressee you get a DB ero...Overview
----------------------------------------
When you select the merge option when exporting contacts to Merge Household members into their households and you select fields and the only field you select is addressee you get a DB erorr
Reproduction steps
----------------------------------------
1. Create demo site
1. Do a simple advanced searech
1. Select some contacts (maybe make sure there is at least one household contact included) and Select export contacts
1. Choose to select fields and also choose the Merge Household members into their Households
1. Select Addressee as the only field to export
Current behaviour
----------------------------------------
Get a DB error
```
DB Error: no such field" code=-19 mode=callback callback=CRM_Core_Error::handle prefix="" info="SELECT contact_a.id as contact_id, contact_a.addressee_id as addressee_id, contact_a.addressee_display as addressee_display, contact_a.addressee_custom as addressee_custom, contact_id_a as refContact FROM civicrm_contact contact_a
INNER JOIN civicrm_relationship crel ON crel.contact_id_b = contact_a.id AND crel.relationship_type_id = 8
INNER JOIN civicrm_contact ctTable ON ctTable.contact_id = contact_id_a WHERE contact_a.is_deleted = 0 AND (crel.is_active = 1 AND ( crel.end_date is NULL OR crel.end_date >= 20201224 ) ) GROUP BY crel.contact_id_a [nativecode=1054 ** Unknown column 'ctTable.contact_id' in 'on clause']"]
```
Expected behaviour
----------------------------------------
Export should succeed
Environment information
----------------------------------------
* __CiviCRM:__ _Master_
* __PHP:__ _7.3_
* __CMS:__ _Drupal 7.77_
* __Database:__ _MySQL 5.7_5.34.0https://lab.civicrm.org/dev/core/-/issues/2271Free the joins! APIv4 explicit joins - can we remove the requirement for spec...2021-01-04T14:23:01ZnoahFree the joins! APIv4 explicit joins - can we remove the requirement for specific columns in the "on" clause?API4 currently micromanages the join conditions of explicit joins, forcing us to use awkward workarounds if we want to join entities on arbitrary conditions.
For example, I'd like to be able to join Email to Email so I can find differen...API4 currently micromanages the join conditions of explicit joins, forcing us to use awkward workarounds if we want to join entities on arbitrary conditions.
For example, I'd like to be able to join Email to Email so I can find different contacts who have the same email addresses. The Email's id is irrelevant to the join; what's relevant are the "email" and "contact_id" fields. See https://civicrm.stackexchange.com/a/38496/446.
Currently, APIv4 enforces a requirement that explicit joins have an "id" column for the joined entity in one of the join's "on" conditions. This enforcement takes place in Api4SelectQuery::getJoinConditions(). If no "on" condition with a "joinEntity.id" column is explicitly given, the code tries to create a new "on" condition using a foreign key relationship from the entity's metadata.
I can trick APIv4 into doing what I want by specifying a gratuitous "on" condition of the form "joinEntity.id = joinEntity.id". See the SE link above for an example. But this smells bad to me. When it comes to explicit join conditions, can't we figure out a way to tell APIv4 "step back, I'll handle this"?https://lab.civicrm.org/dev/core/-/issues/2270Editing a smartgroup created through the search builder renders the new block...2020-12-23T20:07:07ZVangelisPEditing a smartgroup created through the search builder renders the new block by forceOverview
----------------------------------------
When you edit an **existing** smartgroup created with the Search Builder, the new block of record type/operator is always rendering by force. This causes inconvenience (and confusion) to ...Overview
----------------------------------------
When you edit an **existing** smartgroup created with the Search Builder, the new block of record type/operator is always rendering by force. This causes inconvenience (and confusion) to the end user, as they try to 'Search' to see the results but end up with the form rule validation informing them that they need to populate some parameters. In order to bypass this, they need to clear the new line (new block). This behaviour is there since a long time now, we just got complains lately about that.
Reproduction steps
----------------------------------------
Create a smartgroup through the searchbuilder and save it:
1. Search -> Search builder
1. Set some basic filters like : Contacts -> Contact type = Individual and do the search
1. All x records -> Action: Group: Create smartgroup and give it a temporary name
Now go to find your existing smartgroup:
1. Contacts -> Manage groups
1. on the 'Find', type your temporary name that you gave and once it's being displayed, go to 'Settings' (right part)
1. On the popup page, select the last link: 'Edit smart group criteria'
The '-select record type-' and '-operator-' are rendering by default. In order to search, you need to take them out first.
Current behaviour
----------------------------------------
The new record type/operator line is now appearing on either an existing smartgroup done via the searchbuilder or on a new searchbuilder form
Expected/suggested behaviour
----------------------------------------
The new record type + operator line should appear only on the new searchbuilder form
Comments
----------------------------------------
I believe the easiest way to fix this is to check if we have any ssID value [here](https://lab.civicrm.org/dev/core/-/blob/master/CRM/Contact/Form/Search/Builder.php#L54). If we do have an ssID then this means that we are editing an existing smartgroup and not creating a new one.
for example this:
```php
// Initialize new form
if (!$this->_blockCount) {
$this->_blockCount = 4;
$this->set('newBlock', 1);
}
```
should be something like this:
```php
// Initialize new form
if (!$this->_blockCount) {
$this->_blockCount = 4;
if (!$this->_ssID) {
$this->set('newBlock', 1);
}
}
```
Can anyone see a downside on doing this?
[PR added - 19257](https://github.com/civicrm/civicrm-core/pull/19257)5.34.0https://lab.civicrm.org/dev/core/-/issues/2269Default currency shown on invoices if payment is made with different currency2020-12-30T21:47:07Zahed_compucorpDefault currency shown on invoices if payment is made with different currencyOverview
----------------------------------------
Default currency shown on invoices if payment is made with different currency
Reproduction steps
----------------------------------------
1. Go to CiviContribute Component Settings and ...Overview
----------------------------------------
Default currency shown on invoices if payment is made with different currency
Reproduction steps
----------------------------------------
1. Go to CiviContribute Component Settings and check Enable Tax and Invoicing.
2. Go to any contact with contributions.
3. Choose a contribution in currency other than the default one.
4. Press "Print Invoice".
Current behaviour
----------------------------------------
For this contribution (USD is the default currency)
![Screenshot_from_2020-12-22_12-34-58](/uploads/778c80626ef5f77dedefb704fdad82ec/Screenshot_from_2020-12-22_12-34-58.png)
Invoice shows default currency rather than contribution's currency.
![Screenshot_from_2020-12-22_12-35-12](/uploads/5dbf627a12e19a2484196b862b83ef0a/Screenshot_from_2020-12-22_12-35-12.png)
Expected behaviour
----------------------------------------
Invoice shows contribution's currency.
![103090962-52037c00-45fb-11eb-88f9-74f58c707371](/uploads/f326c539297792606c2e985bb9cea9f2/103090962-52037c00-45fb-11eb-88f9-74f58c707371.png)
Ref https://github.com/civicrm/civicrm-core/pull/192905.34.0https://lab.civicrm.org/dev/core/-/issues/2268Unable to search activity tags2020-12-22T15:50:49ZMonish DebUnable to search activity tagsSteps to replicate:
1. Create a tag for activities.
2. Create an activity and tag it.
3. Go to activity search and attempt to search for that tag.
Result: Returns all activitiesSteps to replicate:
1. Create a tag for activities.
2. Create an activity and tag it.
3. Go to activity search and attempt to search for that tag.
Result: Returns all activitiesMonish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/2267Proposal add api_params & api_entity to scheduled_reminder table2023-08-17T05:03:27ZeileenProposal add api_params & api_entity to scheduled_reminder table**Problem**
The scheduled reminders system lacks nuance on criteria. Fixing this requires both a UI change and a schema change but the combined effort of this is a prohibitive lift so my proposal is that we do the schema change with a fu...**Problem**
The scheduled reminders system lacks nuance on criteria. Fixing this requires both a UI change and a schema change but the combined effort of this is a prohibitive lift so my proposal is that we do the schema change with a future intent to expose in the UI but without action to do so as yet.
**Schema change**
I think we are fairly clear we want this to be a variant of an api call and we have already worked through that for the saved search table adding 2 columns
- api_params
- api_entity
I'd like to propose making the same changes to the scheduled reminders table as the saved_search table OR possibly adding saved_search_id and using saved searches from there.
I'm expecting the initial implementation would work in a similar way to the saved search - ie if the new parameter storage is loading the old code path would be ignored. Potentially we can migrate the old stuff over in time
@seamuslee @colemanw @totten