Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-08-05T02:27:08Zhttps://lab.civicrm.org/dev/core/-/issues/2734Search kit / afform allow default for filters2021-08-05T02:27:08ZeileenSearch kit / afform allow default for filtersWe would really like to be able to configure a default for our filters - ie in the screenshot below the ideal would be to be able to specify the default filter for date as 'this calendar month'.
![image](/uploads/3b012f7a67bb728523877a...We would really like to be able to configure a default for our filters - ie in the screenshot below the ideal would be to be able to specify the default filter for date as 'this calendar month'.
![image](/uploads/3b012f7a67bb728523877a2b357f577e/image.png)https://lab.civicrm.org/dev/core/-/issues/2733Contact summary appearing twice in one window after upgrade2021-08-05T17:02:15ZsbyrneContact summary appearing twice in one window after upgradeOverview
----------------------------------------
Following a manual upgrade from 5.32.0 to 5.39.0, a contacts "summary" tab appears twice in the same window as per the attached screenshot (1). When another tab is selected, the summary f...Overview
----------------------------------------
Following a manual upgrade from 5.32.0 to 5.39.0, a contacts "summary" tab appears twice in the same window as per the attached screenshot (1). When another tab is selected, the summary fields remain visible off to one side.
Reproduction steps
----------------------------------------
1. Visit any contacts summary screen
![7.39.0_2_](/uploads/fa6c7d04444aefa562e629c2575121fd/7.39.0_2_.png)
![5.93.0_1_](/uploads/6731eb990c45c1be63f197c0860ae3a8/5.93.0_1_.png)
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Firefox 59.0.1/Chrome 78.0.3904/Safari 13_
* __CiviCRM: Upgraded from 5.32.0 to 5.39.0
* __CMS:__ Drupal 7.8
* __Database:__ _MySQL 5.6https://lab.civicrm.org/dev/core/-/issues/2732SearchKit: have a quick Export task2021-09-02T17:11:13ZbgmSearchKit: have a quick Export taskCurrently, users can export from SearchKit using the traditional Export wizard of CiviCRM, which requires users to select a mapping and a few other options.
As a user, I would like to be able to quickly export the data as seen on the sc...Currently, users can export from SearchKit using the traditional Export wizard of CiviCRM, which requires users to select a mapping and a few other options.
As a user, I would like to be able to quickly export the data as seen on the screen.5.42.0https://lab.civicrm.org/dev/financial/-/issues/179Search kit bugs2021-08-04T22:27:21ZeileenSearch kit bugs@colemanw I hit a couple of things writing up about [how to do a payments search](https://docs.google.com/document/d/1OM8T-HsqFQDVGMB83iXx6CkC4mtRh4dA0hNK0MIX4hc/edit#)
I figured I'd just stick them in one ticket for now
1) The amount...@colemanw I hit a couple of things writing up about [how to do a payments search](https://docs.google.com/document/d/1OM8T-HsqFQDVGMB83iXx6CkC4mtRh4dA0hNK0MIX4hc/edit#)
I figured I'd just stick them in one ticket for now
1) The amount column from the financial_trxn table was not available to add as an afform filter
![image](/uploads/3608db6fc7f5c8289b4f276d40396927/image.png)
2) It 'looked' like I could make check_number 'edit-in-placeable' on the financial_trxn table - but it didn't work - note that check_number IS a field that should be editable as a data entry issue with no financial transaction implications (if we were editing payment method I think we would to be sure that the edit-in-place is calling v3 Payment.create not v4 FinancialTrxn.create - the former is a wrapper for the latter with more logic)
![image](/uploads/67ed36272f37bbc2fe9bdeacbe199c5d/image.png)
![image](/uploads/58fab89fd8ca820dfb2f17a0a4ffa726/image.png)https://lab.civicrm.org/dev/core/-/issues/2731Export preview when mapping fields on Case Export is wrong2023-09-10T05:03:23ZDaveDExport preview when mapping fields on Case Export is wrongNot sure when this started, I'm about 70% sure it was ok about a year ago.
1. Cases - Find Cases
2. Select some and choose export from the actions dropdown.
3. Choose to select the fields for the mapping.
4. When you start adding fields...Not sure when this started, I'm about 70% sure it was ok about a year ago.
1. Cases - Find Cases
2. Select some and choose export from the actions dropdown.
3. Choose to select the fields for the mapping.
4. When you start adding fields, all the columns in the preview show the same case repeated.
The downloaded export file is ok though.https://lab.civicrm.org/dev/core/-/issues/2730Consider replacing fopen() call in CRM_Utils_File::isIncludable with stream_r...2021-08-09T12:58:54ZDaveDConsider replacing fopen() call in CRM_Utils_File::isIncludable with stream_resolve_include_path()The problem is depending on how strict your setup is, some code that uses the error suppression operator (e.g. `@unlink('file_which_may_not_exist')`) behaves differently in php 8 and doesn't get supressed, either flooding your logs or ma...The problem is depending on how strict your setup is, some code that uses the error suppression operator (e.g. `@unlink('file_which_may_not_exist')`) behaves differently in php 8 and doesn't get supressed, either flooding your logs or making civi unusable in some cases.
In particular the api magic function provider uses an algorithm for e.g. getfields, where often the first guess is wrong, leading to an error.
isIncludable was added in 2011, and while stream_resolve_include_path was available at that time, it was introduced into php in 2010, so it's possible not a lot of sites had it.5.41.0https://lab.civicrm.org/dev/financial/-/issues/178Line Items: allow hooks to disable the core method for calculating taxes2021-07-30T22:54:03ZbgmLine Items: allow hooks to disable the core method for calculating taxesThe LineItem BAO create function recalculates taxes after the `pre` hook has been called. This makes sense, since the hook might have changed something, and taxes must be recalculated.
However, the [taxcalculator](https://lab.civicrm.or...The LineItem BAO create function recalculates taxes after the `pre` hook has been called. This makes sense, since the hook might have changed something, and taxes must be recalculated.
However, the [taxcalculator](https://lab.civicrm.org/extensions/taxcalculator) extension wants to handle tax calculations. In most places in core, it can manage to recalculate them after core has done its own recalculations, but not here:
https://github.com/civicrm/civicrm-core/blob/master/CRM/Price/BAO/LineItem.php#L34
I was wondering if it would be possible to have a magic parameter that would disable the call to `getTaxAmountForLineItem`?
Example: `hook_civicrm_pre` would allow extensions to add a param such as `skipTaxCalculations=TRUE`. Kind of like `skipLineItem`..
@eileen I expect you won't like this :-)
For context: I don't like how CiviCRM forces us to have a Financial Type + Financial Accounts + separate Line Items in Price Sets (or different Contribution Pages) for each tax jurisdiction. In Canada, this often means having ~ 5 different combos to cover most tax rates. The taxcalculator extension recalculate taxes based on the location of the contact.https://lab.civicrm.org/dev/core/-/issues/3369Scheduled Reminder limited by Participant Role fails if any participant has m...2022-06-25T00:59:49ZJonGoldScheduled Reminder limited by Participant Role fails if any participant has multiple roles### Steps to replicate
* Register someone for the Rainforest Cup. Assign multiple roles.
* Create a scheduled reminder. Limit it by participant role. See screenshot below.
* Trigger the "Send Scheduled Reminders" job.
### Expected Re...### Steps to replicate
* Register someone for the Rainforest Cup. Assign multiple roles.
* Create a scheduled reminder. Limit it by participant role. See screenshot below.
* Trigger the "Send Scheduled Reminders" job.
### Expected Result
* Job doesn't crash.
### Actual result
```
[nativecode=1292 ** Truncated incorrect DOUBLE value: '1^A2']"]
```
This happens because the WHERE clause is using `IN` but for multi-valued fields you need `REGEXP` or `RLIKE`.
![Selection_1168](/uploads/d39ddf24f2c78688369e34b81cb1bdd4/Selection_1168.png)JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2729Occasional error with search kit installed "call_user_func() expects paramete...2021-12-15T22:46:11ZDaveDOccasional error with search kit installed "call_user_func() expects parameter 1 to be a valid callback, class '\Civi\Search\AfformSearchMetadataInjector' not found"call_user_func() expects parameter 1 to be a valid callback, class '\Civi\Search\AfformSearchMetadataInjector' not found in line 214 of ...\vendor\symfony\event-dispatcher\EventDispatcher.php.
I haven't traced it, but it seems to be in ...call_user_func() expects parameter 1 to be a valid callback, class '\Civi\Search\AfformSearchMetadataInjector' not found in line 214 of ...\vendor\symfony\event-dispatcher\EventDispatcher.php.
I haven't traced it, but it seems to be in the upgrade doFinish(), and I assume is related to https://github.com/civicrm/civicrm-core/blob/b7412ea74b71e2c3c457639e301d57147655bd4e/ext/search_kit/search_kit.php#L12:
`Civi::dispatcher()->addListener('hook_civicrm_alterAngular', ['\Civi\Search\AfformSearchMetadataInjector', 'preprocess'], 1000);`
Possibly some kind of timing issue?https://lab.civicrm.org/dev/core/-/issues/2728New CiviCRM reCAPTCHA Settings Configuration Page Link Does Not Appear within...2021-08-05T02:47:07ZjohngehrigNew CiviCRM reCAPTCHA Settings Configuration Page Link Does Not Appear within Administer Pages or MenuBEFORE the update to CiviCRM 5.39, the reCAPTCHA settings were configurable from the "Misc (Undelete, PDFs, Limits, Logging, reCAPTCHA, etc.)" page:
https://FIXME.ORG/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsetting%2Fmisc&re...BEFORE the update to CiviCRM 5.39, the reCAPTCHA settings were configurable from the "Misc (Undelete, PDFs, Limits, Logging, reCAPTCHA, etc.)" page:
https://FIXME.ORG/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsetting%2Fmisc&reset=1
AFTER the update to 5.39, the reCAPTCHA settings moved to a separate page; however, the link to this page DOES NOT appear on the CiviCRM "Administer > Administration Console > Configuration Checklist" page and DOES NOT appear within any administration drop-down menu:
https://FIXME.ORG/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fsetting%2Frecaptcha&reset=1
Please add this link to the Configuration Checklist page and within the "Administer > System Settings" drop-down menu.
I understand reCAPTCHA code may have been recently moved to Core. If this issue is specific to WordPress, please let me know and I will add to WordPress development project.5.40.0https://lab.civicrm.org/dev/wordpress/-/issues/114Permalink error generated while using SwitchTo plugin to test accounts2021-08-03T20:42:04ZrbaughPermalink error generated while using SwitchTo plugin to test accountsWhile using the SwitchTo plugin to test out contacts on the site, when switching back to the admin account, the following error is generated.
>>>
PHP Fatal error: Uncaught Error: Call to a member function get_page_permastruct() on null...While using the SwitchTo plugin to test out contacts on the site, when switching back to the admin account, the following error is generated.
>>>
PHP Fatal error: Uncaught Error: Call to a member function get_page_permastruct() on null in /public_html/wp-includes/link-template.php:430
Stack trace:
\#0 /public_html/wp-includes/link-template.php(392): _get_page_link(Object(WP_Post), false, false)
\#1 /public_html/wp-includes/link-template.php(197): get_page_link(Object(WP_Post), false, false)
\#2 /public_html/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress.php(79): get_permalink(Object(WP_Post))
\#3 [internal function]: CRM_Utils_System_WordPress->{closure}()
\#4 /public_html/wp-content/plugins/civicrm/civicrm/Civi/Core/Paths.php(130): call_user_func(Object(Closure))
\#5 /public_html/wp-content/plugins/civicrm/civicrm/Civi/Core/Paths.php(256): Civi\Core\Paths->getVariable('wp.frontend', 'url')
\#6 /public_html/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress.php(432): Civi\Core\Paths->getUrl('.', 'relative')
\#7 /public_html/w in /public_html/wp-includes/link-template.php on line 430`
>>>
Reloading the page, the error isn't generated again. It is just when clicking the link to switch back to the original user account. This was working before without any issues.https://lab.civicrm.org/dev/wordpress/-/issues/113Multi Record Profile shortcode not rendering on Wordpress 5.7 Civi 5.39.02021-09-06T16:58:59Zdarren.woodsMulti Record Profile shortcode not rendering on Wordpress 5.7 Civi 5.39.0Hi, we have a multi record data group exposed through a Profile rendered as a shortcode which is showing up fine. However when you click View, Edit, Delete or "Add new record":-
![image](/uploads/b83479c61452e335243f118e05aa345d/image.pn...Hi, we have a multi record data group exposed through a Profile rendered as a shortcode which is showing up fine. However when you click View, Edit, Delete or "Add new record":-
![image](/uploads/b83479c61452e335243f118e05aa345d/image.png)
the subsequent page is simply showing the raw shortcode:-
![image](/uploads/b5dfcaad452c5fbece43483638730f3c/image.png)
URL of the parent profile page is: example.org/my-profile/my-career-history/ which works fine.
Then when clicking on one of the links, the URL turns to a non clean URL: example.org/my-profile/my-career-history/?civiwp=CiviCRM&q=civicrm%2Fprofile%2Fedit&reset=1&id=10887&multiRecord=add&gid=16&context=multiProfileDialog&onPopupClose=
Any help, much appreciated as we have let this slip through testing onto a live site!https://lab.civicrm.org/dev/core/-/issues/2727Automatic discounts not being applied to event registration forms2024-02-03T21:01:25ZLKuttnerAutomatic discounts not being applied to event registration formsOverview
----------------------------------------
Following updates to PHP 7.3.29 and MySQL 5.7.34, we discovered that event registration forms are no longer having discounts automatically applied on public pages or back-end. The discoun...Overview
----------------------------------------
Following updates to PHP 7.3.29 and MySQL 5.7.34, we discovered that event registration forms are no longer having discounts automatically applied on public pages or back-end. The discount codes do work when applied manually. No errors are being logged.
Price sets appear to be a determining factor, as any price sets that were created before 2019 are still displaying discounts properly. If I copy or try to update an old price set, they then stop displaying the discount.
Other inquiries have been posted here:
https://github.com/civicrm/org.civicrm.module.cividiscount/issues/266
https://civicrm.stackexchange.com/questions/40054/cividiscount-automatic-discounts-not-being-applied-after-server-updates
Reproduction steps
----------------------------------------
1. Create new price set for an event registration
2. Create new CiviDiscount or use an existing one with automatic discount for current members
3. Set the price set in the fees tab for the event
4. View the registration form
Current behaviour
----------------------------------------
When using a new or recently modified price set, the discount is not displayed on the registration form.
If you submit the discount code manually, it does get applied and displayed on the form.
The occurs on both our production and dev servers with the versions listed below.
Expected behaviour
----------------------------------------
The discount should be displayed on the form in the format: Conference Pass (Includes automatic member discount of: 10% ) - $ 135.00
Environment information
----------------------------------------
- CiviCRM 5.33.5
- Drupal 7.8.1.
- PHP 7.3.29
- MySQL 5.7.34
- CentOS 7.9
Dev server with same OS, PHP, and MySQL
- CiviCRM 5.39
- CiviDiscount 3.8.4
Comments
----------------------------------------
We have investigated for several days and not found any other clues.
I have tried disabling other relevant extensions without seeing any change.https://lab.civicrm.org/dev/wordpress/-/issues/112CiviCRM Shortcode issue with YoastSEO2021-08-07T03:21:36ZrbaughCiviCRM Shortcode issue with YoastSEOOn one of our sites we are using a contribution form via a shortcode on a std WP page. The form is loading just fine on the page, but when the user hits the "Review Contribution" button, the shortcode itself is rendered on the page inste...On one of our sites we are using a contribution form via a shortcode on a std WP page. The form is loading just fine on the page, but when the user hits the "Review Contribution" button, the shortcode itself is rendered on the page instead of the review form for the contribution page. After doing some testing on the site, it seems there is a conflict with YoastSEO. I tried to downgrade YoastSEO back to 16.6.1, and still have the issue.
This was previously working on an older version of CiviCRM for WP. Version 5.38 is working just fine and so was 5.37 of CiviCRM. But when upgrading to 5.39, the contribution shortcode is failing on the review step. Below are two vanilla instances of WP with CiviCRM and YoastSEO installed.
Both are on WP 5.7 and using the CiviCRM Demo data and WP theme. The contribution page for both of these is the default demo Membership contribution page, ID 2. The CiviCRM v5.38 install is working as expected, but v5.39 is breaking. If I remove YoastSEO, this works again on both. Since it was working before with Yoast installed, there is something introduced in 5.39 that is causing issues while having Yoast installed.
CiviCRM v5.38
https://civcrmtest.graydigitaldev.net/sample-page/
CiviCRM v5.39
https://civicrm.graydigitaldev.net/sample-page/5.40.1https://lab.civicrm.org/dev/wordpress/-/issues/111Civi Shortcode does not work when added in ACF fields2023-12-06T17:13:05ZKurund JalmiCivi Shortcode does not work when added in ACF fieldsSteps to replicate:
* Add ACF field of type 'textarea' for page
* Add CiviCRM shortcode in that field
* View the page, it displays blank instead of civicrm content
I have tested this on vanilla civicrm + acf plugin.
Any thoughts on th...Steps to replicate:
* Add ACF field of type 'textarea' for page
* Add CiviCRM shortcode in that field
* View the page, it displays blank instead of civicrm content
I have tested this on vanilla civicrm + acf plugin.
Any thoughts on the best way to resolve this?https://lab.civicrm.org/dev/core/-/issues/2726Connection fail in runSqlQuery function when using DSN with SSL2021-07-30T22:56:14ZerawatConnection fail in runSqlQuery function when using DSN with SSLOverview
----------------------------------------
Connection fail as below when `runSqlQuery` function in [CRM_Utils_Files](https://github.com/civicrm/civicrm-core/blob/master/CRM/Utils/File.php#L330) is called with DSN string contains ...Overview
----------------------------------------
Connection fail as below when `runSqlQuery` function in [CRM_Utils_Files](https://github.com/civicrm/civicrm-core/blob/master/CRM/Utils/File.php#L330) is called with DSN string contains SSL parameters.
`Cannot open mysqli://user:password@local:3306/civicrm_db?new_link=true&ca=%2Fetc%2Fmysql%2Fdatabase-certificate.pem: DB Error: connect failed`
The reason of the issue is that the connect function in the DB class in the PEAR package ` $db = DB::connect($dsn);` requires stating `ssl=true` as an option if we want to connect database using ssl.
The proposal to fix this is to refactor the code in `runSqlQuery` function in the CRM_Utils_File class to check if the DSN is SSL DSN then we pass the options array that say `ssl=true` as below snippet.
```
$options['ssl'] = FALSE;
if (CRM_Utils_SQL::isSSLDSN($dsn)) {
$options['ssl'] = TRUE;
}
$db = DB::connect($dsn, $options);
```
Reproduction steps
----------------------------------------
The issue can reproduce when installing CiviCRM using [Setup](https://github.com/civicrm/civicrm-setup/blob/master/src/Setup.php ) class in https://github.com/civicrm/civicrm-setup5.41.0https://lab.civicrm.org/dev/core/-/issues/2725Changed ACL behaviour after upgrading2021-08-06T19:30:27ZedvanleeuwenChanged ACL behaviour after upgradingOverview
----------------------------------------
After upgrading from 5.38 to 5.39 the ACL behaviour is different:
- The quick search keeps spinning when part of a name is input and finally ends up in a timeout.
- A person entered belon...Overview
----------------------------------------
After upgrading from 5.38 to 5.39 the ACL behaviour is different:
- The quick search keeps spinning when part of a name is input and finally ends up in a timeout.
- A person entered belonging to a group is not visible to the person which is granted access via ACL.
Both do work with complete admin rights.
_If you have already posted on https://civicrm.stackexchange.com or https://chat.civicrm.org, please include the link to that conversation._
Reproduction steps
----------------------------------------
1. Click in Quick Search.
1. Enter a partial name.
Current behaviour
----------------------------------------
The logo keeps spinning. No output, until a timeout. No errors in the Civi log or in the server's logs.
```
TIP: The best way to convey an error message is to copy it in here and use
three backtick ` symbols. You may edit the message to remove private
information (like passwords). The backticks will help to preserve any
special characters or spaces.
```
Expected behaviour
----------------------------------------
Results should be shown depending on the input.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Edge 92_
* __CiviCRM:__ _5.38.0 > 5.39.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.4__
* __CMS:__ _Drupal 7_
* __Database:__ _MariaDB 10.4_
* __Web Server:__ _Apache 2.4_
Comments
----------------------------------------
_Anything else you would like the reviewer to note._5.40.0https://lab.civicrm.org/dev/core/-/issues/3362registration via backend should expose price set fields regardless of active/...2022-04-22T16:21:40Zlcdwebregistration via backend should expose price set fields regardless of active/expire settingsWhen registering a contact through the backend, price fields should be exposed regardless of their active on/expire on dates. Those filters should only be implemented for the frontend form.When registering a contact through the backend, price fields should be exposed regardless of their active on/expire on dates. Those filters should only be implemented for the frontend form.lcdweblcdwebhttps://lab.civicrm.org/dev/core/-/issues/2724Contact dashboard ignores check for logged in user2023-09-09T05:03:24ZDaveDContact dashboard ignores check for logged in userBut I think it ends up not making a difference in practice. Came up during review of https://github.com/civicrm/civicrm-core/pull/20858 and will come back to this later.
This code: https://github.com/civicrm/civicrm-core/blob/fdb0407903...But I think it ends up not making a difference in practice. Came up during review of https://github.com/civicrm/civicrm-core/pull/20858 and will come back to this later.
This code: https://github.com/civicrm/civicrm-core/blob/fdb0407903e5b84243de2583bb6adc6fa4de1aed/CRM/Contact/Page/View/UserDashBoard.php#L246
`if (empty($userID) && $this->_contactId) {`
It was pulled out into a separate function at https://github.com/civicrm/civicrm-core/commit/2d97420b1ce7498db55e044821ad482dbe584fb3
but the $userID var is still referring to this one in a different scope:
https://github.com/civicrm/civicrm-core/blob/fdb0407903e5b84243de2583bb6adc6fa4de1aed/CRM/Contact/Page/View/UserDashBoard.php#L50https://lab.civicrm.org/dev/core/-/issues/2723Event participant role filter not working in Participant list report2023-09-08T05:03:14ZvitiusEvent participant role filter not working in Participant list reportParticipant list report with Event participant role filter could show more rows.
Reproduction steps
----------------------------------------
1. Create new participant role with id 11 (or 10, 21,...).
2. Register new participant to event...Participant list report with Event participant role filter could show more rows.
Reproduction steps
----------------------------------------
1. Create new participant role with id 11 (or 10, 21,...).
2. Register new participant to event with this new role
3. Show Participant list report on this event
4. Use Participant Role filter to show only Attendees (id of attendee role is 1)
5. In report will you see also participant with new role with id 11
Current behaviour
----------------------------------------
If you use Participant Role filter in Participant list report, that will be work like that: `role.id LIKE '%1%'` and not like `role.id = '1'`.
Expected behaviour
----------------------------------------
Report should show only exact role.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.37.0/5.33.2