Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-08-08T22:21:55Zhttps://lab.civicrm.org/dev/core/-/issues/4414CiviCRM 5.62.1 - CiviCRM core extension: Greenwich, Bootstrap CSS tries to lo...2023-08-08T22:21:55Zjustinfreeman (Agileware)CiviCRM 5.62.1 - CiviCRM core extension: Greenwich, Bootstrap CSS tries to load glyphicons fonts from the incorrect paths returns 404 and icons do not displayCiviCRM core extension: Greenwich, Bootstrap CSS tries to load glyphicons fonts from the incorrect paths returns 404 and icons do not display.
- civicrm/ext/greenwich/fonts/glyphicons-halflings-regular.woff2
- civicrm/ext/greenwich/font...CiviCRM core extension: Greenwich, Bootstrap CSS tries to load glyphicons fonts from the incorrect paths returns 404 and icons do not display.
- civicrm/ext/greenwich/fonts/glyphicons-halflings-regular.woff2
- civicrm/ext/greenwich/fonts/glyphicons-halflings-regular.woff
- civicrm/ext/greenwich/fonts/glyphicons-halflings-regular.ttf
Correct path is:
civicrm/ext/greenwich/extern/bootstrap3/assets/fonts/bootstrap/glyphicons-halflings-regular.ttf
This error is shown in the Web Console when loading the Mosaico Template Editor to create or edit a Mailing.
civicrm/ext/greenwich/dist/bootstrap3.css
```
@font-face {
font-family: "Glyphicons Halflings";
src: url("../fonts/glyphicons-halflings-regular.eot");
src: url("../fonts/glyphicons-halflings-regular.eot?#iefix") format("embedded-opentype"), url("../fonts/glyphicons-halflings-regular.woff2") format("woff2"), url("../fonts/glyphicons-halflings-regular.woff") format("woff"), url("../fonts/glyphicons-halflings-regular.ttf") format("truetype"), url("../fonts/glyphicons-halflings-regular.svg#glyphicons_halflingsregular") format("svg");
}
```
Version: CiviCRM 5.62.1
Agileware Ref: CIVICRM-2149https://lab.civicrm.org/dev/core/-/issues/4413Disabling and re-enabling a core extension removes it from the navigation men...2023-08-08T22:21:49ZlarsssandergreenDisabling and re-enabling a core extension removes it from the navigation menu and from SKIf you disabled and re-enable a core extension, you lose the relevant navigation menu item and you lose some of the relevant entities in SK. For example, if you disable and re-enable civi_mail, you lose the Mailing menu item and the Mail...If you disabled and re-enable a core extension, you lose the relevant navigation menu item and you lose some of the relevant entities in SK. For example, if you disable and re-enable civi_mail, you lose the Mailing menu item and the Mailings and Outbound Mailings entities disappear from SearchKit (but Mailing Bounces, etc are still present). Similar with civi_member. Cache clearing or menu rebuilding doesn't help. On dmaster.https://lab.civicrm.org/dev/core/-/issues/4393Mailing and Outbound Mailings no longer available in SearchKit2023-06-26T21:41:48ZlarsssandergreenMailing and Outbound Mailings no longer available in SearchKitOn 5.62, you can select Mailings and Outbound Mailings in SearchKit. On dmaster, you no longer can.On 5.62, you can select Mailings and Outbound Mailings in SearchKit. On dmaster, you no longer can.https://lab.civicrm.org/dev/core/-/issues/4392tarballs not working in 5.63+2023-07-05T23:49:06ZDaveDtarballs not working in 5.63+There's a new sql/civicrm_data folder that isn't getting included, so the UI installer doesn't work.
@totten
Also the use of `{php}` may not work in all environments. I'd have to double check but it didn't used to work in a normal for...There's a new sql/civicrm_data folder that isn't getting included, so the UI installer doesn't work.
@totten
Also the use of `{php}` may not work in all environments. I'd have to double check but it didn't used to work in a normal form tpl, but this might be a different context.5.63.0https://lab.civicrm.org/dev/core/-/issues/4391Installing a core extension results in an error2023-08-08T22:21:49ZlarsssandergreenInstalling a core extension results in an errorIf you uninstall a core extension (e.g. CiviMail), when you re-install it, you get an error. It seems to still work, but not sure on the details. Not sure if this is technically a regression or not, but tagged as regression as this certa...If you uninstall a core extension (e.g. CiviMail), when you re-install it, you get an error. It seems to still work, but not sure on the details. Not sure if this is technically a regression or not, but tagged as regression as this certainly should work. On dmaster.
```
CRM_Core_Exception: DB Error: already exists in /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Admin/Form/Extensions.php on line 187
Exception trace
# Function Location
0 civicrm_api3('Extension', 'install', Array) /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Admin/Form/Extensions.php:187
1 CRM_Admin_Form_Extensions->postProcess() /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/Form.php:617
2 CRM_Core_Form->mainProcess() /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/StateMachine.php:144
3 CRM_Core_StateMachine->perform(Object(CRM_Admin_Form_Extensions), 'next', 'Next') /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Next.php:43
4 CRM_Core_QuickForm_Action_Next->perform(Object(CRM_Admin_Form_Extensions), 'next') /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php:203
5 HTML_QuickForm_Controller->handle(Object(CRM_Admin_Form_Extensions), 'next') /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php:103
6 HTML_QuickForm_Page->handle('next') /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/Controller.php:355
7 CRM_Core_Controller->run() /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/Page/Basic.php:364
8 CRM_Core_Page_Basic->edit(1, null) /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/Page/Basic.php:170
9 CRM_Core_Page_Basic->run() /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Admin/Page/Extensions.php:105
10 CRM_Admin_Page_Extensions->run(Array, null) /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:319
11 CRM_Core_Invoke::runItem(Array) /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:69
12 CRM_Core_Invoke::_invoke(Array) /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:36
13 CRM_Core_Invoke::invoke(Array) /Users/larssander-green/buildkit/build/drupaltest/web/sites/all/modules/civicrm/drupal/civicrm.module:471
14 civicrm_invoke('admin', 'extensions') /Users/larssander-green/buildkit/build/drupaltest/web/includes/menu.inc:527
15 menu_execute_active_handler() /Users/larssander-green/buildkit/build/drupaltest/web/index.php:21
16 {main}
```https://lab.civicrm.org/dev/core/-/issues/4384AdminUI: Advanced Search not accessible2023-07-04T01:29:21ZlarsssandergreenAdminUI: Advanced Search not accessibleIf you try to access Advanced Search from the menu with AdminUI enabled on dmaster, you get:
![image](/uploads/13cf9f00ac28eb95b4a3f4489c0ddb8d/image.png)
This is due to [PR #26381](https://github.com/civicrm/civicrm-core/pull/26381) an...If you try to access Advanced Search from the menu with AdminUI enabled on dmaster, you get:
![image](/uploads/13cf9f00ac28eb95b4a3f4489c0ddb8d/image.png)
This is due to [PR #26381](https://github.com/civicrm/civicrm-core/pull/26381) and may be related to issue #4360, but I'm not sure so putting this up as a separate issue.
Requires cache clearing while testing.5.64.0https://lab.civicrm.org/dev/core/-/issues/4383One of parameters (value: ) is not of the type CommaSeparatedIntegers for le...2023-06-19T23:17:34ZDaveDOne of parameters (value: ) is not of the type CommaSeparatedIntegers for lesser-permissioned usersI'm not sure all of the variations where you can get this but a simple one is:
`cv ev "civicrm_api3('Relationship', 'create', ['contact_id_a' => 8, 'contact_id_b' => 9, 'relationship_type_id' => 'Sibling of']);"`
where 8 and 9 are suit...I'm not sure all of the variations where you can get this but a simple one is:
`cv ev "civicrm_api3('Relationship', 'create', ['contact_id_a' => 8, 'contact_id_b' => 9, 'relationship_type_id' => 'Sibling of']);"`
where 8 and 9 are suitable individual contacts. It actually happens during the `CRM_Utils_Recent:add()` call that comes after not the relationship creation.
It's from here and it's because it assumes that the earlier query will find at least one row and populate `$ids`: https://github.com/civicrm/civicrm-core/pull/26041/files#diff-7fd1affe37f9de9a37acf9decf9cecb5433999cf097eccda8b1f2af2286c32e3R268
It seems like that wouldn't be limited to just the above scenario.
Came up in weekly webform test runs.5.64.0https://lab.civicrm.org/dev/core/-/issues/4382Admin UI causes search builder (not form builder) to crash2023-07-04T01:29:55ZDaveDAdmin UI causes search builder (not form builder) to crashI think it's from here: https://github.com/civicrm/civicrm-core/commit/db712b3108970b3560488928c85d8f0343016603#diff-191c3573321ff5ab86bbe647462fbdbfbf3779611ec18a4aef86ec1a638d0043R5, which conflicts with the url `civicrm/contact/search...I think it's from here: https://github.com/civicrm/civicrm-core/commit/db712b3108970b3560488928c85d8f0343016603#diff-191c3573321ff5ab86bbe647462fbdbfbf3779611ec18a4aef86ec1a638d0043R5, which conflicts with the url `civicrm/contact/search/builder?reset=1`
While technically a regression, given that it's been stated search builder is not officially supported and was removed from the menu for new sites, I think the todo is to give a heads up somehow that in 5.64 search builder will stop working if you enable admin UI.5.64.0https://lab.civicrm.org/dev/core/-/issues/4369Trigger-based logging schema reconciliation fails when a column is renamed to...2023-06-16T21:29:35ZDaveDTrigger-based logging schema reconciliation fails when a column is renamed to a different upper/lower caseI'm getting this on upgrade: `ALTER TABLE log_civicrm_uf_group ADD post_url varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'Redirect to URL on submit.' [nativecode=1060 ** Duplicate column name 'post_url']`
and I think it'...I'm getting this on upgrade: `ALTER TABLE log_civicrm_uf_group ADD post_url varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'Redirect to URL on submit.' [nativecode=1060 ** Duplicate column name 'post_url']`
and I think it's from https://github.com/civicrm/civicrm-core/pull/26460 which changed the case. The logging table already contains a column post_URL, so when it tries to reconcile and add a column post_url it says it's a duplicate.
So either the reconcile needs to learn about how to handle this, or the upgrade script itself needs to change the logging table if it exists. The latter is probably simpler.5.64.0https://lab.civicrm.org/dev/core/-/issues/4363CiviMail Trackable URL Click Through Broken2023-06-15T15:29:14ZMichael LabriolaCiviMail Trackable URL Click Through BrokenI am using CiviCRM 5.62 with WordPress 6.2.2. After sending a CiviMail with a trackable URL, clicking on the URL in the email produces this WordPress error: There has been a critical error on this website. The PHP error on the server i...I am using CiviCRM 5.62 with WordPress 6.2.2. After sending a CiviMail with a trackable URL, clicking on the URL in the email produces this WordPress error: There has been a critical error on this website. The PHP error on the server is PHP Fatal error: Uncaught Error: Class "CRM_Mailing_Event_BAO_MailingEventClickThrough" not found in /var/www/fkww/wp-content/plugins/civicrm/wp-rest/Controller/Url.php:58
URL.php is calling CRM_Mailing_Event_BAO_MailingEventClickThrough::track which does not exist anymore. I changed it to CRM_Mailing_Event_BAO_MailingEventTrackableURLOpen::track, which works.
I don't know if url.php is supposed to be calling CRM_Mailing_Event_BAO_MailingEventTrackableURLOpen::track (and the WordPress integration is broken) or if there is an alias missing somewhere (and the CiviMail core is broken).
Last time I opened up an issue with the WordPress integration project I was told that they weren't going to fix it and I should consider migrating to a different product, so I'm opening this ticket here.
Thank you.5.62.0https://lab.civicrm.org/dev/core/-/issues/4359Afforms fields are doubled2023-06-15T13:50:57ZlarsssandergreenAfforms fields are doubled![image](/uploads/90aba1ad0e2fe411ce44f9240c6089c4/image.png)
Caused by this [recent PR](https://github.com/civicrm/civicrm-core/pull/26496).![image](/uploads/90aba1ad0e2fe411ce44f9240c6089c4/image.png)
Caused by this [recent PR](https://github.com/civicrm/civicrm-core/pull/26496).5.64.0https://lab.civicrm.org/dev/core/-/issues/4355New Activity with custom radio field gives fatal error2023-07-06T22:45:12ZDaveDNew Activity with custom radio field gives fatal error1. Create a radio field for activities.
2. Go to Contacts - New Activity.
3. Red alert box "network error" and the custom fields don't display. `TypeError: Cannot access offset of type string on string in include() (line 31 of .../templa...1. Create a radio field for activities.
2. Go to Contacts - New Activity.
3. Red alert box "network error" and the custom fields don't display. `TypeError: Cannot access offset of type string on string in include() (line 31 of .../templates_c/en_US/%%1D/1DB/1DB03A28%%CustomField.tpl.php).`
Using php 8. Doesn't happen in php 7.
Works ok in 5.61.5.64.0https://lab.civicrm.org/dev/core/-/issues/43525.62.0: Automatic CiviDiscount discount for renewal no longer shown in prices...2023-06-19T04:03:31Zcomposerjk5.62.0: Automatic CiviDiscount discount for renewal no longer shown in prices on Membership Signup and Renewal contribution pageOverview
----------------------------------------
On Member Signup and Renewal contribution page with automatic CiviDiscount set, the discount is not being shown for the membership prices.
Issue first appeared in 5.61.0 or 5.61.1 and th...Overview
----------------------------------------
On Member Signup and Renewal contribution page with automatic CiviDiscount set, the discount is not being shown for the membership prices.
Issue first appeared in 5.61.0 or 5.61.1 and then was fixed in 5.61.2, as noted in [this thread](https://chat.civicrm.org/civicrm/pl/6o68trstpigk7dx9p5dd6ncyky). Fix seemed okay through 5.61.4.
Issue re-appeared in 5.62.0. Used the same images posted earlier, but the incorrect output is the same in 5.62.0.
Related issues: #4272 & #4282.
Reproduction steps
----------------------------------------
1. Set up automatically-applied CiviDiscount for fixed amount, renewal (current, grace, expired).
2. Member Signup and Renewal contribution page with basic membership types included; no price sets.
3. Attempt to renew using that contribution page (live or test mode).
Current behaviour
----------------------------------------
What we see in 5.62.0 (and previously in 5.61.1 when it was broken) -- it still mentions the discount in the text above `Membership*` but not in the price buttons:
![image](/uploads/8c1276f1b7f7aa9256b7242bc7b37fd2/image.png)
Expected behaviour
----------------------------------------
What we expect to see (and saw in 5.60 and 5.61.2):
![image](/uploads/c1d816e789f1d761695cef49605c79ea/image.png)
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ Safari 16.5 (16615.2.9.11.6, 16615)
* __CiviCRM:__ 5.62.0 <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ 8.0.28
* __CMS:__ WordPress 6.2.2
* __Database:__ MariaDB 10.6
* __Web Server:__ Apache 2.4.57 / Nginx 1.21.3
Comments
----------------------------------------
Let me know if you need more specific steps or detail.
/cc @eileen5.62.0https://lab.civicrm.org/dev/core/-/issues/4330API4 error "Column in order clause is ambiguous"2023-06-07T00:21:50ZsamuelsovAPI4 error "Column in order clause is ambiguous"I have a specific query that used to work but seems to be broken since around CiviCRM 5.60.
I was able to reproduced in master.
This is the api4 call:
```php
$addresses = \Civi\Api4\Address::get()
->addJoin('Contact AS contact', 'LEF...I have a specific query that used to work but seems to be broken since around CiviCRM 5.60.
I was able to reproduced in master.
This is the api4 call:
```php
$addresses = \Civi\Api4\Address::get()
->addJoin('Contact AS contact', 'LEFT', ['master_id.contact_id', '=', 'contact.id'])
->addOrderBy('location_type_id:label', 'ASC')
->setLimit(25)
->execute();
```
`location_type_id` is in Address and as it it doing a join for another address to get the master_id address, it is ambiguous.
Looking at the generated query, we can see that the table prefix is not added in the order by :
```sql
SELECT `a`.`id` AS `id`, `contact`.`display_name` AS `contact.display_name`
FROM civicrm_address a
LEFT JOIN `civicrm_address` `master_id_1` ON `a`.`master_id` = `master_id_1`.`id`
LEFT JOIN `civicrm_contact` `contact` ON `master_id_1`.`contact_id` = `contact`.`id`
ORDER BY FIELD(`location_type_id`,'16','14','1','19','3','15','4','12','2','17','18','20','21','5','11') ASC;
```
Giving the error :
```
ERROR 1052 (23000): Column 'location_type_id' in order clause is ambiguous
```https://lab.civicrm.org/dev/core/-/issues/4326Notice errors on backoffice event registration2023-06-09T23:38:52ZJoeMurrayNotice errors on backoffice event registrationOverview
----------------------------------------
_Register a participant in backoffice. See notice errors._
Reproduction steps
----------------------------------------
1. On dmaster, click on **Events -> Register Event Participant**.
1...Overview
----------------------------------------
_Register a participant in backoffice. See notice errors._
Reproduction steps
----------------------------------------
1. On dmaster, click on **Events -> Register Event Participant**.
1. Select a contact, event fall fundraiser dinner, click **Save**.
1. Get three copies for different line numbers of "Notice: Trying to get property '_id' of non-object in CRM_Event_Form_Participant::formRule()".
Current behaviour
----------------------------------------
![2023-05-31_12-59-37](/uploads/b2ec1cad1728b29ecc09742cd557d759/2023-05-31_12-59-37.png)
```
Notice: Trying to get property '_id' of non-object in CRM_Event_Form_Participant::formRule() (line 825 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Participant.php).
Notice: Trying to get property '_id' of non-object in CRM_Event_Form_Participant::formRule() (line 828 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Participant.php).
Notice: Trying to get property '_action' of non-object in CRM_Event_Form_Participant::formRule() (line 836 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Participant.php).
```
Note: happens when recording payment and when not recording payment.
Expected behaviour
----------------------------------------
_No notice errors_
Environment information
----------------------------------------
dmaster
Comments
----------------------------------------
_Anything else you would like the reviewer to note._5.63.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/4317Import contribution fails with custom fields2023-07-05T23:48:39ZPhilipp MichaelImport contribution fails with custom fieldsOverview
----------------------------------------
When importing contributions with field mappings to a custom field, the process fails after continuing from step 2 of 3.
Reproduction steps
----------------------------------------
1. Cl...Overview
----------------------------------------
When importing contributions with field mappings to a custom field, the process fails after continuing from step 2 of 3.
Reproduction steps
----------------------------------------
1. Click on **Contributions -> Import Contributions**.
1. Choose mandotory options and continue to step 2.
1. In "Matching CiviCRM Field" choose at least one custom field and try to continue to step 3
1. Got an error "**TypeError: CRM_Import_Parser::getFieldMetadata(): Return value must be of type array, null returned**".
Current behavior
----------------------------------------
Regardless of the provided CSV data, the process fails with:
```
TypeError: CRM_Import_Parser::getFieldMetadata(): Return value must be of type array, null returned in CRM_Import_Parser->getFieldMetadata() (line 1768 of /var/www/html/vendor/civicrm/civicrm-core/CRM/Import/Parser.php).
CRM_Import_Parser->getFieldMetadata('Zu_belastendes_Konto.nur_anstehende_Zuwendungen._IBAN') (Line: 165)
CRM_Contribute_Import_Parser_Contribution->getMappedRow(Array) (Line: 221)
CRM_Contribute_Import_Parser_Contribution->validateValues(Array) (Line: 2551)
CRM_Import_Parser->validateRow(Array) (Line: 1842)
CRM_Import_Parser->validate() (Line: 90)
CRM_Import_Form_MapField->postProcess() (Line: 612)
CRM_Core_Form->mainProcess() (Line: 144)
CRM_Core_StateMachine->perform(Object, 'next', 'Next') (Line: 43)
CRM_Core_QuickForm_Action_Next->perform(Object, 'next') (Line: 203)
HTML_QuickForm_Controller->handle(Object, 'next') (Line: 103)
HTML_QuickForm_Page->handle('next') (Line: 355)
CRM_Core_Controller->run(Array, NULL) (Line: 319)
CRM_Core_Invoke::runItem(Array) (Line: 69)
CRM_Core_Invoke::_invoke(Array) (Line: 36)
CRM_Core_Invoke::invoke(Array) (Line: 88)
Drupal\civicrm\Civicrm->invoke(Array) (Line: 83)
Drupal\civicrm\Controller\CivicrmController->main(Array, '')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
```
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.60/5.62/5.64_
* __PHP:__ _8.0_
* __CMS:__ _Drupal 9.5.9_
* __Database:__ _MariaDB 10.4.28_
Comments
----------------------------------------
I've tested latest versions and can reproduce it in 5.60 and later. It was probably caused with changes in [Update Contribution Import to use apiv4 field names, prior to adding hooks](https://github.com/civicrm/civicrm-core/pull/25886). The way of getting custom fields available for import has changed, which leads to different field keys respectively option values. Previously you got the short version "custom_xy", now you get a long database field name like one.
5.59:
![mapping-custom-fields-options-5.59](/uploads/e4f4adc83357fd0c3e7613b6f92d5bb2/mapping-custom-fields-options-5.59.png)
5.60 (and 5.62, 5.64):
![mapping-custom-fields-options-5.62](/uploads/d0f7573c8f279bc53c794949d3183ea9/mapping-custom-fields-options-5.62.png)
The import parser can't find related field meta data regarding to those keys.
I'm not sure, if those key names provided by the API are intended and therefor can't provide a PR.5.63.0https://lab.civicrm.org/dev/core/-/issues/4310Membership HTML output on contribution pages causing layout errors due to unc...2023-05-24T07:36:13ZFrancis (Agileware)Membership HTML output on contribution pages causing layout errors due to unclosed div - 5.61 regressionOverview
----------------------------------------
[commit:dfc5fb9](https://github.com/civicrm/civicrm-core/commit/dfc5fb948b0cb11947b3b75131b54b1c365f08b1) caused a regression in the display of the Membership block, where the logic wrapp...Overview
----------------------------------------
[commit:dfc5fb9](https://github.com/civicrm/civicrm-core/commit/dfc5fb948b0cb11947b3b75131b54b1c365f08b1) caused a regression in the display of the Membership block, where the logic wrapping the "makeContribution" context skips both the closing div and the javascript portion that replaces the auto renew checkbox with a note in force autorenewal mode.
Reproduction steps
----------------------------------------
1. Create a membership contribution page.
2. Attempt to use the contribution page.
Current behaviour
----------------------------------------
The membership block escapes its containment matrix, causing an unclosed div error on the form. This manifests in the browser as a layout nesting issue.
The [W3 validator](https://validator.w3.org/nu/) explains the problem as:
```
Error: End tag form seen, but there were open elements.
From line 1779, column 3; to line 1779, column 9
>↩ ↩ ↩ </form>↩
Error: Unclosed element div.
From line 692, column 3; to line 692, column 128
↩ ↩ <div class="crm-contribution-page-id-7 crm-block crm-contribution-main-form-block" data-page-id="7" data-page-template="main">↩↩
Fatal Error: Cannot recover after last error. Any further errors will be ignored.
From line 1779, column 3; to line 1779, column 9
>↩ ↩ ↩ </form>↩
```
In addition to this, if the membership type should force autorenewal, it may not due to a missing javascript section.
Expected behaviour
----------------------------------------
There should be no layout nesting issue, and all divs should be closed appropriately.
The script to advise the end use on autorenewal should function.
Environment information
----------------------------------------
* __CiviCRM:__ _Master, 5.61.x_
* __PHP:__ 8.0
* __CMS:__ WordPress 6.2.25.61.4https://lab.civicrm.org/dev/core/-/issues/4303Custom field post help results in "Unable to load help file."2023-05-23T22:58:09Zwil_SRQCustom field post help results in "Unable to load help file."Overview
----------------------------------------
See https://civicrm.stackexchange.com/questions/44976/custom-field-post-help-results-in-unable-to-load-help-file/44978#44978
Clicking the blue help bubble for a custom field yields the e...Overview
----------------------------------------
See https://civicrm.stackexchange.com/questions/44976/custom-field-post-help-results-in-unable-to-load-help-file/44978#44978
Clicking the blue help bubble for a custom field yields the error message "Unable to load help file." The log records an exception, [attached.](/uploads/8a35ccf2e69e50a8104f8ae8e755f715/log1.txt) Non-custom fields are working normally.
Reproduction steps
----------------------------------------
1. Locate or create a custom field with field post help text
1. Go to a Create or Edit page that allows filling the custom field
1. Click the blue help bubble
Current behaviour
----------------------------------------
Described in the overview.
Expected behaviour
----------------------------------------
The field post help text displays in a pop-up at the top right of the page.
Environment information
----------------------------------------
* __CiviCRM:__ _5.61.1_
* __PHP:__ _7.4.33_
* __CMS:__ _Drupal 7.97_
* __Database:__ _MySQL 5.7.42_
*
Comments
----------------------------------------
This error is new (regression), but I don't know when it emerged. [Lars](https://civicrm.stackexchange.com/users/3533/lars-sg) confirmed correct operation on 5.58.1 and the problem on dmaster.5.61.3https://lab.civicrm.org/dev/core/-/issues/4282Membership for regression in 5.612023-06-10T01:11:59ZeileenMembership for regression in 5.61Refer https://lab.civicrm.org/dev/core/-/issues/4272#note_90443 and
https://github.com/civicrm/civicrm-core/pull/26170Refer https://lab.civicrm.org/dev/core/-/issues/4272#note_90443 and
https://github.com/civicrm/civicrm-core/pull/261705.61.2https://lab.civicrm.org/dev/core/-/issues/4281`{help}` tags that don't specify the `file` parameter no longer work on windows2023-05-19T14:00:48ZDaveD`{help}` tags that don't specify the `file` parameter no longer work on windowsSeems to have broke in 5.57 with https://github.com/civicrm/civicrm-core/commit/d80e8fa62cad6661a0882753a8babf5512f9bb12. Now it just throws an error.
An example is on the activity form if you click the help bubble for assignee.
I see ...Seems to have broke in 5.57 with https://github.com/civicrm/civicrm-core/commit/d80e8fa62cad6661a0882753a8babf5512f9bb12. Now it just throws an error.
An example is on the activity form if you click the help bubble for assignee.
I see - it's because on windows it doesn't match the regex because it has `\` instead.5.63.0