Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-07-19T17:19:26Zhttps://lab.civicrm.org/dev/core/-/issues/2397Add 'readonly' attribute to fields in schema2021-07-19T17:19:26ZcolemanwAdd 'readonly' attribute to fields in schemaThis is needed by Afform and SearchKit to know whether a field is appropriate to show to the user.
The goal here is to add 'readonly' to all fields that should *not* be presented as editable on user-facing forms.
Examples of fields tha...This is needed by Afform and SearchKit to know whether a field is appropriate to show to the user.
The goal here is to add 'readonly' to all fields that should *not* be presented as editable on user-facing forms.
Examples of fields that should be considered "readonly"
----
- [x] Contact type (theoretically could be changed, but only under special circumstances and there's an extension for that)
- [x] ID fields
- [x] Contact Hash
- [x] Custom fields marked `"is_view"`
- [ ] FK fields that are not meant to change, e.g. Email.contact_id or Participant.contact_id. (in rare circumstances this field gets updated e.g. during deduping, but it's still not something to present on a typical user-facing form, so I'd consider them `'readonly'`).
- [ ] Any auto-increment fields or autopopulated fields e.g. `'creation_date'`.
- [ ] Any other fields that are typically written to programatically and not shown on forms.seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2395Cannot use Afform to create a linked activity2023-07-19T05:03:21ZseamusleeCannot use Afform to create a linked activityAs per https://lab.civicrm.org/extensions/afform/-/issues/21 you cannot use Afform to create an activity when the form is submitted because the source_contact_id field is required by APIv4 when doing activity.create / activity.save and t...As per https://lab.civicrm.org/extensions/afform/-/issues/21 you cannot use Afform to create an activity when the form is submitted because the source_contact_id field is required by APIv4 when doing activity.create / activity.save and there is no way to pass through a param in the Afform form.seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2394Decimal Separator - Incorrect format in some views and editions2023-02-16T13:30:23ZCésarDecimal Separator - Incorrect format in some views and editionsHello,
The Money type fields are not working correctly when modifying the language, the decimal delimiter and the thousands separator are configured, detected with custom case fields and editing a contribution.
* Example custom field i...Hello,
The Money type fields are not working correctly when modifying the language, the decimal delimiter and the thousands separator are configured, detected with custom case fields and editing a contribution.
* Example custom field in case view: (version afected > 5.21.0)
![bug_separator](/uploads/3a6495402f7318f656bf94c73912cda2/bug_separator.gif)
* Example fields in contribution edit: (version afected 5.36.alpha1)
In v5.34.0 the value of total_amount is replaced by the default format value (Ex: 1.000,10 to 1,000.10) in edit form of contribution.
![bug_separator_contrib](/uploads/eb1a291ab6f1311a1e72fa19f0dba5a0/bug_separator_contrib.gif)5.35.0https://lab.civicrm.org/dev/core/-/issues/2393Settings metadata help_text parameter doesn't work and causes errors if you s...2023-06-27T05:03:25ZDaveDSettings metadata help_text parameter doesn't work and causes errors if you specify it but there's no .hlp fileNot sure if I'm going to follow this thru but am recording some findings. There's at least 3 things to deal with:
1. There's no facility to specify the title of the help box. This is the easiest since it can compute it from the setting ...Not sure if I'm going to follow this thru but am recording some findings. There's at least 3 things to deal with:
1. There's no facility to specify the title of the help box. This is the easiest since it can compute it from the setting label.
2. CRM.help _does_ support passing a single string as the help content, but you get into quote-hell pretty quickly.
3. The `{help}` plugin which is what generates the `<a>` link that calls CRM.help doesn't have a way to accept a string as the help content, and `{help}` is what SettingForm.tpl uses. \
3.b Related note: the `{help}` plugin behaves differently whether you pass it a title parameter or not. If there's no parameter it expects to find it inside an associated .hlp file.
Earlier related issue: https://lab.civicrm.org/dev/core/-/issues/1920https://lab.civicrm.org/dev/core/-/issues/2392Deprecated force url for contribution dashboard links2021-02-17T23:06:15ZDaveDDeprecated force url for contribution dashboard links1. Contribution dashboard
2. Click the table layout "button" near the top.
3. Click on one of the "view details" links.
4. `User deprecated function: Deprecated function CRM_Contribute_Form_Search::setDeprecatedDefaults, use pass receive...1. Contribution dashboard
2. Click the table layout "button" near the top.
3. Click on one of the "view details" links.
4. `User deprecated function: Deprecated function CRM_Contribute_Form_Search::setDeprecatedDefaults, use pass receive_date_high not end`5.36.0https://lab.civicrm.org/dev/core/-/issues/2391Do Not Trade Privacy option is missing from report template.2021-02-23T09:18:57ZtapashDo Not Trade Privacy option is missing from report template.Do Not Trade Privacy option is missing from core report template.Do Not Trade Privacy option is missing from core report template.5.36.0https://lab.civicrm.org/dev/core/-/issues/2390Add hook support for Activity Contact2021-03-21T21:40:18ZyashodhaAdd hook support for Activity ContactCurrently, there is no hook support for Activity Contact.Currently, there is no hook support for Activity Contact.5.37.0yashodhayashodhahttps://lab.civicrm.org/dev/wordpress/-/issues/91Remove Base Page content filter once it has been used2021-07-19T10:00:32ZhaystackRemove Base Page content filter once it has been usedSince the Base Page should only be rendered once, we can dispense with the content filter once it has run. This would solve [this issue raised on StackExchange](https://civicrm.stackexchange.com/questions/38854/double-registration-form-o...Since the Base Page should only be rendered once, we can dispense with the content filter once it has run. This would solve [this issue raised on StackExchange](https://civicrm.stackexchange.com/questions/38854/double-registration-form-on-wordpress) without needing extra code.
PR to follow.haystackhaystackhttps://lab.civicrm.org/dev/core/-/issues/2389Search kit navigation - once I've created an afform it's hard to edit it2021-02-23T09:20:59ZeileenSearch kit navigation - once I've created an afform it's hard to edit itIt's really hard to see how to edit a search afform once created -
![image](/uploads/fe400ccb1d640f22723af4fd55b49c50/image.png)
Even just an edit link from the form would help a lot
![image](/uploads/5e4cb7d544f36d6de72fa4c1c77d9d2c...It's really hard to see how to edit a search afform once created -
![image](/uploads/fe400ccb1d640f22723af4fd55b49c50/image.png)
Even just an edit link from the form would help a lot
![image](/uploads/5e4cb7d544f36d6de72fa4c1c77d9d2c/image.png)
@colemanw5.36.0https://lab.civicrm.org/dev/core/-/issues/2388Searchkit bug - not displaying grouped by field2021-02-21T22:07:08ZeileenSearchkit bug - not displaying grouped by fieldAt a url like
civicrm/admin/search#/create/Contribution?params=%7B"version":4,"select":%5B"financial_type_id:label","SUM(total_amount)%20AS%20SUM_total_amount"%5D,"orderBy":%7B%7D,"where":%5B%5D,"groupBy":%5B"financial_type_id"%5D,"join...At a url like
civicrm/admin/search#/create/Contribution?params=%7B"version":4,"select":%5B"financial_type_id:label","SUM(total_amount)%20AS%20SUM_total_amount"%5D,"orderBy":%7B%7D,"where":%5B%5D,"groupBy":%5B"financial_type_id"%5D,"join":%5B%5D,"having":%5B%5D%7D
the financial type field is empty
![image](/uploads/5297013039c6f27b591c1ce2d354d71b/image.png)
![image](/uploads/0f74b9e2b98d9e312018218ad43ac727/image.png)
@colemanw5.36.0https://lab.civicrm.org/dev/civicrm-asset-plugin/-/issues/18civicrm-asset-plugin not available from github2021-02-19T08:35:07Zyalhcivicrm-asset-plugin not available from githubHi,
I'm trying to install CiviCRM for Drupal 8 on an OVH hosting.
The point is: OVH only allows outgoing connections to few sites like: https://getcomposer.org/, https://gitlab.com/, https://github.com/ but not https://lab.civicrm.org...Hi,
I'm trying to install CiviCRM for Drupal 8 on an OVH hosting.
The point is: OVH only allows outgoing connections to few sites like: https://getcomposer.org/, https://gitlab.com/, https://github.com/ but not https://lab.civicrm.org (tested doing some curl tests)
Other requirements for installing CiviCRM for Drupal 8 with composer are available at github.com.
Would it be possible to make civicrm-asset-plugin available from github and default repository for composer at github?
Thanks in advance.https://lab.civicrm.org/dev/core/-/issues/2387'Recent Items' fails to show list of Recent Items2021-03-15T06:08:08Zspalmstrom'Recent Items' fails to show list of Recent ItemsOverview
----------------------------------------
The _Recent Items_ block fails to show the list of recent items, it only shows the current user. It is not manifest on the demo site ([CiviCRM Sandbox on Drupal](https://dmaster.demo.civi...Overview
----------------------------------------
The _Recent Items_ block fails to show the list of recent items, it only shows the current user. It is not manifest on the demo site ([CiviCRM Sandbox on Drupal](https://dmaster.demo.civicrm.org/civicrm)), but is manifest on _drupal9-clean_ _civibuild_ installation, both under Ubuntu 20.4 and ported to Windows. It is also manifest on a Drupal 9 installation running CiviCRM 5.34.0.
See _StackExchange_ entry [Recent Items Block Does Not Show Recent Items Unless There Are Report Results](https://civicrm.stackexchange.com/questions/38292/recent-items-block-does-not-show-recent-items-unless-there-are-report-results)
Reproduction steps
----------------------------------------
1. Click on **Search -> Find Contacts**.
1. Go to a contact and click **View**.
1. Contact name does not appear in **Recent Items**.
Current behaviour
----------------------------------------
Contact name does not appear in _Recent Items_, only the user.
![image](/uploads/0e47865da098da1752d530b072dee0fc/image.png)
Expected behaviour
----------------------------------------
The contact name should appear in _Recent Items_.
![image](/uploads/3d7254e6a538ecfcb3be37f799c73f4b/image.png)
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _MS Edge_ but probably irrelevant.
* __CiviCRM:__ _5.36.alpha1/5.34.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.3/7.4__ but probably irrelevant
* __CMS:__ _Drupal 9.x_
* __Database:__ _MySQL 8.x._ but probably irrelevant
* __Web Server:__ _Apache 2.4/IIS 10_ but probably irrelevant.
Comments
----------------------------------------
It may be that I am missing some CiviCRM setting or something really obvious. It seemed a good idea to flag the issue so as to create a branch name should it be necessary to create a pull request to solve the issue as I plan to do further research on it.5.36.0https://lab.civicrm.org/dev/core/-/issues/2386Support chain-select elements in .setting.php files2023-07-01T05:03:24ZJonGoldSupport chain-select elements in .setting.php filesOverview
----------------------------------------
As we move to metadata-based settings, we need to support existing use cases such as chain-select.
Example use-case
----------------------------------------
1. Go to **Administer » Local...Overview
----------------------------------------
As we move to metadata-based settings, we need to support existing use cases such as chain-select.
Example use-case
----------------------------------------
1. Go to **Administer » Localization » Languages, Currencies, Locations**.
1. The `defaultContactStateProvince` setting can't be represented accurately via metadata.
Current behaviour
----------------------------------------
No way to define either an `onclick` value or a chain-select.
Proposed behaviour
----------------------------------------
A new property `chain_select_settings` contains properties that are passed to the `addChainSelect` method.
Comments
----------------------------------------
There's partial support, and I suspect work on this stopped because `addChainSelect` has a syntax that's tangled up in Smarty. I'll submit a PR to be a conversation piece.
This will also need documentation.JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2385Investigate replacing civicase views with something that is not views2021-12-08T09:00:21ZDaveDInvestigate replacing civicase views with something that is not viewsRelated to https://lab.civicrm.org/dev/core/-/issues/2262.
CiviCase uses mysql views (as opposed to drupal views) and is the only component that does so. I'm not sure if they're still truly needed the way they originally were. In additi...Related to https://lab.civicrm.org/dev/core/-/issues/2262.
CiviCase uses mysql views (as opposed to drupal views) and is the only component that does so. I'm not sure if they're still truly needed the way they originally were. In addition to the issue above, they hardcode activity status id and the number 14 (nothing against the number 14, but hey) making it difficult to override those.
I haven't looked at the full query lately but at one time it had a self-join on the view which was where it was convenient to have the view since at the time you couldn't self-join to temporary tables, which might still be true.5.37.0https://lab.civicrm.org/dev/core/-/issues/2384Remove text about email receipts for each recurring contribution.2021-03-19T21:23:23ZlarsssandergreenRemove text about email receipts for each recurring contribution.On a contribution page, when you select a recurring contribution, this is part of the message that appears: "You will receive an email receipt for each recurring contribution" if [email receipt is enabled for the contribution page.](http...On a contribution page, when you select a recurring contribution, this is part of the message that appears: "You will receive an email receipt for each recurring contribution" if [email receipt is enabled for the contribution page.](https://github.com/civicrm/civicrm-core/blob/e4c693f6e2114a1f536d406d2ef107fc56e7952c/CRM/Core/Payment.php#L596)
I'm sure we're not the only org that sends an email receipt for the first recurring contribution through the contribution page, but doesn't send a receipt for every contribution, making this text inaccurate. It would also be incorrect if a donor isn't entering an email address.
From the perspective of the person filing out the form, I'm not sure whether or not they'll receive an email receipt for every contribution is necessary information. My suggestion is to remove this sentence. I think this kind of information makes sense in an email receipt (where it is also more easily editable) rather than on a contribution page.
I would also suggest removing this sentence: "Your recurring contribution will be processed automatically." I think it is quite obvious that if someone is making a recurring contribution, it will be processed automatically.
If both these sentences were removed, then there is no additional text shown when someone makes a recurring contribution on a page where they can't select the number of instalments, which would be nice and simple.5.37.0https://lab.civicrm.org/dev/core/-/issues/2383contact custom data date field not working in scheduled reminder2021-04-09T01:59:24Zvakeesan26contact custom data date field not working in scheduled reminderWhen we use the contact custom date field in scheduled reminder condition, then it is not working as expected
![image](/uploads/b7084dc4297fe6a78732529c61d29434/image.png)
CRM_Core_BAO_ActionSchedule::prepareMailingQuery function addi...When we use the contact custom date field in scheduled reminder condition, then it is not working as expected
![image](/uploads/b7084dc4297fe6a78732529c61d29434/image.png)
CRM_Core_BAO_ActionSchedule::prepareMailingQuery function adding Inner join with contact id and custom value table ID field
Eg :-
SELECT reminder.id as reminderID, reminder.contact_id as contactID, reminder.entity_table as entityTable, reminder.*, e.id AS entityID, e.id as entityID, e.*
FROM civicrm_action_log reminder
**INNER JOIN civicrm_contact e ON e.id = reminder.entity_id**
WHERE (reminder.action_schedule_id = 22) AND (reminder.action_date_time IS NULL)5.37.0https://lab.civicrm.org/dev/wordpress/-/issues/90Inconsistent Shortcode rendering2021-10-16T13:15:58ZhaystackInconsistent Shortcode renderingThe issue is kind of complicated. What happens when a Shortcode is embedded in a Post/Page is that the CiviCRM-WordPress plugin goes into "Shortcode Mode", parses the Shortcode and returns the resulting markup to the page.
However, if ...The issue is kind of complicated. What happens when a Shortcode is embedded in a Post/Page is that the CiviCRM-WordPress plugin goes into "Shortcode Mode", parses the Shortcode and returns the resulting markup to the page.
However, if any action is taken via a Shortcode, a query string is appended to the URL and CiviCRM-WordPress goes into "Base Page Mode". The relevant code that tries to sort all of this out (and which has been present in the plugin since before I started work on it) is here:
https://github.com/civicrm/civicrm-wordpress/blob/c40aa7106b21ebad25199e8c2b5d5b0e91d351b1/civicrm.php#L693-L732
Now, one of the results of going into "Base Page Mode" is that the entire content of the Post/Page is replaced via a filter on `the_content` which means - for some layouts and some themes - that the Post/Page is no longer rendered as if the Shortcode _were_ present.
I realise that the current behaviour may now be the "expected" behaviour. Hopefully people can test the PR and let me know what impact (if any) it has for their designs.haystackhaystackhttps://lab.civicrm.org/dev/core/-/issues/2381Trigger-based logging crashes on updates to tables with fields of type blob2021-02-23T12:19:14ZDaveDTrigger-based logging crashes on updates to tables with fields of type blobIn https://github.com/civicrm/civicrm-core/pull/18782 binary comparison was added to triggers to allow it to capture changes in upper/lower/accents. For reasons I don't understand at the moment if you apply binary collation to a binary f...In https://github.com/civicrm/civicrm-core/pull/18782 binary comparison was added to triggers to allow it to capture changes in upper/lower/accents. For reasons I don't understand at the moment if you apply binary collation to a binary field (like blob) it says binary doesn't match binary.
`COLLATION 'utf8mb4_bin' is not valid for CHARACTER SET 'binary'`
Description may change as I look closer. Marking regression since it was added in 5.35. Comes up when doing e.g. `UPDATE civicrm_file SET ..something..` which has `document` as a blob field.https://lab.civicrm.org/dev/core/-/issues/2380WordPress, PayPal IPN fails when CiviCRM Contribution Page shortcode is used ...2021-02-26T21:28:23Zjustinfreeman (Agileware)WordPress, PayPal IPN fails when CiviCRM Contribution Page shortcode is used on a page which requires login to access eg. Private page.WordPress, PayPal IPN fails when CiviCRM Contribution Page shortcode is used on a page which requires login to access eg. Private page.
PayPal IPN will attempt to access the Private page, WordPress will redirect to the login page and th...WordPress, PayPal IPN fails when CiviCRM Contribution Page shortcode is used on a page which requires login to access eg. Private page.
PayPal IPN will attempt to access the Private page, WordPress will redirect to the login page and the IPN fails.
It is expected that the PayPal IPN should succeed by calling a general CiviCRM URL for PayPal rather than the actual CiviCRM Contribution Page. This should not be confused with the return URL PayPal calls in the web browser which then loads the CiviCRM Thank You page.
There can be many valid reasons for having a CiviCRM Contribution Page shortcode used on a Private page, for example: users must be logged in to renew membership, or only logged in users can purchase a "widget".
Agileware Ref: CIVICRM-1668
WordPress 5.6
CiviCRM 5.33.2https://lab.civicrm.org/dev/core/-/issues/2379Geocoding saves values that web UI doesn't accept2023-06-26T12:56:40ZJonGoldGeocoding saves values that web UI doesn't acceptOverview
----------------------------------------
Geocoders can pass back a valid latitude/longitude that looks something like this: `-12.456789012345`. That's 16 characters. However, `CRM_Core_DAO::makeAttribute()` only allows saving `...Overview
----------------------------------------
Geocoders can pass back a valid latitude/longitude that looks something like this: `-12.456789012345`. That's 16 characters. However, `CRM_Core_DAO::makeAttribute()` only allows saving `float` values with a max of 14 characters. So attempting to edit an address with a long lat/lon results in a validation error.
Reproduction steps
----------------------------------------
* Manually enter into the database a `geo_code_1` value of `-12.456789012345` on an address.
* Attempt to edit the address.
Current behaviour
----------------------------------------
![Screen_Shot_2021-02-09_at_9.47.59_AM](/uploads/7627d641a1580c9461916299a97f50d7/Screen_Shot_2021-02-09_at_9.47.59_AM.png)
```
TIP: The best way to convey an error message is to copy it in here and use
three backtick ` symbols. You may edit the message to remove private
information (like passwords). The backticks will help to preserve any
special characters or spaces.
```
Expected behaviour
----------------------------------------
Geocode shouldn't trigger validation errors.5.36.0JonGoldJonGold