Development issueshttps://lab.civicrm.org/groups/dev/-/issues2022-10-11T11:57:34Zhttps://lab.civicrm.org/dev/core/-/issues/3892Contribution for event registration with multiple participants lists them mul...2022-10-11T11:57:34Zthoni56Contribution for event registration with multiple participants lists them multiple times in "associated participants"Overview
----------------------------------------
If an event registration is made for multiple participants the corresponding contribution view lists participants multiple times.
Reproduction steps
-------------------------------------...Overview
----------------------------------------
If an event registration is made for multiple participants the corresponding contribution view lists participants multiple times.
Reproduction steps
----------------------------------------
1. Do a single registration with multiple participants to a paid event
2. Go to the resulting contribution and view it
Current behaviour
----------------------------------------
In the section "Associated participants" each participant is listed multiple times, even for the same registration option.
E.g. for this registration for 8 participants (from the "Contribution Amount" section of the same view):
![Skärmbild_2022-10-04_205306](/uploads/93ad061f56970aca8b854c2c41d9f78b/Skärmbild_2022-10-04_205306.png)
we get this "Associated Participants" listing:
![Skärmbild_2022-10-04_205401](/uploads/404d53d7cec254a9aae24962324badef/Skärmbild_2022-10-04_205401.png)
Expected behaviour
----------------------------------------
I'm expecting to see each participant listed only once.
Environment information
----------------------------------------
The event has price sets with multiple options.
![Skärmbild_2022-10-04_223722](/uploads/db466e84bf3a11a04db31181259eed4a/Skärmbild_2022-10-04_223722.png)
![Skärmbild_2022-10-04_223744](/uploads/82129e1b4bd6f32152b53e57df44f815/Skärmbild_2022-10-04_223744.png)
Comments
----------------------------------------
I encountered this since I was trying to get a nice list to include in our invoices. (We cannot use the CiviCRM invoices, partly because of dev/core#3881)5.56.0https://lab.civicrm.org/dev/core/-/issues/3891Show ical and Google Calendar links for non-public events2022-10-25T11:50:06ZlarsssandergreenShow ical and Google Calendar links for non-public eventsCurrently, the Download iCalendar entry for this event and Add event to Google Calendar links only appear in event confirmation emails, on the event confirmation page and on the event info page if the event is public.
But if someone has...Currently, the Download iCalendar entry for this event and Add event to Google Calendar links only appear in event confirmation emails, on the event confirmation page and on the event info page if the event is public.
But if someone has registered for an event, they should be able to add that event to their calendar regardless of whether it is public or not. The event info page can also include these links as the calendar links contain the same information as is already found on the page.
For reference, the help text for Public Event says: "When enabled, this event will be included in iCalendar feeds and displayed on your site's "Upcoming Events" block." So there shouldn't be any expectation that we're hiding calendar links for non-public events as this settings controls only calendar _feeds_. Can't see any reason we'd want to hide calendar links, in any case.
Turns out the links fail when the event is non-public, so I'll have to fix that first.https://lab.civicrm.org/dev/core/-/issues/3890Proposal: Rebuild smart group cache for specific smart groups included in mai...2022-10-25T11:50:42ZlarsssandergreenProposal: Rebuild smart group cache for specific smart groups included in mailing at scheduling timeIdeally, the recipients of a mailing with smart groups should be as up to date as possible when the mailing is scheduled. Currently, a cached version of the smart group is used to build the list of recipients, leading to potentially out ...Ideally, the recipients of a mailing with smart groups should be as up to date as possible when the mailing is scheduled. Currently, a cached version of the smart group is used to build the list of recipients, leading to potentially out of date recipients.
Can we just rebuild the smart group cache for the specific smart groups included in a mailing at scheduling time? Is there significant risk to doing so?
@eileen, I understand you're the expert on this.https://lab.civicrm.org/dev/core/-/issues/3889API4 dates entered without time can give unexpected results2022-10-25T11:50:59ZlarsssandergreenAPI4 dates entered without time can give unexpected resultsFor a datetime field, any date in an API call is converted to a datetime (midnight on the date in question). This can give unexpected results for gets, especially using Search Kit or Form Builder, where users probably aren't thinking abo...For a datetime field, any date in an API call is converted to a datetime (midnight on the date in question). This can give unexpected results for gets, especially using Search Kit or Form Builder, where users probably aren't thinking about dates versus datetimes. These results also aren't consistent with what you get from Advanced Search or other searches.
For example, searching for a contribution with receive_date = 2022-01-01 does not return all contributions received on that date. It only returns contributions received at exactly midnight, i.e. with receive_date = 20220101000000.
Similar issues exist for other operators, like !=, > (will include the date), <= (won't include the date), BETWEEN and NOT BETWEEN (will include the from date, but not the to date), and IN and NOT IN.
The simplest solution would be to put a SQL DATEFORMAT() around the database date field when the date does not include a time and use a Ymd format. This wouldn't work for BETWEEN or IN when one date includes a time and the other doesn't though.
Or if we don't want to change the query, another approach would be to check absolute dates entered into the API to see if they include a time component or not.
- If they include a time, proceed as usual.
- If they don't include times, for all operators except = and !=/<>, set the time component or components depending on the operator (e.g. for BETWEEN set 000000 for the from date, 235959 for the to date).
- For = or !=, switch the operator to BETWEEN or NOT BETWEEN, set the from date to 000000 and the to date to 235959.
- For IN and NOT IN, I'm not sure there's an easy solution in this case. We'd have to convert that to a series of BETWEENs and that's going to be difficult. Is there a good way to warn users that this won't work?
- Not sure what the other operators are supposed to do with dates.
But maybe there's a more elegant solution to this problem. Hoping to get some expert feedback before starting any work on this, since date stuff can be such a quagmire.https://lab.civicrm.org/dev/core/-/issues/3888Checksum link does not popuplate 'primary' State address field on form2022-12-10T05:14:09ZStoobChecksum link does not popuplate 'primary' State address field on formI have replicated this issue on 5.53.0 and 5.49.4
A checksum link to a form that contains address fields does not populate State/Province field whereas all other address fields seem to work.
[This link is an example.](https://civiteach...I have replicated this issue on 5.53.0 and 5.49.4
A checksum link to a form that contains address fields does not populate State/Province field whereas all other address fields seem to work.
[This link is an example.](https://civiteacher.com/civicrm/contribute/transact?reset=1&id=5&cs=2884f3d7245410f5705a968fffd74306_1664477605_504&cid=730)
Attached are examples of the config screenshots
![sp](/uploads/da5db557db16b364a2e0c1662a671c4b/sp.png)
![oosad](/uploads/86bebd186d575f6a827ca150f6de6c4a/oosad.png)https://lab.civicrm.org/dev/core/-/issues/3887CiviMail failed with a loose translated message like "Sorry, error happened a...2022-10-20T19:45:37ZSylvain PlanteCiviMail failed with a loose translated message like "Sorry, error happened and your mail has not been record" whenever I tried to use a sample templateOverview
----------------------------------------
When we try to create a mass mailing message and use one of the sample template provided with CiviCRM, I get this message "Désolé, une erreur est survenue et vos informations n'ont pas ét...Overview
----------------------------------------
When we try to create a mass mailing message and use one of the sample template provided with CiviCRM, I get this message "Désolé, une erreur est survenue et vos informations n'ont pas été enregistrées". If I use a simplier template I made, it is working ok.
_If you have already posted on https://civicrm.stackexchange.com or https://chat.civicrm.org, please include the link to that conversation._
Reproduction steps
----------------------------------------
1. Click on **mass mailing**, **new mailing**
2. Fill all fields except **Campaign** and **Template** and then clicked **Save as draft**.
3. Got no error message.
4. Go back, click on **mass mailing**, **draft mailing**, find the draft and click **continue".
5. Choose a template in **template** field.
6. As soon as the template finish loading and autosave try to save it...
7. Got the error message "Désolé, une erreur est survenue et vos informations n'ont pas été enregistrées"
Current behaviour
----------------------------------------
Expected behaviour
----------------------------------------
Should save a draft and let me edit the mail template.
Environment information
----------------------------------------
* __Browser:__ _Chrome Version 106.0.5249.61 | Edge Version 105.0.1343.53
* __CiviCRM:__ _Master/5.50.1
* __PHP:__ _7.4.29
* __CMS:__ _WordPress 6.0.2
* __Database:__ _MariaDB 10.3.34
* __Web Server:__ _Apache 2.4.53
Comments
----------------------------------------
I have tried to reset CiviCRM cache and rebuild path but to no avail. Group are small, 2 or 3 email address. Work with a simple custom template. No recent update of WP or CiviCRM. We are just starting playing with mass mailing, so I can't tell for how long it has not been working. Also tested sending email to a group. Search contact, select a couple of contact, action->send immediate email, choose the sample template, fill the fields, send email, success! No problem. Seem to be related to how CiviMail store a mass mailing in db. Need help to debug further. Thank you.https://lab.civicrm.org/dev/core/-/issues/3886api3 explorer giving strange advice for customfield.create2022-10-10T10:01:22ZDaveDapi3 explorer giving strange advice for customfield.createDoing a get gives "String" and "Text", which matches my memory and v4 explorer. But I'm not sure when this changed.
![Untitled3](/uploads/a9e8e188fec92c45f2e1dd8aad3e9bef/Untitled3.png)Doing a get gives "String" and "Text", which matches my memory and v4 explorer. But I'm not sure when this changed.
![Untitled3](/uploads/a9e8e188fec92c45f2e1dd8aad3e9bef/Untitled3.png)https://lab.civicrm.org/dev/core/-/issues/3885Search results include participants with price set options they have been rem...2023-04-15T19:36:58ZlarsssandergreenSearch results include participants with price set options they have been removed fromIf a price set option / fee level quantity is 0 because a participant registration has been changed to remove that option, search results include participants with quantity 0. Search results should not include these participants with fee...If a price set option / fee level quantity is 0 because a participant registration has been changed to remove that option, search results include participants with quantity 0. Search results should not include these participants with fee level quantity 0 because they are not registered for that option.
More details in [PR #24650](https://github.com/civicrm/civicrm-core/pull/24650).https://lab.civicrm.org/dev/core/-/issues/3884ical files missing "VTIMEZONE" component2022-09-30T17:20:12ZAndrew Wassonical files missing "VTIMEZONE" componentOverview
----------------------------------------
CiviEvent ical files are generated without the "VTIMEZONE" component which means in some time zones the event date and time will be incorrect with some calendar clients.
Specifically I ...Overview
----------------------------------------
CiviEvent ical files are generated without the "VTIMEZONE" component which means in some time zones the event date and time will be incorrect with some calendar clients.
Specifically I have two Drupal/CiviCRM websites in Alberta that use America/Edmonton as their timezone settings. Several CiviEvents towards the end of September and the month of October generate iCal files that are off by an hour for Microsoft Outlook Calendars set for the Alberta Canada time zone. Apple Calendars and Google Calendars set for Alberta time render the iCal files correctly. If we add markup for "VTIMEZONE" in the iCal file, they work correctly for Microsoft Outlook Calendars set for the Alberta Canada time zone.
```
I've added the following static markup to the iCal files to get them to behave correctly in Microsoft Outlook Calendar set to the Alberta Time Zone.
BEGIN:VTIMEZONE
TZID:America/Edmonton
LAST-MODIFIED:20220816T024022Z
TZURL:https://static.tzurl.org/zoneinfo-outlook/America/Edmonton.ics
X-LIC-LOCATION:America/Edmonton
BEGIN:DAYLIGHT
TZNAME:MDT
TZOFFSETFROM:-0700
TZOFFSETTO:-0600
DTSTART:19700308T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:MST
TZOFFSETFROM:-0600
TZOFFSETTO:-0700
DTSTART:19701101T020000
RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
END:STANDARD
END:VTIMEZONE
```
The "VTIMEZONE" component is described here: https://icalendar.org/iCalendar-RFC-5545/3-6-5-time-zone-component.html
Suggested Fix
----------------------------------------
In order to fix this issue, I suggest VTIMEZONE markup is added to the file at: /civicrm/templates/CRM/Core/Calendar/ICal.tpl
It will require some dynamic code to pull the TZURL: from a lookup table and for the DTSTART/END for DAYLIGHT and STANDARD if the timezone uses DST. It may be that the values can be scraped from the TZURL file.
Cheers,
Andrewhttps://lab.civicrm.org/dev/core/-/issues/3883Group - remove contacts action removes contacts who are not in group and repo...2022-10-25T11:51:49ZlarsssandergreenGroup - remove contacts action removes contacts who are not in group and reports incorrect numbers removedOverview
----------------------------------------
[removeContactsFromGroup](https://github.com/civicrm/civicrm-core/blob/843958bc0022cec4145c8796ae49ccb2fd9d3c28/CRM/Contact/BAO/GroupContact.php#L156) doesn't check if a contact is in a g...Overview
----------------------------------------
[removeContactsFromGroup](https://github.com/civicrm/civicrm-core/blob/843958bc0022cec4145c8796ae49ccb2fd9d3c28/CRM/Contact/BAO/GroupContact.php#L156) doesn't check if a contact is in a group before removing or deleting them, resulting in some strange behaviour. The reported counts shown to the user of contacts removed are also incorrect. Subscription history is set when it doesn't need to be.
This function is also used by Api3 and for unsubscribes.
Current behaviour
----------------------------------------
If we're removing, no matter what the current status of the contact is in the group (Added, Pending, Removed or none at all), the status is set to Removed. If a contact had no relationship to the group at all, they will be set to Removed (and show on the Contact Groups tab as removed, which is confusing for the user as they were never in the group). In all cases, subscription history is added with status Removed.
Counts of contacts removed reported to user are incorrect.
If we're deleting, the row is simply deleted from the table. In all cases, subscription history is added with status Deleted.
Expected behaviour
----------------------------------------
If we're removing:
- If a contact is currently Added or Pending, it is set to Removed and subscription history is added.
- If a contact is Removed or has no group status, nothing happens.
This is somewhat confusing for smart groups. If a contact is not in a smart group because they don't meet the smart group criteria, do we want to set them to Removed, so they are effectively pre-removed if they later meet the smart group criteria? I think we do want this to happen for mailing groups because this function is used for unsubscribes. We don't want a contact to later become part of a smart group that was used for a mailing that they unsubscribed from, so I think we do want to set status to Removed no matter what.
Counts reported to user should also be correct based on what actually happened.
If we're deleting:
- If a contact is currently Added, Pending or Removed, it is deleted from the table and subscription history is added. For smart groups, this resets the contact to being a smart member of the group or not based on the smart group criteria.
- If a contact has no group status, nothing happens.
Fix
----------------------------------------
If this makes sense, I'll submit a PR.
Confusingly, removeContactsFromGroup is also used to _add_ contacts to a group [here.](https://github.com/civicrm/civicrm-core/blob/843958bc0022cec4145c8796ae49ccb2fd9d3c28/CRM/Contact/Page/View/GroupContact.php#L173) I will change that to use addContactsToGroup for Added or Pending. This will result in a change to the op for the hooks though (from `CRM_Utils_Hook::pre('edit', 'GroupContact'...` to `CRM_Utils_Hook::pre('create', 'GroupContact'...`. [The docs](https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_pre/) say create is correct for a contact being added to a group, so it appears this is not correct as it stands. Definitely would value an expert opinion on this aspect.https://lab.civicrm.org/dev/core/-/issues/3882SearchKit - distinct values should be sorted by id2022-10-25T11:52:13ZvitiusSearchKit - distinct values should be sorted by idWhen we have List of contact name and dont use distinct. On output we get sorted list of names on contact id. And when we want have hyperlinks on contacts name, that works perfectly. But when we use distinct function, on output we get un...When we have List of contact name and dont use distinct. On output we get sorted list of names on contact id. And when we want have hyperlinks on contacts name, that works perfectly. But when we use distinct function, on output we get unsorted list of names. But links on contacts is sorted by contact id. That causes missmatch. First of display name have link to lowest contact id and last of display name have link to highest contact id.
I tried this on version 5.51.1 and 5.55.alpha1. And I tried this on case clients (you need enable multiple case clients) like you can see on images bellow. Also I tried this on event participants, where I use aggregation on event id and display participants names. On both distinct causes bad hyper links.
![image](/uploads/7fd977598194996923ddf3e1a698b261/image.png)
![image](/uploads/ac8b4684a84cc8da39b7179eff4ee749/image.png)https://lab.civicrm.org/dev/core/-/issues/3881Edit fields for invoicing information2022-10-25T11:52:40Zthoni56Edit fields for invoicing informationOverview
----------------------------------------
The form fields for invoicing information (in CiviEvent) seems to be hardcoded. E.g. it lacks company name and email. It does not seem possible to change or amend these fields.
Example u...Overview
----------------------------------------
The form fields for invoicing information (in CiviEvent) seems to be hardcoded. E.g. it lacks company name and email. It does not seem possible to change or amend these fields.
Example use-case
----------------------------------------
1. Create an event and enable web registrations
1. Make invoicing mandatory
2. Make a registration and notice what the only available fields are
Current behaviour
----------------------------------------
Hard coded fields
Proposed behaviour
----------------------------------------
Possiblity to use a profile, or custom form.
Comments
----------------------------------------
There is a StackExchange question around this: https://civicrm.stackexchange.com/questions/42202/how-can-i-add-company-to-billing-pay-later-fields but the proposed "solution" is hard and really not a solution.https://lab.civicrm.org/dev/core/-/issues/3880Include displays when cloning searchkit custom searches2022-10-20T07:15:21ZBradley TaylorInclude displays when cloning searchkit custom searchesOn SearchKit it is possible to select "Clone" to create a copy of a saved search which can save a lot of time.
This does not appear to clone any displays (tables, lists, grids). These displays can also take a lot of time to setup and so...On SearchKit it is possible to select "Clone" to create a copy of a saved search which can save a lot of time.
This does not appear to clone any displays (tables, lists, grids). These displays can also take a lot of time to setup and so I believe the ability to include these in the cloned search would be a great feature.
The use case where I came across this was where a client wanted 3 custom search displays, filtered to all events, events from this calendar year, events from past calendar year. An alternative solution would be to allow individual displays to be filtered differently, but associated with a single searchkit search.https://lab.civicrm.org/dev/core/-/issues/3878SearchKit: Add ability to search and filter by active periods2023-02-27T22:02:08ZfrancescbassasSearchKit: Add ability to search and filter by active periodsOverview
----------------------------------------
Some entities (Relationships, Memberships, Cases, Events, Recurring Contributions) may be defined by a start date and end date that indirectly define a period in which the entity is activ...Overview
----------------------------------------
Some entities (Relationships, Memberships, Cases, Events, Recurring Contributions) may be defined by a start date and end date that indirectly define a period in which the entity is active or not.
This is a proposal to enable the possibility to search for entities active during a specific period via SearchKit and also filter results through related SearchKit Afforms.
Example use-case
----------------------------------------
1. **Relationships:** Search for active volunteers on a specific year
1. **Cases:** Get a pivot report with active cases per week
1. **Events:** Count number of active events on last year
1. **Memberships:** List active members per month
1. **Recurring contributions:** Get a pivot report with the active recurring contributions per month
Current behaviour
----------------------------------------
Currently, search for active relationships it’s only available through Advanced Search and Relationships Report, but it’s not possible to do this search via SearchKit.
![advanced-search](/uploads/dbd57f4abd494fe4225494c7f2faa5ef/advanced-search.png)
![relationship-report](/uploads/1d37472120e4f2cde4b055a0c60b147b/relationship-report.png)
@ayduns, points in [this SE answer](https://civicrm.stackexchange.com/a/41871/104) a way to search for a specific active period.
![searchkit-approximation](/uploads/5d151234bd3093ab422ffd6b057d936c/searchkit-approximation.png)
This it’s good, but not enough. It’s very tricky to build this clause intuitively. And if you create an Afform with this SearchKit you can’t expose start dates and end dates to reproduce this clause.
Proposed behavior
----------------------------------------
Create an “Active period” search field selector available for entities with start and end dates: Relationships, Events, Memberships, Recurring contributions and Cases.
This would allow for example:
1. Click on **Search -> Search Kit**.
1. Search for **Relationships** or **Events**
1. Select **Active Period** in **where** clause
1. Choose options for filter **=**/**is Between** and **Pick Date**/**Date Range**...
Active period selector, like in the image below:
![active-period-field-selector](/uploads/f7bff145d568e35ad01ce87dd0f211f1/active-period-field-selector.png)
Comments
----------------------------------------
Would answer questions like:
[How to search active relationships (e.g) during past year?](https://civicrm.stackexchange.com/q/8315/104)
[Is it possible to get point-in-time membership data?](https://civicrm.stackexchange.com/q/2253/104) [duplicate](How do I determine how many active members there were on a date in the past? [duplicate])
[Create a report or graph of the number of campaigns active in any particular month](https://civicrm.stackexchange.com/q/34465/104)
Will cover the use of this extension [Historic Membership Data](https://github.com/fuzionnz/nz.co.fuzion.historicmembershipdata)https://lab.civicrm.org/dev/core/-/issues/3877APIv4 - GroupContact - Does not set actual time part in subscription history ...2022-10-11T15:26:28ZtschuettlerAPIv4 - GroupContact - Does not set actual time part in subscription history dateOverview
----------------------------------------
The time part in the subscription history date is not set to the actual time when the change was triggered by APIv4 GroupContact. It is working fine, when doing so via UI or APIv3.
Repro...Overview
----------------------------------------
The time part in the subscription history date is not set to the actual time when the change was triggered by APIv4 GroupContact. It is working fine, when doing so via UI or APIv3.
Reproduction steps
----------------------------------------
1. Add your own contact to a group via APIv4 `GroupContact::create` https://dmaster.demo.civicrm.org/civicrm/api4#/explorer/GroupContact/create?values=%5B%5B%22group_id%22,%224%22%5D,%5B%22contact_id%22,%22user_contact_id%22%5D%5D
1. Query Subscription History: https://dmaster.demo.civicrm.org/civicrm/api4#/explorer/SubscriptionHistory/get?where=%5B%5B%22contact_id%22,%22%3D%22,%22user_contact_id%22%5D%5D
1. Date fields only contains correct date, time is set to 00:00:00
**Works with Date and Time**
1. Add your own contact from the group tab on your contact page or add it to the group to via APIv3 `GroupContact.create`
1. Query Subscription History: https://dmaster.demo.civicrm.org/civicrm/api4#/explorer/SubscriptionHistory/get?where=%5B%5B%22contact_id%22,%22%3D%22,%22user_contact_id%22%5D%5D
1. Date fields contains date and time when contact was added to the group
Current behaviour
----------------------------------------
Subscription history date field only contains correct data when adding / removing / deleting to/from a group via APIv4 (GroupContact. Time is set as `00:00:00`.
Expected behaviour
----------------------------------------
Subscription history date field contains correct time and date, regardless of which way the contact was added / removed / deleted to/from a group.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Firefox 102.2.0_
* __CiviCRM:__ _Master / https://dmaster.demo.civicrm.org_
Comments
----------------------------------------
_Anything else you would like the reviewer to note._5.55.1https://lab.civicrm.org/dev/core/-/issues/3876Fix custom data view for case of type Money2022-10-25T15:18:23ZyashodhaFix custom data view for case of type MoneyFix custom data view for case of type MoneyFix custom data view for case of type Money5.55.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3875Pressing return on additional participants page for event registration goes b...2023-06-03T19:57:34ZlarsssandergreenPressing return on additional participants page for event registration goes back to previous page instead of forwardThere are three buttons on the additional participant page: Go Back, Continue, Skip Participant. Since all three are type="submit", when you press the return/enter key, the first button of type="submit" is clicked, so you go back one pag...There are three buttons on the additional participant page: Go Back, Continue, Skip Participant. Since all three are type="submit", when you press the return/enter key, the first button of type="submit" is clicked, so you go back one page. Contrast with the primary participant registration page, where return does take you to the next page because there is only one button or with a contribution page where return takes you to the confirmation page, again because there is only one button.
The easiest fix would be to change the types of the other buttons to "button". The button type [is set here](https://github.com/civicrm/civicrm-core/blob/c94963f7637912571ce62b33de60f7d5ce640f69/CRM/Core/Form.php#L758) for all buttons as "submit" unless type="reset" is passed to addButtons. So I propose to review button types in use, setting those that make sense as "submit" (next, done, submit, upload, process, etc) and others as "button" (cancel, refresh). Any buttons without a type will be left as "submit" so as to avoid breaking anything.
There is also a class default added to buttons that have isDefault, but it's unclear to me what this does.https://lab.civicrm.org/dev/core/-/issues/3874APIv4 Relationships refused if duplicated2022-11-26T20:59:14ZshaneonabikeAPIv4 Relationships refused if duplicated**Backlog**
I see that @samuelsov already reported this, but the bot closed the issue #451.
**Disabled Relationships**
I came across a scenario where if a Contact Relationship was disabled, and you attempt to create a new one (that ma...**Backlog**
I see that @samuelsov already reported this, but the bot closed the issue #451.
**Disabled Relationships**
I came across a scenario where if a Contact Relationship was disabled, and you attempt to create a new one (that matches dates) it is refused. Ironically, the UI let's me add the Relationship.
+ Create a Relationship with a start / end date
+ Disable relationship
+ Create a new Relationship with the same start / end date via UI (works)
+ Create a new Relationship with the same start / end date via APIv4 (fails with Duplicate Exception)
**Cases**
Today, I came across another scenario where we are using ActivityProfile with CiviRules. The gist is that when someone submits a CiviCase then CiviRules assigned the Case Coordinator to their case. It's the same person each time.
In this scenario, the APIv4 is also refused the submission because of the duplicated Relationship. But really I think it makes sense to have multiple cases open for one person with the same case coordinator managing them all right?
My scenario can be replicated without ActivityProfile
+ Create a Case for test user A and Coordinator X
+ Create a new Case for Test User A
+ Use the APiv4 to setup a relationship to Coordinator X
It should throw an exception Duplicate Relationship on relationship.create.
Thoughts?https://lab.civicrm.org/dev/core/-/issues/3873Error from CRM_Event_ICalendar->gCalRedirect "Expected one Event, found 0" fo...2022-10-04T17:31:07ZdavidError from CRM_Event_ICalendar->gCalRedirect "Expected one Event, found 0" for past eventsOverview
----------------------------------------
Since Updateing to 5.52 I have a lot of error messages form CRM_Event_ICalendar->gCalRedirect
Reproduction steps
----------------------------------------
1. open a event in fron view whi...Overview
----------------------------------------
Since Updateing to 5.52 I have a lot of error messages form CRM_Event_ICalendar->gCalRedirect
Reproduction steps
----------------------------------------
1. open a event in fron view whiche is in the past e.g. https://dmaster.demo.civicrm.org/civicrm/event/info?id=2&reset=1
2. click on "Add event to Google Calendar" e.g. https://dmaster.demo.civicrm.org/civicrm/event/ical?gCalendar=1&reset=1&id=2
3. Error: "Expected one Event, found 0"Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
Expected one Event, found 0"
Expected behaviour
----------------------------------------
No Error
Environment information
----------------------------------------
Civicrm 5.52 and dmaster.demo.civicrm.org "5.55.alpha1"
Comments
----------------------------------------
https://github.com/civicrm/civicrm-core/blob/c6ea0fd94e7a3be5af08fd1ced1135a5084856bb/CRM/Event/ICalendar.php#L47
only returns events in the future if no start and end date is provided
Possible solution:
https://github.com/civicrm/civicrm-core/blob/c6ea0fd94e7a3be5af08fd1ced1135a5084856bb/CRM/Event/ICalendar.php#L49
add && count($info) > 1
https://github.com/civicrm/civicrm-core/blob/c6ea0fd94e7a3be5af08fd1ced1135a5084856bb/CRM/Event/ICalendar.php#L104
or just return instead of thrown an errorhttps://lab.civicrm.org/dev/core/-/issues/3872Search on pledge payments on Find contributions screen2022-09-26T20:24:23ZyashodhaSearch on pledge payments on Find contributions screenIn _Find contributions_, if _CiviPledge_ is enabled, add search on pledge payments.
![se](/uploads/37de92cf4ea25288db09be94e60df203/se.png)
We do have bunch of options for search on contributions that are recurring or not, pay later o...In _Find contributions_, if _CiviPledge_ is enabled, add search on pledge payments.
![se](/uploads/37de92cf4ea25288db09be94e60df203/se.png)
We do have bunch of options for search on contributions that are recurring or not, pay later or not, would be helpful to check if the contribution is a pledge payment or not.
And based on the components enabled, we can have for event/membership as well.yashodhayashodha