Development issueshttps://lab.civicrm.org/groups/dev/-/issues2022-10-03T02:44:25Zhttps://lab.civicrm.org/dev/core/-/issues/3713AbstractTokenSubscriber and custom token processors stopped being called?2022-10-03T02:44:25ZAdam WoodAbstractTokenSubscriber and custom token processors stopped being called?I have been tearing my hair out over this for over a week now...
Sometime between 24 November 2021 and 11 May 2022 (these are the last 'good' and first 'bad' scheduled reminders on file), the token processor (implemented as an `Abstract...I have been tearing my hair out over this for over a week now...
Sometime between 24 November 2021 and 11 May 2022 (these are the last 'good' and first 'bad' scheduled reminders on file), the token processor (implemented as an `AbstractTokenSubscriber`) in our custom CiviCRM extension stopped working, in that the tokens were no longer processed and simply omitted from the resulting emails. I suspect this happened when we upgraded to 5.47.3 on 3 April 2022. The custom token processor code did not change in the meantime.
It seems that the token subscriber methods are simply no longer called from the Symfony system at all. With judicious use of `error_log()` and `debug_backtrace()`, I can see that the `getSubscribedEvents()` method of the token processor object is called when CiviCRM is invoked, but thereafter the event dispatcher never calls any of the methods in the token processor:
- The `registerTokens()` and `evaluateTokens()` methods of the token processor are never called.
- The dispatcher never fires the `civi.token.list` or `civi.token.eval` events for the subscribed processor (although I can see these events being dispatched to other token processors in core).
In fact the extension has three token processor objects, all affected in the same way.
The token processors are set up in the extension config routine as follows:
```php
function civicses_civicrm_config(&$config) {
_civicses_civix_civicrm_config($config);
if (isset(Civi::$statics[__FUNCTION__])) { return; }
Civi::$statics[__FUNCTION__] = 1;
Civi::dispatcher()->addSubscriber(new CRM_Civicses_TokensSite());
Civi::dispatcher()->addSubscriber(new CRM_Civicses_TokensEvent());
Civi::dispatcher()->addSubscriber(new CRM_Civicses_TokensParticipant());
}
```
I tried resetting the cache and deleting the cached container multiple times, all to no avail. I also tried disabling and re-enabling the extension.
To make sure I wasn't going mad, I even tried re-implementing some of the simple tokens using `..._civicrm_container()`, `..._register_tokens()` and `..._evaluate_tokens()` as described in https://docs.civicrm.org/dev/en/latest/framework/token/#defining-tokens but the same issue occurred: the methods were never called. Even after purging the cached container.
Aware that various parts of CiviCRM are (or were) still in flux with regards to token processor migration, I tried generating both a mass mailing and a scheduled reminder. Neither worked.
An upgrade to 5.50.4 has not fixed the issue. I think I am going mad after all! I have read and re-read the documentation several times now and can't see what I'm doing wrong (and in any case it worked before), so I suspect this is a genuine issue.
Any and all help gratefully received.
<details><summary>Code from the token processor that worked until earlier this year, if anyone is interested. It provides Joomla routed frontend URLs to the event pages (note deprecated hook included for earlier CiviCRM version).</summary>
```php
class CRM_Civicses_TokensEvent extends \Civi\Token\AbstractTokenSubscriber
{
/* Public methods */
/**
* Class constructor.
*/
public function __construct()
{
parent::__construct('event', self::getTokens());
}
/**
* @inheritDoc
*/
public function checkActive(\Civi\Token\TokenProcessor $processor)
{
// Copied from CRM_Event_Tokens
return !empty($processor->context['actionMapping'])
&& $processor->context['actionMapping']->getEntity() === 'civicrm_participant';
}
/**
* @inheritDoc
*/
public function evaluateToken(\Civi\Token\TokenRow $row, $entity, $field, $prefetch = NULL)
{
$info = ($field == 'info_url_frontend');
$registration = ($field == 'registration_url_frontend');
if ($info || $registration)
{
$actionSearchResult = $row->context['actionSearchResult'];
$path = ($registration ? 'civicrm/event/register' : 'civicrm/event/info');
// Default URL using original logic in CRM_Event_Tokens (but with $frontend set to TRUE)
$event = [
'event_id' => $actionSearchResult->event_id,
'url' => \CRM_Utils_System::url($path, 'reset=1&id='.$actionSearchResult->event_id, TRUE, NULL, TRUE),
];
// Use same URL logic as for upcoming event emails, if possible
CRM_Civicses_Events::fixEventURL($event, 0, $registration);
$row->tokens($entity, $field, $event['url']);
}
}
/* CiviCRM hook implementations */
/**
* Implements hook_civicrm_tokens().
*
* @link https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_tokens
*
* NEEDED TO ENSURE LISTING IN ADMINISTRATOR FORMS (uses method ref'd below not registerTokens event).
* @see CRM_Core_SelectValues::eventTokens()
*/
static public function civicrm_tokens(&$tokens)
{
foreach (self::getTokens() as $key => $value)
{
$tokens['event']['event.'.$key] = $value;
}
}
/* Private methods */
/**
* Get token names.
* @return array
*/
static private function getTokens() : array
{
return [
'info_url_frontend' => ts('Event Info URL (front-end)'),
'registration_url_frontend' => ts('Event Registration URL (front-end)'),
];
}
}
```
</details>https://lab.civicrm.org/dev/core/-/issues/730Reports does not filter counties appropriately2022-10-02T05:03:34ZandyburnsReports does not filter counties appropriatelyWithin a report, if I select a state and then want to filter down to the county, I see all the counties in the US with the same name, e.g. Adams.![all_counties_showing](/uploads/317a70eec6edd6c5ddcc90601734b520/all_counties_showing.PNG)
...Within a report, if I select a state and then want to filter down to the county, I see all the counties in the US with the same name, e.g. Adams.![all_counties_showing](/uploads/317a70eec6edd6c5ddcc90601734b520/all_counties_showing.PNG)
In this case I used the *CRM_Report_Form_Contact_Summary* report template.
It should use the same method if used in a profile where if a certain state is selected it only allows those counties tied to that state.https://lab.civicrm.org/dev/core/-/issues/728New Individual: HTML codes are displayed in edit mode instead of < and > char...2022-10-02T05:03:34ZPradeep Nayakpradpnayak@gmail.comNew Individual: HTML codes are displayed in edit mode instead of < and > characters* Navigate to Contacts→New Individual
* Fill in the Job title field with <>
* Click "Save"
* On the preview page, click Edit to edit the Job title field
* Take a look at the field
Result: HTML codes are displayed in edit mode instead o...* Navigate to Contacts→New Individual
* Fill in the Job title field with <>
* Click "Save"
* On the preview page, click Edit to edit the Job title field
* Take a look at the field
Result: HTML codes are displayed in edit mode instead of < and > characters. Please take a look at the attachment
Expected result: special characters should be displayed as enteredhttps://lab.civicrm.org/dev/core/-/issues/2535Improve scheduled reminder UI for selection of event specific date or time be...2022-10-01T14:07:07ZlarsssandergreenImprove scheduled reminder UI for selection of event specific date or time before eventTo set a scheduled reminder for an event, you can either set it to a specific date or n hours, days, etc before the event. However, the UI to set these two options is confusing. If you set a date and n hours before, the n hours before is...To set a scheduled reminder for an event, you can either set it to a specific date or n hours, days, etc before the event. However, the UI to set these two options is confusing. If you set a date and n hours before, the n hours before is ignored. The user must click the X beside the date to remove it in order to make the second option work, which is non-standard and confusing (I had a staff member save a reminder multiple times who couldn't figure out why the n hours before option was disappearing).
![image](/uploads/860d004144b394d04c3d68bd92287ef6/image.png)
To make this clearer to users, I suggest adding radio buttons in front of the two options and only using the selected option.5.55.0https://lab.civicrm.org/dev/core/-/issues/3840Upgrading the database from 5.52.3 to 5.53.0 generates "The wrong dispatch po...2022-10-01T13:51:21ZJonGoldUpgrading the database from 5.52.3 to 5.53.0 generates "The wrong dispatch policy is active".See Mattermost at https://chat.civicrm.org/civicrm/pl/je8a8jqhfby8ibw99ie1k9wywr.
We're still tracking down the cause, but here is a verbose log.
```
Box Requirements Checker
========================
> Using PHP 7.4.30
> PHP is using t...See Mattermost at https://chat.civicrm.org/civicrm/pl/je8a8jqhfby8ibw99ie1k9wywr.
We're still tracking down the cause, but here is a verbose log.
```
Box Requirements Checker
========================
> Using PHP 7.4.30
> PHP is using the following php.ini file:
/etc/php/7.4/cli/php.ini
> Checking Box requirements:
.....
[OK] Your system is ready to run the application.
Found CiviCRM database version 5.52.3.
Found CiviCRM code version 5.53.0.
Checking pre-upgrade messages...
The default copies of the message templates listed below will be updated to
handle new features or correct a problem. Your installation has customized
versions of these message templates, and you will need to apply the updates
manually after running this upgrade. Click here [1] for detailed
instructions.
* _Contributions - Receipt (off-line)_ - Update to new smarty variables
for line items, tax
Links:
------
[1] https://docs.civicrm.org/user/en/latest/email/message-templates/#modifying-system-workflow-message-templates
Press ENTER to continue
Dropping SQL triggers...
Preparing upgrade...
Executing upgrade...
Cleanup old files (CRM_Upgrade_Form::doFileCleanup(/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Cleanup old upgrade snapshots (CRM_Upgrade_Snapshot::cleanupTask(civicrm))
Checking extensions (CRM_Upgrade_Form::disableOldExtensions(/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Begin Upgrade to 5.53.alpha1 (CRM_Upgrade_Form::doIncrementalUpgradeStart(5.53.alpha1))
Upgrade DB to 5.53.alpha1 (CRM_Upgrade_Form::doIncrementalUpgradeStep(5.53.alpha1,5.52.3,5.53.0,/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Upgrade DB to 5.53.alpha1: SQL (CRM_Upgrade_Incremental_php_FiveFiftyThree::runSql(5.53.alpha1))
Replace %A specifier in date settings. (CRM_Upgrade_Incremental_php_FiveFiftyThree::replacePercentA())
Add invoice pdf format (CRM_Upgrade_Incremental_php_FiveFiftyThree::addInvoicePDFFormat())
Add Recent Items Providers (CRM_Upgrade_Incremental_php_FiveFiftyThree::addRecentItemsProviders())
Finish Upgrade DB to 5.53.alpha1 (CRM_Upgrade_Form::doIncrementalUpgradeFinish(5.53.alpha1,5.52.3,5.53.0,/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Begin Upgrade to 5.53.beta1 (CRM_Upgrade_Form::doIncrementalUpgradeStart(5.53.beta1))
Upgrade DB to 5.53.beta1 (CRM_Upgrade_Form::doIncrementalUpgradeStep(5.53.beta1,5.52.3,5.53.0,/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Upgrade DB to 5.53.beta1: SQL (CRM_Upgrade_Incremental_php_FiveFiftyThree::runSql(5.53.beta1))
Finish Upgrade DB to 5.53.beta1 (CRM_Upgrade_Form::doIncrementalUpgradeFinish(5.53.beta1,5.52.3,5.53.0,/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Finish Upgrade DB to 5.53.0 (CRM_Upgrade_Form::doIncrementalUpgradeFinish(5.53.beta1,5.53.0,5.53.0,/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Finish core DB updates 5.53.0 (CRM_Upgrade_Form::doCoreFinish(5.53.beta1,5.53.0,5.53.0,/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Assess extension upgrades (CRM_Upgrade_Form::enqueueExtUpgrades(5.53.beta1,5.53.0,5.53.0,/home/jon/.cv/upgrade/57a5be292438b5304f5ec9865e0f0d29.dat))
Error executing task: %s
[RuntimeException]
Task can not execute correctly. The wrong dispatch policy is active. Expected to find "upgrade.finish".
Exception trace:
() at /var/www/mysite.megaphonetech.com/htdocs/sites/all/modules/civicrm/CRM/Upgrade/DispatchPolicy.php:164
CRM_Upgrade_DispatchPolicy::assertActive() at /var/www/mysite.megaphonetech.com/htdocs/sites/all/modules/civicrm/CRM/Upgrade/Form.php:856
CRM_Upgrade_Form::enqueueExtUpgrades() at /var/www/mysite.megaphonetech.com/htdocs/sites/all/modules/civicrm/CRM/Queue/Task.php:101
CRM_Queue_Task->run() at phar:///usr/local/bin/cv/vendor/composer/../../src/Util/ConsoleQueueRunner.php:78
Civi\Cv\Util\ConsoleQueueRunner->runAll() at phar:///usr/local/bin/cv/src/Command/UpgradeDbCommand.php:133
Civi\Cv\Command\UpgradeDbCommand->execute() at phar:///usr/local/bin/cv/vendor/symfony/console/Command/Command.php:257
Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/cv/vendor/symfony/console/Application.php:850
Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/cv/vendor/symfony/console/Application.php:193
Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/cv/src/Application.php:46
Civi\Cv\Application->doRun() at phar:///usr/local/bin/cv/vendor/symfony/console/Application.php:124
Symfony\Component\Console\Application->run() at phar:///usr/local/bin/cv/src/Application.php:15
Civi\Cv\Application::main() at phar:///usr/local/bin/cv/bin/cv:27
require() at /usr/local/bin/cv:14
upgrade:db [--out OUT] [--dry-run] [--retry] [--skip] [--level LEVEL] [-t|--test] [-U|--user USER]
```https://lab.civicrm.org/dev/core/-/issues/657Add filter for country on Repeat Contributions Report2022-10-01T08:45:39ZfrancescbassasAdd filter for country on Repeat Contributions ReportAdd the hability to filter by country on the Repeat Contributions Report.Add the hability to filter by country on the Repeat Contributions Report.https://lab.civicrm.org/dev/core/-/issues/722Display attachments in Activities tab2022-10-01T05:03:35ZDon WijesooriyaDisplay attachments in Activities tabAttachments in case activities are displayed as paper-clip icon links on the case view screen.
![case_view](/uploads/d9e655c25b0d7b2001380d714720f7fe/case_view.png)
It would be better if attachments are displayed in the activities tab ...Attachments in case activities are displayed as paper-clip icon links on the case view screen.
![case_view](/uploads/d9e655c25b0d7b2001380d714720f7fe/case_view.png)
It would be better if attachments are displayed in the activities tab for all other activities as well.https://lab.civicrm.org/dev/core/-/issues/3857Only public custom groups should be shown in offline contribution receipts2022-10-01T01:07:07ZyashodhaOnly public custom groups should be shown in offline contribution receiptsIf a custom group is public, by definition it says : Check this box if you want this custom group to be displayed on public forms e.g. Event Information page. Only public custom groups will be included in event receipts.
But when you ha...If a custom group is public, by definition it says : Check this box if you want this custom group to be displayed on public forms e.g. Event Information page. Only public custom groups will be included in event receipts.
But when you have non public custom groups on contributions they show up in the offline receipts.5.55.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3402Hide explanatory text about multiple participants unless 2 or more participan...2022-09-30T23:21:23ZlarsssandergreenHide explanatory text about multiple participants unless 2 or more participants selectedOn event registration pages, when multiple participants is enabled, there is a lengthy bit of explanatory text shown:
"Fill in your registration information on this page. If you are registering additional people, you will be able to ente...On event registration pages, when multiple participants is enabled, there is a lengthy bit of explanatory text shown:
"Fill in your registration information on this page. If you are registering additional people, you will be able to enter their registration information after you complete this page and click "Continue"."
It would be better to hide this text until the user selects a number of participants greater than one. I'll submit a patch if this change is supported.https://lab.civicrm.org/dev/core/-/issues/3884ical files missing "VTIMEZONE" component2022-09-30T17:20:12ZAndrew Wassonical files missing "VTIMEZONE" componentOverview
----------------------------------------
CiviEvent ical files are generated without the "VTIMEZONE" component which means in some time zones the event date and time will be incorrect with some calendar clients.
Specifically I ...Overview
----------------------------------------
CiviEvent ical files are generated without the "VTIMEZONE" component which means in some time zones the event date and time will be incorrect with some calendar clients.
Specifically I have two Drupal/CiviCRM websites in Alberta that use America/Edmonton as their timezone settings. Several CiviEvents towards the end of September and the month of October generate iCal files that are off by an hour for Microsoft Outlook Calendars set for the Alberta Canada time zone. Apple Calendars and Google Calendars set for Alberta time render the iCal files correctly. If we add markup for "VTIMEZONE" in the iCal file, they work correctly for Microsoft Outlook Calendars set for the Alberta Canada time zone.
```
I've added the following static markup to the iCal files to get them to behave correctly in Microsoft Outlook Calendar set to the Alberta Time Zone.
BEGIN:VTIMEZONE
TZID:America/Edmonton
LAST-MODIFIED:20220816T024022Z
TZURL:https://static.tzurl.org/zoneinfo-outlook/America/Edmonton.ics
X-LIC-LOCATION:America/Edmonton
BEGIN:DAYLIGHT
TZNAME:MDT
TZOFFSETFROM:-0700
TZOFFSETTO:-0600
DTSTART:19700308T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:MST
TZOFFSETFROM:-0600
TZOFFSETTO:-0700
DTSTART:19701101T020000
RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
END:STANDARD
END:VTIMEZONE
```
The "VTIMEZONE" component is described here: https://icalendar.org/iCalendar-RFC-5545/3-6-5-time-zone-component.html
Suggested Fix
----------------------------------------
In order to fix this issue, I suggest VTIMEZONE markup is added to the file at: /civicrm/templates/CRM/Core/Calendar/ICal.tpl
It will require some dynamic code to pull the TZURL: from a lookup table and for the DTSTART/END for DAYLIGHT and STANDARD if the timezone uses DST. It may be that the values can be scraped from the TZURL file.
Cheers,
Andrewhttps://lab.civicrm.org/dev/core/-/issues/717Mailstore enforces 0700 permissions on created directories - should be config...2022-09-30T05:03:44ZRichMailstore enforces 0700 permissions on created directories - should be configurable.Title says it all, I think! I've been patching this file on my installs for ages and have finally got around to making a core patch (coming as soon as I figure out how to do it.)Title says it all, I think! I've been patching this file on my installs for ages and have finally got around to making a core patch (coming as soon as I figure out how to do it.)https://lab.civicrm.org/dev/core/-/issues/3706RC regression: Valid URLs failing URL validation2022-09-29T14:42:49ZJonGoldRC regression: Valid URLs failing URL validation### Steps to replicate
* Have `php-intl` installed.
* On the master branch, try adding this website to a contact:
```
https://mysite.org/index.php/apps/files/?dir=/Talk/Test%20Folder1/Test%20Folder%202&fileid=597195
```
On 5.50, this sa...### Steps to replicate
* Have `php-intl` installed.
* On the master branch, try adding this website to a contact:
```
https://mysite.org/index.php/apps/files/?dir=/Talk/Test%20Folder1/Test%20Folder%202&fileid=597195
```
On 5.50, this saves correctly, on master branch it fails validation.
In [PR 23755](https://github.com/civicrm/civicrm-core/pull/23755) URL validation uses `idn_to_ascii` ([CRM_Utils_Rule line 224](https://github.com/eileenmcnaughton/civicrm-core/blob/8b3f43f48bdc91c7ed07237f2d8ef1033ffe24b2/CRM/Utils/Rule.php#L224)).JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/3052Homepage field does not accept non-ascii2022-09-29T14:42:48Zthoni56Homepage field does not accept non-asciiOverview
----------------------------------------
The Contact field "Homepage" does not accept anything other than ASCII.
Reproduction steps
----------------------------------------
1. Click on **Contacts -> New Individual**.
1. Entered...Overview
----------------------------------------
The Contact field "Homepage" does not accept anything other than ASCII.
Reproduction steps
----------------------------------------
1. Click on **Contacts -> New Individual**.
1. Entered the following URL in Homepage field: "https://www.linkedin.com/in/marcus-junström-8ba54626/".
Current behaviour
----------------------------------------
Got an error "Enter a valid web address beginning with 'http://' or 'https://'.", which is wrong, but also prevents using modern URLs which allows UTF8 or other encoding, such as LinkedIN pages.
Expected behaviour
----------------------------------------
It should be possible to enter modern, encoded, URL:s.
Environment information
----------------------------------------
* __Browser:__ _Safari 15.3_
* __CiviCRM:__ _5.45.1_
* __CMS:__ _Joomla 3.10_5.51.0https://lab.civicrm.org/dev/core/-/issues/694Problem with (embedded ?) Smart Groups and Search Criteria Modification and U...2022-09-29T05:03:22ZJMMProblem with (embedded ?) Smart Groups and Search Criteria Modification and UpdateThere are several questions on the stack-exchange which regard Smart Group updating (e.g. : https://civicrm.stackexchange.com/questions/12809/smart-groups-cannot-get-smart-groups-to-refresh/28334#28334) : I could reproduce one such issue...There are several questions on the stack-exchange which regard Smart Group updating (e.g. : https://civicrm.stackexchange.com/questions/12809/smart-groups-cannot-get-smart-groups-to-refresh/28334#28334) : I could reproduce one such issue on the Demo site (but I draw attention to the fact that it can be erratic) :
* Create a group : test (empty)
* Advance search Individuals whose name contains "Adam" > You get 12 instances > Create smart group G1 under test
* Advance search Individuals whose name contains "ck" > You get 8 instances > Create smart group G2 under test
* Advance search Individuals whose name contains "y" > You get 52 instances > Create smart group G3 under test
* Advance search Groups G1, G2, G3 > You get 70 (you could expect 72, but there are some common rsults) > Create smart group "Total" under test
Now :
* open G1 and modify search criteria : "Ad" instead of "Adam" > you get 18 instances (instead of 12), thus 6 more > Update the smart group
* Open group "Total" > you get 77 instead of 70, thus 7 more : **why 7 and not 6** ?
Now again :
* open G1 again and modify search criteria : "d" instead of "Ad" > You get 71 instances (instead of 18, thus a lot more) > Update the smart Group
* Open group "Total" > **you still get 77 (while it should contain much more than that)**
* Open "test" > **you get 104 while there is no reason why it should be different from "Total" result**https://lab.civicrm.org/dev/core/-/issues/697Reconcile delegated queries for DAO and DynamicFKAuthorization2022-09-29T05:03:22ZtottenReconcile delegated queries for DAO and DynamicFKAuthorizationThere are two facilities which are generally designed to check permissions on related entities:
* In the API layer, `DynamicFKAuthorization`
* In the DAO layer, `getSelectWhereClause()` / `addSelectWhereClause()`
These originate in som...There are two facilities which are generally designed to check permissions on related entities:
* In the API layer, `DynamicFKAuthorization`
* In the DAO layer, `getSelectWhereClause()` / `addSelectWhereClause()`
These originate in somewhat different use-cases, but they generally both need to (a) look at some arbitrary table/entity reference and (b) filter to determine access. There are also some differences (e.g. single-record vs multi-record/batched; read-permission vs write-permission).https://lab.civicrm.org/dev/core/-/issues/674Register multiple participants not applied2022-09-28T05:03:36ZyalhRegister multiple participants not appliedWhen the Register multiple participants checkbox is not checked,
![Capture1](/uploads/acb6c958383f68c53a9f9bf01cf0af00/Capture1.PNG)
After registering myself, I'm able to register someone else => whereas this should not be the case
![C...When the Register multiple participants checkbox is not checked,
![Capture1](/uploads/acb6c958383f68c53a9f9bf01cf0af00/Capture1.PNG)
After registering myself, I'm able to register someone else => whereas this should not be the case
![Capture2](/uploads/132a65a583e5403955ce6a0c880d8f0d/Capture2.PNG)
Issue tested on 5.11.alpha1 / 5.9.1 / 5.9.0
Seems to be there since 5.9.0. In previous version in that configuration, user was only able to register himself, once.https://lab.civicrm.org/dev/core/-/issues/669Custom Field is_required and is_view set to NULL instead of 0 if checkboxes n...2022-09-28T05:03:35ZjackrabbithannaCustom Field is_required and is_view set to NULL instead of 0 if checkboxes not checked on edit formMay need two separate issues created for this, depends on if we think these are bugs or new expected behavior.
Noticed doing a 'get' API call, CustomField entity, that the is_required and is_view properties are no longer present in API ...May need two separate issues created for this, depends on if we think these are bugs or new expected behavior.
Noticed doing a 'get' API call, CustomField entity, that the is_required and is_view properties are no longer present in API results if they are not checked via the standard custom field edit form.
replicable on dmaster.demo.civicrm.org
Create a custom field, and use the API explorer to look at it's properties
```
$result = civicrm_api3('CustomField', 'get', [
'sequential' => 1,
'id' => 13,
]);
```
I made a field on dmaster.demo, with id 13
Immediately after field creation, is_required showed 0
Went back and edited the custom field and saved, is_required is not present in the values at all
In the past is_required and is_view properties were present in the results, but had a value of 0.
2 things about this.
1) The value stored in the database is now NULL and not 0, I think this is a bug, but IDK. Especially after the field has been edited, the user made a decision that the field is not required, so the data in the database should represent that decision. NULL to me represents no decision.
2) If a value is NULL is the API not including the property in the results? This is inconsistent with the 'getfields' call for an entity...the properties returned for a 'get' api action by the 'getfields' request, should match, that is even if the value is NULL, then the API should return 'is_required' => NULL .
Code down the line may depend on this property being set...like CiviCRM Entity or other API consumers...In the case of CiviCRM Entity, we specifically set up Drupal entity type metadata based on the 'getfields' call and it is expecting the properties to be there when a 'get' call is made...
for 1) this must be a problem with form post process, to be saving the value as NULL and not 0. Do people see this as a bug, are we setting the is_required and is_view columns to NULL instead of 0 on purpose?
2) Do people agree that the expected behavior should be as I describe for the API?https://lab.civicrm.org/dev/core/-/issues/3839Add system check for updated clean URL settings2022-09-27T19:51:34ZelilisseckAdd system check for updated clean URL settingsOverview
----------------------------------------
Based on my experience and this conversation: https://chat.civicrm.org/civicrm/pl/56au14c7dpb5ddebj69kbfjdir
Clean URLs should be required at this point. It's not as much of a problem in...Overview
----------------------------------------
Based on my experience and this conversation: https://chat.civicrm.org/civicrm/pl/56au14c7dpb5ddebj69kbfjdir
Clean URLs should be required at this point. It's not as much of a problem in Drupal, but in Wordpress if a site has been upgraded from the old Clean URL settings in civicrm.settings.php and ?civiwp style URLs and civicrm.settings.php has not been updated manually, strange things will being to occur. This largely manifests itself as yellow "Cannot find valid value for ID" error screens that confuse users when registering for an Event or making a Contribution on user-facing forms. This message comes from a tricky session issue and setting clean URLs up has always been the fix.
Current behaviour
----------------------------------------
Clean URL settings are often not updated by unsuspecting admins as older sites are upgraded to versions of CiviCRM where they should be required.
Proposed behaviour
----------------------------------------
System check warning appears for Wordpress users if civicrm.settings.php does not include up-to-date clean URL settings.
Comments
----------------------------------------
This check could be extended to other CMS' now or in the future, which is the motivation behind using its own check class rather than modifying the existing "Cms" for Wordpress checks. I haven't seen this issue with other CMS' so far.
Any thoughts welcome! PR will be provided and linked.https://lab.civicrm.org/dev/core/-/issues/3870Price set pre and post help display is inconsistent2022-09-27T15:07:07ZlarsssandergreenPrice set pre and post help display is inconsistentPrice set display can get a little wonky. One issue is that for checkboxes and radios, pre and post help for price options is displayed when Display amounts? is checked, but is not displayed when it is not checked. These are the same pri...Price set display can get a little wonky. One issue is that for checkboxes and radios, pre and post help for price options is displayed when Display amounts? is checked, but is not displayed when it is not checked. These are the same price fields, the only difference is Display amounts has been unchecked:
![image](/uploads/37ade20a98ecded410890b394a6fcb18/image.png)
![image](/uploads/7c74ddb8c9221921c0834a0eaf4a0dc6/image.png)
Similarly, pre and post help are never displayed for select options.
I propose to fix these so pre and post help are always displayed when present. This might make for a long select element, but if the fields are going to exist, they should work. Alternately, we could remove pre and post help for select options, but it seems better to keep the fields on all the price option types consistent.5.55.0https://lab.civicrm.org/dev/core/-/issues/682Add basic contact filters to Summary Contributions Report2022-09-27T09:41:13ZfrancescbassasAdd basic contact filters to Summary Contributions ReportContributions of deleted contacts are shown on Summary Contributions Report. Adding basic contact filters to the Summary Contributions Report will prevent these "deleted" contributions from being included. In addition it will enable new ...Contributions of deleted contacts are shown on Summary Contributions Report. Adding basic contact filters to the Summary Contributions Report will prevent these "deleted" contributions from being included. In addition it will enable new possibilities when applying contact filters to the report.
It can be considered a continuation of the work begun in https://issues.civicrm.org/jira/browse/CRM-20545