Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-02-16T13:30:23Zhttps://lab.civicrm.org/dev/core/-/issues/2394Decimal Separator - Incorrect format in some views and editions2023-02-16T13:30:23ZCésarDecimal Separator - Incorrect format in some views and editionsHello,
The Money type fields are not working correctly when modifying the language, the decimal delimiter and the thousands separator are configured, detected with custom case fields and editing a contribution.
* Example custom field i...Hello,
The Money type fields are not working correctly when modifying the language, the decimal delimiter and the thousands separator are configured, detected with custom case fields and editing a contribution.
* Example custom field in case view: (version afected > 5.21.0)
![bug_separator](/uploads/3a6495402f7318f656bf94c73912cda2/bug_separator.gif)
* Example fields in contribution edit: (version afected 5.36.alpha1)
In v5.34.0 the value of total_amount is replaced by the default format value (Ex: 1.000,10 to 1,000.10) in edit form of contribution.
![bug_separator_contrib](/uploads/eb1a291ab6f1311a1e72fa19f0dba5a0/bug_separator_contrib.gif)5.35.0https://lab.civicrm.org/dev/core/-/issues/3575regression (unreleased I think)2022-06-11T14:54:36Zeileenregression (unreleased I think)Sites with CiviMember disabled cannot create relations
Issue is getContactMembershipCount now checks permissions but on sites with civimember disabled the required permissions will not be held
This regressed due to recent changes in th...Sites with CiviMember disabled cannot create relations
Issue is getContactMembershipCount now checks permissions but on sites with civimember disabled the required permissions will not be held
This regressed due to recent changes in this function but I think the fix is not to call it when civimember is disabled5.35.0https://lab.civicrm.org/dev/core/-/issues/2423Some Multi-Select Custom Fields cannot be saved2021-08-18T13:57:49ZhaystackSome Multi-Select Custom Fields cannot be savedOverview
----------------------------------------
The following Custom Field types cannot be saved in the CiviCRM UI nor via API v3:
* Integer Drop-down Multi-Select
* Number Drop-down Multi-Select
* Money Drop-down Multi-Select
They r...Overview
----------------------------------------
The following Custom Field types cannot be saved in the CiviCRM UI nor via API v3:
* Integer Drop-down Multi-Select
* Number Drop-down Multi-Select
* Money Drop-down Multi-Select
They result in the following errors respectively:
* `One of parameters (value: *2*4*) is not of the type Timestamp`
* `One of parameters (value: *2*4*) is not of the type Float`
* `One of parameters (value: *2.99*3.99*1.99*) is not of the type Money`
(Where the * characters above are actually `CRM_Core_DAO::VALUE_SEPARATOR`)
As per [this discussion on MatterMost](https://chat.civicrm.org/civicrm/pl/6ku8g6rs3bnxtk8wtrydtrahhy).
Reproduction steps
----------------------------------------
1. Create a Custom Field of type `Integer`, `Number` or `Money`
1. Select the "Multi-Select" checkbox
1. Add some values for the Select
Values cannot be saved in the CiviCRM UI nor via API v3, e.g.
```php
$result = civicrm_api3('Contact', 'create', [
'id' => 210,
'contact_type' => "Individual",
'custom_20' => [2, 4],
]);
```
Current behaviour
----------------------------------------
Error messages as above.
Expected behaviour
----------------------------------------
The items in the "serialised array" should be checked for their respective types rather than testing the "serialised array" itself and, if valid, should be saved.
Environment information
----------------------------------------
Found in CiviCRM 5.34.0 but almost certainly present since 5.27 and likely a result of [this PR](https://github.com/civicrm/civicrm-core/pull/16992) which introduced the "Multi-Select" checkbox for all Custom Fields of type "Select". Prior to 5.27 `Integer`, `Number` and `Money` did not have a "Multi-Select" option.5.35.0https://lab.civicrm.org/dev/core/-/issues/927Cancel first contribution associated to membership, cancels the membership2021-04-09T18:47:41Zsluc23Cancel first contribution associated to membership, cancels the membershipFollowing this old topic:
https://civicrm.stackexchange.com/questions/2482/membership-sets-to-cancelled-when-contribution-fails-why
https://issues.civicrm.org/jira/browse/CRM-18177
current CiviCRM behavior is when a Contribution a...Following this old topic:
https://civicrm.stackexchange.com/questions/2482/membership-sets-to-cancelled-when-contribution-fails-why
https://issues.civicrm.org/jira/browse/CRM-18177
current CiviCRM behavior is when a Contribution associated with a membership is Cancelled, if this membership has only this Contribution, the membership is cancelled too.
Same when the Contribution gets to "Failed", if it's the first Contribution associated with the membership, it is set to "Expired" status.
https://github.com/civicrm/civicrm-core/blob/5.13/CRM/Contribute/BAO/Contribution.php#L1784
We use Membership for many Organizations with *manual/offline* payment processors, like direct debit, where the first Contribution can be Cancelled (i.e.: the member has no funds in his bank account) but this doesn't mean that the membership has to be cancelled too. The ORG will reattempt to charge this contribution later, and this same Contribution can be later Completed or a new one charged.
This ticket is meant to reopen the discussion about this topic with other users, and if it worth it, to rework on a solution where this behavior of cancelling memberships is not mandatory
Other areas of the code where similar things happen:
* https://github.com/civicrm/civicrm-core/blob/5.13/CRM/Contribute/BAO/ContributionRecur.php#L2985.35.0https://lab.civicrm.org/dev/core/-/issues/2427User Creation fails on 5.34+2021-03-01T19:58:31ZkcristianoUser Creation fails on 5.34+As reported on [Mattermost](https://chat.civicrm.org/civicrm/pl/96r1mb4743fkfn59s6rn5gzguc) User Creation is not working on WP and CiviCRM 5.34. I was able to reproduce and also tested against RC.
Test Enviornment:
- WP 5.6.2
- Civi...As reported on [Mattermost](https://chat.civicrm.org/civicrm/pl/96r1mb4743fkfn59s6rn5gzguc) User Creation is not working on WP and CiviCRM 5.34. I was able to reproduce and also tested against RC.
Test Enviornment:
- WP 5.6.2
- CiviCRM 5.35-RC
- php 7.3
Using a buildkit install, make account creation required on the Name and Address profile.
Add the profile to the `Help Support CiviCRM` page.
The form will ask for credentials, but no CMS user account is created.
Tested on CiviCRM 5.33.2, user account creation works.
I also tested with WP version 5.4.4 and 5.5.2 - this made no difference, the bug starts with CiviCRM 5.34.0
@haystack any immediate thoughts?
EDIT:
Nothing in my logs at all - debug log is empty. Revert of recent commits in CRM_Utils_System_WordPress has no change.5.35.0https://lab.civicrm.org/dev/financial/-/issues/166Account IIF Export Amount Format improper2021-03-01T02:27:36ZLoganBearAccount IIF Export Amount Format improperBatches created before 5.34 export simple value amounts:
```
12.00
-12.00
```
Batches after the upgrade to 5.34 adds a dollar sign to the amount:
```
$12.00
-$12.00
```
I can't get these files imported without loading them into Excel...Batches created before 5.34 export simple value amounts:
```
12.00
-12.00
```
Batches after the upgrade to 5.34 adds a dollar sign to the amount:
```
$12.00
-$12.00
```
I can't get these files imported without loading them into Excel and changing the formatting.5.35.0https://lab.civicrm.org/dev/core/-/issues/2407Search kit uses a maria-db-reserved word2021-02-22T23:05:46ZeileenSearch kit uses a maria-db-reserved wordI found that when running the count query I was getting a db error - it turned out the word 'rows' in the below query is reserved in Maria DB from 10.2.4
```
SELECT count(*) AS `c` FROM ( SELECT `a`.`id` AS `id` FROM civicrm_contact a I...I found that when running the count query I was getting a db error - it turned out the word 'rows' in the below query is reserved in Maria DB from 10.2.4
```
SELECT count(*) AS `c` FROM ( SELECT `a`.`id` AS `id` FROM civicrm_contact a INNER JOIN `civicrm_contribution` `Contact_Contribution_contact_id_01` ON `Contact_Contribution_contact_id_01`.`contact_id` = `a`.`id` AND `a`.`id` = `Contact_Contribution_contact_id_01`.`contact_id` AND
blah blah
WHERE bla blah GROUP BY `a`.`id` ) AS rows;
```
https://mariadb.com/kb/en/reserved-words/5.35.0https://lab.civicrm.org/dev/core/-/issues/2340Creating an afform without civicrm/ in the url breaks the site2021-02-05T06:07:48ZeileenCreating an afform without civicrm/ in the url breaks the siteThe exception is uncaught when civi can't handle the url - meaning that multiple relevant pages (home page, api, any page that might be used to fix it) won't render.
Sorry, due to an error, we are unable to fulfill your request at the ...The exception is uncaught when civi can't handle the url - meaning that multiple relevant pages (home page, api, any page that might be used to fix it) won't render.
Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
'trxn': Could not find access_callback in path tree, Could not find is_ssl in path tree
```
| CRM_Core_Exception: 'trxn': Could not find access_callback in path tree, Could not find is_ssl in path tree in /.../civicrm/CRM/Core/Menu.php on line 269 |
| 0 | CRM_Core_Menu::fillMenuValues(Array, 'trxn') | /../civicrm/CRM/Core/Menu.php:269 |
| 1 | CRM_Core_Menu::build(Array) | /../civicrm/CRM/Core/Menu.php:295 |
| 2 | CRM_Core_Menu::store(false) | /../civicrm/CRM/Core/Invoke.php:146 |
| 3 | CRM_Core_Invoke::getItem(Array) | /../civicrm/CRM/Core/Invoke.php:67 |
| 4 | CRM_Core_Invoke::_invoke(Array) | /../civicrm/CRM/Core/Invoke.php:36 |
| 5 | CRM_Core_Invoke::invoke(Array) | /../civicrm/drupal/civicrm.module:459 |
| 6 | civicrm_invoke('api4') | /.../drupal/includes/menu.inc:527 |
| 7 | menu_execute_active_handler() | /../drupal/index.php:21 |
| 8 | {main} | |
```5.35.0https://lab.civicrm.org/dev/core/-/issues/2355Notice: Undefined property: CRM_Core_DAO::$_context in CRM_Utils_PagerAToZ::c...2021-02-03T21:06:23ZDaveDNotice: Undefined property: CRM_Core_DAO::$_context in CRM_Utils_PagerAToZ::createLinks() on contribution page listingIt's very recent. Coming from https://github.com/civicrm/civicrm-core/pull/19472
Also on Manage Events.It's very recent. Coming from https://github.com/civicrm/civicrm-core/pull/19472
Also on Manage Events.5.35.0https://lab.civicrm.org/dev/core/-/issues/2350Oauth Redirect URL reporterror_civicrm_handler2021-02-03T11:15:42Zmagnolia61Oauth Redirect URL reporterror_civicrm_handlerOverview
----------------------------------------
When trying to configure oauth2 the Redirect URL does not preselect the proper url when ReportError extension is also enabled.
Current behaviour
----------------------------------------
...Overview
----------------------------------------
When trying to configure oauth2 the Redirect URL does not preselect the proper url when ReportError extension is also enabled.
Current behaviour
----------------------------------------
![oauth2-error](/uploads/3a338cb3d84c2859de2deee37b873d2d/oauth2-error.png)
When I add ID & secret and push the Add (auth code) button Google says:
`Invalid parameter value for redirect_uri: Missing scheme: reporterror_civicrm_handler`
Expected behaviour
----------------------------------------
The proper redirect URL
Environment information
----------------------------------------
* __CiviCRM:__ 5.34beta1
* __PHP:__ 7.3
* __CMS:__ Drupal 7
Comments
----------------------------------------
After uninstalling reporterror the redirect URL stays the same. Might be cache. I check again.5.35.0https://lab.civicrm.org/dev/core/-/issues/2242CiviCRM Export, Saved Export Field Mapping that contains custom fields which ...2021-02-01T22:03:53Zjustinfreeman (Agileware)CiviCRM Export, Saved Export Field Mapping that contains custom fields which have been disabled or deleted are still loaded as "clear" values and cause the export download to fail with "DB Error: no such field"CiviCRM Export, Saved Export Field Mapping that contains custom fields which have been disabled or deleted are still loaded as "clear" values and cause the export download to fail with "DB Error: no such field".
This is complicated furt...CiviCRM Export, Saved Export Field Mapping that contains custom fields which have been disabled or deleted are still loaded as "clear" values and cause the export download to fail with "DB Error: no such field".
This is complicated further because the **user cannot remove the "clear" fields from the field export list at all** and as a result, renders the Saved Export Field Mapping defunct.
The disabled or deleted fields are listed on the field export page as "clear", see screenshot below.
![Screenshot_20201210_165641](/uploads/099da3249d6eb3734fab60d6adaacf58/Screenshot_20201210_165641.png)
Agileware Ref: CIVICRM-16275.35.0https://lab.civicrm.org/dev/core/-/issues/2305Logging tables shown as 'different' incorrectly after upgrading to MariaDB 10...2021-02-01T21:21:42ZJKingsnorthLogging tables shown as 'different' incorrectly after upgrading to MariaDB 10.4.xWe recently upgraded to MariaDB 10.4.x and have been running into some problems with logging.
1) \CRM_Logging_Schema::columnsWithDiffSpecs - has an exception for dealing with 'timestamp' fields that default to the current timestamp (you...We recently upgraded to MariaDB 10.4.x and have been running into some problems with logging.
1) \CRM_Logging_Schema::columnsWithDiffSpecs - has an exception for dealing with 'timestamp' fields that default to the current timestamp (you don't want that to happen in the logging tables) however the format for how that is described by MariaDB has changed in recent versions of MariaDB:
https://mariadb.com/kb/en/now/
> When displayed in the INFORMATION_SCHEMA.COLUMNS table, a default CURRENT TIMESTAMP is displayed as CURRENT_TIMESTAMP up until MariaDB 10.2.2, and as current_timestamp() from MariaDB 10.2.3, due to to MariaDB 10.2 accepting expressions in the DEFAULT clause.
2) \CRM_Logging_Schema::columnsWithDiffSpecs - is showing this as a 'difference' for all id fields where the original table is not NULLABLE, but the logging table is NULLABLE and has a default of NULL. In this screenshot the 'original' table is displayed first, followed by the logging table:
![image](/uploads/7877a50bc74e5750ea9690220e00bf2d/image.png)
This is hitting the condition (same lines as above):
```
elseif ($civiTableSpecs[$col]['COLUMN_DEFAULT'] != CRM_Utils_Array::value('COLUMN_DEFAULT', $logTableSpecs[$col]) &&
!strstr($civiTableSpecs[$col]['COLUMN_DEFAULT'], 'TIMESTAMP')
) {
```
My guess is that the COLUMN_DEFAULT was not 'NULL' by default prior to our upgrade to MariaDB 10.4.x, or it's reporting it differently through the SHOW TABLE / COLUMNS commands? I suggest we alter the elseif to account for this case.
---
The symptom of these is that it tries to ALTER all the applicable ID columns every time an extension is enabled, which times out if your logging tables are large. Because it doesn't actually change the schema, it does this _every_ time an extension is enabled/disabled. Or when fixSchemaDifferences is triggered.
---
PR: incoming5.35.0https://lab.civicrm.org/dev/core/-/issues/2313Searchkit - activity record type not intuitive2021-02-01T21:08:14ZeileenSearchkit - activity record type not intuitiveSearches involving activity contacts are complicated - the lowest hanging fruit is probably the activity_contact.record_type_id title - Activity Contact Type?Searches involving activity contacts are complicated - the lowest hanging fruit is probably the activity_contact.record_type_id title - Activity Contact Type?5.35.0https://lab.civicrm.org/dev/core/-/issues/2347Preview button on table display form not working2021-02-01T21:07:36ZeileenPreview button on table display form not workingNothing happens when I click on the green button - @colemanw I mentioned this on that PR - so this is creating a gl to track
![Screenshot_from_2021-02-01_16-28-38](/uploads/b78b49e7ccdabcf4ca2ac21d60b37c2a/Screenshot_from_2021-02-01_16-...Nothing happens when I click on the green button - @colemanw I mentioned this on that PR - so this is creating a gl to track
![Screenshot_from_2021-02-01_16-28-38](/uploads/b78b49e7ccdabcf4ca2ac21d60b37c2a/Screenshot_from_2021-02-01_16-28-38.png)5.35.0https://lab.civicrm.org/dev/core/-/issues/2349Search kit, contribution search - financial type field is odd2021-02-01T21:07:16ZeileenSearch kit, contribution search - financial type field is oddThe field is present before I select any fields, but staying empty....
![Screenshot_from_2021-02-01_16-56-40](/uploads/91c6fa6e756c71cc1d0b2ece8d487fcd/Screenshot_from_2021-02-01_16-56-40.png)The field is present before I select any fields, but staying empty....
![Screenshot_from_2021-02-01_16-56-40](/uploads/91c6fa6e756c71cc1d0b2ece8d487fcd/Screenshot_from_2021-02-01_16-56-40.png)5.35.0https://lab.civicrm.org/dev/core/-/issues/2352UF Settings page for Views CiviCRM integration should not have backticks for ...2021-02-01T20:27:10ZherbdoolUF Settings page for Views CiviCRM integration should not have backticks for BackdropBackdrop now supports MySQL 8 which means the "hackish" support for Views integration has changed. https://github.com/backdrop/backdrop-issues/issues/4745
It no longer works with backticks. Only this works:
```
'abc_civi.',
```Backdrop now supports MySQL 8 which means the "hackish" support for Views integration has changed. https://github.com/backdrop/backdrop-issues/issues/4745
It no longer works with backticks. Only this works:
```
'abc_civi.',
```5.35.0https://lab.civicrm.org/dev/core/-/issues/2333Adding Contacts to a New Group via Manage Groups Page Failure2021-02-01T03:47:07ZkcristianoAdding Contacts to a New Group via Manage Groups Page FailureTested on 5.34-RC, WP 5.6 and Drupal 7
* Add New Group via Manage Groups screen
* Make it a mailing list
* search for all contacts
* click on letter M (or any letter)
Expected - see Contacts with last name M
Actual: Bounced back to gr...Tested on 5.34-RC, WP 5.6 and Drupal 7
* Add New Group via Manage Groups screen
* Make it a mailing list
* search for all contacts
* click on letter M (or any letter)
Expected - see Contacts with last name M
Actual: Bounced back to group creation page
Tested on 5.33.2 and 5.35-master as well.
Same behavior. Not sure when this issue was introduced. I tagged regression, but understand this may go back a bit.5.35.0https://lab.civicrm.org/dev/core/-/issues/2312Searchkit - separate calls for results & count2021-02-01T03:28:04ZeileenSearchkit - separate calls for results & countSearch kit gives the appearance of doing nothing on a search with a slow-ish query but this is the count() part of the search. By separating this part out the user experience is much betterSearch kit gives the appearance of doing nothing on a search with a slow-ish query but this is the count() part of the search. By separating this part out the user experience is much better5.35.0https://lab.civicrm.org/dev/core/-/issues/2310Search-kit - better user experience for bulk updates2021-02-01T03:27:40ZeileenSearch-kit - better user experience for bulk updatesRequest that we provide feedback (progress bar) when doing a bulk update from search kit
I did a search for 100,000 activities via search kit, chose to update the date using the update option and selected 'update 100,000 activities'. No...Request that we provide feedback (progress bar) when doing a bulk update from search kit
I did a search for 100,000 activities via search kit, chose to update the date using the update option and selected 'update 100,000 activities'. Nothing happened. Except it did. Around about 20k activities were updated & we wound up with some js errors when it presumably timed out at the php level.
Being able to update large numbers is a winning feature of search kit - but it needs a progress bar5.35.0https://lab.civicrm.org/dev/core/-/issues/2341Afform api explorer: has_local, has_base do not present as bool2021-01-30T21:28:41ZeileenAfform api explorer: has_local, has_base do not present as boolLooks like the type isn't defined as bool or I would get yes/no options I believe
![image](/uploads/197b56ac6d5a2873e3f60e80d960ca88/image.png)Looks like the type isn't defined as bool or I would get yes/no options I believe
![image](/uploads/197b56ac6d5a2873e3f60e80d960ca88/image.png)5.35.0