Development issueshttps://lab.civicrm.org/groups/dev/-/issues2019-10-30T01:35:14Zhttps://lab.civicrm.org/dev/core/-/issues/1336CRM_ACL_BAO_Cache::updateEntry is bonkers and possibly even broken2019-10-30T01:35:14ZseamusleeCRM_ACL_BAO_Cache::updateEntry is bonkers and possibly even brokenThe function mentioned seems to be written in such a way as it is trying to do two jobs at once which seems very very odd indeed.
Firstly the $id param isn't clearly spelled out however when it calls the deleteEntry() function it seems ...The function mentioned seems to be written in such a way as it is trying to do two jobs at once which seems very very odd indeed.
Firstly the $id param isn't clearly spelled out however when it calls the deleteEntry() function it seems that the $id is of the contact being viewed.
however later on when it calls getAllACLs for contact and also build the cache table it is now believing that $id is the contact id of the user trying to access the contacts. Which makes more sense but still feels very much odd ball.5.20.0seamusleeseamusleehttps://lab.civicrm.org/dev/financial/-/issues/80Noisily deprecate transact api2019-10-24T21:16:11ZeileenNoisily deprecate transact apiWe should add in deprecation warnings using CRM_Core_Error::deprecatedFunctionWarning - these show on dev sites but not live
First step is https://lab.civicrm.org/dev/financial/issues/79We should add in deprecation warnings using CRM_Core_Error::deprecatedFunctionWarning - these show on dev sites but not live
First step is https://lab.civicrm.org/dev/financial/issues/795.20.0https://lab.civicrm.org/dev/financial/-/issues/79Deprecate Contribute.transact api2019-10-24T21:15:57ZeileenDeprecate Contribute.transact apiThe minimum we should do is deprecate from api explorer & I will do that in this PR. (Agreed in Barcelona)
I think we probably should do a noisier deprecation than that but that will stale-out some PRs currently under discussionThe minimum we should do is deprecate from api explorer & I will do that in this PR. (Agreed in Barcelona)
I think we probably should do a noisier deprecation than that but that will stale-out some PRs currently under discussion5.20.0https://lab.civicrm.org/dev/financial/-/issues/77PaymentProcessor.pay should handle 'invoice_id' & map it to a getter so pro...2019-11-04T23:47:09ZeileenPaymentProcessor.pay should handle 'invoice_id' & map it to a getter so processors can retrieve it5.20.0https://lab.civicrm.org/dev/core/-/issues/1333Balance Due of completed contribution does not show as 0 but full amount in p...2019-10-22T00:07:05Zmagnolia61Balance Due of completed contribution does not show as 0 but full amount in payment receiptUsing 5.18.3 with patch https://github.com/civicrm/civicrm-core/pull/15545 (to be able to send the payment receipt at all)
I noticed that in different scenarios's (A. Pay the contribution in one payment & B. Pay it in a few payments)
the...Using 5.18.3 with patch https://github.com/civicrm/civicrm-core/pull/15545 (to be able to send the payment receipt at all)
I noticed that in different scenarios's (A. Pay the contribution in one payment & B. Pay it in a few payments)
the payment notification email shows the wrong amount for the Balance Due.
Interestingly it show the proper Balance Due when doing partial payments
```
Total Amount : 100
This Payment Amount : 60
Balance Due: 40
```
But at the final payment to full fill the contribution it shows the same as the full amount
```
Total Amount : 100
This Payment Amount : 100
Balance Due: 100
```5.18.4https://lab.civicrm.org/dev/core/-/issues/1332Payment details not saved correctly from Additional payment form2019-10-22T00:06:56ZeileenPayment details not saved correctly from Additional payment formDetail is https://github.com/civicrm/civicrm-core/pull/15537Detail is https://github.com/civicrm/civicrm-core/pull/155375.18.4https://lab.civicrm.org/dev/core/-/issues/1329Too many dead people in sample data2019-11-27T02:16:43Zjustinfreeman (Agileware)Too many dead people in sample dataCiviCRM sample data contains too many dead people (Contact, Individual, Deceased = True) - there's a total of 27 dead contacts. Can we bring these people back to life please?
The number of dead people that you actually want in your CRM ...CiviCRM sample data contains too many dead people (Contact, Individual, Deceased = True) - there's a total of 27 dead contacts. Can we bring these people back to life please?
The number of dead people that you actually want in your CRM data should be a very small percentage, unfortunately this state of being seems to be over-represented in the sample data.
Let's breathe some life back into the sample data!
Agileware Ref: CIVICRM-13775.20.0https://lab.civicrm.org/dev/core/-/issues/1325Autoassignees on case activities might assign the wrong person if client has ...2020-07-06T23:21:37ZDaveDAutoassignees on case activities might assign the wrong person if client has another case with that role assigned thereIn a case type timeline you can configure autoassignees for activities based on a role in the case. To reproduce:
1. In the case type edit screen configure a role like "Benefits Specialist is".
2. Add another timeline (you can use the s...In a case type timeline you can configure autoassignees for activities based on a role in the case. To reproduce:
1. In the case type edit screen configure a role like "Benefits Specialist is".
2. Add another timeline (you can use the standard one but it's easier to see with a new one).
3. In that timeline add a followup activity and set the autoassignee to be by relationship and to "Benefits Specialist is".
4. Save the case type.
5. Create a case of that type.
6. Assign the role of "Benefits Specialist is" to someone.
7. Add the other timeline via the Add Timeline dropdown on manage case. So far ok.
8. Create another case for the *same client*.
9. Don't assign the role of "Benefits Specialist is".
10. Add the other timeline again to this case.
11. The Benefits Specialist from the OTHER CASE gets assigned here.
**Note that this happens even if you close the first case before the second.**
I think there's two things going on. One is a variation of issues with closed cases and relationships noted elsewhere, and the other is that the lookup for who to assign doesn't take case_id into account. The first part though would be made irrelevant here if the case_id is taken into account.
There is a little gotcha for relationships that can and usually do exist outside the case, like spouse. If you assign the relationship outside the case, then you might actually expect it to be assigned to the activity without having to assign it specifically as a role on every case.
TBD
And this isn't a recent issue I'm thinking it's always been independent of case_id since introduced.5.29.0https://lab.civicrm.org/dev/core/-/issues/1324Customfields attached to addresses break the profile page2019-10-28T08:08:37ZVangelisPCustomfields attached to addresses break the profile page## General
When we set an address customfield on an address and then we add that field into a profile, the profile page breaks on edit mode.
Returning error: `DB Error: no such field`
## How to reproduce
On https://dmaster.demo.civicrm...## General
When we set an address customfield on an address and then we add that field into a profile, the profile page breaks on edit mode.
Returning error: `DB Error: no such field`
## How to reproduce
On https://dmaster.demo.civicrm.org (CiviCRM 5.20.alpha1) :
* Create a new CustomGroup and assign it to the entity 'Address'
* Create a new customfield (for example of type textfield)
* Populate the field with some dummy information
* Create a new profile and add 2 fields:
* Street Address
* Your newly created customfield
* Click on 'More -> Use edit mode'
* The page should break with error `DB Error: no such field`
## Background
It seems that the issue starts here: https://lab.civicrm.org/dev/core/blob/master/CRM/Contact/BAO/Contact.php#L1784
and then goes here: https://lab.civicrm.org/dev/core/blob/master/CRM/Contact/BAO/Query.php#L1036
and the actual join should take place somewhere here: https://lab.civicrm.org/dev/core/blob/master/CRM/Contact/BAO/Query.php#L1307
In short: There is an additional field, the id of the customtable that is holding the customfield in the select query that is not being joined properly (join is actually missing) from the constructed query.5.20.0https://lab.civicrm.org/dev/core/-/issues/1322payment_or_refund_notification 'FROM' address is missing2019-10-21T05:19:37Zmagnolia61payment_or_refund_notification 'FROM' address is missingThe Payment_or_refund mail (send when recording a payment) does not get send with us.
We get the message that the "FROM" address is missing. All other mails get send perfectly.
```
The mail library returned the following error message:
N...The Payment_or_refund mail (send when recording a payment) does not get send with us.
We get the message that the "FROM" address is missing. All other mails get send perfectly.
```
The mail library returned the following error message:
No From: address has been provided
```
When I change our outbound mail settings to database, I can see indeed the from address is missing from the headers.
The following header is from the add payment mail. This fails to send, lacks the 'From' field and is also missing the return path.
```
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="=_a5d5e8e8a2563fab89e0f4ae653c0aee"
To: Testuser
Subject: Payment Receipt -
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Date: Wed, 16 Oct 2019 12:52:43 +0200
```
The following mail is the contribution receipt. This gets send and has the From field in the header
```
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="=_76561187d0121e320a4a0d0fdb8432cb"
From: "Testuser"
To: Testleid Groepsleiding
Subject: Contribution Receipt - Testleid Groepsleiding
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Return-Path: testuser@gmail.com
Date: Wed, 16 Oct 2019 12:52:16 +0200
```5.18.4https://lab.civicrm.org/dev/core/-/issues/1320Workflow templates - Include displayname in subject2019-10-26T20:33:11Zmagnolia61Workflow templates - Include displayname in subjectMany email providers group emails with the same subject which leads to time-consuming processes for many organisations, and many additional unnecessary clicks.
Some system workflow template subjects include the display name.
Also it mak...Many email providers group emails with the same subject which leads to time-consuming processes for many organisations, and many additional unnecessary clicks.
Some system workflow template subjects include the display name.
Also it makes the email more personal as it is clear who it is addressed to.
This is proven to be beneficial for open-rates of transactional mails.
The messages will be upgraded in 5.20alpha1 by #15491
https://github.com/civicrm/civicrm-core/pull/155135.20.0magnolia61magnolia61https://lab.civicrm.org/dev/core/-/issues/1319No Household Member Relationship Created when an Individual shares a relation...2020-02-19T20:48:07ZalicefruminNo Household Member Relationship Created when an Individual shares a relationship with a householdWhen editing a Contacts Address:
IF one clicks "Use another contact's address"
AND then selects a HOUSEHOLD contact to share an address with
THEN the address is shared BUT a **household member relationship is NOT created**.
The S...When editing a Contacts Address:
IF one clicks "Use another contact's address"
AND then selects a HOUSEHOLD contact to share an address with
THEN the address is shared BUT a **household member relationship is NOT created**.
The Shared Address help text says: "If you link an individual's address to an organization, an employee-employer relationship will be automatically created. **If you link an individual's address to a household, a household member relationship is created.**"
Which leads me to believe this is a regression. It seems the functionality for linking an individual's address to an organization has been enhanced specifically:
When one clicks "Use another contact's address"
AND then selects a ORGANIZATION contact to share an address with
THEN a "Set this organization as current employer" checkbox appears
IF checked then a relationship is created... if not no relationship is created
as discussed [here](https://github.com/civicrm/civicrm-core/pull/12574)
Perhaps a similar checkbox should appear when sharing a household address.
![sharedAddressHelpText](/uploads/9800c3df1b22b02f4342ccf05fb141cc/sharedAddressHelpText.png)5.23.0https://lab.civicrm.org/dev/core/-/issues/1318Import Activity with custom field fails2021-01-28T23:07:08ZPradeep Nayakpradpnayak@gmail.comImport Activity with custom field failsWhen trying to import activity with custom field(type:checkbx) it fails with error '1' is not a valid option for field custom_XX.
To replicate:
1. Create custom field for Activity of type checkbox with Label and value as string.
2. Impo...When trying to import activity with custom field(type:checkbx) it fails with error '1' is not a valid option for field custom_XX.
To replicate:
1. Create custom field for Activity of type checkbox with Label and value as string.
2. Import Activity with Label of custom field.5.35.0https://lab.civicrm.org/dev/core/-/issues/1316Workflow templates - Update 'Thank You' & other text corrections2019-10-24T21:27:09Zmagnolia61Workflow templates - Update 'Thank You' & other text correctionsThere are a few texts in the workflow message templates that are too specific for use in different circumstances. Since we are making changes to the system workflow templates I would like to address these in this round
Specifically I wo...There are a few texts in the workflow message templates that are too specific for use in different circumstances. Since we are making changes to the system workflow templates I would like to address these in this round
Specifically I would like to adjust the templates dealing with contribution and membership
These templates have the text: "**Thank you for your support**". But this is too specific. The contribution offline-receipt could be sent because someone paid for a workshop they are attending. They are not supporting anything, they just paid for what the registered for. The same with the membership. Not all memberships are to support the cause of the organisation. It would be better to describe the object of the gratitude more general.
Some examples of proposed changes.
1. The contribution receipt template had:
`'Thank you for your support',`
But the status can be anything, also pending (which does make the thanks a bit confusing)
Better and more neutral would be:
`'Below you will find a receipt for this contribution.',`
(It would even be better if the table would include the contribution status here)
2. Another example. The event online receipt had:
`Thank you for your participation.`
But the status can also be pending, and anyway chances are high this is all still before the event.
Better and more neutral would be:
`Thank you for your registration.`
3. Thirdly, the membership receipts had:
`Thank you for your support.`
But the membership could also just be something people pay for on a regular basis, without the notion of supporting the 'cause' of the organisation. There are many variations of the membership function.
Better and more neutral here would be:
`Thank you for this contribution.`
4. Finally, the participant confirm template
I added {ts} to the 'click here to confirm text' in https://github.com/civicrm/civicrm-core/pull/15491
But the mail itself is lacking an introductory text. I would propose the following:
`Your registration was waitlisted but we can confirm you can now complete the registration process.`
I believe all these changes (and also some grammar corrections will benefit the readability of the standard texts and make these of more general use for more scenarios.
Cheers, Richard5.20.0magnolia61magnolia61https://lab.civicrm.org/dev/core/-/issues/1309Contribution Dashboard still uses broken Open Flash Charts2019-10-12T16:11:35ZeileenContribution Dashboard still uses broken Open Flash ChartsReplacement chart not rendering on Contribution Dashboard @artfulrobot promised to make it beautiful againReplacement chart not rendering on Contribution Dashboard @artfulrobot promised to make it beautiful again5.20.0RichRichhttps://lab.civicrm.org/dev/core/-/issues/1307Add tracking table for import jobs2022-06-10T09:06:03ZeileenAdd tracking table for import jobsA current blocker to refactoring the import jobs to use queue processes / non-timeout UI methods is persistence of output data.
We discussed this in Barcelona and came up with the following proposal
1) create a new table civicrm_user_j...A current blocker to refactoring the import jobs to use queue processes / non-timeout UI methods is persistence of output data.
We discussed this in Barcelona and came up with the following proposal
1) create a new table civicrm_user_job with the fields
- contact_id (or created_id?)
- job_identifier (or name?) - we probably would need this to be unique but the BAO could handle appending to it if it is not.
- start_timestamp
- end_timestamp
- job_hash - used for file naming
2) files created as a result of the job could have a standard naming convention - e.g
import_{job_hash}_validation_errors.csv
import_{job_hash}_duplicates.csv
3) We would need a cleanup job which would also remove the files - e.g more than one week old
4) The UserJob BAO would obviously run pre & post hooks - allowing tracking by extensions
5) Permissioning of file retrieval can be via Attachment api - Tim thinks we know how that works but he is wrong.
6) When viewing the results of the import this creates options for us to potentially present a user with their imports (plural) results & for them to choose which they want. (Perhaps exposing the job_idenfier field to them would help here?
@totten @pfigel @seamuslee5.51.0https://lab.civicrm.org/dev/core/-/issues/1302Fatal error in export when using "Merge All Contacts with the Same Address" a...2019-10-08T17:27:07ZDaveDFatal error in export when using "Merge All Contacts with the Same Address" and Selected Fields instead of Primary FieldsSee https://civicrm.stackexchange.com/questions/33272/fatal-error-on-export-in-5-18-1/33273#33273
1. Do a contact search.
2. Select some results.
3. Choose Export from the Actions dropdown.
4. Choose Selected Fields.
5. Choose the optio...See https://civicrm.stackexchange.com/questions/33272/fatal-error-on-export-in-5-18-1/33273#33273
1. Do a contact search.
2. Select some results.
3. Choose Export from the Actions dropdown.
4. Choose Selected Fields.
5. Choose the option "Merge All Contacts with the Same Address".
6. Pick your selected fields.
7. Export.
Db error, because there's an extra comma being added at the end of the field list or possibly a field name is supposed to be there but comes out blank. Then it's followed by a php notice when you go to another page.
```
Database Error Code: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ' PRIMARY KEY ( id ), INDEX index_street_address( street_address ) , INDEX i' at line 15, 1064
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -2
[message] => DB Error: syntax error
[mode] => 16
[debug_info] => CREATE TABLE `civicrm_tmp_d_export_4fa32a2a24bde72ebb683e1e36771419` ( id int unsigned NOT NULL AUTO_INCREMENT, display_name varchar(128),
addressee varchar(255),
postal_greeting varchar(255),
email_greeting varchar(255),
street_name varchar(64),
household_name varchar(128),
street_address varchar(96),
city varchar(64),
state_province varchar(64),
civicrm_primary_id varchar(16),
master_id varchar(128),
state_province_id varchar(255),
postal_greeting_id varchar(16),
addressee_id varchar(16),
,
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX index_household_name( household_name )
,
INDEX index_civicrm_primary_id( civicrm_primary_id )
) ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX i' at line 15]
[type] => DB_Error
[user_info] => CREATE TABLE `civicrm_tmp_d_export_4fa32a2a24bde72ebb683e1e36771419` ( id int unsigned NOT NULL AUTO_INCREMENT, display_name varchar(128),
addressee varchar(255),
postal_greeting varchar(255),
email_greeting varchar(255),
street_name varchar(64),
household_name varchar(128),
street_address varchar(96),
city varchar(64),
state_province varchar(64),
civicrm_primary_id varchar(16),
master_id varchar(128),
state_province_id varchar(255),
postal_greeting_id varchar(16),
addressee_id varchar(16),
,
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX index_household_name( household_name )
,
INDEX index_civicrm_primary_id( civicrm_primary_id )
) ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX i' at line 15]
[to_string] => [db_error: message="DB Error: syntax error" code=-2 mode=callback callback=CRM_Core_Error::handle prefix="" info="CREATE TABLE `civicrm_tmp_d_export_4fa32a2a24bde72ebb683e1e36771419` ( id int unsigned NOT NULL AUTO_INCREMENT, display_name varchar(128),
addressee varchar(255),
postal_greeting varchar(255),
email_greeting varchar(255),
street_name varchar(64),
household_name varchar(128),
street_address varchar(96),
city varchar(64),
state_province varchar(64),
civicrm_primary_id varchar(16),
master_id varchar(128),
state_province_id varchar(255),
postal_greeting_id varchar(16),
addressee_id varchar(16),
,
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX index_household_name( household_name )
,
INDEX index_civicrm_primary_id( civicrm_primary_id )
) ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX i' at line 15]"]
)
```
`Notice: Undefined index: sql_columns in CRM_Export_BAO_ExportProcessor->getSQLColumns() (line 927 of .../web/sites/all/modules/civicrm/CRM/Export/BAO/ExportProcessor.php`
@eileen @seamuslee5.18.2https://lab.civicrm.org/dev/financial/-/issues/73Order.create should not require total amount2019-10-19T23:49:21ZJoeMurrayOrder.create should not require total amountThe spec for Order API create indicates that the total_amount is not required. If it is not provided then the total is calculated for the line item totals. However, https://dmaster.demo.civicrm.org/civicrm/api#explorer shows that total_a...The spec for Order API create indicates that the total_amount is not required. If it is not provided then the total is calculated for the line item totals. However, https://dmaster.demo.civicrm.org/civicrm/api#explorer shows that total_amount is a required parameter. Please fix the implementation of the order api create functionality to not require total_amount.5.20.0Monish DebMonish Debhttps://lab.civicrm.org/dev/user-interface/-/issues/6Remove print icon2019-10-13T18:19:26ZnicolRemove print iconThis was raised by @smaen123 at #Summit19. There is an open #PR needing concept approval [on GH](https://github.com/civicrm/civicrm-core/pull/15322). @Kilakwabt mentioned another issue related to this he might want to elaborate on here o...This was raised by @smaen123 at #Summit19. There is an open #PR needing concept approval [on GH](https://github.com/civicrm/civicrm-core/pull/15322). @Kilakwabt mentioned another issue related to this he might want to elaborate on here or via security@civicrm.org depending on its current status.5.20.0https://lab.civicrm.org/dev/core/-/issues/1295Per agreement in NYC sprint, add status check is_active to table2019-10-17T18:16:43ZeileenPer agreement in NYC sprint, add status check is_active to tablehttps://docs.google.com/document/d/1z1Lm-DUrri6xPzGXU37nLk5SfRjo4i9Elvx-lfbmK24/edit#heading=h.164d9ulc2oa3https://docs.google.com/document/d/1z1Lm-DUrri6xPzGXU37nLk5SfRjo4i9Elvx-lfbmK24/edit#heading=h.164d9ulc2oa35.20.0