Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-11-15T01:19:55Zhttps://lab.civicrm.org/dev/core/-/issues/4754Upgrading to 5.66+ still has old copy of crm.menubar.js2023-11-15T01:19:55ZjonathandhnUpgrading to 5.66+ still has old copy of crm.menubar.jscrm.menubar.js l.293 return a console error for ```TypeError: undefined is not an object (evaluating 'result.values.length')``` when text is typed on the search box and live search from the menu bar stopped working.
```
if (result.v...crm.menubar.js l.293 return a console error for ```TypeError: undefined is not an object (evaluating 'result.values.length')``` when text is typed on the search box and live search from the menu bar stopped working.
```
if (result.values.length > 0) {
$('#crm-qsearch-input').autocomplete('widget').menu('option', 'disabled', false);
$.each(result.values, function(k, v) {
ret.push({value: v.id, label: v.data});
});
}
```
Civicrm 5.66.0, then 5.66.1, 5.66.2 and 5.67.0, Drupal 10.1.6 PHP 8.1.24, MariaDB 10.6.15https://lab.civicrm.org/dev/core/-/issues/4742[PHP 8.1] CRM_Admin_Form_Generic warnings2023-10-31T20:38:36Zjofranzfranz@systopia.de[PHP 8.1] CRM_Admin_Form_Generic warnings## Having
- CiviCRM 5.66.2
- Drupal 10.1.5
- PHP 8.1
## Visiting
- `.../admin/config/development/logging` to enable logs in UI
- `.../civicrm/admin/setting/theisland`
## Expecting
No erros
## Seeing
```
Warning: Undefined array key ...## Having
- CiviCRM 5.66.2
- Drupal 10.1.5
- PHP 8.1
## Visiting
- `.../admin/config/development/logging` to enable logs in UI
- `.../civicrm/admin/setting/theisland`
## Expecting
No erros
## Seeing
```
Warning: Undefined array key "template" in include() (line 5 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "help" in include() (line 14 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 14 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "pre_html_text" in include() (line 23 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "post_html_text" in include() (line 26 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "documentation_link" in include() (line 30 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 30 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
```
---
_internal ref 23127_https://lab.civicrm.org/dev/core/-/issues/4735Event Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid...2023-12-06T16:06:38Zdarren.woodsEvent Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid value for id"Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/qu...Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/questions/45729/event-registration-error-on-wordpress-6-3-1-civi-5-63-4-could-not-find-valid-va
Reproduction steps
----------------------------------------
1. Configure an event with free online registration and a thankyou message.
2. Register for the event from the event info page.
Current behaviour
----------------------------------------
Users are shown an error: "Could not find valid value for id"
Expected behaviour
----------------------------------------
Thank you message configured in the event should be shown.
Environment information
----------------------------------------
* __Browser: Browser independent.
* __CiviCRM: 5.63.4
* __PHP: 8.1
* __CMS: WordPress 6.3.1
* __Database: MariaDB
* __Web Server: Nginx
Comments
----------------------------------------
This only happens with registering for events using the Civi event info page. If you embed a shortcode for the specific event in a WordPress page then the error is not shown.https://lab.civicrm.org/dev/core/-/issues/4734ADMIN_UI: default checkbox2023-11-03T15:31:20ZGuillaumeSorelADMIN_UI: default checkboxCould it be possible to have checkboxes per default for each new admin screen using SK, so it becomes possible to select multiple lines (for mailings, messages templates, custom fields...) and proceed bulk actions on them, especially del...Could it be possible to have checkboxes per default for each new admin screen using SK, so it becomes possible to select multiple lines (for mailings, messages templates, custom fields...) and proceed bulk actions on them, especially delete?
New SK screens are sweet but actions still need to be proceeded one-by-one.https://lab.civicrm.org/dev/core/-/issues/4732Scheduled Reminder select2 fields to save/view correctly2023-10-27T00:41:38Zmagnolia61Scheduled Reminder select2 fields to save/view correctlyI am testing 5.68 (master) and run into a problem with Event Type based scheduled reminders.
I think since the Event Type and Registration status have been changed to select2 values are saved but when I re-edit the reminder the field sh...I am testing 5.68 (master) and run into a problem with Event Type based scheduled reminders.
I think since the Event Type and Registration status have been changed to select2 values are saved but when I re-edit the reminder the field show empty.
![image](/uploads/1b0c39ee96ae06c36c0b8dcf2adc1552/image.png)
This is what is recorded in the database:
![image](/uploads/b9f77048338bd4347da0a6cc96cc94e1/image.png)
When I select a single value the behavior of the participant status is different than for the event types. A single value for the participant status gets saved and shown on re-edit.
![image](/uploads/d0659ed253a2ee37a07f21be2f0d70a8/image.png)
BTW. I confirmed this bug on https://dmaster.demo.civicrm.org/
![image](/uploads/b078da97fc6d141a3a5d7d54cc6c1ec0/image.png)
![image](/uploads/c256cd3bdef9f8980be7ab38fdaeb8ed/image.png)https://lab.civicrm.org/dev/core/-/issues/4726On Import in Non English Mode do not import field in saved field mapping is n...2023-11-29T20:14:33ZseamusleeOn Import in Non English Mode do not import field in saved field mapping is not correctly set as default when re-using importOverview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set cor...Overview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set correctly when the MapField form is loaded as per the screenshot below showing the saving of the saved mapping field with the 2nd field as do not import but then when I go to re-use the saved mapping the mapped column does not match do not import
![save_import_map](/uploads/a652dc803fecadde0d5ec7fe0f202f58/save_import_map.jpg)
![use_import_map](/uploads/a2ae9251dbc67491276567473e4668c7/use_import_map.jpg)
Reproduction steps
----------------------------------------
1. Navigate to Administer -> localisation -> Languages ... and Set current language to be French (France)
1. Go to contacts -> Import contacts and proceed to the map field step. Create a mapping and save it making sure that one of the fields is marked as do not import
1. Repeat step 2 but this time re-use the saved mapping from before and find that the field is not mapped to the selection of do not import
ping @eileen @JoeMurray5.67.0https://lab.civicrm.org/dev/core/-/issues/4724Contribution fails mid-donation with geocoding, "on behalf of", and no state/...2023-10-30T02:57:00ZJonGoldContribution fails mid-donation with geocoding, "on behalf of", and no state/provinceOverview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
-------------------------------------...Overview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
----------------------------------------
1. Create a contribution page that allows giving "on behalf of an organization". The Organization profile should include state/province and at least one other address field. The state/province must not be required.
2. Submit the form with an organization. Provide at least one part of the address but leave the state blank.
Current behaviour
----------------------------------------
Crashes in geocoding.
Expected behaviour
----------------------------------------
Submits successfully.
Comments
----------------------------------------
This wouldn't be such a big deal but for https://lab.civicrm.org/dev/core/-/issues/2929.
A partial backtrace is below, though there are other ways to reach this code path (e.g. if confirm pages are present/absent).
```
#0 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/DAO.php(1419): strtolower()
#1 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Utils/Geocode/Google.php(76): CRM_Core_DAO::getFieldValue()
#2 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1287): CRM_Utils_Geocode_Google::format()
#3 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(276): CRM_Core_BAO_Address::addGeocoderData()
#4 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1365): CRM_Core_BAO_Address::fixAddress()
#5 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Location.php(52): CRM_Core_BAO_Address::legacyCreate()
#6 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(327): CRM_Core_BAO_Location::create()
#7 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(1921): CRM_Contact_BAO_Contact::create()
#8 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(1296): CRM_Contact_BAO_Contact::createProfileContact()
#9 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(2312): CRM_Contribute_Form_Contribution_Confirm::processOnBehalfOrganization()
#10 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(836): CRM_Contribute_Form_Contribution_Confirm->processFormSubmission()
#11 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/Form.php(617): CRM_Contribute_Form_Contribution_Confirm->postProcess()
#12 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1318): CRM_Core_Form->mainProcess()
#13 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1076): CRM_Contribute_Form_Contribution_Main->skipToThankYouPage()
```5.68.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/4723SearchKit joins to custom fields appear to be broken2023-11-02T20:48:31ZScottMasonSearchKit joins to custom fields appear to be brokenThe latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom fi...The latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom field for activities (for example Activities details > products)
2. Create a new SK search for activities and join to the custom field
![image](/uploads/ebbeb025d909e2df4b8c87d97d7a9ada/image.png)
3. Add info from the linked entity to the display
4. The info is not shown.
![image](/uploads/870046a2cf17c723bfff75917401beb0/image.png)
I have tested this on the lastest demo site and it appears to be an issue there.
fyi @kurundhttps://lab.civicrm.org/dev/core/-/issues/4722[PHP 8.1] fseek deprecation in PHPgettext2023-12-04T21:08:50Zjofranzfranz@systopia.de[PHP 8.1] fseek deprecation in PHPgettextOverview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Depre...Overview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Deprecation] fseek(): Passing null to parameter #2 ($offset) of type int is deprecated at .../drupal/vendor/civicrm/civicrm-packages/PHPgettext/streams.php:125```
Expected behaviour
----------------------------------------
There should be no deprecation warnings.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __CiviCRM:__ _5.66.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _8.1_
* __CMS:__ _Drupal 9.5.11_https://lab.civicrm.org/dev/core/-/issues/4719[PHP 8.1] New Contribution: 4x Undefined array key2023-12-12T20:43:31Zjofranzfranz@systopia.de[PHP 8.1] New Contribution: 4x Undefined array key## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicr...## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicrm/templates_c/en_US/%%60/60A/60A6E1C6%%Payment.tpl.php).
Warning: Undefined array key "buildRecurBlock" in include() (line 125 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
Warning: Undefined array key "urlPathVar" in include() (line 90 of sites/default/files/civicrm/templates_c/en_US/%%51/516/51624B60%%paymentBlock.tpl.php).
Warning: Undefined array key "dataUrl" in include() (line 477 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
```
---
_Internal ref: sci_https://lab.civicrm.org/dev/core/-/issues/4718[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in...2023-11-03T02:04:37Zjofranzfranz@systopia.de[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in CRM_Core_Action## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate...## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate/drupal/vendor/civicrm/civicrm-core/CRM/Core/Action.php).```5.67.0https://lab.civicrm.org/dev/core/-/issues/4717[PHP 8.1] Organization Address and Contact Info: foreach() argument must be ...2023-12-11T23:15:39Zjofranzfranz@systopia.de[PHP 8.1] Organization Address and Contact Info: foreach() argument must be of type array|object, string given## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/admin/domain?action=update&reset=1
## Seeing
2x:
```Warning: Undefined array key "defaultCurrencySymbol" in include() (line 155 of sites/default/files/civicrm/templates_c/en...## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/admin/domain?action=update&reset=1
## Seeing
2x:
```Warning: Undefined array key "defaultCurrencySymbol" in include() (line 155 of sites/default/files/civicrm/templates_c/en_US/%%24/24E/24E27851%%jsortable.tpl.php).```https://lab.civicrm.org/dev/core/-/issues/4709Custom Field display code assumes option values are numeric2023-10-22T22:13:14ZJonGoldCustom Field display code assumes option values are numericOverview
----------------------------------------
Custom Field display code assumes option values are numeric. This leads to crashing when searching using regex/`LIKE` in Search Builder, and possibly less obsolete parts of Civi as well....Overview
----------------------------------------
Custom Field display code assumes option values are numeric. This leads to crashing when searching using regex/`LIKE` in Search Builder, and possibly less obsolete parts of Civi as well.
Reproduction steps
----------------------------------------
1. Create a new custom field of data type Alphanumeric, HTML type of Select.
1. Go to Search Builder.
1. Search on that field using regex or `LIKE`, with a period in the search term. See attached screenshot.
Current behaviour
----------------------------------------
```
TypeError: round(): Argument #1 ($num) must be of type int|float, string given in round() (line 1332 of /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php).
```
Expected behaviour
----------------------------------------
Search should complete as normal.
Comments
----------------------------------------
This happens because we assume that a select value either has a corresponding label, or it's a number. Which is true when you're searching for a specific value, but fails when the value is a regex or LIKE statement.
This doesn't happen in SearchKit, but it *does* happen when you use a smart group based on the search.
This is a regression in the technical sense, but it's been broken since at least 5.53.
Backtrace is below:
```
#0 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomField.php(1278): round()
#1 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomField.php(1194): CRM_Core_BAO_CustomField::formatDisplayValue()
#2 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomQuery.php(197): CRM_Core_BAO_CustomField::displayValue()
#3 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/BAO/CustomQuery.php(369): CRM_Core_BAO_CustomQuery->where()
#4 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/Query.php(569): CRM_Core_BAO_CustomQuery->query()
#5 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/Query.php(524): CRM_Contact_BAO_Query->initialize()
#6 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(585): CRM_Contact_BAO_Query->__construct()
#7 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(777): CRM_Contact_BAO_GroupContactCache::getQueryObjectSQL()
#8 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(616): CRM_Contact_BAO_GroupContactCache::insertGroupContactsIntoTempTable()
#9 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/GroupContactCache.php(359): CRM_Contact_BAO_GroupContactCache::buildGroupContactTempTable()
#10 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Mailing/BAO/Mailing.php(477): CRM_Contact_BAO_GroupContactCache::load()
#11 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Mailing/BAO/Mailing.php(1647): CRM_Mailing_BAO_Mailing::doSubmitActions()
#12 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/v3/utils.php(1294): CRM_Mailing_BAO_Mailing::create()
#13 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/v3/Mailing.php(55): _civicrm_api3_basic_create()
#14 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_mailing_create()
#15 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(156): Civi\API\Provider\MagicFunctionProvider->invoke()
#16 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(79): Civi\API\Kernel->runRequest()
#17 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/api.php(136): Civi\API\Kernel->runSafe()
#18 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/v3/Mailing.php(307): civicrm_api3()
#19 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_mailing_submit()
#20 /home/members/mysite/sites/crm.mysite.org/web/wp-content/civicrm-custom/extensions/uk.co.vedaconsulting.mosaico/CRM/Mosaico/AbDemux.php(128): Civi\API\Provider\MagicFunctionProvider->invoke()
#21 [internal function]: CRM_Mosaico_AbDemux->onSubmitMailing()
#22 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Provider/WrappingProvider.php(48): call_user_func()
#23 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(156): Civi\API\Provider\WrappingProvider->invoke()
#24 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(79): Civi\API\Kernel->runRequest()
#25 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/api/api.php(28): Civi\API\Kernel->runSafe()
#26 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/REST.php(288): civicrm_api()
#27 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/REST.php(533): CRM_Utils_REST::process()
#28 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(288): CRM_Utils_REST::ajax()
#29 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem()
#30 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke()
#31 /home/members/mysite/sites/crm.mysite.org/web/wp-content/plugins/civicrm/civicrm.php(1199): CRM_Core_Invoke::invoke()
#32 /home/members/mysite/sites/crm.mysite.org/web/wp-includes/class-wp-hook.php(310): CiviCRM_For_WordPress->invoke()
#33 /home/members/mysite/sites/crm.mysite.org/web/wp-includes/class-wp-hook.php(334): WP_Hook->apply_filters()
#34 /home/members/mysite/sites/crm.mysite.org/web/wp-includes/plugin.php(517): WP_Hook->do_action()
#35 /home/members/mysite/sites/crm.mysite.org/web/wp-admin/admin.php(259): do_action()
#36 {main}
```5.68.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/4708Memberships by relationship are not created on contact merge2023-10-23T20:45:46ZbrienneMemberships by relationship are not created on contact mergeOverview
----------------------------------------
If two contacts are merged and one has an active membership and the other has active relationships, memberships by relationship are not created for the related contacts.
Reproduction st...Overview
----------------------------------------
If two contacts are merged and one has an active membership and the other has active relationships, memberships by relationship are not created for the related contacts.
Reproduction steps
----------------------------------------
1. Create (or find) two Organization Contacts
* one should have a membership
* one should have at least one relationship of Type 'Employer of'
1. Merge the two Organizations
1. Note that the merged contact has the membership and the relationship, but that the related contact does not have a membership by relationship
Current behaviour
----------------------------------------
Memberships by relationship are not being created for related contacts after a contact merge.
Expected behaviour
----------------------------------------
When contacts with memberships and relationships- such as of Type 'Employer of' - are merged, memberships by relationship should be created for the relevant contacts- i.e. whatever function gets called to create a membership by relationship should be called after contacts are merged, if that contact has a membership.
Environment information
----------------------------------------
* __CiviCRM:__ 5.66https://lab.civicrm.org/dev/core/-/issues/4707[PHP 8.0+?] Empty requires tag in info.xml crashes extension list2023-10-23T20:45:38Zjofranzfranz@systopia.de[PHP 8.0+?] Empty requires tag in info.xml crashes extension listOverview
----------------------------------------
This seems to be working fine on PHP 7.4 tho.
Reproduction steps
----------------------------------------
1. Having an [empty requires tag](https://github.com/Project60/org.project60.mem...Overview
----------------------------------------
This seems to be working fine on PHP 7.4 tho.
Reproduction steps
----------------------------------------
1. Having an [empty requires tag](https://github.com/Project60/org.project60.membership/pull/68/files)
1. Go to: `.../civicrm/admin/extensions?reset=1`
1. See an empty page? Not sure as I have [whoops](https://filp.github.io/whoops/) enabled
Current behaviour
----------------------------------------
```
array_intersect(): Argument #1 ($array) must be of type array, string given
```
Expected behaviour
----------------------------------------
Empty tags should be ignored
Environment information
----------------------------------------
* __Browser:__ _Firefox_
* __CiviCRM:__ _5.65.2_
* __PHP:__ _8.1 (works on 7.4)_
* __CMS:__ _Drupal 9.5.11_
* __Database:__ _Yes :)_
* __Web Server:__ _Apache 2_5.67.0https://lab.civicrm.org/dev/core/-/issues/4703Saving a group definition lose the current parent groups2023-10-25T20:49:32ZsamuelsovSaving a group definition lose the current parent groupsTo reproduce:
1. edit a group, add a parent, save -> all good
1. edit a group, don't touch the parent, save -> the parent is lost
Was working in 5.60, doesn't work anymore since at least 5.65 and reproduced in https://dmaster.demo.civic...To reproduce:
1. edit a group, add a parent, save -> all good
1. edit a group, don't touch the parent, save -> the parent is lost
Was working in 5.60, doesn't work anymore since at least 5.65 and reproduced in https://dmaster.demo.civicrm.org5.66.1https://lab.civicrm.org/dev/core/-/issues/4697Standalone: civicrm/user path conflicts with existing path to user dashboard2023-11-29T02:10:00ZcolemanwStandalone: civicrm/user path conflicts with existing path to user dashboardThe path `civicrm/user` is declared by the Standalone extension, but it was already in use by core.
See https://lab.civicrm.org/dev/core/-/blob/f04bfacb5ed5131c9d29e8a9c0725c3059caeef0/CRM/Core/xml/Menu/Contact.xml#L213-218The path `civicrm/user` is declared by the Standalone extension, but it was already in use by core.
See https://lab.civicrm.org/dev/core/-/blob/f04bfacb5ed5131c9d29e8a9c0725c3059caeef0/CRM/Core/xml/Menu/Contact.xml#L213-218https://lab.civicrm.org/dev/core/-/issues/4695Deprecated function: Optional parameter $from declared before required parame...2024-01-05T03:43:07ZAndrew WassonDeprecated function: Optional parameter $from declared before required parameter $element## Overview
Deprecated function: Optional parameter $from declared before required parameter $element is implicitly treated as a required parameter in require_once() (line 19 of /sites/all/modules/civicrm/drupal/modules/civicrm_rules/ci...## Overview
Deprecated function: Optional parameter $from declared before required parameter $element is implicitly treated as a required parameter in require_once() (line 19 of /sites/all/modules/civicrm/drupal/modules/civicrm_rules/civicrm_rules.rules.inc).
The deprecated error issue is related to two files in the civicrm_rules sub module.
* line 20 of /civicrm/drupal/modules/civicrm_rules/civicrm_rules.mailing-eval.inc
* line 27 of civicrm/drupal/modules/civicrm_rules/civicrm_rules.contact-eval.inc
_This issue is referenced at:_ https://lab.civicrm.org/dev/core/-/issues/3958#note_152174
## Reproduction steps
1. Provision a new Drupal 7 / CiviCRM site on PHP 8.2 or change an existing site to PHP 8.2
2. Got an error "**Fatal error: Deprecated function: Optional parameter $from declared before required parameter $element is implicitly treated as a required parameter in require_once() (line 19 of /sites/all/modules/civicrm/drupal/modules/civicrm_rules/civicrm\_****rules.rules.inc****).**".
## Environment information
* **CiviCRM:** version 5.66.0 (any version)
* **PHP:** _8.2.x_
* **CMS:** Drupal 7.98 (any Drupal 7 version)
* **Database:** _MySQL 5.7.7/MariaDB 10.4/..._
* **Web Server:** _Apache 2.4/Nginx 1.16/..._
## Comments
The fix is to set the optional parameter $from = NULL to string $from = NULL.
* The sites where I have found this issue all use the Drupal Rules module so this may not impact sites that don't use Drupal Rules in their workflow.
I will create a PR shortly.5.68.0https://lab.civicrm.org/dev/core/-/issues/4692Clone command at Manage Contribution Pages doesn't work2023-11-23T07:51:00ZUpperholmeClone command at Manage Contribution Pages doesn't workOverview
----------------------------------------
On the 'Manage Contribution Pages' page at /civicrm/admin/contribute?reset=1 - which is now a packaged search made with Searchkit, there is an option to Clone any listed contribution page...Overview
----------------------------------------
On the 'Manage Contribution Pages' page at /civicrm/admin/contribute?reset=1 - which is now a packaged search made with Searchkit, there is an option to Clone any listed contribution page. Clicking the 'clone' button should presumably refresh the page view and show the user the new list of contribution pages, including the freshly cloned page.
Clicking the button certainly appears to rebuild the page, but no new contribution page is listed. refreshing the page doesn't help, so I'm assuming no new contribution page is created.
Reproduction steps
----------------------------------------
1. Go to 'Manage Contribution Pages' /civicrm/admin/contribute?reset=1
1. Click on the 'clone' button against any listed page.
1. View the refreshed list of pages, which does not include any cloned page.
Expected behaviour
----------------------------------------
I would expect to see my new page, with a name like 'clone of whatever the old page was called'.
Environment information
----------------------------------------
Repeatable in both Firefox and Safari, and on dmaster.https://lab.civicrm.org/dev/core/-/issues/4640Site Crash after creating custom EntityReference field for Organizations2023-10-22T02:26:56ZJustin657Site Crash after creating custom EntityReference field for OrganizationsOverview
----------------------------------------
Today I managed to inadvertently take down the [dmaster](https://dmaster.demo.civicrm.org/) and [d10-master](https://d10-master.demo.civicrm.org/) CiviCRM demo sites by creating a custom ...Overview
----------------------------------------
Today I managed to inadvertently take down the [dmaster](https://dmaster.demo.civicrm.org/) and [d10-master](https://d10-master.demo.civicrm.org/) CiviCRM demo sites by creating a custom field of DataType=EntityReference and Entity=Organizations.
Those sites were running CiviCRM version 5.67.alpha1.
Reproduction steps
----------------------------------------
1. Create a new custom field, set Data Type = *Entity Reference* and Entity = *Organizations*.
2. When you click Save, the site crashes.
Current behaviour
----------------------------------------
The error thrown after clicking save on this page:
https://d10-master.demo.civicrm.org/civicrm/admin/custom/group/fields
```
The website encountered an unexpected error. Please try again later.
TypeError: CRM_Core_DAO_AllCoreTables::getTableForEntityName(): Return value must be of type string, null returned in CRM_Core_DAO_AllCoreTables::getTableForEntityName() (line 365 of /srv/buildkit/build/d10-master/vendor/civicrm/civicrm-core/CRM/Core/DAO/AllCoreTables.php).
Civi\Api4\Service\Schema\SchemaMapBuilder->addCustomFields() (Line: 73)
Civi\Api4\Service\Schema\SchemaMapBuilder->loadTables() (Line: 51)
Civi\Api4\Service\Schema\SchemaMapBuilder->build() (Line: 286)
Civi\Api4\Utils\CoreUtil::getSchemaMap() (Line: 772)
Civi\Api4\Query\Api4SelectQuery->autoJoinFK() (Line: 393)
Civi\Api4\Query\Api4SelectQuery->getField() (Line: 312)
Civi\Api4\Query\Api4SelectQuery->fillEntityValues() (Line: 83)
Civi\Api4\Query\Api4SelectQuery->__construct() (Line: 106)
Civi\Api4\Generic\DAOGetAction->getObjects() (Line: 94)
Civi\Api4\Generic\DAOGetAction->_run() (Line: 72)
Civi\Api4\Provider\ActionObjectProvider->invoke() (Line: 156)
Civi\API\Kernel->runRequest() (Line: 256)
Civi\Api4\Generic\AbstractAction->execute() (Line: 51)
Civi\Search\AfformSearchMetadataInjector::Civi\Search\{closure}()
call_user_func() (Line: 59)
Civi\Angular\ChangeSet::applyHtmlFilters() (Line: 19)
Civi\Angular\ChangeSet::applyResourceFilters() (Line: 295)
Civi\Angular\Manager->getPartials() (Line: 160)
Civi\Angular\Page\Modules->getMetadata() (Line: 82)
Civi\Angular\Page\Modules::buildAngularModules() (Line: 220)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 263)
Civi\Core\CiviEventDispatcher->dispatch() (Line: 168)
CRM_Utils_Hook->invoke() (Line: 2782)
CRM_Utils_Hook::buildAsset() (Line: 226)
Civi\Core\AssetBuilder->render() (Line: 198)
Civi\Core\AssetBuilder->build() (Line: 136)
Civi\Core\AssetBuilder->getUrl() (Line: 169)
Civi\Angular\AngularLoader->Civi\Angular\{closure}() (Line: 394)
CRM_Core_Region->getSettings() (Line: 142)
CRM_Core_Region->{closure}() (Line: 157)
CRM_Core_Region->render() (Line: 37)
civicrm_page_attachments() (Line: 311)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 388)
Drupal\Core\Extension\ModuleHandler->invokeAllWith() (Line: 312)
Drupal\Core\Render\MainContent\HtmlRenderer->invokePageAttachmentHooks() (Line: 285)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 286)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare() (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
call_user_func() (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (Line: 187)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 704)
Drupal\Core\DrupalKernel->handle() (Line: 19)
```
Expected behaviour
----------------------------------------
It should save the custom field and return to the list of fields in the custom field set.
Environment information
----------------------------------------
* __CiviCRM:__ 5.67.alpha1