Development issueshttps://lab.civicrm.org/groups/dev/-/issues2020-12-12T09:47:07Zhttps://lab.civicrm.org/dev/core/-/issues/2232upgrade can't find service2020-12-12T09:47:07Zeileenupgrade can't find service@totten @kcristiano @christianwach I just upgraded a wordpress site (from 5.31 to 5.32) and on trying to go to the home page hit this.
I feel like this might be the second report of issues like this on a wordpress site (@justinfreeman r...@totten @kcristiano @christianwach I just upgraded a wordpress site (from 5.31 to 5.32) and on trying to go to the home page hit this.
I feel like this might be the second report of issues like this on a wordpress site (@justinfreeman reported one tied with flexmailer #2191 ) where some loading order seems to get jumbled. In addition Justin has reported 2 other issues recently (presumably also on wordpress) which imply that he is seeing issues on wordpress where core and extension setting metadata is not present on some upgraded sites - I wonder if there is a hook order issue
![Screenshot_from_2020-12-05_11-45-07](/uploads/03786193703bc8540bdad33edfaf2f39/Screenshot_from_2020-12-05_11-45-07.png)5.32.2https://lab.civicrm.org/dev/core/-/issues/2226Scheduled Reminder fails to send if From Name includes comma2021-03-22T04:47:07ZlarsssandergreenScheduled Reminder fails to send if From Name includes commaOverview
----------------------------------------
Including a comma in the From Name for a Scheduled Reminder prevents the reminder from being sent. If you run the cron job manually, you'll see an error message, and no emails will be sen...Overview
----------------------------------------
Including a comma in the From Name for a Scheduled Reminder prevents the reminder from being sent. If you run the cron job manually, you'll see an error message, and no emails will be sent. If you don't run cron manually, you won't know that the emails have not been sent. Enclosing the email From Name in double quotes prevents the issue.
Reproduction steps
----------------------------------------
1. Create new scheduled reminder with the From Name containing a ",".
2. Run cron job
Current behaviour
----------------------------------------
![Screen_Shot_2020-12-01_at_6.05.19_PM](/uploads/c515661f1182092f65cbcf172b562544/Screen_Shot_2020-12-01_at_6.05.19_PM.png)
Expected behaviour
----------------------------------------
Email should be sent.
Environment information
----------------------------------------
5.28 on Drupal 7.75
Comments
----------------------------------------
I believe the fix is simply to check the From Name for double quotes and add them if missing. A similar field for contribution page receipts appears to work fine with commas in the From Name, so I suspect this is in place there.5.37.0Monish DebMonish Debhttps://lab.civicrm.org/dev/financial/-/issues/159Line items are added from default price set on recurring contributions for fi...2022-12-14T00:35:14ZFrancis (Agileware)Line items are added from default price set on recurring contributions for financial types with tax accounts.# Steps to reproduce, verified on dmaster.demo.civicrm.org
1. Create a Membership type with required autorenewal
2. Enable Tax & Invoicing
3. Create a Sales Tax account, at any rate, and assign it to the "Member Dues" Financial type.
4....# Steps to reproduce, verified on dmaster.demo.civicrm.org
1. Create a Membership type with required autorenewal
2. Enable Tax & Invoicing
3. Create a Sales Tax account, at any rate, and assign it to the "Member Dues" Financial type.
4. Configure a Contribution Page to sign up for the membership, using the "Member Dues" Financial type.
5. Sign up for a membership using the Contribution page.
6. Using the created recurring contribution id, call the Contribution.repeattransaction API to simulate the membership autorenewal like a payment processor supporting recurring contributions
7. Inspect the resulting contribution records using the Order.get API
# Expected Results
Two orders that are identical apart from dates and IDs
# Actual Results
The second order has two line items. The second line item will be for the price field in the default price set (field 1 / set 1 unless you've somehow changed it), and will be for the same amount as the total of the contribution.
On additional attempts to repeat the transaction, the system crashes due to a DB constraint violation and *rolls back the database transaction, losing the records of any contributions processed so far.*
# Why does this happen?
When `CRM_Contribute_BAO_Contribution::add` calls `CRM_Contribute_BAO_Contribution::checkTaxAmount`, this method checks if the financial type has tax applied and calls `CRM_Price_BAO_LineItem::getLineItemArray` if so, regardless of whether there are any line items already.
# Proposed Solution
Move the calls to `CRM_Price_BAO_LineItem::getLineItemArray` out of `CRM_Contribute_BAO_Contribution::checkTaxAmount` and into `CRM_Contribute_BAO_Contribution::add`, and **only** call it if there's no line_item array present already. See discussion at https://chat.civicrm.org/civicrm/pl/9iuqyx9fp3dexnupuxfefsj4ke
Agileware Ref: CIVICRM-16175.34.0https://lab.civicrm.org/dev/financial/-/issues/158Wording change - change UI parts of contribution soft schema to soft credit2020-12-12T00:21:24ZeileenWording change - change UI parts of contribution soft schema to soft creditThrough out the ContributionSoft.xml fields are referred to as 'Contribution Soft x' but in the UI we normally use 'Soft Credit'
When exposing these fields through Search Kit/ Afform / Metadata based functions I believe 'Soft Credit' is...Through out the ContributionSoft.xml fields are referred to as 'Contribution Soft x' but in the UI we normally use 'Soft Credit'
When exposing these fields through Search Kit/ Afform / Metadata based functions I believe 'Soft Credit' is more meaningful5.34.0https://lab.civicrm.org/dev/core/-/issues/2217Prevent "add_action" from being called multiple times2020-12-06T22:03:10ZhaystackPrevent "add_action" from being called multiple timesIt came to my attention that `CRM_Utils_System_WordPress::addHTMLHead()` can potentially add multiple callbacks to `wp_head` and/or `admin_head` [because `$registered` is never set](https://lab.civicrm.org/dev/core/-/blob/master/CRM/Util...It came to my attention that `CRM_Utils_System_WordPress::addHTMLHead()` can potentially add multiple callbacks to `wp_head` and/or `admin_head` [because `$registered` is never set](https://lab.civicrm.org/dev/core/-/blob/master/CRM/Utils/System/WordPress.php#L268-274). PR to follow.5.34.0haystackhaystackhttps://lab.civicrm.org/dev/core/-/issues/2213Upgrade CiviCRM 5.28.3 to 5.30.0 with Clean URLs and WordPress Base Page "Civ...2020-12-03T22:20:10Zjustinfreeman (Agileware)Upgrade CiviCRM 5.28.3 to 5.30.0 with Clean URLs and WordPress Base Page "CiviCRM" breaks Mosaico IMG URLs and Email Tracked URLsThis has been observed on a CiviCRM and WordPress site. After upgrading from CiviCRM 5.28.3 to 5.30.0 with Clean URLs and WordPress Base Page "CiviCRM" we received reports that Mosaico IMG URLs and Email Tracked URLs were both broken. Th...This has been observed on a CiviCRM and WordPress site. After upgrading from CiviCRM 5.28.3 to 5.30.0 with Clean URLs and WordPress Base Page "CiviCRM" we received reports that Mosaico IMG URLs and Email Tracked URLs were both broken. This was confirmed as those URLs were returning 404s.
This was an old site and noted that the CiviCRM WordPress Base Page option was set to "CiviCRM". After changing the WordPress Base Page option to "civicrm" the Mosaico IMG URLs and Email Tracked URLs resolved correctly, no more 404s.
Was unable to reproduce this same problem on existing CiviCRM 5.31.0 and WordPress site, toggling the CiviCRM WordPress Base Page option from "civicrm" to "CiviCRM" did not result in 404 errors.
**Solution**
1. Find the WordPress page for CiviCRM, note the **Slug** part of the **Permalink** for this page eg. Permalink is https://test.com/civicrm then the Slug is **civicrm**
2. Go to CiviCRM, Administration, **CMS Database Integration**.
3. Change **CMS Database Integration** option to match the **Slug** part of the **Permalink**. eg. **civicrm**
4. Click **Save**.
5. Crack open a beer and **test**.
Agileware Ref: CIVICRM-16135.32.0https://lab.civicrm.org/dev/drupal/-/issues/149D8/D9 Fix Session Start Handling2020-11-30T23:13:25ZseamusleeD8/D9 Fix Session Start HandlingAt present because there is no override in the Drupal8 system class, the DrupalBase SessionStart function is used instead which uses functions and session related code that is not suitable for Drupal8 and can cause Session Already Starte...At present because there is no override in the Drupal8 system class, the DrupalBase SessionStart function is used instead which uses functions and session related code that is not suitable for Drupal8 and can cause Session Already Started notices in watchdog if you use cron.php to execute your cron job.5.33.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2211Export crashes when many contacts share an address and are merged2020-12-15T19:27:08ZlarynExport crashes when many contacts share an address and are mergedWhen many contacts have matching addresses, exporting them and selecting "Merge All Contacts with the Same Address" crashes cryptically with the "sorry the system is unavailable right now" error. It turns out many addressees combined can...When many contacts have matching addresses, exporting them and selecting "Merge All Contacts with the Same Address" crashes cryptically with the "sorry the system is unavailable right now" error. It turns out many addressees combined can exceed the "Addressee" column limits in the temporary search/export table.
> [nativecode=1406 ** Data too long for column 'addressee' at row 1]5.34.0https://lab.civicrm.org/dev/drupal/-/issues/148When creating Premium - requiring subscription even for "physical" premiums2020-12-02T20:14:25ZplanetwebbWhen creating Premium - requiring subscription even for "physical" premiumsWhen trying to add a new Premium (first one), I get the error "Please enter a Period Type" - even though the premium is a regular "product" and not a subscription.
Civi 5.31 / Drupal 7.73 / PHP 7.3
It has been reproduced by another us...When trying to add a new Premium (first one), I get the error "Please enter a Period Type" - even though the premium is a regular "product" and not a subscription.
Civi 5.31 / Drupal 7.73 / PHP 7.3
It has been reproduced by another user with 5.31, his workaround is to submit dummy subscription info just to submit.
![Screen_Shot_2020-11-20_at_10.08.59_AM](/uploads/8ae8ed5da027f8fd5e550f3ea5185971/Screen_Shot_2020-11-20_at_10.08.59_AM.png)5.32.0https://lab.civicrm.org/dev/core/-/issues/2204Proposal - make 5.33 the last CiviCRM version to support php 7.1 (agreed) and...2021-02-05T06:10:18ZeileenProposal - make 5.33 the last CiviCRM version to support php 7.1 (agreed) and mysql 5.6 (deferred) (& equivalent MariaDB version)This extracts from our end-of-life planning for old mysql versions
https://lab.civicrm.org/dev/core/-/issues/1681 and php versions https://lab.civicrm.org/dev/core/-/issues/1528 and makes the proposal that the 5.33 ESR is the last versi...This extracts from our end-of-life planning for old mysql versions
https://lab.civicrm.org/dev/core/-/issues/1681 and php versions https://lab.civicrm.org/dev/core/-/issues/1528 and makes the proposal that the 5.33 ESR is the last version to support php 7.1 and mysql 5.6. This means that sites can get up to 8 more months support on these versions for $120.
Background/ notes
- we have aligned recent end of life for php & mysql versions with ESR versions because it means that if there is an economic value to delaying upgrading people can opt in. If $120 doesn't seem like value for money then it's hard to make the case it is worth $x in developer time
- we have been announcing that both are EOL for ? 6 months? via system checks
- we haven't had a lot of push back from sites about previous EOL efforts on php versions. Generally once we stop supporting a php version there are a reasonable amount of breaking changes after the first 2-3 months
- we had annecdotal evidence from 2 partners that getting off mysql 5.5 was tricky for some sites. OTOH there are unlikely to be any breaking changes for quite some time for 5.6 sites for quite some time. It's likely they could continue to use 5.6 for a year or more after we stop supporting it - we just get to say 'sorry not supported' when those weird edge cases pop up around row format or it there is some unforseen reason for a breaking change
- mysql 8.0 is about to be released
- php 8.0 is about to be released
- generally our ability to support newer mysql versions / php versions has been delayed by difficulties around legacy support and we have effectively supported old versions at the expense of newer versions
- php stopped supporting php 7.1 about a year ago
- Oracle still appears to support php 5.6 (not sure if it's for free or not)5.34.0https://lab.civicrm.org/dev/core/-/issues/2203"Resource URL" help text incorrect2020-12-06T22:04:52Zdarren.woods"Resource URL" help text incorrectThe help text for "Resource URL" still says the absolute URL should be used, which then leads to errors.
> Resource URL
> Absolute URL of the location where the civicrm module or component has been installed.
> Example
> If your site's ...The help text for "Resource URL" still says the absolute URL should be used, which then leads to errors.
> Resource URL
> Absolute URL of the location where the civicrm module or component has been installed.
> Example
> If your site's home url is http://www.example.com/ ... then your CiviCRM Resource URL would be:
> http://www.example.com/
Suggest the shortcodes are added to this guidance, i.e. "[civicrm.root]/" to prevent new users getting mislead.5.33.0https://lab.civicrm.org/dev/drupal/-/issues/147Drupal's permission page does not show descriptions2021-02-02T00:50:16ZfkohrtDrupal's permission page does not show descriptionsCiviCRM 5.31 on Drupal 8 allows in the web UI at `/admin/people/permissions` to configure permissions. But all the CiviCRM permissions show up without their [descriptions](https://lab.civicrm.org/dev/core/-/blob/master/CRM/Core/Permissio...CiviCRM 5.31 on Drupal 8 allows in the web UI at `/admin/people/permissions` to configure permissions. But all the CiviCRM permissions show up without their [descriptions](https://lab.civicrm.org/dev/core/-/blob/master/CRM/Core/Permission.php), which makes it harder to figure out the ones I need. It doesn't help to click _Hide descriptions_ and then _Show descriptions_. This has not been an issue for CiviCRM 5.17 on Drupal 7.5.33.0https://lab.civicrm.org/dev/core/-/issues/2199Add pre() and post() hooks for ufgroup2020-12-23T07:46:00Zlucky091588Add pre() and post() hooks for ufgroupI will add a pre() and post() hooks for ufgroup. I will create a PR and will submit it soon.I will add a pre() and post() hooks for ufgroup. I will create a PR and will submit it soon.5.34.0https://lab.civicrm.org/dev/core/-/issues/2198CiviMail "DB error": suspected core bug relating to attachment replace api2022-09-25T16:43:26ZedwardpetersCiviMail "DB error": suspected core bug relating to attachment replace apiOverview
----------------------------------------
In CiviMail, trying to send a Test mailing gives "Error - DB error - unknown error" on screen, see screenshot, and mail cannot be sent. Seems to be triggered by attachment replace api.
![...Overview
----------------------------------------
In CiviMail, trying to send a Test mailing gives "Error - DB error - unknown error" on screen, see screenshot, and mail cannot be sent. Seems to be triggered by attachment replace api.
![DBerror](/uploads/ae853f717ef1eecd051b826ff91b20de/DBerror.png)
Reproduction steps
----------------------------------------
1. Mailing -> New Mailing
2. Proceed to mailing template (I am using Mosaico) and try to send a Test.
Current behaviour
----------------------------------------
Error in the Civi Log is:
```
Nov 17 12:28:40 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => exceptionHandler
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not exist]
[type] => DB_Error
[user_info] => ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not exist]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::exceptionHandler prefix="" info="ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not exist]"]
)
Nov 17 12:28:40 [debug] $backTrace = #0 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Error.php(942): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /home/sclgulf/public_html/sclgulf/vendor/pear/pear-core-minimal/src/PEAR.php(944): CRM_Core_Error::exceptionHandler(Object(DB_Error))
#2 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB.php(977): PEAR_Error->__construct("DB Error: unknown error", -1, 16, (Array:2), "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...")
#3 /home/sclgulf/public_html/sclgulf/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-1, 16, (Array:2), "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...")
#4 /home/sclgulf/public_html/sclgulf/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -1, 16, (Array:2), "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...", "DB_Error", TRUE)
#5 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/common.php(1913): PEAR->__call("raiseError", (Array:7))
#6 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/mysqli.php(932): DB_common->raiseError(-1, NULL, NULL, "ROLLBACK TO SAVEPOINT civi_0 [nativecode=1305 ** SAVEPOINT civi_0 does not ex...", "1305 ** SAVEPOINT civi_0 does not exist")
#7 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/mysqli.php(402): DB_mysqli->mysqliRaiseError()
#8 /home/sclgulf/public_html/sclgulf/vendor/pear/db/DB/common.php(1219): DB_mysqli->simpleQuery("ROLLBACK TO SAVEPOINT civi_0")
#9 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/packages/DB/DataObject.php(2696): DB_common->query("ROLLBACK TO SAVEPOINT civi_0")
#10 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/packages/DB/DataObject.php(1829): DB_DataObject->_query("ROLLBACK TO SAVEPOINT civi_0")
#11 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/DAO.php(445): DB_DataObject->query("ROLLBACK TO SAVEPOINT civi_0")
#12 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/Core/Transaction/Frame.php(153): CRM_Core_DAO->query("ROLLBACK TO SAVEPOINT civi_0")
#13 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/Core/Transaction/Manager.php(103): Civi\Core\Transaction\Frame->finish()
#14 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Transaction.php(126): Civi\Core\Transaction\Manager->dec()
#15 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Transaction.php(175): CRM_Core_Transaction->commit()
#16 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Subscriber/DynamicFKAuthorization.php(240): CRM_Core_Transaction->run(Object(Closure))
#17 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Subscriber/DynamicFKAuthorization.php(181): Civi\API\Subscriber\DynamicFKAuthorization->authorizeDelegate("get", "civicrm_mailing", "130", (Array:8))
#18 /home/sclgulf/public_html/sclgulf/vendor/symfony/event-dispatcher/EventDispatcher.php(214): Civi\API\Subscriber\DynamicFKAuthorization->onApiAuthorize(Object(Civi\API\Event\AuthorizeEvent), "civi.api.authorize", Object(Civi\Core\CiviEventDispatcher))
#19 /home/sclgulf/public_html/sclgulf/vendor/symfony/event-dispatcher/EventDispatcher.php(44): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch((Array:5), "civi.api.authorize", Object(Civi\API\Event\AuthorizeEvent))
#20 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/Core/CiviEventDispatcher.php(129): Symfony\Component\EventDispatcher\EventDispatcher->dispatch("civi.api.authorize", Object(Civi\API\Event\AuthorizeEvent))
#21 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(219): Civi\Core\CiviEventDispatcher->dispatch("civi.api.authorize", Object(Civi\API\Event\AuthorizeEvent))
#22 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(148): Civi\API\Kernel->authorize(Object(Civi\API\Provider\MagicFunctionProvider), (Array:8))
#23 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest((Array:8))
#24 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/api.php(22): Civi\API\Kernel->runSafe("Attachment", "get", (Array:4))
#25 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/v3/utils.php(1800): civicrm_api("Attachment", "get", (Array:4), (Array:5))
#26 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/v3/Generic.php(398): _civicrm_api3_generic_replace("Attachment", (Array:5))
#27 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Provider/MagicFunctionProvider.php(85): civicrm_api3_generic_replace((Array:8))
#28 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(150): Civi\API\Provider\MagicFunctionProvider->invoke((Array:8))
#29 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest((Array:8))
#30 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/api/api.php(22): Civi\API\Kernel->runSafe("Attachment", "replace", (Array:5))
#31 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Utils/REST.php(300): civicrm_api("Attachment", "replace", (Array:5))
#32 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Utils/REST.php(550): CRM_Utils_REST::process((Array:3), (Array:5))
#33 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(278): CRM_Utils_REST::ajax()
#34 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(68): CRM_Core_Invoke::runItem((Array:12))
#35 /home/sclgulf/public_html/sclgulf/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
#36 /home/sclgulf/public_html/sclgulf/web/modules/contrib/civicrm/src/Civicrm.php(88): CRM_Core_Invoke::invoke((Array:3))
#37 /home/sclgulf/public_html/sclgulf/web/modules/contrib/civicrm/src/Controller/CivicrmController.php(80): Drupal\civicrm\Civicrm->invoke((Array:3))
#38 [internal function](): Drupal\civicrm\Controller\CivicrmController->main((Array:3), "")
#39 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array((Array:2), (Array:2))
#40 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#41 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#42 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext((Array:2), (Array:2))
#43 /home/sclgulf/public_html/sclgulf/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#44 /home/sclgulf/public_html/sclgulf/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#45 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#46 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#47 /home/sclgulf/public_html/sclgulf/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#48 /home/sclgulf/public_html/sclgulf/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#49 /home/sclgulf/public_html/sclgulf/web/modules/contrib/shield/src/ShieldMiddleware.php(91): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#50 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\shield\ShieldMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#51 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#52 /home/sclgulf/public_html/sclgulf/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#53 /home/sclgulf/public_html/sclgulf/web/core/lib/Drupal/Core/DrupalKernel.php(708): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, TRUE)
#54 /home/sclgulf/public_html/sclgulf/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#55 {main}
```
Expected behaviour
----------------------------------------
Test mailing gets sent
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Safari 14.0.1_
* __CiviCRM:__ 5.29.0
* __PHP:__ _7.3__
* __CMS:__ _Drupal 8.96_
* __Database:__ _5.5.5-10.3.27-MariaDB_
* __Web Server:__ _Apache_
Comments
----------------------------------------
My developer says he thinks it is a core bug. "the error seems to be around transaction and how it's being rollbacked".
He has done a temporary patch so that mailings can get sent:
```
[~/www/sclgulf/vendor/civicrm/civicrm-core/api/v3]# diff utils.php utils.php.orig
1800,1805c1800,1803
< if ($entity != 'Attachment') {
< $preexisting = civicrm_api($entity, 'get', $baseParams, $params);
< if (civicrm_error($preexisting)) {
< $transaction->rollback();
< return $preexisting;
< }
---
> $preexisting = civicrm_api($entity, 'get', $baseParams, $params);
> if (civicrm_error($preexisting)) {
> $transaction->rollback();
> return $preexisting;
```5.52.0https://lab.civicrm.org/dev/core/-/issues/2197afform_html - Include Monaco dependencies2020-11-19T04:54:20Ztottenafform_html - Include Monaco dependenciesOverview
----------------------------------------
The extension `afform_html` has a dependency on Monaco, but it's not included by default with either (a) tarballs or (b) civibuild sites.
Reproduction steps
----------------------------...Overview
----------------------------------------
The extension `afform_html` has a dependency on Monaco, but it's not included by default with either (a) tarballs or (b) civibuild sites.
Reproduction steps
----------------------------------------
1. Enable core extension `afform_html`
2. View system status
Current behaviour
----------------------------------------
See a warning that the `node_modules` are missing.
Expected behaviour
----------------------------------------
Don't show a warning. Instead, the Monaco JS should be available by default.5.33.0https://lab.civicrm.org/dev/core/-/issues/2194Email sent to primary email if non primary email field is included on the reg...2021-10-07T21:42:51ZjitendraEmail sent to primary email if non primary email field is included on the registration pageTo replicate
- Create a profile with Fname, Lname, Email (non primary loc type).
- Use this on an event registration page.
- Now, if a user registers on this event and enters a value in the email field, the invoice is sent to the primar...To replicate
- Create a profile with Fname, Lname, Email (non primary loc type).
- Use this on an event registration page.
- Now, if a user registers on this event and enters a value in the email field, the invoice is sent to the primary email stored in civicrm. Not on the email which was entered while registering.
**Step 1**
![image](/uploads/b15adeab947da8b7435317eac4c2ce86/image.png)
**Step 2**
Thankyou page confirms that the email was sent to the primary address.
![Screenshot_2020-11-17_at_3.56.44_PM](/uploads/4d242f534eac5d118128312b927620e4/Screenshot_2020-11-17_at_3.56.44_PM.jpg)5.43.0https://lab.civicrm.org/dev/wordpress/-/issues/82Cannot create a WordPress account from the Contact record2021-10-16T08:08:01ZbgmCannot create a WordPress account from the Contact recordTo reproduce:
* As a WP admin, create a new contact record that has an email
* Click on the Actions menu
Expected: an option to create a new CMS account for this contact.
References:
* https://civicrm.stackexchange.com/questions/9092...To reproduce:
* As a WP admin, create a new contact record that has an email
* Click on the Actions menu
Expected: an option to create a new CMS account for this contact.
References:
* https://civicrm.stackexchange.com/questions/9092/wordpress-creating-new-wp-users-from-civi-contacts5.37.0https://lab.civicrm.org/dev/core/-/issues/2191CiviCRM 5.31 post upgrade errors, You have requested a non-existent service "...2020-12-11T02:13:06Zjustinfreeman (Agileware)CiviCRM 5.31 post upgrade errors, You have requested a non-existent service "mosaico_graphics"; You have requested a non-existent service "civi_flexmailer_required_tokens"; Unrecognized value for setting 'flexmailer_traditional'.Just a FYI that we are seeing this CiviCRM 5.31 post upgrade errors, You have requested a non-existent service "mosaico_graphics" and You have requested a non-existent service "civi_flexmailer_required_tokens". Also see the following err...Just a FYI that we are seeing this CiviCRM 5.31 post upgrade errors, You have requested a non-existent service "mosaico_graphics" and You have requested a non-existent service "civi_flexmailer_required_tokens". Also see the following error message: Unrecognized value for setting 'flexmailer_traditional'.
![Screenshot_20201126_105000](/uploads/7b78860515b992cfc898fc7bcfab7e82/Screenshot_20201126_105000.png)
![Screenshot_20201126_104951](/uploads/9addf493d0c9fc3c8b2e649e50b2c81e/Screenshot_20201126_104951.png)
Causes final step of the upgrade process to result in an error:
There has been a critical error on your website. Please check your site admin email inbox for instructions.
Learn more about debugging in WordPress.
And then this error message is displayed intermittently whilst navigating CiviCRM pages.
Error is output as response to all AJAX requests as the JSON payload, HTML error response which breaks that functionality.
Solution is to:
1. Visit the Administer CiviCRM, Flexmailer Settings and re-save the Flexmailer Settings.
2. Visit the Administer CiviCRM, Mosaico Settings page and saving
2. Clear the CiviCRM caches
Then CiviCRM pages should load normally.
Environment:
CiviCRM 5.31
WordPress 5.5.3
Agileware Ref: CIVICRM-1604 and CIVICRM-16125.32.2https://lab.civicrm.org/dev/core/-/issues/2190E_NOTICE when calling CRM_Core_BAO_SchemaHandler::createTable with logging tu...2020-11-17T21:07:10ZDaveDE_NOTICE when calling CRM_Core_BAO_SchemaHandler::createTable with logging turned on[These two lines](https://github.com/civicrm/civicrm-core/blob/d1eed91c218f4c285a535275e36732f68463824b/CRM/Logging/Schema.php#L818-L819) generate an E_NOTICE because `logTableSpec[$table]` doesn't exist yet.
A bigger question is wouldn...[These two lines](https://github.com/civicrm/civicrm-core/blob/d1eed91c218f4c285a535275e36732f68463824b/CRM/Logging/Schema.php#L818-L819) generate an E_NOTICE because `logTableSpec[$table]` doesn't exist yet.
A bigger question is wouldn't that always be missing since the table hasn't been created yet, so what's the point in even checking the existing value at all?
And why have the lines above that loop thru all the engines but then don't do anything with the resulting list? It looks like maybe it's just left over from when the engine was changed from ARCHIVE to INNODB.
PR coming - just deciding how deep I want to get into this.5.33.0https://lab.civicrm.org/dev/core/-/issues/2188Custom fields of type "Integer" with radio buttons can cause Advanced Search ...2021-01-07T03:26:26ZJonGoldCustom fields of type "Integer" with radio buttons can cause Advanced Search to break#### Steps to replicate
* Create a new custom field (via the UI) of type Integer, HTML Type of radio buttons.
* Set "Is Searchable" to "yes" and save.
* Visit Advanced Search.
#### Expected result
Advanced Search worked identically to b...#### Steps to replicate
* Create a new custom field (via the UI) of type Integer, HTML Type of radio buttons.
* Set "Is Searchable" to "yes" and save.
* Visit Advanced Search.
#### Expected result
Advanced Search worked identically to before the field was added.
#### Actual result
A JavaScript error:
```
Uncaught query function not defined for Select2 custom_9_from
```
The JS error will cause various parts of the form to stop working; the exact effect depends on the load order of the field in question. Select2 may stop working, accordions that load template snippets via AJAX may fail to open.
#### Technical Notes
The "Add Custom Field" form has a default for "Search by Range" set to "Yes", which is hidden by JS until someone sets "Is Searchable" to "Yes".
However, there's no widget to search by range on a multiple-choice field (it doesn't really make sense) so "Search by Range" remains hidden. Unfortunately, that means the field takes the default of "Yes". Advanced Search breaks because the widget doesn't exist.
This issue exists in master, but has existed at least as far back as 5.13.5.33.0JonGoldJonGold