Development issueshttps://lab.civicrm.org/groups/dev/-/issues2019-10-12T16:11:35Zhttps://lab.civicrm.org/dev/core/-/issues/1309Contribution Dashboard still uses broken Open Flash Charts2019-10-12T16:11:35ZeileenContribution Dashboard still uses broken Open Flash ChartsReplacement chart not rendering on Contribution Dashboard @artfulrobot promised to make it beautiful againReplacement chart not rendering on Contribution Dashboard @artfulrobot promised to make it beautiful again5.20.0RichRichhttps://lab.civicrm.org/dev/user-interface/-/issues/6Remove print icon2019-10-13T18:19:26ZnicolRemove print iconThis was raised by @smaen123 at #Summit19. There is an open #PR needing concept approval [on GH](https://github.com/civicrm/civicrm-core/pull/15322). @Kilakwabt mentioned another issue related to this he might want to elaborate on here o...This was raised by @smaen123 at #Summit19. There is an open #PR needing concept approval [on GH](https://github.com/civicrm/civicrm-core/pull/15322). @Kilakwabt mentioned another issue related to this he might want to elaborate on here or via security@civicrm.org depending on its current status.5.20.0https://lab.civicrm.org/dev/core/-/issues/764"This site can't be reached" error message2019-10-13T18:21:24Zteshale.wesene"This site can't be reached" error messageHi there,
I'm getting the above error message whenever I try to print mailing labels for clients. I've attached here a picture of the error message and I'd greatly appreciate it if you could please help me resolve this issue.
![Print_Ma...Hi there,
I'm getting the above error message whenever I try to print mailing labels for clients. I've attached here a picture of the error message and I'd greatly appreciate it if you could please help me resolve this issue.
![Print_Mailing_List_Error_Message](/uploads/eb69f6f7c98cb1395c906e4449e8831d/Print_Mailing_List_Error_Message.jpg)https://lab.civicrm.org/dev/core/-/issues/826Reports show " " in filters with child-groups2019-10-14T08:03:58ZCésarReports show " " in filters with child-groupsHi,
Im using CiviCRM 5.10.4 and I see in all reports ``` ``` when I use child-groups in filters.
![error_view](/uploads/7c72af518ab6a5c68ff00e0b21a4a7d3/error_view.png)Hi,
Im using CiviCRM 5.10.4 and I see in all reports ``` ``` when I use child-groups in filters.
![error_view](/uploads/7c72af518ab6a5c68ff00e0b21a4a7d3/error_view.png)https://lab.civicrm.org/dev/core/-/issues/870Add pre/post hooks for price set / field/option2019-10-14T17:55:01ZyashodhaAdd pre/post hooks for price set / field/optionAdd pre/post hooks for price set/field/option.Add pre/post hooks for price set/field/option.5.18.2yashodhayashodhahttps://lab.civicrm.org/dev/financial/-/issues/69Recording one payment against a "Pending (Incomplete Transaction)" results in...2019-10-15T06:15:33ZJonGoldRecording one payment against a "Pending (Incomplete Transaction)" results in two paymentsTo replicate:
* Create a pending contribution (via API, more on this below).
* Record a payment against the contribution.
* Note that two payments are created - one for the full amount, one for the partial amount.
I investigated why thi...To replicate:
* Create a pending contribution (via API, more on this below).
* Record a payment against the contribution.
* Note that two payments are created - one for the full amount, one for the partial amount.
I investigated why this didn't happen via the UI, and it's because the UI creates "Pending (Pay Later)" records. If you pass `is_pay_later = 1` via API, this bug doesn't occur.
The "Pending (Incomplete Transaction)" generates a record in `civicrm_financial_trxn`, which seems odd if the payment didn't happen - but if that IS correct, it should be consistent about whether it appears when you view payments in the UI.5.18.3https://lab.civicrm.org/dev/core/-/issues/1257Make Relationship Description searchable (Paid Feature2019-10-16T13:44:06Zfabian_SYSTOPIAMake Relationship Description searchable (Paid Feature**Overview**
Relationships provide a "description" field which is nicely displayed in the relationship tab of a contact. However, it is currently not possible to search for those descriptions using any regular CiviCRM search.
**Scope**...**Overview**
Relationships provide a "description" field which is nicely displayed in the relationship tab of a contact. However, it is currently not possible to search for those descriptions using any regular CiviCRM search.
**Scope**
User should have the possibility to search for contacts with certain descriptions in the relationship. The advanced search should offer a possibility to search for relationship descriptions.
**Note**
I originally posted this on CiviCRM's Jira but it probably git lost in migration so I am re-posting it here. We have a customer who may fund this so it would be great to get an estimate from the core team. We would be able to test the improvement.https://lab.civicrm.org/dev/core/-/issues/1295Per agreement in NYC sprint, add status check is_active to table2019-10-17T18:16:43ZeileenPer agreement in NYC sprint, add status check is_active to tablehttps://docs.google.com/document/d/1z1Lm-DUrri6xPzGXU37nLk5SfRjo4i9Elvx-lfbmK24/edit#heading=h.164d9ulc2oa3https://docs.google.com/document/d/1z1Lm-DUrri6xPzGXU37nLk5SfRjo4i9Elvx-lfbmK24/edit#heading=h.164d9ulc2oa35.20.0https://lab.civicrm.org/dev/financial/-/issues/75on order.get, line item has obsoleted contribution_type_id2019-10-19T22:49:23ZJoeMurrayon order.get, line item has obsoleted contribution_type_idThe line item table does not have a contribution_type_id. But when the results of a contribution.get are displayed, the line item fields includes both financial_type_id and contribution_type_id. This seems like an historical artifact tha...The line item table does not have a contribution_type_id. But when the results of a contribution.get are displayed, the line item fields includes both financial_type_id and contribution_type_id. This seems like an historical artifact that should be removed.https://lab.civicrm.org/dev/financial/-/issues/73Order.create should not require total amount2019-10-19T23:49:21ZJoeMurrayOrder.create should not require total amountThe spec for Order API create indicates that the total_amount is not required. If it is not provided then the total is calculated for the line item totals. However, https://dmaster.demo.civicrm.org/civicrm/api#explorer shows that total_a...The spec for Order API create indicates that the total_amount is not required. If it is not provided then the total is calculated for the line item totals. However, https://dmaster.demo.civicrm.org/civicrm/api#explorer shows that total_amount is a required parameter. Please fix the implementation of the order api create functionality to not require total_amount.5.20.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/1322payment_or_refund_notification 'FROM' address is missing2019-10-21T05:19:37Zmagnolia61payment_or_refund_notification 'FROM' address is missingThe Payment_or_refund mail (send when recording a payment) does not get send with us.
We get the message that the "FROM" address is missing. All other mails get send perfectly.
```
The mail library returned the following error message:
N...The Payment_or_refund mail (send when recording a payment) does not get send with us.
We get the message that the "FROM" address is missing. All other mails get send perfectly.
```
The mail library returned the following error message:
No From: address has been provided
```
When I change our outbound mail settings to database, I can see indeed the from address is missing from the headers.
The following header is from the add payment mail. This fails to send, lacks the 'From' field and is also missing the return path.
```
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="=_a5d5e8e8a2563fab89e0f4ae653c0aee"
To: Testuser
Subject: Payment Receipt -
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Date: Wed, 16 Oct 2019 12:52:43 +0200
```
The following mail is the contribution receipt. This gets send and has the From field in the header
```
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="=_76561187d0121e320a4a0d0fdb8432cb"
From: "Testuser"
To: Testleid Groepsleiding
Subject: Contribution Receipt - Testleid Groepsleiding
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Return-Path: testuser@gmail.com
Date: Wed, 16 Oct 2019 12:52:16 +0200
```5.18.4https://lab.civicrm.org/dev/financial/-/issues/85UI in core for processing refunds2019-10-21T21:48:01ZeileenUI in core for processing refundsWe looked at adding the ability to process refunds via the UI at the sprint.
We looked at
1) Changing the existing record refund form (Additional Payment form) to provide the option of processing the refund if offered by the processor ...We looked at adding the ability to process refunds via the UI at the sprint.
We looked at
1) Changing the existing record refund form (Additional Payment form) to provide the option of processing the refund if offered by the processor if a check box was selected
1) Changing the existing record refund form (Additional Payment form) to provide the option of processing the refund if offered by the processor if a differently named button was pressed
1) Having a second action for 'Process Refund' or similar
Opinions at Barcelona were pretty evenly divided between the 3!
A couple of things that might make a difference
1) here is a screen shot of how adding a payment currently looks
![Screen_Shot_2019-10-21_at_7.57.12_PM](/uploads/08d0eb711f4dd11fe0a980b8f92f949c/Screen_Shot_2019-10-21_at_7.57.12_PM.png)
1) @JoeMurray was keen that it be a case of the option showing if ALL payments on a contribution could be refunded. In the edge case of payments from more than one processor the submit refund option would not show
1) @JoeMurray agreed that it is OK to ALWAYS show 'record payment' & 'record refund' as opposed to currently it only shows 'add payment' if there it a balance to pay & add 'record refund' if there is a balance to refund. However, we need to be able to overpay & over refund - I'm going to work on this issue & seeing the UI afterwards (just having the links more often visible) might affect what people think 'makes sense' - issue for that is https://lab.civicrm.org/dev/financial/issues/86https://lab.civicrm.org/dev/core/-/issues/1332Payment details not saved correctly from Additional payment form2019-10-22T00:06:56ZeileenPayment details not saved correctly from Additional payment formDetail is https://github.com/civicrm/civicrm-core/pull/15537Detail is https://github.com/civicrm/civicrm-core/pull/155375.18.4https://lab.civicrm.org/dev/core/-/issues/1333Balance Due of completed contribution does not show as 0 but full amount in p...2019-10-22T00:07:05Zmagnolia61Balance Due of completed contribution does not show as 0 but full amount in payment receiptUsing 5.18.3 with patch https://github.com/civicrm/civicrm-core/pull/15545 (to be able to send the payment receipt at all)
I noticed that in different scenarios's (A. Pay the contribution in one payment & B. Pay it in a few payments)
the...Using 5.18.3 with patch https://github.com/civicrm/civicrm-core/pull/15545 (to be able to send the payment receipt at all)
I noticed that in different scenarios's (A. Pay the contribution in one payment & B. Pay it in a few payments)
the payment notification email shows the wrong amount for the Balance Due.
Interestingly it show the proper Balance Due when doing partial payments
```
Total Amount : 100
This Payment Amount : 60
Balance Due: 40
```
But at the final payment to full fill the contribution it shows the same as the full amount
```
Total Amount : 100
This Payment Amount : 100
Balance Due: 100
```5.18.4https://lab.civicrm.org/dev/core/-/issues/1285Importing campaigns only works with label2019-10-22T18:39:58ZandyburnsImporting campaigns only works with labelOn version 5.13.4 and before, mapping the campaigns field upon import (in my case during a contribution import), would allow use of the campaign ID. Now on 5.17.5, it only works with the campaign label. No rows fail to import, it just sk...On version 5.13.4 and before, mapping the campaigns field upon import (in my case during a contribution import), would allow use of the campaign ID. Now on 5.17.5, it only works with the campaign label. No rows fail to import, it just skips importing the campaign. Typically it is best if it rejects the row.
This may not be a bug but it would be useful to add to release notes if it isn't already or an advisory so people don't get caught out.5.18.2https://lab.civicrm.org/dev/core/-/issues/781Contact Display Name vs Email Greeting in Workflow templates2019-10-23T20:22:53ZMichael LabriolaContact Display Name vs Email Greeting in Workflow templatesI noticed that some of the workflow templates use contact.display_name in the greeting and some of them use contact.email_greeting. It would make sense to me that they all use contact.email_greeting. From what I can tell these template...I noticed that some of the workflow templates use contact.display_name in the greeting and some of them use contact.email_greeting. It would make sense to me that they all use contact.email_greeting. From what I can tell these templates are part of civicrm_generated.mysql file, which is quite large. I created a fork and updated the several places where display_name is still being used. Is submitting a merge request something a general user can do here?
Thanks!5.20.0https://lab.civicrm.org/dev/financial/-/issues/88Should we add is_deleted to the civicrm_contribution table?2019-10-24T11:38:33ZeileenShould we add is_deleted to the civicrm_contribution table?Despite @JoeMurray's best efforts we DO all contributions to be deleted. We do have precedent on other tables for soft deletions via an is_deleted flag. The difficulty with switching to that is it takes time to filter out possible places...Despite @JoeMurray's best efforts we DO all contributions to be deleted. We do have precedent on other tables for soft deletions via an is_deleted flag. The difficulty with switching to that is it takes time to filter out possible places of leakage.
However, we have just added is_template to the civicrm_contribution table (https://lab.civicrm.org/dev/financial/issues/72) on the understanding we will put the time into filtering out leakage over a few releases before starting to use it (& initially not in core) - which makes me wonder if we should add is_deleted & do the work on that at the same time & perhaps add an extension for soft deleting for those who want to be ahead of the game.
@JoeMurray @BjoernE @mattwire @ejegg @pradeep @monish.deb @ayduns @artfulrobot - any thoughts?https://lab.civicrm.org/dev/financial/-/issues/55Support storing IPNs in `civicrm_system_log` for processors that send JSON data2019-10-24T19:14:29ZJonGoldSupport storing IPNs in `civicrm_system_log` for processors that send JSON dataCurrently, `CRM_Core_Payment::logPaymentNotification()`, the method which logs to `civicrm_system_log` uses `$_REQUEST` to grab the POST data. However, `$_REQUEST` doesn't handle raw POST data, it assumes it's form-encoded. This patch ...Currently, `CRM_Core_Payment::logPaymentNotification()`, the method which logs to `civicrm_system_log` uses `$_REQUEST` to grab the POST data. However, `$_REQUEST` doesn't handle raw POST data, it assumes it's form-encoded. This patch handles JSON-encrypted POST requests, notably Stripe, so they can be stored in `civicrm_system_log`.5.16.0JonGoldJonGoldhttps://lab.civicrm.org/dev/financial/-/issues/79Deprecate Contribute.transact api2019-10-24T21:15:57ZeileenDeprecate Contribute.transact apiThe minimum we should do is deprecate from api explorer & I will do that in this PR. (Agreed in Barcelona)
I think we probably should do a noisier deprecation than that but that will stale-out some PRs currently under discussionThe minimum we should do is deprecate from api explorer & I will do that in this PR. (Agreed in Barcelona)
I think we probably should do a noisier deprecation than that but that will stale-out some PRs currently under discussion5.20.0https://lab.civicrm.org/dev/financial/-/issues/80Noisily deprecate transact api2019-10-24T21:16:11ZeileenNoisily deprecate transact apiWe should add in deprecation warnings using CRM_Core_Error::deprecatedFunctionWarning - these show on dev sites but not live
First step is https://lab.civicrm.org/dev/financial/issues/79We should add in deprecation warnings using CRM_Core_Error::deprecatedFunctionWarning - these show on dev sites but not live
First step is https://lab.civicrm.org/dev/financial/issues/795.20.0