Development issueshttps://lab.civicrm.org/groups/dev/-/issues2024-01-13T05:03:27Zhttps://lab.civicrm.org/dev/core/-/issues/3393CALSCALE being inserted at the wrong place in generated ICalendar files2024-01-13T05:03:27ZbrongCALSCALE being inserted at the wrong place in generated ICalendar filesWe had a bug report at Fastmail from a customer trying to add the following file to their calendar, which was generated by CiviCRM:
```
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//CiviCRM//NONSGML CiviEvent iCal//EN
X-WR-TIMEZONE:America/Los_...We had a bug report at Fastmail from a customer trying to add the following file to their calendar, which was generated by CiviCRM:
```
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//CiviCRM//NONSGML CiviEvent iCal//EN
X-WR-TIMEZONE:America/Los_Angeles
METHOD:PUBLISH
BEGIN:VEVENT
UID:CiviCRM_EventID_255_c2ebced490c608cd2aa7a6ae86cb8f9a@supporters.eff.org
SUMMARY:At Home With EFF: COVID-19\, Free Speech\, and Pri
vacy
DESCRIPTION:omitted here...
CATEGORIES:Workshop
CALSCALE:GREGORIAN
DTSTAMP;VALUE=DATE-TIME:20200422T120000
DTSTART;VALUE=DATE-TIME:20200422T120000
DTEND;VALUE=DATE-TIME:20200422T131500
URL:https://supporters.eff.org/civicrm/event/info?reset=1&id=255
END:VEVENT
END:VCALENDAR
```
Per the spec, CALSCALE should be in the outer VCALENDAR object, not inside the contained VEVENT object.
See: https://tools.ietf.org/html/rfc5545 section 3.7.
Having said that, `CALSCALE:GREGORIAN` is already the default, so just omitting it would be fine.https://lab.civicrm.org/dev/core/-/issues/3391E_NOTICES when visiting a contact's Events tab under certain conditions.2024-01-12T05:03:27ZDaveDE_NOTICES when visiting a contact's Events tab under certain conditions.I haven't had a chance to get the exact conditions and I don't think it's recent and the following might be a bit off but it's something like:
1. Using latest master.
2. Enable the waitlist features for an event (enable the two waitlist...I haven't had a chance to get the exact conditions and I don't think it's recent and the following might be a bit off but it's something like:
1. Using latest master.
2. Enable the waitlist features for an event (enable the two waitlist participant statuses and the checkbox on an event configuration info tab).
3. Fill up the event to its max participants.
4. Add a waitlist person.
5. Visit their events tab.
`Notice: Undefined index: target_contact_name in CRM_Activity_BAO_Activity::getContactActivitySelector() (line 2611 of .../CRM/Activity/BAO/Activity.php).`
```
elseif (!$values['target_contact_name']) {
$activity['target_contact_name'] = '<em>n/a</em>';
}
```
Note it doesn't show on the screen only in drupal watchdog.https://lab.civicrm.org/dev/core/-/issues/2930Hardcoded dollar currency symbol in event registration modals2024-01-10T05:03:21ZBradley TaylorHardcoded dollar currency symbol in event registration modalsIn this screenshot the event currency is set to GBP (£), but the total amount is shown as USD ($). The totals are being summed correctly, but the symbol is hardcoded:
![Screenshot_2021-10-31_at_17.15.05](/uploads/38d9076ae581a30aa5a7808...In this screenshot the event currency is set to GBP (£), but the total amount is shown as USD ($). The totals are being summed correctly, but the symbol is hardcoded:
![Screenshot_2021-10-31_at_17.15.05](/uploads/38d9076ae581a30aa5a7808de1705a08/Screenshot_2021-10-31_at_17.15.05.png)
It looks like the currency symbol is hardcoded in `templates/CRM/Price/Form/LineItem.tpl`.
A similar issue occurs when attempting to change selections for the event. In this case, the currency symbol is not hardcoded, but defaults to the default currency code for the installation - not for the currency code associated with the event.
![Screenshot_2021-10-31_at_17.26.05](/uploads/838c95c492eeb558ab3f7e6f7060a31f/Screenshot_2021-10-31_at_17.26.05.png).
Both of these occurences should be updated to use the currency configured as part of the event (on the Fees tab).Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/4896Conflict between cividiscount and public registrations2024-01-10T00:01:31ZtottenConflict between cividiscount and public registrationsOverview
----------------------------------------
There appears to be some conflict between CiviCRM 5.70-rc and cividiscount 3.8.9. I have not examined sufficiently to determine which one should be updated.
Reproduction steps
---------...Overview
----------------------------------------
There appears to be some conflict between CiviCRM 5.70-rc and cividiscount 3.8.9. I have not examined sufficiently to determine which one should be updated.
Reproduction steps
----------------------------------------
1. Install CiviCRM 5.70 and cividiscount 3.8.9 (current master, via git)
1. Create a free event with online registration. (I disabled confirmation-web-page and enabled conformation-email, FWIW.)
1. In a new/private window:
1. Open the event info page (`civicrm/event/info?reset=1&id=7`)
1. Open the event registration page (`civicrm/event/register?id=7&reset=1`)
Current behaviour
----------------------------------------
`civicrm/event/info` works but `civicrm/event/register` raises an error:
```
ReflectionException: "Property CRM_Event_Form_Registration_Register::$_contactID does not exist"
#0 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Form.php(2114): ReflectionProperty->__construct(Object(CRM_Event_Form_Registration_Register), "_contactID")
#1 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/tools/extensions/cividiscount/cividiscount.php(453): CRM_Core_Form->getVar("_contactID")
#2 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/tools/extensions/cividiscount/cividiscount.php(95): _cividiscount_get_form_contact_id(Object(CRM_Event_Form_Registration_Register))
#3 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook.php(276): cividiscount_civicrm_buildForm("CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register))
#4 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook/DrupalBase.php(73): CRM_Utils_Hook->runHooks((Array:60), "civicrm_buildForm", 2, "CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register), NULL, NULL, NULL, NULL)
#5 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Core/CiviEventDispatcher.php(314): CRM_Utils_Hook_DrupalBase->invokeViaUF(2, "CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register), NULL, NULL, NULL, NULL, "civicrm_buildForm")
#6 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php(251): Civi\Core\CiviEventDispatcher::delegateToUF(Object(Civi\Core\Event\GenericHookEvent), "hook_civicrm_buildForm", Object(Civi\Core\UnoptimizedEventDispatcher))
#7 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php(73): Symfony\Component\EventDispatcher\EventDispatcher->callListeners((Array:1), "hook_civicrm_buildForm", Object(Civi\Core\Event\GenericHookEvent))
#8 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Core/CiviEventDispatcher.php(263): Symfony\Component\EventDispatcher\EventDispatcher->dispatch(Object(Civi\Core\Event\GenericHookEvent), "hook_civicrm_buildForm")
#9 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook.php(168): Civi\Core\CiviEventDispatcher->dispatch("hook_civicrm_buildForm", Object(Civi\Core\Event\GenericHookEvent))
#10 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook.php(495): CRM_Utils_Hook->invoke((Array:2), "CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register), NULL, NULL, NULL, NULL, "civicrm_buildForm")
#11 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Form.php(766): CRM_Utils_Hook::buildForm("CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register))
#12 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php(76): CRM_Core_Form->buildForm()
#13 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Event_Form_Registration_Register), "display")
#14 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Event_Form_Registration_Register), "display")
#15 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Controller.php(355): HTML_QuickForm_Page->handle("display")
#16 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(322): CRM_Core_Controller->run((Array:3), NULL)
#17 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem((Array:18))
#18 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
#19 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/drupal/civicrm.module(472): CRM_Core_Invoke::invoke((Array:3))
#20 /Users/totten/bknix/build/dmaster/web/includes/menu.inc(527): civicrm_invoke("event", "register")
#21 /Users/totten/bknix/build/dmaster/web/index.php(24): menu_execute_active_handler()
#22 {main}
```
Expected behaviour
----------------------------------------
Show registration screen
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ Firefox
* __CiviCRM:__ 5.70-rc
* __PHP:__ 8.1
* __CMS:__ D7
* __Database:__ MySQL 5.7
* __Web Server:__ Apachehttps://lab.civicrm.org/dev/core/-/issues/3380Scheduled Reminder token fails for additional group2024-01-09T05:03:22ZStefanScheduled Reminder token fails for additional groupHello everyone,
got this issue for a year now, someone told to open an issue and I do hope, this is the place for that specific one.
I now use:
Wordpress: 5.7.2
Civicrm: 5.37.2
I create an event and set up a mail-reminder, which goes ...Hello everyone,
got this issue for a year now, someone told to open an issue and I do hope, this is the place for that specific one.
I now use:
Wordpress: 5.7.2
Civicrm: 5.37.2
I create an event and set up a mail-reminder, which goes to roles and also to one additional group.
In the html field I then add {event.start_date}.
{event.start_date} works for the roles, e.x. registered.
{event.start_date} **does not work** for group recipients.
Also other event(?)-token doesn't work for that group recipients.
For testing I also deactivated all extensions.
Please can someone confirm this issue?https://lab.civicrm.org/dev/core/-/issues/3372Event reminder add more than one group2024-01-08T05:03:19ZStefanEvent reminder add more than one groupHello everyone,
so we want to heavily use events and event reminders. Then, we got the event on the website, our members get the reminders and also ppl who register get them.
Thing is, I can choose a role and additionally one group.
B...Hello everyone,
so we want to heavily use events and event reminders. Then, we got the event on the website, our members get the reminders and also ppl who register get them.
Thing is, I can choose a role and additionally one group.
But what is, if this needs to be sent to more than one group?
I then could set up multiple reminders and also - I guess - create a dynamical group which contains other groups. But both seems inpractical compared to that smooth select field when I send regular traditional mails, where I can choose multiple groups.
Wordpress: 5.7.2
Civicrm: 5.37.2https://lab.civicrm.org/dev/core/-/issues/3358Add option to include guest information in back-office confirmation emails2024-01-07T05:03:23ZJKingsnorthAdd option to include guest information in back-office confirmation emailsProblem: when you send a confirmation email from the back-end after registering a participant, or editing their booking, it only includes the information for the 'current' participant (ie, just the lead booker). It does not include any '...Problem: when you send a confirmation email from the back-end after registering a participant, or editing their booking, it only includes the information for the 'current' participant (ie, just the lead booker). It does not include any 'additional participants' (guests) linked to their registration.
Solution: suggested CiviCRM core patch to add a checkbox to 'include guest information' for confirmation emails for participants that have guests attached to them. This would include the guest information int he email, as though it was from a front-end booking.
ie: IF the booking has additional participants, display a new checkbox:
![image](/uploads/2dbec13b633d9be6e880c2fb255a4b80/image.png)
If the checkbox is ticked, then add in the guest information, in the same way as a 'front-end' registration would add their information.https://lab.civicrm.org/dev/core/-/issues/3357Adding Participants to event using action drop down leads to blank screen2024-01-06T05:03:27ZkohnworkshopAdding Participants to event using action drop down leads to blank screenSelecting multiple contacts from the contact search and selecting "register participants to event" leads to a blank screen.
If I am doing something wrong can you please let me know what?
My expectation is that I would then reach a scree...Selecting multiple contacts from the contact search and selecting "register participants to event" leads to a blank screen.
If I am doing something wrong can you please let me know what?
My expectation is that I would then reach a screen to chose which event to add these to.
Thanks.
![Screen_Shot_2021-03-10_at_6.23.55_PM](/uploads/c86c9c0a1cbcd2a903050176e6ce7a5d/Screen_Shot_2021-03-10_at_6.23.55_PM.png)
![Screen_Shot_2021-03-10_at_6.24.06_PM](/uploads/ed55f0e84f0dc447cf2b0c854b9ac9ed/Screen_Shot_2021-03-10_at_6.24.06_PM.png)https://lab.civicrm.org/dev/core/-/issues/3345Selections information not visible when editing participant record from find ...2024-01-05T05:03:30ZanilSelections information not visible when editing participant record from find participants searchReproduced on https://dmaster.demo.civicrm.org on 1st March 2021 - Version 5.36.alpha1
To reproduce, register a contact for an event with a fee.
Search for this participant via a find participant search and click on edit from the searc...Reproduced on https://dmaster.demo.civicrm.org on 1st March 2021 - Version 5.36.alpha1
To reproduce, register a contact for an event with a fee.
Search for this participant via a find participant search and click on edit from the search results –
![participant_bug](/uploads/95b9fddc4f3f8f97e77274603361d8a4/participant_bug.png)
Correct info appears when you edit directly from the events tab from the contact record.
![participant_bug2](/uploads/3117ada4a296ec9badc687e951a64f7e/participant_bug2.png)https://lab.civicrm.org/dev/core/-/issues/3303Front End Event Registration Form - Drop Down Select List Labels not accessible2023-12-28T05:03:24ZndavisFront End Event Registration Form - Drop Down Select List Labels not accessibleOn front end registration forms, when using screen reader software (JAWS etc) When tabbing from a text field into a drop down select list field, the screen reader reads the selected data, not the field label, the way it does with other f...On front end registration forms, when using screen reader software (JAWS etc) When tabbing from a text field into a drop down select list field, the screen reader reads the selected data, not the field label, the way it does with other field types. This is broken. It should read the field label for drop down lists like it does with other field types. The user knows what is selected when they click it and it's read.
To fix this issue, change the aria-labelledby attribute of the s2id_autogen1 id'd input html element from select2-chosen-1 to s2id_autogen1
Code Example for the credit card form at https://demo.circle-interactive.co.uk/civicrm/event/register?id=1&reset=1:
`<label for="s2id_autogen1" class="select2-offscreen">Country</label>
<input class="select2-focusser select2-offscreen" type="text" aria-haspopup="true" role="button" aria-labelledby="select2-chosen-1" id="s2id_autogen1">`
**aria-labelledby="select2-chosen-1"**
needs to be changed to
`<label for="s2id_autogen1" class="select2-offscreen">Country</label>
<input class="select2-focusser select2-offscreen" type="text" aria-haspopup="true" role="button" aria-labelledby="s2id_autogen1" id="s2id_autogen1">`
**aria-labelledby="s2id_autogen1"**
This change can be extrapolated to state list drop downs (indeed any drop-downs)
For blind users this causes confusion because they don't know what field they're on if they're in a state/province named after the country and it works differently than the rest of the field types.
Changing this in the html source using developer tools of firefox or chrome fixes issue until page is refreshed.
I tried to figure out where this is happening but the javascript spaghetti is very confusing. If anyone can point me to the right file I'll patch it.
thx,
Neil P Davis
Developer
National Federation of the Blindhttps://lab.civicrm.org/dev/core/-/issues/3201Participant Listing report Unknown column 'contact_civireport.age_at_event2023-12-20T05:03:24ZEmerykZielinskiParticipant Listing report Unknown column 'contact_civireport.age_at_eventHey all,
when I try to sort Participant Listing report by age of the Participant (in the time of the event) i get the following error:
`[debug] $backTrace = #0 /var/www/html/sites/all/modules/civicrm/CRM/Core/Error.php(208): CRM_Core_E...Hey all,
when I try to sort Participant Listing report by age of the Participant (in the time of the event) i get the following error:
`[debug] $backTrace = #0 /var/www/html/sites/all/modules/civicrm/CRM/Core/Error.php(208): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /var/www/html/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(922): CRM_Core_Error::handle(Object(DB_Error))
#2 /var/www/html/sites/all/modules/civicrm/packages/DB.php(987): PEAR_Error->__construct("DB Error: no such field", -19, 16, (Array:2), "SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...")
#3 /var/www/html/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-19, 16, (Array:2), "SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...")
#4 /var/www/html/sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -19, 16, (Array:2), "SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...", "DB_Error", TRUE)
#5 /var/www/html/sites/all/modules/civicrm/packages/DB/common.php(1920): PEAR->__call("raiseError", (Array:7))
#6 /var/www/html/sites/all/modules/civicrm/packages/DB/mysqli.php(933): DB_common->raiseError(-19, NULL, NULL, "SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...", "1054 ** Unknown column 'contact_civireport.age_at_event' in 'field list'")
#7 /var/www/html/sites/all/modules/civicrm/packages/DB/mysqli.php(403): DB_mysqli->mysqliRaiseError()
#8 /var/www/html/sites/all/modules/civicrm/packages/DB/common.php(1229): DB_mysqli->simpleQuery("SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...")
#9 /var/www/html/sites/all/modules/civicrm/packages/DB/DataObject.php(2416): DB_common->query("SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...")
#10 /var/www/html/sites/all/modules/civicrm/packages/DB/DataObject.php(1607): DB_DataObject->_query("SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...")
#11 /var/www/html/sites/all/modules/civicrm/CRM/Core/DAO.php(435): DB_DataObject->query("SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...")
#12 /var/www/html/sites/all/modules/civicrm/CRM/Core/DAO.php(1428): CRM_Core_DAO->query("SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...", TRUE)
#13 /var/www/html/sites/all/modules/civicrm/CRM/Report/Form.php(3076): CRM_Core_DAO::executeQuery("SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...")
#14 /var/www/html/sites/all/modules/civicrm/CRM/Report/Form.php(3561): CRM_Report_Form->buildRows("SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_so...", (Array:0))
#15 /var/www/html/sites/all/modules/civicrm/CRM/Report/Form/Event/ParticipantListing.php(616): CRM_Report_Form->postProcess()
#16 /var/www/html/sites/all/modules/civicrm/CRM/Core/Form.php(495): CRM_Report_Form_Event_ParticipantListing->postProcess()
#17 /var/www/html/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Submit.php(74): CRM_Core_Form->mainProcess()
#18 /var/www/html/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Submit->perform(Object(CRM_Report_Form_Event_ParticipantListing), "submit")
#19 /var/www/html/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Report_Form_Event_ParticipantListing), "submit")
#20 /var/www/html/sites/all/modules/civicrm/CRM/Core/Controller.php(351): HTML_QuickForm_Page->handle("submit")
#21 /var/www/html/sites/all/modules/civicrm/CRM/Utils/Wrapper.php(114): CRM_Core_Controller->run()
#22 /var/www/html/sites/all/modules/civicrm/CRM/Report/Page/Instance.php(90): CRM_Utils_Wrapper->run("CRM_Report_Form_Event_ParticipantListing", NULL, (Array:0))
#23 /var/www/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(284): CRM_Report_Page_Instance->run((Array:4), NULL)
#24 /var/www/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:14))
#25 /var/www/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:4))
#26 /var/www/html/sites/all/modules/civicrm/drupal/civicrm.module(444): CRM_Core_Invoke::invoke((Array:4))
#27 /var/www/html/includes/menu.inc(527): civicrm_invoke("report", "instance", "26")
#28 /var/www/html/index.php(21): menu_execute_active_handler()
#29 {main}`
is there a way to set up the column `contact_civireport.age_at_event` by myself?https://lab.civicrm.org/dev/core/-/issues/3196Event ID is displaying Event Title in reports2023-12-17T05:03:31ZjgentlesEvent ID is displaying Event Title in reportsFirst, when you run a report and include the event ID column in some cases it displays the event title instead. In other cases, it does not show anything for the event id field. This is in CiviCRM 5.36.1.First, when you run a report and include the event ID column in some cases it displays the event title instead. In other cases, it does not show anything for the event id field. This is in CiviCRM 5.36.1.https://lab.civicrm.org/dev/core/-/issues/2887ical/ics files generated by Civi are not compatible with Outlook during Dayli...2023-12-13T15:33:23ZStoobical/ics files generated by Civi are not compatible with Outlook during Daylight SavingsOverview
----------------------------------------
Since the inclusion of timezone in the ical/ics files that CiviCRM produces RFC5545 timezone is technically correct but Outlook doesn't interpret them properly
Reproduction steps
-------...Overview
----------------------------------------
Since the inclusion of timezone in the ical/ics files that CiviCRM produces RFC5545 timezone is technically correct but Outlook doesn't interpret them properly
Reproduction steps
----------------------------------------
1. during daylight savings (until Nov 7 in this year, 2021) create an event
2. download the ics/ical file from the event 'info' page
3. open that ics/ical file in Outlook
4. notice that it is one hour forward (later) than should be
Commentary
----------------------------------------
Hi guys, I wanted to make you aware of a new twist on this issue since timezones were added to the Civi-generated ical/ics files. Good news and bad, but wanted to share my research.
Good news: timezones are good, and as you know ical/ics from Civi didn't have them until 5.37.
Bad news: timezone glitches in Outlook.
The standards are meticulous but illustrate the format here: https://icalendar.org/iCalendar-RFC-5545/3-8-3-1-time-zone-identifier.html and the TZ zones can be clearly seen here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
How does this relate to Outlook, might you ask? Good question. Well I scoured the internet and people unrelated to CiviCRM have reported issues with timezone discrepancies in Outlook....
- As far back as 2016: https://theeventscalendar.com/support/forums/topic/ical-timezone-issue-with-microsoft-outlook
- And as recently as 2019: https://answers.microsoft.com/en-us/msoffice/forum/all/outlook-cant-read-timezone-in-ics-file-a-slew-of/495cadf9-4630-48b5-99ce-88d94980f289
... what these tend to have in common is that the discrepancies happen during Daylight Savings, which we are in right now, and which ends Nov 7. And they all have to do with ical/ics files that use a format of "America/New_York" whereas Outlook uses a different naming convention.
But how does this relate to CiviCRM? An even better question. Prior to version CiviCRM 5.37 which was released in June, CiviCRM ical/ics files had NO timezone at all, here: #19762 I never knew this. Lack of timezone caused problems of its own, but with most folks who are in the same timezone it doesn't matter.
When I made a mandatory security update to 5.38 CiviCRM a few months ago, the problems surfaced for a large nonprofit organization that uses primarily Outlook. That is because although CiviCRM now creates its ical/ics file to the RFC5545 standard, Outlook does not (attached). And now that CiviCRM is putting in timezones, we notice the issue for the first time...but only in Outlook. In one of the above posts it clearly states that Outlook misinterprets America/New_York in Daylight Savings.
So all that to say this is where we stand, between a rock and a hard place, metaphorically but perhaps even literally getting Microsoft to change their software might be like moving a mountain. And CiviCRM, well-meaning though we may be, may not want to accommodate a change to Civi that doesn't meet standards.
Solution ?
--------------------------------
There might be an exception or compromise in this mess, but it will more likely be on the CiviCRM side. Originally detected by agilware on this repo: https://github.com/civicrm/civicrm-core/pull/19762
![comparison](/uploads/8ef08e1138430a9793a18ad7966581f3/comparison.png)
[outlook-created.ics](/uploads/dee2cccb0c4a19b61ff106cb54f8ee5a/outlook-created.ics)5.52.2justinfreeman (Agileware)justinfreeman (Agileware)https://lab.civicrm.org/dev/wordpress/-/issues/140Event registration confirmation page no longer shown. Error: Could not find v...2023-12-07T09:30:02Zdarren.woodsEvent registration confirmation page no longer shown. Error: Could not find valid value for id.WordPress 6.2, Civi ESR 5.57.5.
The confirmation page after event registration is no longer shown (for both Test and Live links). Instead, the attached error is shown:-
![image](/uploads/602b80ebba49507af86158d362c9b164/image.png)
The ...WordPress 6.2, Civi ESR 5.57.5.
The confirmation page after event registration is no longer shown (for both Test and Live links). Instead, the attached error is shown:-
![image](/uploads/602b80ebba49507af86158d362c9b164/image.png)
The workaround is to embed the event registration page as a shortcode. However the confirmation page and confirmation emails show a link to the event info page, which then has the "Register" button taking people to the wrong page.
I'm wondering if this can be fixed, or if we need to override the confirmation and event info pages somehow to redirect users to the WordPress page (perhaps using a naming convention).
Thanks!https://lab.civicrm.org/dev/core/-/issues/4735Event Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid...2023-12-06T16:06:38Zdarren.woodsEvent Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid value for id"Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/qu...Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/questions/45729/event-registration-error-on-wordpress-6-3-1-civi-5-63-4-could-not-find-valid-va
Reproduction steps
----------------------------------------
1. Configure an event with free online registration and a thankyou message.
2. Register for the event from the event info page.
Current behaviour
----------------------------------------
Users are shown an error: "Could not find valid value for id"
Expected behaviour
----------------------------------------
Thank you message configured in the event should be shown.
Environment information
----------------------------------------
* __Browser: Browser independent.
* __CiviCRM: 5.63.4
* __PHP: 8.1
* __CMS: WordPress 6.3.1
* __Database: MariaDB
* __Web Server: Nginx
Comments
----------------------------------------
This only happens with registering for events using the Civi event info page. If you embed a shortcode for the specific event in a WordPress page then the error is not shown.https://lab.civicrm.org/dev/core/-/issues/1590Scheduled reminder: "Additional recipients" receive reminders under circumsta...2023-12-01T05:03:19ZJonGoldScheduled reminder: "Additional recipients" receive reminders under circumstances where they ought not toThis is a superset of event#28. The issue seems to be more generalized than I'd realized.
"Additional recipients" will receive reminders on events (and presumably other entities) that have been deleted. To test:
* Create a scheduled r...This is a superset of event#28. The issue seems to be more generalized than I'd realized.
"Additional recipients" will receive reminders on events (and presumably other entities) that have been deleted. To test:
* Create a scheduled reminder for an existing event.
* Under *Limit or Add Recipients*, select **Also Include** and add a group or contact(s).
* Delete the event.
* Run the scheduled reminders job.
**Expected result**
No scheduled reminder.
**Actual result**
Scheduled reminder to the "additional recipients".
### Why it happens
Scheduled reminder recipients are decided in two passes. First, whomever qualifies by the "normal" criteria (e.g. event participants) and a second pass for anyone in "Additional Participants".
The first pass is specific to the type of reminder (event, membership, contribution); the second is the same code regardless. This caused event#28; the "additional recipients" pass, by virtue of not being event/membership/etc-specific, wasn't aware that events have the special case of templates, which other entities don't. It also doesn't check for deleted entities.
The solution is to add a new method to the `Civi\ActionSchedule\MappingInterface` interface - a `sendToAdditional` method that returns a boolean. Then, each class that implements this interface can abort the "additional recipients" pass in an entity-specific way. Besides deleted entities and event templates, contributions have templates as well now, so we should check for that.https://lab.civicrm.org/dev/core/-/issues/2708Event registration cookies error when registering additional participants on ...2023-11-22T05:03:23ZandyburnsEvent registration cookies error when registering additional participants on WP multisiteOn a WP 5.7.2 multisite Civi 5.35.2, I set up a event registration that allows multiple participants and is a free event.
I tested this on 3 sites:
- Primary domain site.org
- site2.org
- 50.site.org
On all but 50.site.org, I get the ...On a WP 5.7.2 multisite Civi 5.35.2, I set up a event registration that allows multiple participants and is a free event.
I tested this on 3 sites:
- Primary domain site.org
- site2.org
- 50.site.org
On all but 50.site.org, I get the cookies error every single time If I try and register an additional participant. It works as expected if I just register 1 person.
So something appears to be wrong in the code with how the additional participant registration works. 50.site.org is first in the list alphabetically.
I get the following cookies error shown here: https://civicrm.stackexchange.com/questions/40020/event-registration-cookies-error-when-registering-additional-participants
It occurs from 2nd additional participant screen => thank you page (fails)
If confirmation page enabled: It occurs from confirmation page => thank you page (fails)
Here is the ONLY scenario where I do not get the cookies error. (summary: fails on first registration process. Try it again and it works.)
1. I register myself and another person.
1. I get the cookies error
1. I go back to register again to register myself and another person
1. It lets me register again (same contact info)
1. For additional participant, it says they are already registered, so I change the name so it doesn't dedupe on existing registrant.
1. Thank you page is successfully shown.
In all cases, registration occurs whether a cookies error is shown or not.https://lab.civicrm.org/dev/core/-/issues/899PCP is still active after contribution page is disabled.2023-11-15T05:03:17ZjitendraPCP is still active after contribution page is disabled.To replicate -
- Create a contribution page and enable PCP.
- User makes a donation from the live page and creates a PCP of his own.
- When an admin approves the PCP, a notification email is sent to the creator.
- Disable the Contributi...To replicate -
- Create a contribution page and enable PCP.
- User makes a donation from the live page and creates a PCP of his own.
- When an admin approves the PCP, a notification email is sent to the creator.
- Disable the Contribution page.
- PCP is kept as it is.
- When the live page is visited by the promoter or the user from the PCP link, a yellow message is displayed on the page
![image](/uploads/0b1710ed1f37bcce8b9b4d9c1779ee85/image.png)
Real problem seems to be - you have someone who has made a P2P contribution page who might have no clue the page has been disabled by a site admin and is out promoting the page!
Thoughts on expected behavior? @eileen @KarinG...
- Disable PCP when CP is disabled.
- Keep PCP as it is and change the error message on PCP load.
- Disable the PCP and send an email notification to the creator.
- The current error is perhaps the correct and enough response to be shown to the user :shrug:jitendrajitendrahttps://lab.civicrm.org/dev/core/-/issues/3952Event badges, json may be broken (was CiviEvent - Date tokens may be misforma...2023-11-14T01:27:44ZtottenEvent badges, json may be broken (was CiviEvent - Date tokens may be misformatted)(*This is an offshoot from #3829. PR [24695](https://github.com/civicrm/civicrm-core/pull/24695) bundled in a partial fix for this date-token issue, but it looks to me like this is distinct from the barcode problem - and this still has s...(*This is an offshoot from #3829. PR [24695](https://github.com/civicrm/civicrm-core/pull/24695) bundled in a partial fix for this date-token issue, but it looks to me like this is distinct from the barcode problem - and this still has some TODOs.*)
v5.43 included an update for certain tokens. It recommended adding an explicit date filter:
* `{event.start_date}` => `{event.start_date|crmDate:"%B %E%f}`
* `{event.end_date}` => `{event.end_date|crmDate:"%B %E%f}`
Notably, the default content in `civicrm_print_label`.`data` has references to these tokens. It was updated by way of [873bfeb503caa413f17460](https://github.com/civicrm/civicrm-core/commit/873bfeb503caa413f17460dbe450b74fac3d6dbf#diff-b604dfcba0703a9cd5e9f1431451f657c2a580b1dfd8eb56e2c4e4a960c4b43c) (see `FiveFortyThree.php` and `civicrm_navigation.tpl`). However, the `data` field have special encoding requirements (JSON?), so it's not a simple string-substitution.
With [24695](https://github.com/civicrm/civicrm-core/pull/24695), it sounds like the escaping is fixed for new installs (5.54.1+). However, we probably need a cleanup/upgrade step for sites which either (a) installed 5.43-5.54 or (b) installed <5.43 and ran the upgrade.5.69.0https://lab.civicrm.org/dev/core/-/issues/3015Undefined Index2023-11-03T05:03:19ZJoeMurrayUndefined IndexOverview
----------------------------------------
_Update multiple participants caused undefined index error on dmaster._
Reproduction steps
----------------------------------------
1. Create custom alphanumeric field for participants,...Overview
----------------------------------------
_Update multiple participants caused undefined index error on dmaster._
Reproduction steps
----------------------------------------
1. Create custom alphanumeric field for participants, eg add Idea to Food Preference custom field set on dmaster.
1. Create profile with just this new field, eg test.
1. Find all participants, select a couple, then choose Update multiple participants search results action.
1. Select profile created above. Click continue.
1. See Notice: Undefined index: size in CRM_Event_Form_Task_Batch->buildQuickForm() (line 108 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Task/Batch.php).
1. Note that the Idea field has a column but there is no field provided to enter data.
Current behaviour
----------------------------------------
![2022-01-03_11-51-42](/uploads/3b007e3aa61eb2b3cc00bd3d10e36360/2022-01-03_11-51-42.png)
Expected behaviour
----------------------------------------
No error. Ability to enter / edit data in Idea field.
Environment information
----------------------------------------
dmaster on mac chrome.EdselopezEdselopez2022-01-05