Development issueshttps://lab.civicrm.org/groups/dev/-/issues2019-11-24T06:15:23Zhttps://lab.civicrm.org/dev/core/-/issues/1084Contribution confirmation page: Translation won't work2019-11-24T06:15:23ZDetlev SieberContribution confirmation page: Translation won't workThe message {ts 1=$button}Your contribution will not be completed until you click the <strong>%1</strong> button. Please click the button one time only.{/ts} is not translated.
The reason is: The code is split over several lines and con...The message {ts 1=$button}Your contribution will not be completed until you click the <strong>%1</strong> button. Please click the button one time only.{/ts} is not translated.
The reason is: The code is split over several lines and contains spaces, linebreaks and tab characters. This breaks the gettext translation.5.16.0Detlev SieberDetlev Sieberhttps://lab.civicrm.org/dev/core/-/issues/1016Small bug with impact on translation in confirm.tpl2019-11-24T06:16:33ZGuillaumeSorelSmall bug with impact on translation in confirm.tplI found that some strings in /sites/all/modules/civicrm/templates/CRM/Contribute/Form/Contribution/Confirm.tpl were not translated because of a line break in code lines 298 >> 301.
`{if $is_pay_later OR $amount LE 0.0}
{ts 1=$...I found that some strings in /sites/all/modules/civicrm/templates/CRM/Contribute/Form/Contribution/Confirm.tpl were not translated because of a line break in code lines 298 >> 301.
`{if $is_pay_later OR $amount LE 0.0}
{ts 1=$button}Your transaction will not be completed until you click the <strong>%1</strong> button. Please click the button one time only.{/ts}
{else}
{ts 1=$button}Your contribution will not be completed until you click the <strong>%1</strong> button. Please click the button one time only.{/ts}
{/if}`
When corrected, theses strings are correctly translated otherwise would they stay in English.5.15.0https://lab.civicrm.org/dev/core/-/issues/1245is_email_receipt column default in civicrm_contribution_recur may not be correct2019-11-25T15:14:11Zseamusleeis_email_receipt column default in civicrm_contribution_recur may not be correctIn our instance i have found that the is_email_receipt column had a default of 0 in civicrm_contribution_recur even tho the schema is set to be default 1. It would appear that it was caused by the fact no default was specified in the upg...In our instance i have found that the is_email_receipt column had a default of 0 in civicrm_contribution_recur even tho the schema is set to be default 1. It would appear that it was caused by the fact no default was specified in the upgrade script https://github.com/civicrm/civicrm-svn/commit/7f39befd60bc735408d7866b02b3ac7fff1d4eea#diff-9ad8e290180451a2d6eacbd3d1ca7966R354https://lab.civicrm.org/dev/core/-/issues/1468Advanced search fails to properly search for contribution source2019-12-11T19:17:56ZRichAdvanced search fails to properly search for contribution sourceOverview
----------------------------------------
Try searching for a contribution source from the Advanced search - bet you don't get any results.
Reproduction steps
----------------------------------------
1. Create a contact; add ...Overview
----------------------------------------
Try searching for a contribution source from the Advanced search - bet you don't get any results.
Reproduction steps
----------------------------------------
1. Create a contact; add a contribution with a source `findme`
1. Do an advanced search, specifying a contribution with a source `findme`
1. no results - expected to find your contact.
Current behaviour
----------------------------------------
No results.
Reason: the SQL generation generates SQL like this: `civicrm_contribution.source IN ("%findme%")`
i.e. it's added `%` wildcards as if for a `LIKE` operator, but then it's used `IN`!
Expected behaviour
----------------------------------------
It should generate SQL like this: `civicrm_contribution.source LIKE ("%findme%")` and return the result.
Environment information
----------------------------------------
* __CiviCRM:__ _Master_ and _5.20.0_5.22.0RichRichhttps://lab.civicrm.org/dev/core/-/issues/1472Thousands-separator corrupts price field values (comma)2019-12-16T19:27:10ZAllenShawThousands-separator corrupts price field values (comma)This issue appears with price field values of 1000 and above. It is reproducible as follows on dmaster:
I start by visiting Administer CiviCRM > Localization > Languages, Currency, Locations, and ensure the following settings:
* Thousa...This issue appears with price field values of 1000 and above. It is reproducible as follows on dmaster:
I start by visiting Administer CiviCRM > Localization > Languages, Currency, Locations, and ensure the following settings:
* Thousands Separator: ,
* Decimal Delimiter: .
Then I take these steps:
1. Create a price field with an amount of 1200.00, and click Save
1. In the list of price fields, observe that the amount is correct: "1,200.00".
1. Edit that price field, and in the Edit form, the amount is displayed with decimal and thousands-separators, as "1,200.00"
1. Remove the comma and click Save.
1. In the list of price fields, observe that the amount is correct: "1,200.00".
1. Again edit that price field, and in the Edit form, the amount is again displayed with decimal and thousands-separators, as "1,200.00"
1. Change nothing in this form and merely press Save.
1. In the list of price fields, observe that the amount is now "1.00".
My guess is that the comma is being treated as a decimal, even though the localization settings specify that it is the thousands-separator.
Perhaps we could just do without thousands-separators in editable price fields, and sidestep the issue of processing them; but then someone would enter them manually and be surprised at the result. So omitting them is probably not enough.5.22.0https://lab.civicrm.org/dev/financial/-/issues/113Soft Credits should have pre/post hooks2020-01-12T21:51:57ZJonGoldSoft Credits should have pre/post hooksThe ContributionSoft entity doesn't have pre/post hooks. The use case for having them is to trigger emails or other workflows involving the credited individual.The ContributionSoft entity doesn't have pre/post hooks. The use case for having them is to trigger emails or other workflows involving the credited individual.5.23.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/1255Email address token on the confirmation message not working for a pay later c...2020-01-14T20:47:10ZjitendraEmail address token on the confirmation message not working for a pay later contribution.To replicate -
- Add a profile with an email(email-primary) field.
- Include this profile on a contribution page.
- Submit the page with pay later and notice the below confirmation message on the thankyou page -
![image](/uploads/bfb07...To replicate -
- Add a profile with an email(email-primary) field.
- Include this profile on a contribution page.
- Submit the page with pay later and notice the below confirmation message on the thankyou page -
![image](/uploads/bfb07ad0f414007d2b148ad10aeb6309/image.png)
The second line ends with "has been sent to .". This should be displaying an email address of the user.5.23.0jitendrajitendrahttps://lab.civicrm.org/dev/core/-/issues/1423civicrm_contribution_recur.is_email_receipt is ignored2020-01-15T17:02:54ZRichcivicrm_contribution_recur.is_email_receipt is ignoredOverview
----------------------------------------
The recur table has a `is_email_receipt` column. To me this means that this is a per-recurring-contrib preference, but this does not appear to be honoured.
Reproduction steps
---------...Overview
----------------------------------------
The recur table has a `is_email_receipt` column. To me this means that this is a per-recurring-contrib preference, but this does not appear to be honoured.
Reproduction steps
----------------------------------------
(I've written a test in a PR to follow.)
1. Create a contribution recur record with `is_email_receipt = 1`
1. add a completed contrib
1. expect an email, don't get one.
Expected behaviour
----------------------------------------
I think the behaviour *should* be:
1. was `is_email_receipt` passed in to the API call? If so, use that.
*if not*...
2. is the contrib part of a recurring contribution, and is the recur record's `is_email_receipt` set (to 0 or 1)? If so, use that.
*if not*...
3. is the contrib linked to a contribution page? If so, use the contribution page's setting.
*if not*...
4. send one by default
Environment information
----------------------------------------
* __CiviCRM:__ _Master @ 38891c5df7
[possibly linked issue](https://lab.civicrm.org/dev/core/issues/1245)https://lab.civicrm.org/dev/core/-/issues/1573Add columns to Contribution Detail report: Employer, Location Type, Preferred...2020-02-05T03:07:10ZAllenShawAdd columns to Contribution Detail report: Employer, Location Type, Preferred Communication MethodFor some time I've been running a PHP file override to get some extra columns into the *Contribution Detail* report. Adding these to the core report is fairly easy, and these columns seem like they'd be useful to others (who could also o...For some time I've been running a PHP file override to get some extra columns into the *Contribution Detail* report. Adding these to the core report is fairly easy, and these columns seem like they'd be useful to others (who could also of course just move right along as usual without using them, if they like).
Because these columns simply amount to more information about entities already included in the report, this change would not make any changes to the underlying logic (or lack thereof) of the report itself.
PR forthcoming.5.23.0AllenShawAllenShawhttps://lab.civicrm.org/dev/financial/-/issues/117Payment edit link cannot be modified2020-02-11T20:07:09Zadrian@roomify.usPayment edit link cannot be modifiedOn the 'View Contribution' page, the payment details edit link is not currently modifiable via hook_civicrm_links. Related issue: https://issues.civicrm.org/jira/browse/CRM-13434
I'll be submitting a PR.On the 'View Contribution' page, the payment details edit link is not currently modifiable via hook_civicrm_links. Related issue: https://issues.civicrm.org/jira/browse/CRM-13434
I'll be submitting a PR.5.24.0https://lab.civicrm.org/dev/financial/-/issues/116Cancelling a payment thru the API2020-02-14T19:24:31ZalicefruminCancelling a payment thru the APIWhen a user updates a Contribution with the status "Completed" to have the status "Cancelled" thru the UI (or the API using Contribution.create and an id) a negative payment is created with a status of "Cancelled" like in the screen shot...When a user updates a Contribution with the status "Completed" to have the status "Cancelled" thru the UI (or the API using Contribution.create and an id) a negative payment is created with a status of "Cancelled" like in the screen shot below:
![cancelled](/uploads/04c0dcd8c7798a42184e2f0a902b1697/cancelled.png)
This works fine if you are cancelling a full contribution however there is now way in the UI or the API to cancel one of multiple payments.
For Example:
+ a user has a $10 contribution with two payments one for $2 and one for $8
+ The user wants to cancel the $2 contribution
If you cancel the contribution it will record a negative payment of $10.
IF you do `Payment.cancel` it will record a negative payment of $2 with a status "Refunded"
Using `FinancialTrxn.create` you can create a payment of -$2 with a status of "Cancelled" but it will not update the contribution status AND when you update the contribution status to "Cancelled" a new negative payment (of -$10) will be created with a status of cancelled.
PROPOSED SOLUTIONS:
+ Update the `Contribution.create` api so that there is a flag to not create new payments.
+ Allow 'status_id' to be passed to the Payment API and update the contribution and payment statuses based on the status_id if providedhttps://lab.civicrm.org/dev/core/-/issues/1583API v4 returning incorrect count of contributions under certain WHERE conditions2020-02-17T02:21:40ZjamieAPI v4 returning incorrect count of contributions under certain WHERE conditionsThe database has three contributions with the `contribution_recur_id` set to 19.
When I query for these via apiv4 using just the `contribution_recur_id`, I get three results from the database (and the `first()` function works properly)....The database has three contributions with the `contribution_recur_id` set to 19.
When I query for these via apiv4 using just the `contribution_recur_id`, I get three results from the database (and the `first()` function works properly).
When I query and limit to those with `is_template` set to 1 (there should be no matching results), I get a count of 1, but NULL when I call `first()`.
Here's the data:
```
MariaDB [ptp]> SELECT * FROM civicrm_contribution WHERE contribution_recur_id =19;
+------+------------+-------------------+----------------------+-----------------------+---------------------+-----------------------+--------------+------------+------------+-----------------------------+----------------------------------+----------+-------------+---------------+---------------------+---------------+---------------------------------------------------------------------------------+--------------+-----------------------+---------+--------------+------------------------+------------+--------------+-------------+------------+---------------+--------------------------+----------------+-------------+
| id | contact_id | financial_type_id | contribution_page_id | payment_instrument_id | receive_date | non_deductible_amount | total_amount | fee_amount | net_amount | trxn_id | invoice_id | currency | cancel_date | cancel_reason | receipt_date | thankyou_date | source | amount_level | contribution_recur_id | is_test | is_pay_later | contribution_status_id | address_id | check_number | campaign_id | tax_amount | creditnote_id | revenue_recognition_date | invoice_number | is_template |
+------+------------+-------------------+----------------------+-----------------------+---------------------+-----------------------+--------------+------------+------------+-----------------------------+----------------------------------+----------+-------------+---------------+---------------------+---------------+---------------------------------------------------------------------------------+--------------+-----------------------+---------+--------------+------------------------+------------+--------------+-------------+------------+---------------+--------------------------+----------------+-------------+
| 3928 | 10459 | 2 | 14 | 1 | 2019-12-02 13:07:59 | 0.00 | 296.00 | 8.88 | 287.12 | in_1FlKFWAwDzuDdbFCuWUlA4EZ | 0f3dd1eda0400becb9ecd33c58d28ae8 | USD | NULL | 0 | 2019-12-02 13:07:56 | NULL | Online Contribution: PowerBase Subscription Payment with Monthly Payment Option | NULL | 19 | 0 | 0 | 1 | 24745 | NULL | NULL | NULL | NULL | NULL | NULL | 0 |
| 3951 | 10459 | 2 | 14 | 1 | 2020-01-02 13:08:03 | 0.00 | 296.00 | 8.88 | 287.12 | in_1FwZ1bAwDzuDdbFCXoBfw8UM | NULL | USD | NULL | NULL | 2020-01-02 14:13:42 | NULL | Online Contribution: PowerBase Subscription Payment with Monthly Payment Option | NULL | 19 | 0 | 0 | 1 | NULL | NULL | NULL | NULL | NULL | NULL | NULL | 0 |
| 3999 | 10459 | 2 | 14 | 1 | 2020-02-02 13:08:03 | 0.00 | 296.00 | 8.88 | 287.12 | in_1G7nnbAwDzuDdbFCvncHVNPH | NULL | USD | NULL | NULL | 2020-02-07 15:03:30 | NULL | Online Contribution: PowerBase Subscription Payment with Monthly Payment Option | NULL | 19 | 0 | 0 | 1 | NULL | NULL | NULL | NULL | NULL | NULL | NULL | 0 |
+------+------------+-------------------+----------------------+-----------------------+---------------------+-----------------------+--------------+------------+------------+-----------------------------+----------------------------------+----------+-------------+---------------+---------------------+---------------+---------------------------------------------------------------------------------+--------------+-----------------------+---------+--------------+------------------------+------------+--------------+-------------+------------+---------------+--------------------------+----------------+-------------+
3 rows in set (0.001 sec)
MariaDB [ptp]>
```
Here is the test code:
```
<?php
$res = \Civi\Api4\Contribution::get()
->setCheckPermissions(FALSE)
->addWhere('contribution_recur_id', '=', 19)
->execute();
echo "=== NOTE Results are correct ===\n\n";
echo "count is: " . $res->count() . "\n";
echo "First...\n";
print_r($res->first());
foreach ($res as $r) {
print_r($r);
}
$contribution_recur_id = 19;
$res = \Civi\Api4\Contribution::get()
->setCheckPermissions(FALSE)
->addWhere('contribution_recur_id', '=', 19)
->addWhere('is_template', '=', 1)
->execute();
echo "\n\n";
echo "=== NOTE: count is one, but no results from first() === \n";
echo "count is: " . $res->count() . "\n";
echo "First...\n";
print_r($res->first());
foreach ($res as $r) {
// No output from this call.
print_r($r);
}
```
And here is the output when running that code via `cv`:
```
=== NOTE Results are correct ===
count is: 4
First...
Array
(
[id] => 3928
[contact_id] => 10459
[financial_type_id] => 2
[contribution_page_id] => 14
[payment_instrument_id] => 1
[receive_date] => 2019-12-02 13:07:59
[non_deductible_amount] => 0.00
[total_amount] => 296.00
[fee_amount] => 8.88
[net_amount] => 287.12
[trxn_id] => in_1FlKFWAwDzuDdbFCuWUlA4EZ
[invoice_id] => 0f3dd1eda0400becb9ecd33c58d28ae8
[invoice_number] =>
[currency] => USD
[cancel_date] =>
[cancel_reason] => 0
[receipt_date] => 2019-12-02 13:07:56
[thankyou_date] =>
[source] => Online Contribution: PowerBase Subscription Payment with Monthly Payment Option
[amount_level] =>
[contribution_recur_id] => 19
[is_test] => 0
[is_pay_later] => 0
[contribution_status_id] => 1
[address_id] => 24745
[check_number] =>
[campaign_id] =>
[creditnote_id] =>
[tax_amount] =>
[revenue_recognition_date] =>
[is_template] => 0
)
Array
(
[id] => 3928
[contact_id] => 10459
[financial_type_id] => 2
[contribution_page_id] => 14
[payment_instrument_id] => 1
[receive_date] => 2019-12-02 13:07:59
[non_deductible_amount] => 0.00
[total_amount] => 296.00
[fee_amount] => 8.88
[net_amount] => 287.12
[trxn_id] => in_1FlKFWAwDzuDdbFCuWUlA4EZ
[invoice_id] => 0f3dd1eda0400becb9ecd33c58d28ae8
[invoice_number] =>
[currency] => USD
[cancel_date] =>
[cancel_reason] => 0
[receipt_date] => 2019-12-02 13:07:56
[thankyou_date] =>
[source] => Online Contribution: PowerBase Subscription Payment with Monthly Payment Option
[amount_level] =>
[contribution_recur_id] => 19
[is_test] => 0
[is_pay_later] => 0
[contribution_status_id] => 1
[address_id] => 24745
[check_number] =>
[campaign_id] =>
[creditnote_id] =>
[tax_amount] =>
[revenue_recognition_date] =>
[is_template] => 0
)
Array
(
[id] => 3951
[contact_id] => 10459
[financial_type_id] => 2
[contribution_page_id] => 14
[payment_instrument_id] => 1
[receive_date] => 2020-01-02 13:08:03
[non_deductible_amount] => 0.00
[total_amount] => 296.00
[fee_amount] => 8.88
[net_amount] => 287.12
[trxn_id] => in_1FwZ1bAwDzuDdbFCXoBfw8UM
[invoice_id] =>
[invoice_number] =>
[currency] => USD
[cancel_date] =>
[cancel_reason] =>
[receipt_date] => 2020-01-02 14:13:42
[thankyou_date] =>
[source] => Online Contribution: PowerBase Subscription Payment with Monthly Payment Option
[amount_level] =>
[contribution_recur_id] => 19
[is_test] => 0
[is_pay_later] => 0
[contribution_status_id] => 1
[address_id] =>
[check_number] =>
[campaign_id] =>
[creditnote_id] =>
[tax_amount] =>
[revenue_recognition_date] =>
[is_template] => 0
)
Array
(
[id] => 3999
[contact_id] => 10459
[financial_type_id] => 2
[contribution_page_id] => 14
[payment_instrument_id] => 1
[receive_date] => 2020-02-02 13:08:03
[non_deductible_amount] => 0.00
[total_amount] => 296.00
[fee_amount] => 8.88
[net_amount] => 287.12
[trxn_id] => in_1G7nnbAwDzuDdbFCvncHVNPH
[invoice_id] =>
[invoice_number] =>
[currency] => USD
[cancel_date] =>
[cancel_reason] =>
[receipt_date] => 2020-02-07 15:03:30
[thankyou_date] =>
[source] => Online Contribution: PowerBase Subscription Payment with Monthly Payment Option
[amount_level] =>
[contribution_recur_id] => 19
[is_test] => 0
[is_pay_later] => 0
[contribution_status_id] => 1
[address_id] =>
[check_number] =>
[campaign_id] =>
[creditnote_id] =>
[tax_amount] =>
[revenue_recognition_date] =>
[is_template] => 0
)
=== NOTE: count is one, but no results from first() ===
count is: 1
First...
www-data@fecbf38eb0bb:~/powerbase$
```https://lab.civicrm.org/dev/core/-/issues/1438when importing contributions, can't match contact on phone number2020-02-17T15:27:10Zjamiewhen importing contributions, can't match contact on phone numberOverview
----------------------------------------
When importing contributions, you can't match an existing contact using a phone number, even when the default unsupervised rule specified the phone field. It is because the dedupe rule ca...Overview
----------------------------------------
When importing contributions, you can't match an existing contact using a phone number, even when the default unsupervised rule specified the phone field. It is because the dedupe rule calls the phone field "phone_numeric" yet the contact list of importable fields lists the field as "phone" - so no match is every made.
Reproduction steps
----------------------------------------
1. Click on **Contacts -> Find and Merge Duplicate Contacts**.
1. Click **Add rule for Individuals**.
1. Rule Name: Phone, Used: Unsupervised, Select field Phone and enter weight: 1, Threshhold: 1 and **Save**
1. Click **Contributions -> Import Contributions**
1. Upload any CSV file, choose defaults
1. Click Next
1. See that Phone is not listed in fields to import
Current behaviour
----------------------------------------
When the field mapper screen appears and you have an supervised dedupe rule with a phone field, you get a missing index error, a phantom "match to contact" option in the field list, and the phone field is not listed.
![phone-import-error](/uploads/26b39da7bed124937c3666d4fb275a03/phone-import-error.png)
Expected behaviour
----------------------------------------
The phone field should be listed (with "match to contact").
Environment information
----------------------------------------5.24.0https://lab.civicrm.org/dev/core/-/issues/1386Allow advanced search for contributions without a soft credit related2020-02-24T05:47:09ZfrancescbassasAllow advanced search for contributions without a soft credit relatedOverview
----------------------------------------
There isn't an easy way to search in advanced search, contributions that do not have a related soft credit.
Current behaviour
----------------------------------------
`Contributions OR S...Overview
----------------------------------------
There isn't an easy way to search in advanced search, contributions that do not have a related soft credit.
Current behaviour
----------------------------------------
`Contributions OR Soft Credits?` field allows to search:
- `Contributions Only` - All contributions
- `Soft Credits Only` - Only Soft Credits
- `Soft Credits with related Hard Credit` - Soft Credits + Hard Credits
- `Both` - All (standard) contributions and Soft Credits
![softcredit-search-option](/uploads/226448c8736e97b4c8fefddf7e5787c5/softcredit-search-option.png)
Proposed behaviour
----------------------------------------
Add a fifth option:
- `Contributions without a soft credit` - All contributions without a soft credit related
And rename other options so it becomes a bit more clear
- `Contributions Only`
- `Soft Credits Only`
- ~~Soft Credits with related Hard Credit~~ `Contributions and their related soft credit`
- ~~Both~~ `All`5.24.0https://lab.civicrm.org/dev/financial/-/issues/109Invoice does not assign/display the contact's country2020-03-01T20:27:10ZbgmInvoice does not assign/display the contact's countryTo reproduce:
* Enable Taxes and Invoicing
* Edit the "Contribution Invoice Receipt" message template to include `{$country}` (other related contact tokens are called `{$street_address}`, `{$email}`, etc.
* Go to a contact, create a con...To reproduce:
* Enable Taxes and Invoicing
* Edit the "Contribution Invoice Receipt" message template to include `{$country}` (other related contact tokens are called `{$street_address}`, `{$email}`, etc.
* Go to a contact, create a contribution, and from "view contribution", click "print PDF invoice" to view an invoice.
The country will be empty.5.24.0https://lab.civicrm.org/dev/core/-/issues/1522, as decimal separator, and [space] as thousand separators leads to api errors2020-03-17T22:27:15Zjaapjansma, as decimal separator, and [space] as thousand separators leads to api errors**Steps to reproduce**
1. At Administer --> Localisation --> Languages, Currencies and Location: set , as a decimal separator
2. At Administer --> Localisation --> Languages, Currencies and Location: Set space as thousand separator (So ...**Steps to reproduce**
1. At Administer --> Localisation --> Languages, Currencies and Location: set , as a decimal separator
2. At Administer --> Localisation --> Languages, Currencies and Location: Set space as thousand separator (So that 1234.56 is displayed as 1 234,56)
3. Go to api 3 explorer (Support --> Developers --> Api explorer v3)
4. Create a contribution with total_amount = 250.00 (keep the dot and the two zero's).
**Expected result**
Contribution created with a total amount of € 250,00
**Actual result**
Api error: `total_amount is not a valid amount: 250.00`
**Caused by**
This is caused by the statement in _https://github.com/civicrm/civicrm-core/blob/master/CRM/Utils/Rule.php#L603_
This statement expects at least . in either decimal separator or thousand separator.
```php
if ($config->monetaryDecimalPoint &&
$config->monetaryDecimalPoint != '.' &&
// CRM-7122 also check for Thousands Separator in config settings
$config->monetaryThousandSeparator != '.' &&
substr_count($value, '.')
) {
return FALSE;
}
```
**Analyses**
Below an analyses of the _contribution.create_ api with different localization settings and inputs.
| Currency | Decimal sep. | Thousand sep. | Contribution.create total_amount | Raw Value | Display as | 5.13 | 5.20 |
|----------|--------------|---------------|----------------------------------|------------|------------------|----------|----------|
| $ | . | , | 1,234,567.89 | 1234567.89 | $ 1,234,567.89 | OK | OK |
| $ | . | , | 1234567.89 | 1234567.89 | $ 1,234,567.89 | OK | OK |
| $ | . | [space] | 1 234 567.89 | 1234567.89 | $ 1 234 567.89 | OK | OK |
| $ | . | [space] | 1234567.89 | 1234567.89 | $ 1 234 567.89 | **Fail** | **Fail** |
| € | . | , | 1,234,567.89 | 1234567.89 | € 1,234,567.89 | OK | OK |
| € | . | , | 1234567.89 | 1234567.89 | € 1,234,567.89 | OK | OK |
| € | , | . | 1.234.567,89 | 1234567.89 | € 1.234.567,89 | OK | OK |
| € | , | . | 1234567.89 | 1234567.89 | € 1.234.567,89 | OK | OK |
| € | , | [space] | 1 234 567,89 | 1234567.89 | € 1 234 567,89 | OK | OK |
| € | , | [space] | 1234567.89 | 1234567.89 | € 1 234 567,89 | **Fail** | **Fail** |
| NOK | . | , | 1,234,567.89 | 1234567.89 | NOK 1,234,567.89 | OK | OK |
| NOK | . | , | 1234567.89 | 1234567.89 | NOK 1,234,567.89 | OK | OK |
| NOK | , | . | 1.234.567,89 | 1234567.89 | NOK 1.234.567,89 | OK | OK |
| NOK | , | . | 1234567.89 | 1234567.89 | NOK 1.234.567,89 | OK | OK |
| NOK | , | [space] | 1 234 567,89 | 1234567.89 | NOK 1 234 567,89 | OK | OK |
| NOK | , | [space] | 1234567.89 | 1234567.89 | NOK 1 234 567,89 | **Fail** | **Fail** |
**See also**
This bug is introduced by https://issues.civicrm.org/jira/browse/CRM-7122
**Question before fixing this**
What exactly is this if statement checking for? 5.23.0https://lab.civicrm.org/dev/core/-/issues/1640Update pending contribution status action also send email without warning2020-03-21T19:38:53ZjaapjansmaUpdate pending contribution status action also send email without warningWhen you search for contributions with status pending. You have an action to batch update all contribution statuses to completed. See screenshots
![Screenshot_from_2020-03-10_22-38-02](/uploads/e533c6e42f3ed4d1545f3855d3dd81b8/Screensho...When you search for contributions with status pending. You have an action to batch update all contribution statuses to completed. See screenshots
![Screenshot_from_2020-03-10_22-38-02](/uploads/e533c6e42f3ed4d1545f3855d3dd81b8/Screenshot_from_2020-03-10_22-38-02.png)
![Screenshot_from_2020-03-10_22-39-20](/uploads/d57cd774f224eb3ec62c73dc446628e7/Screenshot_from_2020-03-10_22-39-20.png)
When you do this the system also sends an email receipt to the donor.
**There is no warning about this e-mail.**
Possible solutions:
1. Checkbox for sending e-mails or not (this will give the user control)
2. A warning text indicating that this action also sends an e-mai.
I will see if I can work on option 1.jaapjansmajaapjansmahttps://lab.civicrm.org/dev/user-interface/-/issues/18Wrap separators in price field in spans with classes2020-05-14T00:17:14ZherbdoolWrap separators in price field in spans with classesThis is what it looks like now:
![Screenshot_from_2020-04-14_23-33-59](/uploads/41dd70e6e16b1305ed8fb8ca7abf3b6e/Screenshot_from_2020-04-14_23-33-59.png)
About 4 years ago a span and class were added to the "-" separator. But we should...This is what it looks like now:
![Screenshot_from_2020-04-14_23-33-59](/uploads/41dd70e6e16b1305ed8fb8ca7abf3b6e/Screenshot_from_2020-04-14_23-33-59.png)
About 4 years ago a span and class were added to the "-" separator. But we should have them on the colons as well. This will help with styling the form. This should be a simple PR.5.27.0herbdoolherbdoolhttps://lab.civicrm.org/dev/core/-/issues/989Allow Permissioned contact to download the invoice2020-05-20T14:10:30ZeileenAllow Permissioned contact to download the invoiceOverview
To Print other contact Invoice Logged in contact need 'access CiviContribute' permission
To Print own Invoice Logged in contact need 'view my invoices' Permission.
If user role only have 'view my invoices' permission and want to...Overview
To Print other contact Invoice Logged in contact need 'access CiviContribute' permission
To Print own Invoice Logged in contact need 'view my invoices' Permission.
If user role only have 'view my invoices' permission and want to print invoice of contact which have Permissioned relationship. It gives access denied message.
(e.g. Employee should print invoice of Employer contact if relationship is Permissioned)
Before
it was not allowing download invoice for Permissioned relationship contact.
After
It allow to download invoice for Permissioned relationship contact.
NOTE I'm opening this to track https://github.com/civicrm/civicrm-core/pull/13320 so I can close it - it hasn't been approved in concept so it's stalled in the PR queue. Most of the work for a change like this is in the unit test & in the approval negotiation so the PR is probably about 20% of the overall work & it makes more sense to remove from review queue for nowhttps://lab.civicrm.org/dev/financial/-/issues/125Allow individuals to download invoices for their organisation2020-05-20T14:10:48ZbgmAllow individuals to download invoices for their organisationMy use-case is the following:
* Membership is invoiced to the organization;
* A related contact (with view/edit permission) should be able to login and access the dashboard of the organization, download invoices.
Viewing the related or...My use-case is the following:
* Membership is invoiced to the organization;
* A related contact (with view/edit permission) should be able to login and access the dashboard of the organization, download invoices.
Viewing the related org's dashboard works, it displays the list of invoices and a download link, but clicking on the link results in an "Access Denied".