webtracking merge requestshttps://lab.civicrm.org/extensions/webtracking/-/merge_requests2022-01-03T23:10:47Zhttps://lab.civicrm.org/extensions/webtracking/-/merge_requests/1Fix tabsets on Manage Contribution Pages page2022-01-03T23:10:47ZJonGoldFix tabsets on Manage Contribution Pages pageOn the "Manage Contribution Pages" page, the action links are manipulated with bitwise operations against constants like `CRM_Core_Action::VIEW`. It relies on the tabset array's keys being a power of 2.
The `array_merge` I wrapped in a...On the "Manage Contribution Pages" page, the action links are manipulated with bitwise operations against constants like `CRM_Core_Action::VIEW`. It relies on the tabset array's keys being a power of 2.
The `array_merge` I wrapped in a conditional rewrites the array keys to be sequential from 0. This causes the link not to appear, but also removes other links ("Disable" and "Delete").
Because the bitwise operations make it all but impossible to inject a link there, and because it's already not showing up, this PR removes the code so at least "Disable" and "Delete" will show up.