webtracking merge requestshttps://lab.civicrm.org/extensions/webtracking/-/merge_requests2023-05-18T16:00:58Zhttps://lab.civicrm.org/extensions/webtracking/-/merge_requests/2Add support for GA42023-05-18T16:00:58ZbgmAdd support for GA4The old GA is deprecated, so this is an attempt at supporting GA4.
I tried to keep it fairly close to the original, but I don't know much about GA old/new APIs, so I mostly just implemented what I was asked to implement. The "ecommerce ...The old GA is deprecated, so this is an attempt at supporting GA4.
I tried to keep it fairly close to the original, but I don't know much about GA old/new APIs, so I mostly just implemented what I was asked to implement. The "ecommerce tracking" code in this PR is probably a bit confused at the moment (will fix it soon-ish).
I also need to track the `user_id`, so I might add a setting for supporting that, because it's an additional level of creepy / potential PII exchange.
(I think the previous implementation tried to be privacy-sensitive, but if a site is using a tool like GA, they probably don't care about privacy and just want to track their conversions and having too many options just creates incoherent data and confuses admins.)
cc @mattwire @JonGold fyihttps://lab.civicrm.org/extensions/webtracking/-/merge_requests/1Fix tabsets on Manage Contribution Pages page2022-01-03T23:10:47ZJonGoldFix tabsets on Manage Contribution Pages pageOn the "Manage Contribution Pages" page, the action links are manipulated with bitwise operations against constants like `CRM_Core_Action::VIEW`. It relies on the tabset array's keys being a power of 2.
The `array_merge` I wrapped in a...On the "Manage Contribution Pages" page, the action links are manipulated with bitwise operations against constants like `CRM_Core_Action::VIEW`. It relies on the tabset array's keys being a power of 2.
The `array_merge` I wrapped in a conditional rewrites the array keys to be sequential from 0. This causes the link not to appear, but also removes other links ("Disable" and "Delete").
Because the bitwise operations make it all but impossible to inject a link there, and because it's already not showing up, this PR removes the code so at least "Disable" and "Delete" will show up.