Add tests around getting enabled financial types?
(note to self)
In reading the code before breakfast today - it's how I like to start the day - I noticed in several places we do this:
$financialTypes = (array) CRM_Civigiftaid_Settings::getValue('financial_types_enabled')
I think the idea is that you want this to be like
[1,2,3] but because the setting is stored as a string (on 3.4.4 at least) then we're getting
['1,2,3'] which does not match anything.
This could lead to contributons being wrongly assumed ineligible. I plan to investigate.