ukgiftaid issueshttps://lab.civicrm.org/extensions/ukgiftaid/-/issues2020-11-26T18:00:36Zhttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/2Installer fails when re-installing2020-11-26T18:00:36ZRichInstaller fails when re-installingDuring testing I found I was unable to uninstall then reinstall. This is because uninstall does not remove the custom fields (which I think is reasonably sensible); and then reinstalling gets in a tangle with that xml file trying to recr...During testing I found I was unable to uninstall then reinstall. This is because uninstall does not remove the custom fields (which I think is reasonably sensible); and then reinstalling gets in a tangle with that xml file trying to recreate stuff.RichRichhttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/3Pop-up prompting user to add a Gift Aid declaration redirects to a 404 error2020-11-26T18:00:37ZmarcusjwilsonPop-up prompting user to add a Gift Aid declaration redirects to a 404 errorThis issue was reported by our client using v3.3.10:
The pop-up that prompts the user to add a Gift Aid declaration directs to a 404, of the format:
..../civicrm/contact/view/?reset=1&gid=3&cid=210206&selectedChild=custom_3This issue was reported by our client using v3.3.10:
The pop-up that prompts the user to add a Gift Aid declaration directs to a 404, of the format:
..../civicrm/contact/view/?reset=1&gid=3&cid=210206&selectedChild=custom_3https://lab.civicrm.org/extensions/ukgiftaid/-/issues/4Individual donation marked as "NO" from backend, gets included in batch- v3.42020-11-26T18:00:37ZtapashIndividual donation marked as "NO" from backend, gets included in batch- v3.4Scenario:
* Customer has an open GA declaration which was created online.
* He comes on premise and gives a donation and particularly request not to claim gift aid on it.
* Donation is manually marked as NO in the contribution section by...Scenario:
* Customer has an open GA declaration which was created online.
* He comes on premise and gives a donation and particularly request not to claim gift aid on it.
* Donation is manually marked as NO in the contribution section by a staff.
* When created a batch, donation gets added to the batch.
Would this be considered a bug or a feature on the new version of ext? Previously the extension has ignored it. Thankshttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/5Cannot do onlinesubmission2020-11-26T18:00:37ZtapashCannot do onlinesubmissionReceiving this error when click submit after validation: What could be reason for this Please?
Donations cannot be removed from batch and resubmitted either.
```
Status: Unknown
Department3001businessThe submission of this document has...Receiving this error when click submit after validation: What could be reason for this Please?
Donations cannot be removed from batch and resubmitted either.
```
Status: Unknown
Department3001businessThe submission of this document has failed due to departmental specific business logic in the Body tag.
ChRIS4999schemaInternal schema validation error
Please wait for 10 seconds then click on the Refresh link to get an update of the submission.
```
Log in drupal: `Notice: Undefined offset: 1 in HmrcGiftAid->packageDigest() (line 706 of /home/webadmin/public_html/cmm/sites/default/files/civicrm/ext/giftaidsubmission/govtalk/HmrcGiftAid.php).`
![Screenshot_2020-06-13_at_18.23.55](/uploads/b8157228f3f58444bc78860433f317ae/Screenshot_2020-06-13_at_18.23.55.png)https://lab.civicrm.org/extensions/ukgiftaid/-/issues/6PHP warnings when removing from batch2020-07-09T11:16:51ZtapashPHP warnings when removing from batchFor each donation there's a warning in drupal log when removing from batch:
`Warning: count(): Parameter must be an array or an object that implements Countable in include() (line 53 of /home/webadmin/public_html/cmm/sites/default/files...For each donation there's a warning in drupal log when removing from batch:
`Warning: count(): Parameter must be an array or an object that implements Countable in include() (line 53 of /home/webadmin/public_html/cmm/sites/default/files/civicrm/templates_c/en_GB/%%1D/1D7/1D7FFE0E%%RemoveFromBatch.tpl.php).`https://lab.civicrm.org/extensions/ukgiftaid/-/issues/7Upgrading to 3.4 fails2020-07-08T17:19:46ZTomCrawshawUpgrading to 3.4 failsI'm running Civi 5.26.2 and have tried upgrading GiftAid to 3.4. It appears to upgrade correctly, including running db updates with no logged errors, but deletes the previously existing reports (they can be rebuilt).
Secondly, the conf...I'm running Civi 5.26.2 and have tried upgrading GiftAid to 3.4. It appears to upgrade correctly, including running db updates with no logged errors, but deletes the previously existing reports (they can be rebuilt).
Secondly, the configuration screen is missing:
![Screenshot_2020-06-19_at_14.15.16](/uploads/dd7d7b0e1ea38586014713eb758fd237/Screenshot_2020-06-19_at_14.15.16.png)
Error log says:
Notice: Undefined variable: elementGroups in CRM_Civigiftaid_Form_Settings->buildQuickForm() (line 98 of .............../sites/default/files/civicrm/ext/uk.co.compucorp.civicrm.giftaid-3.0alpha3/CRM/Civigiftaid/Form/Settings.php).https://lab.civicrm.org/extensions/ukgiftaid/-/issues/8New contributions from recurring contributions inherit the batch from previou...2020-10-05T21:22:25ZcapoNew contributions from recurring contributions inherit the batch from previous onesWhen calling `repeattransaction` to generate a new recurring contribution from an existing one, the custom values are copied from the one that's being used as a template. As a result, the new contribution inherits the content of some fie...When calling `repeattransaction` to generate a new recurring contribution from an existing one, the custom values are copied from the one that's being used as a template. As a result, the new contribution inherits the content of some fields, such as the Gift Aid batch name.
### The Cause
The issue is being caused by [CRM_Contribute_BAO_ContributionRecur::copyCustomValues](https://github.com/civicrm/civicrm-core/blob/56f82bb1bf7afefe8d4cdd7dac3b56eff8b3c775/CRM/Contribute/BAO/ContributionRecur.php#L553), which is copying those values. That makes things hard, as this way of copying values doesn't trigger hooks.
### A Possible Fix
May the solution be to ensure the creation and usage of contribution templates that have the batch name empty?https://lab.civicrm.org/extensions/ukgiftaid/-/issues/9Donation marked as NO for memberships despite selected YES in declaration2023-07-10T14:49:52ZtapashDonation marked as NO for memberships despite selected YES in declarationStep to reproduce:
- Create a recurring donation via MEMBERSHIP contribution page with giftaid as YES
- A declaration created with YES, but the donation is marked as NOStep to reproduce:
- Create a recurring donation via MEMBERSHIP contribution page with giftaid as YES
- A declaration created with YES, but the donation is marked as NOhttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/10After installing version 3.4.2 on Civi 5.27.3 (on Drupal), profile problems2020-10-05T21:27:55ZatheiaAfter installing version 3.4.2 on Civi 5.27.3 (on Drupal), profile problemsHello,
I have installed the giftaid extension as described above. After adding the profile to a contribution page, the contribution page emits what looks like raw html code on screen (`<p>By selecting 'Yes' above you are confirming tha...Hello,
I have installed the giftaid extension as described above. After adding the profile to a contribution page, the contribution page emits what looks like raw html code on screen (`<p>By selecting 'Yes' above you are confirming that <ol> <li>you are a UK taxpayer and</li> <li>the amount of income and/or capital gains tax you pay is at least as much as we will reclaim on your donations in this tax year.</li> </ol> <p><b>About Gift Aid</b><p> <p>Gift Aid increases the value of donations to charities by allowing them to reclaim basic rate tax on your gift. We would like to reclaim gift aid on your behalf. We can only reclaim Gift Aid if you are a UK taxpayer. Please confirm that you are a eligible for gift aid above. <a href="http://www.hmrc.gov.uk/individuals/giving/gift-aid.htm">More about Gift Aid</a>.</p>`).
I figured this might be due to the post help field containing the escaped html characters rather than the symbols (e.g. `<` instead of `<`), so I went to edit that text. This resulted in the "are you eligible for UK Gift Aid? question disappearing.
Checking the field again, the Field Name had incorrectly set itself to Contribution :: Amount Label.
Setting it explicitly to Individual :: UK Tax Payer?::Gift Aid Declaration seems to have fixed it.
I'm not sure why either of these problems occurred, but it seems fixed in my deployment now?
Best wishes,
Alexhttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/11How to obtain a GA declaration from a donation based EVENT registration?2020-12-08T18:08:50ZtapashHow to obtain a GA declaration from a donation based EVENT registration?I thought it might be an easy task just by adding "Are you UK taxpyer" option to a profile. But unfortuntely once added that field the profile does not show up anymore for event registration.
Just wondering how can I obtain a declaratio...I thought it might be an easy task just by adding "Are you UK taxpyer" option to a profile. But unfortuntely once added that field the profile does not show up anymore for event registration.
Just wondering how can I obtain a declaration from an event registration please? Thankshttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/12Donation towards EVENT Not included a batch, although its marked as YES2020-11-26T18:08:54ZtapashDonation towards EVENT Not included a batch, although its marked as YESThis is my test case:
- Create a new financial type "Donation based Event" and include this in GA settings as eligible.
- Make this FT available for "Giftaid" custom field set.
- Create new event page with FT = "Donation based Event" and...This is my test case:
- Create a new financial type "Donation based Event" and include this in GA settings as eligible.
- Make this FT available for "Giftaid" custom field set.
- Create new event page with FT = "Donation based Event" and a price set that is considered as a donation and giftaidable (not fees).
- Submit an online registration, Contribution is marked as YES. But eligible amount is 0.
- Donor already have a giftaid declaration prior to this donation.
- When create a batch with this donation, its not included in batch.
![Screenshot_2020-08-21_at_19.14.12](/uploads/0a607b48c0b605ad4348507cb8ced2fe/Screenshot_2020-08-21_at_19.14.12.png)https://lab.civicrm.org/extensions/ukgiftaid/-/issues/13Weird and confusing declaration log & receipting when selected NO2023-08-02T06:18:51ZtapashWeird and confusing declaration log & receipting when selected NOHere's a case:
1. A declaration was created with **NO** from contribution page using older version of extension. Has a start date.
2. Donor gives a new donation via contribution page with **NO**. Older declaration is closed with current...Here's a case:
1. A declaration was created with **NO** from contribution page using older version of extension. Has a start date.
2. Donor gives a new donation via contribution page with **NO**. Older declaration is closed with current date. But weirdly a new declaration is created as **Yes.** with current open date. Source of contribution states **ERROR: Title not set**. In the **receipt** it declares as "**Eligible for giftaid: No**"
3. Donor gives another donation via contribution page with **NO**. 2nd declaration is still open as **YES** and new declaration is created as **NO**.
In the **receipt** it declares as "**Eligible for giftaid: No**"
4. On a different occassion, everytime a donation is submitted using **NO**, a new declaration with **NO** is created. I had 10 declaration of a contact with just **NO** on it.
Here's a glimps of the declaration below.
![Screenshot_2020-08-22_at_18.36.01](/uploads/857a1ac670be42aa485a3f6041927eab/Screenshot_2020-08-22_at_18.36.01.png)https://lab.civicrm.org/extensions/ukgiftaid/-/issues/14Enabling the extension removes the CiviCRM menu in Wordpress2021-03-07T21:12:45ZmarzastEnabling the extension removes the CiviCRM menu in WordpressI am running CiviCRM 5.29.0 on Wordpress 5.5.1. After I upgraded the UK Gift Aid extension to 3.4.4 the admin menu for CiviCRM has disappeared. The menu appears back when I disable the extension.
I think there might be an issue somewher...I am running CiviCRM 5.29.0 on Wordpress 5.5.1. After I upgraded the UK Gift Aid extension to 3.4.4 the admin menu for CiviCRM has disappeared. The menu appears back when I disable the extension.
I think there might be an issue somewhere within the extension itself.https://lab.civicrm.org/extensions/ukgiftaid/-/issues/15Address validation issue2020-11-25T18:24:37Zmattwiremjw@mjwconsult.co.ukAddress validation issueIn Scotland, lots of people have addresses that start with a 0, e.g. 0/3, 54 Made-up Street. In these instances, the address field for that contact is blank when added to a Gift Aid batch.
I can get around this by changing the address t...In Scotland, lots of people have addresses that start with a 0, e.g. 0/3, 54 Made-up Street. In these instances, the address field for that contact is blank when added to a Gift Aid batch.
I can get around this by changing the address to 'Flat 0/3' (which isn't strictly correct!), but I end up with 'Flat 0'.https://lab.civicrm.org/extensions/ukgiftaid/-/issues/16Contribution saved as eligible although the declaration was negative2020-11-04T19:35:46ZcapoContribution saved as eligible although the declaration was negativeIn some tests, the extension performed different than I expected in terms of what it saved in the contribution eligibility. A new contact sent a contribution saying no to Gift Aid, this occurred:
- the contact was created and a new Gift...In some tests, the extension performed different than I expected in terms of what it saved in the contribution eligibility. A new contact sent a contribution saying no to Gift Aid, this occurred:
- the contact was created and a new Gift Aid declaration is added to the contact record,
- the declaration has a clear no, as expected,
- but the corresponding contribution is created with a yes instead.
This was due to the fact that the contribution will store:
- 1 (yes) if the site has the option "all financial types are eligible for Gift Aid"
- 1 (yes) if the financial type of the contribution is set for Gift Aid eligibility
What I was expecting, instead, was:
- if the Gift Aid eligibility chosen by the contact was 1 or 3 (yes):
- if the contribution belongs to an eligible financial type, it will store a yes
- if the contribution belongs to a non-eligible financial type, it will store a no
...and, specially:
- if the Gift Aid eligibility chosen by the contact was 0 (no):
- regardless of its financial type, a no will be saved
Is this an intentioned behaviour? I haven't started preparing any merge request because I need to make sure I understand first how the extension is meant to work.https://lab.civicrm.org/extensions/ukgiftaid/-/issues/17Amount totals in Gift Aid Report are for 50 record subset, not total records ...2021-03-23T22:37:30ZTomCrawshawAmount totals in Gift Aid Report are for 50 record subset, not total records in BatchUnlike other reports, the Total amounts shown at the bottom of the Gift Aid report are just for the visible rows, not the total found. It appears the function "statistics(&$rows)" in CRM/Civigiftaid/Report/Form/Contribute/GiftAid.php is ...Unlike other reports, the Total amounts shown at the bottom of the Gift Aid report are just for the visible rows, not the total found. It appears the function "statistics(&$rows)" in CRM/Civigiftaid/Report/Form/Contribute/GiftAid.php is using the 50 visible rows, not the entire set, and needs to run its own query before returning the counts back in $statistics['counts']['giftaidamount'] etc.
This quick & dirty reworking of the function shows the correct amounts:
```php
public function statistics(&$rows) {
$statistics = parent::statistics($rows);
$totals = [
'contribution' => 0,
'eligibleAmount' => 0,
'giftAidAmount' => 0,
];
$statisticsQuery = "
COUNT({$this->_aliases['civicrm_value_gift_aid_submission']}.amount) as civicrm_contribution_total_amount_count,
SUM({$this->_aliases['civicrm_value_gift_aid_submission']}.amount) as civicrm_contribution_total_amount_sum,
SUM({$this->_aliases['civicrm_value_gift_aid_submission']}.gift_aid_amount) as civicrm_contribution_gift_aid_amount_sum
{$this->_from} {$this->_where}
";
$statisticsSQL = "SELECT {$statisticsQuery} {$this->_having}";
$statisticsDAO = CRM_Core_DAO::executeQuery($statisticsSQL);
while ($statisticsDAO->fetch()) {
$totals['contribution'] = $statisticsDAO->civicrm_contribution_total_amount_sum;
$totals['giftAidAmount'] = $statisticsDAO->civicrm_contribution_gift_aid_amount_sum;
}
$statistics['counts']['amount'] = [
'value' => $totals['contribution'],
'title' => 'Total Donation Amount',
'type' => CRM_Utils_Type::T_MONEY
];
$statistics['counts']['giftaidamount'] = [
'value' => $totals['giftAidAmount'],
'title' => 'Total Gift Aid Amount',
'type' => CRM_Utils_Type::T_MONEY
];
return $statistics;
}
```https://lab.civicrm.org/extensions/ukgiftaid/-/issues/18Editing GA declaration to add end date causes Civi to hang2023-08-11T16:20:13ZTomCrawshawEditing GA declaration to add end date causes Civi to hangRunning Drupal 7.73, CiviCRM 5.30, GA extension 3.4.5
Editing an existing GA declaration to add an end date results in session hanging (with spinning triangle), although the new end date is stored in database. Debugging console message ...Running Drupal 7.73, CiviCRM 5.30, GA extension 3.4.5
Editing an existing GA declaration to add an end date results in session hanging (with spinning triangle), although the new end date is stored in database. Debugging console message is:
[Error] Failed to load resource: the server responded with a status of 500 () (edit, line 0)
https://weyarun.org.uk/drupal_demo/civicrm/contact/view/cd/edit?tableId=12158&cid=12158&groupID=10&action=update&snippet=json
Other edits of the declaration appear to work as expected.https://lab.civicrm.org/extensions/ukgiftaid/-/issues/21Data too long for column 'source'2020-11-23T23:43:31ZcapoData too long for column 'source'The source of a declaration might end up being the title of the contribution page from which the contribution comes from. But:
- the length allowed for the title of a contribution page is 255 characters (see [xml/schema/Contribute/Contr...The source of a declaration might end up being the title of the contribution page from which the contribution comes from. But:
- the length allowed for the title of a contribution page is 255 characters (see [xml/schema/Contribute/ContributionPage.xml#L26](https://github.com/civicrm/civicrm-core/blob/1f7272b128156e8f948d8a0a86838aee57c4e021/xml/schema/Contribute/ContributionPage.xml#L26))
- and the length allowed for the source of a Gift Aid declaration is only 32 characters (see [CRM/Civigiftaid/Upgrader.php#L773](https://lab.civicrm.org/extensions/ukgiftaid/-/blob/3.4.5/CRM/Civigiftaid/Upgrader.php#L773)).
So a contribution sent through a contribution page titled: `Standard Donation Form for Donate Page`, would cause an error like:
```
Nov 16 22:37:09 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => UPDATE civicrm_value_gift_aid_declaration SET
entity_id=220799,eligible_for_gift_aid=3,address='1 Street',post_code='PS1 TA2',
start_date=20201116223703,given_date=20201116223703,
source='Standard Donation Form for Donate Page'
WHERE id=17066
[nativecode=1406 ** Data too long for column 'source' at row 1]
[type] => DB_Error
[user_info] => UPDATE civicrm_value_gift_aid_declaration SET
entity_id=220799,eligible_for_gift_aid=3,address='1 Street',post_code='PS1 TA2',
start_date=20201116223703,given_date=20201116223703,
source='Standard Donation Form for Donate Page'
WHERE id=17066
[nativecode=1406 ** Data too long for column 'source' at row 1]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::handle prefix="" info="UPDATE civicrm_value_gift_aid_declaration SET
entity_id=220799,eligible_for_gift_aid=3,address='1 Street',post_code='PS1 TA2',
start_date=20201116223703,given_date=20201116223703,
source='Standard Donation Form for Donate Page'
WHERE id=17066
[nativecode=1406 ** Data too long for column 'source' at row 1]"]
)
```https://lab.civicrm.org/extensions/ukgiftaid/-/issues/22Add tests around getting enabled financial types?2022-02-13T23:44:10ZRichAdd tests around getting enabled financial types?(note to self)
In reading the code before breakfast today - it's how I like to start the day - I noticed in several places we do this:
```
$financialTypes = (array) CRM_Civigiftaid_Settings::getValue('financial_types_enabled')
```
I t...(note to self)
In reading the code before breakfast today - it's how I like to start the day - I noticed in several places we do this:
```
$financialTypes = (array) CRM_Civigiftaid_Settings::getValue('financial_types_enabled')
```
I think the idea is that you want this to be like `[1,2,3]` but because the setting is stored as a string (on 3.4.4 at least) then we're getting `['1,2,3']` which does not match anything.
This could lead to contributons being wrongly assumed ineligible. I plan to investigate.RichRichhttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/25Donation cannot be validated with “Yes past 4 years” declaration2021-03-24T13:35:00ZtapashDonation cannot be validated with “Yes past 4 years” declarationThis was a test case where a new declaration was created of “Yes past 4 years” with current date.
2 individual Donation, one marked with yes, another with past 4 years within eligible section of the contribution.
None of them could b...This was a test case where a new declaration was created of “Yes past 4 years” with current date.
2 individual Donation, one marked with yes, another with past 4 years within eligible section of the contribution.
None of them could be validated for submission with an error “ INVALID DONOR DETAILS : ADDRESS DATA, Missing first line of address; Postcode invalid“, which is certainly not correct.
But if the declaration is changed to “Yes” and start date backdated to anywhere prior to contribution date, all works fine and batch could be submitted without any issues. I am on latest CiviCRM version, not sure if this has worked previously though. @mattwirehttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/26What permissions are required for this extension?2023-08-02T02:37:06ZtapashWhat permissions are required for this extension?Is there any specific permission required to get this extension work, particularly when the changes in declaration happen through a profile by an anonymous user? i.e. access to all custom field, profile listings, add profile, edit profi...Is there any specific permission required to get this extension work, particularly when the changes in declaration happen through a profile by an anonymous user? i.e. access to all custom field, profile listings, add profile, edit profile etc?
Would be very much appreciated if you could clarify please @mattwire @artfulrobot
Many thankshttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/27Add option value for new pseudoconstant2021-12-21T14:41:54ZeileenAdd option value for new pseudoconstant@mattwire @artfulrobot there is now an option group for the values that can be used in civicrm_entity_batch.entity_table.
From 5.42 on you will need an option value in this option group to support how giftaid uses this table
In order t...@mattwire @artfulrobot there is now an option group for the values that can be used in civicrm_entity_batch.entity_table.
From 5.42 on you will need an option value in this option group to support how giftaid uses this table
In order to support earlier versions you could use `ensureOptionGroupExists` with the same parameters as in https://lab.civicrm.org/dev/core/-/commit/b6d0c5b8efdc729fd1c63d3f25e1076d4acf9aa2 or conditionally add the option value if it DOES exist
https://lab.civicrm.org/dev/core/-/issues/2682https://lab.civicrm.org/extensions/ukgiftaid/-/issues/28Tests failing with 3.52022-05-23T11:25:20ZRichTests failing with 3.5Run on Civi 5.48.2: (with output from `phpunit7 --testdox`)
```
Summary of non-successful tests:
CRM_Civigiftaid_Declaration
✘ Set declaration logic with data set #0
│
│ Test set: existing no, adding a yes (also tests omitted ...Run on Civi 5.48.2: (with output from `phpunit7 --testdox`)
```
Summary of non-successful tests:
CRM_Civigiftaid_Declaration
✘ Set declaration logic with data set #0
│
│ Test set: existing no, adding a yes (also tests omitted given_date and provided given_date)
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #1
│
│ Test set: existing no, adding a yes past 4
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #3
│
│ Test set: existing yes, adding a no
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #4
│
│ Test set: existing yes past 4, adding a no
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #5
│
│ Test set: existing yes, adding a yes: Expect declr 1 to have reason_ended =
│ Failed asserting that two strings are equal.
│ --- Expected
│ +++ Actual
│ @@ @@
│ -''
│ +'(MISSING)'
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:189
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #6
│
│ Test set: existing yes, adding a yes past 4, but existing declaration is older than 4 years ago: Expect declr 1 to have reason_ended =
│ Failed asserting that two strings are equal.
│ --- Expected
│ +++ Actual
│ @@ @@
│ -''
│ +'(MISSING)'
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:189
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #7
│
│ Test set: existing yes, adding a yes past 4, but existing declaration is not older than 4 years ago Expect declr 1 to have start_date >= 2022-05-11 11:13:23
│ Failed asserting that '2020-05-01 00:00:00' is equal to '2022-05-11 11:13:23' or is greater than '2022-05-11 11:13:23'.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:184
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
FAILURES!
Tests: 30, Assertions: 191, Failures: 7.
```
EDIT: **This seems to be around the getPartialDeclaration logic in setDeclaration().**https://lab.civicrm.org/extensions/ukgiftaid/-/issues/29Installation fails with "'name,label,description' is not a valid option for f...2023-02-07T13:56:32Zaydunsaidan.saunders@squiffle.ukInstallation fails with "'name,label,description' is not a valid option for field option_value_fields" on 5.49+Attempting to install the extension fails with "'name,label,description' is not a valid option for field option_value_fields"
5.49 sets `option_value_fields` to `name,label,description`. The code assumes that values retrieved via api3 ...Attempting to install the extension fails with "'name,label,description' is not a valid option for field option_value_fields"
5.49 sets `option_value_fields` to `name,label,description`. The code assumes that values retrieved via api3 `get` can be fed directly to api3 `create`... which is not always true.https://lab.civicrm.org/extensions/ukgiftaid/-/issues/30two different currencies2022-06-16T08:49:21Zdavephassalltwo different currenciesWe are unable to create a batch and get the message "you can not add items of two different currencies to a single contribution batch". We are using UK Gift Aid 3.5.1 and civicrm 5.47.3 and all of our data is in sterling.
Thank youWe are unable to create a batch and get the message "you can not add items of two different currencies to a single contribution batch". We are using UK Gift Aid 3.5.1 and civicrm 5.47.3 and all of our data is in sterling.
Thank youhttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/31Address format wrong in report2023-02-07T13:54:22Zaydunsaidan.saunders@squiffle.ukAddress format wrong in reportIn the report, the address should be shown as "the house name or number and the postcode".
`CRM_Civigiftaid_Declaration::getDonorAddress()` returns a `house` field as the first part of the stored address up to a comma. This would wor...In the report, the address should be shown as "the house name or number and the postcode".
`CRM_Civigiftaid_Declaration::getDonorAddress()` returns a `house` field as the first part of the stored address up to a comma. This would work if the stored address was structured correctly.
But `getAddressAndPostalCode()` and `getFormattedAddress()` that are used to set the address on the declaration do not attempt to extract the house name or number.
There was some work on this in https://lab.civicrm.org/extensions/ukgiftaid/-/commit/7325f5dcf0d3cdf7189ba76c661ca5d254be1cfc
There was a regexp in `getHouseNo()` attempting to extract the house name/number but it was removed in that commit.
It seems the intent was to move the house number matching to the point where the address is stored on the declaration, rather than when the address is read from the declaration. But I don't see that the house name/number extraction made it to the declaration setting stage.
Before attempting to fix this, I'd like some confirmation that the intention is that the address stored on the declaration is a single string formatted such that the house name/number required for the report is the first part of the address up to a comma.https://lab.civicrm.org/extensions/ukgiftaid/-/issues/32API Giftaid.updatedeclarations overwrites existing declaration address with c...2022-06-30T16:41:13Zaydunsaidan.saunders@squiffle.ukAPI Giftaid.updatedeclarations overwrites existing declaration address with current address`Giftaid.updatedeclarations` overwrites an existing declaration address with the current address of the contact. The documentation says it updates missing addresses so I assumed that it would fill in missing addresses but not change exi...`Giftaid.updatedeclarations` overwrites an existing declaration address with the current address of the contact. The documentation says it updates missing addresses so I assumed that it would fill in missing addresses but not change existing ones on declarations.
Do you agree it should only be updating missing addresses?
Separately, but in the same function - why does it specifically disable logging before making these updates? I'd prefer to be able to track all changes in the log.https://lab.civicrm.org/extensions/ukgiftaid/-/issues/39Add Api4 Contribution.UpgradeGiftAid action - missing2023-07-31T17:31:33Zmattwiremjw@mjwconsult.co.ukAdd Api4 Contribution.UpgradeGiftAid action - missing@artfulrobot To track https://lab.civicrm.org/extensions/ukgiftaid/-/merge_requests/39#note_149537@artfulrobot To track https://lab.civicrm.org/extensions/ukgiftaid/-/merge_requests/39#note_149537