ukgiftaid issueshttps://lab.civicrm.org/extensions/ukgiftaid/-/issues2021-12-21T14:41:54Zhttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/27Add option value for new pseudoconstant2021-12-21T14:41:54ZeileenAdd option value for new pseudoconstant@mattwire @artfulrobot there is now an option group for the values that can be used in civicrm_entity_batch.entity_table.
From 5.42 on you will need an option value in this option group to support how giftaid uses this table
In order t...@mattwire @artfulrobot there is now an option group for the values that can be used in civicrm_entity_batch.entity_table.
From 5.42 on you will need an option value in this option group to support how giftaid uses this table
In order to support earlier versions you could use `ensureOptionGroupExists` with the same parameters as in https://lab.civicrm.org/dev/core/-/commit/b6d0c5b8efdc729fd1c63d3f25e1076d4acf9aa2 or conditionally add the option value if it DOES exist
https://lab.civicrm.org/dev/core/-/issues/2682https://lab.civicrm.org/extensions/ukgiftaid/-/issues/5Cannot do onlinesubmission2020-11-26T18:00:37ZtapashCannot do onlinesubmissionReceiving this error when click submit after validation: What could be reason for this Please?
Donations cannot be removed from batch and resubmitted either.
```
Status: Unknown
Department3001businessThe submission of this document has...Receiving this error when click submit after validation: What could be reason for this Please?
Donations cannot be removed from batch and resubmitted either.
```
Status: Unknown
Department3001businessThe submission of this document has failed due to departmental specific business logic in the Body tag.
ChRIS4999schemaInternal schema validation error
Please wait for 10 seconds then click on the Refresh link to get an update of the submission.
```
Log in drupal: `Notice: Undefined offset: 1 in HmrcGiftAid->packageDigest() (line 706 of /home/webadmin/public_html/cmm/sites/default/files/civicrm/ext/giftaidsubmission/govtalk/HmrcGiftAid.php).`
![Screenshot_2020-06-13_at_18.23.55](/uploads/b8157228f3f58444bc78860433f317ae/Screenshot_2020-06-13_at_18.23.55.png)https://lab.civicrm.org/extensions/ukgiftaid/-/issues/4Individual donation marked as "NO" from backend, gets included in batch- v3.42020-11-26T18:00:37ZtapashIndividual donation marked as "NO" from backend, gets included in batch- v3.4Scenario:
* Customer has an open GA declaration which was created online.
* He comes on premise and gives a donation and particularly request not to claim gift aid on it.
* Donation is manually marked as NO in the contribution section by...Scenario:
* Customer has an open GA declaration which was created online.
* He comes on premise and gives a donation and particularly request not to claim gift aid on it.
* Donation is manually marked as NO in the contribution section by a staff.
* When created a batch, donation gets added to the batch.
Would this be considered a bug or a feature on the new version of ext? Previously the extension has ignored it. Thankshttps://lab.civicrm.org/extensions/ukgiftaid/-/issues/8New contributions from recurring contributions inherit the batch from previou...2020-10-05T21:22:25ZcapoNew contributions from recurring contributions inherit the batch from previous onesWhen calling `repeattransaction` to generate a new recurring contribution from an existing one, the custom values are copied from the one that's being used as a template. As a result, the new contribution inherits the content of some fie...When calling `repeattransaction` to generate a new recurring contribution from an existing one, the custom values are copied from the one that's being used as a template. As a result, the new contribution inherits the content of some fields, such as the Gift Aid batch name.
### The Cause
The issue is being caused by [CRM_Contribute_BAO_ContributionRecur::copyCustomValues](https://github.com/civicrm/civicrm-core/blob/56f82bb1bf7afefe8d4cdd7dac3b56eff8b3c775/CRM/Contribute/BAO/ContributionRecur.php#L553), which is copying those values. That makes things hard, as this way of copying values doesn't trigger hooks.
### A Possible Fix
May the solution be to ensure the creation and usage of contribution templates that have the batch name empty?https://lab.civicrm.org/extensions/ukgiftaid/-/issues/6PHP warnings when removing from batch2020-07-09T11:16:51ZtapashPHP warnings when removing from batchFor each donation there's a warning in drupal log when removing from batch:
`Warning: count(): Parameter must be an array or an object that implements Countable in include() (line 53 of /home/webadmin/public_html/cmm/sites/default/files...For each donation there's a warning in drupal log when removing from batch:
`Warning: count(): Parameter must be an array or an object that implements Countable in include() (line 53 of /home/webadmin/public_html/cmm/sites/default/files/civicrm/templates_c/en_GB/%%1D/1D7/1D7FFE0E%%RemoveFromBatch.tpl.php).`