From d7b0e446fdd30355e485c6c0e7ebd6fe0ce8160a Mon Sep 17 00:00:00 2001
From: "Matthew Wire (MJW Consulting)" <mjw@mjwconsult.co.uk>
Date: Mon, 15 Oct 2018 17:27:21 +0100
Subject: [PATCH] Add some FIXME comments
---
CRM/Core/Payment/StripeIPN.php | 2 ++
1 file changed, 2 insertions(+)
diff --git a/CRM/Core/Payment/StripeIPN.php b/CRM/Core/Payment/StripeIPN.php
index e87a7a28..c974da52 100644
--- a/CRM/Core/Payment/StripeIPN.php
+++ b/CRM/Core/Payment/StripeIPN.php
@@ -404,6 +404,7 @@ class CRM_Core_Payment_StripeIPN extends CRM_Core_Payment_BaseIPN {
$query_params
);
+ // FIXME: MJW Do we need this custom handling for memberships here? Core should do all we need
if ($this->membership_id) {
$plan_elements = explode("-", $this->plan_id);
$plan_name_elements = explode("-", $this->plan_name);
@@ -581,6 +582,7 @@ class CRM_Core_Payment_StripeIPN extends CRM_Core_Payment_BaseIPN {
}
// Check for membership id.
+ // FIXME: MJW Not sure why we assign membership_id here
$membership = civicrm_api3('Membership', 'get', array(
'contribution_recur_id' => $this->contribution_recur_id,
));
--
GitLab