From 73b1b0a3ede7eede245eb193f53d1dc7cae242c3 Mon Sep 17 00:00:00 2001 From: Jamie McClelland <jm@mayfirst.org> Date: Wed, 22 Apr 2020 21:06:21 -0400 Subject: [PATCH] ensure membership contribution pages with required auto renew work https://lab.civicrm.org/extensions/stripe/issues/189 --- js/civicrm_stripe.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/js/civicrm_stripe.js b/js/civicrm_stripe.js index 227585e1..4cfb8f43 100644 --- a/js/civicrm_stripe.js +++ b/js/civicrm_stripe.js @@ -628,11 +628,14 @@ CRM.$(function($) { if ($('input[name="auto_renew"]').prop('checked')) { isRecur = true; } - else if (document.getElementById('auto_renew').type == 'hidden') { - isRecur = (document.getElementById('auto_renew').value == 1); + else if ($('input[name="auto_renew"]').attr('type') == 'hidden') { + // If the auto_renew field exists as a hidden field, then we force a + // recurring contribution (the value isn't useful since it depends on + // the locale - e.g. "Please renew my membership") + isRecur = true;; } else { - isRecur = Boolean(document.getElementById('auto_renew').checked); + isRecur = Boolean($('input[name="auto_renew"]').checked); } } debugging('isRecur is ' + isRecur); -- GitLab