"install_groupid" and "install_matching" issues
Created by: MegaphoneJon
Hi Andy,
I know you're done, but you said you'd be available for bugfixes. Let me know if you think this isn't something you'll get to.
In the code I noticed a couple of things about these two functions.
- They're called by the "enable" and "postInstall" hooks. If I understand them correctly, they should just run once, on
hook_civicrm_install
. - They don't have docblocks, so I'm actually not 100% sure. I see that
install groupid
creates the custom field group and field; I haven't investigated whatinstall_matching
does, but if you could add a docblock, it would help future maintainers of the code. -
hook_civicrm_uninstall
should have functions that reverse these functions (e.g. delete the custom field and group).
Thanks, Jon