From 59c27f9100a688406495601ad7557c610230b06e Mon Sep 17 00:00:00 2001 From: Matthew Wire <mjw@mjwconsult.co.uk> Date: Sun, 9 May 2021 12:17:31 +0100 Subject: [PATCH] Code cleanup --- CRM/Core/Payment/MJWIPNTrait.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CRM/Core/Payment/MJWIPNTrait.php b/CRM/Core/Payment/MJWIPNTrait.php index 810ccd5..e02214e 100644 --- a/CRM/Core/Payment/MJWIPNTrait.php +++ b/CRM/Core/Payment/MJWIPNTrait.php @@ -94,10 +94,12 @@ trait CRM_Core_Payment_MJWIPNTrait { * If not set, we respect the value set on the ContributionRecur entity (for recurring contributions) * or the value set on the ContributionPage entity (for non-recurring contributions). * + * @param int $contributionID + * * @return int * @throws \CiviCRM_API3_Exception */ - public function getSendEmailReceipt($contributionId) { + public function getSendEmailReceipt(int $contributionID) { if (isset($this->is_email_receipt)) { return (int) $this->is_email_receipt; } @@ -117,7 +119,7 @@ trait CRM_Core_Payment_MJWIPNTrait { try { $this->is_email_receipt = \Civi\Api4\Contribution::get(FALSE) ->addSelect('contribution_page.is_email_receipt') - ->addWhere('id', '=', $contributionId) + ->addWhere('id', '=', $contributionID) ->execute() ->first()['contribution_page.is_email_receipt'] ?? 0; } -- GitLab