Email Invoice Fatal Error
When using the "Email Invoice" button for a pending contribution, I was presented with a fatal error (PHP 8).
PHP Fatal error: Declaration of CRM_Invoicehelper_Contribute_Form_Task_Invoice::addActivities($subject, $contactIds, $fileName, $params) must be compatible with CRM_Contribute_Form_Task_Invoice::addActivities($subject, $contactIds, $fileName, $params, $contributionId = null) in /home/user/wp-content/uploads/civicrm/ext/invoicehelper-1.0/CRM/Invoicehelper/Contribute/Form/Task/Invoice.php on line 636
It seems that this ext's function is not matching the base function. They included the contribution id as a param and setting it if passed in.
I added the param to the function param list in a test environment and then added the if statement for the contribution as per core, but noticed that the Activity type is showing as "meeting" for my environment and not the "Emailed Invoice" activity type as expected. I noticed in core it is hard coded in, but see you are pulling from DAO.