GoCardless merge requestshttps://lab.civicrm.org/extensions/gocardless/-/merge_requests2020-02-03T13:04:15Zhttps://lab.civicrm.org/extensions/gocardless/-/merge_requests/69Fix issues with checkConfig2020-02-03T13:04:15Zmattwiremjw@mjwconsult.co.ukFix issues with checkConfig- Do not report errors via `setStatus()` - this is done by the calling function if required.
- Explicitly get the payment processor type details - `$this->_paymentProcessor['api.payment_processor_type.getsingle']` is not available in mo...- Do not report errors via `setStatus()` - this is done by the calling function if required.
- Explicitly get the payment processor type details - `$this->_paymentProcessor['api.payment_processor_type.getsingle']` is not available in most(?) cases. (Eg. when called from `\Civi\Payment\System::getByProcessor()`https://lab.civicrm.org/extensions/gocardless/-/merge_requests/48Issue/47 - multiple accounts2019-06-21T09:11:50ZRichIssue/47 - multiple accounts*Created by: artfulrobot*
Please test*Created by: artfulrobot*
Please test1.8https://lab.civicrm.org/extensions/gocardless/-/merge_requests/46Fix for issue 452019-06-21T09:10:03ZRichFix for issue 45*Created by: artfulrobot*
Assumed input params to be strings and comparing with `==` but the membership forms include nested arrays with numeric keys. Since 'some string' evaluates to 0, `0 == 'some string'` and the first string tested ...*Created by: artfulrobot*
Assumed input params to be strings and comparing with `==` but the membership forms include nested arrays with numeric keys. Since 'some string' evaluates to 0, `0 == 'some string'` and the first string tested was first name, so that got clobbered. Using `===` instead has solved this.https://lab.civicrm.org/extensions/gocardless/-/merge_requests/44Membership tests and fix2018-11-15T22:12:14ZRichMembership tests and fix*Created by: aydun*
I've added some tests for memberships in the first commit which shows a problem.
The second commit fixes that.
For background, see analysis by @wmortada in #42*Created by: aydun*
I've added some tests for memberships in the first commit which shows a problem.
The second commit fixes that.
For background, see analysis by @wmortada in #42v1.6 stablehttps://lab.civicrm.org/extensions/gocardless/-/merge_requests/41Minor changes to fix typos and improve readability2018-10-10T13:10:37ZRichMinor changes to fix typos and improve readability*Created by: wmortada*
Just made a few very minor tweaks to help improve the README.*Created by: wmortada*
Just made a few very minor tweaks to help improve the README.https://lab.civicrm.org/extensions/gocardless/-/merge_requests/25doPaymentsFailed() refers to wrong variable2018-10-10T09:56:11ZRichdoPaymentsFailed() refers to wrong variable*Created by: wmortada*
This looks like a typo to me. The function doPaymentsFailed() refers to a variable $update but this isn't defined. I think it should refer to $contribution.
I haven't tested this myself, but spotted it while r...*Created by: wmortada*
This looks like a typo to me. The function doPaymentsFailed() refers to a variable $update but this isn't defined. I think it should refer to $contribution.
I haven't tested this myself, but spotted it while reading through the code.https://lab.civicrm.org/extensions/gocardless/-/merge_requests/36Limiting the number of payments/installments as per issue 34.2018-05-10T13:44:30ZRichLimiting the number of payments/installments as per issue 34.*Created by: stesi561*
Introduces a basic validation negative number of installments not allowed.
Create variable to hold parameters for api call to GoCardless instead of doing inline to allow passing of optional paramenters.
If n...*Created by: stesi561*
Introduces a basic validation negative number of installments not allowed.
Create variable to hold parameters for api call to GoCardless instead of doing inline to allow passing of optional paramenters.
If number of payments is present add "installments" to params to Go Cardless call.
Update Readme.https://lab.civicrm.org/extensions/gocardless/-/merge_requests/30Update README.md2018-03-08T09:41:05ZRichUpdate README.md*Created by: petednz*
added info re which frequencies are allowed*Created by: petednz*
added info re which frequencies are allowedhttps://lab.civicrm.org/extensions/gocardless/-/merge_requests/13Allow > 1 intervals2017-01-18T10:50:31ZRichAllow > 1 intervals*Created by: wpf500*
I noticed that the `$interval_interval` is ~never used~~ (correction: is used to update the `ContributionRecur` record, but not sent to GC), at the moment this means that if a recurring contribution was supposed to ...*Created by: wpf500*
I noticed that the `$interval_interval` is ~never used~~ (correction: is used to update the `ContributionRecur` record, but not sent to GC), at the moment this means that if a recurring contribution was supposed to occur once every 2 months, it would still be set up in GoCardless at once a month.
This PR adds `interval` support (renamed from `interval_interval` for consistency), and checks that the interval that has been specified isn't greater than a year (which isn't allowed with direct debits)https://lab.civicrm.org/extensions/gocardless/-/merge_requests/11Store qfKey in session2017-01-18T10:50:31ZRichStore qfKey in session*Created by: wpf500*
In the changes that involved merging #9 something broke when using CiviCRM's contribution forms. The `session_token` was only previously ever checked against GoCardless I think, whereas now its assumed that it is st...*Created by: wpf500*
In the changes that involved merging #9 something broke when using CiviCRM's contribution forms. The `session_token` was only previously ever checked against GoCardless I think, whereas now its assumed that it is stored in the session. https://lab.civicrm.org/extensions/gocardless/-/merge_requests/9Correctly update membership after redirect flow2017-01-17T19:03:00ZRichCorrectly update membership after redirect flow*Created by: wpf500*
Hi, thanks for sharing this plugin, its exactly what I needed!
I found an issue when using it for recurring memberships where the membership would never get updated. I'm new to CiviCRM so what I've changed might ...*Created by: wpf500*
Hi, thanks for sharing this plugin, its exactly what I needed!
I found an issue when using it for recurring memberships where the membership would never get updated. I'm new to CiviCRM so what I've changed might not make sense but it seems to work!
I switched the test for `membershipID` vs `contributionRecurID` around because it seems that in the case of recurring memberships both exist, and the `ContributionRecur` record holds all the information needed (including the `amount`) so there's no need to query the `Contribution` record.
I also noticed that the field `amount` doesn't exist for a `Contribution`, so I switched that to `total_amount`.