Skip to content

Membership should be handled by CiviCRM not this extension

Created by: wmortada

This extension updates the membership directly using the API. I don't believe that it should do this. This extension should just handle the payments, the business logic around membership should be handled by CiviCRM.

I believe that this may be causing a number of issues with memberships:

  • #27 Membership since date is getting changed
  • start_date and join_date are overwritten on renewal
  • end_date is extended twice on renewal (this extension extends the end date while the payment is pending, CiviCRM extends it again when the payment clears)

All of the business logic around membership is triggered when the extension makes API requests to completetransaction and repeattransaction when a webhook is received.

I spent some time looking at this extension during the UK CiviCRM sprint and was hoping to follow this up subsequently but haven't had the time yet unfortunately. If I get time, I would like to follow this up in future but in the meantime I wanted to at least record my understanding of the problem here.