Unable to alter financial type of recurring contribution
It is not possible to change the financial type of a recurring contribution without also changing the amount. In this scenario we only want to change the financial type in CiviCRM. We don't want to make any changes to the subscription in GoCardless.
We are unable to do this because of the logic in CRM_Core_Payment_GoCardless::changeSubscriptionAmount().
Steps to reproduce:
- Visit the recurring contribution tab of a contact record
- Click edit next to a recurring contribution
- Change the financial type of the recurring contribution only
- Click save
- You will see the following error: "The given amount is the same as the current amount. Refusing to update subscription without a change in amount."
I understand the logic of not touching the GoCardless subscription if the amount doesn't change. However, in this case we only want to change the CiviCRM record and not update anything in GoCardless. I think the logic should be changed to identify if the change only affects CiviCRM and in which case just update the CiviCRM record without making a change in GoCardless.