GoCardless issueshttps://lab.civicrm.org/extensions/gocardless/-/issues2021-09-06T17:31:00Zhttps://lab.civicrm.org/extensions/gocardless/-/issues/123CiviCRM 5.40, 5.41 support or test fixes2021-09-06T17:31:00ZRichCiviCRM 5.40, 5.41 support or test fixes5.39 broke tests, and some core functionality.
In 5.40 we have other problems including at least one new one: creating a membership in the past seems to fail now - Civi is setting the membership start date to today.5.39 broke tests, and some core functionality.
In 5.40 we have other problems including at least one new one: creating a membership in the past seems to fail now - Civi is setting the membership start date to today.1.11.1 - Support CiviCRM 5.39, 5.40https://lab.civicrm.org/extensions/gocardless/-/issues/122Upgrader task needed to support start-date feature2021-08-26T10:42:18ZnicolUpgrader task needed to support start-date feature5.40.2 + GC 1.11.0 gave an error "Warning: Invalid argument supplied for foreach() in /home/x/public_html/media/civicrm/ext/uk.artfulrobot.civicrm.gocardless/CRM/GoCardlessUtils.php on line 526". This was fixed by going to the admin › co...5.40.2 + GC 1.11.0 gave an error "Warning: Invalid argument supplied for foreach() in /home/x/public_html/media/civicrm/ext/uk.artfulrobot.civicrm.gocardless/CRM/GoCardlessUtils.php on line 526". This was fixed by going to the admin › contribute » gc settings page and saving. ([mattermost ref](https://chat.civicrm.org/civicrm/pl/hp75etjsnfgoxdydygawytqoxh))1.11.1 - Support CiviCRM 5.39, 5.40https://lab.civicrm.org/extensions/gocardless/-/issues/120CiviCRM 5.39 support2021-08-02T01:10:52ZRichCiviCRM 5.39 supportThe tests do not pass on 5.39.
```
There were 3 errors:
1) GoCardlessTest::testWebhookPaymentConfirmationFirst
CiviCRM_API3_Exception: Not having valid line items for membership payments is invalid.
/buildkit/build/dmaster/web/sites/a...The tests do not pass on 5.39.
```
There were 3 errors:
1) GoCardlessTest::testWebhookPaymentConfirmationFirst
CiviCRM_API3_Exception: Not having valid line items for membership payments is invalid.
/buildkit/build/dmaster/web/sites/all/modules/civicrm/api/api.php:134
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:281
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:196
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/tests/phpunit/GoCardlessTest.php:935
/buildkit/extern/phpunit7/phpunit7.phar:615
2) GoCardlessTest::testWebhookPaymentConfirmationSubsequent
CiviCRM_API3_Exception: Not having valid line items for membership payments is invalid.
/buildkit/build/dmaster/web/sites/all/modules/civicrm/api/api.php:134
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:465
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:297
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:196
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/tests/phpunit/GoCardlessTest.php:1069
/buildkit/extern/phpunit7/phpunit7.phar:615
3) GoCardlessTest::testWebhookPaymentConfirmationDoesNotMarkCancelledAsInProgress
CiviCRM_API3_Exception: Not having valid line items for membership payments is invalid.
/buildkit/build/dmaster/web/sites/all/modules/civicrm/api/api.php:134
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:465
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:297
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/CRM/Core/Payment/GoCardlessIPN.php:196
/buildkit/build/dmaster/web/sites/default/files/civicrm/ext/gocardless/tests/phpunit/GoCardlessTest.php:1201
/buildkit/extern/phpunit7/phpunit7.phar:615
ERRORS!
Tests: 37, Assertions: 198, Errors: 3.
```1.11.1 - Support CiviCRM 5.39, 5.40RichRich