Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C CDNTaxReceipts
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • CDNTaxReceipts
  • Issues
  • #125
Closed
Open
Created Sep 25, 2021 by DaveD@DaveDMaintainer1 of 8 tasks completed1/8 tasks

Evaluate how 5.43 treats the extension's use of BAO_MessageTemplate and the alterMailParams hook

As per recent dev-digest.

Preliminary review:

  • For the hook, there's already a note in the code that the hook is called multiple times, so maybe it's already handling that well enough. Check what happens.
  • We look up and create $contact['email_greeting_display'] and pass it with tplParams. Need to check:
    • is this even needed - possibly there was no email greeting token at the time this was written? Can we just use the core token? Or does the core token do something weird?
    • noting that if it were needed this isn't the same $contact as the $contact that is no longer being passed by core. The other one is when you do something like Find Contacts - Actions - Send Email.
    • If we were to switch to the core one, need an upgrade script to update people's templates. Maybe this alone makes it not worth using the core one if there's no need.
  • Replace valueName with workflow_name. Note in the hook that won't be available until 5.43 so need to support both for a bit.
  • Should it use civicrm_api3('MessageTemplate', 'send') instead of the BAO? Something else?
  • Unit tests. There was some issue in the carrot environment with using delivery_method=email. Can't remember. Maybe it was just mink tests since CiviMailUtils should work for regular tests anywhere.
Edited Sep 25, 2021 by DaveD
Assignee
Assign to
Time tracking