Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • WordPress WordPress
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • DevelopmentDevelopment
  • WordPressWordPress
  • Issues
  • #49
Closed
Open
Issue created May 06, 2020 by kcristiano@kcristianoMaintainer

CiviCRM front end pages broken on WP Latest (master)

WordPress just committed bug fixes redirect_canonical() in their master branch. The history is as follows:

Original redirect_canonical issues and patches :

ticket 11694

svn 34492

2020 redirect_canonical issues :

ticket 45337

ticket 40773

ticket 28081

2020 redirect_canonical svn patches:

svn 47727

svn 47760

svn 47761

svn 47759

2020 redirect_canonical Git patches:

47727

47760

47761

47759

changelog for canonical.php

These WP changes are correct, the root of the issue is that CiviCRM used page=CiviCRM was used on the front end. It should only have been used on the back end. We've gotten away with this for 8 years, it's now time to fix.

The issue is that canonical_redirect() now properly strips page=CiviCRM from front end pages.

https://wplatest.tadpole.cc is an example site running master of both WP and CiviCRM. CiviCRM pages built with shortcode pages load, but if you take action - try and contribute, submit a profile, click on a link to register on an event info page - 404.

Pages that are linbked to directly - cleanurls or ugly urls, 404.

We need to remove page=CiviCRM from the front end pages.

We need to do this before WP updates and we need to backport to ESR as this will break all WP CiviCRM sites.

There is no way understate that if we do dont fix ALL WP Sites will break on update. And if WP does this as aminor release that gets pushed out via auto-update 💥 💣

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking